OSDN Git Service
Bill Yi [Tue, 20 Aug 2019 19:38:42 +0000 (12:38 -0700)]
[automerger skipped] Merge "Import translations. DO NOT MERGE" into qt-r1-dev am:
7892f729a5 -s ours
am:
5188a0560f -s ours
am skip reason: subject contains skip directive
Change-Id: I36bfd0b4831c53650425409c1b18ef3d26db248a
Arc Wang [Tue, 20 Aug 2019 19:25:41 +0000 (12:25 -0700)]
Merge "[Wi-Fi] Fix multi SIM devices switch to mobile data automatically settings missing problem" into qt-r1-dev am:
54dbed859d
am:
2394d0821b
Change-Id: Ife8a564c622b03983a9f5a557e2762bc3cd969e2
Bill Yi [Sat, 17 Aug 2019 16:45:15 +0000 (09:45 -0700)]
[automerger skipped] Merge "Import translations. DO NOT MERGE" into qt-r1-dev
am:
7892f729a5 -s ours
am skip reason: subject contains skip directive
Change-Id: I02568545b0452c41a81daf515960665dbf7516cc
TreeHugger Robot [Sat, 17 Aug 2019 16:30:21 +0000 (16:30 +0000)]
Merge "Import translations. DO NOT MERGE" into qt-r1-dev
Arc Wang [Sat, 17 Aug 2019 14:17:59 +0000 (07:17 -0700)]
Merge "[Wi-Fi] Fix multi SIM devices switch to mobile data automatically settings missing problem" into qt-r1-dev
am:
54dbed859d
Change-Id: I19214265a783f092bb183b3341aa1c2116f3188f
TreeHugger Robot [Sat, 17 Aug 2019 13:58:53 +0000 (13:58 +0000)]
Merge "[Wi-Fi] Fix multi SIM devices switch to mobile data automatically settings missing problem" into qt-r1-dev
Bill Yi [Sat, 17 Aug 2019 08:35:46 +0000 (01:35 -0700)]
Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Bug:
64712476
Change-Id: Ie3771d039d46900090a8a4f58f325b9a5eb29e0a
Kevin Chyn [Sat, 17 Aug 2019 03:01:16 +0000 (20:01 -0700)]
Merge "Update attention string" into qt-r1-dev am:
e218dc0517
am:
5725d33471
Change-Id: Ic8302db945bdf128bb04eda2ba6105abe6083ce0
Kevin Chyn [Sat, 17 Aug 2019 02:42:52 +0000 (19:42 -0700)]
Merge "Update attention string" into qt-r1-dev
am:
e218dc0517
Change-Id: I0fd8c3a1ea66dde8eefc934cd3265cbb6fbafe0f
Kevin Chyn [Sat, 17 Aug 2019 02:01:31 +0000 (02:01 +0000)]
Merge "Update attention string" into qt-r1-dev
Arc Wang [Mon, 12 Aug 2019 12:11:13 +0000 (20:11 +0800)]
[Wi-Fi] Fix multi SIM devices switch to mobile data automatically settings missing problem
Context#getResources loading is done based on the last SIM to
come up, we may get wrong customization settings.
This fix check the setting of active subscription and shows the preference.
Bug:
138956509
Test: CellularFallbackPreferenceControllerTest
manual test:
1. Insert feature supported SIM and check UI.
2. Remove feature supported SIM and check UI.
3. Turn airplane mode on and check 1. and 2..
Change-Id: I72b6db415429181395a02f163889bb1b9c0f070f
Merged-In: I72b6db415429181395a02f163889bb1b9c0f070f
Kevin Chyn [Fri, 16 Aug 2019 23:34:01 +0000 (16:34 -0700)]
Update attention string
Bug:
139484065
Test: manual
Change-Id: Ie4619fb51709ba2651866b7841dd4d6b51f165d1
Yi Jiang [Tue, 13 Aug 2019 01:51:42 +0000 (18:51 -0700)]
Merge "Don't show suggestion slice if 'Screen attention' is already on" into qt-qpr1-dev
am:
7933af0273
Change-Id: Iecc58066521d19bb58514eca667a5f4daecbe0de
Yi Jiang [Tue, 13 Aug 2019 01:28:31 +0000 (01:28 +0000)]
Merge "Don't show suggestion slice if 'Screen attention' is already on" into qt-qpr1-dev
Arc Wang [Thu, 8 Aug 2019 08:30:51 +0000 (01:30 -0700)]
[Wi-Fi] Remove unsupported EAP methods for WPA3-Enterprise 192-bit
am:
bde8c0a64d
Change-Id: Ib7dc37d80825346c6c024c84f450f8762c21b3ef
Arc Wang [Mon, 5 Aug 2019 07:20:42 +0000 (15:20 +0800)]
[Wi-Fi] Remove unsupported EAP methods for WPA3-Enterprise 192-bit
1. Only support EAP-TLS for WPA3-Enterprise 192-bit
2. Remove "Do not validate" from the CA certificate menu
3. Remove "Do not provide" from user certificate menu
Bug:
135127581
Test: WifiConfigControllerTest
Change-Id: Ibf904da9407ec803afb8bb995e9df1a2e25f0dcb
Merged-In: Ibf904da9407ec803afb8bb995e9df1a2e25f0dcb
Yi Jiang [Tue, 16 Jul 2019 00:14:33 +0000 (17:14 -0700)]
Don't show suggestion slice if 'Screen attention' is already on
Bug:
137259771
Fix:
137259771
Test: Manually
Change-Id: I5568b569ecd4db943f1a239c7ddcd2923bec4028
(cherry picked from commit
06f0bd6d4ee02656954016b3bc1a63f16dfad17b)
Merged-In: I5568b569ecd4db943f1a239c7ddcd2923bec4028
Christine Franks [Sun, 4 Aug 2019 08:37:50 +0000 (01:37 -0700)]
Merge "[DO NOT MERGE] Update title for null uri when setting changes" into qt-r1-dev am:
37b38f872f
am:
31cc369a4d
Change-Id: I578907b141f2a6a705473394e16519507997caa8
Christine Franks [Sun, 4 Aug 2019 08:32:21 +0000 (01:32 -0700)]
[DO NOT MERGE] Update title for null uri when setting changes am:
ea14373666
am:
c48918dac0
Change-Id: I268d4d01a515e1c49b83e3c321af230cb06bffc9
Christine Franks [Sun, 4 Aug 2019 07:53:35 +0000 (00:53 -0700)]
Merge "[DO NOT MERGE] Update title for null uri when setting changes" into qt-r1-dev
am:
37b38f872f
Change-Id: Ie2b1e884d7501fb1d37ce816a5f4c78042be6300
Christine Franks [Sun, 4 Aug 2019 07:53:29 +0000 (00:53 -0700)]
[DO NOT MERGE] Update title for null uri when setting changes
am:
ea14373666
Change-Id: Idca3e0d0855ced876f4bd891739e0141ec86a777
Christine Franks [Sat, 3 Aug 2019 14:47:40 +0000 (14:47 +0000)]
Merge "[DO NOT MERGE] Update title for null uri when setting changes" into qt-r1-dev
Christine Franks [Thu, 1 Aug 2019 18:09:16 +0000 (11:09 -0700)]
[DO NOT MERGE] Update title for null uri when setting changes
Currently, the title will not update at all if set to silent.
Bug:
130445562
Test: make RunSettingsRoboTests -j48
Change-Id: Id8fc0182adb37c05436f5924b7dcdffb9d994e0d
Edgar Wang [Fri, 2 Aug 2019 06:00:15 +0000 (23:00 -0700)]
Merge "Add skip lock screen in Notification & security lock screen settings" into qt-r1-dev am:
8e3b202070
am:
063cc34713
Change-Id: Ic856426092578e47418498de40e22aa484badb19
Edgar Wang [Fri, 2 Aug 2019 05:49:22 +0000 (22:49 -0700)]
Merge "Add skip lock screen in Notification & security lock screen settings" into qt-r1-dev
am:
8e3b202070
Change-Id: Ib1cf35ee24f88a9eae71714349fe40cb982214b0
Edgar Wang [Fri, 2 Aug 2019 05:38:23 +0000 (05:38 +0000)]
Merge "Add skip lock screen in Notification & security lock screen settings" into qt-r1-dev
Daniel Solomon [Thu, 1 Aug 2019 20:51:28 +0000 (13:51 -0700)]
Merge "Settings: change the color mode preview image" into qt-r1-dev am:
c5fbd7b669
am:
8e699b6ec8
Change-Id: I077cdf4c165158aa927f4d1aa0632b6c343b2fb2
Daniel Solomon [Thu, 1 Aug 2019 20:38:20 +0000 (13:38 -0700)]
Merge "Settings: change the color mode preview image" into qt-r1-dev
am:
c5fbd7b669
Change-Id: I719cdde36a264519900584b9835d5c6e70cc5818
TreeHugger Robot [Thu, 1 Aug 2019 19:58:47 +0000 (19:58 +0000)]
Merge "Settings: change the color mode preview image" into qt-r1-dev
Youming Ye [Thu, 1 Aug 2019 18:58:55 +0000 (11:58 -0700)]
Check the missing useHomeWfMode case am:
b7923f5a3f
am:
84049d217d
Change-Id: I101a0d837a4912e316c3cd25f6f829d15cbc8745
Youming Ye [Thu, 1 Aug 2019 18:27:48 +0000 (11:27 -0700)]
Check the missing useHomeWfMode case
am:
b7923f5a3f
Change-Id: I81aadd772a8c8b07ca6c967868789aa91fe0dba9
Edgar Wang [Mon, 29 Jul 2019 08:55:31 +0000 (16:55 +0800)]
Add skip lock screen in Notification & security lock screen settings
Users may have trouble finding this setting in face auth.
Heard this from dogfood/executive feedback and customer support discussion.
So add Skip Lock Screen preference in
Display > Lock screen display > What to show >
and
App & Notifications > Notifications > Lock Screen >
Bug:
138458558
Test: robotest & manual
Change-Id: I10e420821423821743d65b00c8b7e6d4d1224e00
Youming Ye [Tue, 11 Jun 2019 22:25:52 +0000 (15:25 -0700)]
Check the missing useHomeWfMode case
Bug:
133812904
Test: Build
Change-Id: If89c67c0595808a1339517c6084f1d1e23f5974b
Merged-In: If89c67c0595808a1339517c6084f1d1e23f5974b
Antony Sargent [Wed, 31 Jul 2019 23:05:35 +0000 (16:05 -0700)]
Merge "Protect entry points to add an eSIM when admin restricted" into qt-r1-dev am:
4685c785b9
am:
ad2f49f851
Change-Id: I7a87b32111936ce805f90cf68b7cbe7c8df498f9
Bill Yi [Wed, 31 Jul 2019 23:04:50 +0000 (16:04 -0700)]
[automerger skipped] Import translations. DO NOT MERGE am:
5a690f3c4c -s ours
am:
1ccff0ddc6 -s ours
am skip reason: subject contains skip directive
Change-Id: I69d8e92cdbaca6f83a068ed2507b623728c8eac3
Antony Sargent [Wed, 31 Jul 2019 22:56:00 +0000 (15:56 -0700)]
Merge "Protect entry points to add an eSIM when admin restricted" into qt-r1-dev
am:
4685c785b9
Change-Id: I5792ff5333005e2e0c66fd24d594b79bf67d140c
Bill Yi [Wed, 31 Jul 2019 22:53:52 +0000 (15:53 -0700)]
[automerger skipped] Import translations. DO NOT MERGE
am:
5a690f3c4c -s ours
am skip reason: subject contains skip directive
Change-Id: Ic10bfa052664715f150c09abfc3f0015aa530ee8
TreeHugger Robot [Wed, 31 Jul 2019 22:39:22 +0000 (22:39 +0000)]
Merge "Protect entry points to add an eSIM when admin restricted" into qt-r1-dev
Antony Sargent [Wed, 31 Jul 2019 19:53:39 +0000 (12:53 -0700)]
Protect entry points to add an eSIM when admin restricted
If the DISALLOW_CONFIG_MOBILE_NETWORKS admin policy is set, we were
accidentally still allowing access to the flow where you add an eSIM
subscription via the "plus" button on the Network & internet page. While
fixing this, I also noticed that the mobile networks list page (which
only becomes available if you have multiple subscriptions) has a link at
the bottom to start the flow as well, and that wasn't being protected.
The fix for the plus button on the Network & internet page was just to
make sure not to call setEnabled(true) if the preference was already
disabled by admin policy, since that has the effect of overriding the
admin-disabling.
The fix for the mobile networks list page just needed to add the
relevant tags in the layout XML, and then we get it for free.
Fixes:
137627845
Test: make RunSettingsRoboTests
Change-Id: I896ac248f50aaeecc157791938a0a0a98265aa07
Daniel Solomon [Wed, 31 Jul 2019 18:46:39 +0000 (11:46 -0700)]
Settings: change the color mode preview image
Change the color mode preview image to better illustrate the difference
between Natural and Boosted color modes.
Bug:
138126243
Test: manual testing on Pixel
Change-Id: I367b383f9f2da9b2e2d5960e51c3ec7821d4915b
Bill Yi [Wed, 31 Jul 2019 19:09:08 +0000 (12:09 -0700)]
Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Bug:
64712476
Change-Id: I3e51c61d9bdff182bc83a04242ccd6e1e4f9629d
Quang Luong [Wed, 31 Jul 2019 00:35:06 +0000 (17:35 -0700)]
Merge "Default MAC address should display "Not Available" in network details" into qt-r1-dev am:
17908b1e8f
am:
5c4a0e3444
Change-Id: I68a1a9451dda22ab32baf6bae395c0368b1f9b9b
Quang Luong [Wed, 31 Jul 2019 00:16:00 +0000 (17:16 -0700)]
Merge "Default MAC address should display "Not Available" in network details" into qt-r1-dev
am:
17908b1e8f
Change-Id: Ie1cdb83f47bac988b93401b3994a096d85333ce6
TreeHugger Robot [Tue, 30 Jul 2019 23:33:22 +0000 (23:33 +0000)]
Merge "Default MAC address should display "Not Available" in network details" into qt-r1-dev
Antony Sargent [Tue, 30 Jul 2019 22:58:21 +0000 (15:58 -0700)]
Merge "Make EnabledNetworkModePreferenceController listen to setting changes" into qt-r1-dev am:
66208e734b
am:
5a39d48ab2
Change-Id: Id51073c918d19403b47cc0bf21964a122d6cadf3
Bill Yi [Tue, 30 Jul 2019 22:57:25 +0000 (15:57 -0700)]
[automerger skipped] Merge "Import translations. DO NOT MERGE" into qt-r1-dev am:
67afe87617 -s ours
am:
1b86d59384 -s ours
am skip reason: subject contains skip directive
Change-Id: I2aa2952eec13d8c7fcb0ae1eeb437e780ef8c818
Antony Sargent [Tue, 30 Jul 2019 22:43:32 +0000 (15:43 -0700)]
Merge "Make EnabledNetworkModePreferenceController listen to setting changes" into qt-r1-dev
am:
66208e734b
Change-Id: I7e1494a1859393844ad5810a9721bf3865ed5f75
Bill Yi [Tue, 30 Jul 2019 22:42:25 +0000 (15:42 -0700)]
[automerger skipped] Merge "Import translations. DO NOT MERGE" into qt-r1-dev
am:
67afe87617 -s ours
am skip reason: subject contains skip directive
Change-Id: I253e0acc117f894554878c91ba084cca775eb7bd
TreeHugger Robot [Tue, 30 Jul 2019 22:33:32 +0000 (22:33 +0000)]
Merge "Make EnabledNetworkModePreferenceController listen to setting changes" into qt-r1-dev
TreeHugger Robot [Tue, 30 Jul 2019 21:39:43 +0000 (21:39 +0000)]
Merge "Import translations. DO NOT MERGE" into qt-r1-dev
Antony Sargent [Tue, 30 Jul 2019 17:10:57 +0000 (10:10 -0700)]
Make EnabledNetworkModePreferenceController listen to setting changes
The controller for the "Preferred network type" preference on the SIM
details page wasn't listening for changes to the underlying global
setting, so changes to the setting would be reflected in SysUI but not
on this page if it happened to be showing.
Bug:
135667565
Test: make RunSettingsRoboTests
Change-Id: I5dfe4843a681c613f49caf4584e9dbebc54e708a
Bill Yi [Tue, 30 Jul 2019 19:03:57 +0000 (12:03 -0700)]
[automerger skipped] Import translations. DO NOT MERGE am:
9af3e6a625 -s ours am:
f5c8056f7a -s ours
am:
3cda841897 -s ours
am skip reason: subject contains skip directive
Change-Id: I8670a31858f74816775f9ca91e799e08719d7284
Bill Yi [Tue, 30 Jul 2019 18:55:38 +0000 (11:55 -0700)]
Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Bug:
64712476
Change-Id: Id8561f757b8520ebbd976cc9b06fa833b68575d8
Bill Yi [Tue, 30 Jul 2019 18:47:09 +0000 (11:47 -0700)]
[automerger skipped] Import translations. DO NOT MERGE am:
9af3e6a625 -s ours
am:
f5c8056f7a -s ours
am skip reason: subject contains skip directive
Change-Id: I8d700ef074dff397a3e02cca8945935a549c77df
Bill Yi [Tue, 30 Jul 2019 18:43:40 +0000 (11:43 -0700)]
[automerger skipped] Merge "Import translations. DO NOT MERGE" into qt-r1-dev am:
f63cb669ff -s ours
am:
50dc17d8bc -s ours
am skip reason: subject contains skip directive
Change-Id: I594fbdb0e5eea0247dfa12fd5eff51677627e41c
Bill Yi [Tue, 30 Jul 2019 18:32:38 +0000 (11:32 -0700)]
[automerger skipped] Merge "Import translations. DO NOT MERGE" into qt-r1-dev
am:
f63cb669ff -s ours
am skip reason: subject contains skip directive
Change-Id: Ia87ca65aaf5bf3f43c2d15b944bdf06a74f857c6
Bill Yi [Tue, 30 Jul 2019 18:32:37 +0000 (11:32 -0700)]
[automerger skipped] Import translations. DO NOT MERGE
am:
9af3e6a625 -s ours
am skip reason: subject contains skip directive
Change-Id: Ic131b3c52fc5f2c0bd1b735a376df65108490f5e
TreeHugger Robot [Tue, 30 Jul 2019 18:09:15 +0000 (18:09 +0000)]
Merge "Import translations. DO NOT MERGE" into qt-r1-dev
Antony Sargent [Tue, 30 Jul 2019 17:28:26 +0000 (10:28 -0700)]
Merge "Refesh mobile network details page on carrier config changes" into qt-r1-dev am:
985d3d570d
am:
42861b21c9
Change-Id: I0f3fae2daf7c5df5985e2fd6597fdf563fdb095c
Antony Sargent [Tue, 30 Jul 2019 16:54:25 +0000 (09:54 -0700)]
Merge "Refesh mobile network details page on carrier config changes" into qt-r1-dev
am:
985d3d570d
Change-Id: Ic653102f8f66c0f5e1e3457750cdf150f1dbfd5e
TreeHugger Robot [Tue, 30 Jul 2019 16:41:29 +0000 (16:41 +0000)]
Merge "Refesh mobile network details page on carrier config changes" into qt-r1-dev
Bill Yi [Tue, 30 Jul 2019 00:02:13 +0000 (17:02 -0700)]
Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Bug:
64712476
Change-Id: Ie730f2fa36caf0c3d99159cc649ed7e24ca2ceec
Bill Yi [Mon, 29 Jul 2019 23:46:49 +0000 (16:46 -0700)]
Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Bug:
64712476
Change-Id: Idbe888a8bb4d386d7d8e883cc530561c1a5806ad
Julia Reynolds [Mon, 29 Jul 2019 20:23:00 +0000 (13:23 -0700)]
Merge "Move channel listing into a pref controller" into qt-qpr1-dev
am:
2d035ddfa2
Change-Id: Ice7a48d0fdad00b8d1f09a1da1fe39d5a8d85e79
TreeHugger Robot [Mon, 29 Jul 2019 18:42:25 +0000 (18:42 +0000)]
Merge "Move channel listing into a pref controller" into qt-qpr1-dev
TreeHugger Robot [Mon, 29 Jul 2019 02:28:37 +0000 (02:28 +0000)]
Merge "Fix launching of work profile notif settings" into qt-qpr1-dev
Jason Chiu [Sat, 27 Jul 2019 01:44:26 +0000 (18:44 -0700)]
Merge "Fix DISALLOW_AMBIENT_DISPLAY blocks access to all lock screen display settings" into qt-r1-dev
am:
04ad8c905a
Change-Id: I2c87041fb5575dfd621f4a9539653342c75d544f
TreeHugger Robot [Sat, 27 Jul 2019 01:29:55 +0000 (01:29 +0000)]
Merge "Fix DISALLOW_AMBIENT_DISPLAY blocks access to all lock screen display settings" into qt-r1-dev
Kevin Chyn [Sat, 27 Jul 2019 01:15:41 +0000 (18:15 -0700)]
[automerger skipped] Do not request cancel authentication unless currently authenticating am:
49c7d07650 -s ours
am:
587d8d7005 -s ours
am skip reason: change_id I6521e896d0402fe856dc85476f51149c9b3084a8 with SHA1
0a33d62a17 is in history
Change-Id: I14cf7941c761c973d6c9297d366c213aeae4cbcf
Kevin Chyn [Sat, 27 Jul 2019 01:14:19 +0000 (18:14 -0700)]
Add ability to finish() ConfirmDeviceCredential if it loses foreground
am:
e27a304b97
Change-Id: Ie695769418adfd316d608a2e23ed45e7237d28ce
Kevin Chyn [Sat, 27 Jul 2019 00:50:13 +0000 (17:50 -0700)]
[automerger skipped] Do not request cancel authentication unless currently authenticating
am:
49c7d07650 -s ours
am skip reason: change_id I6521e896d0402fe856dc85476f51149c9b3084a8 with SHA1
0a33d62a17 is in history
Change-Id: If5e6d4c715b0c3482f297c709320e2ca9f6fa209
Kevin Chyn [Fri, 26 Jul 2019 21:53:20 +0000 (14:53 -0700)]
Add ability to finish() ConfirmDeviceCredential if it loses foreground
If user enters face settings but does not enter the password, then
turns off the screen, it's possible the challenge is invalidated. Instead,
we should finish() the device credential screen as well as FaceSettings.
This prevents
1) The user from being prompted for credential with lack of context
2) Credential returning a HAT that wraps an invalidated challenge
The user will be returned to the security settings screen, where they
have more context and can decide if they want to enter face settings again.
Fixes:
138273242
Test: 1) Open face settings, do not enter password
2) Press power button
3) Unlock keyguard
4) User is not presented with credential screen
Test: Go through SUW, turning on/off the screen at various security
screens. Able to enroll successfully
Change-Id: I3c3d4600138012821bb0eea7d2927df00011cdb0
Kevin Chyn [Fri, 26 Jul 2019 19:35:30 +0000 (12:35 -0700)]
Merge "Do not request cancel authentication unless currently authenticating" into qt-r1-dev
am:
ba4fad160d
Change-Id: Ie71d66f43e21821b0ccac003d02878f011e63f18
Julia Reynolds [Mon, 1 Jul 2019 17:44:39 +0000 (13:44 -0400)]
Move channel listing into a pref controller
And a hidden preference category. This makes
hiding/showing the list a lot cleaner and also allows more
of the code to be tested.
Also delete some unused code that no longer complied after
this refactor.
Fixes:
133443871
Test: atest
Change-Id: I4a5fe0e075019bae2df44a0a9dcec26a40ee6d12
(cherry picked from commit
a295d71c94fbf9411f6ee6062de39aa34a574375)
Julia Reynolds [Wed, 12 Jun 2019 15:39:39 +0000 (11:39 -0400)]
Fix launching of work profile notif settings
Test: manual
Fixes:
132289017
Change-Id: I3c177aae1f4dd46556b652253d24b225d01987eb
(cherry picked from commit
142920e0c228427000a46e13aa2945796f2ef626)
Kevin Chyn [Fri, 26 Jul 2019 18:20:10 +0000 (11:20 -0700)]
Do not request cancel authentication unless currently authenticating
Currently we always send cancel() if ConfirmDeviceCredentialActivity
goes into the background. However, if the biometric state is no longer
authenticating, requesting cancel() in this state will result in an
inconsistent state between BiometricService/client and
ConfirmDeviceCredentials.
BiometricService/client will receive the ERROR_CANCELED message incorrectly,
while ConfirmDeviceCredential is showing / pending user password. When
the password is entered, its result is ignored.
The correct behavior is for ConfirmDeviceCredentialActivity to invoke
cancel() only if it's still authenticating. Otherwise BiometricService
and its client will receive ERROR_CANCELED, instead of the actual password
auth result.
Bug:
138279856
Test: BiometricPromptDemo, enable device credential fallback, get into
lockout state, successfully enter password. API result is
success instead of "canceled" now.
Change-Id: I6521e896d0402fe856dc85476f51149c9b3084a8
Merged-In: I6521e896d0402fe856dc85476f51149c9b3084a8
Kevin Chyn [Fri, 26 Jul 2019 19:15:50 +0000 (19:15 +0000)]
Merge "Do not request cancel authentication unless currently authenticating" into qt-r1-dev
Antony Sargent [Fri, 12 Jul 2019 18:04:14 +0000 (11:04 -0700)]
Refesh mobile network details page on carrier config changes
In general the mobile network details page has several preference
controllers that don't listen to carrier config changes, so instead of
having each one add a listener, we instead just have one listener and
refresh the entire page when we see the broadcast.
Fixes:
135587885
Test: make RunSettingsRoboTests
Change-Id: Iff5b28dbfe12d94c901b442b23cece8e68218983
Bill Yi [Fri, 26 Jul 2019 18:22:30 +0000 (11:22 -0700)]
[automerger skipped] Merge "Import translations. DO NOT MERGE" into qt-r1-dev
am:
8b9c85f0cd -s ours
am skip reason: subject contains skip directive
Change-Id: I3dabad25e5640239b491c864a999156156e77552
Kevin Chyn [Fri, 26 Jul 2019 18:20:10 +0000 (11:20 -0700)]
Do not request cancel authentication unless currently authenticating
Currently we always send cancel() if ConfirmDeviceCredentialActivity
goes into the background. However, if the biometric state is no longer
authenticating, requesting cancel() in this state will result in an
inconsistent state between BiometricService/client and
ConfirmDeviceCredentials.
BiometricService/client will receive the ERROR_CANCELED message incorrectly,
while ConfirmDeviceCredential is showing / pending user password. When
the password is entered, its result is ignored.
The correct behavior is for ConfirmDeviceCredentialActivity to invoke
cancel() only if it's still authenticating. Otherwise BiometricService
and its client will receive ERROR_CANCELED, instead of the actual password
auth result.
Bug:
138279856
Test: BiometricPromptDemo, enable device credential fallback, get into
lockout state, successfully enter password. API result is
success instead of "canceled" now.
Change-Id: I6521e896d0402fe856dc85476f51149c9b3084a8
TreeHugger Robot [Fri, 26 Jul 2019 17:39:58 +0000 (17:39 +0000)]
Merge "Import translations. DO NOT MERGE" into qt-r1-dev
Bill Yi [Fri, 26 Jul 2019 01:34:18 +0000 (18:34 -0700)]
Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Bug:
64712476
Change-Id: I84fe706da2873676a567287114abc4e6a27c158c
Jason Chiu [Thu, 25 Jul 2019 08:23:12 +0000 (16:23 +0800)]
Fix DISALLOW_AMBIENT_DISPLAY blocks access to all lock screen display settings
"Ambient display" was merged into "Lock screen display", and the entry
was also moved from security page to display page and leveraged the
original user restriction of "Ambient display".
The user restriction should just work on the switch of Ambient display
instead of the "Lock screen display" entry.
Bug:
138177691
Test: robotest, visual
Change-Id: I5db0eb68c3aa6f4f7d8ecd42db2cdc72255b12f7
Peiyong Lin [Thu, 25 Jul 2019 00:25:14 +0000 (17:25 -0700)]
Remove prerelease driver option from Settings UI. am:
c2dfba01ca
am:
7c5bb0ecda
Change-Id: Icfe7daa49feffd7b46b887d41e34615c8c0df6f9
Peiyong Lin [Wed, 24 Jul 2019 23:59:33 +0000 (16:59 -0700)]
Remove prerelease driver option from Settings UI.
am:
c2dfba01ca
Change-Id: Ia0f23e48d9ed4ad10d01bebe23d4b8cdd62458c3
Raff Tsai [Wed, 24 Jul 2019 12:20:40 +0000 (05:20 -0700)]
Fix crash after uninstalling app
am:
637d419157
Change-Id: Ib68843298dfcb71de6198a988f153397aabeb7f3
Raff Tsai [Fri, 28 Jun 2019 10:17:14 +0000 (18:17 +0800)]
Fix crash after uninstalling app
updateState was invoked in loader callback. But the
package was uninstalled at the callback time caused
null pointer exception. Add null check to prevent
null pointer access.
Fixes:
136170218
Fixes:
133771724
Test: make RunSettingsRoboTests, manual
Change-Id: I2715e77f6e32af42a4bce70c9f409b0311eb36c4
(cherry picked from commit
790a822526251236af196c3ae17f1990c75fb133)
Joshua Mccloskey [Wed, 24 Jul 2019 04:49:40 +0000 (21:49 -0700)]
Merge "Add extra check for accessibility flow." into qt-r1-dev
am:
c563fbb979
Change-Id: I0d84937b8029a8bdcec920123501fcb81f99f02f
Joshua Mccloskey [Tue, 23 Jul 2019 23:54:38 +0000 (23:54 +0000)]
Merge "Add extra check for accessibility flow." into qt-r1-dev
Peiyong Lin [Tue, 23 Jul 2019 17:27:47 +0000 (10:27 -0700)]
Remove prerelease driver option from Settings UI.
BUG:
134881329
Test: Verified with Settings UI.
Change-Id: Id610cbaec9b9a5a8be201e7952cb7715d2fe2eb4
Bill Yi [Tue, 23 Jul 2019 20:19:18 +0000 (13:19 -0700)]
Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Bug:
64712476
Change-Id: I81487d87626426a7b7a969314691a6ce1177df4b
joshmccloskey [Tue, 23 Jul 2019 00:10:55 +0000 (17:10 -0700)]
Add extra check for accessibility flow.
Bug:
138197084
Test: Verified other accessibility features like Live Transcribe does
not bring the user to the accessibility flow.
Test: Verified that the Sound Amplifier does not bring the user to
the accessibility flow.
Change-Id: I5131d74926c0b01c565da280c55afe0080855688
Yanting Yang [Tue, 23 Jul 2019 16:37:45 +0000 (09:37 -0700)]
Merge "Support new regulatory label for location" into qt-dev
am:
28736bee5d
Change-Id: I0a966698855aa935b6acbf3829988d5004ff57e2
TreeHugger Robot [Tue, 23 Jul 2019 16:12:52 +0000 (16:12 +0000)]
Merge "Support new regulatory label for location" into qt-dev
TreeHugger Robot [Tue, 23 Jul 2019 10:07:36 +0000 (10:07 +0000)]
Merge "Use the date format to show the system update info" into qt-r1-dev
Quang Luong [Fri, 19 Jul 2019 18:28:03 +0000 (11:28 -0700)]
Default MAC address should display "Not Available" in network details
For saved networks that do not have a MAC address available in their
WifiConfiguration such as Passpoint networks, the MAC address will
be the default value of 20:00:00:00:00:00. In this case, display
"Not Available" as the summary of the MAC address preference.
Bug:
137282522
Test: atest WifiDetailPreferenceControllerTest &&
manual - open saved passpoint network details while disconnected
but in range and observe MAC address preference.
Change-Id: Ie9010b0430726de8105852ae2afe10047dcc3676
Mehdi Alizadeh [Mon, 22 Jul 2019 23:17:48 +0000 (23:17 +0000)]
Merge "Removes logic to disable gesture nav when default home app changes" into qt-r1-dev
Bill Yi [Mon, 22 Jul 2019 19:53:25 +0000 (12:53 -0700)]
[automerger skipped] Import translations. DO NOT MERGE
am:
7d966975ad -s ours
am skip reason: subject contains skip directive
Change-Id: I494a50f37bc0ae4d4d7979756fc067f575057224
Bill Yi [Mon, 22 Jul 2019 17:59:39 +0000 (10:59 -0700)]
Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Bug:
64712476
Change-Id: I0369197f24082cadfbb6b3ac72d33243231090ac
Bill Yi [Mon, 22 Jul 2019 17:37:18 +0000 (10:37 -0700)]
Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Bug:
64712476
Change-Id: If2b98e7c7fadad3c2fb18275ed458da76e9cc7ac