OSDN Git Service

android-x86/external-toybox.git
11 years agoAdding -s (single shot) and -o (omit pids) options to pidof
Elie De Brauwer [Sat, 8 Dec 2012 19:10:05 +0000 (20:10 +0100)]
Adding -s (single shot) and -o (omit pids) options to pidof

11 years agoSet executable bits on two test scripts.
Rob Landley [Sun, 9 Dec 2012 19:20:16 +0000 (13:20 -0600)]
Set executable bits on two test scripts.

11 years agoAdding sha1sum tests based on RFC 3174
Elie De Brauwer [Sat, 8 Dec 2012 13:40:17 +0000 (14:40 +0100)]
Adding sha1sum tests based on RFC 3174

11 years agoAdding tests for cat
Elie De Brauwer [Sat, 8 Dec 2012 12:28:40 +0000 (13:28 +0100)]
Adding tests for cat

11 years agoAdd README file to each toys/ directory, teach build infrastructure to get fancy...
Rob Landley [Sun, 9 Dec 2012 03:10:10 +0000 (21:10 -0600)]
Add README file to each toys/ directory, teach build infrastructure to get fancy name from that. This means adding new directories shouldn't require touching build scripts.

11 years agoComplicate the rm -i behavior to do what posix specifies.
Rob Landley [Sat, 8 Dec 2012 08:26:56 +0000 (02:26 -0600)]
Complicate the rm -i behavior to do what posix specifies.

11 years agoMake yesno() always read from stdin and write to stderr. (If we need to find our...
Rob Landley [Sat, 8 Dec 2012 08:25:32 +0000 (02:25 -0600)]
Make yesno() always read from stdin and write to stderr. (If we need to find our tty, open /dev/tty, but existing users don't.)

11 years agoNew rm command.
Rob Landley [Fri, 7 Dec 2012 12:26:21 +0000 (06:26 -0600)]
New rm command.

11 years agoUpdate link to posix in docs (open group broke their website).
Rob Landley [Thu, 6 Dec 2012 21:15:30 +0000 (15:15 -0600)]
Update link to posix in docs (open group broke their website).

11 years agoHave dirtree_add_node() set parent so error message can provide full path.
Rob Landley [Thu, 6 Dec 2012 21:13:30 +0000 (15:13 -0600)]
Have dirtree_add_node() set parent so error message can provide full path.

11 years agoUse sched_{set,get}affinity directly so musl doesn't have to provide wrappers.
Rob Landley [Mon, 3 Dec 2012 22:16:06 +0000 (16:16 -0600)]
Use sched_{set,get}affinity directly so musl doesn't have to provide wrappers.

11 years agoMinor whitespace tweak.
Rob Landley [Sun, 2 Dec 2012 00:30:48 +0000 (18:30 -0600)]
Minor whitespace tweak.

11 years agoFirst guess at what internationalization support for expand would look like.
Rob Landley [Sun, 2 Dec 2012 00:30:20 +0000 (18:30 -0600)]
First guess at what internationalization support for expand would look like.

11 years agoGenerate status page with new pubs.opengroup.org urls.
Rob Landley [Sun, 2 Dec 2012 00:27:37 +0000 (18:27 -0600)]
Generate status page with new pubs.opengroup.org urls.

11 years agoRemove unused structure definition.
Rob Landley [Sun, 2 Dec 2012 00:26:58 +0000 (18:26 -0600)]
Remove unused structure definition.

11 years agoThe open group changed their website stupidly, so opengroup.org/onlinepubs forwards...
Rob Landley [Sun, 2 Dec 2012 00:26:21 +0000 (18:26 -0600)]
The open group changed their website stupidly, so opengroup.org/onlinepubs forwards to a dead server and you have to use pubs.opengroup.org/onlinepubs now. Change the hello template to note the new location. (Waiting to see if they fix it upstream before touching every command in toys/posix.)

11 years agoAdd header that musl libc needs.
Rob Landley [Sun, 2 Dec 2012 00:12:06 +0000 (18:12 -0600)]
Add header that musl libc needs.

11 years agoFix ancient glibc workaround to force fstatat64
Rob Landley [Sat, 1 Dec 2012 23:59:38 +0000 (17:59 -0600)]
Fix ancient glibc workaround to force fstatat64

11 years agoMinor cleanup: unify two codepaths that do the same thing.
Rob Landley [Sat, 1 Dec 2012 17:03:52 +0000 (11:03 -0600)]
Minor cleanup: unify two codepaths that do the same thing.

11 years agoWould the compiler like to warn me about declaring two variables with the same name...
Rob Landley [Sat, 1 Dec 2012 16:53:03 +0000 (10:53 -0600)]
Would the compiler like to warn me about declaring two variables with the same name in the same function? No? Carry on then...

11 years agoFelix Janda pointed out that the r in mbrtowc() stands for "restartable" so it's...
Rob Landley [Sat, 1 Dec 2012 06:42:01 +0000 (00:42 -0600)]
Felix Janda pointed out that the r in mbrtowc() stands for "restartable" so it's already buffering the partial data we feed it, so rolling back most of the last commit to wc.

11 years agoRe-add backspace support to expand (oops) and fix test to expect data plus backspace...
Rob Landley [Sat, 1 Dec 2012 06:21:37 +0000 (00:21 -0600)]
Re-add backspace support to expand (oops) and fix test to expect data plus backspace characters rather than the chracters cancelling each other out before output.

11 years agoLargeish rewrite of expand, mostly described on the mailing list.
Rob Landley [Fri, 30 Nov 2012 08:41:52 +0000 (02:41 -0600)]
Largeish rewrite of expand, mostly described on the mailing list.

11 years agomd5sum tests from RFC 1321
Rob Landley [Thu, 29 Nov 2012 04:56:16 +0000 (22:56 -0600)]
md5sum tests from RFC 1321

11 years agoUse the specified compiler for preprocessing.
Rob Landley [Thu, 29 Nov 2012 02:44:52 +0000 (20:44 -0600)]
Use the specified compiler for preprocessing.

11 years agoThe previous wc -m didn't handle multibyte characters that crossed a buffer boundary...
Rob Landley [Wed, 28 Nov 2012 09:12:02 +0000 (03:12 -0600)]
The previous wc -m didn't handle multibyte characters that crossed a buffer boundary, so take a guess at making that work. (I haven't got a test case for this. I also don't know how to handle invalid sequences so just don't count them.)

11 years agologin: Avoid gcc to drop exit condition because of "always false condition".
Jonathan Clairembault [Tue, 27 Nov 2012 10:09:04 +0000 (11:09 +0100)]
login: Avoid gcc to drop exit condition because of "always false condition".

11 years agoFirst round of expand cleanups.
Rob Landley [Tue, 27 Nov 2012 19:55:57 +0000 (13:55 -0600)]
First round of expand cleanups.

11 years agoexpand: handle backspace.
Jonathan Clairembault [Fri, 23 Nov 2012 08:24:53 +0000 (09:24 +0100)]
expand: handle backspace.

11 years agoAdd expand command as described in POSIX-2008.
Jonathan Clairembault [Thu, 22 Nov 2012 23:06:28 +0000 (00:06 +0100)]
Add expand command as described in POSIX-2008.
Erratum: Do not handle backspace.

11 years agoSquash "type punned pointer" nonsense with a bigger hammer. (Sheesh.)
Rob Landley [Tue, 27 Nov 2012 05:36:25 +0000 (23:36 -0600)]
Squash "type punned pointer" nonsense with a bigger hammer. (Sheesh.)

11 years agoThe headers of uClibc and older glibc got unhappy with O_DIRECTORY and some other...
Rob Landley [Tue, 27 Nov 2012 05:24:07 +0000 (23:24 -0600)]
The headers of uClibc and older glibc got unhappy with O_DIRECTORY and some other stuff. Fix it up in portability.h.

11 years agoCleanup i18n support (#ifdefectomy, move global init to process launch). Teach make...
Rob Landley [Mon, 26 Nov 2012 20:14:29 +0000 (14:14 -0600)]
Cleanup i18n support (#ifdefectomy, move global init to process launch). Teach make.sh to emit "#define FLAG_x 0" for options inside disabled USE macros so we can unconditionally refer to them.

11 years agoUpdate touch: add remaining posix arguments, make existing ones work.
Rob Landley [Mon, 26 Nov 2012 01:23:10 +0000 (19:23 -0600)]
Update touch: add remaining posix arguments, make existing ones work.

11 years agoMake internalization support optional
Felix Janda [Wed, 21 Nov 2012 19:38:29 +0000 (20:38 +0100)]
Make internalization support optional

11 years agoFix typo.
Rob Landley [Sun, 25 Nov 2012 20:40:25 +0000 (14:40 -0600)]
Fix typo.

11 years agoRemove readlink -m for being poorly defined ("readlink -m /dev/null/and/more" answers...
Rob Landley [Fri, 23 Nov 2012 03:18:09 +0000 (21:18 -0600)]
Remove readlink -m for being poorly defined ("readlink -m /dev/null/and/more" answers what question, exactly?), rewrite xabspath() to work right and not depend on realpath, fix subtle longstanding bug in llist_traverse().

11 years agoUpdate readlink so -f works. Add -menq while there.
Rob Landley [Tue, 20 Nov 2012 15:21:52 +0000 (09:21 -0600)]
Update readlink so -f works. Add -menq while there.

11 years agoCommit 698 adding cut should ahve included the actual cut.c file. (Oops.)
Rob Landley [Tue, 20 Nov 2012 07:00:17 +0000 (01:00 -0600)]
Commit 698 adding cut should ahve included the actual cut.c file. (Oops.)

11 years agoTeach option parsing about [groups] of related options.
Rob Landley [Mon, 19 Nov 2012 07:49:53 +0000 (01:49 -0600)]
Teach option parsing about [groups] of related options.

11 years agoInit global context to toybox multiplexer early so error_exit() doesn't segfault...
Rob Landley [Mon, 19 Nov 2012 00:52:19 +0000 (18:52 -0600)]
Init global context to toybox multiplexer early so error_exit() doesn't segfault trying to print current command name, and change TOYBOX_DEBUG+TOYBOX_SUID complaint about not having the suid bit set to warning rather than exit..

11 years agoFix leak (call endmntent).
Rob Landley [Sun, 18 Nov 2012 04:06:00 +0000 (22:06 -0600)]
Fix leak (call endmntent).

11 years agoMore touch cleanup to use generic infrastructure: use getdate() from libc, use flag...
Rob Landley [Sat, 17 Nov 2012 00:01:35 +0000 (18:01 -0600)]
More touch cleanup to use generic infrastructure: use getdate() from libc, use flag macros, option parsing can collect argument strings in global block, use existing perror_* macros.

11 years agoFix touch warnings (unused variables, failure to reserve space for null terminator).
Rob Landley [Fri, 16 Nov 2012 21:44:45 +0000 (15:44 -0600)]
Fix touch warnings (unused variables, failure to reserve space for null terminator).

11 years agoRefactor touch (cleanup whitespace, brackets, function order), code otherwise same.
Rob Landley [Fri, 16 Nov 2012 21:36:01 +0000 (15:36 -0600)]
Refactor touch (cleanup whitespace, brackets, function order), code otherwise same.

11 years agoAdd touch from Choubey Ji.
Rob Landley [Fri, 16 Nov 2012 18:43:41 +0000 (12:43 -0600)]
Add touch from Choubey Ji.

11 years agoAdd cut from Jason Kyungwan Han.
Rob Landley [Fri, 16 Nov 2012 18:26:48 +0000 (12:26 -0600)]
Add cut from Jason Kyungwan Han.

11 years agoSet optc when optstring NULL.
Rob Landley [Fri, 16 Nov 2012 06:46:39 +0000 (00:46 -0600)]
Set optc when optstring NULL.

11 years agoAdd rebound support to intercept error_exit() and longjmp instead.
Rob Landley [Fri, 16 Nov 2012 06:35:46 +0000 (00:35 -0600)]
Add rebound support to intercept error_exit() and longjmp instead.

11 years agoMake ls default to -C if no option specified and it's outputting to a tty.
Rob Landley [Thu, 15 Nov 2012 22:15:51 +0000 (16:15 -0600)]
Make ls default to -C if no option specified and it's outputting to a tty.

11 years agoReindent to two spaces per level. Remove vi: directives that haven't worked right...
Rob Landley [Tue, 13 Nov 2012 23:14:08 +0000 (17:14 -0600)]
Reindent to two spaces per level. Remove vi: directives that haven't worked right in years (ubuntu broke its' vim implementation). Remove trailing spaces. Add/remove blank lines. Re-wordwrap in places. Update documentation with new coding style.

The actual code should be the same afterward, this is just cosmetic refactoring.

11 years agoAnnounce release, add anchor tags to roadmap, tweak downloads in header (new bin...
Rob Landley [Tue, 13 Nov 2012 22:13:45 +0000 (16:13 -0600)]
Announce release, add anchor tags to roadmap, tweak downloads in header (new bin directory pointing to downloads/binaries/$CURRENT).

11 years agoAdded tag 0.4.1 for changeset 8871e8002812
Rob Landley [Tue, 13 Nov 2012 13:33:05 +0000 (07:33 -0600)]
Added tag 0.4.1 for changeset 8871e8002812

11 years agoOlder versions of glibc predated posix-2008. They still provide most of what we need...
Rob Landley [Tue, 13 Nov 2012 12:32:03 +0000 (06:32 -0600)]
Older versions of glibc predated posix-2008. They still provide most of what we need, but require a boot to the headers to get them to admit it. Note that uClibc lies and claims to be glibc so we have to specifically exclude it here.

11 years agoYet another attempt to get the fiddly patch file creation logic right.
Rob Landley [Mon, 12 Nov 2012 08:59:56 +0000 (02:59 -0600)]
Yet another attempt to get the fiddly patch file creation logic right.

11 years agoOn 32 bit platforms %ld doesn't match uint64_t, so do long long and %lld (rather...
Rob Landley [Sun, 11 Nov 2012 00:24:14 +0000 (18:24 -0600)]
On 32 bit platforms %ld doesn't match uint64_t, so do long long and %lld (rather than deal with verbose PRIu64 nonsense).

11 years agoFix reversed test: patch creates a file if /dev/null or dated the epoch _and_ first...
Rob Landley [Sat, 10 Nov 2012 20:34:01 +0000 (14:34 -0600)]
Fix reversed test: patch creates a file if /dev/null or dated the epoch _and_ first hunk being replaced is 0 lines at start of file, not one or the other.

11 years agoChange df percentage calculation to match posix, spotted by Roy Tam.
Rob Landley [Thu, 8 Nov 2012 21:03:03 +0000 (15:03 -0600)]
Change df percentage calculation to match posix, spotted by Roy Tam.

11 years agowc -m only cares about counting characters. Attached is a try on implementing it...
Felix Janda [Thu, 8 Nov 2012 17:19:07 +0000 (11:19 -0600)]
wc -m only cares about counting characters. Attached is a try on implementing it and some test cases for it. The test cases are only for UTF-8 locales.

11 years agoMake sha1sum and md5sum default to y.
Rob Landley [Sun, 4 Nov 2012 00:21:59 +0000 (19:21 -0500)]
Make sha1sum and md5sum default to y.

11 years agoUse stridx.
Rob Landley [Fri, 2 Nov 2012 14:50:09 +0000 (09:50 -0500)]
Use stridx.

11 years agoAdd vconfig.c - Creates virtual ethernet devices.
Kyungwan Han [Thu, 1 Nov 2012 14:55:29 +0000 (09:55 -0500)]
Add vconfig.c - Creates virtual ethernet devices.

11 years agoattached are some simple tests for dirname and wc and a fix for a small typo in anoth...
Felix Janda [Mon, 29 Oct 2012 21:55:08 +0000 (16:55 -0500)]
attached are some simple tests for dirname and wc and a fix for a small typo in another test script.

11 years agoFollow symlinks to get actual device name, getmountlist() reverses order for us now...
Rob Landley [Sat, 27 Oct 2012 02:15:31 +0000 (21:15 -0500)]
Follow symlinks to get actual device name, getmountlist() reverses order for us now, detect stdout to full device.

11 years agoAdd md5sum in lsb, combine sha1sum (mostly shared infrastructure). Downside: current...
Rob Landley [Tue, 23 Oct 2012 21:28:14 +0000 (16:28 -0500)]
Add md5sum in lsb, combine sha1sum (mostly shared infrastructure). Downside: current infrastructure can't give them different help text. Hmmm...

11 years agoPut the commands at the start of menuconfig and the toybox library options at the...
Rob Landley [Sun, 21 Oct 2012 22:57:23 +0000 (17:57 -0500)]
Put the commands at the start of menuconfig and the toybox library options at the end. (Aesthetic tweak.)

11 years agoUpdate roadmap/status with new toolbox analysis based on android system/core git...
Rob Landley [Tue, 16 Oct 2012 22:09:30 +0000 (17:09 -0500)]
Update roadmap/status with new toolbox analysis based on android system/core git repo.

11 years agoDoc tweak about test suite.
Rob Landley [Tue, 9 Oct 2012 02:31:07 +0000 (21:31 -0500)]
Doc tweak about test suite.

11 years agoSimplify sha1sum a little.
Rob Landley [Tue, 9 Oct 2012 02:27:58 +0000 (21:27 -0500)]
Simplify sha1sum a little.

11 years agoFix thinko for uname -m when i686 binary runs on x86_64 host.
Rob Landley [Tue, 9 Oct 2012 02:24:19 +0000 (21:24 -0500)]
Fix thinko for uname -m when i686 binary runs on x86_64 host.

11 years agoNew build infrastructure to generate FLAG_ macros and TT alias, #define FOR_commandna...
Rob Landley [Mon, 8 Oct 2012 05:02:30 +0000 (00:02 -0500)]
New build infrastructure to generate FLAG_ macros and TT alias, #define FOR_commandname before #including toys.h to trigger it. Rename DEFINE_GLOBALS() to just GLOBALS() (because I could never remember if it was DECLARE_GLOBALS). Convert existing commands to use new infrastructure, and replace optflag constants with FLAG_ macros where appropriate.

11 years agoMissing line in patch -l. Oops.
Rob Landley [Mon, 8 Oct 2012 04:53:25 +0000 (23:53 -0500)]
Missing line in patch -l. Oops.

11 years agoTest tweaks. Set +x on two scripts (so they can be run standalone), fix chgrp so...
Rob Landley [Mon, 8 Oct 2012 03:57:27 +0000 (22:57 -0500)]
Test tweaks. Set +x on two scripts (so they can be run standalone), fix chgrp so it doesn't abort test all.

11 years agoFix thinko in xpidfile()
Rob Landley [Mon, 8 Oct 2012 00:31:12 +0000 (19:31 -0500)]
Fix thinko in xpidfile()

11 years agopatch -l (loose match)
Rob Landley [Sun, 7 Oct 2012 00:07:34 +0000 (19:07 -0500)]
patch -l (loose match)

11 years agoTrivial cleanup
Rob Landley [Sun, 7 Oct 2012 00:01:23 +0000 (19:01 -0500)]
Trivial cleanup

11 years agoFix catv to display byte 255 correctly. (It's both M- and ^?.)
Rob Landley [Sat, 6 Oct 2012 06:54:24 +0000 (01:54 -0500)]
Fix catv to display byte 255 correctly.  (It's both M- and ^?.)

11 years agoCleanup mknod.
Rob Landley [Sat, 6 Oct 2012 04:33:36 +0000 (23:33 -0500)]
Cleanup mknod.

11 years agoClean up sha1sum, make it use global union properly.
Rob Landley [Mon, 17 Sep 2012 05:17:16 +0000 (00:17 -0500)]
Clean up sha1sum, make it use global union properly.

11 years agogethostname: Tighten up error messages slightly, switch to default "y".
Rob Landley [Sun, 9 Sep 2012 23:44:12 +0000 (18:44 -0500)]
gethostname: Tighten up error messages slightly, switch to default "y".

11 years agoAdd switch_root and fix infrastructure to understand name "switch_root".
Rob Landley [Sat, 8 Sep 2012 06:27:54 +0000 (01:27 -0500)]
Add switch_root and fix infrastructure to understand name "switch_root".

11 years agoI screwed up ls in commit 580. Oops. Fix it.
Rob Landley [Fri, 7 Sep 2012 00:49:40 +0000 (19:49 -0500)]
I screwed up ls in commit 580. Oops. Fix it.

11 years agoPosix compliance: wc shouldn't have trailing spaces (breaks aboriginal's mkinitr
Rob Landley [Thu, 6 Sep 2012 08:10:18 +0000 (03:10 -0500)]
Posix compliance: wc shouldn't have trailing spaces (breaks aboriginal's mkinitr
amfs script), when to print filenames was wrong, and it should have a "total" line when counting multiple arguments.

11 years agoUpdate status page.
Rob Landley [Tue, 4 Sep 2012 02:25:46 +0000 (21:25 -0500)]
Update status page.

11 years agomktemp broke kernel build, so new rules: if you don't specify anything, /tmp/tmp...
Rob Landley [Tue, 4 Sep 2012 02:24:46 +0000 (21:24 -0500)]
mktemp broke kernel build, so new rules: if you don't specify anything, /tmp/tmp.* Specify a file, ./file.  Specify -p dir then dir/tmp.*. Specify -p dir and file, dir/file. Also implement -q which lsb wants.

11 years agoRoy Tam pointed out that sh.c didn't get fully converted.
Rob Landley [Mon, 27 Aug 2012 10:25:50 +0000 (05:25 -0500)]
Roy Tam pointed out that sh.c didn't get fully converted.

11 years agoAdd du command.
Ashwini Kumar [Mon, 27 Aug 2012 02:17:00 +0000 (21:17 -0500)]
Add du command.

11 years agoSplit off pre-relaunch news entries into a separate oldnews.html page.
Rob Landley [Sun, 26 Aug 2012 21:33:06 +0000 (16:33 -0500)]
Split off pre-relaunch news entries into a separate oldnews.html page.

11 years agoRegularize command headers, update links to standards documents.
Rob Landley [Sat, 25 Aug 2012 23:08:51 +0000 (18:08 -0500)]
Regularize command headers, update links to standards documents.

11 years agoToysh is our posix sh, so move from "other" to "posix" and use sh as the base command...
Rob Landley [Sat, 25 Aug 2012 21:34:08 +0000 (16:34 -0500)]
Toysh is our posix sh, so move from "other" to "posix" and use sh as the base command name.

11 years agoTeach build to compare toys/*/*.c against .config symbol names instead of stopping...
Rob Landley [Sat, 25 Aug 2012 20:43:02 +0000 (15:43 -0500)]
Teach build to compare toys/*/*.c against .config symbol names instead of stopping at first _ when assembling list of files to build, and convert - to _. This lets us have commands like switch_root or nbd-client.

11 years agoMove commands into "posix", "lsb", and "other" menus/directories.
Rob Landley [Sat, 25 Aug 2012 19:25:22 +0000 (14:25 -0500)]
Move commands into "posix", "lsb", and "other" menus/directories.

11 years agoSome dubious asides, currently commented out.
Rob Landley [Sat, 25 Aug 2012 19:24:24 +0000 (14:24 -0500)]
Some dubious asides, currently commented out.

11 years agoCheck in the updated news and status web pages.
Rob Landley [Sat, 25 Aug 2012 16:51:25 +0000 (11:51 -0500)]
Check in the updated news and status web pages.

11 years agoFix bug spotted by Avery Pennarun: getusername() and getgroupname() can reuse the...
Rob Landley [Sun, 19 Aug 2012 02:12:02 +0000 (21:12 -0500)]
Fix bug spotted by Avery Pennarun: getusername() and getgroupname() can reuse the utoa buffer when neither is recognized, meaning uid would be shown again instead of gid.

11 years agoBugfix from Avery Pennarun: getpriority() uses a different range than nice(), so...
Rob Landley [Fri, 17 Aug 2012 03:24:30 +0000 (22:24 -0500)]
Bugfix from Avery Pennarun: getpriority() uses a different range than nice(), so follow thenice man page and zero errno then check it if nice returns -1.

11 years agoAdding usleep
Elie De Brauwer [Wed, 15 Aug 2012 10:53:54 +0000 (12:53 +0200)]
Adding usleep

11 years agoReplace TOY_LIST_LEN with more generic ARRAY_LEN()
Rob Landley [Tue, 14 Aug 2012 06:42:06 +0000 (01:42 -0500)]
Replace TOY_LIST_LEN with more generic ARRAY_LEN()

11 years agoRewrite taskset to use syscall directly without macros/prototypes glibc refuses to...
Rob Landley [Mon, 6 Aug 2012 04:05:16 +0000 (23:05 -0500)]
Rewrite taskset to use syscall directly without macros/prototypes glibc refuses to make available without yet more wacky inappropriate #defines. (Linux is not the hurd.)

11 years agoRefactoring, no code change.
Rob Landley [Tue, 31 Jul 2012 11:01:12 +0000 (06:01 -0500)]
Refactoring, no code change.