OSDN Git Service
Roman Stratiienko [Mon, 31 Jan 2022 09:30:27 +0000 (11:30 +0200)]
drm_hwcomposer: Tidy-up DrmDevice class
1. Move drm/DrmConnector.h to Normal clang-tidy checks list by fixing
clang-tidy findings.
2. Remove DrmDevice self-reference.
3. Replace shared_ptr reference to DrmDevice in DrmFbImporter with a
pointer, making ResourceManager only owner of DrmDevice and its
chilren.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Sun, 30 Jan 2022 21:46:10 +0000 (23:46 +0200)]
drm_hwcomposer: Tidy-up DrmConnector class
Implement DrmConnector instantiation through CreateInstance() static method,
which helps to reduce complexity of DrmDevice::Init() function.
Move Connector-to-CRTC binding information to the DrmDevice class.
Move drm/DrmConnector.h to Normal clang-tidy checks list by fixing
clang-tidy findings.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Sun, 30 Jan 2022 19:06:35 +0000 (21:06 +0200)]
drm_hwcomposer: Tidy-up DrmEncoder class
Implement DrmEncoder instantiation through CreateInstance() static method,
which helps to reduce complexity of DrmDevice::Init() function.
Move Encoder-to-CRTC binding information to the DrmDevice class.
Move drm/DrmEncoder.h to Normal clang-tidy checks list by fixing
clang-tidy findings.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Sun, 30 Jan 2022 18:28:46 +0000 (20:28 +0200)]
drm_hwcomposer: Tidy-up DrmCrtc class
Implement DrmCrtc instantiation through CreateInstance() static method,
which helps to reduce complexity of DrmDevice::Init() function.
Move CRTC-to-Display binding information to the DrmDevice class.
Move drm/DrmCrtc.h to Normal clang-tidy checks list by fixing
clang-tidy findings.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Sat, 29 Jan 2022 17:53:14 +0000 (19:53 +0200)]
drm_hwcomposer: Remove ability to prioritize primary display
This feature isn't correctly fits hwc2 and SF requirements.
Primary display prioritization shall be done by introducing ability to
override internal/external connector type for any connector.
'vendor.hwc.drm.primary_display_order' property is no longer relevant.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Fri, 28 Jan 2022 23:17:39 +0000 (01:17 +0200)]
drm_hwcomposer: Handle primary display in GetDisplayConnectionType()
Primary display should always be internal.
Closes: https://gitlab.freedesktop.org/drm-hwcomposer/drm-hwcomposer/-/issues/58
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Fri, 28 Jan 2022 22:50:22 +0000 (00:50 +0200)]
drm_hwcomposer: Tidy-up DrmPlane class
This allow to throw away few lines from DrmDevice::Init() making it less
complicated.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Fri, 28 Jan 2022 22:10:07 +0000 (00:10 +0200)]
drm_hwcomposer: Simplify DrmHwcTwo::GetDisplay()
Cosmetic change: make GetDisplay() non-static class method + use
deduced return type.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 20 Jan 2022 15:12:40 +0000 (17:12 +0200)]
drm_hwcomposer: Fix build_deploy.sh script
Composer service has to be started again.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Tue, 18 Jan 2022 11:47:04 +0000 (13:47 +0200)]
drm_hwcomposer: Remove utils/autolock.*
AutoLock class is no longer used.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Tue, 18 Jan 2022 08:35:30 +0000 (10:35 +0200)]
drm_hwcomposer: Remove write-back related helpers from DrmDevice class
Remove unused functionality.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Tue, 18 Jan 2022 08:21:48 +0000 (10:21 +0200)]
drm_hwcomposer: Remove DrmDisplayCompositor:CreateInitializedComposition
Remove unused functionality.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Mon, 17 Jan 2022 16:29:24 +0000 (18:29 +0200)]
drm_hwcomposer: Add headless mode support
Headless mode required to keep SurfaceFlinger alive when all displays are
disconnected, Without headless mode Android will continuously crash.
Only single internal (primary) display is required to be in HEADLESS mode
to prevent the crash. See [1].
[1]: https://source.android.com/devices/graphics/hotplug#handling-common-scenarios
Closes: https://gitlab.freedesktop.org/drm-hwcomposer/drm-hwcomposer/-/issues/57
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Mon, 17 Jan 2022 11:17:56 +0000 (13:17 +0200)]
drm_hwcomposer: Configuring Composer HAL to use sequential IDs
Implement Google guidelines from [1]
1. The supported display config IDs are:
id=1, 1080x1920 60hz
id=2, 1080x1920 50hz
2. When a change of display configs is processed, the next set of config IDs
are assigned starting from the next unused integer, shown as follows:
id=3, 2160x3840 60hz
id=4, 2160x3840 50hz
id=5, 1080x1920 60hz
id=6, 1080x1920 50hz
+ Don't update modes in GetDisplayConfigs() . Modes is now updated at init or
after every hotplug event.
[1]: https://source.android.com/devices/graphics/hotplug#configuring-composer-hal-sequential-ids
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Mon, 17 Jan 2022 09:24:21 +0000 (11:24 +0200)]
drm_hwcomposer: Introduce main lock
Further development will require more asynchronous processing.
Introduce project-wide single mutex for these purposes.
Use it instead for callback handling instead of callback_lock.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Mon, 17 Jan 2022 08:35:34 +0000 (10:35 +0200)]
drm_hwcomposer: Restore HWC2 API logging functionality
Process and log __PRETTY_FUNCTION__ compiler string.
Prints HWC2 API logs as follows:
hwc2-device: Display #0 Layer: #0 hook: android::HwcLayer::SetLayerBuffer
hwc2-device: Display #0 hook: android::HwcDisplay::ValidateDisplay
hwc2-device: Display #0 hook: android::HwcDisplay::GetChangedCompositionTypes
hwc2-device: Display #0 hook: android::HwcDisplay::GetChangedCompositionTypes
hwc2-device: Display #0 hook: android::HwcDisplay::GetDisplayRequests
hwc2-device: Display #0 hook: android::HwcDisplay::GetDisplayRequests
hwc2-device: Display #0 hook: android::HwcDisplay::AcceptDisplayChanges
hwc2-device: Display #0 hook: android::HwcDisplay::PresentDisplay
hwc2-device: Display #0 hook: android::HwcDisplay::GetReleaseFences
hwc2-device: Display #0 hook: android::HwcDisplay::GetReleaseFences
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Mon, 10 Jan 2022 14:04:15 +0000 (16:04 +0200)]
drm_hwcomposer: CI: Upgrade to clang-13 && clang-tidy-13
+ address new clang-tidy findings.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 20 Jan 2022 15:12:13 +0000 (17:12 +0200)]
drm_hwcomposer: Add delay between hotplug uevent and modes get
We need some delay to ensure DrmConnector::UpdateModes() will query
correct modes list, otherwise at least RPI4 board may report 0 modes.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Mon, 17 Jan 2022 16:44:22 +0000 (18:44 +0200)]
drm_hwcomposer: Fix missing connector state assignment
It was accidentally removed by my previous commit. Restore it.
Fixes:
a148f21336ad ("drm_hwcomposer: Rework display modes handling")
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 13 Jan 2022 09:10:00 +0000 (11:10 +0200)]
drm_hwcomposer: Add script for quick build and deploy drm_hwcomposer
It should help us with manual testing.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 13 Jan 2022 14:37:27 +0000 (16:37 +0200)]
drm_hwcomposer: Use DPMS property to configure display pipeline
Some of KMS drivers like kirin are sensitive to display pipeline
configuration, modern kernel will configure the pipeline correctly
when user sets DPMS property.
To be more precise current compositor logic will not attach primary
plane to the CRTC, while kirin relies on it internally.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Tue, 4 Jan 2022 16:27:40 +0000 (18:27 +0200)]
drm_hwcomposer: Move HwcDisplayConfigs out of HwcDisplay class
To reduce complexity of HwcDisplay class.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Tue, 4 Jan 2022 14:13:12 +0000 (16:13 +0200)]
drm_hwcomposer: Move DrmHwcTwo.{cpp|h} to hwc2_device/ directory
To keep all frontend-related files in a single directory.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Tue, 4 Jan 2022 14:02:55 +0000 (16:02 +0200)]
drm_hwcomposer: Move HwcDisplay out of DrmHwcTwo class
Reduces code complexity.
Closes: https://gitlab.freedesktop.org/drm-hwcomposer/drm-hwcomposer/-/issues/35
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Tue, 4 Jan 2022 12:30:37 +0000 (14:30 +0200)]
drm_hwcomposer: Move HwcLayer out of DrmHwcTwo class
... to reduce complexity of DrmHwcTwo.* files.
Bump-up tidy level of new files to NORMAL (fix function naming,
add NOLINT, etc.)
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Tue, 4 Jan 2022 10:59:29 +0000 (12:59 +0200)]
drm_hwcomposer: Move hw_module related code out of DrmHwcTwo.* files
... to reduce complexity of DrmHwcTwo class.
Create "hwc2_device" directory that will be later used to fit
all frontend-related code.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Tue, 4 Jan 2022 09:42:33 +0000 (11:42 +0200)]
drm_hwcomposer: CI: Remove -readability-use-anyofallof from COARSE list
We have single fail case of -readability-use-anyofallof.
Use NOLINTNEXTLINE comment instead.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Tue, 4 Jan 2022 09:19:52 +0000 (11:19 +0200)]
drm_hwcomposer: CI: Remove duplicate tidy checks
This improves visibility and helps to distinguish which
particular checks are disabled at every level.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Tue, 4 Jan 2022 09:10:22 +0000 (11:10 +0200)]
drm_hwcomposer: CI: Move tidy FINE checklist to Makefile
To make checklists definitions aligned and allow inheritance.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 30 Dec 2021 17:23:14 +0000 (19:23 +0200)]
drm_hwcomposer: Raise clang-tidy level of some files to NORMAL
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 30 Dec 2021 17:20:53 +0000 (19:20 +0200)]
drm_hwcomposer: Fix float to 16.16 fixed point conversion
Previously, the fractional part was truncated.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 30 Dec 2021 16:12:26 +0000 (18:12 +0200)]
drm_hwcomposer: CI: Find all source files instead of hardcoding them.
Goals:
1. Follow clang-tidy rules to maintain project clean.
2. Do not allow new code to break goal #1.
Requirements for CI:
1. In case new file appears in the project, it should be picked-up by CI
automatically and CI should assign NORMAL clang-tidy check level.
2. CI makefile should have SKIP list to define files for which build
by CI is impossible for some reason.
3. CI makefile should have ability to override clang-tidy check level for
every file.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 30 Dec 2021 16:05:27 +0000 (18:05 +0200)]
drm_hwcomposer: Make Planner class fully static
clang-tidy suggested to make all methods of Planner static,
since they don't use any instance members.
This makes creation of Planner instances unnecessary, therefore
remove all such cases.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 23 Dec 2021 17:04:29 +0000 (19:04 +0200)]
drm_hwcomposer: CI: Set clang-tidy level to NORMAL for some files
Some of files require small adjustments to move into NORMAL checks list.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 23 Dec 2021 15:36:12 +0000 (17:36 +0200)]
drm_hwcomposer: CI: Raise clang-tidy level from NONE to COARSE for *.h
To improve CI coverage.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 23 Dec 2021 14:25:20 +0000 (16:25 +0200)]
drm_hwcomposer: CI: Process every file with clang-tidy.
Currently part of header files isn't processed by CI.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 23 Dec 2021 11:41:13 +0000 (13:41 +0200)]
drm_hwcomposer: CI: Fix Makefile dependencies
Previous dependencies relations was triggering FULL 'clang-tidy'
re-validation, even in case single source file has changed.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Fri, 24 Dec 2021 16:56:17 +0000 (18:56 +0200)]
drm_hwcomposer: Update readability-identifier-naming rules
Sync local rules with github gist [1] revision 7.
[1]: https://gist.github.com/airglow923/
1fa3bda42f2b193920d7f46ee8345e04
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 23 Dec 2021 10:59:20 +0000 (12:59 +0200)]
drm_hwcomposer: Free resources in HookDevClose()
Composer service won't free memory for us, see [1].
[1]: https://cs.android.com/android/platform/superproject/+/master:hardware/interfaces/graphics/composer/2.1/utils/passthrough/include/composer-passthrough/2.1/HwcHal.h;l=83;drc=
7ae8af54b32a7eb827dbf9f2aedb647c9525a3d9
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Tue, 11 Jan 2022 17:47:24 +0000 (19:47 +0200)]
drm_hwcomposer: Send crtc.active and crtc.mode together with the frame
On HiKey/HiKey960 boards, enabling the crtc before the first
composition is set can cause trouble, as part of the display
engine is configured in the atomic plane update method.
So when commit
36a7f28516a4 ("drm_hwcomposer: Rework display
Mode Setting and DPMS handling"), which reworked the dpms and
modeset logic to commit the modeset immediately, landed it
caused bootup regressions on those boards.
Talking with others it seems other drivers likely may have
issues trying to enable the crtc without a plane.
Thus this patch changes the logic to queue modesets so they
are submitted with the initial composition. Similarly it
removes the crtc activation, as the initial composition will
implicitly activate the crtc.
Fixes:
36a7f28516a4 ("drm_hwcomposer: Rework display Mode Setting and DPMS handling")
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
[jstultz: Added commit message, reworked a comment]
Signed-off-by: John Stultz <john.stultz@linaro.org>
Change-Id: Ie4d1f967da052b0b3ef73257c2ca76b30504a6c2
Roman Stratiienko [Wed, 22 Dec 2021 15:34:18 +0000 (17:34 +0200)]
drm_hwcomposer: Remove supported()/unsupported() functions
Functions was used mostly for logging HWC2 API calls.
API calls logging will be re-introduced inside the hook templates in
further patches, which will improve logs quality and reduce LOC number.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Fri, 17 Dec 2021 13:09:28 +0000 (15:09 +0200)]
drm_hwcomposer: Modify source_layers_ to be integer instead of array
It isn't used as an array. Simplify the logic.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Tested-by: Martin Juecker <martin.juecker@gmail.com>
Reviewed-by: Matvii Zorin <matvii.zorin@globallogic.com>
Roman Stratiienko [Fri, 17 Dec 2021 13:01:18 +0000 (15:01 +0200)]
drm_hwcomposer: Cleanup Planner class
Remove unused code.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Tested-by: Martin Juecker <martin.juecker@gmail.com>
Reviewed-by: Matvii Zorin <matvii.zorin@globallogic.com>
Roman Stratiienko [Fri, 17 Dec 2021 11:31:27 +0000 (13:31 +0200)]
drm_hwcomposer: Handle unused planes by DrmDisplayCompositor
Rationale:
1. Cleanup/Simplify DrmDisplayComposition class
2. Prepare for shared planes support
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Tested-by: Martin Juecker <martin.juecker@gmail.com>
Reviewed-by: Matvii Zorin <matvii.zorin@globallogic.com>
Roman Stratiienko [Wed, 15 Dec 2021 11:46:05 +0000 (13:46 +0200)]
drm_hwcomposer: Rework KMS state tracking
1. Store only FrameBuffer shared handle to keep buffer alive while
it is a part of active composition.
2. Store used planes to allow clearing of the composition.
Before this both of mentioned above was a part of DrmDisplayComposition.
Any external modification DrmDisplayComposition caused framebuffer object
to be destroyed, which forced screen to go blank.
We want to modify DrmDisplayComposition, to allow re-using previous
composition data.
This change will also help us tracking STAGED frame state and
migrate to non-blocking atomic commit.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Tested-by: Martin Juecker <martin.juecker@gmail.com>
Reviewed-by: Matvii Zorin <matvii.zorin@globallogic.com>
Roman Stratiienko [Wed, 22 Dec 2021 14:22:24 +0000 (16:22 +0200)]
drm_hwcomposer: CI: Replace shell scripts with Makefile
This won't make much benefits for CI, but for local native builds will
significantly speed-up build cycle by allowing parallel build and by
using dependency tracking logic.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 22 Dec 2021 09:46:03 +0000 (11:46 +0200)]
drm_hwcomposer: CI: Tune clang-tidy coarse checks
1. Switch to "enable all then disable unwanted" strategy
2. Enable checks that causes small number of failes, marking
corresponding lines as NOLINT, so we won't introduce
new such cases unintentionally.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 22 Dec 2021 08:40:59 +0000 (10:40 +0200)]
drm_hwcomposer: Tidy-up the CI scripts
1. Use -Wextra instead of multiple -Wxxx arguments. It will turn on remaining
checks (such as -Wunused-parameter, which is currently disabled in CI)
2. Bump-up ANDROID_API definitions to 31
3. Fix clang-format-diff-X version to match the one specified in the README.md
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Yongqin Liu [Sun, 28 Nov 2021 00:46:30 +0000 (08:46 +0800)]
drm_hwcomposer: support more connector types
according to the drm_connector_enum_list defined
in the kernel file drivers/gpu/drm/drm_connector.c
Otherwise for the new connector type, the connector
name will be "None" to be printed in the logcat, like this:
12-13 05:38:06.263 383 383 I hwc-backend: Backend 'generic' for 'None' and driver 'omapdrm' was successfully set
with this change, it will be fixed with the connector type like this:
12-13 06:01:57.672 342 342 I hwc-backend: Backend 'generic' for 'DPI-1' and driver 'omapdrm' was successfully set
Also updated the internal() and external() functions
to make the newly added SPI and USB are valid types
Signed-off-by: Yongqin Liu <yongqin.liu@linaro.org>
Roman Stratiienko [Mon, 6 Dec 2021 12:56:14 +0000 (14:56 +0200)]
drm_hwcomposer: Assume premultiplied alpha for CLIENT layer
On db845c, we have seen an odd behavior with modal dialogs in
AOSP, where the background which is normally darkened, was
rendering as black, though it would occasionally flicker to the
right thing. This cropped up after alpha support on planes
landed in 5.15, so we assumed it was an edge case issue with the
dpu1 driver.
But while working on a separate issue seen on x86 hardware:
https://gitlab.freedesktop.org/drm-hwcomposer/drm-hwcomposer/-/issues/46
Roman noticed drm_hwcomposer always sets the blending type to
NONE for the client layer. Which had gone un-noticed becase he
didn't have any devices that exposed the NONE type.
Thus Roman implemented this patch, which sets up the client
blend type to PREMULTIPLIED.
While it did not resolve the x86 issue above, it does resolve
the incorrect rendering seen on db845c with alpha support
enabled.
Tested-by: Martin Juecker martin.juecker@gmail.com #Exynos 4412
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
Change-Id: I95601c680ca1af0dc9d3b3f102f79f77af081b75
Roman Stratiienko [Mon, 6 Dec 2021 10:59:26 +0000 (12:59 +0200)]
drm_hwcomposer: Fix all cases which triggers an error on -Wsign-compare
Android-9 has -Wsign-compare enabled by default and it causes build issues.
Enable -Wsign-compare option in CI, so we won't introduce such issues anymore.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Tue, 30 Nov 2021 15:48:16 +0000 (17:48 +0200)]
drm_hwcomposer: Use gralloc0::perform API by minigbm bufferinfo getter
Using of internals of cros_gralloc_handle isn't recommended, since
it can be changed at any time. Meanwhile minigbm provides another
API to access buffer information based on gralloc0 perform() call.
ChromiumOS are using this API by mesa3d and other related projects.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Tue, 30 Nov 2021 15:06:44 +0000 (17:06 +0200)]
drm_hwcomposer: Validate gralloc0 name for minigbm and libdrm getters
Using of incorrect gralloc0 results in a runtime issues, with logs like
"Cannot convert hal format to drm format <VALUE>" or other.
Validate gralloc name and exit gracefully in case it doesnt't match the one
we are expecting.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Tue, 16 Nov 2021 16:23:18 +0000 (18:23 +0200)]
drm_hwcomposer: Rework display modes handling
Android likes to adapt display output frequency to match window context
frequency. Unfortunately platform code has some limitations, therefore
hwcomposer HAL should be careful with reporting supported display modes.
Known platform limitations:
1: Framework doesn't distinguish between interlaced/progressive modes.
2. Framework will not switch display frequency in case margin in FPS rate
is very small (<1FPS or so). Not a big issue, but that is causing
some CTS tests to fail.
In addition to that VRR technology (or seamless mode switching) require
hwcomposer to group modes which tells the framework that seamless mode
configuration change is supported within a group of display modes.
By this commit do the following:
1. Group modes by the resolution:
E.g.
Group 1:
1024x768i@60
1024x768i@90
1024x768@50
1024x768@50.1
Group 2:
1920x1080@60
1920x1080@24.3
1920x1080i@60
1920x1080i@120
2. Disable modes in a way that each group keeps only interlaced or proressive
modes enabled. In case KMS reported preferred mode is interlaced - prefer
interlaced for the whole group, otherwise prefer progressive.
3. Disable mode in case different mode in the same group has similar frequency
with delta less than 1FPS.
4. Report only modes which remain enabled to the framework.
Test: atest CtsGraphicsTestCases
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 28 Oct 2021 12:52:38 +0000 (15:52 +0300)]
drm_hwcomposer: Don't use Mapper@4 metadata API for legacy getters
As it turned out Mapper@4 metadata API calls are slow.
Allow using legacy getters again.
Closes: https://gitlab.freedesktop.org/drm-hwcomposer/drm-hwcomposer/-/issues/56
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Mon, 25 Oct 2021 19:54:20 +0000 (22:54 +0300)]
drm_hwcomposer: Make uevent listener standalone
1. DRM event listener doesn't work in this conditions, uevent blocks
the thread and non-blocking select() doesn't make any sense.
Remove DRM event handling for now.
2. UEvent listeren is common for all DrmDevices, therefore put it into
ResourceManager class.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Sat, 23 Oct 2021 14:47:35 +0000 (17:47 +0300)]
drm_hwcomposer: Route release fence directly
Current release_fence merging logic doesn't make much sence, cleanup it.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Sat, 23 Oct 2021 14:35:44 +0000 (17:35 +0300)]
drm_hwcomposer: Make single atomic function for all atomic commit ops.
... to allow precise control on atomic commit operations.
This should also help to implement dynamic modechange, readback and
other useful features.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Fri, 22 Oct 2021 15:13:09 +0000 (18:13 +0300)]
drm_hwcomposer: Move CreateModeBlob to DrmMode class
CreateModeBlob doesn't architecturally belongs to DrmDisplayCompositor.
+ align DrmMode internal types with libdrm types to avoid compilation errors.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 7 Oct 2021 08:27:08 +0000 (11:27 +0300)]
drm_hwcomposer: Remove DrmDisplayCompositor::GetActiveModeResolution()
DrmDisplayCompositor::GetActiveModeResolution() isn't used, remove it.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Tue, 5 Oct 2021 15:17:53 +0000 (18:17 +0300)]
drm_hwcomposer: Rework display Mode Setting and DPMS handling
1. Remove DPMS logic. As stated in KMS kernel docs: CRTC "activate"
property was implemented as a simplified atomic replacement of DPMS.
And kernel internally will just update "activate" on DPMS setting.
2. Add SetDisplayActivate(bool state) method to compositor class,
which is now replacement for SetDpmsMode().
3. Move mode settings out of DrmComposition class to DrmCompositor class.
From now on DrmComposition describes only layer-to-plane composition
as it should be.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 30 Sep 2021 07:18:28 +0000 (10:18 +0300)]
drm_hwcomposer: Rework UserPropertyBlob to use RAII
Makes code simpler and leak-free.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 30 Sep 2021 07:15:05 +0000 (10:15 +0300)]
drm_hwcomposer: Move GetPlaneProperty into DrmPlane class
In addition move logging to GetPlaneProperty(), which allow to reduce
number of LoC by ~50 LoC and increase readability.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 30 Sep 2021 07:14:42 +0000 (10:14 +0300)]
drm_hwcomposer: Remove unused DrmDisplayCompositor class fields
Test: mmma external/drm_hwcomposer
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 30 Sep 2021 07:09:46 +0000 (10:09 +0300)]
drm_hwcomposer: Remove unused {DrmComposition,DrmCompositor}::Dump()
Both DrmCompositor and DrmComposition have to be reworked to account
for shared DRM planes, asynchronous atomic commit, dynamic modechange and
composition reusing between Validate/Present steps.
Current dump logic will be obsolate anyway and keeping/supporting it will
slow-down reworking process. It make sense to remove it now and create
from scrach if needed.
Test: mmma external/drm_hwcomposer
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 30 Sep 2021 07:09:31 +0000 (10:09 +0300)]
drm_hwcomposer: Move client flattening closer to the frontend
Remove unnecessary code from DrmCompositor.
Drops ~100 LoC.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Thu, 30 Sep 2021 16:36:00 +0000 (19:36 +0300)]
drm_hwcomposer: Allow pre-multi layer to always pass DrmPlane validation
This logic was removed accidentaly during cleanup. Restore it.
Enables hardware-accelerated composition on raspberry-pi 4.
Fixes:
5063d53ddf7d ("drm_hwcomposer: Improve handling of blending mode")
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Fri, 22 Oct 2021 09:34:36 +0000 (12:34 +0300)]
drm_hwcomposer: Improve Mapper@4 metadata API fds index guessing logic
Unfortunately Mapper@4.0 metadata API doesn't allow to query fd index or
getting fd another way for every layout plane, therefore users have to
provide their custom additional metadata API.
We are doing all our best to minimize custom per-platform logic in
drm_hwcomposer. So it was decided to implement primitive guessing logic,
allowing users to extend it with out-of-tree code if necessary.
As was reported by John Stultz in [1] our primitive logic has some flaws.
New guessing logic are using inputs from layout data (offsets, sizes),
and should be more precise.
[1]: https://gitlab.freedesktop.org/drm-hwcomposer/drm-hwcomposer/-/merge_requests/159
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 29 Sep 2021 10:01:39 +0000 (13:01 +0300)]
drm_hwcomposer: Add support for VSYNC_2_4 callback
Increase composer@2.4 implemented API coverage.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 29 Sep 2021 10:00:29 +0000 (13:00 +0300)]
drm_hwcomposer: Handle all HWC2 callbacks in DrmHwcTwo.{h,cpp}
Part of frontend isolation activities.
1. Use HWC2 HAL types only inside DrmHwcTwo.{h,cpp}.
2. Use single lock for all callbacks.
3. Communicate with other drm_dwc components using std::function
without any locking.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 29 Sep 2021 09:59:54 +0000 (12:59 +0300)]
drm_hwcomposer: Move rotation enum querying into DrmPlane initialization
Benefits:
1. Improve readability.
2. Less logic in runtime slightly reduces overhead on CPU.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 29 Sep 2021 09:59:48 +0000 (12:59 +0300)]
drm_hwcomposer: Cleanup DrmPlane::Init()
Adding enum value into map looks ugly.
Create a wrapper in order to fix it.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 29 Sep 2021 09:52:22 +0000 (12:52 +0300)]
drm_hwcomposer: DrmPlane: More atomic commit cleanup
A few rearrangements to reduce LoC and increase readability.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 29 Sep 2021 09:50:10 +0000 (12:50 +0300)]
drm_hwcomposer: Remove unused cursor_{x,y}_ and layer_color_ variables
Make it clear that drm_hwcomposer doesn't handle these values.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 29 Sep 2021 09:47:35 +0000 (12:47 +0300)]
drm_hwcomposer: Convert transform value at HWC hook call
One more step towards "frontend" isolation.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 29 Sep 2021 09:47:31 +0000 (12:47 +0300)]
drm_hwcomposer: Improve handling of blending mode
1. Convert to DrmHwcBlending inside HWC hook.
2. Use map for enum_values for cleaner atomic commit preparation.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 29 Sep 2021 09:47:26 +0000 (12:47 +0300)]
drm_hwcomposer: Query color_encoding and color_range enums during init
Should slightly reduce CPU load at runtime + improve
atomic commit readability.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 29 Sep 2021 09:47:21 +0000 (12:47 +0300)]
drm_hwcomposer: Create intermediate enum for colorspace and samplerange
Part of "frontend" isolation activities.
Also allows to additionally simplify atomic commit.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 29 Sep 2021 09:47:16 +0000 (12:47 +0300)]
drm_hwcomposer: Move plane-related atomic commit logic to DrmPlane class
Remove unnecessary property getter/setters from DrmPlane class.
As result: Removed ~50 unnecessary LoC. Improved readability.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 29 Sep 2021 09:47:12 +0000 (12:47 +0300)]
drm_hwcomposer: Move IsKMSDev to DrmDevice
IsKMSDev() is a DRM device helper, therefore DrmDevice class
is better home for it.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 29 Sep 2021 09:47:06 +0000 (12:47 +0300)]
drm_hwcomposer: Remove unused AvailableWritebackConnector()
ResourceManager::AvailableWritebackConnector is not used anymore.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 29 Sep 2021 09:47:00 +0000 (12:47 +0300)]
drm_hwcomposer: Remove unused ResourceManager::gralloc_ field
It was added with initial ResourceManager implementation and was
never used.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 29 Sep 2021 09:46:54 +0000 (12:46 +0300)]
drm_hwcomposer: Cleanup DRM atomic commit
Create and use DrmPlane::AtomicSet() wrapper.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 29 Sep 2021 09:46:28 +0000 (12:46 +0300)]
drm_hwcomposer: Wrap libdrm drmMode*{Get|Free}* into RAII
This should elliminate chance of any leaks in the future.
Fix drmModePropertyBlobPtr leak in DrmHwcTwo.cpp.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Roman Stratiienko [Wed, 4 Aug 2021 19:43:06 +0000 (22:43 +0300)]
drm_hwcomposer: Fix property_get() linux impl.
Bad implementation was found during code surfing.
At this moment function is used only as a stub for CI.
Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
Roman Stratiienko [Thu, 4 Mar 2021 13:22:09 +0000 (15:22 +0200)]
drm_hwcomposer: CI: Tune the readability-identifier-naming settings
Copy rules from [1], which is based on Google cpp code-style guide [2]
[1]: https://gist.github.com/airglow923/
1fa3bda42f2b193920d7f46ee8345e04
[2]: https://google.github.io/styleguide/cppguide.html
Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
Roman Stratiienko [Wed, 4 Aug 2021 16:55:37 +0000 (19:55 +0300)]
drm_hwcomposer: CI: Upgrade clang-* to v12
- Enabling readability-ientifier-naming tidy check does require to specify
MacroDefinitionIgnoredRegexp key, which is available only in clang-tidy-12.
- Clang-12 isn't available on ubuntu 20.10, therefore upgrade to 21.04.
- "DEBIAN_FRONTEND: noninteractive" is required to prevent ubuntu 21.04
from hanging, presumably due to waiting for the user input.
- A positive side effect of upgrading to clang-12 is new clang-tidy-12,
which exposed new issues in the code which is also fixed by this commit,
e.g:
Failed cppcoreguidelines-narrowing-conversions check with error:
error: narrowing conversion from 'uint32_t' (aka 'unsigned int') to 'float'
require explicit casting to pass the check, while some of such fails are caused
by incorrect variable type and fixed by changing the type to correct one.
Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
Roman Stratiienko [Wed, 25 Aug 2021 03:15:42 +0000 (06:15 +0300)]
drm_hwcomposer: Don't close same handle several times.
Video (YUV) frames can have several planes in the same buffer,
in this case all the planes will be represented by the same
gem_handle, which must be closed only once.
Fixes logcat noise during video playback.
Reported-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
John Stultz [Tue, 24 Aug 2021 04:59:25 +0000 (04:59 +0000)]
drm_hwcomposer: Quiet noisy errors when planes don't support various attributes
If a plane doesn't support alpha or rotation, and IsValidForLayer()
fails, we see lots of logcat noise to the effect of:
08-24 04:45:42.957 453 453 E hwc-platform: Failed to emplace layer 0, dropping it
08-24 04:45:42.957 453 453 E hwc-platform: Failed provision stage with ret -22
08-24 04:45:42.957 453 453 E hwc-drm-display-composition: Planner failed provisioning planes ret=-22
08-24 04:45:42.957 453 453 E hwc-drm-two: Failed to plan the composition ret=-22
This noise is unneccessarily worrisome, as they don't really
help explain why things fail, and we still fall back to client
composing and frames are correctly composited.
Thus, this patch switches the errors to verbose-level warnings,
which match the level in IsValidForLayer() which explain what
actually is going wrong.
Change-Id: I7ed06906b8d9e02e6ec0ac50a94346e9f9c05ac6
Signed-off-by: John Stultz <john.stultz@linaro.org>
John Stultz [Sat, 31 Jul 2021 00:19:50 +0000 (00:19 +0000)]
drm_hwcomposer: Fix sync_file fd leak from "Rework audofd"
In commit
0fade37afd60 ("drm_hwcomposer: Rework autofd"),
a change to some very subtle existing code caused a resource
leak such that after 10 minutes or so of active display
output, we would start seeing:
android.hardware.graphics.composer@2.3-service: failed to dup fence 10
over and over in logcat. Moving the mouse would cause black
frame to flicker and eventually Surfaceflinger would crash
and restart.
The problem was subtle change in the following hunk:
@@ -1047,10 +1049,9 @@ HWC2::Error DrmHwcTwo::HwcLayer::SetLayerBlendMode(int32_t mode) {
HWC2::Error DrmHwcTwo::HwcLayer::SetLayerBuffer(buffer_handle_t buffer,
int32_t acquire_fence) {
supported(__func__);
- UniqueFd uf(acquire_fence);
set_buffer(buffer);
- set_acquire_fence(uf.get());
+ acquire_fence_ = UniqueFd(fcntl(acquire_fence, F_DUPFD_CLOEXEC));
return HWC2::Error::None;
}
The core of the problem being, that the UniqueFd class calls
close(fd_) in its descructor. So while the change using
fcntl(...,F_DUPFD_CLOEXEC) matches what was burried in
set_acquire_fence(), dropping the creation (and more importantly
the destruction when it goes out of scope) of uf changes the
logic so we don't end up calling close on the aquire_fence fd
argument passed in.
One can confirm this resource leak by doing:
adb shell lsof | grep composer
And noticing the number of sync_file fds growing over time.
Thus, this patch fixes the logic, so instead of dup()'ing the
passed in fd, (and then closing it as done before Roman's
patch), we can just set aquire_fence_ to a new UniqueFd directly
using the aquire_fence fd passed in.
This pattern actually occured twice, so I've fixed it in both
places.
Fixes:
0fade37afd60 ("drm_hwcomposer: Rework autofd")
Signed-off-by: John Stultz <john.stultz@linaro.org>
Change-Id: Iff2ca1c0b6701abbdc10c6ee92edb21a4b84a841
Roman Stratiienko [Fri, 21 May 2021 11:33:28 +0000 (14:33 +0300)]
drm_hwcomposer: Add links to the HWC2 API description
Some part of the API is not streightforward and wrong implementation
may cause leaks and other hard-to-debug runtime issues.
Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
Roman Stratiienko [Sat, 20 Feb 2021 11:59:55 +0000 (13:59 +0200)]
drm_hwcomposer: Rework autofd
Motivation:
Current implementation of UniqueFd can be used in a different ways,
making analytical tracking of FD lifecycle much harder than it may be.
Keep this part clean is very important, since any wrong code may open
a hard-to-detect runtime bugs and fd leaks, which may accidentally slip
into the production.
Implementation:
1. Combine UniqueFd anf OutputFd into single class.
2. Reduce the API to be minimal and sufficient.
3. Document the API and use cases.
4. Move to utils/UniqueFd.h.
5. dup(fd) was replaced with fcntl(fd, F_DUPFD_CLOEXEC)) to
address clang-tidy findings. Find more information at [1]
[1]: https://clang.llvm.org/extra/clang-tidy/checks/android-cloexec-dup.html
Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
Roman Stratiienko [Wed, 10 Feb 2021 12:59:52 +0000 (14:59 +0200)]
drm_hwcomposer: cleanup hwcutils
Remove DrmHwcBuffer class. Wrap remaining logic into
DrmHwcLayer class.
Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
Roman Stratiienko [Wed, 10 Feb 2021 10:11:16 +0000 (12:11 +0200)]
drm_hwcomposer: Stop importing native_handle_t into the mapper
Composer service is already importing buffers from binder pipe
into the mapper and caches them making native handles valid
for a whole composition processing cycle.
Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
Roman Stratiienko [Tue, 9 Feb 2021 15:49:55 +0000 (17:49 +0200)]
drm_hwcomposer: Tracking of the DRM FB objects using RAII
DRM framebuffer objects must be kept registered in DRM/KMS
while used for scanning-out (After atomic commit applied
for processing by display controller and until next atomic
commit is applied for processing).
Existing logic for tracking current state is overcomplicated and
needs to be redesigned. Also further developing of drm_hwc will
require migration to asynchronous atomic commit, so additional
asynchronous FB cleanup logic must be created.
Buffer caching logic will also benefit from this.
With the RAII all further changes will be less painful and more robust.
By this commit I also renamed DrmGenericImporter to DrmFbImporter:
'Fb' word is present in most of existing composers (android and linux)
so it will be easier to compare different implementations.
Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
Benjamin Li [Sun, 9 May 2021 16:01:38 +0000 (09:01 -0700)]
drm_hwcomposer: update README for clang-format-diff-11 and touch up formatting
The README.md is out of date -- clang-format-diff-5.0 is not what runs on
CI anymore. To help contributors better test their changes locally before
submitting a merge request, update to the actual linting command being run
in CI.
Signed-off-by: Benjamin Li <benl@squareup.com>
Benjamin Li [Sun, 9 May 2021 15:52:35 +0000 (08:52 -0700)]
drm_hwcomposer: remove unused variable blend
The first tuple element returned by GetEnumValueWithName is just the index
of that enum, which is not useful.
Signed-off-by: Benjamin Li <benl@squareup.com>
Benjamin Li [Sun, 9 May 2021 15:52:18 +0000 (08:52 -0700)]
drm_hwcomposer: reject rotations reported as unsupported by hardware
Currently we only check for the presence of any rotation support -- but
hardware may choose to, say, only support 180 degree rotation. Respect
the specific rotation capabilities reported through DRM properties.
Signed-off-by: Benjamin Li <benl@squareup.com>
Benjamin Li [Wed, 5 May 2021 16:23:15 +0000 (09:23 -0700)]
drm_hwcomposer: add DRM_PROPERTY_TYPE_BITMASK
Bitmask properties are integers that additionally have strings associated
with each bit. For example, the "rotation" property's bits are described
as "rotate-90", "reflect-x", and so on.
The bitmask integer is not actually passed to us -- instead, the interface
for enums is used, except that more than one value can be set. This means we
must query using the associated strings, rather than use bit index mappings
provided as constants in the public kernel header drm_mode.h.
Signed-off-by: Benjamin Li <benl@squareup.com>
Matvii Zorin [Mon, 26 Apr 2021 14:24:56 +0000 (17:24 +0300)]
drm_hwcomposer: Fix regression after composition creation cleanup
During rebasing of the local integration branch, one code chunk was not
updated accidentally and the client range was not selected properly which
leads to jank frames appearance.
The issue has been already fixed by the commit
3f89182bb9df
("drm_hwcomposer: Fix client range selection logic").
Issue: https://gitlab.freedesktop.org/drm-hwcomposer/drm-hwcomposer/-/issues/53
Fixes:
b3b15166f9da ("drm_hwcomposer: Add GetExtraClientRange method")
Suggested-by: Roman Stratiienko <r.stratiienko@gmail.com>
Signed-off-by: Matvii Zorin <matvii.zorin@globallogic.com>