OSDN Git Service
Hansong Zhang [Mon, 9 Apr 2018 21:10:21 +0000 (14:10 -0700)]
Merge changes from topic "am-
e8b13d24-dee0-4f84-89d4-
8a7d110f6ec1" into oc-dev am:
d59b0eddae am:
3f2dbb7cc9
am:
e934ea80a6
Change-Id: I17aa86fa2a02f1a80e9ec8aaa557c3488dd32c21
Hansong Zhang [Mon, 9 Apr 2018 21:08:48 +0000 (14:08 -0700)]
[automerger skipped] [automerger] DO NOT MERGE Fix unexpected behavior in Bluetooth pairing am:
ac6c49d2b0 am:
5b98c9f4a3 am:
dfe4cc74f7 skipped:
d276b38666 am:
5d27bdb6d2 am:
bab8dca667 am:
84061c71d1 am:
41be25548e skipped:
74ff24d1c6 am:
c4127072f4 am:
1b7566cd07
am:
af077f8d4c -s ours
Change-Id: I834e60da9920199756dce2206042e4a1ba0c20b9
Hansong Zhang [Mon, 9 Apr 2018 20:54:58 +0000 (13:54 -0700)]
Merge changes from topic "am-
e8b13d24-dee0-4f84-89d4-
8a7d110f6ec1" into oc-dev am:
d59b0eddae
am:
3f2dbb7cc9
Change-Id: Ica684d7a7fc36439111b7eeb3886761f63a7130f
Hansong Zhang [Mon, 9 Apr 2018 20:53:41 +0000 (13:53 -0700)]
[automerger] DO NOT MERGE Fix unexpected behavior in Bluetooth pairing am:
ac6c49d2b0 am:
5b98c9f4a3 am:
dfe4cc74f7 skipped:
d276b38666 am:
5d27bdb6d2 am:
bab8dca667 am:
84061c71d1 am:
41be25548e skipped:
74ff24d1c6 am:
c4127072f4
am:
1b7566cd07
Change-Id: I10c2d233f05ddf566ac38afb7c2cdc5a8e61df25
Hansong Zhang [Mon, 9 Apr 2018 20:44:07 +0000 (13:44 -0700)]
Merge changes from topic "am-
e8b13d24-dee0-4f84-89d4-
8a7d110f6ec1" into oc-dev
am:
d59b0eddae
Change-Id: Ia628cc0bd02429ec321d8e80c9d9ad2c097715bd
Hansong Zhang [Mon, 9 Apr 2018 20:43:04 +0000 (13:43 -0700)]
[automerger] DO NOT MERGE Fix unexpected behavior in Bluetooth pairing am:
ac6c49d2b0 am:
5b98c9f4a3 am:
dfe4cc74f7 skipped:
d276b38666 am:
5d27bdb6d2 am:
bab8dca667 am:
84061c71d1 am:
41be25548e skipped:
74ff24d1c6
am:
c4127072f4
Change-Id: I559bfa947ae6f7ee89076d05826fd4529d6b0cc2
TreeHugger Robot [Mon, 9 Apr 2018 20:29:54 +0000 (20:29 +0000)]
Merge changes from topic "am-
e8b13d24-dee0-4f84-89d4-
8a7d110f6ec1" into oc-dev
* changes:
[automerger] DO NOT MERGE Fix unexpected behavior in Bluetooth pairing am:
4f58c19afa am:
e25ebddfdc am:
ee220e0238 am:
7b2b84c617 skipped:
b1f00ebf9c
[automerger] DO NOT MERGE Fix unexpected behavior in Bluetooth pairing am:
4f58c19afa am:
e25ebddfdc am:
ee220e0238 am:
7b2b84c617
[automerger] DO NOT MERGE Fix unexpected behavior in Bluetooth pairing am:
4f58c19afa am:
e25ebddfdc am:
ee220e0238
[automerger] DO NOT MERGE Fix unexpected behavior in Bluetooth pairing am:
4f58c19afa am:
e25ebddfdc
[automerger] DO NOT MERGE Fix unexpected behavior in Bluetooth pairing am:
4f58c19afa
DO NOT MERGE Fix unexpected behavior in Bluetooth pairing
Makoto Onuki [Mon, 9 Apr 2018 20:29:30 +0000 (20:29 +0000)]
Merge "Once auto-battery saver is ever set, don't show suggestion" into pi-dev
Beverly Tai [Mon, 9 Apr 2018 19:54:24 +0000 (19:54 +0000)]
Merge "Update DndCondition settings summary" into pi-dev
TreeHugger Robot [Mon, 9 Apr 2018 19:08:26 +0000 (19:08 +0000)]
Merge "Remove gear from usb preference" into pi-dev
TreeHugger Robot [Mon, 9 Apr 2018 19:04:22 +0000 (19:04 +0000)]
Merge "Use proper icon size for default app prefs." into pi-dev
TreeHugger Robot [Mon, 9 Apr 2018 18:59:44 +0000 (18:59 +0000)]
Merge "GesturesSettingPreferenceController to Toggle" into pi-dev
TreeHugger Robot [Mon, 9 Apr 2018 18:52:25 +0000 (18:52 +0000)]
Merge "Reorder visual effect fields" into pi-dev
TreeHugger Robot [Mon, 9 Apr 2018 18:40:40 +0000 (18:40 +0000)]
Merge "Fix a crash in Storage Settings." into pi-dev
Jerry Zhang [Fri, 6 Apr 2018 19:06:49 +0000 (12:06 -0700)]
Remove gear from usb preference
Switch from GearPreference to a normal
Preference.
Add some spacing underneath the power role.
Bug:
77647931
Test: passes
Change-Id: Ic15849e12aa47df75cc75c9da0384e24627a9c8b
TreeHugger Robot [Mon, 9 Apr 2018 17:33:50 +0000 (17:33 +0000)]
Merge "Delete unused query_hint_text string." into pi-dev
TreeHugger Robot [Mon, 9 Apr 2018 17:33:21 +0000 (17:33 +0000)]
Merge "Update inherited actionBarStyle to DeviceDefault." into pi-dev
Fan Zhang [Fri, 6 Apr 2018 23:31:31 +0000 (16:31 -0700)]
Use proper icon size for default app prefs.
Change-Id: Ib48c7a546fcd3a3a9e32b7a65cbdadd54721f252
Fixes:
77726902
Test: robotests
Daniel Nishi [Fri, 6 Apr 2018 20:05:35 +0000 (13:05 -0700)]
Fix a crash in Storage Settings.
This prevents a NullPtrException when the DonutView attempts to shrink
the percentage sign. By gracefully falling back when we don't understand
the percentage sign, we can avoid a crash.
Change-Id: I0b0770ce4b51eb30817dc556636f86476f4cd1bf
Fixes:
77653937
Test: Robotest -- screenshot attached
Lei Yu [Mon, 9 Apr 2018 17:09:22 +0000 (17:09 +0000)]
Merge "Add NullPtrCheck when smearing in settings" into pi-dev
Beverly [Fri, 6 Apr 2018 18:17:13 +0000 (14:17 -0400)]
Update DndCondition settings summary
Test: make ROBOTEST_FILTER=ZenModeSettingsTest RunSettingsRoboTests -j40
Test: atest DndConditionTest
Change-Id: Iff39e9dfda25453bfe4c2554fea3ef7be0832413
Fixes:
77704156
Fixes:
76208187
Julia Reynolds [Fri, 6 Apr 2018 17:02:53 +0000 (13:02 -0400)]
Reorder visual effect fields
Bug:
77657376
Test: RunSettingsRoboTests
Change-Id: I9f5be8f173d8d987d419f6d444d76d2abe175b4e
HJ ChangLiao [Mon, 2 Apr 2018 09:06:55 +0000 (17:06 +0800)]
GesturesSettingPreferenceController to Toggle
Convert GesturesSettingPreferenceController to
TogglePreferenceController,
All of its children need follow the change,
add setter and robotest for them:
AssistGestureSettingsPreferenceController
DoubleTapPowerPreferenceController
DoubleTapScreenPreferenceController
DoubleTwistPreferenceController
PickupGesturePreferenceController
SwipeToNotificationPreferenceController
Change-Id: I792b2d370eea828bf345fb2b1cc3eac260eb66f4
Merged-In: I792b2d370eea828bf345fb2b1cc3eac260eb66f4
Fixes:
74913806
Fixes:
67998110
Fixes:
67998098
Fixes:
67998048
Fixes:
67998069
Fixes:
67997452
Test: make RunSettingsRoboTests
John Li [Tue, 27 Mar 2018 08:16:55 +0000 (16:16 +0800)]
Move these radio buttons to the left
Assign new single layout to RadioButtonPreference for w/ or w/o icon
and call setIconSpaceReserved(false) in RadioButtonPreference's
constructor. In case of having icon, calling setIcon() can make
icon_frame visible.
Bug:
70850017
Test: m -j56 SettingsRoboTests RunSettingsRoboTests
Change-Id: I8b35f75b6d8114a5e4c69ec1a3287c55e764ffe0
Erik Kline [Thu, 5 Apr 2018 21:30:56 +0000 (14:30 -0700)]
Display Private DNS status in preference summary
Also: fix a bug where the actual current mode is not read correctly
from settings on initialization.
Test: as follows
- built, flashed, booted
- manual test behaves as expected
- make -j50 RunSettingsRoboTests ROBOTEST_FILTER=PrivateDnsModeDialogPreferenceTest passes
- make -j50 RunSettingsRoboTests ROBOTEST_FILTER=PrivateDnsPreferenceControllerTest passes
Bug:
34953048
Bug:
64133961
Change-Id: I0b845b3894a47b837abf5de273d1ada642ef5a23
Andrew Sapperstein [Wed, 24 Jan 2018 01:34:19 +0000 (17:34 -0800)]
Update inherited actionBarStyle to DeviceDefault.
Was using a Material style. Now it's using the DeviceDefault one that
Theme.DeviceDefault.Settings uses.
Bug:
69314526
Test: visual inspection
Change-Id: I5ce1bbb51a8d067fce226ff4a41fdea64106156a
Andrew Sapperstein [Sun, 8 Apr 2018 18:15:03 +0000 (11:15 -0700)]
Delete unused query_hint_text string.
Change-Id: If6378768255c7cac290f914620115bff04c6b281
Fixes:
77772047
Test: compiles
TreeHugger Robot [Sat, 7 Apr 2018 05:06:53 +0000 (05:06 +0000)]
Merge "Fix test expectations for NetworkCallbacks" into pi-dev
TreeHugger Robot [Sat, 7 Apr 2018 01:04:52 +0000 (01:04 +0000)]
Merge "Create help link placeholder for Wifi Direct settings." into pi-dev
Fan Zhang [Thu, 5 Apr 2018 20:48:55 +0000 (13:48 -0700)]
Create help link placeholder for Wifi Direct settings.
Change-Id: Ia22259d191d2663d7ef63438c680826d3fd590fb
Merged-In: Ia22259d191d2663d7ef63438c680826d3fd590fb
Fixes:
70854725
Test: robotests
Doris Ling [Fri, 6 Apr 2018 23:00:30 +0000 (23:00 +0000)]
Merge "Adjust alignment for suggestion icon." into pi-dev
Lei Yu [Fri, 6 Apr 2018 21:50:05 +0000 (14:50 -0700)]
Add NullPtrCheck when smearing in settings
This only happens in new device with broken power_profile.xml, in
which it doesn't have screen power model.
This CL catches the null pointer crash and log it.
Change-Id: Iac23e3a8fc51385bdb22979c4b59000319f6fd49
Fixes:
74617269
Test: RunSettingsRoboTests
TreeHugger Robot [Fri, 6 Apr 2018 22:42:17 +0000 (22:42 +0000)]
Merge "Import translations. DO NOT MERGE" into pi-dev
TreeHugger Robot [Fri, 6 Apr 2018 22:29:02 +0000 (22:29 +0000)]
Merge "Prioritize dynamic summaries" into pi-dev
Doris Ling [Tue, 3 Apr 2018 00:17:42 +0000 (17:17 -0700)]
Adjust alignment for suggestion icon.
- add margin to the suggestion icon so that it align properly with the
suggestion text.
- also align the action button with the suggestion icon and text.
Change-Id: Ic12e4160d6583cf2d837e65ee5fd5a1ad73d348d
Fixes:
74414989
Test: visual
Matthew Fritze [Wed, 4 Apr 2018 23:58:56 +0000 (16:58 -0700)]
Prioritize dynamic summaries
If both Xml and a controller provide a summary,
the controller's should be prioritized.
Change-Id: I030746b0f253ce4884a7868e385069b208f63082
Fixes:
77602860
Test: robotests
Erik Kline [Fri, 6 Apr 2018 21:07:59 +0000 (14:07 -0700)]
Fix test expectations for NetworkCallbacks
Test: as follows
- built
- flashed
- booted
- make -j50 RunSettingsRoboTests ROBOTEST_FILTER=WifiMasterSwitchPreferenceControllerTest
Bug:
64133961
Bug:
77285360
Change-Id: I1ada2888d0c5517f3bcde646bf8efab331330cfd
Julia Reynolds [Fri, 6 Apr 2018 20:48:31 +0000 (20:48 +0000)]
Merge "Make volume sliders sliceable" into pi-dev
Mehdi Alizadeh [Fri, 6 Apr 2018 20:46:18 +0000 (20:46 +0000)]
Merge "Adds strings for Swipe Up gesture in Settings" into pi-dev
TreeHugger Robot [Fri, 6 Apr 2018 20:46:00 +0000 (20:46 +0000)]
Merge "Add test for anomaly detection in P" into pi-dev
Mehdi Alizadeh [Wed, 4 Apr 2018 23:43:12 +0000 (16:43 -0700)]
Adds strings for Swipe Up gesture in Settings
Bug:
77549883
Test: None
Change-Id: I64b448f3a3564e8ac6d29e1241e84032708dba71
TreeHugger Robot [Fri, 6 Apr 2018 20:39:24 +0000 (20:39 +0000)]
Merge "Exempt tests from hidden API checks." into pi-dev
TreeHugger Robot [Fri, 6 Apr 2018 20:35:41 +0000 (20:35 +0000)]
Merge "Change "More details" to "Learn more" in policy transparency dialog." into pi-dev
TreeHugger Robot [Fri, 6 Apr 2018 20:26:24 +0000 (20:26 +0000)]
Merge "Add battery illustration" into pi-dev
TreeHugger Robot [Fri, 6 Apr 2018 20:19:21 +0000 (20:19 +0000)]
Merge "Add name and icon for AOD" into pi-dev
TreeHugger Robot [Fri, 6 Apr 2018 19:28:55 +0000 (19:28 +0000)]
Merge "Add anomaly log to dumpsys" into pi-dev
Lei Yu [Wed, 4 Apr 2018 19:16:18 +0000 (12:16 -0700)]
Add test for anomaly detection in P
Lot of tests have been added already, this CL adds the missing tests
after robolectric upgrade.
Also add UID_NULL check in AnomalyDetectionJobService. It is almost
impossible to happen however we better catch it.
Bug:
73172999
Test: RunSettingsRoboTests
Change-Id: I950537efb166b0900393df1321ca64151b43e906
Lei Yu [Fri, 6 Apr 2018 17:19:19 +0000 (17:19 +0000)]
Merge "Hide app if it shares uid with whitelisted app" into pi-dev
TreeHugger Robot [Fri, 6 Apr 2018 17:15:46 +0000 (17:15 +0000)]
Merge "Update SliceContollerInXmlTest to match latest slice spec." into pi-dev
TreeHugger Robot [Fri, 6 Apr 2018 17:12:01 +0000 (17:12 +0000)]
Merge "Disable user control of color mode depending on Accessibility" into pi-dev
TreeHugger Robot [Fri, 6 Apr 2018 16:32:35 +0000 (16:32 +0000)]
Merge "apostrophe should be curly" into pi-dev
Nicolas Geoffray [Fri, 6 Apr 2018 13:29:03 +0000 (14:29 +0100)]
Exempt tests from hidden API checks.
Bug:
64382372
Bug:
74963051
Test: m
Change-Id: I4e51a8a7d86ac79668f66057daf550a8f04711dd
arangelov [Thu, 5 Apr 2018 14:05:12 +0000 (15:05 +0100)]
Change "More details" to "Learn more" in policy transparency dialog.
Screenshot: https://screenshot.googleplex.com/5xrwW3g29qa.png
Bug:
77618738
Test: none
Change-Id: I464f492cd6b1468b85b5a691c29ae7a982ecebff
Bill Yi [Thu, 5 Apr 2018 23:59:06 +0000 (16:59 -0700)]
Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Bug:
64712476
Change-Id: I065e2a1271c2f8e4dba989736069982ed6be7f9d
TreeHugger Robot [Thu, 5 Apr 2018 23:41:47 +0000 (23:41 +0000)]
Merge ""Data Warn & Limits" pref. summary should be empty." into pi-dev
TreeHugger Robot [Thu, 5 Apr 2018 23:33:40 +0000 (23:33 +0000)]
Merge "Add new string for sound settings" into pi-dev
TreeHugger Robot [Thu, 5 Apr 2018 23:12:21 +0000 (23:12 +0000)]
Merge "Import translations. DO NOT MERGE" into pi-dev
Lei Yu [Thu, 5 Apr 2018 22:01:52 +0000 (15:01 -0700)]
Add name and icon for AOD
Keep it in both app list and full usage list for now,
so we don't need to update smearing code.
Bug:
77156569
Test: Screenshot | RunSettingsRoboTests
Change-Id: I5247da90ea591b226cafef8f2d1ffcbff387b62f
TreeHugger Robot [Thu, 5 Apr 2018 22:47:23 +0000 (22:47 +0000)]
Merge "Change "X over" text color to ColorError" into pi-dev
Andreas Terzis [Fri, 30 Mar 2018 06:19:10 +0000 (23:19 -0700)]
"Data Warn & Limits" pref. summary should be empty.
The "Data Warning & Limits" preference in the Data Usage screen
should not have a summary.
Bug:
77300376
Test: manual
Test: make RunSettingsRoboTests
Change-Id: Ic567e7451ac3ea102577ab96ccef3ce7de05d4ad
Lei Yu [Thu, 5 Apr 2018 20:38:58 +0000 (13:38 -0700)]
Hide app if it shares uid with whitelisted app
Statsd blame app based on uid, which may mapping to multiple packages.
If there is one app in whitelist, then we shouldn't blame other apps
in anomaly detection.
Change-Id: Ib546e207eb113cef9ef5fecb1138e61558e9cf55
Fixes:
77560853
Test: RunSettingsRoboTests
TreeHugger Robot [Thu, 5 Apr 2018 22:07:30 +0000 (22:07 +0000)]
Merge "Update WifiScanningRequiredFragment dialog to show help page" into pi-dev
TreeHugger Robot [Thu, 5 Apr 2018 21:36:59 +0000 (21:36 +0000)]
Merge "Do not use warning or limit to display "X B left" above usage bar" into pi-dev
Bill Yi [Thu, 5 Apr 2018 21:34:11 +0000 (14:34 -0700)]
Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Bug:
64712476
Change-Id: I08041a5d5d29533296012921a6d53956948ad527
TreeHugger Robot [Thu, 5 Apr 2018 21:23:24 +0000 (21:23 +0000)]
Merge "Update the anomaly type constants" into pi-dev
TreeHugger Robot [Thu, 5 Apr 2018 21:02:51 +0000 (21:02 +0000)]
Merge "Import translations. DO NOT MERGE" into pi-dev
Fan Zhang [Thu, 5 Apr 2018 18:19:45 +0000 (11:19 -0700)]
Update SliceContollerInXmlTest to match latest slice spec.
- Convert the test to use CodeInspector
- Skip abstract classes when validating contract
- Also check SliderPreferenceController when validating contract
Change-Id: I671c1a622df6d1d7248a12932f144711fbf5a026
Fixes:
77634230
Test: make RunSettingsRoboTests -j40 ROBOTEST_FILTER=CodeIns
TreeHugger Robot [Thu, 5 Apr 2018 20:50:06 +0000 (20:50 +0000)]
Merge "Update launch intent flags for settings shortcut widgets." into pi-dev
Salvador Martinez [Thu, 5 Apr 2018 00:34:32 +0000 (17:34 -0700)]
Update WifiScanningRequiredFragment dialog to show help page
This CL updates the WifiScanningRequiredFragment dialog so that the
learn more button is only shown when a help page is available.
Additionally, we add the metrics constant for the dialog.
Test: robotests
Bug:
67070896
Change-Id: I7697c88b5969edaf5c06eb33251f215b776c64ee
Jan Nordqvist [Wed, 4 Apr 2018 22:54:26 +0000 (15:54 -0700)]
Do not use warning or limit to display "X B left" above usage bar
Bug:
70950124
Test: manual
Test: make RunSettingsRoboTests
Change-Id: I46f4f5f1cf6092038e49beaafe5aa6a19ffb0aa1
TreeHugger Robot [Thu, 5 Apr 2018 19:59:00 +0000 (19:59 +0000)]
Merge "Fall back to Wi-Fi data display in data usage screen with no SIM." into pi-dev
Bill Yi [Thu, 5 Apr 2018 19:33:14 +0000 (12:33 -0700)]
Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Bug:
64712476
Change-Id: I2be2f8d5061e7b01fd97170d861d68980db9e665
TreeHugger Robot [Thu, 5 Apr 2018 19:02:11 +0000 (19:02 +0000)]
Merge "Couple more Scoped Directory Access changes." into pi-dev
Julia Reynolds [Tue, 3 Apr 2018 17:48:55 +0000 (13:48 -0400)]
Make volume sliders sliceable
Test: make -j RunSettingsRoboTests
Change-Id: I8495770792dfdada54174ca61937f336e4fc219c
Fixes:
67997207
Lei Yu [Thu, 5 Apr 2018 01:06:16 +0000 (18:06 -0700)]
Update the anomaly type constants
Bug:
77323601
Test: Build
Change-Id: I0b6733edbfe12f494104f78be7087fa621191431
Lei Yu [Thu, 5 Apr 2018 17:48:55 +0000 (17:48 +0000)]
Merge "Show Battery saver tip when battery saver is on" into pi-dev
TreeHugger Robot [Thu, 5 Apr 2018 17:46:21 +0000 (17:46 +0000)]
Merge "Fix crash in Monkey test." into pi-dev
Lei Yu [Fri, 30 Mar 2018 16:50:02 +0000 (09:50 -0700)]
Add battery illustration
Also update the VideoPreference to handle the full screen
illustration by adding attr isFullWidth and aspectRadio.
Change-Id: If2ccba4ce792801c6fd79b7c60af4e3826c091cc
Fixes:
74409022
Test: Screenshot | RunSettingsRoboTests
Doris Ling [Mon, 2 Apr 2018 21:51:36 +0000 (14:51 -0700)]
Update launch intent flags for settings shortcut widgets.
- earlier changes were made to the intent flags when creating new
settings shortcut to ensure that it is launching a new task. However,
ShortcutManager is actually caching existing shortcut info, and it will
continue to use the existing shortcut info unless we explicitly update
the info.
- when rebooting from build upgrade, we will go through all existing
shortcut to update the launch intent flags to ensure that the shortcut
info is update to date.
Change-Id: Iee2365d9aec64a47b193e3c9be443c252504815b
Fixes:
76395879
Test: make RunSettingsRoboTests
TreeHugger Robot [Thu, 5 Apr 2018 17:12:43 +0000 (17:12 +0000)]
Merge "Fix issue in ring volume sample not always being played." into pi-dev
Lei Yu [Thu, 5 Apr 2018 16:57:13 +0000 (16:57 +0000)]
Merge "Hide uninstalled app in restrict app dialog" into pi-dev
Jan Nordqvist [Thu, 5 Apr 2018 16:30:43 +0000 (09:30 -0700)]
Change "X over" text color to ColorError
Bug:
70950124
Test: manual
Test: make RunSettingsRoboTests
Change-Id: I2a59d6b4b4549a780ae168e9e1b3f356c677262c
TreeHugger Robot [Thu, 5 Apr 2018 16:20:25 +0000 (16:20 +0000)]
Merge "Update settings to reference correct versionCode" into pi-dev
Bill Yi [Thu, 5 Apr 2018 14:28:37 +0000 (07:28 -0700)]
Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Bug:
64712476
Change-Id: I3feadbd392d82249b0318377310b4d1155057773
TreeHugger Robot [Thu, 5 Apr 2018 04:57:46 +0000 (04:57 +0000)]
Merge "Fix a bug where homepage is using staled locale for tiles" into pi-dev
TreeHugger Robot [Thu, 5 Apr 2018 03:55:05 +0000 (03:55 +0000)]
Merge "Import translations. DO NOT MERGE" into pi-dev
Lei Yu [Wed, 4 Apr 2018 20:30:42 +0000 (13:30 -0700)]
Show Battery saver tip when battery saver is on
Before this CL, we only show "Battery Saver is on" when users turn it
on in battery tips.
In this CL, we change to constantly show this tip when battery
saver is on.
Change-Id: I9ddefdbd5818725202ddf4469b4a685ba008060a
Fixes:
75251000
Test: RunSettingsRoboTests
Bill Yi [Thu, 5 Apr 2018 01:18:03 +0000 (18:18 -0700)]
Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Bug:
64712476
Change-Id: Ibf6633b42d66e2c1418c2c3b719533a36c696f6a
Doris Ling [Thu, 5 Apr 2018 00:35:41 +0000 (17:35 -0700)]
Fix issue in ring volume sample not always being played.
- when we adjust the sound volme in Sound settings, we only re-post the
stop sample message when we receive the onSampleStarting callback.
However, if we change the volume while a sample is still playing,
onSampleStarting will not be called as it's already started. This
results in shortened sample duration, which in extreme case, the new
sample will not be played at all if the new volume change is made almost
towards the end of the previous sample period. So, everytime user change
the volume, we should re-post the stop sample message, so that the
sample playing duration would be extended properly.
- also removed the original calls to the onStreamValueChanged() during
init, as the original implementation is empty, and during init, we do
not need any handling to start/stop the sample.
Change-Id: I9f35ddfb6d809eeb83b1a732a09362286ff6ed77
Fixes:
77514234
Test: make RunSettingsRoboTests
Fan Zhang [Wed, 4 Apr 2018 22:51:06 +0000 (15:51 -0700)]
Fix a bug where homepage is using staled locale for tiles
When setting a new locale, SettingsActivity restarts to load
everything in the new locale.
Data (containing locale specific title/summary etc) is reloaded
correctly and triggers a callback to UI to redraw.
However we skip the first callback as an optimization for app startup
time. When we restart fragment, we failed to save the state whether we
have already seen the first callback. So when data with new locale text
triggers the callback, it's being skipped and this make UI still render
in old locale.
The fix is to just save the state before fragment gets destroyed before
locale change so the callback can trigger later.
A better fix is: make data (Tile object) not cache text. Then we don't
need to worry about locale cache at all. We should do this fix in the
long term.
Test: localeswitcher
Test: adb shell am broadcast -a com.google.android.testing.i18n.localeswitcher.CHANGE_LOCALE -e LANGUAGE_TAG "zh"
Test: adb shell am broadcast -a com.google.android.testing.i18n.localeswitcher.CHANGE_LOCALE -e LANGUAGE_TAG "ja"
Fixes:
77470788
Bug:
77600770
Change-Id: Ic4223ddbb679db64d0fc3c29d16a5f61a66cc99c
TreeHugger Robot [Wed, 4 Apr 2018 23:59:49 +0000 (23:59 +0000)]
Merge "Fix crash in non-indexable keys collection" into pi-dev
Daniel Solomon [Sat, 31 Mar 2018 01:11:38 +0000 (18:11 -0700)]
Disable user control of color mode depending on Accessibility
The Accessibility settings for color inversion and color correction are
incompatible with some color modes. When either of these settings is
enabled, disable GUI color mode controls.
Bug:
68856024
Change-Id: I12fad22190283bac38592b94e88d865d3af978ad
Jan Nordqvist [Mon, 26 Mar 2018 22:29:44 +0000 (15:29 -0700)]
Fall back to Wi-Fi data display in data usage screen with no SIM.
Bug:
70950124
Test: manual
Test: make RunSettingsRoboTests
Change-Id: I06bf78e54119819be87e15baca7e5b6a241958cb
Merged-In: I06bf78e54119819be87e15baca7e5b6a241958cb
TreeHugger Robot [Wed, 4 Apr 2018 22:40:27 +0000 (22:40 +0000)]
Merge "Updates to match prebuilts drop" into pi-dev
TreeHugger Robot [Wed, 4 Apr 2018 21:30:32 +0000 (21:30 +0000)]
Merge "Expressly forbid IP string literals as Private DNS hostnames" into pi-dev
Makoto Onuki [Wed, 4 Apr 2018 19:45:52 +0000 (12:45 -0700)]
Once auto-battery saver is ever set, don't show suggestion
Bug:
77228046
Test: manual test after adb shell settings delete secure suppress_auto_battery_saver_suggestion
Test: m -j ROBOTEST_FILTER=BatterySaverButtonPreferenceControllerTest RunSettingsRoboTests
Change-Id: If0d26f05399a33269d9540e6e09292ce46765637
TreeHugger Robot [Wed, 4 Apr 2018 20:37:15 +0000 (20:37 +0000)]
Merge "Log when settings slice is requested/updated." into pi-dev
Matthew Fritze [Wed, 4 Apr 2018 16:56:53 +0000 (09:56 -0700)]
Fix crash in non-indexable keys collection
Some of the AmbientDisplay preference controllers were
crashing when their isAvailable methods were being called
by their fragment's search index providers, which meant that
the entire collection of non-indexable keys failed. Thus,
all search results were showing up. In the case of a secondary
user, they were able to see developer options which crashed
settings when clicked.
There are two issues addressed in this cl.
1. Fix the crashes so the non-indexable keys collection works
2. Contain each fragment's collection, so that if a fragment does
crash, the damage is minimized.
Part 1 is checking that the config in isAvailable is not null,
and creating one if so.
Part 2 is fixed by surrounding the collection of non-indexable
keys in a try-catch, with an option in the catch to re-throw the
error if a system property is set. Thus, in a new pre-submit
instrumentation test, we can and docheck if any of the fragments crash
when collecting non-indexable keys.
Change-Id: I820bd9cb2649aa6faff7f82fcf575a62e41dc4fc
Fixes:
77486668
Test: atest NonIndexableCrashTest, robotests
Patrick Baumann [Wed, 4 Apr 2018 20:17:05 +0000 (13:17 -0700)]
Update settings to reference correct versionCode
This settings change is required for a framework change that ensures
that apps built for pre-P that rely on reflection to access
ApplicationInfo#versionCode don't crash. The move to long version
code introduces a new field and all modifications of the field are
wrapped in a method that ensures both the new and old fields are set
appropriately.
Bug:
74393568
Test: manual - builds and broken app runs
Change-Id: Idfa5f85d3f91583098ebee88f0e8caecaacff9b4
TreeHugger Robot [Wed, 4 Apr 2018 20:10:11 +0000 (20:10 +0000)]
Merge "Use grey icon for work profile settings" into pi-dev