OSDN Git Service
Peter Eisentraut [Wed, 17 Mar 2010 22:02:44 +0000 (22:02 +0000)]
Don't link PL/Python against LOCALMODLIBS
This variable is apparently only for Python internally. In newer releases
of Python this variable pulls in more and more libraries that users are
less likely to have, leading to potential build failures.
Peter Eisentraut [Wed, 17 Mar 2010 21:31:17 +0000 (21:31 +0000)]
Message style tuning
Peter Eisentraut [Wed, 17 Mar 2010 20:58:38 +0000 (20:58 +0000)]
Fix peculiar, untranslatable message concatenation attempt
Peter Eisentraut [Wed, 17 Mar 2010 20:53:19 +0000 (20:53 +0000)]
Make typography consistent
Magnus Hagander [Wed, 17 Mar 2010 18:03:55 +0000 (18:03 +0000)]
Typo fixes.
Fujii Masao
Peter Eisentraut [Wed, 17 Mar 2010 17:12:31 +0000 (17:12 +0000)]
Update broken and permanently moved links
Tom Lane [Wed, 17 Mar 2010 16:52:38 +0000 (16:52 +0000)]
Pass incompletely-transformed aggregate argument lists as separate parameters
to transformAggregateCall, instead of abusing fields in Aggref to carry them
temporarily. No change in functionality but hopefully the code is a bit
clearer now. Per gripe from Gokulakannan Somasundaram.
Tom Lane [Wed, 17 Mar 2010 15:55:50 +0000 (15:55 +0000)]
Fix incorrect example in CREATE INDEX reference page, per Josh Kupershmidt.
Also fix and uncomment an old example of creating a GIST index, and make
a couple of other minor editorial adjustments.
Simon Riggs [Wed, 17 Mar 2010 00:28:15 +0000 (00:28 +0000)]
Fix typo in streaming replication protocol docs.
Simon Riggs [Tue, 16 Mar 2010 16:03:24 +0000 (16:03 +0000)]
Fix typo in math function docs, spotted by Heikki.
Heikki Linnakangas [Tue, 16 Mar 2010 09:09:55 +0000 (09:09 +0000)]
Throw a nicer error message if a standby server attempts to connect while
the master is still in recovery. We don't support cascading slaves yet.
Patch by Fujii Masao, with slightly changed wording.
Simon Riggs [Mon, 15 Mar 2010 19:03:31 +0000 (19:03 +0000)]
Document that trig functions accept/return values in radians.
Simon Riggs [Mon, 15 Mar 2010 18:49:17 +0000 (18:49 +0000)]
Remove incorrect comment from GetWriteRecPtr(): the return value is always
correct, as described in comments at start of xlog.c
Tom Lane [Sun, 14 Mar 2010 04:17:54 +0000 (04:17 +0000)]
Update oidjoins regression test for 9.0.
Peter Eisentraut [Sat, 13 Mar 2010 20:55:05 +0000 (20:55 +0000)]
Add some more structure and bits of information to PL/Python documentation
Bruce Momjian [Sat, 13 Mar 2010 16:56:37 +0000 (16:56 +0000)]
Revert all keepalive moves, reevaluate.
Bruce Momjian [Sat, 13 Mar 2010 16:40:38 +0000 (16:40 +0000)]
Move more tcp keepalive macros to be consistent.
Bruce Momjian [Sat, 13 Mar 2010 15:35:46 +0000 (15:35 +0000)]
Move TCP keepalive macro definition
Jaime Casanova
Bruce Momjian [Sat, 13 Mar 2010 14:55:57 +0000 (14:55 +0000)]
Add libpq warning message if the .pgpass-retrieved password fails.
Add ERRCODE_INVALID_PASSWORD sqlstate error code.
Peter Eisentraut [Sat, 13 Mar 2010 11:00:19 +0000 (11:00 +0000)]
Update shared memory configuration information for Linux
In particular, the assertion that shmall is sufficiently sized by default
is slowly becoming untrue.
Bruce Momjian [Sat, 13 Mar 2010 03:09:04 +0000 (03:09 +0000)]
Document what user name email symbols are supported by tsearch.
Bruce Momjian [Sat, 13 Mar 2010 00:41:58 +0000 (00:41 +0000)]
Allow underscores in tsearch email addressses, per RFC 5322 and report
by Dan O'Hara.
Patch by Teodor Sigaev
Bruce Momjian [Sat, 13 Mar 2010 00:40:43 +0000 (00:40 +0000)]
Small adjustment by pgindent.
Bruce Momjian [Fri, 12 Mar 2010 23:21:48 +0000 (23:21 +0000)]
Re-add comma, oops.
Tom Lane [Fri, 12 Mar 2010 22:19:19 +0000 (22:19 +0000)]
Add some logging code for unexpected cases in pgstat.c, particularly being
unable to read a stats file for reasons other than ENOENT, and having to reset
last_statrequest because it's later than current time in the collector.
Not clear if this will shed any light on the "pgstat wait timeout" business,
but it seems like a good idea in general.
In passing, do some message-style-police work on recently-added
pgstat_reset_shared_counters code.
Tom Lane [Fri, 12 Mar 2010 21:40:36 +0000 (21:40 +0000)]
Fix a commented-out block of code that pgindent didn't understand
properly; it's been making that comment uglier with each run.
Bruce Momjian [Fri, 12 Mar 2010 17:46:07 +0000 (17:46 +0000)]
Remove unnecessary comma in documentation.
Tom Lane [Thu, 11 Mar 2010 21:47:19 +0000 (21:47 +0000)]
Add missing reset of need_initialization in reloptions code.
This resulted in useless extra work during every call of parseRelOptions,
but no bad effects other than that. Noted by Alvaro.
Tom Lane [Thu, 11 Mar 2010 21:29:32 +0000 (21:29 +0000)]
Modify psql's \d printout to fold exclusion constraints in with regular
indexes, rather than printing them twice. Per my gripe when the exclusion
constraint feature was committed.
Tom Lane [Thu, 11 Mar 2010 18:43:24 +0000 (18:43 +0000)]
Sync timezone code with tzcode 2010c from the Olson group. This fixes some
corner cases that come up in certain timezones (apparently, only those with
lots and lots of distinct TZ transition rules, as far as I can gather from
a quick scan of their archives). Per suggestion from Jeevan Chalke.
Back-patch to 8.4. Possibly we need to push this into earlier releases
as well, but I'm hesitant to update them to the 64-bit tzcode without
more thought and testing.
Heikki Linnakangas [Thu, 11 Mar 2010 09:26:59 +0000 (09:26 +0000)]
Fix bug in KnownAssignedXidsMany(). I saw this when looking at the
assertion failure reported by Erik Rijkers, but this alone doesn't explain
the failure.
Heikki Linnakangas [Thu, 11 Mar 2010 09:10:25 +0000 (09:10 +0000)]
Fix comment which was apparently copy-pasted from another function.
Tom Lane [Thu, 11 Mar 2010 04:36:43 +0000 (04:36 +0000)]
Simplify a couple of pg_dump and psql \d queries about index constraints
by joining to pg_constraint.conindid, instead of the former technique of
joining indirectly through pg_depend. This is much more straightforward
and probably faster as well. I had originally desisted from changing these
queries when conindid was added because I was worried about losing
performance, but if we join on conrelid as well as conindid then the index
on conrelid can be used when pg_constraint is large.
Tom Lane [Thu, 11 Mar 2010 03:36:22 +0000 (03:36 +0000)]
Update comment for pg_constraint.conindid to mention that it's used for
exclusion constraints. Not sure how we managed to update the comment for
it in catalogs.sgml but miss this one.
Robert Haas [Wed, 10 Mar 2010 19:48:39 +0000 (19:48 +0000)]
Fix incorrect comment about permissions checking being done in utility.c.
Noted while reviewing a patch from KaiGai Kohei.
Itagaki Takahiro [Wed, 10 Mar 2010 02:04:48 +0000 (02:04 +0000)]
pg_start_backup() can use a share lock to lock ControlFileLock
instead of an exclusive lock.
The change is almost for code cleanup. Since there seems to be no
performance benefits from it, backports should not be needed.
Fujii Masao
Tom Lane [Wed, 10 Mar 2010 01:58:11 +0000 (01:58 +0000)]
Preliminary release notes for releases 8.4.3, 8.3.10, 8.2.16, 8.1.20, 8.0.24,
7.4.28.
Tom Lane [Tue, 9 Mar 2010 22:34:38 +0000 (22:34 +0000)]
Use SvROK(sv) rather than directly checking SvTYPE(sv) == SVt_RV in plperl.
The latter is considered unwarranted chumminess with the implementation,
and can lead to crashes with recent Perl versions.
Report and fix by Tim Bunce. Back-patch to all versions containing the
questionable coding pattern.
Alvaro Herrera [Tue, 9 Mar 2010 14:27:28 +0000 (14:27 +0000)]
Update time zone data files to tzdata release 2010d: DST law changes in Fiji,
Samoa, Chile; corrections to recent changes in Paraguay and Bangladesh.
Michael Meskes [Tue, 9 Mar 2010 11:09:46 +0000 (11:09 +0000)]
ecpg now adds a unique counter to its varchar struct definitions to make these definitions unique, too. It used to use the linenumber but in the rare case of two definitions in one line this was not unique.
Andrew Dunstan [Tue, 9 Mar 2010 02:48:33 +0000 (02:48 +0000)]
Add checks for valid encoding of query strings passed to SPI by plperl.
Bruce Momjian [Mon, 8 Mar 2010 23:03:00 +0000 (23:03 +0000)]
Return proper exit code (3) from psql when ON_ERROR_STOP=on and
--single-transaction are both used and the failure happens in commit,
e.g. failed deferred trigger. Also properly free BEGIN/COMMIT result
structures from --single-transaction.
Per report from Dominic Bevacqua
Magnus Hagander [Mon, 8 Mar 2010 12:38:37 +0000 (12:38 +0000)]
Add missing space in example.
Tim Landscheidt
Michael Meskes [Mon, 8 Mar 2010 12:15:24 +0000 (12:15 +0000)]
Better test the content of the SQLSTATE string in ecpglib than the pointer.
Magnus Hagander [Mon, 8 Mar 2010 10:01:12 +0000 (10:01 +0000)]
Require hostname to be set when using GSSAPI authentication. Without it,
the GSSAPI libraries crash.
Noted by Zdenek Kotala
Magnus Hagander [Mon, 8 Mar 2010 09:57:26 +0000 (09:57 +0000)]
Disallow gssapi authentication on local connections, since it
requires a hostname to function.
Noted by Zdenek Kotala
Tom Lane [Mon, 8 Mar 2010 01:18:09 +0000 (01:18 +0000)]
Update time zone data files to tzdata release 2010c: DST law changes in
Bangladesh, Mexico, Paraguay.
Magnus Hagander [Sun, 7 Mar 2010 17:02:34 +0000 (17:02 +0000)]
Revert patch for --psqlrc=FILENAME in psql.
Tom Lane [Sat, 6 Mar 2010 23:10:42 +0000 (23:10 +0000)]
Fix warning messages in restrict_and_check_grant() to include the column name
when warning about column-level privileges. This is more useful than before
and makes the apparent duplication complained of by Piyush Newe not so
duplicate. Also fix lack of quote marks in a related message text.
Back-patch to 8.4, where column-level privileges were introduced.
Stephen Frost
Magnus Hagander [Sat, 6 Mar 2010 15:28:09 +0000 (15:28 +0000)]
Add --psqlrc=FILENAME parameter to psql, to process an explicitly named
file instead of ~/.psqlrc on startup.
Tom Lane [Sat, 6 Mar 2010 00:45:49 +0000 (00:45 +0000)]
When reading pg_hba.conf and similar files, do not treat @file as an inclusion
unless (1) the @ isn't quoted and (2) the filename isn't empty. This guards
against unexpectedly treating usernames or other strings in "flat files"
as inclusion requests, as seen in a recent trouble report from Ed L.
The empty-filename case would be guaranteed to misbehave anyway, because our
subsequent path-munging behavior results in trying to read the directory
containing the current input file.
I think this might finally explain the report at
http://archives.postgresql.org/pgsql-bugs/2004-05/msg00132.php
of a crash after printing "authentication file token too long, skipping",
since I was able to duplicate that message (though not a crash) on a
platform where stdio doesn't refuse to read directories. We never got
far in investigating that problem, but now I'm suspicious that the trigger
condition was an @ in the flat password file.
Back-patch to all active branches since the problem can be demonstrated in all
branches except HEAD. The test case, creating a user named "@", doesn't cause
a problem in HEAD since we got rid of the flat password file. Nonetheless it
seems like a good idea to not consider quoted @ as a file inclusion spec,
so I changed HEAD too.
Michael Meskes [Fri, 5 Mar 2010 13:57:09 +0000 (13:57 +0000)]
In case the connection magically disappears libecpg only returns an internal
error sqlstate. This change makes it return a correct value..
Heikki Linnakangas [Thu, 4 Mar 2010 09:39:53 +0000 (09:39 +0000)]
Fix IsBinaryCoercible to not confuse a cast using in/out functions
with binary compatibility.
Backpatch to 8.4 where INOUT casts were introduced.
Bruce Momjian [Wed, 3 Mar 2010 23:38:44 +0000 (23:38 +0000)]
Add C comment about DDL changes possibly causing pg_dump errors.
Bruce Momjian [Wed, 3 Mar 2010 22:28:42 +0000 (22:28 +0000)]
Document that "Q" is ignored by to_date and to_timestamp. Add C comment
about the behavior.
Document that quotes in to_date, to_timestamp, to_number skip input
characters.
Tom Lane [Wed, 3 Mar 2010 20:31:09 +0000 (20:31 +0000)]
Fix a couple of places that would loop forever if attempts to read a stdio file
set ferror() but never set feof(). This is known to be the case for recent
glibc when trying to read a directory as a file, and might be true for other
platforms/cases too. Per report from Ed L. (There is more that we ought to
do about his report, but this is one easily identifiable issue.)
Heikki Linnakangas [Wed, 3 Mar 2010 20:10:48 +0000 (20:10 +0000)]
Fix pg_dump of ACLs of foreign servers. The command to grant/revoke
privileges of foreign servers is "GRANT ... ON *FOREIGN* SERVER ...".
Tom Lane [Wed, 3 Mar 2010 19:10:22 +0000 (19:10 +0000)]
Make contrib/xml2 use core xml.c's error handler, when available (that is,
in versions >= 8.3). The core code is more robust and efficient than what
was there before, and this also reduces risks involved in swapping different
libxml error handler settings.
Before 8.3, there is still some risk of problems if add-on modules such as
Perl invoke libxml without setting their own error handler. Given the lack
of reports I'm not sure there's a risk in practice, so I didn't take the
step of actually duplicating the core code into older contrib/xml2 branches.
Instead I just tweaked the existing code to ensure it didn't leave a dangling
pointer to short-lived memory when throwing an error.
Tom Lane [Wed, 3 Mar 2010 17:29:45 +0000 (17:29 +0000)]
Export xml.c's libxml-error-handling support so that contrib/xml2 can use it
too, instead of duplicating the functionality (badly).
I renamed xml_init to pg_xml_init, because the former seemed just a bit too
generic to be safe as a global symbol. I considered likewise renaming
xml_ereport to pg_xml_ereport, but felt that the reference to ereport probably
made it sufficiently PG-centric already.
Andrew Dunstan [Wed, 3 Mar 2010 03:29:37 +0000 (03:29 +0000)]
Make iconv work like other optional libraries for MSVC.
Bruce Momjian [Wed, 3 Mar 2010 03:23:12 +0000 (03:23 +0000)]
Fix SGML markup.
Bruce Momjian [Wed, 3 Mar 2010 03:14:08 +0000 (03:14 +0000)]
Restructure CREATE FUNCTION "NOTES" section to be shorter; move items
into proper sections, per suggestion from Tom.
Tom Lane [Wed, 3 Mar 2010 01:53:17 +0000 (01:53 +0000)]
Instead of trying (and failing) to allow <<label>> at the end of a DECLARE
section, throw an error message saying explicitly that the label must go
before DECLARE. Per investigation of a recent pgsql-novice question,
this code did not work as intended in any modern PG version, maybe not ever.
Allowing such a thing would only create ambiguity anyway, so it seems better
to remove it than fix it.
Bruce Momjian [Tue, 2 Mar 2010 23:38:17 +0000 (23:38 +0000)]
Adjust max_standby_delay documentation to be clearer, and mention that
two adjacent long-running queries have much less than max_standby_delay
before query cancel is possible.
Andrew Dunstan [Tue, 2 Mar 2010 22:02:31 +0000 (22:02 +0000)]
Add missing library and include dir for XSLT in MSVC builds
Bruce Momjian [Tue, 2 Mar 2010 21:18:59 +0000 (21:18 +0000)]
Document the effect of max_standby_delay on increasing the delay of data
from master to slave, and discourage its use during slave/master
keep-xid-alive connections.
Peter Eisentraut [Tue, 2 Mar 2010 20:40:48 +0000 (20:40 +0000)]
Update keywords list for 9.0
Andrew Dunstan [Tue, 2 Mar 2010 17:06:51 +0000 (17:06 +0000)]
Do not run regression tests for contrib/xml2 on MSVC unless building with XML
Tom Lane [Tue, 2 Mar 2010 16:14:39 +0000 (16:14 +0000)]
Cause plpgsql to throw an error if "INTO rowtype_var" is followed by a comma.
Per bug #5352, this helps to provide a useful error message if the user
tries to do something presently unsupported, namely use a rowtype variable
as a member of a multiple-item INTO list.
Andrew Dunstan [Tue, 2 Mar 2010 12:29:14 +0000 (12:29 +0000)]
Add XSLT defines for MSVC builds
Heikki Linnakangas [Mon, 1 Mar 2010 21:27:26 +0000 (21:27 +0000)]
Fix translation of strings in psql \d output (translation in headers worked,
but not in cells).
Heikki Linnakangas [Mon, 1 Mar 2010 20:55:45 +0000 (20:55 +0000)]
Fix numericlocale psql option when used with a null string and latex and troff
formats; a null string must not be formatted as a numeric. The more exotic
formats latex and troff also incorrectly formatted all strings as numerics
when numericlocale was on.
Backpatch to 8.1 where numericlocale option was added.
This fixes bug #5355 reported by Andy Lester.
Tom Lane [Mon, 1 Mar 2010 18:07:59 +0000 (18:07 +0000)]
Fix contrib/xml2 so regression test still works when it's built without libxslt.
This involves modifying the module to have a stable ABI, that is, the
xslt_process() function still exists even without libxslt. It throws a
runtime error if called, but doesn't prevent executing the CREATE FUNCTION
call. This is a good thing anyway to simplify cross-version upgrades.
Magnus Hagander [Mon, 1 Mar 2010 16:02:01 +0000 (16:02 +0000)]
It's clearly now pointless to do backwards compatible parsing of this,
since we released a version without it, so remove the comment that
says we might want to do that.
Tom Lane [Mon, 1 Mar 2010 14:54:00 +0000 (14:54 +0000)]
Buildfarm still unhappy, so I'll bet it's EACCES not EPERM.
Tom Lane [Mon, 1 Mar 2010 05:16:35 +0000 (05:16 +0000)]
Remove xmlCleanupParser calls from contrib/xml2.
These are unnecessary and probably dangerous. I don't see any immediate
risk situations in the core XML support or contrib/xml2 itself, but there
could be issues with external uses of libxml2, and in any case it's an
accident waiting to happen.
Greg Stark [Mon, 1 Mar 2010 00:04:06 +0000 (00:04 +0000)]
add EPERM to the list of return codes to expect from opening directories based on Vista results
Tom Lane [Sun, 28 Feb 2010 21:31:57 +0000 (21:31 +0000)]
Fix up memory management problems in contrib/xml2.
Get rid of the code that attempted to funnel libxml2's memory allocations
into palloc. We already knew from experience with the core xml datatype
that trying to do this is simply not reliable. Unlike the core code, I
did not bother adding a lot of PG_TRY/PG_CATCH logic to try to ensure that
everything is cleaned up on error exit. Hence, we might leak some memory
if one of these functions fails partway through. Given the deprecated
status of this contrib module and the fact that errors partway through
the functions shouldn't be too common, it doesn't seem worth worrying about.
Also fix a separate bug in xpath_table, that it did the wrong things
if given a result tuple descriptor with less than 2 columns. While
such a case isn't very useful in practice, we shouldn't fail or stomp
memory when it occurs.
Add some simple regression tests based on all the reported crash cases
that I have on hand.
This should be back-patched, but let's see if the buildfarm likes it first.
Greg Stark [Sun, 28 Feb 2010 21:05:30 +0000 (21:05 +0000)]
Second try at fsyncing directories in CREATE DATABASE. Let's see what the build farm says of opening directories read-only and ignoring EBADF from fsync of directories
Tom Lane [Sun, 28 Feb 2010 19:51:37 +0000 (19:51 +0000)]
Assorted code cleanup for contrib/xml2. No change in functionality,
just make it a bit less ugly in places.
Bruce Momjian [Sun, 28 Feb 2010 02:20:40 +0000 (02:20 +0000)]
Update complex locale example in the documentation.
Bruce Momjian [Sun, 28 Feb 2010 02:19:47 +0000 (02:19 +0000)]
*** empty log message ***
Michael Meskes [Sat, 27 Feb 2010 21:56:16 +0000 (21:56 +0000)]
Make sure ecpg uses the same header files in the same order as the backend.
Tom Lane [Sat, 27 Feb 2010 21:53:21 +0000 (21:53 +0000)]
Insert a hack into get_float8_nan (both core and ecpg copies) to deal with
the fact that NetBSD/mips is currently broken, as per buildfarm member pika.
Also add regression tests to ensure that get_float8_nan and get_float4_nan
are exercised even on platforms where they are not needed by
float8in/float4in.
Zoltán Böszörményi and Tom Lane
Bruce Momjian [Sat, 27 Feb 2010 20:20:44 +0000 (20:20 +0000)]
Back out unintended change to pg_locale.c.
Bruce Momjian [Sat, 27 Feb 2010 20:16:17 +0000 (20:16 +0000)]
Document ATAPI FLUSH CACHE EXT.
Bruce Momjian [Sat, 27 Feb 2010 14:46:05 +0000 (14:46 +0000)]
Document trace_recovery_messages() parameter as an enum, not string.
Fujii Masao
Heikki Linnakangas [Sat, 27 Feb 2010 09:29:20 +0000 (09:29 +0000)]
Document max_standby_delay=-1 option, now that it's allowed again.
Tom Lane [Sat, 27 Feb 2010 04:29:44 +0000 (04:29 +0000)]
Entity-ify a few new uses of literal <, >, and &.
Tom Lane [Sat, 27 Feb 2010 03:55:52 +0000 (03:55 +0000)]
Undo some more pgindent breakage. Per buildfarm.
Bruce Momjian [Sat, 27 Feb 2010 03:41:34 +0000 (03:41 +0000)]
Use <> for libpq #include in example programs, per suggestion from Josh Berkus.
Bruce Momjian [Sat, 27 Feb 2010 01:39:46 +0000 (01:39 +0000)]
Document ATAPI drive flush command, and mention SSD drives.
Bruce Momjian [Fri, 26 Feb 2010 18:00:15 +0000 (18:00 +0000)]
Suggest gmake installcheck-world for pgindent testing.
Bruce Momjian [Fri, 26 Feb 2010 17:07:55 +0000 (17:07 +0000)]
Revert pgindent changes to ecpg include files that are part of ecpg
regession test output, and update pgindent script to avoid them in the
future.
Bruce Momjian [Fri, 26 Feb 2010 15:57:34 +0000 (15:57 +0000)]
Wording improvements to README.
Bruce Momjian [Fri, 26 Feb 2010 15:42:36 +0000 (15:42 +0000)]
Update pgindent docs to use maintainer-clean.
Bruce Momjian [Fri, 26 Feb 2010 13:50:34 +0000 (13:50 +0000)]
Document why pgindent wants a fresh CVS checkout.
Bruce Momjian [Fri, 26 Feb 2010 04:14:36 +0000 (04:14 +0000)]
In vacuumdb --help, call analyze "statistics", not "hints".
Bruce Momjian [Fri, 26 Feb 2010 02:58:49 +0000 (02:58 +0000)]
Call output file typedefs.list; update README.
Bruce Momjian [Fri, 26 Feb 2010 02:31:52 +0000 (02:31 +0000)]
Document pg_restore --jobs as a performance enhancement.