OSDN Git Service
Juergen Ributzka [Wed, 3 Sep 2014 07:07:10 +0000 (07:07 +0000)]
Reapply r216805 "[MachineCombiner][AArch64] Use the correct register class for MADD, SUB, and OR.""
This reapplies r216805 with a fix to a copy-past error, which resulted in an
incorrect register class.
Original commit message:
Select the correct register class for the various instructions that are
generated when combining instructions and constrain the registers to the
appropriate register class.
This fixes rdar://problem/
18183707.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217019
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Wed, 3 Sep 2014 06:07:54 +0000 (06:07 +0000)]
Recommit "Use unique_ptr to manager FilterChooser ownership."
Just using insert of a pair this time instead of emplace.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217018
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Wed, 3 Sep 2014 05:59:23 +0000 (05:59 +0000)]
Revert "Use unique_ptr to manager FilterChooser ownership."
std::map::emplace isn't working on some of the bots.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217015
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Wed, 3 Sep 2014 05:49:09 +0000 (05:49 +0000)]
Use unique_ptr to manager FilterChooser ownership.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217014
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Wed, 3 Sep 2014 05:49:07 +0000 (05:49 +0000)]
Implement move constructor and remove copy constructor for Filter objects in FixedLenDecoderEmitter. Also remove unused copy constructor of FilterChooser.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217013
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Wed, 3 Sep 2014 05:42:52 +0000 (05:42 +0000)]
[MCJIT] Make llvm-rtdyld process eh_frame sections in -verify mode (accidentally
left out of r217010).
Also remove a crufty debugging output statement that was accidentally left in.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217011
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Wed, 3 Sep 2014 05:01:46 +0000 (05:01 +0000)]
[MCJIT] Add a 'section_addr' builtin function to RuntimeDyldChecker.
The syntax of the new builtin is 'section_addr(<filename>, <section-name>)'
(similar to the stub_addr builtin, but without a symbol name). It returns the
base address of the given section in the given object file. This builtin makes
it possible to refer to the contents of sections that cannot contain symbols,
e.g. sections added by the linker itself, like __eh_frame.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217010
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Wed, 3 Sep 2014 01:38:36 +0000 (01:38 +0000)]
[FastISel][AArch64] Add target-dependent instruction selection for Add/Sub.
There is already target-dependent instruction selection support for Adds/Subs to
support compares and the intrinsics with overflow check. This takes advantage of
the existing infrastructure to also support Add/Sub, which allows the folding of
immediates, sign-/zero-extends, and shifts.
This fixes rdar://problem/
18207316.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217007
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Kledzik [Wed, 3 Sep 2014 01:34:58 +0000 (01:34 +0000)]
Fix test case to match correct llvm-objdump output
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217006
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Kledzik [Wed, 3 Sep 2014 01:12:52 +0000 (01:12 +0000)]
Replace printf with outs() <<
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217005
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Wed, 3 Sep 2014 01:06:50 +0000 (01:06 +0000)]
Change name of copyFlags() to copyIRFlags(). Add convenience method for logical 'and' of all flags. NFC.
Adding 'IR' to the names in an attempt to be less ambiguous about the flags we're dealing with here.
The 'and' method is needed by the SLPVectorizer (PR20802) and possibly other passes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217004
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Wed, 3 Sep 2014 00:06:47 +0000 (00:06 +0000)]
[CFLAA] Remove one final initializer list
Maybe MSVC will be happy now...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217000
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Tue, 2 Sep 2014 23:50:01 +0000 (23:50 +0000)]
[CFLAA] And even more MSVC fixes
Remove a couple more initializer lists and constexpr dependencies.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216998
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Bieneman [Tue, 2 Sep 2014 23:48:13 +0000 (23:48 +0000)]
Cleaning up remaining static initializers in Signals.inc
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216996
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Tue, 2 Sep 2014 23:29:48 +0000 (23:29 +0000)]
[CFLAA] More cleanup for MSVC
Remove more initializer lists, etc.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216994
91177308-0d34-0410-b5e6-
96231b3b80d8
Pete Cooper [Tue, 2 Sep 2014 23:23:34 +0000 (23:23 +0000)]
Tablegen scheduling models don't reference empty itineraries as of r216919, so don't emit the unused itinerary variables
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216993
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Tue, 2 Sep 2014 22:52:30 +0000 (22:52 +0000)]
[CFLAA] No initializer lists for MSVC
MSVC 2012 does not understand initializer lists; remove them.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216991
91177308-0d34-0410-b5e6-
96231b3b80d8
Renato Golin [Tue, 2 Sep 2014 22:46:18 +0000 (22:46 +0000)]
Missing test from r216989
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216990
91177308-0d34-0410-b5e6-
96231b3b80d8
Renato Golin [Tue, 2 Sep 2014 22:45:13 +0000 (22:45 +0000)]
Only emit movw on ARMv6T2+
Fix PR18364.
Patch by Dimitry Andric.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216989
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 2 Sep 2014 22:41:07 +0000 (22:41 +0000)]
unique_ptrify passing the TargetMachine to ExecutionEngine::MCJITCtor
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216988
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Tue, 2 Sep 2014 22:36:58 +0000 (22:36 +0000)]
[CFLAA] Remove tautological comparison
Fixes this (the warning is right, the unsigned value is not negative):
lib/Analysis/StratifiedSets.h:689:53: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
bool inbounds(StratifiedIndex N) const { return N >= 0 && N < Links.size(); }
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216987
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Tue, 2 Sep 2014 22:33:57 +0000 (22:33 +0000)]
[FastISel][AArch64] Use the target-dependent selection code for shifts first.
This uses the target-dependent selection code for shifts first, which allows us
to create better code for shifts with immediates and sign-/zero-extend folding.
Vector type are not handled yet and the code falls back to target-independent
instruction selection for these cases.
This fixes rdar://problem/
17907920.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216985
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Tue, 2 Sep 2014 22:33:53 +0000 (22:33 +0000)]
[FastISel][AArch64] Use a new helper function to determine if a value type is supported. NFCI.
FastISel for AArch64 supports more value types than are actually legal. Use a
dedicated helper function to reflect this.
It is very similar to the isLoadStoreTypeLegal function, with the exception
that vector types are not supported yet.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216984
91177308-0d34-0410-b5e6-
96231b3b80d8
Sean Silva [Tue, 2 Sep 2014 22:32:20 +0000 (22:32 +0000)]
Nuke MCAnalysis.
The code is buggy and barely tested. It is also mostly boilerplate.
(This includes MCObjectDisassembler, which is the interface to that
functionality)
Following an IRC discussion with Jim Grosbach, it seems sensible to just
nuke the whole lot of functionality, and dig it up from VCS if
necessary (I hope not!).
All of this stuff appears to have been added in a huge patch dump (look
at the timeframe surrounding e.g. r182628) where almost every patch
seemed to be untested and not reviewed before being committed.
Post-review responses to the patches were never addressed. I don't think
any of it would have passed pre-commit review.
I doubt anyone is depending on this, since this code appears to be
extremely buggy. In limited testing that Michael Spencer and I did, we
couldn't find a single real-world object file that wouldn't crash the
CFG reconstruction stuff. The symbolizer stuff has O(n^2) behavior and
so is not much use to anyone anyway. It seemed simpler to remove them as
a whole. Most of this code is boilerplate, which is the only way it was
able to scrape by 60% coverage.
HEADSUP: Modules folks, some files I nuked were referenced from
include/llvm/module.modulemap; I just deleted the references. Hopefully
that is the right fix (one was a FIXME though!).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216983
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Tue, 2 Sep 2014 22:28:02 +0000 (22:28 +0000)]
Reinstate "Nuke the old JIT."
Approved by Jim Grosbach, Lang Hames, Rafael Espindola.
This reinstates commits r215111, 215115, 215116, 215117, 215136.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216982
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Tue, 2 Sep 2014 22:26:06 +0000 (22:26 +0000)]
[CFLAA] LLVM_CONSTEXPR -> const
The number is just a constant, and this should make MSVC happy (or at least
happier).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216981
91177308-0d34-0410-b5e6-
96231b3b80d8
Robin Morisset [Tue, 2 Sep 2014 22:16:29 +0000 (22:16 +0000)]
[X86] Allow atomic operations using immediates to avoid using a register
The only valid lowering of atomic stores in the X86 backend was mov from
register to memory. As a result, storing an immediate required a useless copy
of the immediate in a register. Now these can be compiled as a simple mov.
Similarily, adding/and-ing/or-ing/xor-ing an
immediate to an atomic location (but through an atomic_store/atomic_load,
not a fetch_whatever intrinsic) can now make use of an 'add $imm, x(%rip)'
instead of using a register. And the same applies to inc/dec.
This second point matches the first issue identified in
http://llvm.org/bugs/show_bug.cgi?id=17281
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216980
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Tue, 2 Sep 2014 22:13:00 +0000 (22:13 +0000)]
[CFLAA] constexpr -> LLVM_CONSTEXPR
Attempt to fix the MSVC build by not using constexpr.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216979
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Tue, 2 Sep 2014 22:12:54 +0000 (22:12 +0000)]
Add pass-manager flags to use CFL AA
Add -use-cfl-aa (and -use-cfl-aa-in-codegen) to add CFL AA in the default pass
managers (for easy testing).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216978
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Tue, 2 Sep 2014 21:51:35 +0000 (21:51 +0000)]
BumpPtrAllocator: use uintptr_t when aligning addresses to avoid undefined behaviour
In theory, alignPtr() could push a pointer beyond the end of the current slab, making
comparisons with that pointer undefined behaviour. Use an integer type to avoid this.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216973
91177308-0d34-0410-b5e6-
96231b3b80d8
Kostya Serebryany [Tue, 2 Sep 2014 21:46:51 +0000 (21:46 +0000)]
[asan] Assign a low branch weight to ASan's slow path, patch by Jonas Wagner. This speeds up asan (at least on SPEC) by 1%-5% or more. Also fix lint in dfsan.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216972
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Tue, 2 Sep 2014 21:45:50 +0000 (21:45 +0000)]
R600/SI: Relax some ordering in tests.
This will help with enabling misched
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216971
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Tue, 2 Sep 2014 21:43:13 +0000 (21:43 +0000)]
Add a CFL Alias Analysis implementation
This provides an implementation of CFL alias analysis (including some
supporting data structures). Currently, we don't have any extremely fancy
features, sans some interprocedural analysis (i.e. no field sensitivity, etc.),
and we do best sitting behind BasicAA + TBAA. In such a configuration, we take
~0.6-0.8% of total compile time, and give ~7-8% NoAlias responses to queries
TBAA and BasicAA couldn't answer when bootstrapping LLVM. In testing this on
other projects, we've seen up to 10.5% of queries dropped by BasicAA+TBAA
answered with NoAlias by this algorithm.
Patch by George Burgess IV (with minor modifications by me -- mostly adapting
some BasicAA tests), thanks!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216970
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Tue, 2 Sep 2014 21:32:54 +0000 (21:32 +0000)]
[FastISel][AArch64] Move over to target-dependent instruction selection only.
This change moves FastISel for AArch64 to target-dependent instruction selection
only. This change replicates the existing target-independent behavior, therefore
there are no changes to the unit tests or new tests.
Future changes will take advantage of this change and update functionality
and unit tests.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216955
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Tue, 2 Sep 2014 21:07:44 +0000 (21:07 +0000)]
[FastISel] Provide the option to skip target-independent instruction selection. NFC.
This allows the target to disable target-independent instruction selection and
jump directly into the target-dependent instruction selection code.
This can be beneficial for targets, such as AArch64, which could emit much
better code, but never got a chance to do so, because the target-independent
instruction selector was able to find an instruction sequence.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216947
91177308-0d34-0410-b5e6-
96231b3b80d8
Yi Jiang [Tue, 2 Sep 2014 21:00:39 +0000 (21:00 +0000)]
Generate extract for in-tree uses if the use is scalar operand in vectorized instruction. radar://
18144665
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216946
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Tue, 2 Sep 2014 20:43:07 +0000 (20:43 +0000)]
R600/SI: Fix hardcoded register numbers in test
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216944
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Tue, 2 Sep 2014 20:24:47 +0000 (20:24 +0000)]
Refactor LowerFABS and LowerFNEG into one function (x86) (NFC)
We duplicate ~30 lines of code to lower FABS and FNEG for x86, so this patch combines them into one function.
No functional change intended, so no additional test cases. Test-suite behavior is unchanged.
Differential Revision: http://reviews.llvm.org/D5064
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216942
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Tue, 2 Sep 2014 20:20:43 +0000 (20:20 +0000)]
cmake: Don't reject unknown cpp files that start with .
Some editors create hidden file backups in the same
directory as the file, and it's annoying when cmake
errors on them.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216941
91177308-0d34-0410-b5e6-
96231b3b80d8
Robin Morisset [Tue, 2 Sep 2014 20:17:52 +0000 (20:17 +0000)]
Fix MemoryDependenceAnalysis in cases where QueryInstr is a CmpXchg or a AtomicRMW
Summary:
MemoryDependenceAnalysis is currently cautious when the QueryInstr is an atomic
load or store, but I forgot to check for atomic cmpxchg/atomicrmw. This patch
is a way of fixing that, and making it less brittle (i.e. no risk that I forget
another possible kind of atomic, even if the IR ends up changing in the future),
by adding a fallback checking mayReadOrWriteFromMemory.
Thanks to Philip Reames for finding this bug and suggesting this solution in
http://reviews.llvm.org/D4845
Sadly, I don't see how to add a test for this, since the passes depending on
MemoryDependenceAnalysis won't trigger for an atomic rmw anyway. Does anyone
see a way for testing it?
Test Plan: none possible at first sight
Reviewers: jfb, reames
Subscribers: llvm-commits
Differential Revision: http://reviews.llvm.org/D5019
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216940
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Tue, 2 Sep 2014 20:03:00 +0000 (20:03 +0000)]
Fix a logic bug when copying fast-math flags.
"Setting" does not equal "copying". This bug has sat dormant for 2 reasons:
1. The unit test was not adequate.
2. Every current user of the "copyFastMathFlags" API is operating on a new instruction.
(ie, all existing fast-math flags are off). If you copy flags to an existing
instruction that has some flags on already, you will not necessarily turn them off
as expected.
I uncovered this bug while trying to implement a fix for PR20802.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216939
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Tue, 2 Sep 2014 19:49:39 +0000 (19:49 +0000)]
Add a note about AuroraUX to the release notes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216938
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Tue, 2 Sep 2014 19:18:52 +0000 (19:18 +0000)]
Add note to documentation about machine node chains.
I've been assuming chain operands were always the first operand,
since the documentation says this. I was confused about why they
were missing after instruction selection. Apparently the convention
changes to using the last operand for MachineSDNodes and I've never
noticed before.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216934
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Tue, 2 Sep 2014 19:12:31 +0000 (19:12 +0000)]
R600/SI: Add failing testcase.
This is broken when 64-bit add is only partially
moved to the VALU.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216933
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Tue, 2 Sep 2014 19:02:53 +0000 (19:02 +0000)]
Fix interference caused by fmul 2, x -> fadd x, x
If an fmul was introduced by lowering, it wouldn't be folded
into a multiply by a constant since the earlier combine would
have replaced the fmul with the fadd.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216932
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Kledzik [Tue, 2 Sep 2014 18:50:24 +0000 (18:50 +0000)]
Code review tweaks
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216931
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Tue, 2 Sep 2014 18:47:54 +0000 (18:47 +0000)]
Fix crash when looking up the addrspace of GEPs with vector types
Patch by Björn Steinbrink
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216930
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Tue, 2 Sep 2014 18:42:44 +0000 (18:42 +0000)]
CodeGen: Handle va_start in the entry block
Also fix a small copy-paste bug in X86ISelLowering where Chain should
have been used in place of DAG.getEntryToken().
Fixes PR20828.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216929
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Tue, 2 Sep 2014 18:33:51 +0000 (18:33 +0000)]
Fix comment and unnecessary check for FP build_vectors.
This was copy-paste from the integer version, but
FP build_vectors don't truncate.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216928
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 2 Sep 2014 18:21:06 +0000 (18:21 +0000)]
unique_ptrify LTOCodeGenerator::NativeObjectFile
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216927
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 2 Sep 2014 18:13:54 +0000 (18:13 +0000)]
unique_ptrify the result of SpecialCaseList::create
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216925
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Tue, 2 Sep 2014 18:00:00 +0000 (18:00 +0000)]
MCSchedule.h: fix VS2012 build after r216919
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216924
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 2 Sep 2014 17:49:23 +0000 (17:49 +0000)]
unique_ptrify FileOutputBuffer::FileOutputBuffer
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216921
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Tue, 2 Sep 2014 17:49:16 +0000 (17:49 +0000)]
Fix left shifts of negative values in MipsDisassembler.
This bug was reported by UBSan.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216920
91177308-0d34-0410-b5e6-
96231b3b80d8
Pete Cooper [Tue, 2 Sep 2014 17:43:54 +0000 (17:43 +0000)]
Change MCSchedModel to be a struct of statically initialized data.
This removes static initializers from the backends which generate this data, and also makes this struct match the other Tablegen generated structs in behaviour
Reviewed by Andy Trick and Chandler C
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216919
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 2 Sep 2014 17:42:01 +0000 (17:42 +0000)]
unique_ptrify PBQPBuilder::build
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216918
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Tue, 2 Sep 2014 17:38:34 +0000 (17:38 +0000)]
Fix signed integer overflow in PPCInstPrinter.
This bug was reported by UBSan.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216917
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Tue, 2 Sep 2014 17:29:51 +0000 (17:29 +0000)]
Correct unique_ptr passing in MCObjectDisassembler::setFallbackRegion
Rather than passing by lvalue reference, pass by value to ensure that
the caller provides an rvalue (and use move assignment, rather than
release+reset, to assign to the member variable)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216916
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Tue, 2 Sep 2014 17:25:29 +0000 (17:25 +0000)]
Fix left shifts by too large exponents in MCParser
(which happened only on error recovery path).
This bug was reported by UBSan.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216915
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrea Di Biagio [Tue, 2 Sep 2014 17:22:49 +0000 (17:22 +0000)]
Revert: [APFloat] Fixed a bug in method 'fusedMultiplyAdd'.
This reverts revision 216913; the new test added at revision 216913
caused regression failures on a couple of buildbots.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216914
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrea Di Biagio [Tue, 2 Sep 2014 16:44:56 +0000 (16:44 +0000)]
[APFloat] Fixed a bug in method 'fusedMultiplyAdd'.
When folding a fused multiply-add builtin call, make sure that we propagate the
correct result in the case where the addend is zero, and the two other operands
are finite non-zero.
Example:
define double @test() {
%1 = call double @llvm.fma.f64(double 7.0, double 8.0, double 0.0)
ret double %1
}
Before this patch, the instruction simplifier wrongly folded the builtin call
in function @test to constant 'double 7.0'.
With this patch, method 'fusedMultiplyAdd' correctly evaluates the multiply and
propagates the expected result (i.e. 56.0).
Added test fold-builtin-fma.ll with the reproducible from PR20832 plus extra
test cases to verify the behavior of method 'fusedMultiplyAdd' in the presence
of NaN/Inf operands.
This fixes PR20832.
Differential Revision: http://reviews.llvm.org/D5152
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216913
91177308-0d34-0410-b5e6-
96231b3b80d8
JF Bastien [Tue, 2 Sep 2014 16:26:55 +0000 (16:26 +0000)]
Add missing override on ARMAsmBackend's dtor.
Test Plan: ninja check && ninja clang-test
Subscribers: aemerson
Differential Revision: http://reviews.llvm.org/D5075
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216912
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Tue, 2 Sep 2014 16:22:00 +0000 (16:22 +0000)]
LICM: Don't crash when an instruction is used by an unreachable BB
Summary:
BBs might contain non-LCSSA'd values after the LCSSA pass is run if they
are unreachable from the entry block.
Normally, the users of the instruction would be PHIs but the unreachable
BBs have normal users; rewrite their uses to be undef values.
An alternative fix could involve fixing this at LCSSA but that would
require this invariant to hold after subsequent transforms. If a BB
created an unreachable block, they would be in violation of this.
This fixes PR19798.
Differential Revision: http://reviews.llvm.org/D5146
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216911
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Tue, 2 Sep 2014 16:19:41 +0000 (16:19 +0000)]
Fix left shifts of negative integers in AArch64 InstPrinter/Disassembler
Summary:
Left shift of negative integer is an undefined behavior, and
is reported by UBSan. It's ok for imm values to be negative, so we can
just replace left shifts with multiplications.
Test Plan: check-llvm test suite
Reviewers: t.p.northover
Reviewed By: t.p.northover
Subscribers: aemerson, mcrosier, llvm-commits
Differential Revision: http://reviews.llvm.org/D5132
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216910
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Tue, 2 Sep 2014 16:05:23 +0000 (16:05 +0000)]
Enable splitting indexing from loads with TargetConstants
When I recommitted r208640 (in r216898) I added an exclusion for TargetConstant
offsets, as there is no guarantee that a backend can handle them on generic
ADDs (even if it generates them during address-mode matching) -- and,
specifically, applying this transformation directly with TargetConstants caused
a self-hosting failure on PPC64. Ignoring all TargetConstants, however, is less
than ideal. Instead, for non-opaque constants, we can convert them into regular
constants for use with the generated ADD (or SUB).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216908
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Tue, 2 Sep 2014 13:54:53 +0000 (13:54 +0000)]
Replace -use-init-array with -use-ctors.
We have been using .init-array for most systems for quiet some time,
but tools like llc are still defaulting to .ctors because the old
option was never changed.
This patch makes llc default to .init-array and changes the option to
be -use-ctors.
Clang is not affected by this. It has its own fancier logic.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216905
91177308-0d34-0410-b5e6-
96231b3b80d8
Aaron Ballman [Tue, 2 Sep 2014 12:19:02 +0000 (12:19 +0000)]
Silencing an MSVC C4334 warning ('<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)). NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216902
91177308-0d34-0410-b5e6-
96231b3b80d8
David Xu [Tue, 2 Sep 2014 09:33:56 +0000 (09:33 +0000)]
Merge Extend and Shift into a UBFX
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216899
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Tue, 2 Sep 2014 06:24:04 +0000 (06:24 +0000)]
Revert "Revert '[DAGCombiner] Split up an indexed load if only the base pointer value is live'"
I reverted r208640 in r209747 because r208640 broke self-hosting on PPC64. The
underlying cause of the failure is that pre-inc loads with increments
represented by ISD::TargetConstants were being transformed into ISD:::ADDs with
ISD::TargetConstant operands. PPC doesn't have a pattern for those, and so they
were selected as invalid r+r adds.
This recommits r208640, rebased and with an exclusion for ISD::TargetConstant
increments. This behavior seems correct, although in the future we might want
to ask the target to split out the indexing that uses ISD::TargetConstants.
Unfortunately, I don't yet have small test case where the relevant invalid
'add' instruction is not itself dead (and thus eliminated by
DeadMachineInstructionElim -- sometimes bugpoint is too good at removing things)
Original commit message (by Adam Nemet):
Right now the load may not get DCE'd because of the side-effect of updating
the base pointer.
This can happen if we lower a read-modify-write of an illegal larger type
(e.g. i48) such that the modification only affects one of the subparts (the
lower i32 part but not the higher i16 part). See the testcase.
In order to spot the dead load we need to revisit it when SimplifyDemandedBits
decided that the value of the load is masked off. This is the
CommitTargetLoweringOpt piece.
I checked compile time with ARM64 by sending SPEC bitcode files through llc.
No measurable change.
Fixes <rdar://problem/
16031651>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216898
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Tue, 2 Sep 2014 06:23:54 +0000 (06:23 +0000)]
[PowerPC] Guard against illegal selection of add for TargetConstant operands
r208640 was reverted because it caused a self-hosting failure on ppc64. The
underlying cause was the formation of ISD::ADD nodes with ISD::TargetConstant
operands. Because we have no patterns for 'add' taking 'timm' nodes, these are
selected as r+r add instructions (which is a miscompile). Guard against this
kind of behavior in the future by making the backend crash should this occur
(instead of silently generating invalid output).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216897
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Mon, 1 Sep 2014 23:48:39 +0000 (23:48 +0000)]
CodeGen: indicate Windows unwind data format
The structures for Windows unwinding are shared across multiple platforms.
Indicate the encoding to be used for the particular target. Use this to switch
the unwind emitter instantiated by the AsmPrinter.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216895
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Mon, 1 Sep 2014 23:48:34 +0000 (23:48 +0000)]
CodeGen: split out the Win64Exception emitter
Move the Windows unwind information emitter into a separate header. This is not
related to DWARF based emission. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216894
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Mon, 1 Sep 2014 23:48:29 +0000 (23:48 +0000)]
MC: remove unnecessary enumeration prefix
This is an enum class, and will be appropriately prefixed, making the encoding
type prefix redundant. No change to any uses as the use of this was not yet
introduced.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216893
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Mon, 1 Sep 2014 21:20:14 +0000 (21:20 +0000)]
SROA: Don't insert instructions before a PHI
SROA may decide that it needs to insert a bitcast and would set it's
insertion point before a PHI. This will create an invalid module
right quick.
Instead, choose the first insertion point in the basic block that holds
our PHI.
This fixes PR20822.
Differential Revision: http://reviews.llvm.org/D5141
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216891
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Mon, 1 Sep 2014 21:10:02 +0000 (21:10 +0000)]
Revert "Revert two GEP-related InstCombine commits"
This reverts commit r216698 which reverted r216523 and r216598.
We would attempt to perform the transformation even if the match()
failed because, as a side effect, it would set V. This would trick us
into believing that we correctly found a place to correctly apply the
transform.
An additional test case was added to getelementptr.ll so that we might
not regress in the future.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216890
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Mon, 1 Sep 2014 19:01:47 +0000 (19:01 +0000)]
Use an integer constant for FABS / FNEG (x86).
This change will ease refactoring LowerFABS() and LowerFNEG()
since they have a lot of overlap.
Remove the creation of a floating point constant from an integer
because it's going to be used for a bitwise integer op anyway.
No change to codegen expected, but the verbose comment string
for asm output may change from float values to hex (integer),
depending on whether the constant already exists or not.
Differential Revision: http://reviews.llvm.org/D5052
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216889
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Mon, 1 Sep 2014 18:44:57 +0000 (18:44 +0000)]
Add a convenience method to copy wrapping, exact, and fast-math flags (NFC).
The loop vectorizer preserves wrapping, exact, and fast-math properties of scalar instructions.
This patch adds a convenience method to make that operation easier because we need to do this
in the loop vectorizer, SLP vectorizer, and possibly other places.
Although this is a 'no functional change' patch, I've added a testcase to verify that the exact
flag is preserved by the loop vectorizer. The wrapping and fast-math flags are already checked
in existing testcases.
Differential Revision: http://reviews.llvm.org/D5138
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216886
91177308-0d34-0410-b5e6-
96231b3b80d8
Jingyue Wu [Mon, 1 Sep 2014 14:55:04 +0000 (14:55 +0000)]
Fix a typo in comments in r216862, NFC
PR20766 -> PR20776. Thanks Roman Divacky for the catch!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216883
91177308-0d34-0410-b5e6-
96231b3b80d8
Tilmann Scheller [Mon, 1 Sep 2014 12:59:34 +0000 (12:59 +0000)]
[ARM] Add Thumb-2 code size optimization regression test for EOR.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216881
91177308-0d34-0410-b5e6-
96231b3b80d8
Tilmann Scheller [Mon, 1 Sep 2014 12:53:29 +0000 (12:53 +0000)]
ARM] Add Thumb-2 code size optimization regression test for BIC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216880
91177308-0d34-0410-b5e6-
96231b3b80d8
Yuri Gorshenin [Mon, 1 Sep 2014 12:51:00 +0000 (12:51 +0000)]
[asan-assembly-instrumentation] Prologue and epilogue are moved out from InstrumentMemOperand().
Reviewers: eugenis
Subscribers: llvm-commits
Differential revision: http://reviews.llvm.org/D4923
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216879
91177308-0d34-0410-b5e6-
96231b3b80d8
Renato Golin [Mon, 1 Sep 2014 11:25:07 +0000 (11:25 +0000)]
Thumb2 M-class MSR instruction support changes
This patch implements a few changes related to the Thumb2 M-class MSR instruction:
* better handling of unpredictable encodings,
* recognition of the _g and _nzcvqg variants by the asm parser only if the DSP
extension is available, preferred output of MSR APSR moves with the _<bits>
suffix for v7-M.
Patch by Petr Pavlu.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216874
91177308-0d34-0410-b5e6-
96231b3b80d8
Patrik Hagglund [Mon, 1 Sep 2014 11:04:07 +0000 (11:04 +0000)]
Fix in InlineSpiller to make the rematerilization loop also consider
implicit uses of the whole register when a sub register is defined.
Now the same iterator is used in the rematerilization loop as in the
spill loop later.
Patch provided by Mikael Holmen.
This fix was proposed and reviewed by Quentin Colombet,
http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-August/076135.html.
Unfortunately, this error in the rematerilization code has only been
seen in a large test case for an out-of-tree target, and is probably
hard to reproduce on an in-tree target. Therefore, no testcase is
provided.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216873
91177308-0d34-0410-b5e6-
96231b3b80d8
Yuri Gorshenin [Mon, 1 Sep 2014 10:24:04 +0000 (10:24 +0000)]
Revert "[asan-assembly-instrumentation] Prologue and epilogue are moved out from InstrumentMemOperand()."
This reverts commit
895aa397038b8de86d83ac0997a70949a486e112.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216872
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Mon, 1 Sep 2014 10:09:18 +0000 (10:09 +0000)]
Fix a really bad miscompile introduced in r216865 - the else-if logic
chain became completely broken here as *all* intrinsic users ended up
being skipped, and the ones that seemed to be singled out were actually
the exact wrong set.
This is a great example of why long else-if chains can be easily
confusing. Switch the entire code to use early exits and early continues
to have simpler (and more importantly, correct) logic here, as well as
fixing the reversed logic for detecting and continuing on lifetime
intrinsics.
I've also significantly cleaned up the test case and added another test
case demonstrating an example where the optimization is not (trivially)
safe to perform.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216871
91177308-0d34-0410-b5e6-
96231b3b80d8
Renato Golin [Mon, 1 Sep 2014 10:00:17 +0000 (10:00 +0000)]
Small refactor on VectorizerHint for deduplication
Previously, the hint mechanism relied on clean up passes to remove redundant
metadata, which still showed up if running opt at low levels of optimization.
That also has shown that multiple nodes of the same type, but with different
values could still coexist, even if temporary, and cause confusion if the
next pass got the wrong value.
This patch makes sure that, if metadata already exists in a loop, the hint
mechanism will never append a new node, but always replace the existing one.
It also enhances the algorithm to cope with more metadata types in the future
by just adding a new type, not a lot of code.
Re-applying again due to MSVC 2013 being minimum requirement, and this patch
having C++11 that MSVC 2012 didn't support.
Fixes PR20655.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216870
91177308-0d34-0410-b5e6-
96231b3b80d8
Yuri Gorshenin [Mon, 1 Sep 2014 09:56:45 +0000 (09:56 +0000)]
[asan-assembly-instrumentation] Prologue and epilogue are moved out from InstrumentMemOperand().
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216869
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Mon, 1 Sep 2014 09:01:39 +0000 (09:01 +0000)]
Feed AA to the inliner and use AA->getModRefBehavior in AddAliasScopeMetadata
This feeds AA through the IFI structure into the inliner so that
AddAliasScopeMetadata can use AA->getModRefBehavior to figure out which
functions only access their arguments (instead of just hard-coding some
knowledge of memory intrinsics). Most of the information is only available from
BasicAA; this is important for preserving alias scoping information for
target-specific intrinsics when doing the noalias parameter attribute to
metadata conversion.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216866
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Mon, 1 Sep 2014 06:03:11 +0000 (06:03 +0000)]
Ignore lifetime intrinsics in use list for MemCpyOptimizer. Patch by Luqman Aden, review by Hal Finkel.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216865
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Mon, 1 Sep 2014 05:17:15 +0000 (05:17 +0000)]
Remove an errant outer loop that contains nothing but an inner loop over exactly the same elements. While no functionality is change intended (and hence there are no changes to tests), you don't want to skip this revision if bisecting for errors.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216864
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Mon, 1 Sep 2014 04:26:40 +0000 (04:26 +0000)]
Fix AddAliasScopeMetadata again - alias.scope must be a complete description
I thought that I had fixed this problem in r216818, but I did not do a very
good job. The underlying issue is that when we add alias.scope metadata we are
asserting that this metadata completely describes the aliasing relationships
within the current aliasing scope domain, and so in the context of translating
noalias argument attributes, the pointers must all be based on noalias
arguments (as underlying objects) and have no other kind of underlying object.
In r216818 excluding appropriate accesses from getting alias.scope metadata is
done by looking for underlying objects that are not identified function-local
objects -- but that's wrong because allocas, etc. are also function-local
objects and we need to explicitly check that all underlying objects are the
noalias arguments for which we're adding metadata aliasing scopes.
This fixes the underlying-object check for adding alias.scope metadata, and
does some refactoring of the related capture-checking eligibility logic (and
adds more comments; hopefully making everything a bit clearer).
Fixes self-hosting on x86_64 with -mllvm -enable-noalias-to-md-conversion (the
feature is still disabled by default).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216863
91177308-0d34-0410-b5e6-
96231b3b80d8
Jingyue Wu [Mon, 1 Sep 2014 03:47:25 +0000 (03:47 +0000)]
[MachineSink] Use the real post dominator tree
Summary:
Fixes a FIXME in MachineSinking. Instead of using the simple heuristics
in isPostDominatedBy, use the real MachinePostDominatorTree. The old
heuristics caused instructions to sink unnecessarily, and might create
register pressure.
Test Plan:
Added a NVPTX codegen test to verify that our change is in effect. It also
shows the unnecessary register pressure caused by over-sinking. Updated
affected tests in AArch64 and X86.
Reviewers: eliben, meheff, Jiangning
Reviewed By: Jiangning
Subscribers: jholewinski, aemerson, mcrosier, llvm-commits
Differential Revision: http://reviews.llvm.org/D4814
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216862
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Sun, 31 Aug 2014 21:26:22 +0000 (21:26 +0000)]
DebugInfo: Elide lexical scopes which only contain other (inline or lexical) scopes.
DW_TAG_lexical_scopes inform debuggers about the instruction range for
which a given variable (or imported declaration/module/etc) is valid. If
the scope doesn't itself contain any such entities, it's a waste of
space and should be omitted.
We were correctly doing this for entirely empty leaves, but not for
intermediate nodes.
Reduces total (not just debug sections) .o file size for a bootstrap
-gmlt LLVM by 22% and bootstrap -gmlt clang executable by 13%. The wins
for a full -g build will be less as a % (and in absolute terms), but
should still be substantial - with some of that win being fewer
relocations, thus more substantiall reducing link times than fewer bytes
alone would have.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216861
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Sun, 31 Aug 2014 19:19:57 +0000 (19:19 +0000)]
Consider addrspaces in canLosslesslyBitCastTo()
Make this conservatively correct and report false for different
address spaces, which might require a nontrivial translation.
Based on the few uses of this, I don't think this currently
breaks anything.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216846
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Sun, 31 Aug 2014 18:04:28 +0000 (18:04 +0000)]
DebugInfo: Move argument creation up into the caller that's unambiguously handling the subprogram scope (replacing a conditional with an assertion in the process)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216845
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Sun, 31 Aug 2014 05:46:17 +0000 (05:46 +0000)]
Delay adding imported entity DIEs to the lexical scope, streamlining the check for "this scope has nothing in it"
This makes the emptiness of the scope with regards to variables and
nested scopes is the same as with regards to imported entities. Just
check if we had nothing at all before we build the node.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216840
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Sun, 31 Aug 2014 05:41:15 +0000 (05:41 +0000)]
Modify DwarfDebug::constructImportedEntityDIE to return rather than insert into the scope
Another step towards improving lexical_scope handling
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216839
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Sun, 31 Aug 2014 05:32:06 +0000 (05:32 +0000)]
Refactor constructImportedEntityDIE(DwarfUnit, DIImportedEntity) to return a DIE rather than inserting it into a specified context.
First of many steps to improve lexical scope construction (to omit
trivial lexical scopes - those without any direct variables). To that
end it's easier not to create imported entities directly into the
lexical scope node, but to build them, then add them if necessary.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216838
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Sun, 31 Aug 2014 02:14:26 +0000 (02:14 +0000)]
Simplify expression using container's front() rather than begin()->
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216833
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Sun, 31 Aug 2014 01:33:41 +0000 (01:33 +0000)]
Add some negative (and positive) static_assert checks for ArrayRef-of-pointer conversions introduced in r216709
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216830
91177308-0d34-0410-b5e6-
96231b3b80d8