OSDN Git Service
Jakub Pawlowski [Thu, 19 Oct 2017 22:51:35 +0000 (15:51 -0700)]
Clarify naming for characteristic value handle
We always reffer to characteristic by it's value handle.
Bug:
67057055
Test: compilation
Change-Id: I41a5d910ed471800c996b44dccfdbab3d7c3bdda
Treehugger Robot [Thu, 19 Oct 2017 23:38:51 +0000 (23:38 +0000)]
Merge "Test: Rename performance_test to net_test_performance"
Jack He [Thu, 19 Oct 2017 21:25:26 +0000 (14:25 -0700)]
Test: Rename performance_test to net_test_performance
Bug:
67059793
Test: make
Change-Id: I6303d4c367e465c8404538d904eabca80b509a16
Jakub Pawlowski [Thu, 19 Oct 2017 07:26:09 +0000 (00:26 -0700)]
hw/bluetooth.default.so -> libbluetooth.so (1/2)
Also rename the build goal for both the library and headers.
Bug:
67853426
Test: run Bluetooth
Merged-In: Iaffeebc1d3f2761e13f6d66d4e855dc342603054
Change-Id: Iaffeebc1d3f2761e13f6d66d4e855dc342603054
(cherry picked from commit
842ff8ed7f5b00d5f6da9d975f37e65c41bb8ebc)
Jack He [Thu, 19 Oct 2017 07:36:18 +0000 (07:36 +0000)]
Revert "Add -fno-exceptions to default build config"
This reverts commit
d4b1d66dbe28818df3408a920ef37a3e0afca0aa.
Change Ie53b82e5d670f44a2460880c32dd9102d1caad7d
is a better fix. This flag won't disable exceptions in pre-compiled STL library.
Bug:
67963594
Test: build
Change-Id: I8c8cf0ebeb79bae697f0074de2d2e39f8e8f8703
Treehugger Robot [Thu, 19 Oct 2017 08:31:28 +0000 (08:31 +0000)]
Merge "Fix failing ConfigTest"
Jakub Pawlowski [Thu, 19 Oct 2017 06:55:39 +0000 (23:55 -0700)]
Fix failing ConfigTest
When running in cloud, different version of STL library is used. It
throws exceptions and make tests fail.
Bug:
67963594
Test: ConfigTest
Change-Id: Ie53b82e5d670f44a2460880c32dd9102d1caad7d
Jakub Pawlowski [Thu, 19 Oct 2017 03:49:54 +0000 (20:49 -0700)]
Run clang-format on headers
Bug:
67853426
Test: compilation
Change-Id: I37dcac01e78fafb4ef0c7e97578d04605c46e88e
Jakub Pawlowski [Sat, 23 Sep 2017 21:47:20 +0000 (14:47 -0700)]
Move Bluetooth headers to system/bt (1/3)
Bug:
67853426
Test: run Bluetooth
Change-Id: I75748d29a35d10d377d39e0441116dbfd04c82e9
Treehugger Robot [Wed, 18 Oct 2017 23:58:28 +0000 (23:58 +0000)]
Merge "Remove tabs from build/Android.bp"
Treehugger Robot [Wed, 18 Oct 2017 23:39:41 +0000 (23:39 +0000)]
Merge "HID: Fix the behavior of virtual_cable_unplug"
Treehugger Robot [Wed, 18 Oct 2017 22:45:37 +0000 (22:45 +0000)]
Merge "Do not set random address when public address is in use"
Jack He [Wed, 18 Oct 2017 22:18:24 +0000 (15:18 -0700)]
Remove tabs from build/Android.bp
Test: make
Change-Id: I02dc1cf5a5e6c0ed2df60fcc3fb79edbb026cf8c
Treehugger Robot [Wed, 18 Oct 2017 22:15:21 +0000 (22:15 +0000)]
Merge "Add -fno-exceptions to default build config"
Treehugger Robot [Wed, 18 Oct 2017 19:21:13 +0000 (19:21 +0000)]
Merge "Make system/bt build with the VNDK."
Steven Moreland [Mon, 17 Jul 2017 17:17:59 +0000 (10:17 -0700)]
Make system/bt build with the VNDK.
When the vndk is enabled (BOARD_VNDK_VERSION=current),
vendor libraries must only link against vendor variants
in the build system. This also means that they receive
restricted sets of headers and that automatic global
headers are restricted.
Test: build system/bt with BOARD_VNDK_VERSION=current
Bug:
37342627
Change-Id: Ie1507e9b5bdb626fa0049faadd225c2c1f451661
Merged-In: Ie1507e9b5bdb626fa0049faadd225c2c1f451661
(cherry picked from commit
41401a5916f750f29af61bae35ca99f7e851333f)
Myles Watson [Tue, 3 Oct 2017 20:04:28 +0000 (13:04 -0700)]
Allocate tSDBP_DISCOVERY_DB instead of bytes
Test: build
Change-Id: Ib7a33cf7cb89715da781b4e93d0bfe3f74490cea
Jakub Pawlowski [Wed, 18 Oct 2017 11:06:13 +0000 (04:06 -0700)]
Remove hw_module_t dependency in Bluetooth - cleanup
Bug:
67853426
Test: run Bluetooth
Jakub Pawlowski [Wed, 18 Oct 2017 11:03:41 +0000 (04:03 -0700)]
Linux build fix
Test: compile using ninja
Jack He [Wed, 18 Oct 2017 07:26:16 +0000 (00:26 -0700)]
Add -fno-exceptions to default build config
* C++ exceptions are expensive and are not used in our code
* We need to disable exception to achieve desired behavior for
std::stoi, which we don't want it to crash when failing to parse an
incoming integer
Test: make, net_test_osi
Change-Id: Idc363ff1f25f085c75df3c473ee4d2a210af3b17
Jakub Pawlowski [Tue, 17 Oct 2017 23:40:41 +0000 (16:40 -0700)]
Move include->internal_include (1/2)
Change-Id: If351c7d51a380c33ec9bae3b3f240ed53639f3c9
Treehugger Robot [Wed, 18 Oct 2017 00:00:54 +0000 (00:00 +0000)]
Merge "Fix failing ConfigTest"
Jakub Pawlowski [Tue, 17 Oct 2017 22:21:52 +0000 (22:21 +0000)]
Merge changes I4b90b6ee,I37c5a138,I6ff0c0dc
* changes:
Inline bta_gattc_start_disc_* where possible
bta_gattc_explore_srvc minor style fixes
Remove bta_gattc_incl_srvc_disc_cmpl
Jakub Pawlowski [Tue, 17 Oct 2017 21:18:18 +0000 (21:18 +0000)]
Merge "Remove hw_module_t dependency in Bluetooth (1/3)"
Jakub Pawlowski [Tue, 17 Oct 2017 21:03:41 +0000 (14:03 -0700)]
Fix failing ConfigTest
Specifying base as 0 let stoi autodetect it. Default is 10.
Bug:
67595284
Test: ConfigTest
Change-Id: I09a996edb6fde81de7c59e3aaa4a33134fe40891
Jakub Pawlowski [Mon, 16 Oct 2017 22:57:16 +0000 (15:57 -0700)]
Remove hw_module_t dependency in Bluetooth (1/3)
Bug:
67853426
Test: run Bluetooth
Merged-In: Ia3808552137d1f770f2c0305aaa01181f383d064
Change-Id: Ia3808552137d1f770f2c0305aaa01181f383d064
Jakub Pawlowski [Tue, 17 Oct 2017 18:08:22 +0000 (11:08 -0700)]
Inline bta_gattc_start_disc_* where possible
Bug:
67057055
Test: compilation
Change-Id: I4b90b6eede46ffb777180caaab7cb073f898ddba
Jack He [Tue, 17 Oct 2017 19:01:39 +0000 (12:01 -0700)]
Use DIST_DIR from environment for XML log output
Bug:
64687730
Test: DIST_DIR=`pwd` ./test/run_host_unit_tests.py -j40 --enable_xml
Change-Id: Ib81703ec76d65700068563c557c090b1f197e650
Jakub Pawlowski [Tue, 17 Oct 2017 18:05:02 +0000 (11:05 -0700)]
bta_gattc_explore_srvc minor style fixes
Bug:
67057055
Test: compilation
Change-Id: I37c5a138ccddcb1ddd09e3efb5dfcdaeb5bdad04
Jakub Pawlowski [Tue, 17 Oct 2017 18:03:58 +0000 (11:03 -0700)]
Remove bta_gattc_incl_srvc_disc_cmpl
Bug:
67057055
Test: compilation
Change-Id: I6ff0c0dc203232f9fa2b43ccbacb015106d2b6d1
Treehugger Robot [Tue, 17 Oct 2017 18:09:34 +0000 (18:09 +0000)]
Merge "Add script to run host native unit tests"
Martin Brabham [Tue, 17 Oct 2017 17:56:44 +0000 (17:56 +0000)]
Merge "hfp: change initial codec from MSBC_T1 to CVSD"
Jakub Pawlowski [Tue, 17 Oct 2017 06:17:21 +0000 (23:17 -0700)]
Do not set random address when public address is in use
Test: compilation
Change-Id: Ie9832b258aa85a9a4086c1608a32aa6f4049853b
Jack He [Fri, 29 Sep 2017 01:41:28 +0000 (18:41 -0700)]
Add script to run host native unit tests
* Add run_host_unit_tests.py, which does
1. Run "mmma -jN system/bt"
2. Run all host native unit tests configured in HOST_TESTS
3. Output structured XML GTest log output
Bug:
64687730
Test: ./test/run_host_unit_tests.py -j40
Change-Id: I389c67a2e0f60639d1bbfa20375364964b184233
Hansong Zhang [Tue, 17 Oct 2017 00:00:16 +0000 (17:00 -0700)]
HID: Fix the behavior of virtual_cable_unplug
The Bluetooth HID profile itself should not unbond other device; the
Bluetooth HID host and device should only disconnect the HID profile
when sending or receiving virtual_cable_unplug command.
Bug:
67866553
Test: Test with SL4A.
Change-Id: Ie378a7292309d2b11f53fcd82bca1cf42e64b0c0
Jakub Pawlowski [Fri, 13 Oct 2017 16:10:29 +0000 (09:10 -0700)]
config refactor - use strings
Use strings instead of char* arrays. This simplify memory management,
and makes the code easier to follow.
Bug:
67595284
Test: manual
Change-Id: If5dca2a16038360c361f2809601dcac056cb8769
Jakub Pawlowski [Fri, 6 Oct 2017 07:04:27 +0000 (00:04 -0700)]
persistent configuration refactor
Use std::list instead of list_t, use std::string instead of const char*
Bug:
67595284
Test: manual
Change-Id: I65f576977b547b09dc9aebea49d4e399e5712ec6
Martin Brabham [Fri, 13 Oct 2017 22:47:24 +0000 (15:47 -0700)]
hfp: change initial codec from MSBC_T1 to CVSD
4.11.2 Audio Connection Setup by HF For all HF initiated audio connection
establishments for which both sides support the Codec Negotiation feature,
the HF shall trigger the AG to establish a Codec Connection. This is
necessary because only the AG knows about the codec selection and settings
of the network.
In the event we do not support codec negotiation we should make our initial
codec CVSD
Bug:
66324788
Change-Id: Ib68129ea1399c54224109e3ca7ba12784973d68f
Treehugger Robot [Mon, 16 Oct 2017 17:36:50 +0000 (17:36 +0000)]
Merge "Fix net_test_bluetooth"
Myles Watson [Tue, 3 Oct 2017 19:35:59 +0000 (12:35 -0700)]
Remove casts in bta/ and stack/btm
Make pointers to const structs const pointers.
Pass complete unions instead of casting smaller objects.
Test: build
Change-Id: I7d6b61183554be70ac7f58f4133a76ec68e35408
Jack He [Sat, 14 Oct 2017 01:23:05 +0000 (18:23 -0700)]
Fix net_test_bluetooth
* net_test_bluetooth should try to load Bluetooth library from
system/lib/hw or system/lib64/hw if it cannot find it from default
path
* Also replaced legacy logging macro with libbase logging statements
Bug:
67059247
Test: net_test_bluetooth
Change-Id: I6c45f66aedf675397f377ca56203bec9708324e1
Treehugger Robot [Sat, 14 Oct 2017 00:31:31 +0000 (00:31 +0000)]
Merge "bta_gattc_cache: prepare for type unification"
Treehugger Robot [Sat, 14 Oct 2017 00:04:25 +0000 (00:04 +0000)]
Merge "bta: Remove unsafe casts in BTA_AG"
Treehugger Robot [Sat, 14 Oct 2017 00:00:22 +0000 (00:00 +0000)]
Merge "stack: Remove casts and spell local_keys correctly"
Treehugger Robot [Fri, 13 Oct 2017 23:54:34 +0000 (23:54 +0000)]
Merge "btif: Use key types to avoid casting"
Jakub Pawlowski [Fri, 13 Oct 2017 22:49:07 +0000 (15:49 -0700)]
bta_gattc_cache: prepare for type unification
Bug:
67057055
Test: compilation
Change-Id: I46eb07a8f118b61551b3adc404ec306ad6a14b9c
Myles Watson [Tue, 3 Oct 2017 22:55:15 +0000 (15:55 -0700)]
stack: Remove casts and spell local_keys correctly
Test: build
Change-Id: Ide6ec9528e1f8efca9850eab53aa2bdb88ba363d
Myles Watson [Tue, 3 Oct 2017 21:05:47 +0000 (14:05 -0700)]
btif: Use key types to avoid casting
Test: build
Change-Id: If816c480219552dc8833b094a6228817883b774d
Myles Watson [Mon, 2 Oct 2017 20:33:04 +0000 (13:33 -0700)]
bta: Remove unsafe casts in BTA_AG
Test: build
Change-Id: I19659173498972f838ccc59dcac00e0f26417340
Jakub Pawlowski [Thu, 12 Oct 2017 05:54:47 +0000 (22:54 -0700)]
Minor style fixes in bta_gattc_act.cc
Bug:
67057055
Test: compilation test
Change-Id: I862f2da834cf6f5a024ee7321229c337980f3638
Jakub Pawlowski [Fri, 13 Oct 2017 18:04:34 +0000 (11:04 -0700)]
gatt_utils minor style fixes
Test: compilation
Change-Id: I76f3f26b5140b7b60508756b1e841b09aeeb5e7d
Jakub Pawlowski [Fri, 13 Oct 2017 17:23:02 +0000 (10:23 -0700)]
gatt_act_discovery indentation fix
Bug:
67057055
Test: compilation test
Change-Id: I22640f47b5faf6e1d8718dec003b3cc83b51c514
Jakub Pawlowski [Fri, 13 Oct 2017 17:01:24 +0000 (10:01 -0700)]
BTA GATT cache cleanup bta_gattc_discover_pri_service
Bug:
67057055
Test: compilation test
Change-Id: I23464a61282d60400ae36debc820c66a4f1a1e1a
Jakub Pawlowski [Fri, 13 Oct 2017 16:51:06 +0000 (09:51 -0700)]
Fix crash in l2cble_start_conn_update
Bug:
67774334
Test: compilation
Change-Id: I42ec986c6c5f3fe81f507596bf1df05dcf3ec0ba
Jack He [Fri, 6 Oct 2017 00:54:49 +0000 (17:54 -0700)]
HID: Refactor bta_dm_pm_ssr to be more readable
* Reuse values obtained from tables
* Continue early when Bluetooth addresses do not match, so that the
rest of the method can save some indentation
Test: make, HID host test
Change-Id: I7b2d4ec35a167c93da25a112e73c8d37531714a5
Jakub Pawlowski [Thu, 12 Oct 2017 22:00:35 +0000 (15:00 -0700)]
BTA GATT cache cleanup bta_gattc_srvc_in_list
Bug:
67057055
Test: compilation test
Change-Id: I22e752c1d270128ff0ae4f633d4f3eccf4cb725e
Jakub Pawlowski [Thu, 12 Oct 2017 21:42:11 +0000 (14:42 -0700)]
BTA GATT cache cleanup add_*_to_list
Bug:
67057055
Test: compilation test
Change-Id: If70cfc4c024434ffe77e53410b5de8f70af6b33e
Jakub Pawlowski [Thu, 12 Oct 2017 18:18:03 +0000 (11:18 -0700)]
BTA GATT cache cleanup bta_gattc_disc_res_cback
Bug:
67057055
Test: compilation test
Change-Id: Iccfffe5de654070058ce3f4af3f48fa0975b7cf3
Jakub Pawlowski [Thu, 12 Oct 2017 20:29:04 +0000 (13:29 -0700)]
make Uuid::kBase into local constexpr
This fixes a bug where From128BitBE is used before kBase is initialized
Bug:
67671467
Test: Share a picture using Bluetooth
Change-Id: Ifb5b5f90dbca9646f117b9ff5d01439407424597
Jakub Pawlowski [Wed, 11 Oct 2017 21:55:15 +0000 (14:55 -0700)]
BTA GATT cache cleanup
This patch splits bta_gattc_add_attr_to_cache into two functions:
bta_gattc_add_descr_to_cache and bta_gattc_add_incl_srvc_to_cache
Bug:
67057055
Test: compilation test
Change-Id: I92702495e8631197e56c2cb0ab126b59cf7e90e4
Hansong Zhang [Wed, 11 Oct 2017 23:43:53 +0000 (16:43 -0700)]
Fix logs in btif_hh
Fixed two logs which are incosistent with the actual error
Test: not needed.
Change-Id: I8937797148c8c71ef91f9fba5799192bf52692d8
Jakub Pawlowski [Wed, 4 Oct 2017 19:22:10 +0000 (12:22 -0700)]
Use LOG() macros in BTA GATT logging
Test: compilation test
Change-Id: If7676af5bf915df57ab6e876d2f27500ebf5c07d
Treehugger Robot [Tue, 10 Oct 2017 19:48:35 +0000 (19:48 +0000)]
Merge "Linux: silence gnu-variable-sized-type-not-at-end warnings"
Treehugger Robot [Tue, 10 Oct 2017 18:33:10 +0000 (18:33 +0000)]
Merge "HCI: Restart 5 seconds after an HCI timeout"
Jakub Pawlowski [Tue, 10 Oct 2017 17:12:30 +0000 (10:12 -0700)]
Linux: silence gnu-variable-sized-type-not-at-end warnings
Test: compile on linux using ninja
Change-Id: If3fed35017e4aa8cfc2740b49eb4ff547b4e7e5f
Andre Eisenbach [Tue, 10 Oct 2017 10:29:49 +0000 (03:29 -0700)]
Change DI record default company ID to Google
Test: manual
Change-Id: I181e9716dc2c9e48272dcc7f1a00841b4ed5c8dc
Jakub Pawlowski [Tue, 10 Oct 2017 03:53:39 +0000 (20:53 -0700)]
Linux build fix - include what you use
sys/uio.h should be included for writev
Change-Id: I1f66391d15109366356af09c825afa1216fbbf34
Jakub Pawlowski [Mon, 9 Oct 2017 22:13:38 +0000 (15:13 -0700)]
Fix linking error during stack startup
Change-Id: I0ac207eada1ddf2181a4c2826ede74310ce119d1
Myles Watson [Fri, 6 Oct 2017 23:51:21 +0000 (16:51 -0700)]
Manually convert to unary where coccinelle could not
Test: build
Change-Id: I7b5ea758b94bf225e8776f64256d644c3e96b198
Myles Watson [Fri, 6 Oct 2017 23:39:05 +0000 (16:39 -0700)]
Use unary operator instead of == bool
Automatically generated with coccinelle:
@@
expression e1;
@@
-e1 == false
+!e1
@@
expression e1;
@@
-false == e1
+!e1
@@
expression e1;
@@
-e1 == true
+e1
@@
expression e1;
@@
-true == e1
+e1
Test: build
Change-Id: Ic7df0dc43b550594855e457466b6bccd8f3443a3
Treehugger Robot [Fri, 6 Oct 2017 21:40:34 +0000 (21:40 +0000)]
Merge "Remove the build team from OWNERS in system/bt"
Treehugger Robot [Fri, 6 Oct 2017 20:27:29 +0000 (20:27 +0000)]
Merge "Remove -Wno-typedef-redefinition"
Myles Watson [Fri, 6 Oct 2017 18:22:51 +0000 (11:22 -0700)]
HCI: Restart 5 seconds after an HCI timeout
Bug:
67209266
Test: build
Change-Id: I69a4a17382742327268a80dbc5c5be49059ecb3c
Myles Watson [Thu, 5 Oct 2017 23:21:51 +0000 (16:21 -0700)]
Remove the build team from OWNERS in system/bt
Test: build
Change-Id: I17f1fa9c0b5cdf4dc871c54f5731371f6828255c
Myles Watson [Thu, 5 Oct 2017 23:38:11 +0000 (16:38 -0700)]
Remove -Wno-typedef-redefinition
Test: build
Change-Id: I42cc5ad8f77061bdce8906f7e454c8120f4e71b2
Chih-Hung Hsieh [Mon, 2 Oct 2017 22:48:17 +0000 (15:48 -0700)]
Use -Werror in system/bt/vendor_libs/linux/interface/
Bug:
66996870
Test: build with WITH_TIDY=1
Change-Id: I2eca0a5fff52c83a86b060fd274c5a4cd1c53664
Treehugger Robot [Thu, 5 Oct 2017 01:51:14 +0000 (01:51 +0000)]
Merge "Decrese the default verbosity for A2DP codec info logs"
Treehugger Robot [Thu, 5 Oct 2017 01:39:45 +0000 (01:39 +0000)]
Merge "Added extra A2DP logging when there is an error"
Treehugger Robot [Thu, 5 Oct 2017 01:25:42 +0000 (01:25 +0000)]
Merge "Fix net_test_bluetooth"
Pavlin Radoslavov [Wed, 4 Oct 2017 18:26:04 +0000 (11:26 -0700)]
Decrese the default verbosity for A2DP codec info logs
Bug:
64159791
Test: Manual
Change-Id: Ida10f5d2aa6643df136a41891d7775e175c06570
(cherry picked from commit
b4ae75f4524fd5bf55d015f860f1deaee0d81f43)
Pavlin Radoslavov [Wed, 4 Oct 2017 12:36:25 +0000 (05:36 -0700)]
Added extra A2DP logging when there is an error
Bug:
64159791
Test: Manual
Change-Id: Ic1001892b7abc9784a21a183d141df51b1b92fc0
(cherry picked from commit
6c6d2f6a14847ee75c72b1366449c45ab66feb00)
Jakub Pawlowski [Wed, 4 Oct 2017 23:01:26 +0000 (16:01 -0700)]
Fix net_test_bluetooth
Test: net_test_bluetooth
Change-Id: I8c84f0db3ce0e4f6efbd6d7d3cdc794be8fb7faa
Myles Watson [Tue, 3 Oct 2017 23:51:30 +0000 (16:51 -0700)]
btm: Return the result in btm_pm_compare_modes
Test: build
Bug:
67383347
Change-Id: Id4407c1a73592674f0d86b1be1152abc088908b5
Jakub Pawlowski [Sat, 9 Sep 2017 19:50:38 +0000 (12:50 -0700)]
Use std::list in GATT related code
Bug:
67057055
Test: sl4a Gatt* tests
Change-Id: I8201ebdad5ba4c3d5d0a2fd3d0fe9dc900b51d60
Treehugger Robot [Wed, 4 Oct 2017 17:22:17 +0000 (17:22 +0000)]
Merge "Run clang format on files touched by CL 488398"
Jack He [Mon, 2 Oct 2017 21:07:33 +0000 (14:07 -0700)]
A2DP: Advance btif profile queue on OPENING->other_state transition
* Entering BTIF_AV_STATE_OPENING is only possible through
BTIF_AV_CONNECT_REQ_EVT (initiated by us) OR
BTA_AV_PENDING_EVT (initiated by remote)
from BTIF_AV_STATE_IDLE
* If we go from BTIF_AV_CONNECT_REQ_EVT, we must have a pending
connection request in btif_profile_queue that should be advanced when
we quit BTIF_AV_STATE_OPENING state
* This CL adds a flag to indicate whether an AV connection is initiated
by us and only advance queue when it is
* Also add queue advancement in BTA_AV_REJECT_EVT and BTA_AV_CLOSE_EVT
Bug:
67317954
Test: make
Change-Id: I16dc8ebf76c6edaacb1f7a4a44e604170ff9a8b0
c_sdamga [Mon, 20 Jul 2015 13:47:04 +0000 (19:17 +0530)]
Handle Disconnect request in AV Opening State handler
Usecase:
1. Uncheck media from settings UI
2. initiate A2dp connection from remote, send AVRCP play from remote
Failure:
A2dp connection stuck in opening state.
Rootcause:
When A2dp is unchecked from settings UI and remote initiated
a2dp connection and AVRCP play, music starts streaming on DUT
since A2dp connection disconnected. As A2dp connection was not
completed, btif state stuck in opening state.
Fix:
Handled the disconnection request in the opening state
so that AV state machine moves to proper state before
processing AVRCP Play.
Test: 1. Uncheck media from settings UI
2. initiate A2dp connection from remote, send AVRCP play
Bug:
35415160
Change-Id: If1cda5b78100419fdc60c97349efafdd4a18d40c
Myles Watson [Tue, 19 Sep 2017 17:01:28 +0000 (10:01 -0700)]
Run clang format on files touched by CL 488398
https://android-review.googlesource.com/#/c/488398/
Test: build
Change-Id: Iefbd5b632087be00a12b1a0c851f9e3f3b514532
Subramanian Srinivasan [Fri, 29 Sep 2017 01:41:03 +0000 (18:41 -0700)]
Fix adv instance validity check during suspend and resume of resolving list
When BT is shutdown, multi advertisement instance pointer is made
null by BleAdvertisingManager::CleanUp function.
Any subsequent BleAdvertisingManager::Get function call made at
this point(eg during suspension and resumption of resolving list
activity)leads to a crash as the instance pointer is null.
Hence, use BleAdvertisingManager::IsInitialized function instead
of BleAdvertisingManager::Get function to check the validity of
multi advertisement instance.
Bug:
67325491
Change-Id: Ibbae7fa546bb52494be78eaff6d4b7b15614ab15
Stanley Tng [Fri, 29 Sep 2017 16:01:25 +0000 (09:01 -0700)]
Add comments to function arrays to indicate usage
No logic change. More comments are added to function arrays to indicate
how each array entry are used.
Test: Manual
Change-Id: I59283cb9786da6f3a4b8a4b36e36e79a25ca6cb8
Dan Willemsen [Tue, 3 Oct 2017 02:30:06 +0000 (02:30 +0000)]
Merge "Rename target.linux[_x86[_64]] to target.linux_glibc[_x86[_64]]"
Treehugger Robot [Mon, 2 Oct 2017 23:02:56 +0000 (23:02 +0000)]
Merge "HID: Free process_repage_timer to prevent leak"
Hemant Gupta [Wed, 13 Sep 2017 12:05:03 +0000 (17:35 +0530)]
HID: Free process_repage_timer to prevent leak
Usecase:
1) Perform BT on/off stress test
2) Check for memory leakage in code in subsequent BT on/off usecase
Expectation
No memory leak during BT on/off stress test
Observed result
Memory leakage in hid code where alarm process_repage_timer is not freed
and only cancelled
Fix:
Free alarm process_repage_timer during HID Host deregstration
Test: Checked with BT on/off usecase, and alarm process_repage_timer is now
freed in every BT on/off usecase.
Bug:
65657207
Change-Id: Iccecd126716a5660f4c37ddc917bacee84342297
Dan Willemsen [Mon, 2 Oct 2017 17:41:11 +0000 (10:41 -0700)]
Rename target.linux[_x86[_64]] to target.linux_glibc[_x86[_64]]
In the future, target.linux will apply to all targets running a linux kernel
(android, linux_glibc, linux_bionic). So move all current users to the specific
linux_glibc.
There will be another cleanup pass later that will move some instances back to
target.linux if the properties should be shared with target.android and
target.linux_bionic, but target.linux needs to be removed first.
Test: out/soong/build.ninja identical before/after
Change-Id: Iadc1ba324e03fd2b1b52bf471ffa2a71e0ec3e61
Exempt-From-Owner-Approval: build system cleanup
Stanley Tng [Thu, 28 Sep 2017 19:55:41 +0000 (12:55 -0700)]
Add more logs for Bluetooth connection errors
Test: manual
Change-Id: I63402ee8ffa8f57a70a9c9aaa0370d8ca599bbea
Treehugger Robot [Fri, 29 Sep 2017 23:17:41 +0000 (23:17 +0000)]
Merge "Remove unused events handler for BLE scan clients"
Pavlin Radoslavov [Fri, 29 Sep 2017 01:11:06 +0000 (18:11 -0700)]
Remove casts to (tBTA_GATTC*) unions to avoid unaligned accesses
Bug:
65381426
Test: unit tests
Change-Id: I37e89ec7187ab1c61be4c736385a9fc5ec88d737
Pavlin Radoslavov [Fri, 29 Sep 2017 21:44:59 +0000 (21:44 +0000)]
Merge "Revert "Fix stack-buffer-overflow in bluetooth service GATT client""
Treehugger Robot [Fri, 29 Sep 2017 21:07:57 +0000 (21:07 +0000)]
Merge "UUID fix string parsing"
Jakub Pawlowski [Fri, 29 Sep 2017 20:48:38 +0000 (13:48 -0700)]
Remove unused events handler for BLE scan clients
These events should be handled only for GATT clients, not for BLE
scanner.
Bug:
67058417
Test: compilation
Change-Id: I70744d3c6fd7eb40d839863f7413a7521ca0b2e9