QFontDatabase review

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

query fontconfig directly from QFontDatabase

since fontconfig has its own cache mainting internal QFontDatabase cache
is kinda redundant, have to leak check still but font tests pass

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

inline qt_pixelSize() function

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

scale the fontconfig weight value to QFont::Weight in QFontDatabase

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove compat QFontDatabase methods

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

de-duplicate QFontDatabase code

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

add case-sensitivity test for QFontDatabase

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

de-duplicate QFontDatabase code

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

const-ify QFontDatabase::styleString() methods

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

test case for converting QFont from and to QString

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

add config file for testing X 16 bit depth support

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

update comment in QVariant test data

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

zero-copy QX11Data::copyXImageToQImage() for some cases

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QX11Data::copyXImageToQImage() optimization

the cake is a lie - even tho XGetPixel() and XPutPixel() take ulong as
pixel value it has to converted manually to value appropriate for the
XImage depth

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

Merge branch 'master' of https://scm.osdn.net/gitroot/kde/Katie

special-case QImage::Format_RGB16 with different bytes per line

for some reason on Debian XImage with depth equal to 16 can have different
bytes per line (off by 2 bits), on Arch it was not a thing when I tested
it so it could be a bug in X

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove QTextDecoder and QTextEncoder leftovers

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

convert the SVG image to QImage::Format_ARGB32_Premultiplied only if it is not in format with alpha channel

since it is painting of image (not painting to image) the performance
impact of it not being QImage::Format_ARGB32_Premultiplied is neglectable

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

drop noop SVG quality implementation

altought it would be pretty easy to implement it seems to be in somewhat
unsupported state anyway, for reference:
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/shape-rendering
https://developer.mozilla.org/en-US/docs/Web/CSS/image-rendering

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove redundant QCompleter::event() reimplementation

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused QPdf::generateLinearGradientShader() method

USE_NATIVE_GRADIENTS is never defined

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused QFontSubset::toTruetype() method

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

correct logic in isStyleMatch() function

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

load the application font as last resort instead of adding it to each patterns

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove now bogus QFont test

italic/oblique are handled as enum (QFont::Style) and hint for fontconfig
what kind of slant to match (if style name is not specified that is) which
means exact style match or nothing. trying to substitute, mix and match
such style names in QFontDatabase was bad idea to begin with (not my idea)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

do not add the last resort font to the pattern when loading font

the default QApplication font is the last resort font

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

minor QFont documentation review

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

do not add fonts with empty style to the database

Source Code Variable font has such entries for example

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

query and set font pixel size from QFontDatabase

note that font pixel size is DPI-scaled, it being -1 means scale it to the
DPI of the paint device for example and Katie supports only scalable fonts
for a reason

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

preperations to drop QFontInfo

since I do not care about qt compat only normal and regular style
names are matched as equal, for now

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

resolve family aliases from QFontDatabase methods

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

fix font style matching in QFontDatabase::font() and test case it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

set the pitch of the font from QFontDatabase::font()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

export qt_getClipRects() only for the QRegion test

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

move qt_getClipRects() function to qregion source file, where it belongs

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

lock before accessing the custom meta types global static in QMetaType::type()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

Revert "always allocate QGlyphLayout data on the heap"

will have to wait until the QTextEngine redo

This reverts commit 4a5239046adeb78397c868074fe48d595fcb8fa4.

always allocate QGlyphLayout data on the heap

much easier to calculate the glyph array data size and also no
possibility for stack corruption

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

add thread-safety test for QFontDatabase

it basically tests fontconfig thread-safety but QFontDatabase is documented
as thread-safe (as it should be) so why not add test case for it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QFontDatabase test review

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

do not assume FcObjectSetCreate(), FcPatternCreate() and FcFontList() return non-null pointers in QFontDatabase constructor

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

replace hardcoded QFont::Unstretched value with the enum

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

assume the codec MIB is in the table in QTextCodec::mibEnum() and add test for it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused headers inclusions in qfont source file

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

use the QPixmap::scaled() method in QMoviePrivate::next()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

use QVector for the QMetaMethod list in qInvokeTestMethods() function

operator new may throw if the method count is zero, a test case should have
atleast one method tho

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

move QTextConverter::ConversionFlag documentation bellow QTextConverter documentation

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

move constructor and destructor to the top in qfontdatabase source file

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

read PNG rows directly into QImage allocated memory

KAT format is still faster, benchmark result:
********* Start testing of tst_QImageReader *********
Config: Using QTest library 4.12.0, Katie 4.12.0
PASS  : tst_QImageReader::initTestCase()
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.kat":
     449,473.586 CPU ticks per iteration (total: 224,736,793, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.kat":
     12,192,500.92 CPU ticks per iteration (total: 6,096,250,460, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.kat":
     4,553,239.292 CPU ticks per iteration (total: 2,276,619,646, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.png":
     1,847,145.64 CPU ticks per iteration (total: 923,572,823, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.png":
     19,422,744.28 CPU ticks per iteration (total: 9,711,372,141, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.png":
     12,389,194.51 CPU ticks per iteration (total: 6,194,597,257, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.ppm":
     653,286.280 CPU ticks per iteration (total: 326,643,140, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.ppm":
     2,728,198.060 CPU ticks per iteration (total: 1,364,099,030, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.ppm":
     2,455,954.036 CPU ticks per iteration (total: 1,227,977,018, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.svg":
     10,524,974.96 CPU ticks per iteration (total: 5,262,487,482, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.xpm":
     8,238,501.942 CPU ticks per iteration (total: 4,119,250,971, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.xpm":
     74,886,112.602 CPU ticks per iteration (total: 37,443,056,301, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.xpm":
     63,337,570.664 CPU ticks per iteration (total: 31,668,785,332, iterations: 500)
PASS  : tst_QImageReader::readImage()
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.kat":
     1,950,330.16 CPU ticks per iteration (total: 975,165,082, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.kat":
     13,089,959.61 CPU ticks per iteration (total: 6,544,979,808, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.kat":
     5,447,284.922 CPU ticks per iteration (total: 2,723,642,461, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.png":
     3,342,337.962 CPU ticks per iteration (total: 1,671,168,981, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.png":
     20,326,863.998 CPU ticks per iteration (total: 10,163,431,999, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.png":
     13,279,201.09 CPU ticks per iteration (total: 6,639,600,546, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.ppm":
     1,498,119.28 CPU ticks per iteration (total: 749,059,644, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.ppm":
     3,641,910.638 CPU ticks per iteration (total: 1,820,955,319, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.ppm":
     3,370,265.894 CPU ticks per iteration (total: 1,685,132,947, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.svg":
     9,147,455.174 CPU ticks per iteration (total: 4,573,727,587, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.xpm":
     9,729,368.638 CPU ticks per iteration (total: 4,864,684,319, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.xpm":
     75,966,954.086 CPU ticks per iteration (total: 37,983,477,043, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.xpm":
     64,719,740.840 CPU ticks per iteration (total: 32,359,870,420, iterations: 500)
PASS  : tst_QImageReader::setScaledSize()
PASS  : tst_QImageReader::cleanupTestCase()
Totals: 4 passed, 0 failed, 0 skipped
********* Finished testing of tst_QImageReader *********

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

cache system fonts on per QFontDatabase object basis

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

drop support for registering custom QVariantAnimation interpolators

even the declarative component inherit and use internal animation classes
methods for interpolation, if anything there should be more interpolators
(e.g. for QVariant::LongLong and QVariant::ULongLong)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

qconfig header update

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused QErrorMessage class

Katana uses KMessageBox or system notifcations for such things

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

do not store the hinting flags in QFontEngineFT

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

translations update

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

update URL TLDs table data

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

Merge branch 'master' of https://scm.osdn.net/gitroot/kde/Katie

prepare genlocale.py script for CLDR v42

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

FreeBSD package footprint file update

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

add QChar enum for unicode v15.0

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

update unicode data tables to v15.0

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

include system locale header for setlocale() and LC_CTYPE in qkeymapper_x11 source file

fixes build on FreeBSD

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused qsettings header inclusion in qcommonstyle source file

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove redundant Q_EXPORT_PLUGIN2() macro

its PLUGIN argument is unused

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

README update

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove now unused plugin verification section and data

it should've been added even if QT_NO_PLUGIN_CHECK was defined btw, now
only ELF header is checked tho

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove redundant handle check in QLibrary::unload()

QLibraryPrivate::unload() does the same check

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

compiler warnings fix

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove redundant QSettings forward-declaration in qlibrary_p header

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

replace internal loadDocument<T>() function with its body

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QIconLoader doesn't need QObject as base class

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

Merge branch 'master' of https://scm.osdn.net/gitroot/kde/Katie

replace QCursorData::setBitmap() with its body

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove resource system leftovers in QPixmapIconEngine::addFile()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

use the stored pixmap mask in QCursor::handle()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QCursor rewrite

X may or may not copy the pixmaps so handles have to be kept until cursor
data destruction

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

ensure the QVariant type is QVariant::String in ini_settings_read() for compat

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

do not register QColor, QVector2D, QVector3D and QVector2D interpolators as external

now the interpolators global mutex will be held 4 times less when the
GUI component library is loaded and 4 more times when it is unloaded

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

document internal QFontDatabase methods as such

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

mark qt_FcPatternToQFontDef() function as static

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

Merge branch 'master' of https://scm.osdn.net/gitroot/kde/Katie

initialize values in QFont streaming operator

if they are not read from the QDataStream (e.g. premature end of data or
corrupt data) they will end up being zero tho because that is what
QDataStream sets them to on failure, perhaps it should not

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QFontDatabase::families() optimization

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove QApplication::fontDatabaseChanged() signal

it indicates that QFontDatabase has cached the fonts, not that system font
was added or removed which QFontDatabase should have signal for no
QCoreApplication/QApplication

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QJsonDocument optimization

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

drop support for storing types that are not QString-convertable via QSettings

I am not interested in custom types feature at all - QMainWindow for
example saves its state via QDataStream. ofcourse it involves conversion
but that is the case with QVariant aswell. there is also the qreal type
thing - it may be float, it may double. streaming QRectF has to be done
in such a way to account for both cases but here is the catch - if
conversion fails there has to be fallback which QSettings::value() kinda
covers for types that are not composed of several more types.

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QDebug documentation update

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QDebug rewrite to use QByteArray as internal buffer

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QDeclarativeInfo rewrite to not use QDebug

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

log the error string, not the QDeclarativeError pointer in QDeclarativeScriptActionPrivate::execute()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

revert f92053f38142c9b4a589f5623e3055958d145a01

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

Merge branch 'master' of https://scm.osdn.net/gitroot/kde/Katie

remove unused AVG16() macro

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

namefsck script update

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

drop compile-time options to disable debug and warning output

such type of messages can still be filtered by installing message handler

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QImage documentation update

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

use growing buffer (QDataBuffer) in blending functions

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

move variables to the scope they are used in QGradientData::generateGradientColorTable()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QImage::Format_RGB16 to XImage copying optimization

it is a bit tricky to figure out the compatible cases but the zero-copy
optimizations pay off

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

create print preview images with the page rectangle size and fill them with white color

fixes possible rendering issues (e.g. random colors at the edges)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>