OSDN Git Service
Marco Nelissen [Sat, 14 Jan 2017 02:34:21 +0000 (02:34 +0000)]
Don't initialize sync sample parameters until the end am:
a9660fe122
am:
22386993b5
Change-Id: Ia743be4048c57929c59b06a12b53f993b5b00111
Marco Nelissen [Sat, 14 Jan 2017 02:31:51 +0000 (02:31 +0000)]
Don't initialize sync sample parameters until the end
am:
a9660fe122
Change-Id: Ia072f16604c3e766d4d2cdc49b88efcf182ca5f7
Marco Nelissen [Thu, 12 Jan 2017 23:49:04 +0000 (15:49 -0800)]
Don't initialize sync sample parameters until the end
to avoid leaving them in a partially initialized state.
Bug:
33137046
Test: ran CTS tests
Change-Id: I1f5c070233c5917d85da9e930e01a3fc51a0a0ec
Eric Laurent [Wed, 4 Jan 2017 22:25:30 +0000 (22:25 +0000)]
DO NOT MERGE - improve audio effect framwework thread safety am:
b47a5ab107 am:
26cf2f4d73 am:
73a152960b -s ours am:
21d6eafd26 -s ours
am:
6c5deab4f2
Change-Id: I680ead77538594903bc5140f68eeb920a7ac39c0
Eric Laurent [Wed, 4 Jan 2017 22:22:59 +0000 (22:22 +0000)]
DO NOT MERGE - improve audio effect framwework thread safety am:
b47a5ab107 am:
26cf2f4d73 am:
73a152960b -s ours
am:
21d6eafd26 -s ours
Change-Id: I8ad30b3c76e746ed85dde65a841ebb17af519ce6
Eric Laurent [Wed, 4 Jan 2017 22:20:47 +0000 (22:20 +0000)]
DO NOT MERGE - improve audio effect framwework thread safety am:
b47a5ab107 am:
26cf2f4d73
am:
73a152960b -s ours
Change-Id: Id10c17b4bbdc1dd90a1cad25b6c697f8b6a0bcd0
Eric Laurent [Wed, 4 Jan 2017 22:17:58 +0000 (22:17 +0000)]
DO NOT MERGE - improve audio effect framwework thread safety am:
b47a5ab107
am:
26cf2f4d73
Change-Id: I6513190cce6756c47e5ede0dc578fa0d2c5889b3
Eric Laurent [Wed, 4 Jan 2017 22:15:59 +0000 (22:15 +0000)]
DO NOT MERGE - improve audio effect framwework thread safety am:
84c392104e -s ours
am:
5d5f9cd28a
Change-Id: I3f732f9e0c346c0e7989e22401062011ef7c7ed2
Eric Laurent [Wed, 4 Jan 2017 22:15:29 +0000 (22:15 +0000)]
DO NOT MERGE - improve audio effect framwework thread safety
am:
b47a5ab107
Change-Id: I46af7560653784852e771a2eefd581989aac0644
Eric Laurent [Wed, 4 Jan 2017 22:12:58 +0000 (22:12 +0000)]
DO NOT MERGE - improve audio effect framwework thread safety
am:
84c392104e -s ours
Change-Id: Ia65e289c7383406c719226e8f404b392ca4303b2
Eric Laurent [Thu, 1 Dec 2016 23:28:29 +0000 (15:28 -0800)]
DO NOT MERGE - improve audio effect framwework thread safety
- Reorganize handle effect creation code to make sure the effect engine
is created with both thread and effect chain mutex held.
- Reorganize handle disconnect code to make sure the effect engine
is released with both thread and effect chain mutex held.
- Protect IEffect interface methods in EffectHande with a Mutex.
- Only pin effect if the session was acquired first.
- Do not use strong pointer to EffectModule in EffectHandles:
only the EffectChain has a single strong reference to the EffectModule.
- Check reply size before writing status in EffectHandle::command()
Bug:
32707507
Bug:
32095713
Change-Id: Ia1098cba2cd32cc2d1c9dfdff4adc2388dfed80e
Eric Laurent [Thu, 1 Dec 2016 23:28:29 +0000 (15:28 -0800)]
DO NOT MERGE - improve audio effect framwework thread safety
- Reorganize handle effect creation code to make sure the effect engine
is created with both thread and effect chain mutex held.
- Reorganize handle disconnect code to make sure the effect engine
is released with both thread and effect chain mutex held.
- Protect IEffect interface methods in EffectHande with a Mutex.
- Only pin effect if the session was acquired first.
- Do not use strong pointer to EffectModule in EffectHandles:
only the EffectChain has a single strong reference to the EffectModule.
- Check reply size before writing status in EffectHandle::command()
Bug:
32707507
Bug:
32095713
Change-Id: Ia1098cba2cd32cc2d1c9dfdff4adc2388dfed80e
Andy Hung [Sat, 3 Dec 2016 00:45:17 +0000 (00:45 +0000)]
Merge "Effect: Use local cached data for Effect commit" into klp-dev am:
1576f5968c am:
308e51173e am:
94d5167a91 am:
98c2151dc3
am:
110d4d31b3
Change-Id: Id0e2e230e2ccd08f46cfd33cab5d7585e9623cf0
Andy Hung [Sat, 3 Dec 2016 00:45:02 +0000 (00:45 +0000)]
Effect: Use local cached data for Effect commit am:
dd79ccda92 am:
82c8c7656f am:
9851dee7da am:
4242950061
am:
a661c82829
Change-Id: I8318ec70f93d1ed10b5606511eb2d1885121f355
Andy Hung [Sat, 3 Dec 2016 00:42:49 +0000 (00:42 +0000)]
Merge "Effect: Use local cached data for Effect commit" into klp-dev am:
1576f5968c am:
308e51173e am:
94d5167a91
am:
98c2151dc3
Change-Id: I0105fd0ddab374f8d1e95cc9e45af094367edd30
Andy Hung [Sat, 3 Dec 2016 00:42:33 +0000 (00:42 +0000)]
Effect: Use local cached data for Effect commit am:
dd79ccda92 am:
82c8c7656f am:
9851dee7da
am:
4242950061
Change-Id: I9cee35a3c8df1747c5461dc62c3210a0de134b87
Andy Hung [Sat, 3 Dec 2016 00:40:47 +0000 (00:40 +0000)]
Merge "Effect: Use local cached data for Effect commit" into klp-dev am:
1576f5968c am:
308e51173e
am:
94d5167a91
Change-Id: I3a4af7a28adcd54d4590f447845b134acb80f053
Andy Hung [Sat, 3 Dec 2016 00:40:33 +0000 (00:40 +0000)]
Effect: Use local cached data for Effect commit am:
dd79ccda92 am:
82c8c7656f
am:
9851dee7da
Change-Id: I3d375c671122e61cf0b530457c37c1cd5c06e563
Andy Hung [Sat, 3 Dec 2016 00:38:50 +0000 (00:38 +0000)]
Merge "Effect: Use local cached data for Effect commit" into klp-dev am:
1576f5968c
am:
308e51173e
Change-Id: I7d741aa81543b95a6c3aeada9a259ba5a4c9b5bb
Andy Hung [Sat, 3 Dec 2016 00:38:33 +0000 (00:38 +0000)]
Effect: Use local cached data for Effect commit am:
dd79ccda92
am:
82c8c7656f
Change-Id: I8819bc1146b0b751abc0790edd4b7d73f2198038
Andy Hung [Sat, 3 Dec 2016 00:36:02 +0000 (00:36 +0000)]
Merge "Effect: Use local cached data for Effect commit" into klp-dev
am:
1576f5968c
Change-Id: I3310e7efeb0bcd1826d112e94e13f46ce5234755
Andy Hung [Sat, 3 Dec 2016 00:36:01 +0000 (00:36 +0000)]
Effect: Use local cached data for Effect commit
am:
dd79ccda92
Change-Id: Ide8165907e03b9d400eaa33a222ceeae782d6509
Andy Hung [Sat, 3 Dec 2016 00:32:27 +0000 (00:32 +0000)]
Merge "Effect: Use local cached data for Effect commit" into klp-dev
rago [Wed, 30 Nov 2016 19:34:20 +0000 (19:34 +0000)]
Fix security vulnerability: potential OOB write in audioserver am:
e275907e57 am:
01e854056a am:
3e8ab60b7f am:
9161586309
am:
ad29b47d91
Change-Id: I7ea2eaa2b1fb4cf652b702e847b2a83e777858ef
rago [Wed, 30 Nov 2016 19:28:49 +0000 (19:28 +0000)]
Fix security vulnerability: potential OOB write in audioserver am:
e275907e57 am:
01e854056a am:
3e8ab60b7f
am:
9161586309
Change-Id: Ibcceb08d7db77f67f3dfc3cdad1d2bd6994183ae
rago [Wed, 30 Nov 2016 19:23:21 +0000 (19:23 +0000)]
Fix security vulnerability: potential OOB write in audioserver am:
e275907e57 am:
01e854056a
am:
3e8ab60b7f
Change-Id: Ib575df34ec5bb7dc2cd83a859e10abe94e894317
rago [Wed, 30 Nov 2016 19:17:48 +0000 (19:17 +0000)]
Fix security vulnerability: potential OOB write in audioserver am:
e275907e57
am:
01e854056a
Change-Id: I7ea6a871eed4b9e1c56c5350c4e5fb5eb628e816
rago [Wed, 30 Nov 2016 19:12:17 +0000 (19:12 +0000)]
Fix security vulnerability: potential OOB write in audioserver
am:
e275907e57
Change-Id: I38086dbaeeef1c068887cc20aca9d557bb159372
rago [Wed, 23 Nov 2016 02:02:48 +0000 (18:02 -0800)]
Fix security vulnerability: potential OOB write in audioserver
Bug:
32705438
Bug:
32703959
Test: cts security test
Change-Id: I8900c92fa55b56c4c2c9d721efdbabe6bfc8a4a4
Andy Hung [Wed, 16 Nov 2016 01:19:58 +0000 (17:19 -0800)]
Effect: Use local cached data for Effect commit
Test: POC, Cts Effect, BassBoost, EnvReverb, Equalizer,
Test: LoudnessEnhancer, PresetReverb, Virtualizer, Visualizer
Bug:
32220769
Change-Id: Iea96ba0daf71691ee8954cca4ba1c10fe827626e
Ricardo Garcia [Tue, 15 Nov 2016 23:57:29 +0000 (23:57 +0000)]
Merge "Fix security vulnerability: Effect command might allow negative indexes" into klp-dev am:
501aee7a54 am:
dd269152c4 am:
756f8dcdc1 am:
8b850ec8d5
am:
b926fff90e
Change-Id: I918b03096776bb3881b1b3521e0da9917bbb1111
rago [Tue, 15 Nov 2016 23:57:09 +0000 (23:57 +0000)]
Fix security vulnerability: Effect command might allow negative indexes am:
01183402d7 am:
94e3424b74 am:
9bf3487e7a am:
d4881f8406
am:
f31abe2c96
Change-Id: I7f305a4dacb8dd382a52d6b3f95b41bfbd5151a6
Ricardo Garcia [Tue, 15 Nov 2016 23:49:57 +0000 (23:49 +0000)]
Merge "Fix security vulnerability: Effect command might allow negative indexes" into klp-dev am:
501aee7a54 am:
dd269152c4 am:
756f8dcdc1
am:
8b850ec8d5
Change-Id: I1cf21ca7d1124a986f390b103f4c641b67e807a9
rago [Tue, 15 Nov 2016 23:49:38 +0000 (23:49 +0000)]
Fix security vulnerability: Effect command might allow negative indexes am:
01183402d7 am:
94e3424b74 am:
9bf3487e7a
am:
d4881f8406
Change-Id: I4786037f49f5da37a1a363f7cb01c9c086776624
Ricardo Garcia [Tue, 15 Nov 2016 23:43:28 +0000 (23:43 +0000)]
Merge "Fix security vulnerability: Effect command might allow negative indexes" into klp-dev am:
501aee7a54 am:
dd269152c4
am:
756f8dcdc1
Change-Id: I9ce75a77ed741953c3476576387eebf77e21f784
rago [Tue, 15 Nov 2016 23:43:09 +0000 (23:43 +0000)]
Fix security vulnerability: Effect command might allow negative indexes am:
01183402d7 am:
94e3424b74
am:
9bf3487e7a
Change-Id: Ia36571a591829777096ad41316b7edf169ce9a6c
Ricardo Garcia [Tue, 15 Nov 2016 23:35:55 +0000 (23:35 +0000)]
Merge "Fix security vulnerability: Effect command might allow negative indexes" into klp-dev am:
501aee7a54
am:
dd269152c4
Change-Id: I336c76f311fc09cd81ccd22a35dada99d0b76be7
rago [Tue, 15 Nov 2016 23:35:37 +0000 (23:35 +0000)]
Fix security vulnerability: Effect command might allow negative indexes am:
01183402d7
am:
94e3424b74
Change-Id: Id0353ac5716377b45e3a967110d43d9baf744be8
Ricardo Garcia [Tue, 15 Nov 2016 23:28:07 +0000 (23:28 +0000)]
Merge "Fix security vulnerability: Effect command might allow negative indexes" into klp-dev
am:
501aee7a54
Change-Id: I7386c90f91d41d2b6df3efc28cfa6e4b4f79608a
rago [Tue, 15 Nov 2016 23:28:06 +0000 (23:28 +0000)]
Fix security vulnerability: Effect command might allow negative indexes
am:
01183402d7
Change-Id: I13603ac1cdb57b844ca7d03f119adda832825f34
Ricardo Garcia [Tue, 15 Nov 2016 23:19:20 +0000 (23:19 +0000)]
Merge "Fix security vulnerability: Effect command might allow negative indexes" into klp-dev
rago [Mon, 14 Nov 2016 22:58:34 +0000 (14:58 -0800)]
Fix security vulnerability: Effect command might allow negative indexes
Bug:
32448258
Bug:
32095626
Test: Use POC bug or cts security test
Change-Id: I69f24eac5866f8d9090fc4c0ebe58c2c297b63df
Ray Essick [Mon, 14 Nov 2016 21:13:37 +0000 (21:13 +0000)]
Merge "DO NOT MERGE: defensive parsing of mp3 album art information" into lmp-mr1-dev
am:
7cfd47c566
Change-Id: I6850faa8b803654a47fd7c4f9e661e16cf272ec6
Ray Essick [Mon, 14 Nov 2016 21:13:36 +0000 (21:13 +0000)]
DO NOT MERGE: defensive parsing of mp3 album art information
am:
5759c46d84
Change-Id: Ic50efe3ee2fc52ae3cf227d893723f1d9095dac5
Ray Essick [Mon, 14 Nov 2016 20:56:52 +0000 (20:56 +0000)]
Merge "DO NOT MERGE: defensive parsing of mp3 album art information" into lmp-mr1-dev
Marco Nelissen [Mon, 14 Nov 2016 20:42:35 +0000 (20:42 +0000)]
Make VBRISeeker more robust am:
7fdd36418e am:
ae0cffaced am:
82642824a5 am:
c236ae3ad0
am:
43dad372e7
Change-Id: Id0b9601ce428f2e30785c9bebabf14377bc89cd7
Marco Nelissen [Mon, 14 Nov 2016 20:35:04 +0000 (20:35 +0000)]
Make VBRISeeker more robust am:
7fdd36418e am:
ae0cffaced am:
82642824a5
am:
c236ae3ad0
Change-Id: If2f8a18bd63204d336f5de1862f8226b3c74a407
Marco Nelissen [Mon, 14 Nov 2016 20:27:34 +0000 (20:27 +0000)]
Make VBRISeeker more robust am:
7fdd36418e am:
ae0cffaced
am:
82642824a5
Change-Id: Ia7eb6656c3034793e8caea2b417d99fa0702d05d
Marco Nelissen [Mon, 14 Nov 2016 20:21:03 +0000 (20:21 +0000)]
Make VBRISeeker more robust am:
7fdd36418e
am:
ae0cffaced
Change-Id: I3e6fdf30fc372fb32cfbd24a37814d0946eaca2f
Marco Nelissen [Mon, 14 Nov 2016 20:13:03 +0000 (20:13 +0000)]
Make VBRISeeker more robust
am:
7fdd36418e
Change-Id: I0138de501cd433986e77927e27a527606b61ea25
Marco Nelissen [Fri, 11 Nov 2016 17:20:00 +0000 (09:20 -0800)]
Make VBRISeeker more robust
Bug:
32577290
Change-Id: I9bcc9422ae7dd3ae4a38df330c9dcd7ac4941ec8
Andy Hung [Thu, 10 Nov 2016 19:45:41 +0000 (19:45 +0000)]
Merge "Effects: Check get parameter command size" into klp-dev am:
c5768d0921 am:
cfe5d97cf3 am:
a74f0af62b am:
4f58afc951
am:
12aa313edb
Change-Id: I77ac723f45d399201fe8f3b8e0f73ea2ea64df41
Andy Hung [Thu, 10 Nov 2016 19:45:25 +0000 (19:45 +0000)]
Effects: Check get parameter command size am:
3d34cc76e3 am:
59920bf785 am:
14d87911d7 am:
79a088a065
am:
58e5681c96
Change-Id: I1dada214864e39b0294afdcfbda0523822646a96
Andy Hung [Thu, 10 Nov 2016 19:45:10 +0000 (19:45 +0000)]
Merge "DO NOT MERGE: Visualizer: Check capture size and latency parameters" into klp-dev am:
f89590d009 am:
50f9a9faea am:
684314f196 -s ours am:
354864c443 -s ours
am:
b52c98e44c
Change-Id: Ie31ee24a3e6a290cc8e702e08028590d34999b79
Andy Hung [Thu, 10 Nov 2016 19:44:55 +0000 (19:44 +0000)]
DO NOT MERGE: Visualizer: Check capture size and latency parameters am:
86cbc180f4 am:
ce8b7cd373 am:
34ce18d4e7 -s ours am:
eee2d5eed2 -s ours
am:
272b2fecd4
Change-Id: I414c623b77dc482f7c53c7c46fdbc4d822cb3694
Andy Hung [Thu, 10 Nov 2016 19:40:08 +0000 (19:40 +0000)]
Merge "Effects: Check get parameter command size" into klp-dev am:
c5768d0921 am:
cfe5d97cf3 am:
a74f0af62b
am:
4f58afc951
Change-Id: I67d6ab6c8083e4b509c6f065cb11de0a0c3101d7
Andy Hung [Thu, 10 Nov 2016 19:39:52 +0000 (19:39 +0000)]
Effects: Check get parameter command size am:
3d34cc76e3 am:
59920bf785 am:
14d87911d7
am:
79a088a065
Change-Id: I9d46fdc8a919d5339dddac558f1f5496f35b498a
Andy Hung [Thu, 10 Nov 2016 19:39:36 +0000 (19:39 +0000)]
Merge "DO NOT MERGE: Visualizer: Check capture size and latency parameters" into klp-dev am:
f89590d009 am:
50f9a9faea am:
684314f196 -s ours
am:
354864c443 -s ours
Change-Id: I4c6ac6e018ab04a83e94a58d040a765efd1e8546
Andy Hung [Thu, 10 Nov 2016 19:39:21 +0000 (19:39 +0000)]
DO NOT MERGE: Visualizer: Check capture size and latency parameters am:
86cbc180f4 am:
ce8b7cd373 am:
34ce18d4e7 -s ours
am:
eee2d5eed2 -s ours
Change-Id: I576b1d3716c599050a04752e0a14d8203457177f
Andy Hung [Thu, 10 Nov 2016 19:33:37 +0000 (19:33 +0000)]
Merge "Effects: Check get parameter command size" into klp-dev am:
c5768d0921 am:
cfe5d97cf3
am:
a74f0af62b
Change-Id: Ib5c23b1eb3919d9f849ec75fe5a46922d08ae12b
Andy Hung [Thu, 10 Nov 2016 19:33:22 +0000 (19:33 +0000)]
Effects: Check get parameter command size am:
3d34cc76e3 am:
59920bf785
am:
14d87911d7
Change-Id: Icbc43a1d34af774dcf500cdb3548d0399f0b6943
Andy Hung [Thu, 10 Nov 2016 19:33:06 +0000 (19:33 +0000)]
Merge "DO NOT MERGE: Visualizer: Check capture size and latency parameters" into klp-dev am:
f89590d009 am:
50f9a9faea
am:
684314f196 -s ours
Change-Id: I77de3ae3c9b9032b622b2502b4cda1bf0e0bfaea
Andy Hung [Thu, 10 Nov 2016 19:32:51 +0000 (19:32 +0000)]
DO NOT MERGE: Visualizer: Check capture size and latency parameters am:
86cbc180f4 am:
ce8b7cd373
am:
34ce18d4e7 -s ours
Change-Id: Icd8dd8dc6674729ab735d09d0b15f18e6fe28bdb
Andy Hung [Thu, 10 Nov 2016 19:26:36 +0000 (19:26 +0000)]
Merge "Effects: Check get parameter command size" into klp-dev am:
c5768d0921
am:
cfe5d97cf3
Change-Id: I748c867f0259d70eddec229457ca68ac7581dc09
Andy Hung [Thu, 10 Nov 2016 19:26:36 +0000 (19:26 +0000)]
Merge "Visualizer: Check capture size and latency parameters" into lmp-dev am:
565394b1da
am:
59c52a1c7b
Change-Id: I42938f96c0af7402e4e3bbe6eabee7fa7adf11e0
Andy Hung [Thu, 10 Nov 2016 19:26:21 +0000 (19:26 +0000)]
Effects: Check get parameter command size am:
3d34cc76e3
am:
59920bf785
Change-Id: I2d90659faa7d0085b33d0f527a97fa6dc82a70d7
Andy Hung [Thu, 10 Nov 2016 19:26:20 +0000 (19:26 +0000)]
Visualizer: Check capture size and latency parameters am:
9a2732ba0a
am:
5e0822f704
Change-Id: I5dffff4e104307e4d9baf7652935a9a361bd51ce
Andy Hung [Thu, 10 Nov 2016 19:26:06 +0000 (19:26 +0000)]
Merge "DO NOT MERGE: Visualizer: Check capture size and latency parameters" into klp-dev am:
f89590d009
am:
50f9a9faea
Change-Id: I2768ab9532953fde21bd10fcca5a509602e80553
Andy Hung [Thu, 10 Nov 2016 19:25:50 +0000 (19:25 +0000)]
DO NOT MERGE: Visualizer: Check capture size and latency parameters am:
86cbc180f4
am:
ce8b7cd373
Change-Id: I2afd4ba46fd6d62c3e89e49ec826ef7d683b324a
Andy Hung [Thu, 10 Nov 2016 19:20:32 +0000 (19:20 +0000)]
Merge "Effects: Check get parameter command size" into klp-dev
am:
c5768d0921
Change-Id: Ibd53fe698f492b7b4bb02181c8dda355a7485990
Andy Hung [Thu, 10 Nov 2016 19:20:29 +0000 (19:20 +0000)]
Effects: Check get parameter command size
am:
3d34cc76e3
Change-Id: Iacc05ef6b8fd1e906daaa3fd0b39c39049b47a0c
Andy Hung [Thu, 10 Nov 2016 19:19:52 +0000 (19:19 +0000)]
Merge "DO NOT MERGE: Visualizer: Check capture size and latency parameters" into klp-dev
am:
f89590d009
Change-Id: I8a9006c295b1a4b5759be649432a93851d66efc6
Andy Hung [Thu, 10 Nov 2016 19:19:51 +0000 (19:19 +0000)]
DO NOT MERGE: Visualizer: Check capture size and latency parameters
am:
86cbc180f4
Change-Id: Ieefd729dc4b90ecaba5bd7684b940ec70f9203b5
Andy Hung [Thu, 10 Nov 2016 19:19:22 +0000 (19:19 +0000)]
Merge "Visualizer: Check capture size and latency parameters" into lmp-dev
am:
565394b1da
Change-Id: I117666052e68605024d833a3d4a74fef7d21e3c1
Andy Hung [Thu, 10 Nov 2016 19:19:21 +0000 (19:19 +0000)]
Visualizer: Check capture size and latency parameters
am:
9a2732ba0a
Change-Id: I3e08e2106d1d1ccc6974e7036dea4617fb8c04f5
Andy Hung [Thu, 10 Nov 2016 19:16:40 +0000 (19:16 +0000)]
Merge "Effects: Check get parameter command size" into klp-dev
Andy Hung [Thu, 10 Nov 2016 19:15:01 +0000 (19:15 +0000)]
Merge "Visualizer: Check capture size and latency parameters" into lmp-dev
Andy Hung [Thu, 10 Nov 2016 19:13:24 +0000 (19:13 +0000)]
Merge "DO NOT MERGE: Visualizer: Check capture size and latency parameters" into klp-dev
Ricardo Garcia [Wed, 9 Nov 2016 19:47:32 +0000 (19:47 +0000)]
Merge "Fix security vulnerability: Equalizer command might allow negative indexes" into klp-dev am:
fc6faebb08 am:
ef01da120b am:
dc3b5edb63 am:
1b035a25ca
am:
048e810776
Change-Id: I3ebb1456893a4ee624f2ca009d71e6431d3d83d5
rago [Wed, 9 Nov 2016 19:47:18 +0000 (19:47 +0000)]
Fix security vulnerability: Equalizer command might allow negative indexes am:
e981cca9ff am:
8fb8275471 am:
6b4cf2c0d3 am:
dd060b3bb4
am:
4bcf2e6fbe
Change-Id: If429c65b08422dffa2ffc83c47e647db42ba9165
Ricardo Garcia [Wed, 9 Nov 2016 19:42:05 +0000 (19:42 +0000)]
Merge "Fix security vulnerability: Equalizer command might allow negative indexes" into klp-dev am:
fc6faebb08 am:
ef01da120b am:
dc3b5edb63
am:
1b035a25ca
Change-Id: I3c6fe49fc7cccebe92a9cf0a3120123ab678fba0
rago [Wed, 9 Nov 2016 19:41:48 +0000 (19:41 +0000)]
Fix security vulnerability: Equalizer command might allow negative indexes am:
e981cca9ff am:
8fb8275471 am:
6b4cf2c0d3
am:
dd060b3bb4
Change-Id: If6848a77e1f2a785c017d2e5d77f770c34a97d4c
Ricardo Garcia [Wed, 9 Nov 2016 19:36:32 +0000 (19:36 +0000)]
Merge "Fix security vulnerability: Equalizer command might allow negative indexes" into klp-dev am:
fc6faebb08 am:
ef01da120b
am:
dc3b5edb63
Change-Id: Ic7eaa2e7cc04107dd9eac4674aa3f8d7bfd283a3
rago [Wed, 9 Nov 2016 19:36:16 +0000 (19:36 +0000)]
Fix security vulnerability: Equalizer command might allow negative indexes am:
e981cca9ff am:
8fb8275471
am:
6b4cf2c0d3
Change-Id: I88ed7d46bb8d54dcb2309b103dd6fcf787ba3269
Ricardo Garcia [Wed, 9 Nov 2016 19:31:02 +0000 (19:31 +0000)]
Merge "Fix security vulnerability: Equalizer command might allow negative indexes" into klp-dev am:
fc6faebb08
am:
ef01da120b
Change-Id: I6cf6ce34535fd3120b9865c27dce39b043e595fc
rago [Wed, 9 Nov 2016 19:30:47 +0000 (19:30 +0000)]
Fix security vulnerability: Equalizer command might allow negative indexes am:
e981cca9ff
am:
8fb8275471
Change-Id: Iba4ca7302804912646e8c510d2e436ebbf8373aa
Ricardo Garcia [Wed, 9 Nov 2016 19:25:17 +0000 (19:25 +0000)]
Merge "Fix security vulnerability: Equalizer command might allow negative indexes" into klp-dev
am:
fc6faebb08
Change-Id: I8f81e75106cecd69eb8942dea1c375ce7aa729fd
rago [Wed, 9 Nov 2016 19:25:16 +0000 (19:25 +0000)]
Fix security vulnerability: Equalizer command might allow negative indexes
am:
e981cca9ff
Change-Id: I8355da91fab0d63fab72e05ba907708a3f3fe9c8
Ricardo Garcia [Wed, 9 Nov 2016 19:14:34 +0000 (19:14 +0000)]
Merge "Fix security vulnerability: Equalizer command might allow negative indexes" into klp-dev
Ray Essick [Wed, 9 Nov 2016 18:44:43 +0000 (18:44 +0000)]
DO NOT MERGE: defensive parsing of mp3 album art information am:
2ff80538b7 am:
c3819cfda9 am:
c696d76d98 -s ours am:
1e036d883e -s ours
am:
8326a5bd4f
Change-Id: I7e4df7a200ec1a9945e9371bedacbc880fb9c7cb
Ray Essick [Wed, 9 Nov 2016 18:38:42 +0000 (18:38 +0000)]
DO NOT MERGE: defensive parsing of mp3 album art information am:
2ff80538b7 am:
c3819cfda9 am:
c696d76d98 -s ours
am:
1e036d883e -s ours
Change-Id: I72ef099cc16c44823320453729da9c036d7fdca8
Ray Essick [Wed, 9 Nov 2016 18:33:12 +0000 (18:33 +0000)]
DO NOT MERGE: defensive parsing of mp3 album art information am:
2ff80538b7 am:
c3819cfda9
am:
c696d76d98 -s ours
Change-Id: I80f50a474af40a2ea3c732604e77caef6afadf46
Ray Essick [Wed, 9 Nov 2016 18:27:11 +0000 (18:27 +0000)]
DO NOT MERGE: defensive parsing of mp3 album art information am:
2ff80538b7
am:
c3819cfda9
Change-Id: I2a98a164f3c1d728e0f5bec906116cd1bffac19a
Ray Essick [Wed, 9 Nov 2016 18:27:11 +0000 (18:27 +0000)]
DO NOT MERGE: defensive parsing of mp3 album art information am:
52d02b97a4 -s ours
am:
d4bce2cc70
Change-Id: I4bbe609b4fd188182305136c7005fc5aebf33827
Ray Essick [Wed, 9 Nov 2016 18:21:12 +0000 (18:21 +0000)]
DO NOT MERGE: defensive parsing of mp3 album art information
am:
2ff80538b7
Change-Id: I864307c871b8ab48fd0fe2ddaba2e6ead0f0233a
Ray Essick [Wed, 9 Nov 2016 18:21:12 +0000 (18:21 +0000)]
DO NOT MERGE: defensive parsing of mp3 album art information
am:
52d02b97a4 -s ours
Change-Id: I6951ac809d45ac97e3f6d57ec6c978b086dc1f31
Ray Essick [Wed, 2 Nov 2016 21:16:28 +0000 (14:16 -0700)]
DO NOT MERGE: defensive parsing of mp3 album art information
several points in stagefrights mp3 album art code
used strlen() to parse user-supplied strings that may be
unterminated, resulting in reading beyond the end of a buffer.
This changes the code to use strnlen() for 8-bit encodings and
strengthens the parsing of 16-bit encodings similarly. It also
reworks how we watch for the end-of-buffer to avoid all over-reads.
Bug:
32377688
Test: crafted mp3's w/ good/bad cover art. See what showed in play music
Change-Id: I479d51e88d3180461cb6ea5540974671cfd84201
(cherry picked from commit
52d02b97a4dc54cff9c4f058eeeab6753c2230a0)
Andy Hung [Sat, 5 Nov 2016 02:40:53 +0000 (19:40 -0700)]
Effects: Check get parameter command size
Test: Custom test.
Bug:
32438594
Bug:
32624850
Bug:
32635664
Change-Id: I9b1315e2c02f11bea395bfdcf5c1ccddccbad8a6
Ray Essick [Wed, 2 Nov 2016 21:16:28 +0000 (14:16 -0700)]
DO NOT MERGE: defensive parsing of mp3 album art information
several points in stagefrights mp3 album art code
used strlen() to parse user-supplied strings that may be
unterminated, resulting in reading beyond the end of a buffer.
This changes the code to use strnlen() for 8-bit encodings and
strengthens the parsing of 16-bit encodings similarly. It also
reworks how we watch for the end-of-buffer to avoid all over-reads.
Bug:
32377688
Test: crafted mp3's w/ good/bad cover art. See what showed in play music
Change-Id: I479d51e88d3180461cb6ea5540974671cfd84201
Ray Essick [Wed, 2 Nov 2016 21:15:43 +0000 (14:15 -0700)]
DO NOT MERGE: defensive parsing of mp3 album art information
several points in stagefrights mp3 album art code
used strlen() to parse user-supplied strings that may be
unterminated, resulting in reading beyond the end of a buffer.
This changes the code to use strnlen() for 8-bit encodings and
strengthens the parsing of 16-bit encodings similarly. It also
reworks how we watch for the end-of-buffer to avoid all over-reads.
Bug:
32377688
Test: crafted mp3's w/ good/bad cover art. See what showed in play music
Change-Id: Idbaf221fa2283b33e83f399562a3323dd095cc2c