OSDN Git Service
Robert Haas [Tue, 3 Aug 2010 19:53:20 +0000 (19:53 +0000)]
Regression tests for new btree_gist "not equals" support.
Jeff Davis, with minor adjustments by me.
Tom Lane [Tue, 3 Aug 2010 19:24:05 +0000 (19:24 +0000)]
Code review for --quote-all-identifiers patch: add missing --help documentation
for new pg_dump/pg_dumpall parameters, make a couple of trivial stylistic
adjustments to make the code follow usual project style.
Tom Lane [Tue, 3 Aug 2010 19:02:21 +0000 (19:02 +0000)]
Fix mangled grammar.
Tom Lane [Tue, 3 Aug 2010 18:33:09 +0000 (18:33 +0000)]
Kibitzing on \conninfo patch: adjust the order of field output to match
the parameters of \connect, and fix oversight of not enabling translation
of the messages. Also, adjust \connect's similar messages to match, and
deal with 8.2-era violation of basic translatability guidelines there.
Bruce Momjian [Tue, 3 Aug 2010 17:14:19 +0000 (17:14 +0000)]
Add EXPLAIN documentation example.
gabrielle <gorthx@gmail.com>
Tom Lane [Tue, 3 Aug 2010 16:31:02 +0000 (16:31 +0000)]
Add some comments to tinterval_cmp_internal pointing out its severe
implementation deficiencies. Per discussion of bug #5592, we're not
going to change it, but these things should be documented so that if
anyone ever reimplements type tinterval, they will be more careful.
Robert Haas [Tue, 3 Aug 2010 15:47:02 +0000 (15:47 +0000)]
Fix inheritance count tracking in ALTER TABLE .. ADD CONSTRAINT.
Without this patch, constraints inherited by children of a parent
table which itself has multiple inheritance parents can end up with
the wrong coninhcount. After dropping the constraint, the children
end up with a leftover copy of the constraint that is not dumped
and cannot be dropped. There is a similar problem with ALTER TABLE
.. ADD COLUMN, but that looks significantly more difficult to
resolve, so I'm committing this fix separately.
Back-patch to 8.4, which is the first release that has coninhcount.
Report by Hank Enting.
Tom Lane [Tue, 3 Aug 2010 15:15:31 +0000 (15:15 +0000)]
Fix markup, other minor editing for recent btree_gist doc changes.
Tom Lane [Tue, 3 Aug 2010 01:50:27 +0000 (01:50 +0000)]
Be a little more careful with the shift computations in QT2QTN and
makeTSQuerySign. The first of these is a live bug, on some platforms,
as per bug #5590 from John Regehr. However the consequences seem limited
because of the relatively narrow scope of use of QTNode.sign. The shift in
makeTSQuerySign is actually safe because TSQS_SIGLEN is unsigned, but it
seems like a good idea to insert an explicit cast rather than depend on that.
Tom Lane [Tue, 3 Aug 2010 00:10:39 +0000 (00:10 +0000)]
Fix core dump in QTNodeCompare when tsquery_cmp() is applied to two empty
tsqueries. CompareTSQ has to have a guard for the case rather than blindly
applying QTNodeCompare to random data past the end of the datums. Also,
change QTNodeCompare to be a little less trusting: use an actual test rather
than just Assert'ing that the input is sane. Problem encountered while
investigating another issue (I saw a core dump in autoanalyze on a table
containing multiple empty tsquery values).
Back-patch to all branches with tsquery support.
In HEAD, also fix some bizarre (though not outright wrong) coding in
tsq_mcontains().
Robert Haas [Mon, 2 Aug 2010 23:20:23 +0000 (23:20 +0000)]
Teach levenshtein() about multi-byte characters.
Based on a patch by, and further ideas from, Alexander Korotkov.
Robert Haas [Mon, 2 Aug 2010 16:26:48 +0000 (16:26 +0000)]
Add btree_gist support for searching on "not equals".
Jeff Davis, with slight editorialization by me.
Tom Lane [Mon, 2 Aug 2010 04:51:17 +0000 (04:51 +0000)]
Don't try to force use of -no-cpp-precomp on OS X. It's been five years
since Apple shipped a compiler that needed this switch, and there's
increasing interest in using other compilers that won't accept the switch
at all. Better to let anybody who still needs the switch inject it via
CPPFLAGS. Per gripe from Neil Conway.
Robert Haas [Mon, 2 Aug 2010 03:46:54 +0000 (03:46 +0000)]
Remove ancient PL/pgsql line numbering hack.
While this hack arguably has some benefit in terms of making PL/pgsql's
line numbering match the programmer's expectations, it also makes
PL/pgsql inconsistent with the remaining PLs, making it difficult for
clients to reliably determine where the error actually is. On balance,
it seems better to be consistent.
Pavel Stehule
Tom Lane [Mon, 2 Aug 2010 02:29:39 +0000 (02:29 +0000)]
Tweak a couple of macros in the regex code to suppress compiler warnings
from "clang". The VERR changes make an assignment unconditional, which is
probably easier to read/understand anyway, and one can hardly argue that
it's worth shaving cycles off the case of reporting another error when
one has already been detected. The INSIST change limits where that macro
can be used, but not in a way that creates a problem for any existing call.
Tom Lane [Mon, 2 Aug 2010 01:24:54 +0000 (01:24 +0000)]
Fix an ancient typo that prevented the detection of conflicting fields when
interval input "invalid" was specified together with other fields. Spotted
by Neil Conway with the help of a clang warning. Although this has been
wrong since the interval code was written more than 10 years ago, it doesn't
affect anything beyond which error message you get for a wrong input, so not
worth back-patching very far.
Tom Lane [Sun, 1 Aug 2010 22:38:11 +0000 (22:38 +0000)]
Fix ANALYZE's ancient deficiency of not trying to collect stats for expression
indexes when the index column type (the opclass opckeytype) is different from
the expression's datatype. When coded, this limitation wasn't worth worrying
about because we had no intelligence to speak of in stats collection for the
datatypes used by such opclasses. However, now that there's non-toy
estimation capability for tsvector queries, it amounts to a bug that ANALYZE
fails to do this.
The fix changes struct VacAttrStats, and therefore constitutes an API break
for custom typanalyze functions. Therefore we can't back-patch it into
released branches, but it was agreed that 9.0 isn't yet frozen hard enough
to make such a change unacceptable. Ergo, back-patch to 9.0 but no further.
The API break had better be mentioned in 9.0 release notes.
Tom Lane [Sun, 1 Aug 2010 21:31:08 +0000 (21:31 +0000)]
Add some knowledge about prefix matches to tsmatchsel(). It's not terribly
bright, but it beats assuming that a prefix match behaves identically to an
exact match, which is what the code was doing before :-(. Noted while
experimenting with Artur Dobrowski's example.
Tom Lane [Sun, 1 Aug 2010 19:16:39 +0000 (19:16 +0000)]
Fix an additional set of problems in GIN's handling of lossy page pointers.
Although the key-combining code claimed to work correctly if its input
contained both lossy and exact pointers for a single page in a single TID
stream, in fact this did not work, and could not work without pretty
fundamental redesign. Modify keyGetItem so that it will not return such a
stream, by handling lossy-pointer cases a bit more explicitly than we did
before.
Per followup investigation of a gripe from Artur Dabrowski.
An example of a query that failed given his data set is
select count(*) from search_tab where
(to_tsvector('german', keywords ) @@ to_tsquery('german', 'ee:* | dd:*')) and
(to_tsvector('german', keywords ) @@ to_tsquery('german', 'aa:*'));
Back-patch to 8.4 where the lossy pointer code was introduced.
Tom Lane [Sun, 1 Aug 2010 02:12:42 +0000 (02:12 +0000)]
Rewrite the rbtree routines so that an RBNode is the first field of the
struct representing a tree entry, rather than being a separately allocated
piece of storage. This API is at least as clean as the old one (if not
more so --- there were some bizarre choices in there) and it permits a
very substantial memory savings, on the order of 2X in ginbulk.c's usage.
Also, fix minor memory leaks in code called by ginEntryInsert, in
particular in ginInsertValue and entryFillRoot, as well as ginEntryInsert
itself. These leaks resulted in the GIN index build context continuing
to bloat even after we'd filled it to maintenance_work_mem and started
to dump data out to the index.
In combination these fixes restore the GIN index build code to honoring
the maintenance_work_mem limit about as well as it did in 8.4. Speed
seems on par with 8.4 too, maybe even a bit faster, for a non-pathological
case in which HEAD was formerly slower.
Back-patch to 9.0 so we don't have a performance regression from 8.4.
Robert Haas [Sun, 1 Aug 2010 01:08:29 +0000 (01:08 +0000)]
Make psql distinguish between unique indices and unique constraints.
Josh Kupershmidt. Reviewing and kibitzing by Kevin Grittner and me.
Tom Lane [Sat, 31 Jul 2010 03:27:40 +0000 (03:27 +0000)]
Tweak tsmatchsel() so that it examines the structure of the tsquery whenever
possible (ie, whenever the tsquery is a constant), even when no statistics
are available for the tsvector. For example, foo @@ 'a & b'::tsquery
can be expected to be more selective than foo @@ 'a'::tsquery, whether
or not we know anything about foo. We use DEFAULT_TS_MATCH_SEL as the assumed
selectivity of individual query terms when no stats are available, then
combine the terms according to the query's AND/OR structure as usual.
Per experimentation with Artur Dabrowski's example. (The fact that there
are no stats available in that example is a problem in itself, but
nonetheless tsmatchsel should be smarter about the case.)
Back-patch to 8.4 to keep all versions of tsmatchsel() in sync.
Tom Lane [Sat, 31 Jul 2010 00:30:54 +0000 (00:30 +0000)]
Rewrite the key-combination logic in GIN's keyGetItem() and scanGetItem()
routines to make them behave better in the presence of "lossy" index pointers.
The previous coding was outright incorrect for some cases, as recently
reported by Artur Dabrowski: scanGetItem would fail to return index entries in
cases where one index key had multiple exact pointers on the same page as
another key had a lossy pointer. Also, keyGetItem was extremely inefficient
for cases where a single index key generates multiple "entry" streams, such as
an @@ operator with a multiple-clause tsquery. The presence of a lossy page
pointer in any one stream defeated its ability to use the opclass
consistentFn, resulting in probing many heap pages that didn't really need to
be visited. In Artur's example case, a query like
WHERE tsvector @@ to_tsquery('a & b')
was about 50X slower than the theoretically equivalent
WHERE tsvector @@ to_tsquery('a') AND tsvector @@ to_tsquery('b')
The way that I chose to fix this was to have GIN call the consistentFn
twice with both TRUE and FALSE values for the in-doubt entry stream,
returning a hit if either call produces TRUE, but not if they both return
FALSE. The code handles this for the case of a single in-doubt entry stream,
but punts (falling back to the stupid behavior) if there's more than one lossy
reference to the same page. The idea could be scaled up to deal with multiple
lossy references, but I think that would probably be wasted complexity. At
least to judge by Artur's example, such cases don't occur often enough to be
worth trying to optimize.
Back-patch to 8.4. 8.3 did not have lossy GIN index pointers, so not
subject to these problems.
Robert Haas [Fri, 30 Jul 2010 04:30:23 +0000 (04:30 +0000)]
Make details of the Numeric representation private to numeric.c.
Review by Tom Lane.
Tom Lane [Thu, 29 Jul 2010 23:16:33 +0000 (23:16 +0000)]
Improved version of patch to protect pg_get_expr() against misuse:
look through join alias Vars to avoid breaking join queries, and
move the test to someplace where it will catch more possible ways
of calling a function. We still ought to throw away the whole thing
in favor of a data-type-based solution, but that's not feasible in
the back branches.
This needs to be back-patched further than 9.0, but I don't have time
to do so today. Committing now so that the fix gets into 9.0beta4.
Simon Riggs [Thu, 29 Jul 2010 22:27:27 +0000 (22:27 +0000)]
Rename asyncCommitLSN to asyncXactLSN to reflect changed role in 9.0.
Transaction aborts now record their LSN to avoid corner case
behaviour in SR/HS, hence change of name of variables and functions.
As pointed out by Fujii Masao. Cosmetic changes only.
Tom Lane [Thu, 29 Jul 2010 21:18:11 +0000 (21:18 +0000)]
Update release notes for 9.0 beta 4. Back-patch some changes that were made only in HEAD.
Robert Haas [Thu, 29 Jul 2010 20:11:48 +0000 (20:11 +0000)]
Avoid using text_to_cstring() in levenshtein functions.
Operating directly on the underlying varlena saves palloc and memcpy
overhead, which testing shows to be significant.
Extracted from a larger patch by Alexander Korotkov.
Tom Lane [Thu, 29 Jul 2010 20:09:25 +0000 (20:09 +0000)]
Clean up some inconsistencies in the volatility marking of various I/O
related functions. Per today's discussion, we will henceforth assume
that datatype I/O functions are either stable or immutable, never volatile.
(This implies in particular that domain CHECK constraint expressions shouldn't
be volatile, since domain_in executes them.) In turn, functions that execute
the I/O functions of arbitrary datatypes should always be labeled stable.
This affects the labeling of array_to_string, which was unsafely marked
immutable, and record_in, record_out, record_recv, record_send,
domain_in, domain_recv, which were over-conservatively marked volatile.
The array I/O functions were already marked stable, which is correct
per this policy but would have been wrong if we maintained domain_in
as volatile.
Back-patch to 9.0, along with an earlier fix to correctly mark cash_in
and cash_out as stable not immutable (since they depend on lc_monetary).
No catversion bump --- the implications of this are not currently
severe enough to justify a forced initdb.
Peter Eisentraut [Thu, 29 Jul 2010 19:34:41 +0000 (19:34 +0000)]
Fix indentation of verbatim block elements
Block elements with verbatim formatting (literallayout, programlisting,
screen, synopsis) should be aligned at column 0 independent of the surrounding
SGML, because whitespace is significant, and indenting them creates erratic
whitespace in the output. The CSS stylesheets already take care of indenting
the output.
Assorted markup improvements to go along with it.
Tom Lane [Thu, 29 Jul 2010 19:23:20 +0000 (19:23 +0000)]
Fix another longstanding problem in copy_relation_data: it was blithely
assuming that a local char[] array would be aligned on at least a word
boundary. There are architectures on which that is pretty much guaranteed to
NOT be the case ... and those arches also don't like non-aligned memory
accesses, meaning that log_newpage() would crash if it ever got invoked.
Even on Intel-ish machines there's a potential for a large performance penalty
from doing I/O to an inadequately aligned buffer. So palloc it instead.
Backpatch to 8.0 --- 7.4 doesn't have this code.
Tom Lane [Thu, 29 Jul 2010 18:29:52 +0000 (18:29 +0000)]
Work around a documentation toolchain problem by replacing the "AIX-fixlevels"
table with a <variablelist> carrying the same information. Previously the
9.0 documentation was failing to build as a US-size PDF file. It's quite
obscure what the real problem is or why this avoids it, but we need a hack
now so we can build docs for beta4.
In passing do a bit of editing in the AIX installation docs, in particular
remove a long-obsolete claim that the regression tests are likely to fail.
Robert Haas [Thu, 29 Jul 2010 16:14:36 +0000 (16:14 +0000)]
Fix possible page corruption by ALTER TABLE .. SET TABLESPACE.
If a zeroed page is present in the heap, ALTER TABLE .. SET TABLESPACE will
set the LSN and TLI while copying it, which is wrong, and heap_xlog_newpage()
will do the same thing during replay, so the corruption propagates to any
standby. Note, however, that the bug can't be demonstrated unless archiving
is enabled, since in that case we skip WAL logging altogether, and the LSN/TLI
are not set.
Back-patch to 8.0; prior releases do not have tablespaces.
Analysis and patch by Jeff Davis. Adjustments for back-branches and minor
wordsmithing by me.
Simon Riggs [Thu, 29 Jul 2010 11:06:34 +0000 (11:06 +0000)]
Add explicit regression tests for ALTER TABLE lock levels.
Use this to catch a couple of lock level assignments that slipped
through manual testing, per Peter Eisentraut.
Peter Eisentraut [Wed, 28 Jul 2010 20:34:34 +0000 (20:34 +0000)]
Remove wildly obsolete type attribute externallength from chkpass
Tom Lane [Wed, 28 Jul 2010 17:21:56 +0000 (17:21 +0000)]
Fix oversight in new EvalPlanQual logic: the second loop over the ExecRowMark
list in ExecLockRows() forgot to allow for the possibility that some of the
rowmarks are for child tables that aren't relevant to the current row.
Per report from Kenichiro Tanaka.
Simon Riggs [Wed, 28 Jul 2010 05:22:24 +0000 (05:22 +0000)]
Reduce lock levels of CREATE TRIGGER and some ALTER TABLE, CREATE RULE actions.
Avoid hard-coding lockmode used for many altering DDL commands, allowing easier
future changes of lock levels. Implementation of initial analysis on DDL
sub-commands, so that many lock levels are now at ShareUpdateExclusiveLock or
ShareRowExclusiveLock, allowing certain DDL not to block reads/writes.
First of number of planned changes in this area; additional docs required
when full project complete.
Tom Lane [Wed, 28 Jul 2010 04:50:50 +0000 (04:50 +0000)]
Fix potential failure when hashing the output of a subplan that produces
a pass-by-reference datatype with a nontrivial projection step.
We were using the same memory context for the projection operation as for
the temporary context used by the hashtable routines in execGrouping.c.
However, the hashtable routines feel free to reset their temp context at
any time, which'd lead to destroying input data that was still needed.
Report and diagnosis by Tao Ma.
Back-patch to 8.1, where the problem was introduced by the changes that
allowed us to work with "virtual" tuples instead of materializing intermediate
tuple values everywhere. The earlier code looks quite similar, but it doesn't
suffer the problem because the data gets copied into another context as a
result of having to materialize ExecProject's output tuple.
Peter Eisentraut [Wed, 28 Jul 2010 04:39:14 +0000 (04:39 +0000)]
Show psql timing output even in quiet mode
These two settings ought to be independent of each other.
Robert Haas [Tue, 27 Jul 2010 23:43:42 +0000 (23:43 +0000)]
Add ssl_cipher() and ssl_version() functions to contrib/sslinfo.
Review by Dave Page.
Robert Haas [Tue, 27 Jul 2010 20:02:06 +0000 (20:02 +0000)]
Fix typo in PL/pgsql code example.
Backpatch to 8.4.
Marc Cousin. Review by Kevin Grittner.
Peter Eisentraut [Tue, 27 Jul 2010 19:01:16 +0000 (19:01 +0000)]
Spelling fixes
Robert Haas [Tue, 27 Jul 2010 16:06:53 +0000 (16:06 +0000)]
In postgresql.conf.sample, use on/off rather than true/false.
We used to be consistent about this, but my recent patch to add a
restart_after_crash GUC failed to follow the existing convention.
Report and patch from Fujii Masao.
Alvaro Herrera [Tue, 27 Jul 2010 04:18:28 +0000 (04:18 +0000)]
Ensure $_SHARED is declared in the main:: namespace, per bugs #5570 and #5571.
Author: Alex Hunsaker
Peter Eisentraut [Mon, 26 Jul 2010 20:28:49 +0000 (20:28 +0000)]
Fix grammar
backpatched to 8.1
Peter Eisentraut [Mon, 26 Jul 2010 20:14:05 +0000 (20:14 +0000)]
Add table creation and population to example
from John Gage
Bruce Momjian [Mon, 26 Jul 2010 01:43:52 +0000 (01:43 +0000)]
Remove tabs from sgml file.
Robert Haas [Sun, 25 Jul 2010 23:21:22 +0000 (23:21 +0000)]
CREATE TABLE IF NOT EXISTS.
Reviewed by Bernd Helmle.
Peter Eisentraut [Sun, 25 Jul 2010 08:30:42 +0000 (08:30 +0000)]
Add INSERT statement to example so that it can be reproduced
from John Gage
Bruce Momjian [Sun, 25 Jul 2010 03:47:29 +0000 (03:47 +0000)]
Adjust check_for_isn_and_int8_passing_mismatch() so it is called for all
migrations.
Backpatch to 9.0.
Bruce Momjian [Sun, 25 Jul 2010 03:28:32 +0000 (03:28 +0000)]
Prevent pg_upgrade from migrating databases that use reg* data types
where the oid is not preserved by pg_upgrade (everything but pg_type).
Update documentation.
Per bug report from depstein@alliedtesting.com.
Peter Eisentraut [Sat, 24 Jul 2010 16:46:57 +0000 (16:46 +0000)]
Fix typo
Peter Eisentraut [Sat, 24 Jul 2010 12:17:35 +0000 (12:17 +0000)]
Tidy up boolean data type page
by Thom Brown
Peter Eisentraut [Sat, 24 Jul 2010 12:16:20 +0000 (12:16 +0000)]
Remove tab from SGML file
Peter Eisentraut [Fri, 23 Jul 2010 20:04:18 +0000 (20:04 +0000)]
Add more checks against altering typed tables
- Prohibit altering column type
- Prohibit changing inheritance
- Move checks from Exec to Prep phases in ALTER TABLE code
backpatched to 9.0
Robert Haas [Fri, 23 Jul 2010 14:56:54 +0000 (14:56 +0000)]
Have psql avoid describing local sockets as host names.
We now use the phrase 'via local socket in' rather than 'on host' in both
\c and \conninfo output, when applicable.
Fujii Masao, with some kibitzing by me.
Robert Haas [Fri, 23 Jul 2010 00:43:00 +0000 (00:43 +0000)]
Avoid deep recursion when assigning XIDs to multiple levels of subxacts.
Backpatch to 8.0.
Andres Freund, with cleanup and adjustment for older branches by me.
Robert Haas [Thu, 22 Jul 2010 13:03:11 +0000 (13:03 +0000)]
Add missing function prototype.
Fujii Masao
Robert Haas [Thu, 22 Jul 2010 01:25:01 +0000 (01:25 +0000)]
Fix bogus server version in pg_dumpall --quote-all-identifiers.
Robert Haas [Thu, 22 Jul 2010 01:22:35 +0000 (01:22 +0000)]
Add options to force quoting of all identifiers.
I've added a quote_all_identifiers GUC which affects the behavior
of the backend, and a --quote-all-identifiers argument to pg_dump
and pg_dumpall which sets the GUC and also affects the quoting done
internally by those applications.
Design by Tom Lane; review by Alex Hunsaker; in response to bug #5488
filed by Hartmut Goebel.
Robert Haas [Thu, 22 Jul 2010 00:47:59 +0000 (00:47 +0000)]
Centralize DML permissions-checking logic.
Remove bespoke code in DoCopy and RI_Initial_Check, which now instead
fabricate call ExecCheckRTPerms with a manufactured RangeTblEntry.
This is intended to make it feasible for an enhanced security provider
to actually make use of ExecutorCheckPerms_hook, but also has the
advantage that RI_Initial_Check can allow use of the fast-path when
column-level but not table-level permissions are present.
KaiGai Kohei. Reviewed (in an earlier version) by Stephen Frost, and by me.
Some further changes to the comments by me.
Bruce Momjian [Tue, 20 Jul 2010 18:38:53 +0000 (18:38 +0000)]
CVS test: please ignore
Does modification just of CVS tag text cause an empty CVS diff for the commit?
Bruce Momjian [Tue, 20 Jul 2010 18:14:16 +0000 (18:14 +0000)]
Properly replay CREATE TABLESPACE during crash recovery by deleting
directory/symlink before creation.
Report from Tom Lane.
Backpatch to 9.0.
Robert Haas [Tue, 20 Jul 2010 14:14:30 +0000 (14:14 +0000)]
Have \conninfo mention the port even for local sockets.
Per discussion with David Christensen, there can be multiple
instances of PG accessible via local sockets, and you need the port
to see which one you're actually connected to. David's original
patch worked this way, but I inadvertently ripped it out during
commit.
Robert Haas [Tue, 20 Jul 2010 03:54:19 +0000 (03:54 +0000)]
Add \conninfo command to psql, to show current connection info.
David Christensen. Reviewed by Steve Singer. Some further changes by me.
Robert Haas [Tue, 20 Jul 2010 01:57:19 +0000 (01:57 +0000)]
Make ECPG regression tests independent of standard_conforming_strings.
Per buildfarm, again.
Robert Haas [Tue, 20 Jul 2010 01:22:52 +0000 (01:22 +0000)]
Make hstore regression tests independent of standard_conforming_strings.
Per buildfarm.
Robert Haas [Tue, 20 Jul 2010 00:47:53 +0000 (00:47 +0000)]
Add restart_after_crash GUC.
Normally, we automatically restart after a backend crash, but in some
cases when PostgreSQL is invoked by clusterware it may be desirable to
suppress this behavior, so we provide an option which does this.
Since no existing GUC group quite fits, create a new group called
"error handling options" for this and the previously undocumented GUC
exit_on_error, which is now documented.
Review by Fujii Masao.
Robert Haas [Tue, 20 Jul 2010 00:34:44 +0000 (00:34 +0000)]
Change the default value of standard_conforming_strings to on.
This change should be publicized to driver maintainers at once and
release-noted as an incompatibility with previous releases.
Peter Eisentraut [Mon, 19 Jul 2010 18:53:25 +0000 (18:53 +0000)]
Portability fixes for Solaris for requirepeer feature patch
per report from Dave Page
Tom Lane [Sun, 18 Jul 2010 23:43:32 +0000 (23:43 +0000)]
Remove unnecessary "Not safe to send CSV data" complaint from elog.c's fallback
path when CSV logging is configured but not yet operational. It's sufficient
to send the message to stderr, as we were already doing, and the "Not safe"
gripe has already confused at least two core members ...
Backpatch to 9.0, but not further --- doesn't seem appropriate to change
this behavior in stable branches.
Tom Lane [Sun, 18 Jul 2010 19:37:49 +0000 (19:37 +0000)]
Allow ORDER BY/GROUP BY/etc items to match targetlist items regardless of
any implicit casting previously applied to the targetlist item. This is
reasonable because the implicit cast, by definition, wasn't written by the
user; so we are preserving the expected behavior that ORDER BY items match
textually equivalent tlist items. The case never arose before because there
couldn't be any implicit casting of a top-level SELECT item before we process
ORDER BY etc. But now it can arise in the context of aggregates containing
ORDER BY clauses, since the "targetlist" is the already-casted list of
arguments for the aggregate. The net effect is that the datatype used for
ORDER BY/DISTINCT purposes is the aggregate's declared input type, not that
of the original input column; which is a bit debatable but not horrendous,
and to do otherwise would require major rework that doesn't seem justified.
Per bug #5564 from Daniel Grace. Back-patch to 9.0 where aggregate ORDER BY
was implemented.
Tom Lane [Sun, 18 Jul 2010 17:08:11 +0000 (17:08 +0000)]
Fix up poor handling of unsupported-platform case in requirepeer patch.
Tom Lane [Sun, 18 Jul 2010 16:42:20 +0000 (16:42 +0000)]
Fix thinko in recent patch: 'sock' should be 'conn->sock'.
Bruce Momjian [Sun, 18 Jul 2010 15:51:00 +0000 (15:51 +0000)]
Add SO_PEERCRED check in new unix domain socket permission checking code.
Peter Eisentraut [Sun, 18 Jul 2010 11:37:26 +0000 (11:37 +0000)]
Add server authentication over Unix-domain sockets
This adds a libpq connection parameter requirepeer that specifies the user
name that the server process is expected to run under.
reviewed by KaiGai Kohei
Bruce Momjian [Sun, 18 Jul 2010 04:47:46 +0000 (04:47 +0000)]
Simplify missing tablespace replay error hint message, but only in HEAD
so we don't need to re-translate for 9.0.
Tom Lane [Fri, 16 Jul 2010 22:25:51 +0000 (22:25 +0000)]
Add a log_file_mode GUC that allows control of the file permissions set on
log files created by the syslogger process.
In passing, make unix_file_permissions display its value in octal, same
as log_file_mode now does.
Martin Pihlak
Heikki Linnakangas [Fri, 16 Jul 2010 11:35:40 +0000 (11:35 +0000)]
Fix typo spotted by Thom Brown.
Heikki Linnakangas [Fri, 16 Jul 2010 11:20:23 +0000 (11:20 +0000)]
Add a paragraph explaining what restartpoints are. Mention that
wal_keep_segments does not take effect during recovery.
Fujii Masao
Tom Lane [Fri, 16 Jul 2010 02:15:56 +0000 (02:15 +0000)]
Add support for dividing money by money (yielding a float8 result) and for
casting between money and numeric.
Andy Balholm, reviewed by Kevin Grittner
Tom Lane [Fri, 16 Jul 2010 00:45:30 +0000 (00:45 +0000)]
Remove a sanity check in the exclusion-constraint code that prevented users
from defining non-self-conflicting constraints.
Jeff Davis
Note: I (tgl) objected to removing this check in 9.0 on the grounds that it
was an important sanity check in new, poorly tested code. However, it should
be all right to remove it for 9.1, since we'll get field testing from the
9.0 branch.
Tom Lane [Fri, 16 Jul 2010 00:13:23 +0000 (00:13 +0000)]
Remove duplicate code in DefineOpFamily().
The code was probably meant to be this way all along, since the subroutine
CreateOpFamily previously had only one caller. But it wasn't.
KaiGai Kohei
Tom Lane [Wed, 14 Jul 2010 22:04:21 +0000 (22:04 +0000)]
Use an <xref> for restore_command reference. Marko Tiikkaja
Tom Lane [Wed, 14 Jul 2010 21:21:08 +0000 (21:21 +0000)]
Fix several problems in pg_dump's handling of SQL/MED objects, notably failure
to dump a PUBLIC user mapping correctly, as per bug #5560 from Shigeru Hanada.
Use the pg_user_mappings view rather than trying to access pg_user_mapping
directly, so that the code doesn't fail when run by a non-superuser. And
clean up some minor carelessness such as unsafe usage of fmtId().
Back-patch to 8.4 where this code was added.
Tom Lane [Wed, 14 Jul 2010 17:09:45 +0000 (17:09 +0000)]
Allow full SSL certificate verification (wherein libpq checks its host name
parameter against server cert's CN field) to succeed in the case where
both host and hostaddr are specified. As with the existing precedents
for Kerberos, GSSAPI, SSPI, it is the calling application's responsibility
that host and hostaddr match up --- we just use the host name as given.
Per bug #5559 from Christopher Head.
In passing, make the error handling and messages for the no-host-name-given
failure more consistent among these four cases, and correct a lie in the
documentation: we don't attempt to reverse-lookup host from hostaddr
if host is missing.
Back-patch to 8.4 where SSL cert verification was introduced.
Tom Lane [Tue, 13 Jul 2010 20:57:19 +0000 (20:57 +0000)]
Teach EXPLAIN to print PARAM_EXEC Params as the referenced expressions,
rather than just $N. This brings the display of nestloop-inner-indexscan
plans back to where it's been, and incidentally improves the display of
SubPlan parameters as well. In passing, simplify the EXPLAIN code by
having it deal primarily in the PlanState tree rather than separately
searching Plan and PlanState trees. This is noticeably cleaner for
subplans, and about a wash elsewhere.
One small difference from previous behavior is that EXPLAIN will no longer
qualify local variable references in inner-indexscan plan nodes, since it
no longer sees such nodes as possibly referencing multiple tables. Vars
referenced through PARAM_EXEC Params are still forcibly qualified, though,
so I don't think the display is any more confusing than before. Adjust a
couple of examples in the documentation to match this behavior.
Bruce Momjian [Tue, 13 Jul 2010 20:03:32 +0000 (20:03 +0000)]
On Win32, pg_upgrade cannot sent any server log output to the log file
because of file access limitations on that platform.
Bruce Momjian [Tue, 13 Jul 2010 18:14:14 +0000 (18:14 +0000)]
Remove incorrect email address for pg_upgrade bug reports.
Bruce Momjian [Tue, 13 Jul 2010 18:09:55 +0000 (18:09 +0000)]
In pg_upgrade, report /bin directory checks independent of /data checks.
Bruce Momjian [Tue, 13 Jul 2010 17:00:50 +0000 (17:00 +0000)]
Print each test_fsync description while test is running, rather than at
the end.
Bruce Momjian [Tue, 13 Jul 2010 15:56:53 +0000 (15:56 +0000)]
In pg_upgrade, prevent psql AUTOCOMMIT=off by not loading .psqlrc.
Heikki Linnakangas [Tue, 13 Jul 2010 09:02:30 +0000 (09:02 +0000)]
Oops, in the previous fix to prevent a cursor that's being used in a FOR
loop from being dropped, I missed subtransaction cleanup. Pinned portals
must be dropped at subtransaction cleanup just as they are at main
transaction cleanup.
Per bug #5556 by Robert Walker. Backpatch to 8.0, 7.4 didn't have
subtransactions.
Bruce Momjian [Mon, 12 Jul 2010 18:30:36 +0000 (18:30 +0000)]
Restore pl/pgsql default install release note item.
Bruce Momjian [Mon, 12 Jul 2010 18:25:21 +0000 (18:25 +0000)]
9.0 release note improvements
Erik Rijkers
Bruce Momjian [Mon, 12 Jul 2010 17:47:39 +0000 (17:47 +0000)]
Spellcheck 9.0 release notes.
Tom Lane [Mon, 12 Jul 2010 17:01:06 +0000 (17:01 +0000)]
Make NestLoop plan nodes pass outer-relation variables into their inner
relation using the general PARAM_EXEC executor parameter mechanism, rather
than the ad-hoc kluge of passing the outer tuple down through ExecReScan.
The previous method was hard to understand and could never be extended to
handle parameters coming from multiple join levels. This patch doesn't
change the set of possible plans nor have any significant performance effect,
but it's necessary infrastructure for future generalization of the concept
of an inner indexscan plan.
ExecReScan's second parameter is now unused, so it's removed.
Bruce Momjian [Mon, 12 Jul 2010 16:21:51 +0000 (16:21 +0000)]
Document bump of minor library version numbers.
Bruce Momjian [Mon, 12 Jul 2010 16:18:44 +0000 (16:18 +0000)]
Bump minor library version numbers, for 9.1 release.
Tom Lane [Sat, 10 Jul 2010 18:37:00 +0000 (18:37 +0000)]
Add a note about preferred window width to the section about code
formatting conventions.