OSDN Git Service
Chris Manton [Sat, 24 Oct 2020 21:43:31 +0000 (14:43 -0700)]
Only send ReadRemoteVersionRequest in legacy mode
gd acl can only accept an event for either classic
or le, but not both.
Bug:
166280067
Tag: #refactor
Test: act.py -tc BleCocTest
Change-Id: I719f09a380e7b75da7c40ffc136038ccaea90812
Chris Manton [Sat, 24 Oct 2020 21:22:03 +0000 (14:22 -0700)]
Revert "Should not send classic commands on le link"
This reverts commit
25b8b04caa3c2c4b218f8d56f5f72e7ca1e24f8c.
Turns out this is a command that may be run on both le and br_edr links
Bug:
166280067
Tag: #refactor
Test: act.py -tc BleCocTest
Change-Id: Ieb3de7c6046f18b30805b7486441039b591f929b
Hansong Zhang [Fri, 23 Oct 2020 23:27:18 +0000 (16:27 -0700)]
GD ACL: on_read_remote_supported_features_complete
Use OnReadRemoteExtendedFeaturesComplete callback to send it to L2cap
Tag: #gd-refactor
Bug:
141555841
Test: cert/run --host
Change-Id: I04398f308028c1419072e87a6990aab6f6be1795
Baligh Uddin [Sat, 24 Oct 2020 01:40:47 +0000 (01:40 +0000)]
Merge "Cleanup references to system/core/base -> system/libbase"
Hansong Zhang [Fri, 23 Oct 2020 19:31:12 +0000 (12:31 -0700)]
Clean up log spam in avrcp and a2dp
Now we don't see bugs in avrcp and a2dp sbc encoder often, move them to
verbose logging.
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I8475b6914edb5c06927d8578d2d035c49a41efdc
Treehugger Robot [Fri, 23 Oct 2020 18:55:21 +0000 (18:55 +0000)]
Merge changes Ic1411faf,I0ef22f28,I645b787d,Ief031db6,I5c494deb, ...
* changes:
Remove unused def SMP_DEBUG
Remove name from BTM_SecAddBleDevice
Re-log stack/l2cap/l2c_ble::
enum-ify link stack/acl/btm_acl::policy settings
Streamline main/shim/acl::_reason
Streamline stack/btm/btm_ble_addr::btm_ble_addr_resolvable
Streamline stack/btm/btm_ble_gap::btm_ble_update_adv_flag
Streamline stack/btm/btm_ble_addr::btm_ble_resolve_random_addr
enum-ify stack/btm/btm_ble_gap::BTM_BLE_
Add main/shim/acl_legacy_interface::auth_complete
Chris Manton [Sun, 11 Oct 2020 21:36:53 +0000 (14:36 -0700)]
Remove unused def SMP_DEBUG
Toward readable code
Bug:
163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ic1411faf31fd6c4dc66282bfe42a0ec47c969bb1
Chris Manton [Fri, 23 Oct 2020 02:47:49 +0000 (19:47 -0700)]
Remove name from BTM_SecAddBleDevice
bd_name is always nullptr
Toward readable code
Bug:
163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I0ef22f288425dad0cc08d4e43acc12e5dd51d6dd
Chris Manton [Thu, 8 Oct 2020 21:25:38 +0000 (14:25 -0700)]
Re-log stack/l2cap/l2c_ble::
Please "don\'t" use apostrophes
Towards grepable code
Bug:
163134718
Tag: #refactor
Test: ble paired 2 phones
Test: act.py -tc BleCocTest
Change-Id: I645b787dffa54d1f1829fca1212a4fa811e1f51e
Chris Manton [Sun, 11 Oct 2020 03:55:47 +0000 (20:55 -0700)]
enum-ify link stack/acl/btm_acl::policy settings
And also move to only use location
And restrict from header into compilation unit
Toward readable code
Bug:
163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ief031db624bf1363ee3ec4043efafcfdc4be1b59
Chris Manton [Tue, 20 Oct 2020 15:06:13 +0000 (08:06 -0700)]
Streamline main/shim/acl::_reason
Bug:
166280067
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I5c494deb85fbb3101602078dcaeefc98ac695754
Chris Manton [Tue, 13 Oct 2020 20:58:56 +0000 (13:58 -0700)]
Streamline stack/btm/btm_ble_addr::btm_ble_addr_resolvable
Toward readable code
Bug:
163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I6600ac7d3fdc1a9ff099b0ffa8c9b1826c6db456
Chris Manton [Tue, 13 Oct 2020 21:19:35 +0000 (14:19 -0700)]
Streamline stack/btm/btm_ble_gap::btm_ble_update_adv_flag
Toward readable code
Bug:
163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I241cf791f672d0003419c7e8e26b4baf2089d681
Chris Manton [Tue, 13 Oct 2020 20:34:43 +0000 (13:34 -0700)]
Streamline stack/btm/btm_ble_addr::btm_ble_resolve_random_addr
Toward readable code
Bug:
163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ifc5c988e6a5dd8540c5465639022a355ee9efcbf
Chris Manton [Tue, 13 Oct 2020 21:19:08 +0000 (14:19 -0700)]
enum-ify stack/btm/btm_ble_gap::BTM_BLE_
Toward readable code
Bug:
163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Icb54b5f68c11bcb0a28b1cf25abcaf68c734d6ca
Chris Manton [Fri, 16 Oct 2020 01:16:57 +0000 (18:16 -0700)]
Add main/shim/acl_legacy_interface::auth_complete
Bug:
166280067
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I2ad8753860ec78441a22c7f3e071beb11b9773c6
Baligh Uddin [Fri, 23 Oct 2020 14:33:47 +0000 (14:33 +0000)]
Cleanup references to system/core/base -> system/libbase
BUG:
157656545
Test: TH
Change-Id: I6b04e7340d58215ccf183e4b086023281e0a9951
Jakub Pawlowski [Fri, 23 Oct 2020 11:14:14 +0000 (11:14 +0000)]
Revert "BTM_ACL: Remove unused code"
This reverts commit
85a4ce1ebd16bb20e87edac88ba0cbd71fa92d46.
Reason for revert: This is needed for LE Audio
Change-Id: Iaed065aef5f40e066d08004699c07dea2f48c94a
Treehugger Robot [Fri, 23 Oct 2020 07:04:14 +0000 (07:04 +0000)]
Merge changes from topic "gd_security_shim"
* changes:
GD Security: pipe in determined just_works flag
GD Security Shim: Make ConfirmationData have strict types
Hansong Zhang [Thu, 22 Oct 2020 20:17:35 +0000 (13:17 -0700)]
Refactor btm_remove_acl
Use ACL handle instead.
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I4447134f80f39e4afaf051e49c10a55ea68f9f5b
Hansong Zhang [Thu, 22 Oct 2020 22:45:50 +0000 (15:45 -0700)]
BTM_BLE_GAP: Clean up log spam
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I35bca19f53ca865697f810524bb911c8668e08f5
Chris Manton [Thu, 22 Oct 2020 17:35:56 +0000 (10:35 -0700)]
Use stack/acl/btm_acl::acl_process_extended_features
Bug:
166280067
Tag: #refactor
Test: Pair classic device
Change-Id: I1a87ea23c8b4590a313652dca78b0e51354ecb33
Chris Manton [Thu, 22 Oct 2020 17:35:39 +0000 (10:35 -0700)]
Add stack/acl/btm_acl::acl_process_extended_features
Bug:
166280067
Tag: #refactor
Test: Pair classic device
Change-Id: I1136fae14a3673f6dc76b8d3d08414525690f8b3
Chris Manton [Thu, 22 Oct 2020 17:32:05 +0000 (10:32 -0700)]
Add main/shim/acl_legacy_interface::btm_acl_role_changed
Bug:
166280067
Tag: #refactor
Test: Pair classic device
Change-Id: Ie4f2c31ed449a5bf9353efb3ab640cbbbfab211f
Chris Manton [Thu, 22 Oct 2020 19:55:44 +0000 (12:55 -0700)]
Add tHCI_STATUS to btm_acl_role_changed
Bug:
166280067
Tag: #refactor
Test: Pair classic device
Change-Id: I5ba4b72585e9cd9e0e0e45935f6e4a328fc28581
Chris Manton [Tue, 20 Oct 2020 23:57:27 +0000 (16:57 -0700)]
Should not send classic commands on le link
Bug:
171491610
Tag: #refactor
Test: verified on wireshark
Change-Id: I1428ea803a6dd327a81209a4f710d96a8d6612be
Chris Manton [Thu, 22 Oct 2020 17:47:09 +0000 (10:47 -0700)]
Return after gd acl creates connection
Bug:
166280067
Tag: #refactor
Test: Pair classic device
Change-Id: Ie18dc8ba759b6fd20b7cd041a86c86b94c7e9e1f
Hansong Zhang [Mon, 19 Oct 2020 22:47:35 +0000 (15:47 -0700)]
L2cap API: Use GD L2cap flag
Bug:
141555841
Test: cert/run --host
Tag: #gd-refactor
Change-Id: I2c6a67e3f74616d7bd2845049af4273088648de4
Hansong Zhang [Thu, 22 Oct 2020 06:16:52 +0000 (23:16 -0700)]
BTM_ACL: Remove unused code
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I1ddd384d8527313ac447c3d2b794a24f461117e9
Hansong Zhang [Wed, 21 Oct 2020 23:18:52 +0000 (16:18 -0700)]
btm_acl_encrypt_change: Use handle directly
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I7cc183ca8094315e00e3e924a77f0fec8d47c941
Hansong Zhang [Wed, 21 Oct 2020 22:03:32 +0000 (15:03 -0700)]
Flatten btm_sec_start_encryption
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ie0c0709ef3f625657704cc41f40377a60d8c3523
Treehugger Robot [Wed, 21 Oct 2020 23:27:25 +0000 (23:27 +0000)]
Merge changes Ie1b2f0f6,I5f115595,I7c766087,If341f69a,Idba0190c, ...
* changes:
Use acl_create_le_connection_with_id
Add acl_create_le_connection_with_id
Plumb through acl_create|cancel_le_connection
Add bd_features_text
Remove def stack/hcic/hcicmds::BT_10A
Proper interface around disconnect_reason
Use tHCI_STATUS in btm_sec_disconnect
Allow gd acl to take DISCONNECT when enabled
Connect main/shim/acl_legacy_interface::acl_ble_enhanced_connection_complete_from_shim
Add stack/acl/btm_acl::btm_acl_disconnected
Hansong Zhang [Wed, 21 Oct 2020 01:48:52 +0000 (18:48 -0700)]
Refactor btm_sec_set_peer_sec_caps
No need to pass acl_cb
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I7cb1bae627c731106ab3a93442acb8f6bb2018fa
Chris Manton [Tue, 20 Oct 2020 21:42:47 +0000 (14:42 -0700)]
Use acl_create_le_connection_with_id
Bug:
166280067
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: Ie1b2f0f60367ad15834b28ee896989674c6f3614
Chris Manton [Tue, 20 Oct 2020 21:42:21 +0000 (14:42 -0700)]
Add acl_create_le_connection_with_id
Bug:
166280067
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: I5f1155951394c3fc073a2b5ef2f57f9e2db2cab4
Chris Manton [Tue, 20 Oct 2020 19:33:54 +0000 (12:33 -0700)]
Plumb through acl_create|cancel_le_connection
Bug:
166280067
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: I7c766087716777c274866bff20c197ea41fc80f8
Chris Manton [Sat, 17 Oct 2020 23:11:11 +0000 (16:11 -0700)]
Add bd_features_text
Bug:
163134718
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: If341f69a65b484d88275d95a60cfd15ab64ede5e
Chris Manton [Sun, 11 Oct 2020 15:53:41 +0000 (08:53 -0700)]
Remove def stack/hcic/hcicmds::BT_10A
Always false; untested when true
Bug:
163134718
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: Idba0190c8f5f8bb2eab6c93d4f4e9687fc58874b
Chris Manton [Sat, 10 Oct 2020 23:37:11 +0000 (16:37 -0700)]
Proper interface around disconnect_reason
Bug:
163134718
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: I10d4bc9ae642c16cf5622adf541db999f442a48f
Chris Manton [Thu, 15 Oct 2020 21:22:32 +0000 (14:22 -0700)]
Use tHCI_STATUS in btm_sec_disconnect
Bug:
163134718
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: Idc93062d96aa45c0e4ed385a3fa09e6cbdabf915
Chris Manton [Tue, 20 Oct 2020 16:40:18 +0000 (09:40 -0700)]
Allow gd acl to take DISCONNECT when enabled
Bug:
166280067
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: Ib460b3c9c63572753d51aaf1c49f56024b6d4bfb
Chris Manton [Tue, 20 Oct 2020 16:36:07 +0000 (09:36 -0700)]
Connect main/shim/acl_legacy_interface::acl_ble_enhanced_connection_complete_from_shim
Bug:
166280067
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: I26ae8837788425a74d7202a40b3e7fc7b2c7a279
Chris Manton [Fri, 16 Oct 2020 15:54:53 +0000 (08:54 -0700)]
Add stack/acl/btm_acl::btm_acl_disconnected
Also connect to shim acl
Bug:
166280067
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: I8a3d7ef1f44b637a053e85a98765a3db5498e590
Chris Manton [Sat, 17 Oct 2020 22:54:42 +0000 (15:54 -0700)]
Remove unused def BTM_MAX_PRE_SM4_LKEY_TYPE
Towards readable code
Bug:
163134718
Tag: #refactor
Test: Compiled and passed basic functionality
Change-Id: Icba095ec66c4d9b65cec5269729defa0e25c3760
Martin Brabham [Wed, 7 Oct 2020 21:53:38 +0000 (14:53 -0700)]
GD Security: pipe in determined just_works flag
Bug:
162984360
Tag: #gd-refactor
Test: cert/run --host SecurityTest
Test: atest --host bluetooth_test_gd
Change-Id: I480898445bf65f8034a1519cc3fba4572e613c56
Martin Brabham [Wed, 21 Oct 2020 07:41:42 +0000 (00:41 -0700)]
GD Security Shim: Make ConfirmationData have strict types
Bug:
162984360
Tag: #gd-refactor
Test: cert/run --host SecurityTest
Test: atest --host bluetooth_test_gd
Test: atest --host bluetooth_test_common
Change-Id: I6684d53b7fe154d80d0869333f1d6d19459d1090
Chris Manton [Wed, 7 Oct 2020 15:44:35 +0000 (08:44 -0700)]
Use stack/l2cap/l2c_link::l2c_packets_completed
Bug:
166280067
Tag: #refactor
Test: atest --host bluetooth_test_gd
Change-Id: I52ed1f0130500c516933b30ac28b029443ee53f4
Chris Manton [Mon, 19 Oct 2020 23:57:27 +0000 (16:57 -0700)]
Re-log entry into stack/gatt/gatt_api::GATT_
Towards readable code
Bug:
163134718
Tag: #refactor
Test: Compiled and passed basic functionality
Change-Id: I79e887df6f1ff67eab94d6eefb8b63f88273a77a
Chris Manton [Mon, 19 Oct 2020 21:19:15 +0000 (14:19 -0700)]
Re-log stack/gap/gap_ble::client_connect_cback
Towards readable code
Bug:
163134718
Tag: #refactor
Test: Compiled and passed basic functionality
Change-Id: Ic1093dbfe77fd980fb8045bc0e16599a9978192c
Chris Manton [Wed, 7 Oct 2020 15:43:12 +0000 (08:43 -0700)]
Add stack/l2cap/l2c_link::l2c_packets_completed
Towards readable code
Bug:
163134718
Tag: #refactor
Test: Compiled and passed basic functionality
Change-Id: I956eb147794fee1f1c04c08853587891bfdf205b
Chris Manton [Mon, 19 Oct 2020 20:57:43 +0000 (13:57 -0700)]
Add stack/acl/ble_acl::acl_ble_enhanced_connection_complete_from_shim
Bug:
166280067
Tag: #refactor
Test: atest --host bluetooth_test_gd
Change-Id: I6b112841a85ad394223e98cc32f2661029a39f75
Chris Manton [Sat, 17 Oct 2020 22:46:00 +0000 (15:46 -0700)]
Remove never set #def BTIF_MIXED_MODE_INCLUDED
Towards readable code
Bug:
163134718
Tag: #refactor
Test: Compiled and passed basic functionality
Change-Id: I37a71035318f104274768f9ce3c5746527f80d80
Chris Manton [Mon, 19 Oct 2020 21:28:02 +0000 (14:28 -0700)]
gd: Third entry gd acl shim
Bug:
166280067
Tag: #refactor
Test: atest --host bluetooth_test_gd
Change-Id: I1f6ab0511dae9c020a14b2754b0c862498784f19
Hansong Zhang [Tue, 20 Oct 2020 22:39:30 +0000 (15:39 -0700)]
BTM_SEC minor clean up
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I4d5743de037d1f5f84802050d630bc8bd23b6d8d
Treehugger Robot [Tue, 20 Oct 2020 22:45:37 +0000 (22:45 +0000)]
Merge "Add shim role helper main/shim/helpers::ToLegacyRole"
Hansong Zhang [Mon, 19 Oct 2020 22:22:03 +0000 (15:22 -0700)]
Introduce GD L2cap init flag
Bug:
141555841
Test: cert/run --host
Tag: #gd-refactor
Change-Id: Ida422ee0738e206f45004f76e60e7f8c6b7d5acc
Chris Manton [Thu, 15 Oct 2020 15:50:39 +0000 (08:50 -0700)]
Add shim role helper main/shim/helpers::ToLegacyRole
Bug:
166280067
Tag: #refactor
Test: atest --host bluetooth_test_gd
Change-Id: Id8ba2b00ea738ca7a7b4dfc3f028c53bc305c421
Treehugger Robot [Tue, 20 Oct 2020 19:41:33 +0000 (19:41 +0000)]
Merge "Assert in default case"
Treehugger Robot [Tue, 20 Oct 2020 19:40:45 +0000 (19:40 +0000)]
Merge "GD Security: InternalEnforceSecurityPolicy"
Chris Manton [Mon, 19 Oct 2020 21:37:50 +0000 (14:37 -0700)]
gd: Plumb through ReadRemoteExtendedFeatures
Also plumb through ReadRemoteVersionInformation
Bug:
166280067
Tag: #refactor
Test: atest --host bluetooth_test_gd
Change-Id: Ida0265aec9f7a7e532097bbe0c550c36ba2e071e
Martin Brabham [Tue, 13 Oct 2020 23:42:07 +0000 (16:42 -0700)]
Inclusive Language Updates
slave -> peripheral
SLAVE -> PERIPHERAL
Slave -> Peripheral
BYPASS_INCLUSIVE_LANGUAGE_REASON=required_to_explain_the_update
Bug:
170342881
Tag: #refactor
Test: cert/run --host
Test: atest --host bluetooth_test_common
Test: atest --host bluetooth_test_gd
Test: atest net_test_btif
Change-Id: I4a3cccc0c1d182f172a21a6c70d569e5a89a5916
Merged-In: I4a3cccc0c1d182f172a21a6c70d569e5a89a5916
Łukasz Rymanowski [Fri, 8 May 2020 23:26:11 +0000 (01:26 +0200)]
stack/eatt: Add initial implementation for EATT
Tag: #feature
Bug:
159786353
Sponsor: jpawlowski@
Test: atest --host net_test_eatt
Change-Id: I934153625e69b1e20af657ded8f17238484cb65e
Treehugger Robot [Tue, 20 Oct 2020 12:12:41 +0000 (12:12 +0000)]
Merge "Refactor advertising callback mechanism for GD"
Treehugger Robot [Tue, 20 Oct 2020 05:58:48 +0000 (05:58 +0000)]
Merge "Revert "gd: Plumb through ReadRemoteExtendedFeatures""
Hansong Zhang [Mon, 19 Oct 2020 22:26:50 +0000 (15:26 -0700)]
L2cap link: Fix a potential nullptr exception
Bug:
141555841
Test: cert/run --host
Tag: #gd-refactor
Change-Id: I1550b750438364fa54d961d529e642c2beddb963
Chris Manton [Tue, 20 Oct 2020 02:51:42 +0000 (02:51 +0000)]
Revert "gd: Plumb through ReadRemoteExtendedFeatures"
This reverts commit
2956f2790709a159f7806b1b514aef2fe539a3e9.
Reason for revert: Broken Build
Change-Id: Ife01bd468d885bac8d270f280d3e5eb2ee0f29e1
Martin Brabham [Thu, 8 Oct 2020 21:11:57 +0000 (14:11 -0700)]
Assert in default case
Bug:
162984360
Tag: #gd-refactor
Test: cert/run --host SecurityTest:test_dut_initiated_no_input_no_output_no_input_no_output_twice_bond_and_enforce
Test: atest --host bluetooth_test_gd
Change-Id: Id41c0be842663b342b2c89fabbbdd702174ba6d1
Chris Manton [Mon, 19 Oct 2020 21:37:50 +0000 (14:37 -0700)]
gd: Plumb through ReadRemoteExtendedFeatures
Also plumb through ReadRemoteVersionInformation
Bug:
166280067
Tag: #refactor
Test: atest --host bluetooth_test_gd
Change-Id: If08f26cd1cbb6724689cc6b09268cf959285bb58
Martin Brabham [Mon, 5 Oct 2020 19:29:07 +0000 (12:29 -0700)]
GD Security: InternalEnforceSecurityPolicy
Currently, the logic is a little confusing, this CL should simplify it.
Bug:
162984360
Tag: #gd-refactor
Test: cert/run --host SecurityTest:test_dut_initiated_no_input_no_output_no_input_no_output_twice_bond_and_enforce
Test: atest --host bluetooth_test_gd
Change-Id: I19753a29487c4bf2c3b40189c0576526d39657c8
Treehugger Robot [Mon, 19 Oct 2020 23:20:09 +0000 (23:20 +0000)]
Merge "Merge redfin/bramble support."
Xin Li [Mon, 19 Oct 2020 17:08:28 +0000 (10:08 -0700)]
Merge redfin/bramble support.
Bug:
171218636
Merged-In: I32df229c5561a1cae7be722865c378145de5a23a
Change-Id: Ie7ae2703a3ef41871147d42653809a5274a5c499
Chris Manton [Wed, 14 Oct 2020 15:40:38 +0000 (08:40 -0700)]
gd: Second entry acl shim
Bug:
166280067
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: If2df6e773e6625f927426fc0bfa32ff33172cea7
Chris Manton [Wed, 14 Oct 2020 15:43:51 +0000 (08:43 -0700)]
Add main/shim/helpers::MakeLegacyBtHdrPacket
Bug:
166280067
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: Idc3083dbd8639b416880dbb8b07667a9356e82ed
Chris Manton [Wed, 14 Oct 2020 15:32:33 +0000 (08:32 -0700)]
Use tHCI_STATUS throughout shim interface
Bug:
166280067
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: Ia6b600dbe0a8dbf99b1e97d6776a5dfe7f48248f
Łukasz Rymanowski [Mon, 19 Oct 2020 15:28:04 +0000 (15:28 +0000)]
l2c: Add missing event string am:
bc44ab6afd
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1458305
Change-Id: I32df229c5561a1cae7be722865c378145de5a23a
Łukasz Rymanowski [Mon, 19 Oct 2020 15:27:27 +0000 (15:27 +0000)]
l2c: Fix CoC default response am:
73cd2329c9
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1458304
Change-Id: I59b44bac4cab9ea770cf81799937967770f3e723
Łukasz Rymanowski [Mon, 19 Oct 2020 15:26:46 +0000 (15:26 +0000)]
l2c: Change std::vector to uint16[] in the tL2C_LCB am:
dc4a812fd6
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1458303
Change-Id: I4d6486a96dbe0d26478ef3f6d4ed2dc5c37fc27b
Łukasz Rymanowski [Tue, 13 Oct 2020 14:38:04 +0000 (14:38 +0000)]
l2c: Add missing event string
Tag: #feature
Bug:
159786353
Sponsor: jpawlowski@
Test: compile & manual
Change-Id: Icd9658ca7402a1a43ca0743ded6929833cd8957d
Łukasz Rymanowski [Tue, 13 Oct 2020 14:29:13 +0000 (14:29 +0000)]
l2c: Fix CoC default response
Looks like patch:
203c71a9020 Restore LE CoC l2cap conn rsp
was merged in similar time that:
4456dc7c91e stack/l2c: Add support for credit based connection oriented channels
However those two have a conflict.
This patch fixes that.
Tag: #feature
Bug:
159786353
Sponsor: jpawlowski@
Test: compile & manual
Change-Id: Ie252d15bdad9d20d9006908aa34e8b566583e4be
Łukasz Rymanowski [Tue, 13 Oct 2020 09:34:56 +0000 (09:34 +0000)]
l2c: Change std::vector to uint16[] in the tL2C_LCB
Since there are places where memset is done on tL2C_LCB
we can't keep std::vector in this struct
Tag: #feature
Bug:
159786353
Sponsor: jpawlowski@
Test: compile & manual
Change-Id: I2a9795e3c7dbe280b17725eac6333744440e89df
Treehugger Robot [Mon, 19 Oct 2020 09:29:19 +0000 (09:29 +0000)]
Merge "GD-Controller: Do not register NumberOfCompletedPacket without ACL layer" am:
456105020f
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1464710
Change-Id: Iafb4d9fd99ba850d9d0bbcf58f45c9a697f845e5
Treehugger Robot [Mon, 19 Oct 2020 09:12:39 +0000 (09:12 +0000)]
Merge "GD-Controller: Do not register NumberOfCompletedPacket without ACL layer"
Chienyuan [Fri, 25 Sep 2020 10:02:31 +0000 (18:02 +0800)]
Refactor advertising callback mechanism for GD
Tag: #refactor
Bug:
169390539
Test: all sl4a tests for BLE advertising
Change-Id: If16058fa2ca07d27bf3a340b0aaff51e0f7ec232
Chris Manton [Sun, 18 Oct 2020 09:15:29 +0000 (09:15 +0000)]
enum-ify stack/include/btm_api_types::BTM_SEC_ am:
600515c780
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1459356
Change-Id: I5134b107c090df8d675b431444756b845dec9811
Chris Manton [Sun, 4 Oct 2020 23:11:58 +0000 (16:11 -0700)]
enum-ify stack/include/btm_api_types::BTM_SEC_
Towards readable code
Bug:
163134718
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: I6b7d23ffdd22b4d9e98f214f2fee650ea35d765d
Chris Manton [Sat, 17 Oct 2020 23:58:27 +0000 (23:58 +0000)]
Add main/shim/helpers::debug::DumpBtHdr am:
81e50d6cf0
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1460809
Change-Id: I2e59386a1048a6467e202aa510e2527cf04cfe0a
Chris Manton [Wed, 14 Oct 2020 15:44:19 +0000 (08:44 -0700)]
Add main/shim/helpers::debug::DumpBtHdr
Bug:
166280067
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: I8593550041440c23f1b8eddef4e51a962e317768
Chris Manton [Sat, 17 Oct 2020 03:02:40 +0000 (03:02 +0000)]
Add main/shim/acl_legacy_interface::on_packets_completed am:
4ebd9b7464
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1460806
Change-Id: I8dd5a38a744cc6b97d986e52b2aa71bf486556cb
Chris Manton [Sat, 17 Oct 2020 00:10:10 +0000 (00:10 +0000)]
enum-ify stack/btm/security_device_record::BTM_SEC_STATE_ am:
3f86f5a247
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1459357
Change-Id: I82f5b25669008d0ab3695fd4f10be6107eecdfe2
Jack He [Fri, 16 Oct 2020 22:22:22 +0000 (15:22 -0700)]
GD-Controller: Do not register NumberOfCompletedPacket without ACL layer
* Only register it when ACL layer is enabled
* Also hci layer event is only registered by HCI lyaer when HCI layer
is enabled
Test: make, pair and connect Bluetooth devices
Bug:
170603745
Tag: #gd-refactor
Change-Id: Icc94d239c28ba58ceffebee1061b4f8042afecc5
Chris Manton [Wed, 14 Oct 2020 14:57:40 +0000 (07:57 -0700)]
Add main/shim/acl_legacy_interface::on_packets_completed
Bug:
166280067
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: Ib26e66fbc3ec1e441bb6ffbf368f77e6fa60699f
Chris Manton [Mon, 5 Oct 2020 00:11:13 +0000 (17:11 -0700)]
enum-ify stack/btm/security_device_record::BTM_SEC_STATE_
Towards readable code
Bug:
163134718
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: I2b44dfca2d36c815d65c786ca7371cc24788bcca
Chris Manton [Fri, 16 Oct 2020 18:40:26 +0000 (18:40 +0000)]
Take EventCode::DISCONNECTION_COMPLETE if acl shim is enabled am:
255faddb20
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1460805
Change-Id: Ic1dc1372d9e381258f3e02505b3973f7109ec054
Chris Manton [Fri, 16 Oct 2020 18:40:22 +0000 (18:40 +0000)]
Use proper undefined hci error status code am:
2f5249a191
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1460804
Change-Id: Iec65a03c54460bca886cf320a790f88356453daa
Chris Manton [Fri, 16 Oct 2020 18:40:18 +0000 (18:40 +0000)]
Include hci_error_code in acl_hci/ble_acl interfaces am:
7768eb542a
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1460803
Change-Id: I9cc14761f4ebe0bdf500cf1e1e621436b43dd35c
Chris Manton [Fri, 16 Oct 2020 18:40:13 +0000 (18:40 +0000)]
enum-ify stack/include/::hci_error_code am:
69d5cb2ceb
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1460802
Change-Id: Ie9e2daca132ddaee8fb074e4f5f97d92b768ca7a
Chris Manton [Fri, 16 Oct 2020 18:39:33 +0000 (18:39 +0000)]
Streamline stack/btm/btm_ble_gap::BTM_BleSetScanParams am:
335c1a91fb
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1459360
Change-Id: Ie5eb78bc88b0823037a8213acdfee49a0a74d987
Chris Manton [Wed, 14 Oct 2020 06:29:35 +0000 (23:29 -0700)]
Take EventCode::DISCONNECTION_COMPLETE if acl shim is enabled
Bug:
166280067
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: Iada55f394e79c197bbb3534c8376a32a040989e5
Chris Manton [Wed, 14 Oct 2020 16:13:00 +0000 (09:13 -0700)]
Use proper undefined hci error status code
Bug:
163134718
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: I2a95b74e8a8a3b31ec63e2ef64070ab4c2d374f1
Chris Manton [Wed, 14 Oct 2020 16:44:27 +0000 (09:44 -0700)]
Include hci_error_code in acl_hci/ble_acl interfaces
Bug:
163134718
Tag: #refactor
Test: act.py -tc BleCocTest
Test: ble paired 2 phones
Test: classic paired Bose SoundLink
Change-Id: Ic06d5fbfcbba0a5bb1cb4f7f64354942959af46c
OSDN Git Service
