OSDN Git Service
Rashika Kheria [Sun, 10 Nov 2013 13:32:54 +0000 (19:02 +0530)]
Staging: tidspbridge: Fix foo * bar should be foo *bar in dspapi.c
This patch fixes the following checkpatch.pl warning in pmgr/dspapi.c-
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sun, 10 Nov 2013 13:32:24 +0000 (19:02 +0530)]
Staging: tidspbridge: Prefer dev_info() then printk() in dmm.c
This patch fixes the following checkpatch.pl warning in pmgr/dmm.c-
WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sun, 10 Nov 2013 13:31:26 +0000 (19:01 +0530)]
Staging: tidspbridge: Remove unnecessary white space before a quoted newline in dmm.c
This patch fixes the following checkpatch.pl warning in pmgr/dmm.c-
WARNING: unnecessary whitespace before a quoted newline
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sun, 10 Nov 2013 13:30:54 +0000 (19:00 +0530)]
Staging: tidspbridge: Fix quoted string split across line in dmm.c
This patch fixes the following checkpatch.pl warning in pmgr/dmm.c-
WARNING: quoted string split across lines
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sun, 10 Nov 2013 13:30:22 +0000 (19:00 +0530)]
Staging: tidspbridge: Fix no space at the start of the line in dev.c
This patch fixes the following checkpatch.pl warning in pmgr/dev.c-
WARNING: please, no spaces at the start of a line
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sun, 10 Nov 2013 13:29:51 +0000 (18:59 +0530)]
Staging: tidspbridge: Fix foo * bar should be foo *bar in dev.c
This patch fixes the following checkpatch.pl warning in pmgr/dev.c-
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sun, 10 Nov 2013 13:29:17 +0000 (18:59 +0530)]
Staging: tidspbridge: Fix no space at the start of the line in dbll.c
This patch fixes the following checkpatch.pl warning in pmgr/dbll.c-
WARNING: please, no space at the start of the line
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sun, 10 Nov 2013 13:28:44 +0000 (18:58 +0530)]
Staging: tidspbridge: Fix no space before tabs in dbll.c
This patch fixes the following checkpatch.pl warning in pmgr/dbll.c-
WARNING: please, no space before tabs
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sun, 10 Nov 2013 13:28:09 +0000 (18:58 +0530)]
Staging: tidspbridge: Fix quoted string split across line in dbll.c
This patch fixes the following checkpatch.pl warning in pmgr/dbll.c-
WARNING: quoted string split across lines
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sun, 10 Nov 2013 13:27:21 +0000 (18:57 +0530)]
Staging: tidspbridge: Fix quoted string split across lines in cmm.c
This patch fixes the following checkpatch.pl warning in pmgr/cmm.c-
WARNING: quoted string split across lines
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sun, 10 Nov 2013 13:26:40 +0000 (18:56 +0530)]
Staging: tidspbridge: Fix foo ** bar should be foo **bar in cmm.c
This patch fixes the following checkpatch.pl warning in pmgr/cmm.c-
ERROR: "foo ** bar" should be "foo **bar"
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Archana kumari [Sun, 10 Nov 2013 18:34:04 +0000 (00:04 +0530)]
staging: rtl8192e: Fixed space prohibited warning in dot11d.c
This patch fixes space prohibited before semicolon warning in dot11d.c
Signed-off-by: Archana kumari <archanakumari959@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Sat, 9 Nov 2013 21:34:54 +0000 (03:04 +0530)]
staging:rtl8192e: Rewrite macro definition as static inline function.
This patch removes the checkpatch.pl error Macros "with complex values
should be enclosed in parenthesis" in dot11d.h by rewriting it as a
static inline function.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Teodora Baluta [Thu, 7 Nov 2013 22:13:47 +0000 (00:13 +0200)]
staging: rtl8188eu: remove unneeded semicolon
This patch fixes the following issues detected by coccinelle:
drivers/staging/rtl8188eu/core/rtw_xmit.c:688:75-76: Unneeded semicolon
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c:2307:64-65: Unneeded semicolon
drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c:89:66-67: Unneeded semicolon
Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Teodora Baluta [Thu, 7 Nov 2013 22:13:46 +0000 (00:13 +0200)]
staging: rtl8188eu: correct code alignment
This patch fixes incorrect code alignment due to mixed indenting with
spaces and tabs. This patch was detected using coccinelle and
silences the following warnings:
drivers/staging/rtl8188eu/core/rtw_io.c:297:2-29: code aligned with following code on line 299
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4420:2-29: code aligned with following code on line 4422
drivers/staging/rtl8188eu/os_dep/osdep_service.c:54:2-17: code aligned with following code on line 55
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:7229:2-17: code aligned with following code on line 7231
Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Thu, 7 Nov 2013 13:46:36 +0000 (19:16 +0530)]
Staging: rtl8192e: Fix Sparse warning of cast to restricted __le32 in rtl_core.c
This patch fixes the following sparse warnings in rtl8192e/rtl_core.c-
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1846:46: warning: cast to restricted __le32
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1951:46: warning: cast to restricted __le32
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:2199:50: warning: cast to restricted __le32
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Thu, 7 Nov 2013 13:45:48 +0000 (19:15 +0530)]
Staging: rtl8192e: Fix incorrect type in assignment in rtl_core.c
This patch fixes the following sparse warning in rtl8192e/rtl_core.c-
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:565:10: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:565:10: expected restricted __le16
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:565:10: got int
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:565:13: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:565:13: expected restricted __le16
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:565:13: got int
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:565:16: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:565:16: expected restricted __le16
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:565:16: got int
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:565:19: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:565:19: expected restricted __le16
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:565:19: got int
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:566:10: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:566:10: expected restricted __le16
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:566:10: got int
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:566:13: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:566:13: expected restricted __le16
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:566:13: got int
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:566:16: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:566:16: expected restricted __le16
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:566:16: got int
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:566:19: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:566:19: expected restricted __le16
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:566:19: got int
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:2012:12: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:2012:12: expected unsigned short [unsigned] [usertype] fc
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:2012:12: got restricted __le16 [usertype] frame_ctl
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:2102:46: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:2102:46: expected unsigned int [unsigned] [usertype] BufferAddress
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:2102:46: got restricted __le32 [usertype] <noident>
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:2137:41: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:2137:41: expected unsigned int [unsigned] [usertype] NextDescAddress
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:2137:41: got restricted __le32 [usertype] <noident>
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:2401:38: warning: incorrect type in assignment rtllib_softmac.c(different base types)
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:2401:38: expected unsigned int [unsigned] [usertype] BufferAddress
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:2401:38: got restricted __le32 [usertype] <noident>
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Thu, 7 Nov 2013 13:44:56 +0000 (19:14 +0530)]
Staging: rtl8192e: Fix Sparse Warning for Static Declarations in rtl_core.c
This patch fixes the following sparse warning in rtl8192e/rtl_core.c-
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:58:5: warning: symbol 'hwwep' was not declared. Should it be static?
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:588:5: warning: symbol 'WDCAPARA_ADD' was not declared. Should it be static?
drivers/staging/rtl8192e/rtl8192e/rtl_core.c:2695:13: warning: symbol 'rtl8192_interrupt' was not declared. Should it be static?
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Thu, 7 Nov 2013 13:43:49 +0000 (19:13 +0530)]
Staging: rtl8192e: Fix incorrect type in assignment in r8192E_dev.c
This patch fixes the following sparse warning in rtl8192e/r8192E_dev.c-
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:1275:27: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:1275:27: expected unsigned int [unsigned] [usertype] TxBuffAddr
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:1275:27: got restricted __le32 [usertype] <noident>
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:1305:27: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:1305:27: expected unsigned int [unsigned] [usertype] TxBuffAddr
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:1305:27: got restricted __le32 [usertype] <noident>
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Thu, 7 Nov 2013 13:42:28 +0000 (19:12 +0530)]
Staging: rtl8192e: Fix Sparse warning of cast from restricted __le16 in r8192E_dev.c
This patch fixes the following Sparse warning in rtl8192e/r8192E_dev.c-
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:196:34: warning: cast from restricted __le16
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:198:33: warning: cast from restricted __le16
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:200:33: warning: cast from restricted __le16
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Thu, 7 Nov 2013 13:41:31 +0000 (19:11 +0530)]
Staging: rtl8192e: Fix Sparse Warning for Static Declarations in rtllib_crypt_wep.c
This patch fixes the following Sparse warnings in rtllib_crypt_wep.c-
drivers/staging/rtl8192e/rtllib_crypt_wep.c:273:12: warning: symbol 'rtllib_crypto_wep_init' was not declared. Should it be static?
drivers/staging/rtl8192e/rtllib_crypt_wep.c:279:13: warning: symbol 'rtllib_crypto_wep_exit' was not declared. Should it be static?
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Thu, 7 Nov 2013 13:40:18 +0000 (19:10 +0530)]
Staging: rtl8192e: Fix Sparse Warning for Static Declarations in rtllib_crypt_tkip.c
This patch fixes the following Sparse warnings in rtllib_crypt_tkip.c-
drivers/staging/rtl8192e/rtllib_crypt_tkip.c:755:12: warning: symbol 'rtllib_crypto_tkip_init' was not declared. Should it be static?
drivers/staging/rtl8192e/rtllib_crypt_tkip.c:761:13: warning: symbol 'rtllib_crypto_tkip_exit' was not declared. Should it be static?
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Thu, 7 Nov 2013 13:39:25 +0000 (19:09 +0530)]
Staging: rtl8192e: Fix Sparse warning of cast to restricted __le16 in rtllib_crypt_tkip.c
This patch fixes the following Sparse warnings in rtllib_crypt_tkip.c-
drivers/staging/rtl8192e/rtllib_crypt_tkip.c:176:16: warning: cast to restricted __le16
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Thu, 7 Nov 2013 13:37:50 +0000 (19:07 +0530)]
Staging: rtl8192e: Fix Sparse Warning for Static Declarations in rtllib_crypt_ccmp.c
This patch fixes the following Sparse warnings in rtllib_crypt_ccmp.c-
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c:446:12: warning: symbol 'rtllib_crypto_ccmp_init' was not declared. Should it be static?
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c:452:13: warning: symbol 'rtllib_crypto_ccmp_exit' was not declared. Should it be static?
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Fri, 8 Nov 2013 12:56:20 +0000 (18:26 +0530)]
Staging: rtl8192e: Fix incorrect type in assignment in rtl819x_BAProc.c
This patch fixes the following Sparse warnings in
rtl819x_BAProc.c-
drivers/staging/rtl8192e/rtl819x_BAProc.c:118:21: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl819x_BAProc.c:118:21: expected unsigned short [unsigned] [usertype] tmp
drivers/staging/rtl8192e/rtl819x_BAProc.c:118:21: got restricted __le16 [usertype] <noident>
drivers/staging/rtl8192e/rtl819x_BAProc.c:122:13: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl819x_BAProc.c:122:13: expected unsigned short [unsigned] [addressable] [usertype] tmp
drivers/staging/rtl8192e/rtl819x_BAProc.c:122:13: got restricted __le16 [usertype] <noident>
drivers/staging/rtl8192e/rtl819x_BAProc.c:125:13: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl819x_BAProc.c:125:13: expected unsigned short [unsigned] [addressable] [usertype] tmp
drivers/staging/rtl8192e/rtl819x_BAProc.c:125:13: got restricted __le16 [usertype] <noident>
drivers/staging/rtl8192e/rtl819x_BAProc.c:181:13: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl819x_BAProc.c:181:13: expected unsigned short [unsigned] [usertype] tmp
drivers/staging/rtl8192e/rtl819x_BAProc.c:181:13: got restricted __le16 [usertype] <noident>
drivers/staging/rtl8192e/rtl819x_BAProc.c:184:13: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl819x_BAProc.c:184:13: expected unsigned short [unsigned] [addressable] [usertype] tmp
drivers/staging/rtl8192e/rtl819x_BAProc.c:184:13: got restricted __le16 [usertype] <noident>
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Thu, 7 Nov 2013 13:35:09 +0000 (19:05 +0530)]
Staging: rtl8192e: Fix Sparse Warning for Static Declarations in rtllib_softmac.c
This patch fixes the following Sparse warnings in rtllib_softmac.c-
drivers/staging/rtl8192e/rtllib_softmac.c:3636:12: warning: symbol 'rtllib_MgntDisconnectIBSS' was not declared. Should it be static?
drivers/staging/rtl8192e/rtllib_softmac.c:3661:13: warning: symbol 'rtllib_MlmeDisassociateRequest' was not declared. Should it be static?
drivers/staging/rtl8192e/rtllib_softmac.c:3687:13: warning: symbol 'rtllib_MgntDisconnectAP' was not declared. Should it be static?
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Thu, 7 Nov 2013 13:28:57 +0000 (18:58 +0530)]
Staging: rtl8192e: Fix incorrect type in assignment in rtllib_softmac.c
This patch fixes the following Sparse warning in rtllib_softmac.c-
drivers/staging/rtl8192e/rtllib_softmac.c:298:12: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtllib_softmac.c:298:12: expected unsigned short [unsigned] [usertype] fc
drivers/staging/rtl8192e/rtllib_softmac.c:298:12: got restricted __le16 [usertype] frame_ctl
drivers/staging/rtl8192e/rtllib_softmac.c:810:32: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtllib_softmac.c:810:32: expected restricted __le16 [usertype] frame_ctl
drivers/staging/rtl8192e/rtllib_softmac.c:810:32: got int
drivers/staging/rtl8192e/rtllib_softmac.c:814:34: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtllib_softmac.c:814:34: expected restricted __le16 [usertype] duration_id
drivers/staging/rtl8192e/rtllib_softmac.c:814:34: got int
drivers/staging/rtl8192e/rtllib_softmac.c:821:33: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtllib_softmac.c:821:33: expected restricted __le16 [usertype] algorithm
drivers/staging/rtl8192e/rtllib_softmac.c:821:33: got int
drivers/staging/rtl8192e/rtllib_softmac.c:955:24: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtllib_softmac.c:955:24: expected unsigned short [unsigned] [usertype] val16
drivers/staging/rtl8192e/rtllib_softmac.c:955:24: got restricted __le16 [usertype] <noident>
drivers/staging/rtl8192e/rtllib_softmac.c:1263:33: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtllib_softmac.c:1263:33: expected restricted __le16 [usertype] duration_id
drivers/staging/rtl8192e/rtllib_softmac.c:1263:33: got int
drivers/staging/rtl8192e/rtllib_softmac.c:1282:30: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtllib_softmac.c:1282:30: expected restricted __le16 [usertype] listen_interval
drivers/staging/rtl8192e/rtllib_softmac.c:1282:30: got unsigned short [unsigned] [usertype] listen_interval
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Thu, 7 Nov 2013 13:27:37 +0000 (18:57 +0530)]
Staging: rtl8192e: Fix Sparse Warning of invalid assignment '|=' in rtllib_softmac.c
This patch fixes the following Sparse warning in rtllib_softmac.c-
drivers/staging/rtl8192e/rtllib_softmac.c:812:40: warning: invalid assignment: |=
drivers/staging/rtl8192e/rtllib_softmac.c:812:40: left side has type restricted __le16
drivers/staging/rtl8192e/rtllib_softmac.c:812:40: right side has type int
drivers/staging/rtl8192e/rtllib_softmac.c:924:17: warning: invalid assignment: |=
drivers/staging/rtl8192e/rtllib_softmac.c:924:17: left side has type restricted __le16
drivers/staging/rtl8192e/rtllib_softmac.c:924:17: right side has type int
drivers/staging/rtl8192e/rtllib_softmac.c:924:17: error: cast from unknown type
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Thu, 7 Nov 2013 13:26:28 +0000 (18:56 +0530)]
Staging: rtl8192e: Fix Sparse warning of restricted __le16 degrades to integer in rtllib_softmac.c
This patch fixes the following Sparse warning in rtllib_softmac.c-
drivers/staging/rtl8192e/rtllib_softmac.c:230:19: warning: restricted __le16 degrades to integer
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sat, 2 Nov 2013 18:10:15 +0000 (23:40 +0530)]
Staging: rtl8192e: Fix Sparse Warning of restricted __le16 degrades to integer in rtllib_tx.c
This patch fixes the following sparse warning in rtllib_tx.c-
warning: restricted __le16 degrades to integer
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sat, 2 Nov 2013 18:09:22 +0000 (23:39 +0530)]
Staging: rtl8192e: Fix incorrect type in assignment in rtllib_tx.c
This patch fixes the following sparse warning in rtllib_tx.c-
drivers/staging/rtl8192e/rtllib_tx.c:234:24: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtllib_tx.c:234:24: expected restricted __le16 [usertype] frag_size
drivers/staging/rtl8192e/rtllib_tx.c:234:24: got int [signed] txb_size
drivers/staging/rtl8192e/rtllib_tx.c:613:43: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtllib_tx.c:613:43: expected restricted __le16 [usertype] payload_size
drivers/staging/rtl8192e/rtllib_tx.c:613:43: got unsigned int [unsigned] len
drivers/staging/rtl8192e/rtllib_tx.c:767:35: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtllib_tx.c:767:35: expected restricted __le16 [usertype] payload_size
drivers/staging/rtl8192e/rtllib_tx.c:767:35: got int [signed] [assigned] bytes
drivers/staging/rtl8192e/rtllib_tx.c:814:51: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtllib_tx.c:814:51: expected restricted __le16 [usertype] seq_ctl
drivers/staging/rtl8192e/rtllib_tx.c:814:51: got unsigned short
drivers/staging/rtl8192e/rtllib_tx.c:174:36: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtllib_tx.c:174:36: expected unsigned short [unsigned] [short] [usertype] <noident>
drivers/staging/rtl8192e/rtllib_tx.c:174:36: got restricted __be16 [usertype] <noident>
drivers/staging/rtl8192e/rtllib_tx.c:873:35: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtllib_tx.c:873:35: expected restricted __le16 [usertype] payload_size
drivers/staging/rtl8192e/rtllib_tx.c:873:35: got unsigned int [unsigned] len
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sat, 2 Nov 2013 18:08:00 +0000 (23:38 +0530)]
Staging: rtl8192e: Fix Sparse Warning for Static Declarations in rtllib_module.c
This patch fixes the following sparse warning in rtllib_module.c-
drivers/staging/rtl8192e/rtllib_module.c:240:12: warning: symbol 'rtllib_init' was not declared. Should it be static?
drivers/staging/rtl8192e/rtllib_module.c:260:13: warning: symbol 'rtllib_exit' was not declared. Should it be static?
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sat, 2 Nov 2013 18:07:04 +0000 (23:37 +0530)]
Staging: rtl8192e: Fix incorrect casting in rtllib_rx.c
This patch fixes the following sparse warning in rtllib_rx.c-
drivers/staging/rtl8192e/rtllib_rx.c:2267:34: warning: cast to restricted __le32
drivers/staging/rtl8192e/rtllib_rx.c:2268:34: warning: cast to restricted __le32
drivers/staging/rtl8192e/rtllib_rx.c:2269:36: warning: cast to restricted __le32
drivers/staging/rtl8192e/rtllib_rx.c:2269:36: warning: cast from restricted __le16
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sat, 2 Nov 2013 18:06:12 +0000 (23:36 +0530)]
Staging: rtl8192e: Fix Sparse warning of restricted __le16 degrades to integer in rtllib_rx.c
This patch fixes the following sparse warning in rtllib_rx.c-
warning: restricted __le16 degrades to integer
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sat, 2 Nov 2013 18:04:44 +0000 (23:34 +0530)]
Staging: rtl8192e: Fix incorrect type in assignment in rtllib_rx.c
This patch fixes the following Sparse warning in rtllib_rx.c-
drivers/staging/rtl8192e/rtllib_rx.c:493:37: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtllib_rx.c:493:37: expected unsigned short [unsigned] [usertype] len
drivers/staging/rtl8192e/rtllib_rx.c:493:37: got restricted __be16 [usertype] <noident>
drivers/staging/rtl8192e/rtllib_rx.c:1227:37: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtllib_rx.c:1227:37: expected unsigned short [unsigned] [usertype] len
drivers/staging/rtl8192e/rtllib_rx.c:1227:37: got restricted __be16 [usertype] <noident>
drivers/staging/rtl8192e/rtllib_rx.c:1635:40: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtllib_rx.c:1635:40: expected restricted __le16 <noident>
drivers/staging/rtl8192e/rtllib_rx.c:1635:40: got int
drivers/staging/rtl8192e/rtllib_rx.c:1637:40: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtllib_rx.c:1637:40: expected restricted __le16 <noident>
drivers/staging/rtl8192e/rtllib_rx.c:1637:40: got int
drivers/staging/rtl8192e/rtllib_rx.c:1641:45: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtllib_rx.c:1641:45: expected restricted __le16 <noident>
drivers/staging/rtl8192e/rtllib_rx.c:1641:45: got unsigned short [unsigned] [usertype] <noident>
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Teodora Baluta [Mon, 4 Nov 2013 11:12:12 +0000 (13:12 +0200)]
staging: usbip: fix sparse warnings regarding endianness
The wHubCharacteristics field in usb_hub_descriptor structure is __le16
so there is no need for cast. The cpu_to_le16 returns a __le16 type for
a u16 type. Used cpu_to_le16 to silence last sparse error.
drivers/staging/usbip/vhci_hcd.c:223:35: warning: incorrect type in assignment (different base types)
drivers/staging/usbip/vhci_hcd.c:223:35: expected restricted __le16 [usertype] wHubCharacteristics
drivers/staging/usbip/vhci_hcd.c:223:35: got unsigned short [unsigned] [usertype] <noident>
drivers/staging/usbip/vhci_hcd.c:351:34: warning: incorrect type in assignment (different base types)
drivers/staging/usbip/vhci_hcd.c:351:34: expected unsigned short [unsigned] [short] [usertype] <noident>
drivers/staging/usbip/vhci_hcd.c:351:34: got restricted __le16 [usertype] <noident>
drivers/staging/usbip/vhci_hcd.c:352:34: warning: incorrect type in assignment (different base types)
drivers/staging/usbip/vhci_hcd.c:352:34: expected unsigned short [unsigned] [short] [usertype] <noident>
drivers/staging/usbip/vhci_hcd.c:352:34: got restricted __le16 [usertype] <noident>
drivers/staging/usbip/vhci_hcd.c:540:36: warning: restricted __le16 degrades to integer
Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Sat, 2 Nov 2013 12:08:10 +0000 (17:38 +0530)]
staging:usbip:usbip_common.c: Join quoted string split accross lines
This patch removes the checkpatch.pl warnings "quoted string split accross lines"
in usbip_common.c.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Sat, 2 Nov 2013 12:01:22 +0000 (17:31 +0530)]
staging:usbip:stub_rx.c: Remove warning quoted string split across lines
This patch removes the checkpatch.pl warnings "quoted string split
across lines" in stub_rx.c by merging the quoted strings and the
ensuring that the lines are not more than 80 characters long.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Sat, 2 Nov 2013 12:41:44 +0000 (18:11 +0530)]
staging:wlan-ng:hfa384x.h: remove typedef struct hfa384x_bytestr __packed hfa384x_bytestr_t
This patch removes the checkpatch.pl warning "do not add new typedefs"
and changes all source files that use that typedef. Also lines were
shortened to 80 characters to do away with the checkpatch.pl warning
"line over 80 characters" generated due to replacement of the
hfa384x_bytestr_t by struct hfa384x_bytestr in prism2mgmt.c,
prism2mgmt.h, prism2mib.c, prism2sta.c.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Sat, 2 Nov 2013 12:32:38 +0000 (18:02 +0530)]
staging:wlan-ng:cfg80211.c: Shorten lines to 80 characters
This patch removes checkpatch.pl warnings "line over 80 characters" in
cfg80211.c.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Archana kumari [Sun, 3 Nov 2013 06:21:31 +0000 (11:51 +0530)]
staging: media: davinci_vpfe:Removed space before semicolon in dm365_ipipe_hw.c
This patch fixes "space prohibted before semicolon" warning in dm365_ipipe_hw.cdetected via checkpatch.pl
Signed-off-by: Archana kumari <archanakumari959@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Sat, 2 Nov 2013 17:12:22 +0000 (22:42 +0530)]
staging:media:go7007:saa7134-go7007.c: Remove space before tabs
This patch removes the checkpatch.pl warning "please, no space before
tabs" in saa7134-go7007.c by converting space followed by tab to tab
followed by tab.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Sat, 2 Nov 2013 12:20:56 +0000 (17:50 +0530)]
staging:media:go7007:go7007-fw.c: move trailing statement to next line
This patch removes the checkpatch.pl error "trailing statements should
be on next line" in go7007-fw.c.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Fri, 1 Nov 2013 17:00:38 +0000 (19:00 +0200)]
Staging: media: fix space prohibited before semicolon
Fix checkpatch.pl issues with space prohibited before semicolon in dm365_ipipe.c
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ingrid Cheung [Sun, 10 Nov 2013 04:02:50 +0000 (23:02 -0500)]
Staging: bcm: Fix checkpatch warnings for long lines.
Fixes multiple checkpatch warnings for long lines in Bcmchar.c.
Signed-off-by: Ingrid Cheung <hi@ingridcheung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ingrid Cheung [Sun, 10 Nov 2013 01:53:21 +0000 (20:53 -0500)]
Staging: bcm: Fix checkpatch warning for long line.
Fixed a line that was over 80 characters in Bcmchar.c.
Signed-off-by: Ingrid Cheung <hi@ingridcheung.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nandini Hanumanthagowda [Fri, 1 Nov 2013 18:49:31 +0000 (00:19 +0530)]
staging: bcm: fixed space related errors around operators
removed any prohibited spaces and added required spaces
around operators to follow linux coding style and hence
fixed the checkpatch errors
Signed-off-by: Nandini Hanumanthagowda <nandu.hgowda@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nandini Hanumanthagowda [Fri, 1 Nov 2013 16:33:55 +0000 (22:03 +0530)]
staging: bcm: removed prohibited space before semicolon
removed prohibited space before semicolon(;) to fix
checkpatch warning
Signed-off-by: Nandini Hanumanthagowda <nandu.hgowda@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Fri, 1 Nov 2013 13:54:17 +0000 (19:24 +0530)]
Staging: keucr: Fix externs are avoided in smscsi.c
This patch fixes the following checkpatch.pl warning in smscsi.c-
WARNING: externs should be avoided in .c files
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Fri, 1 Nov 2013 13:51:27 +0000 (19:21 +0530)]
Staging: keucr: Fix externs are avoided in smilsub.c
This patch fixes the following checkpatch.pl warning in smilsub.c-
WARNING: externs should be avoided in .c files
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Fri, 1 Nov 2013 13:49:57 +0000 (19:19 +0530)]
Staging: keucr: Fix externs are avoided in smilmain.c
This patch fixes the following checkpatch.pl warning in smilmain.c-
WARNING: externs should be avoided in .c files
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Fri, 1 Nov 2013 13:03:08 +0000 (15:03 +0200)]
staging: crystalhd: return true and false instead of 1 and 0
This fixes coccinelle error regarding functions that return
bool and return 1 and 0 instead of true and false.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Archana kumari [Fri, 1 Nov 2013 08:35:44 +0000 (14:05 +0530)]
staging: media: lirc: fixed sparse warnings by adding __user annotations in lirc_serial.c
This patch fixes sparse warning by adding __user annotations in
lirc_serial.c
Signed-off-by: Archana kumari <archanakumari959@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Teodora Baluta [Sun, 10 Nov 2013 15:12:45 +0000 (17:12 +0200)]
staging: vt6655: remove unneeded semicolon
This patch deletes any unneeded semicolons in driver vt6655 as detected
by coccinelle.
Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Teodora Baluta [Sun, 10 Nov 2013 15:12:44 +0000 (17:12 +0200)]
staging: vt6655: fix comparison of bool to 0/1
This patch corrects comparison of bool to 0/1 for file
drivers/staging/vt6655/rxtx.c. The following type of coccinelle detected
warnings are silenced:
WARNING: Comparison of bool to 0/1
Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Teodora Baluta [Sun, 10 Nov 2013 15:12:43 +0000 (17:12 +0200)]
staging: vt6655: fix assignment of bool to 0
This patch fixes the following warnings detected using coccinelle for
drivers/staging/wmgr.c file:
drivers/staging/vt6655/wmgr.c:2335:1-22: WARNING: Assignment of bool to 0/1
drivers/staging/vt6655/wmgr.c:2338:1-27: WARNING: Assignment of bool to 0/1
Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Teodora Baluta [Sun, 10 Nov 2013 15:12:42 +0000 (17:12 +0200)]
staging: vt6655: delete explicit comparison to bool
This patch fixes the following type of coccinelle detected warnings for
driver vt6655:
WARNING: Comparison to bool
Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Teodora Baluta [Fri, 8 Nov 2013 23:00:03 +0000 (01:00 +0200)]
staging: vt6655: put brace on previous line
Place braces on same line for code statements. Fix the following
checkpatch.pl type of error for drivers/staging/vt6655/bssdb.c file:
ERROR: that open brace { should be on the previous line
Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Teodora Baluta [Fri, 8 Nov 2013 23:00:02 +0000 (01:00 +0200)]
staging: vt6655: put trailing statements on next line
This patch fixes the following type of checkpatch.pl errors in
drivers/staging/vt6655/bssdb.c file:
ERROR: trailing statements should be on next line
Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Teodora Baluta [Fri, 8 Nov 2013 23:00:01 +0000 (01:00 +0200)]
staging: vt6655: remove braces for single statement blocks
This patch removes braces for single statement blocks, clearing these
types of checkpatch.pl warnings:
WARNING: braces {} are not necessary for single statement blocks
WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Teodora Baluta [Fri, 8 Nov 2013 23:00:00 +0000 (01:00 +0200)]
staging: vt6655: replace C99 comments wtih C89 comments
This patch replaces C99 comments with /* .. */ comments. Any commented
code is deleted.
Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nandini Hanumanthagowda [Sun, 3 Nov 2013 13:00:52 +0000 (18:30 +0530)]
staging: vt6656: fixed whitespace related errors around operators
removed prohibited spaces around operators and added required
spaces around operators wherever necessary to fix checkpatch
errors
Signed-off-by: Nandini Hanumanthagowda <nandu.hgowda@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Mon, 4 Nov 2013 08:44:02 +0000 (10:44 +0200)]
staging: vt6656: Fix (most) sparse warnings regarding static functions/variables
This fixes sparse warnings for functions and variables, e.g.:
* drivers/staging/vt6656/card.c:69:11: warning: symbol 'cwRXBCNTSFOff'
was not declared. Should it be static?
Some warnings were false positives, such as:
* drivers/staging/vt6656/dpc.c:249:5: warning: symbol 'RXbBulkInProcessData'
was not declared. Should it be static?
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Archana kumari [Fri, 1 Nov 2013 06:49:21 +0000 (12:19 +0530)]
staging: vt6655: fixed sparse warning for static declaration in wpa2.c
This patch fixes sparse warning for static declaration in wpa2.c
Signed-off-by: Archana kumari <archanakumari959@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Sun, 10 Nov 2013 17:10:31 +0000 (19:10 +0200)]
Staging: rtl8187se: fix printk() should include kern_ facility level
Fix checkpatch.pl issues with printk() should
include kern_ facility level in r8185b_init.c
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Teodora Baluta [Tue, 5 Nov 2013 16:36:47 +0000 (18:36 +0200)]
staging: lustre: remove initialisation of static variable
Fix the following checkpatch.pl error:
ERROR: do not initialise statics to 0 or NULL
+static int libcfs_nidstring_idx = 0;
Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Teodora Baluta [Tue, 5 Nov 2013 16:36:46 +0000 (18:36 +0200)]
staging: lustre: place EXPORT_SYMBOL after its function
This patch fixes the following type of warnings detected by
checkpatch.pl:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Teodora Baluta [Tue, 5 Nov 2013 16:36:45 +0000 (18:36 +0200)]
staging: lustre: remove space between function name and open parenthesis
This fixes the following checkpatch.pl warnings:
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dulshani Gunawardhana [Thu, 31 Oct 2013 16:21:32 +0000 (21:51 +0530)]
staging:lustre: Fix plain integer as NULL pointer warning
Fix the sparse warning of 'Using plain integer as NULL pointer' in lproc_lov.c.
Signed-off-by: Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Sun, 10 Nov 2013 08:56:17 +0000 (14:26 +0530)]
Staging: rtl8187se: Remove C99 style commenting
This patch fixes the checkpatch.pl warning
"do not use C99 // comments"
in ieee80211/ieee80211_softmac.c.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Sun, 10 Nov 2013 08:54:44 +0000 (14:24 +0530)]
Staging: rtl8187se: Fix indentation errors
This patch fixes the checkpatch.pl warnings "code indent should use
tabs where possible" in ieee80211/ieee80211_softmac.c.
Also unnecessary blanks lines are removed.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Thu, 7 Nov 2013 21:37:03 +0000 (03:07 +0530)]
Staging:rtl8187se: Remove unnecessary braces from if-else statement
This patch fixes the checkpatch.pl warning
braces {} are not necessary for any arm of this statement
in ieee80211/ieee80211_softmac.c.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Thu, 7 Nov 2013 21:36:39 +0000 (03:06 +0530)]
Staging:rtl8187se: Add space before open parenthesis of if condition
This patch fixes the checkpatch.pl warning :
space required before the open parenthesis '('
in ieee80211/ieee80211_softmac.c.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey Botello [Thu, 7 Nov 2013 08:31:21 +0000 (09:31 +0100)]
Staging: rtl8187se: use macro IW_HANDLER to initialize r8180_wx_handlers
Use IW_HANDLER to initialize iw_handler structure like in others wireless
driver.
Acked-by: Pablo Neira Ayuso <pablo@gnumonks.org>
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Wed, 6 Nov 2013 11:26:33 +0000 (16:56 +0530)]
Staging:rtl8187se: Insert spaces after commas
This patch fixes the checkpatch.pl warnings
space required after that ',' in ieee80211/ieee80211_softmac.c
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Wed, 6 Nov 2013 05:40:24 +0000 (11:10 +0530)]
staging:rtl8187se: Use preferred library linux/uaccess.h over asm/uaccess.h
This patch fixes the checkpatch.pl warning "Use #include
<linux/uaccess.h> instead of <asm/uaccess.h>" in
ieee80211/ieee80211_softmac.c .
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Tue, 5 Nov 2013 22:06:11 +0000 (03:36 +0530)]
staging:rtl8187se: Shift open brace of function declarations to next line
This patch fixes the checkpatch.pl error "open brace '{' following
function declarations go on the next line" in ieee80211_softmac.c.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Sun, 3 Nov 2013 10:46:14 +0000 (16:16 +0530)]
Staging: rtl8187se: Fix C99 style commenting in dot11d.h
This patch fixes the checkpatch.pl error "do not use C99 // comments"
in ieee80211/dot11d.n.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sat, 2 Nov 2013 17:35:19 +0000 (23:05 +0530)]
Staging: rtl8187se: Remove useless comments in dot11d.c
This patch removes unnecessary comments in ieee80211/dot11d.c.
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sat, 2 Nov 2013 17:33:43 +0000 (23:03 +0530)]
Staging: rtl8187se: Remove unnecessary return statement in ieee80211_crypt_tkip.c
This patch removes an unnecessary return statement in the function
ieee80211_tkip_null() in ieee80211/ieee80211_crypt_tkip.c.
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sat, 2 Nov 2013 17:28:20 +0000 (22:58 +0530)]
Staging: rtl8187se: Fix code indent should use tabs in ieee80211_crypt_tkip.c
This patch fixes the following checkpatch.pl issues in
ieee80211/ieee80211_crypt_tkip.c-
ERROR: code indent should use tabs where possible
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sat, 2 Nov 2013 17:27:07 +0000 (22:57 +0530)]
Staging: rtl8187se: Replace "foo * bar" with "foo *bar" in ieee80211_crypt_tkip.c
This patch fixes the following checkpatch.pl issues in
ieee80211/ieee80211_crypt_tkip.c-
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sat, 2 Nov 2013 17:25:52 +0000 (22:55 +0530)]
Staging: rtl8187se: Remove useless comments in ieee80211_crypt_tkip.c
This patch removes useless comments in ieee80211/ieee80211_crypt_tkip.c.
And, hence also removes the following checkpatch.pl issue-
ERROR: do not use C99 // comments
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sat, 2 Nov 2013 17:24:39 +0000 (22:54 +0530)]
Staging: rtl8187se: Fix quoted strings split across lines in ieee80211_crypt_ccmp.c
This patch fixes the following checkpatch.pl issues in
ieee80211/ieee80211_crypt_ccmp.c-
WARNING: quoted string split across lines
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sat, 2 Nov 2013 17:23:07 +0000 (22:53 +0530)]
Staging: rtl8187se: Remove unnecessary comments in ieee80211_crypt_ccmp.c
This patch removes unnecessary comments written in ieee80211/ieee80211_crypt_ccmp.c.
And hence also, removes the following checkpatch.pl issue-
ERROR: do not use C99 // comments
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sat, 2 Nov 2013 17:21:26 +0000 (22:51 +0530)]
Staging: rtl8187se: Fix line over 80 characters in dot11d.c
This patch fixes the following checkpatch.pl issues in
ieee80211/dot11d.c-
WARNING: line over 80 characters
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sat, 2 Nov 2013 17:19:59 +0000 (22:49 +0530)]
Staging: rtl8187se: Remove unnecessary braces around single statement in dot11d.c
This patch fixes the following checkpatch.pl issues in
ieee80211/dot11d.c-
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sat, 2 Nov 2013 17:17:45 +0000 (22:47 +0530)]
Staging: rtl8187se: Fix space prohibited before semicolon in dot11d.c
This patch fixes the following checkpatch.pl issues in
ieee80211/dot11d.c-
WARNING: space prohibited before semicolon
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sat, 2 Nov 2013 17:16:00 +0000 (22:46 +0530)]
Staging: rtl8187se: Fix printk() should include KERN_ facility level
This patch fixes the following checkpatch.pl issues in
ieee80211/dot11d.c-
WARNING: printk() should include KERN_ facility level
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rashika Kheria [Sat, 2 Nov 2013 17:14:38 +0000 (22:44 +0530)]
Staging: rtl8187se: Fix C99 style commenting in dot11d.c
This patch fixes the following checkpatch.pl issues in
ieee80211/dot11d.c-
ERROR: do not use C99 // comments
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Thu, 31 Oct 2013 03:31:41 +0000 (09:01 +0530)]
drivers : staging :rtl8187se : r8180_core.c : remove space before semicolon
This patch removes the checkpatch.pl warning space prohibited before
semicolon.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sima Baymani [Sun, 3 Nov 2013 10:18:57 +0000 (11:18 +0100)]
staging: imx-drm: remove unnecessary braces
Fix checkpatch warning by removing unnecessary braces.
Compile-tested the single file.
Signed-off-by: Sima Baymani <sima.baymani@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Reviewed-by: Archana Kumari <archanakumari959@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Archana kumari [Wed, 30 Oct 2013 19:04:08 +0000 (00:34 +0530)]
staging: imx-drm: Fix warning for static const char * array in imx-ldb.c
This patch fixes the warning "static const char * array should
probably be static const char * const" in imx-ldb.c.
Signed-off-by: Archana kumari <archanakumari959@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sima Baymani [Tue, 5 Nov 2013 20:28:56 +0000 (21:28 +0100)]
staging: cxt1e1: fix long lines warning
Break up long lines per checkpatch warnings.
Signed-off-by: Sima Baymani <sima.baymani@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sima Baymani [Tue, 5 Nov 2013 20:49:16 +0000 (21:49 +0100)]
staging: cxt1e1: remove typedef comet_t
Remove typedef declaration per checkpatch warning.
Built and loaded.
Signed-off-by: Sima Baymani <sima.baymani@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sima Baymani [Tue, 5 Nov 2013 20:22:56 +0000 (21:22 +0100)]
staging: cxt1e1: comet,h - fix placement of braces
Fix bad placement of braces per checkpatch warning.
Signed-off-by: Sima Baymani <sima.baymani@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sima Baymani [Tue, 5 Nov 2013 20:22:12 +0000 (21:22 +0100)]
staging: cxt1e1: comet.h - fix long lines warning
Fix long lines warnings from checkpatch which were introduced in
previous patch in series due to reindentation.
Signed-off-by: Sima Baymani <sima.baymani@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sima Baymani [Tue, 5 Nov 2013 20:21:38 +0000 (21:21 +0100)]
staging: cxt1e1: comet.h - fix wrong indentation
Reindent needed parts of comet.h per checkpatch warnings - whitespace
changes only.
This patch introduces long line warnings because of the reindentation.
Those warnings are fixed by the next patch in series.
Signed-off-by: Sima Baymani <sima.baymani@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dulshani Gunawardhana [Wed, 30 Oct 2013 18:49:54 +0000 (00:19 +0530)]
staging/cxt1e1:Fixes incorrect brace placement
This patch fixes the error "This open brace { should be on the
above line" detected via checkpatch.pl.
Signed-off-by: Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>
Reviewed-by: Zach Brown <zab@redhat.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kelley Nielsen [Wed, 6 Nov 2013 13:10:19 +0000 (05:10 -0800)]
staging: ft1000: fix remaining checkpatch issues in ft1000_hw.c
The file ft1000_hw.c is still full of coding style problems that make it
challenging to read and understand. The lines inside the switch cases
in ft1000_proc_drvmsg() are indented too deeply, so remove one leading
tab. Join lines that are now able to fit in the 80 character limit.
This will take care of the "too many leading tabs" issue. Run
checkpatch.pl on the file, and correct all other issues it reports
(except lines with user visible strings over 80 chars).
Signed-off-by: Kelley Nielsen <kelleynnn@gmail.com>
Suggested-by: Waskiewicz Jr, Peter P <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>