OSDN Git Service

android-x86/packages-apps-Camera2.git
9 years agoam 6b2d1e0b: Merge "Revert temporary session images in filmstrip to RGB_565" into...
Alan Newberger [Thu, 25 Sep 2014 01:10:06 +0000 (01:10 +0000)]
am 6b2d1e0b: Merge "Revert temporary session images in filmstrip to RGB_565" into ub-camera-glacier

* commit '6b2d1e0b660e931c6cbc91a25ec85df070712e65':
  Revert temporary session images in filmstrip to RGB_565

9 years agoam 347dccbe: Ensure Camera doesn\'t attempt access of back camera on Nakasi
Alan Newberger [Thu, 25 Sep 2014 01:10:04 +0000 (01:10 +0000)]
am 347dccbe: Ensure Camera doesn\'t attempt access of back camera on Nakasi

* commit '347dccbe1ed10ceec190af4d3797a197426f1caf':
  Ensure Camera doesn't attempt access of back camera on Nakasi

9 years agoMerge "Revert temporary session images in filmstrip to RGB_565" into ub-camera-glacier
Alan Newberger [Thu, 25 Sep 2014 01:09:03 +0000 (01:09 +0000)]
Merge "Revert temporary session images in filmstrip to RGB_565" into ub-camera-glacier

9 years agoRevert temporary session images in filmstrip to RGB_565
Alan Newberger [Thu, 25 Sep 2014 00:59:02 +0000 (17:59 -0700)]
Revert temporary session images in filmstrip to RGB_565

A simple way to avoid performance issues for now until we get around
the significant load issues seen in writing ARGB_8888 to disk cache.

Bug: 17642071
Change-Id: I6017980fce6e633b52dce93f3f46931e5bcc3d9c

9 years agoEnsure Camera doesn't attempt access of back camera on Nakasi
Alan Newberger [Thu, 25 Sep 2014 00:19:25 +0000 (17:19 -0700)]
Ensure Camera doesn't attempt access of back camera on Nakasi

Bug: 17647004
Change-Id: I823f98cfdfcc7429b6acf98215e4a08787bc1bb9

9 years agoam 2631a15a: Don\'t show aspect ratio UI if using API2 portability
Alan Newberger [Wed, 24 Sep 2014 22:04:09 +0000 (22:04 +0000)]
am 2631a15a: Don\'t show aspect ratio UI if using API2 portability

* commit '2631a15a37b890f4ee720c5a4bbe3e654524deb6':
  Don't show aspect ratio UI if using API2 portability

9 years agoDon't show aspect ratio UI if using API2 portability
Alan Newberger [Wed, 24 Sep 2014 21:23:30 +0000 (14:23 -0700)]
Don't show aspect ratio UI if using API2 portability

Avoid preview size changes due to current state of locking in API2
portability implementation.

Bug: 17462976
Change-Id: I9426380699988d67b21ce86850ef00736e84a5d6

9 years agoam eeeed4fa: new sounds for timer ticker and pano / photosphere intermediate captures
Spike Sprague [Wed, 24 Sep 2014 01:47:39 +0000 (01:47 +0000)]
am eeeed4fa: new sounds for timer ticker and pano / photosphere intermediate captures

* commit 'eeeed4fa00ed842050bc7e0edd3b37c262802a5b':
  new sounds for timer ticker and pano / photosphere intermediate captures

9 years agonew sounds for timer ticker and pano / photosphere intermediate captures
Spike Sprague [Wed, 27 Aug 2014 19:01:36 +0000 (12:01 -0700)]
new sounds for timer ticker and pano / photosphere intermediate captures

companions CL: ag/534823

bug: 17281234

Change-Id: I9d98d8e869dcefdbd0f7e0b53dea6b8e024a8e3b

9 years agoam 7d1fb593: Merge "monkey test NPE fix, another null check on mCameraDevice" into...
Spike Sprague [Wed, 24 Sep 2014 01:03:23 +0000 (01:03 +0000)]
am 7d1fb593: Merge "monkey test NPE fix, another null check on mCameraDevice" into ub-camera-glacier

* commit '7d1fb593ae26e4f327e47bcbb857057da4ea23a0':
  monkey test NPE fix, another null check on mCameraDevice

9 years agoMerge "monkey test NPE fix, another null check on mCameraDevice" into ub-camera-glacier
Spike Sprague [Wed, 24 Sep 2014 00:44:00 +0000 (00:44 +0000)]
Merge "monkey test NPE fix, another null check on mCameraDevice" into ub-camera-glacier

9 years agoam b60af188: Merge "Fix filmstrip item bounds to filmstrip scale" into ub-camera...
Alan Newberger [Tue, 23 Sep 2014 16:53:25 +0000 (16:53 +0000)]
am b60af188: Merge "Fix filmstrip item bounds to filmstrip scale" into ub-camera-glacier

* commit 'b60af188e3bc712a7f06700c591c428834237dff':
  Fix filmstrip item bounds to filmstrip scale

9 years agoMerge "Fix filmstrip item bounds to filmstrip scale" into ub-camera-glacier
Alan Newberger [Tue, 23 Sep 2014 16:43:58 +0000 (16:43 +0000)]
Merge "Fix filmstrip item bounds to filmstrip scale" into ub-camera-glacier

9 years agoam 5f86f7fd: Cleanup gesture UI hide code
Alan Newberger [Tue, 23 Sep 2014 00:35:31 +0000 (00:35 +0000)]
am 5f86f7fd: Cleanup gesture UI hide code

* commit '5f86f7fdd19dad9cdf670e0504cfaddefd4a89fc':
  Cleanup gesture UI hide code

9 years agoam b2b0e02c: Clean up unused code
Alan Newberger [Tue, 23 Sep 2014 00:35:30 +0000 (00:35 +0000)]
am b2b0e02c: Clean up unused code

* commit 'b2b0e02cb5f0aba8fed9389193fa98150da75efc':
  Clean up unused code

9 years agoCleanup gesture UI hide code
Alan Newberger [Mon, 22 Sep 2014 19:30:08 +0000 (12:30 -0700)]
Cleanup gesture UI hide code

Relocate show/hide of zoom UI in the onScaleBegin/onScaleEnd classes.

Bug: 17613719

Change-Id: I400161c95c08c7f3b6b36487de703296236595bb

9 years agoClean up unused code
Alan Newberger [Mon, 22 Sep 2014 19:05:56 +0000 (12:05 -0700)]
Clean up unused code

This UI code is completely unused, and has no reference from rest of
app. Delete for cleanup.

Bug: 17613719

Change-Id: I1d9d443ef6642cd434725fe71e59fa0220258789

9 years agomonkey test NPE fix, another null check on mCameraDevice
Spike Sprague [Mon, 22 Sep 2014 17:52:32 +0000 (10:52 -0700)]
monkey test NPE fix, another null check on mCameraDevice

bug: 17604028
Change-Id: I7b45c101045b765562146ebe2c779e227a6227bd

9 years agoFix filmstrip item bounds to filmstrip scale
Alan Newberger [Sun, 21 Sep 2014 23:11:29 +0000 (16:11 -0700)]
Fix filmstrip item bounds to filmstrip scale

There's no reason to scale filmstrip items to anything other
than the fixed filmstrip scale, and doing otherwise interferes
with Glide caching and introduces flickers upon zoom.

Bug: 17597708
Change-Id: Ia143b4d95a48e9e23bbf36ec0edf93599caaa01b

9 years agoam 02758e4c: (-s ours) Merge "Import translations. DO NOT MERGE" into ub-camera-glacier
Baligh Uddin [Fri, 19 Sep 2014 22:43:59 +0000 (22:43 +0000)]
am 02758e4c: (-s ours) Merge "Import translations. DO NOT MERGE" into ub-camera-glacier

* commit '02758e4c60ea1ff5a78c6d7d8d77ee353a2bf6f5':
  Import translations. DO NOT MERGE

9 years agoMerge "Import translations. DO NOT MERGE" into ub-camera-glacier
Baligh Uddin [Fri, 19 Sep 2014 22:33:35 +0000 (22:33 +0000)]
Merge "Import translations. DO NOT MERGE" into ub-camera-glacier

9 years agoam 30ae8c64: Merge "Changed tap-to-meter rectangle and weights." into ub-camera-glacier
Jiawen Chen [Fri, 19 Sep 2014 22:28:39 +0000 (22:28 +0000)]
am 30ae8c64: Merge "Changed tap-to-meter rectangle and weights." into ub-camera-glacier

* commit '30ae8c64cec9313fc050daf94ae3fbddedf80b36':
  Changed tap-to-meter rectangle and weights.

9 years agoMerge "Changed tap-to-meter rectangle and weights." into ub-camera-glacier
Jiawen Chen [Fri, 19 Sep 2014 22:17:29 +0000 (22:17 +0000)]
Merge "Changed tap-to-meter rectangle and weights." into ub-camera-glacier

9 years agoam e684ea54: Merge "Fix CameraSettingsActivityHelper" into ub-camera-glacier
Alan Newberger [Fri, 19 Sep 2014 21:03:32 +0000 (21:03 +0000)]
am e684ea54: Merge "Fix CameraSettingsActivityHelper" into ub-camera-glacier

* commit 'e684ea54121ef885a0aa84cd3bea50c5a345d55e':
  Fix CameraSettingsActivityHelper

9 years agoam 19942a17: Merge "implement new trash icon, plus some asset cleanup" into ub-camera...
Spike Sprague [Fri, 19 Sep 2014 21:03:31 +0000 (21:03 +0000)]
am 19942a17: Merge "implement new trash icon, plus some asset cleanup" into ub-camera-glacier

* commit '19942a171844d6bd361026a6b8df2eebaa0661db':
  implement new trash icon, plus some asset cleanup

9 years agoMerge "Fix CameraSettingsActivityHelper" into ub-camera-glacier
Alan Newberger [Fri, 19 Sep 2014 20:59:46 +0000 (20:59 +0000)]
Merge "Fix CameraSettingsActivityHelper" into ub-camera-glacier

9 years agoMerge "implement new trash icon, plus some asset cleanup" into ub-camera-glacier
Spike Sprague [Fri, 19 Sep 2014 20:54:55 +0000 (20:54 +0000)]
Merge "implement new trash icon, plus some asset cleanup" into ub-camera-glacier

9 years agoam 8bbb5122: Merge "add null check to updateCameraParametersPreferences to apease...
Spike Sprague [Fri, 19 Sep 2014 18:30:27 +0000 (18:30 +0000)]
am 8bbb5122: Merge "add null check to updateCameraParametersPreferences to apease the monkey" into ub-camera-glacier

* commit '8bbb51221106c12b0cf7e933fc2af2a63b84b1c1':
  add null check to updateCameraParametersPreferences to apease the monkey

9 years agoMerge "add null check to updateCameraParametersPreferences to apease the monkey"...
Spike Sprague [Fri, 19 Sep 2014 18:22:56 +0000 (18:22 +0000)]
Merge "add null check to updateCameraParametersPreferences to apease the monkey" into ub-camera-glacier

9 years agoadd null check to updateCameraParametersPreferences to apease the monkey
Spike Sprague [Fri, 19 Sep 2014 18:18:46 +0000 (11:18 -0700)]
add null check to updateCameraParametersPreferences to apease the monkey

bug: 17580046
Change-Id: I4a109c1134684f6d5b2dafdb138137ef36f208f0

9 years agoam 963775c3: portability layer doesn\'t work well with startPreviewWithCallback(...
Spike Sprague [Fri, 19 Sep 2014 06:19:18 +0000 (06:19 +0000)]
am 963775c3: portability layer doesn\'t work well with startPreviewWithCallback() here\'s a dirty dirty workaround.

* commit '963775c3092e2553ae8157df9e5d307d4f711de1':
  portability layer doesn't work well with startPreviewWithCallback() here's a dirty dirty workaround.

9 years agoportability layer doesn't work well with startPreviewWithCallback()
Spike Sprague [Fri, 19 Sep 2014 02:44:07 +0000 (19:44 -0700)]
portability layer doesn't work well with startPreviewWithCallback()
here's a dirty dirty workaround.

bug: 17576554
Change-Id: Ief40b65ce49712153f6ef604a3513348e493d4d9

9 years agoam 3c3b31df: mode switch jank fixes
Spike Sprague [Thu, 18 Sep 2014 20:11:13 +0000 (20:11 +0000)]
am 3c3b31df: mode switch jank fixes

* commit '3c3b31dfd5ec7a43e89cd4695cc8c498afc3a91d':
  mode switch jank fixes

9 years agomode switch jank fixes
Spike Sprague [Mon, 8 Sep 2014 17:43:04 +0000 (10:43 -0700)]
mode switch jank fixes

puts many ValueAnimators news into initialize methods
changes startPreview() calls to startPreviewWithCallback()
puts MultToggleImageButton's bitmap combine into an AsyncTask

bug: 17070332
Change-Id: Idea6396264588b345ed27b9f96f9434ff3e7e77c

9 years agoimplement new trash icon, plus some asset cleanup
Spike Sprague [Thu, 18 Sep 2014 17:52:35 +0000 (10:52 -0700)]
implement new trash icon, plus some asset cleanup

bug: 17566685
Change-Id: Ia7b55ad3b6fed939c19abcde12cbf34726ba919c

9 years agoChanged tap-to-meter rectangle and weights.
Jiawen Chen [Wed, 17 Sep 2014 00:05:37 +0000 (17:05 -0700)]
Changed tap-to-meter rectangle and weights.

Bug: 17417649

- Clarified widths in Settings3A.
  - For Gcam only, reduced AE box to 12.25% of the shorter edge of the crop
  rectangle. This matches the setting on Nexus 5.
  - For Gcam only, changed AE weight to 22 after consultations with Ryan.
  - Tested with Gcam and it final shots look great in HDR scenes.
- Does not fully address b/17417649: ISP AE ignores the weight completely and
  overcompensates for the tap region.
- Changed AutoFocusHelper to take touch points in normalized portrait
  coordinates along with a sensor orientation. The output is a MeteringRectangle
  in sensor pixels.
  - Fixed a bug where a digital-zoomed tap doesn't work when the rect intersects
    edges. It should have been clamp, not check for intersection and return the
    full crop rectangle if it doesn't intersect.

- Submit simultaneously with ag/549706.

Change-Id: If084e64ecbfc4a08ece96a7cebfcaf835d92b9d1

9 years agoImport translations. DO NOT MERGE
Baligh Uddin [Wed, 17 Sep 2014 04:45:54 +0000 (21:45 -0700)]
Import translations. DO NOT MERGE

Change-Id: I6541f685bfc16e910b5689acbe74e15e07c5bd5b
Auto-generated-cl: translation import

9 years agoFix CameraSettingsActivityHelper
Alan Newberger [Wed, 17 Sep 2014 03:54:56 +0000 (20:54 -0700)]
Fix CameraSettingsActivityHelper

Previous hack to allow activity up button to work, interfered with
custom preference merging we use to conditonally add items to
Settings. Now fixed by allowing internal control of whether the
full preference tree is returned by the fragment or just the
desired subtree, so that the Helper can access the full tree.

Bug: 17534830
Change-Id: I11510f365b9e212f07009b2233bb5d8036228774

9 years agoMerge "Import translations. DO NOT MERGE" into lmp-dev
Baligh Uddin [Tue, 16 Sep 2014 15:20:49 +0000 (15:20 +0000)]
Merge "Import translations. DO NOT MERGE" into lmp-dev

9 years agoam 6f1dfe69: Merge "Don\'t set mCameraAppUI to null in onDestroy" into ub-camera...
Puneet Lall [Tue, 16 Sep 2014 08:21:16 +0000 (08:21 +0000)]
am 6f1dfe69: Merge "Don\'t set mCameraAppUI to null in onDestroy" into ub-camera-glacier

* commit '6f1dfe69b93bfb42c11d456901e9d3ffee826cce':
  Don't set mCameraAppUI to null in onDestroy

9 years agoMerge "Don't set mCameraAppUI to null in onDestroy" into ub-camera-glacier
Puneet Lall [Mon, 15 Sep 2014 21:41:55 +0000 (21:41 +0000)]
Merge "Don't set mCameraAppUI to null in onDestroy" into ub-camera-glacier

9 years agoDon't set mCameraAppUI to null in onDestroy
Puneet Lall [Mon, 15 Sep 2014 18:29:59 +0000 (11:29 -0700)]
Don't set mCameraAppUI to null in onDestroy

BUG: 17408047

Note that we originally set this to null to address BUG: 12805279
which involved leaking Views.  However, this has regressed and will
require another look regardless.  The number of views leaked
with and without the null assignment is the same, so this change
does not make the regression any worse.

Change-Id: If90aeebb081073eb4f5b928919fc67ef710e1054

9 years agoam a16219d5: set proper alpha on shutter button on mode switch, eliminates a janky...
Spike Sprague [Mon, 15 Sep 2014 19:26:53 +0000 (19:26 +0000)]
am a16219d5: set proper alpha on shutter button on mode switch, eliminates a janky alpha flash

* commit 'a16219d51937bda5f3e69c0e77171ae0fb893823':
  set proper alpha on shutter button on mode switch, eliminates a janky alpha flash

9 years agoImport translations. DO NOT MERGE
Baligh Uddin [Mon, 15 Sep 2014 06:11:10 +0000 (23:11 -0700)]
Import translations. DO NOT MERGE

Change-Id: I7ec96a5d9c1e761e23af43c5b61dd537e1577346
Auto-generated-cl: translation import

9 years agoset proper alpha on shutter button on mode switch,
Spike Sprague [Fri, 12 Sep 2014 22:01:04 +0000 (15:01 -0700)]
set proper alpha on shutter button on mode switch,
eliminates a janky alpha flash

bug: 17487040

Change-Id: I08e66b5be53e58e9e16d32c09ef50081e90e9284

9 years agoam 70a96525: Don\'t send redundant requests to start the preview
Puneet Lall [Fri, 12 Sep 2014 18:02:34 +0000 (18:02 +0000)]
am 70a96525: Don\'t send redundant requests to start the preview

* commit '70a96525f16ca6c6abb9a7a9dab26ba1e61235dd':
  Don't send redundant requests to start the preview

9 years agoDon't send redundant requests to start the preview
Puneet Lall [Fri, 12 Sep 2014 00:33:21 +0000 (17:33 -0700)]
Don't send redundant requests to start the preview

Change-Id: I43d8a2917bbe0140f1e9367cce21f68b19807aa8

9 years agoam 486ba1da: Revert layout change for Camera
Alan Newberger [Fri, 12 Sep 2014 01:46:46 +0000 (01:46 +0000)]
am 486ba1da: Revert layout change for Camera

* commit '486ba1da145f70b07235617e5f1f64186daa0fc0':
  Revert layout change for Camera

9 years agoam ca5173d8: Move launcher icons to mipmap
Alan Newberger [Fri, 12 Sep 2014 01:46:44 +0000 (01:46 +0000)]
am ca5173d8: Move launcher icons to mipmap

* commit 'ca5173d84722383d2d9ef49dd85fba28af035429':
  Move launcher icons to mipmap

9 years agoRevert layout change for Camera
Alan Newberger [Thu, 11 Sep 2014 23:29:20 +0000 (16:29 -0700)]
Revert layout change for Camera

Changing from LAYOUT_FULLSCREEN to FULLSCREEN interferes with layout of
Action Bar.

Bug: 17477202
Change-Id: I029a84adbe4c5017cc8185c5c0c2601a03196bde

9 years agoMove launcher icons to mipmap
Alan Newberger [Thu, 11 Sep 2014 21:39:22 +0000 (14:39 -0700)]
Move launcher icons to mipmap

Bug: 17457682
Change-Id: I6a626c8547f3eea8a06fc47fc70c1a587767b040

9 years agoam 45f316bc: Establish synchronous camera closing when app utilizes API1/API2
Alan Newberger [Thu, 11 Sep 2014 17:51:52 +0000 (17:51 +0000)]
am 45f316bc: Establish synchronous camera closing when app utilizes API1/API2

* commit '45f316bcecb8713cbb217507981fd657fcdaa274':
  Establish synchronous camera closing when app utilizes API1/API2

9 years agoEstablish synchronous camera closing when app utilizes API1/API2
Alan Newberger [Thu, 11 Sep 2014 17:25:54 +0000 (10:25 -0700)]
Establish synchronous camera closing when app utilizes API1/API2

To ensure API1 and API2 portability implementations coordinate together,
if app uses API2 for any mode, lock both modes into synchronouse camera
closing.

Bug: 17464089
Change-Id: If4cf1eb02053ec9e56b7b8df97c21e012467aa3a

9 years agoam 0c5fc1d3: (-s ours) Merge "Import translations. DO NOT MERGE" into ub-camera-glacier
Baligh Uddin [Thu, 11 Sep 2014 15:58:23 +0000 (15:58 +0000)]
am 0c5fc1d3: (-s ours) Merge "Import translations. DO NOT MERGE" into ub-camera-glacier

* commit '0c5fc1d311eaa82dff09cee6332140fda21d473e':
  Import translations. DO NOT MERGE

9 years agoMerge "Import translations. DO NOT MERGE" into lmp-dev
Baligh Uddin [Thu, 11 Sep 2014 15:49:05 +0000 (15:49 +0000)]
Merge "Import translations. DO NOT MERGE" into lmp-dev

9 years agoMerge "Import translations. DO NOT MERGE" into ub-camera-glacier
Baligh Uddin [Thu, 11 Sep 2014 15:48:57 +0000 (15:48 +0000)]
Merge "Import translations. DO NOT MERGE" into ub-camera-glacier

9 years agoam e6ebf3d7: If we are using CaptureModule for Gcam only, turn off flash.
Andy Huibers [Thu, 11 Sep 2014 04:37:47 +0000 (04:37 +0000)]
am e6ebf3d7: If we are using CaptureModule for Gcam only, turn off flash.

* commit 'e6ebf3d73bb3f337413bdde437fbb8fde6cee436':
  If we are using CaptureModule for Gcam only, turn off flash.

9 years agoIf we are using CaptureModule for Gcam only, turn off flash.
Andy Huibers [Thu, 11 Sep 2014 04:08:56 +0000 (21:08 -0700)]
If we are using CaptureModule for Gcam only, turn off flash.

Bug: 17460394

Change-Id: I4743e9c31f516d12537b2ceedc9e1fe35fbd8381

9 years agoam 0c9af933: Merge "Revert "Delay PhotoModule preview cover removal to address jank...
Alan Newberger [Thu, 11 Sep 2014 01:37:45 +0000 (01:37 +0000)]
am 0c9af933: Merge "Revert "Delay PhotoModule preview cover removal to address jank"" into ub-camera-glacier

* commit '0c9af933b7227577003f462ddab12a1ca49208fe':
  Revert "Delay PhotoModule preview cover removal to address jank"

9 years agoMerge "Revert "Delay PhotoModule preview cover removal to address jank"" into ub...
Alan Newberger [Thu, 11 Sep 2014 01:26:18 +0000 (01:26 +0000)]
Merge "Revert "Delay PhotoModule preview cover removal to address jank"" into ub-camera-glacier

9 years agoRevert "Delay PhotoModule preview cover removal to address jank"
Alan Newberger [Thu, 11 Sep 2014 01:26:01 +0000 (01:26 +0000)]
Revert "Delay PhotoModule preview cover removal to address jank"

This CL introduced PhotoModule state corruption, multiple picture taking was not possible. Need to deal with stopPreview during picture taking vs module initialization.

Bug: 17451185

This reverts commit 49fb93b5517e12606eb747f0a5d218b4d03df821.

Change-Id: I0a1eec8147ce859d2e83ee7bdd17655b4054f904

9 years agoam 7351415d: Reset aspect ratio on pause
Alan Newberger [Thu, 11 Sep 2014 00:33:48 +0000 (00:33 +0000)]
am 7351415d: Reset aspect ratio on pause

* commit '7351415ddfaf7f563a4a12c9204e6feb20fdf49d':
  Reset aspect ratio on pause

9 years agoReset aspect ratio on pause
Alan Newberger [Wed, 10 Sep 2014 22:03:27 +0000 (15:03 -0700)]
Reset aspect ratio on pause

When resuming the app we do resize things but the old aspect
ratio is cached, thus skipping a reset of the transform matrices
because the app thinks it is already at the correct aspect ratio.
In certain cases (changing orientation when paused) this leads to
layout bugs.

Bug: 17304671
Change-Id: Ia171190b3c76dc05519bdf4d1947d9664d5fb604

9 years agoam 87a2300f: Merge "workaround fix" into ub-camera-glacier
Spike Sprague [Wed, 10 Sep 2014 23:14:50 +0000 (23:14 +0000)]
am 87a2300f: Merge "workaround fix" into ub-camera-glacier

* commit '87a2300ff2b49b8bd6a69815d1e4f3db477fcf4d':
  workaround fix

9 years agoMerge "workaround fix" into ub-camera-glacier
Spike Sprague [Wed, 10 Sep 2014 23:07:48 +0000 (23:07 +0000)]
Merge "workaround fix" into ub-camera-glacier

9 years agoam 3096e672: Merge "Delay PhotoModule preview cover removal to address jank" into...
Alan Newberger [Wed, 10 Sep 2014 22:58:30 +0000 (22:58 +0000)]
am 3096e672: Merge "Delay PhotoModule preview cover removal to address jank" into ub-camera-glacier

* commit '3096e6729b72a47ee3ed0a68a455bc978036de5c':
  Delay PhotoModule preview cover removal to address jank

9 years agoMerge "Delay PhotoModule preview cover removal to address jank" into ub-camera-glacier
Alan Newberger [Wed, 10 Sep 2014 22:53:06 +0000 (22:53 +0000)]
Merge "Delay PhotoModule preview cover removal to address jank" into ub-camera-glacier

9 years agoDelay PhotoModule preview cover removal to address jank
Alan Newberger [Wed, 10 Sep 2014 22:44:01 +0000 (15:44 -0700)]
Delay PhotoModule preview cover removal to address jank

Cover should stay in place at least until startPreview completes.
Since it is async, we should call handlers in a callback.

Bug: 17451185
Change-Id: I220c49b9bb75ad977d92780c6eea0ff126a7dcb8

9 years agoam d3ee86b7: Merge "Return to filmstrip when video playback finishes." into ub-camera...
Senpo Hu [Wed, 10 Sep 2014 22:17:02 +0000 (22:17 +0000)]
am d3ee86b7: Merge "Return to filmstrip when video playback finishes." into ub-camera-glacier

* commit 'd3ee86b7c1f1973119619f8e1b356d9707dd0493':
  Return to filmstrip when video playback finishes.

9 years agoworkaround fix
Spike Sprague [Wed, 10 Sep 2014 18:31:09 +0000 (11:31 -0700)]
workaround fix

change View.SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN to View.SYSTEM_UI_FLAG_FULLSCREEN

on L, with View.SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN the entire camera app window is shifted down by the height of the status bar.

with View.SYSTEM_UI_FLAG_FULLSCREEN thw window lays out correctly.

note: with either flag on KitKat the window lays out correctly.

bug: 17457492

Change-Id: I6534fcedaafbbb525967289db7fb759ba50fca42

9 years agoMerge "Return to filmstrip when video playback finishes." into ub-camera-glacier
Senpo Hu [Wed, 10 Sep 2014 22:11:15 +0000 (22:11 +0000)]
Merge "Return to filmstrip when video playback finishes." into ub-camera-glacier

9 years agoReturn to filmstrip when video playback finishes.
Senpo Hu [Wed, 10 Sep 2014 21:43:16 +0000 (14:43 -0700)]
Return to filmstrip when video playback finishes.

Bug: 17091348
Change-Id: I9703d014029bf29431b099b129b1ed8bce0ffa03

9 years agoam 5675b8af: Fix the upside-down orienation bug in CaptureModule.
Senpo Hu [Wed, 10 Sep 2014 21:43:30 +0000 (21:43 +0000)]
am 5675b8af: Fix the upside-down orienation bug in CaptureModule.

* commit '5675b8af3fddca8d73d0ce0c8aa2f2a38592f556':
  Fix the upside-down orienation bug in CaptureModule.

9 years agoam d79b38d6: Merge "Remove jank on camera options switching" into ub-camera-glacier
Alan Newberger [Wed, 10 Sep 2014 21:21:08 +0000 (21:21 +0000)]
am d79b38d6: Merge "Remove jank on camera options switching" into ub-camera-glacier

* commit 'd79b38d669e9e61a954b02f3aca63810476f6fc5':
  Remove jank on camera options switching

9 years agoFix the upside-down orienation bug in CaptureModule.
Senpo Hu [Wed, 10 Sep 2014 21:15:00 +0000 (14:15 -0700)]
Fix the upside-down orienation bug in CaptureModule.

Bug: 17369697
Change-Id: I5beb0ec45f2dbf372dda88ffd8a92b1632b3ab90

9 years agoMerge "Remove jank on camera options switching" into ub-camera-glacier
Alan Newberger [Wed, 10 Sep 2014 21:13:54 +0000 (21:13 +0000)]
Merge "Remove jank on camera options switching" into ub-camera-glacier

9 years agoam 9cefdd49: Changed double to float. viewFinder -> viewfinder.
Jiawen Chen [Wed, 10 Sep 2014 21:10:45 +0000 (21:10 +0000)]
am 9cefdd49: Changed double to float. viewFinder -> viewfinder.

* commit '9cefdd495332719d987ffb942742ec602793d8d4':
  Changed double to float. viewFinder -> viewfinder.

9 years agoChanged double to float. viewFinder -> viewfinder.
Jiawen Chen [Tue, 9 Sep 2014 21:14:39 +0000 (14:14 -0700)]
Changed double to float. viewFinder -> viewfinder.

Change-Id: I5f10a5e8dae40f56457b863d5e8c703e7bf68e49

9 years agoam ffc395d6: Reinitialize shutter button in Camera mode upon preview start
Alan Newberger [Wed, 10 Sep 2014 20:32:05 +0000 (20:32 +0000)]
am ffc395d6: Reinitialize shutter button in Camera mode upon preview start

* commit 'ffc395d6e7eaafcdcd283e183188de16aa14aa4c':
  Reinitialize shutter button in Camera mode upon preview start

9 years agoReinitialize shutter button in Camera mode upon preview start
Alan Newberger [Wed, 10 Sep 2014 20:07:18 +0000 (13:07 -0700)]
Reinitialize shutter button in Camera mode upon preview start

VideoModule already does this here, and by adding to PhotoModule we
address a bug where pausing when capturing leaves the button
disabled on resume.

Bug: 17426670
Change-Id: I8333b52a72c0da8b58070d689406975332ae632e

9 years agoam 5c4bd6b5: Reduce logging for unknown camera scope
Alan Newberger [Wed, 10 Sep 2014 18:32:48 +0000 (18:32 +0000)]
am 5c4bd6b5: Reduce logging for unknown camera scope

* commit '5c4bd6b5348a3464783270ea0bb10d4968d3b0cb':
  Reduce logging for unknown camera scope

9 years agoReduce logging for unknown camera scope
Alan Newberger [Wed, 10 Sep 2014 18:22:19 +0000 (11:22 -0700)]
Reduce logging for unknown camera scope

Still log a warning, but remove stack trace logging.

Change-Id: I28e47feb5d2700fd05e7ff4e6faeb1d5a9e38de5

9 years agoam a710f371: Merge "This fixes Bitmap.createBitmap offset bug in L, not sure why...
Andy Huibers [Wed, 10 Sep 2014 17:08:50 +0000 (17:08 +0000)]
am a710f371: Merge "This fixes Bitmap.createBitmap offset bug in L, not sure why." into ub-camera-glacier

* commit 'a710f371b8e454d37b8b2be50e001b79e37c67f2':
  This fixes Bitmap.createBitmap offset bug in L, not sure why.

9 years agoMerge "This fixes Bitmap.createBitmap offset bug in L, not sure why." into ub-camera...
Andy Huibers [Wed, 10 Sep 2014 15:55:10 +0000 (15:55 +0000)]
Merge "This fixes Bitmap.createBitmap offset bug in L, not sure why." into ub-camera-glacier

9 years agoam fd97c6da: (-s ours) Merge "DO NOT MERGE: Adjust for camera2 API changes" into...
Qiwen Zhao [Wed, 10 Sep 2014 15:29:28 +0000 (15:29 +0000)]
am fd97c6da: (-s ours) Merge "DO NOT MERGE: Adjust for camera2 API changes" into ub-camera-glacier

* commit 'fd97c6da954f3e3e6f8547f6f7363cddba6c1b9a':
  DO NOT MERGE: Adjust for camera2 API changes

9 years agoMerge "DO NOT MERGE: Adjust for camera2 API changes" into ub-camera-glacier
Qiwen Zhao [Wed, 10 Sep 2014 15:20:46 +0000 (15:20 +0000)]
Merge "DO NOT MERGE: Adjust for camera2 API changes" into ub-camera-glacier

9 years agoam 42a5ad5a: Merge "Granting read permission in the result intent for VIDEO_CAPTURE...
Nicolas Prevot [Wed, 10 Sep 2014 09:50:44 +0000 (09:50 +0000)]
am 42a5ad5a: Merge "Granting read permission in the result intent for VIDEO_CAPTURE." into ub-camera-glacier

* commit '42a5ad5a9c7e660854fd0552b81e025c16db9f05':
  Granting read permission in the result intent for VIDEO_CAPTURE.

9 years agoMerge "Granting read permission in the result intent for VIDEO_CAPTURE." into ub...
Nicolas Prevot [Wed, 10 Sep 2014 09:42:35 +0000 (09:42 +0000)]
Merge "Granting read permission in the result intent for VIDEO_CAPTURE." into ub-camera-glacier

9 years agoam 5e3bf4cc: Remove toast. This reverts commit 779414e8bfe23d66de310570ff2314654e45ec9f.
Andy Huibers [Wed, 10 Sep 2014 06:57:12 +0000 (06:57 +0000)]
am 5e3bf4cc: Remove toast. This reverts commit 779414e8bfe23d66de310570ff2314654e45ec9f.

* commit '5e3bf4cc84a186c5e89dfa692f3af95007751877':
  Remove toast. This reverts commit 779414e8bfe23d66de310570ff2314654e45ec9f.

9 years agoRemove jank on camera options switching
Alan Newberger [Wed, 10 Sep 2014 01:47:37 +0000 (18:47 -0700)]
Remove jank on camera options switching

There are two main causes of jank on encountered on options switching:

1. When requesting camera in requestCamera, a portability refactor
introduced a regression where we blocked in the main thread to close
the camera. This main thread blockage is unacceptable as it caused a
preview freeze in addition to the freeze we were trying to create during
the switch, leading to a two-frame preview freeze.

2. The mode options animations which delay the button state transition,
also resulted in preview stutters. Unsure of cause but reverting first
and will assess fixes and reintroduce.

Bug: 17414652
Change-Id: Ib72e331f1bbb5d3b608d8bdc5656c2ff2836ed42

9 years agoRemove toast.
Andy Huibers [Wed, 10 Sep 2014 01:45:28 +0000 (18:45 -0700)]
Remove toast.
This reverts commit 779414e8bfe23d66de310570ff2314654e45ec9f.

Change-Id: Idf04e0bbb69822792327fd17634a4f95f7eb2092

9 years agoam b954b3e8: Merge "Always match camera orientation with device orientation regardles...
Senpo Hu [Wed, 10 Sep 2014 00:27:59 +0000 (00:27 +0000)]
am b954b3e8: Merge "Always match camera orientation with device orientation regardless portrait lock." into ub-camera-glacier

* commit 'b954b3e8b9fff8adf82808bd6cac1f9a7ac9505a':
  Always match camera orientation with device orientation regardless portrait lock.

9 years agoMerge "Always match camera orientation with device orientation regardless portrait...
Senpo Hu [Wed, 10 Sep 2014 00:22:10 +0000 (00:22 +0000)]
Merge "Always match camera orientation with device orientation regardless portrait lock." into ub-camera-glacier

9 years agoam 65c00136: Set video quality pref default values at startup.
Senpo Hu [Wed, 10 Sep 2014 00:21:40 +0000 (00:21 +0000)]
am 65c00136: Set video quality pref default values at startup.

* commit '65c00136cde07e050d05e3da61876199df90dd18':
  Set video quality pref default values at startup.

9 years agoSet video quality pref default values at startup.
Senpo Hu [Tue, 9 Sep 2014 20:51:25 +0000 (13:51 -0700)]
Set video quality pref default values at startup.

The problem of the old approach is the default values never got set
until switching on video module.

The caveat of the this CL is that the default value tweak is only applied
for Shamu. Rather than basing on device model string, detecting
CamcorderProfile capability is a better way to get this job done. However,
|CamcorderProfile.hasProfile| needs camera id info so I'd argue this CL
is good enough for the Shamu/L release.

Bug: 17060480
Change-Id: Ia53ff6aecad44fe7a32257fa1415163f167c09bf

9 years agoAlways match camera orientation with device orientation regardless
Senpo Hu [Mon, 8 Sep 2014 08:07:27 +0000 (01:07 -0700)]
Always match camera orientation with device orientation regardless
portrait lock.

Verified that this CL fixes the orientation issue for portrait/landscape
photos taken in PhotoModule with all configuration combinations such as
Camera API1/API2 devices, K/L devices, front/back camera.

Bug: 17360176
Change-Id: If84244726cf7e2ade470c231b8ac16e9b80366fe

9 years agoMerge "Adjust for camera2 API changes" into lmp-dev
Eino-Ville Talvala [Tue, 9 Sep 2014 22:21:07 +0000 (22:21 +0000)]
Merge "Adjust for camera2 API changes" into lmp-dev

9 years agoThis fixes Bitmap.createBitmap offset bug in L, not sure why.
Andy Huibers [Tue, 9 Sep 2014 19:52:29 +0000 (12:52 -0700)]
This fixes Bitmap.createBitmap offset bug in L, not sure why.

Bug: 17145703
Change-Id: I18a673a5cac4400a2d6e80a851b1fb12381dc995

9 years agoGranting read permission in the result intent for VIDEO_CAPTURE.
Nicolas Prevot [Tue, 9 Sep 2014 19:35:56 +0000 (20:35 +0100)]
Granting read permission in the result intent for VIDEO_CAPTURE.

BUG:17437266
Change-Id: I84d1a69a3d314a05a7e3b5c949c896700426644e

9 years agoDO NOT MERGE: Adjust for camera2 API changes
Eino-Ville Talvala [Mon, 8 Sep 2014 22:13:16 +0000 (15:13 -0700)]
DO NOT MERGE: Adjust for camera2 API changes

Add frameNumber to CaptureCallback#onCaptureStarted

Bug: 17421092
Change-Id: I6e66bd1abc2ecec4dd8346cf4313dc7261ffa26b