OSDN Git Service
Christopher Dombroski [Wed, 8 May 2019 02:13:32 +0000 (19:13 -0700)]
OP_REQUEST_INSTALL_PACKAGES denied by default
am:
43e682abef
Change-Id: I13fd6fc7ba432a2cde1e8dbbc7b206e8203374f8
Christopher Dombroski [Tue, 16 Apr 2019 20:21:39 +0000 (13:21 -0700)]
OP_REQUEST_INSTALL_PACKAGES denied by default
Some system apps may download unknown content and the user should
be explicitly asked whether they trust these files. System apps should
explicitly use the extra NOT_UNKNOWN_SOURCE to bypass this check.
Test: Builds, boots, existing tests pass:
atest CtsPackageInstallTestCases
Locally verified they pass if CtsPackageInstallTestCases.apk was signed by
the platform cert.
Bug:
123700348
Change-Id: I3028bf8ff3f79a41521deeee43fba3c32bb1b2ca
Merged-In: I2578251906f6656b83464d1c4fc4db99165841c9
Eran Messeri [Thu, 11 Apr 2019 00:35:21 +0000 (17:35 -0700)]
Merge changes from topic "am-
09249f80-e618-46fc-ac06-
c7fdc73c36ae" into oc-dev
am:
07a485743a
Change-Id: I0ba4a71037e5bac19a540320665446b55b7aafb6
Julia Reynolds [Thu, 11 Apr 2019 00:19:16 +0000 (17:19 -0700)]
Merge "[RESTRICT_AUTOMERGE]: Add cross user permission check - areNotificationsEnabledForPackage" into oc-dev
am:
2256fd4e11
Change-Id: I1658f2dc59428265adf385ec2e9c579abbefb023
Julia Reynolds [Wed, 10 Apr 2019 23:56:01 +0000 (16:56 -0700)]
Merge changes from topic "am-
3ca7326a-cbf1-4f97-a1b5-
a4fdfac0fb47" into oc-dev
am:
652a666500
Change-Id: I4e93c29d4d65d14d39b683a27004f871b1dd0b9a
Pavel Grafov [Wed, 10 Apr 2019 23:41:27 +0000 (16:41 -0700)]
[automerger] Limit IsSeparateProfileChallengeAllowed to system callers am:
9061fcc46b am:
39f5432697 am:
9c0bc5405e am:
55209aca88 am:
d5ce9a41b6
am:
20007cb46f
Change-Id: I3bf88bf3a830dc7dea61e32d1df31b273a5d1afe
TreeHugger Robot [Wed, 10 Apr 2019 23:26:00 +0000 (23:26 +0000)]
Merge changes from topic "am-
09249f80-e618-46fc-ac06-
c7fdc73c36ae" into oc-dev
* changes:
[automerger] Permission Check For DPM.getPermittedAccessibilityServices am:
4fd13eefcf am:
39eef269be am:
5d66886b4c am:
75b579135c am:
0f19d41748
[automerger] Permission Check For DPM.getPermittedAccessibilityServices am:
4fd13eefcf am:
39eef269be am:
5d66886b4c am:
75b579135c
[automerger] Permission Check For DPM.getPermittedAccessibilityServices am:
4fd13eefcf am:
39eef269be am:
5d66886b4c
[automerger] Permission Check For DPM.getPermittedAccessibilityServices am:
4fd13eefcf am:
39eef269be
[automerger] Permission Check For DPM.getPermittedAccessibilityServices am:
4fd13eefcf
Permission Check For DPM.getPermittedAccessibilityServices
TreeHugger Robot [Wed, 10 Apr 2019 22:59:44 +0000 (22:59 +0000)]
Merge "[RESTRICT_AUTOMERGE]: Add cross user permission check - areNotificationsEnabledForPackage" into oc-dev
TreeHugger Robot [Wed, 10 Apr 2019 22:20:55 +0000 (22:20 +0000)]
Merge changes from topic "am-
3ca7326a-cbf1-4f97-a1b5-
a4fdfac0fb47" into oc-dev
* changes:
[automerger] [RESTRICT AUTOMERGE]: Add cross user permission check - areNotificationsEnabledForPackage am:
a2b2e377a0 am:
00121902b0 am:
777c45416e am:
0bf87880d8 skipped:
9f3fca716a
[automerger] [RESTRICT AUTOMERGE]: Add cross user permission check - areNotificationsEnabledForPackage am:
a2b2e377a0 am:
00121902b0 am:
777c45416e am:
0bf87880d8
[automerger] [RESTRICT AUTOMERGE]: Add cross user permission check - areNotificationsEnabledForPackage am:
a2b2e377a0 am:
00121902b0 am:
777c45416e
[automerger] [RESTRICT AUTOMERGE]: Add cross user permission check - areNotificationsEnabledForPackage am:
a2b2e377a0 am:
00121902b0
[automerger] [RESTRICT AUTOMERGE]: Add cross user permission check - areNotificationsEnabledForPackage am:
a2b2e377a0
[RESTRICT AUTOMERGE]: Add cross user permission check - areNotificationsEnabledForPackage
Julia Reynolds [Wed, 27 Mar 2019 16:15:57 +0000 (12:15 -0400)]
[RESTRICT_AUTOMERGE]: Add cross user permission check - areNotificationsEnabledForPackage
Test: atest
Fixes:
128599467
Change-Id: I13a0ca7590f8c4b44379730e0ee2088aba400c2a
(cherry picked from commit
657d164136199126ae241848887de0230699cea0)
Android Build Merger (Role) [Wed, 10 Apr 2019 12:44:06 +0000 (12:44 +0000)]
[automerger] Limit IsSeparateProfileChallengeAllowed to system callers am:
9061fcc46b am:
39f5432697 am:
9c0bc5405e am:
55209aca88 am:
d5ce9a41b6
Change-Id: I9f9adc6f9979b3ee946e43150556f0ba971a67f8
Android Build Merger (Role) [Wed, 10 Apr 2019 12:44:01 +0000 (12:44 +0000)]
[automerger] Limit IsSeparateProfileChallengeAllowed to system callers am:
9061fcc46b am:
39f5432697 am:
9c0bc5405e am:
55209aca88
Change-Id: I9f56349020376c4cb459597bf01cb4956344f7a8
Android Build Merger (Role) [Wed, 10 Apr 2019 12:43:56 +0000 (12:43 +0000)]
[automerger] Limit IsSeparateProfileChallengeAllowed to system callers am:
9061fcc46b am:
39f5432697 am:
9c0bc5405e
Change-Id: If32bb0948a2b9aa67b99ceae0ed9234f570198bf
Android Build Merger (Role) [Wed, 10 Apr 2019 12:43:51 +0000 (12:43 +0000)]
[automerger] Limit IsSeparateProfileChallengeAllowed to system callers am:
9061fcc46b am:
39f5432697
Change-Id: I064e17eb9e4a91cbf8cda5fe6ee37da48724634d
Android Build Merger (Role) [Wed, 10 Apr 2019 12:43:44 +0000 (12:43 +0000)]
[automerger] Limit IsSeparateProfileChallengeAllowed to system callers am:
9061fcc46b
Change-Id: Ia35b381b55199cc0c3b516ccc5091993a2c3d488
Pavel Grafov [Wed, 10 Apr 2019 11:47:25 +0000 (12:47 +0100)]
Limit IsSeparateProfileChallengeAllowed to system callers
Fixes:
128599668
Test: build, set up separate challenge
Merged-In: I2fef9ab13614627c0f1bcca04759d0974fc6181a
Change-Id: I2fef9ab13614627c0f1bcca04759d0974fc6181a
Android Build Merger (Role) [Tue, 9 Apr 2019 22:29:07 +0000 (22:29 +0000)]
[automerger] [RESTRICT AUTOMERGE]: Add cross user permission check - areNotificationsEnabledForPackage am:
a2b2e377a0 am:
00121902b0 am:
777c45416e am:
0bf87880d8 skipped:
9f3fca716a
Change-Id: I0dd61347ddd16574c9bb4f301725da09d88e737d
Android Build Merger (Role) [Tue, 9 Apr 2019 22:29:04 +0000 (22:29 +0000)]
[automerger] [RESTRICT AUTOMERGE]: Add cross user permission check - areNotificationsEnabledForPackage am:
a2b2e377a0 am:
00121902b0 am:
777c45416e am:
0bf87880d8
Change-Id: If90b329955ca2514e6c236932614648670d440ea
Android Build Merger (Role) [Tue, 9 Apr 2019 22:28:44 +0000 (22:28 +0000)]
[automerger] [RESTRICT AUTOMERGE]: Add cross user permission check - areNotificationsEnabledForPackage am:
a2b2e377a0 am:
00121902b0 am:
777c45416e
Change-Id: Ic6d7bf16ab67d441e77f003288129671c2ec327d
Android Build Merger (Role) [Tue, 9 Apr 2019 22:28:40 +0000 (22:28 +0000)]
[automerger] [RESTRICT AUTOMERGE]: Add cross user permission check - areNotificationsEnabledForPackage am:
a2b2e377a0 am:
00121902b0
Change-Id: I362a9976890358467b16f07315295b17d767b9b1
Android Build Merger (Role) [Tue, 9 Apr 2019 22:28:33 +0000 (22:28 +0000)]
[automerger] [RESTRICT AUTOMERGE]: Add cross user permission check - areNotificationsEnabledForPackage am:
a2b2e377a0
Change-Id: Ic1d3439eb787c393d0f595d04c7627345118474d
Julia Reynolds [Wed, 27 Mar 2019 16:15:57 +0000 (12:15 -0400)]
[RESTRICT AUTOMERGE]: Add cross user permission check - areNotificationsEnabledForPackage
Test: atest
Fixes:
128599467
Change-Id: I13a0ca7590f8c4b44379730e0ee2088aba400c2a
(cherry picked from commit
657d164136199126ae241848887de0230699cea0)
Bryan Ferris [Tue, 9 Apr 2019 20:20:18 +0000 (13:20 -0700)]
Merge changes from topic "am-
e391c592-eeb3-4cc9-85fd-
fa5d3bf694c5" into oc-dev
am:
2833e406e0
Change-Id: Iad49fea0efffc9766797f590b9140cb4bb73a3fd
Bryan Ferris [Tue, 9 Apr 2019 19:46:49 +0000 (19:46 +0000)]
Merge changes from topic "am-
e391c592-eeb3-4cc9-85fd-
fa5d3bf694c5" into oc-dev
* changes:
[automerger] [RESTRICT AUTOMERGE] Added missing permission check to isPackageDeviceAdminOnAnyUser. am:
7b5a576965 am:
0494ac6568 am:
70b534799b am:
49a505f4f9 skipped:
022bfaa808
[automerger] [RESTRICT AUTOMERGE] Added missing permission check to isPackageDeviceAdminOnAnyUser. am:
7b5a576965 am:
0494ac6568 am:
70b534799b am:
49a505f4f9
[automerger] [RESTRICT AUTOMERGE] Added missing permission check to isPackageDeviceAdminOnAnyUser. am:
7b5a576965 am:
0494ac6568 am:
70b534799b
[automerger] [RESTRICT AUTOMERGE] Added missing permission check to isPackageDeviceAdminOnAnyUser. am:
7b5a576965 am:
0494ac6568
[automerger] [RESTRICT AUTOMERGE] Added missing permission check to isPackageDeviceAdminOnAnyUser. am:
7b5a576965
[RESTRICT AUTOMERGE] Added missing permission check to isPackageDeviceAdminOnAnyUser.
Varun Shah [Tue, 9 Apr 2019 19:12:19 +0000 (12:12 -0700)]
Added missing permission check to isPackageDeviceAdminOnAnyUser.
am:
18e7dedf6c
Change-Id: I3cd02487a2f39775e86c22ed12fb0fae45198ba4
Android Build Merger (Role) [Thu, 4 Apr 2019 22:24:47 +0000 (22:24 +0000)]
[automerger] [RESTRICT AUTOMERGE] Added missing permission check to isPackageDeviceAdminOnAnyUser. am:
7b5a576965 am:
0494ac6568 am:
70b534799b am:
49a505f4f9 skipped:
022bfaa808
Change-Id: I3bf41e099ceca0d122df82cf2f8a18d3ec8b3808
Android Build Merger (Role) [Thu, 4 Apr 2019 22:24:42 +0000 (22:24 +0000)]
[automerger] [RESTRICT AUTOMERGE] Added missing permission check to isPackageDeviceAdminOnAnyUser. am:
7b5a576965 am:
0494ac6568 am:
70b534799b am:
49a505f4f9
Change-Id: I0af65577fac55fce95549a27dc3ecf00b94d20ff
Android Build Merger (Role) [Thu, 4 Apr 2019 22:24:37 +0000 (22:24 +0000)]
[automerger] [RESTRICT AUTOMERGE] Added missing permission check to isPackageDeviceAdminOnAnyUser. am:
7b5a576965 am:
0494ac6568 am:
70b534799b
Change-Id: I172642a771dcafa2d106886984cba3de7a87ae03
Android Build Merger (Role) [Thu, 4 Apr 2019 22:24:32 +0000 (22:24 +0000)]
[automerger] [RESTRICT AUTOMERGE] Added missing permission check to isPackageDeviceAdminOnAnyUser. am:
7b5a576965 am:
0494ac6568
Change-Id: Ib3786714238c868448bc448408a854907052ae2d
Android Build Merger (Role) [Thu, 4 Apr 2019 22:24:26 +0000 (22:24 +0000)]
[automerger] [RESTRICT AUTOMERGE] Added missing permission check to isPackageDeviceAdminOnAnyUser. am:
7b5a576965
Change-Id: I6d0a4a82a74b78b156b877e0d0785de16cac3856
Bryan Ferris [Thu, 4 Apr 2019 22:18:52 +0000 (15:18 -0700)]
[RESTRICT AUTOMERGE] Added missing permission check to isPackageDeviceAdminOnAnyUser.
Added a check for the MANAGE_USERS permission to
PackageManagerService#isPackageDeviceAdminOnAnyUser.
Test: Modify the settings app to log the call attempt and follow the
steps below
In order to work around the limitations of N builds we needed to modify
the settings app to log the call attempt. This is described in detail at
b/
128599183#comment15
Bug:
128599183
Change-Id: Ie96c8e174983f61574f12d5d4b210d06377054e5
Varun Shah [Wed, 20 Mar 2019 18:10:33 +0000 (11:10 -0700)]
Added missing permission check to isPackageDeviceAdminOnAnyUser.
Added a check for the MANAGE_USERS permission to
PackageManagerService#isPackageDeviceAdminOnAnyUser.
To test that the method is still usable:
1) Enable virtual storage via: adb shell sm set-virtual-disk true
2) Follow instructions by clicking on notification to set up virtual storage
3) Go to Settings -> Apps & notifications -> See all X apps
4) Click on any non-system app (example Instagram)
5) Tap Storage and you should see a "Change" button (if not, choose another app)
6) Tap Change and you should see Internal and Virtual storage options listed
7) The above step confirms the method is still usable by Settings
Bug:
128599183
Test: SafetyNet logging (steps listed above)
Change-Id: I989f1daf52a71f6c778ebd81baa6f1bf83e9a718
Merged-In: I36521fa43daab399e08869647326a7ac32d1e512
Android Build Merger (Role) [Tue, 26 Mar 2019 10:13:46 +0000 (10:13 +0000)]
[automerger] Permission Check For DPM.getPermittedAccessibilityServices am:
4fd13eefcf am:
39eef269be am:
5d66886b4c am:
75b579135c am:
0f19d41748
Change-Id: Idee49f5f8c935dda02d3a19c8b5680bed6d7de81
Android Build Merger (Role) [Tue, 26 Mar 2019 10:13:41 +0000 (10:13 +0000)]
[automerger] Permission Check For DPM.getPermittedAccessibilityServices am:
4fd13eefcf am:
39eef269be am:
5d66886b4c am:
75b579135c
Change-Id: I62d3f4b0d7f00b2f15003fa176d4758599dc2353
Android Build Merger (Role) [Tue, 26 Mar 2019 10:13:35 +0000 (10:13 +0000)]
[automerger] Permission Check For DPM.getPermittedAccessibilityServices am:
4fd13eefcf am:
39eef269be am:
5d66886b4c
Change-Id: Ia4146b009e593ddda10c5878432533b3192c27d6
Android Build Merger (Role) [Tue, 26 Mar 2019 10:13:29 +0000 (10:13 +0000)]
[automerger] Permission Check For DPM.getPermittedAccessibilityServices am:
4fd13eefcf am:
39eef269be
Change-Id: Ie52de123dc9e0587d16992f72e0794de69207b81
Android Build Merger (Role) [Tue, 26 Mar 2019 10:13:22 +0000 (10:13 +0000)]
[automerger] Permission Check For DPM.getPermittedAccessibilityServices am:
4fd13eefcf
Change-Id: I45ff5ff42ee294967ae7e03329338abd49c94df4
Eran Messeri [Mon, 25 Mar 2019 14:31:04 +0000 (14:31 +0000)]
Permission Check For DPM.getPermittedAccessibilityServices
Bug:
128599660
Test: com.android.server.devicepolicy.DevicePolicyManagerTest
Test: com.google.android.gts.devicepolicy.DeviceOwnerTest
Change-Id: I8be915bd6a4ff99884d23005a4c6f0100806dbe8
Merged-In: I8ee3f876fcaffa63636645f0f59709cd147254ef
Wyatt Riley [Mon, 4 Mar 2019 14:56:23 +0000 (06:56 -0800)]
Merge "DO NOT MERGE - SUPL ES Extension - Safer Init and Not After Boot" into oc-dev
am:
809231680f
Change-Id: If2f27dd775d4d5d543d23d10dcce10bc1bc4f51a
WyattRiley [Mon, 4 Mar 2019 14:51:02 +0000 (06:51 -0800)]
[automerger] DO NOT MERGE - SUPL ES Extension - Safer Init and Not After Boot am:
b5e7bbe5b8 am:
1bb102e37d am:
1c348395f5 am:
26fda93676 skipped:
cf76183e6c
am:
cf81345649
Change-Id: I8f2f2edaaa607378d75e3c852d0b8cedbc4fbb67
Wyatt Riley [Mon, 4 Mar 2019 14:29:06 +0000 (14:29 +0000)]
Merge "DO NOT MERGE - SUPL ES Extension - Safer Init and Not After Boot" into oc-dev
WyattRiley [Thu, 28 Feb 2019 19:43:12 +0000 (11:43 -0800)]
DO NOT MERGE - SUPL ES Extension - Safer Init and Not After Boot
Safe order of pointer setting and background thread start
Verifying mCallEndElapsedRealtimeMillis is not the initial value
Bug:
112159033
Bug:
115361555
Bug:
125124724
Test: Verified not-after-boot with test code b/
115361555#comment14
Test: Reproed NPE with test thread sleep and verify fix
Change-Id: Icd2ea91d71da71c8fda109ceb70514733d35060b
Android Build Merger (Role) [Fri, 1 Mar 2019 21:01:49 +0000 (21:01 +0000)]
[automerger] DO NOT MERGE - SUPL ES Extension - Safer Init and Not After Boot am:
b5e7bbe5b8 am:
1bb102e37d am:
1c348395f5 am:
26fda93676 skipped:
cf76183e6c
Change-Id: Ifd0a52ac469b9d59aa43b3849b5cfbabeac99ed5
Android Build Merger (Role) [Fri, 1 Mar 2019 21:01:39 +0000 (21:01 +0000)]
[automerger] DO NOT MERGE - SUPL ES Extension - Safer Init and Not After Boot am:
b5e7bbe5b8 am:
1bb102e37d am:
1c348395f5 am:
26fda93676
Change-Id: I87431bd661f6d5243d4c442e3caf6db247dc89bd
Android Build Merger (Role) [Fri, 1 Mar 2019 21:01:31 +0000 (21:01 +0000)]
[automerger] DO NOT MERGE - SUPL ES Extension - Safer Init and Not After Boot am:
b5e7bbe5b8 am:
1bb102e37d am:
1c348395f5
Change-Id: I5c7df1fd86ece1f84fba51250568a0d049b591f9
Android Build Merger (Role) [Fri, 1 Mar 2019 21:01:22 +0000 (21:01 +0000)]
[automerger] DO NOT MERGE - SUPL ES Extension - Safer Init and Not After Boot am:
b5e7bbe5b8 am:
1bb102e37d
Change-Id: I0499fab6407457adb226a0fef751e22c9566179f
Android Build Merger (Role) [Fri, 1 Mar 2019 21:01:11 +0000 (21:01 +0000)]
[automerger] DO NOT MERGE - SUPL ES Extension - Safer Init and Not After Boot am:
b5e7bbe5b8
Change-Id: I6a05a6ca8ad3313c901a2ad692851d2096b21e7b
WyattRiley [Tue, 19 Feb 2019 21:19:13 +0000 (13:19 -0800)]
DO NOT MERGE - SUPL ES Extension - Safer Init and Not After Boot
Safe order of pointer setting and background thread start
Verifying mCallEndElapsedRealtimeMillis is not the initial value
Bug:
112159033
Bug:
115361555
Bug:
125124724
Test: Verified not-after-boot with test code b/
115361555#comment14
Test: Reproed NPE on Nexus 5x with test thread sleep and verify fix
Change-Id: I596f913bc79873274c2743132c93ef2381d9f3c7
Abodunrinwa Toki [Fri, 8 Feb 2019 01:38:52 +0000 (17:38 -0800)]
[automerger skipped] DO NOT MERGE No smart text assist for unprovisioned device.
am:
7c8a46e0dd -s ours
am skip reason: change_id I360250a5c2a92d09c8d8f559b51c74f490f70c2c with SHA1
9796a1bd00 is in history
Change-Id: I431250313c81a1aee082503e3b39798ff4e5056e
Abodunrinwa Toki [Wed, 28 Jun 2017 01:49:07 +0000 (02:49 +0100)]
DO NOT MERGE No smart text assist for unprovisioned device.
Test: bit CtsViewTestCases:android.view.textclassifier.cts.TextClassificationManagerTest
bit FrameworksCoreTests:android.widget.TextViewActivityTest
bit FrameworksCoreTests:android.widget.TextViewActivityMoutseTest
Bug:
120866126
Bug:
62745625
Merged-In: I360250a5c2a92d09c8d8f559b51c74f490f70c2c
Change-Id: I360250a5c2a92d09c8d8f559b51c74f490f70c2c
Guliz Tuncay [Fri, 11 Jan 2019 00:21:07 +0000 (16:21 -0800)]
[automerger] Select only preinstalled Spell Checker Services am:
ed5973b8a8 am:
5ab7f995ba am:
d71a5db522 am:
276e18c147 am:
d962aabf4c
am:
3c2abaa4da
Change-Id: I2b4a8618280a602b4eb42db9bf822a14324b587f
Bryan Ferris [Fri, 11 Jan 2019 00:14:19 +0000 (16:14 -0800)]
[automerger] Revert "Select only preinstalled Spell Checker Services" am:
170e24d4e1 am:
fb3b187f10 am:
7abf49d3b7 am:
1684713f2e am:
cd6eba50ba
am:
576e4ac184
Change-Id: I304213f41d8b6f499d022f453392234ae901b36c
Android Build Merger (Role) [Thu, 10 Jan 2019 17:55:03 +0000 (17:55 +0000)]
[automerger] Select only preinstalled Spell Checker Services am:
ed5973b8a8 am:
5ab7f995ba am:
d71a5db522 am:
276e18c147 am:
d962aabf4c
Change-Id: I4fa4b56b1472ed6c25bc431ef9ce8060cb04a1f1
Android Build Merger (Role) [Thu, 10 Jan 2019 17:54:53 +0000 (17:54 +0000)]
[automerger] Select only preinstalled Spell Checker Services am:
ed5973b8a8 am:
5ab7f995ba am:
d71a5db522 am:
276e18c147
Change-Id: I2a8463e8e885a81229b28e7e99e7432a08a04c93
Android Build Merger (Role) [Thu, 10 Jan 2019 17:54:43 +0000 (17:54 +0000)]
[automerger] Select only preinstalled Spell Checker Services am:
ed5973b8a8 am:
5ab7f995ba am:
d71a5db522
Change-Id: I9e0504f59437cc8fd72e96630a6fb753a4cbb423
Android Build Merger (Role) [Thu, 10 Jan 2019 17:54:29 +0000 (17:54 +0000)]
[automerger] Select only preinstalled Spell Checker Services am:
ed5973b8a8 am:
5ab7f995ba
Change-Id: I51fbf27831b8b981a7b1a6e2af9cf46d8e544c12
Android Build Merger (Role) [Thu, 10 Jan 2019 17:54:16 +0000 (17:54 +0000)]
[automerger] Select only preinstalled Spell Checker Services am:
ed5973b8a8
Change-Id: I8da1dd728ff244a1363d9274aa3f41d1c6081ee8
Guliz Tuncay [Wed, 16 Aug 2017 19:02:31 +0000 (12:02 -0700)]
Select only preinstalled Spell Checker Services
When we are setting a new spell checker as the default one in
Secure.Settings, TSMS#findAvailSpellCheckerLocked can pick up
any available spell checker service. This violates the principle
that user should be warned whenever we are setting an untrusted
spell checker service as the default service, since the warning
dialog is never shown.
Fixes:
64764051
Bug:
118694079
Test: Manually as follows:
1. Open 'packages/inputmethods/LatinIME/java/AndroidManifest.xml'
and remove 'AndroidSpellCheckerService'
2. lunch aosp_buillhead-userdebug && make -j
3. Flash the image
4. adb shell dumpsys textservices
-> no spell checker is recognized
5. adb shell settings get secure selected_spell_checker
-> null
6. tapas SampleSpellCheckerService
7. make -j
8. adb install -r $OUT/system/app/SampleSpellCheckerService/SampleSpellCheckerService.apk
9. adb shell dumpsys textservices
-> SampleSpellCheckerService is recognized
10. adb shell settings get secure selected_spell_checker
-> null
Change-Id: I16f12293d15258c9148677c7ee09fe6dcf81e81d
Merged-In: Idab3ecc246fe9344a09e6907a0ba39f8ea6506f9
Android Build Merger (Role) [Thu, 10 Jan 2019 00:44:52 +0000 (00:44 +0000)]
[automerger] Revert "Select only preinstalled Spell Checker Services" am:
170e24d4e1 am:
fb3b187f10 am:
7abf49d3b7 am:
1684713f2e am:
cd6eba50ba
Change-Id: I9b15a7332565cc39eee4abb9faccb2d148281bf0
Android Build Merger (Role) [Thu, 10 Jan 2019 00:44:47 +0000 (00:44 +0000)]
[automerger] Revert "Select only preinstalled Spell Checker Services" am:
170e24d4e1 am:
fb3b187f10 am:
7abf49d3b7 am:
1684713f2e
Change-Id: Ib4cbddb955c57d2d59fb3b7fe656e21bc56266aa
Android Build Merger (Role) [Thu, 10 Jan 2019 00:44:41 +0000 (00:44 +0000)]
[automerger] Revert "Select only preinstalled Spell Checker Services" am:
170e24d4e1 am:
fb3b187f10 am:
7abf49d3b7
Change-Id: I019b36991306a8f7887b7a0b8233b2c9f1c9ed32
Android Build Merger (Role) [Thu, 10 Jan 2019 00:44:36 +0000 (00:44 +0000)]
[automerger] Revert "Select only preinstalled Spell Checker Services" am:
170e24d4e1 am:
fb3b187f10
Change-Id: Idfe048ca52ab0eb317e9313f56b884d264c14fd5
Android Build Merger (Role) [Thu, 10 Jan 2019 00:44:29 +0000 (00:44 +0000)]
[automerger] Revert "Select only preinstalled Spell Checker Services" am:
170e24d4e1
Change-Id: I11efc66592aada0a9b54299b6d782e92e247f811
Bryan Ferris [Wed, 9 Jan 2019 23:22:20 +0000 (15:22 -0800)]
Revert "Select only preinstalled Spell Checker Services"
This reverts commit
fa265ed97026e3b8675a2ccbf4035cad6dc1523f.
Reason for revert: The backport for b/
118694079 was applied improperly.
The fix involved filtering the class members list of spell checkers into a new list before searching it. The backport filtered the list but failed to update references to the class member into references to the local variable, creating no change in observable behavior. A new version of this commit will be simultaneously uploaded, which both fixes the bad behavior and allows us to have exactly 1 CL per branch that fixes the issue.
Bug:
118694079
Change-Id: Ic38a2ca2ddede7f0929779b0f2292b7823c11e87
Merged-In: Idab3ecc246fe9344a09e6907a0ba39f8ea6506f9
Tony Mak [Tue, 8 Jan 2019 12:18:40 +0000 (04:18 -0800)]
Merge changes from topic "am-
5969704d-c4c1-4e63-afae-
e851b95f3e2b" into oc-dev
am:
5ee2efb484
Change-Id: I03962452c1ff5c3a25ed319e7b32e209f8fab5f4
TreeHugger Robot [Tue, 8 Jan 2019 11:55:30 +0000 (11:55 +0000)]
Merge changes from topic "am-
5969704d-c4c1-4e63-afae-
e851b95f3e2b" into oc-dev
* changes:
[automerger] RESTRICT AUTOMERGE Do not linkify text with RLO/LRO characters. am:
73f398d306 am:
363e47e676 am:
efb165f557 am:
b2b98a008b skipped:
3823545fee
[automerger] RESTRICT AUTOMERGE Do not linkify text with RLO/LRO characters. am:
73f398d306 am:
363e47e676 am:
efb165f557 am:
b2b98a008b
[automerger] RESTRICT AUTOMERGE Do not linkify text with RLO/LRO characters. am:
73f398d306 am:
363e47e676 am:
efb165f557
[automerger] RESTRICT AUTOMERGE Do not linkify text with RLO/LRO characters. am:
73f398d306 am:
363e47e676
[automerger] RESTRICT AUTOMERGE Do not linkify text with RLO/LRO characters. am:
73f398d306
RESTRICT AUTOMERGE Do not linkify text with RLO/LRO characters.
Tony Mak [Tue, 8 Jan 2019 10:50:57 +0000 (02:50 -0800)]
RESTRICT AUTOMERGE Do not linkify text with RLO/LRO characters.
am:
d9e75a497e
Change-Id: Id1b62f552f29ef9a20d78bb7487201452dfda601
Tony Mak [Thu, 29 Nov 2018 17:37:42 +0000 (17:37 +0000)]
RESTRICT AUTOMERGE Do not linkify text with RLO/LRO characters.
Also don't show smart actions for selections in text with unsupported
characters.
Bug:
116321860
Test: runtest -x cts/tests/tests/text/src/android/text/util/cts/LinkifyTest.java
Change-Id: Ib2ee544b5783234fba8ee2f93adf0b36b039520f
Merged-In: Ib2ee544b5783234fba8ee2f93adf0b36b039520f
Android Build Merger (Role) [Thu, 3 Jan 2019 14:08:07 +0000 (14:08 +0000)]
[automerger] RESTRICT AUTOMERGE Do not linkify text with RLO/LRO characters. am:
73f398d306 am:
363e47e676 am:
efb165f557 am:
b2b98a008b skipped:
3823545fee
Change-Id: I3c673c0d4337914308f5cdd1081e564f96cc3383
Android Build Merger (Role) [Thu, 3 Jan 2019 14:07:59 +0000 (14:07 +0000)]
[automerger] RESTRICT AUTOMERGE Do not linkify text with RLO/LRO characters. am:
73f398d306 am:
363e47e676 am:
efb165f557 am:
b2b98a008b
Change-Id: I29c3f97af12987c8a1dd8a69529641d32d2dd172
Android Build Merger (Role) [Thu, 3 Jan 2019 14:07:52 +0000 (14:07 +0000)]
[automerger] RESTRICT AUTOMERGE Do not linkify text with RLO/LRO characters. am:
73f398d306 am:
363e47e676 am:
efb165f557
Change-Id: Ibc588da08fbb6069989c7c97110e4cecea0b0ce5
Android Build Merger (Role) [Thu, 3 Jan 2019 14:07:43 +0000 (14:07 +0000)]
[automerger] RESTRICT AUTOMERGE Do not linkify text with RLO/LRO characters. am:
73f398d306 am:
363e47e676
Change-Id: I828e0c99ab41935d20033c970b5131f2fcbf9085
Android Build Merger (Role) [Thu, 3 Jan 2019 14:07:33 +0000 (14:07 +0000)]
[automerger] RESTRICT AUTOMERGE Do not linkify text with RLO/LRO characters. am:
73f398d306
Change-Id: I423ddd8df74bee8dbf7cd96009bbdffebf81b93a
Tony Mak [Thu, 29 Nov 2018 17:37:42 +0000 (17:37 +0000)]
RESTRICT AUTOMERGE Do not linkify text with RLO/LRO characters.
Also don't show smart actions for selections in text with unsupported
characters.
Bug:
116321860
Test: runtest -x cts/tests/tests/text/src/android/text/util/cts/LinkifyTest.java
Change-Id: Id271cab8aef6b9b13ef17f1a8654c7616f75cf13
WyattRiley [Fri, 21 Dec 2018 19:07:09 +0000 (11:07 -0800)]
[automerger skipped] [automerger] Adding SUPL NI Emergency Extension Time am:
64306e1e7b am:
882e4e7ba0 am:
478d13d664 am:
17232346f0 skipped:
46f972fea5
am:
5cf98f1399 -s ours
Change-Id: Ic83aa8cd0eb564e27264dfb3f929bc86fe7ec4f6
Android Build Merger (Role) [Fri, 21 Dec 2018 16:50:53 +0000 (16:50 +0000)]
[automerger] Adding SUPL NI Emergency Extension Time am:
64306e1e7b am:
882e4e7ba0 am:
478d13d664 am:
17232346f0 skipped:
46f972fea5
Change-Id: I93997d7383990bd70492944411196c8fbb6b319e
Android Build Merger (Role) [Fri, 21 Dec 2018 16:49:09 +0000 (16:49 +0000)]
[automerger] Adding SUPL NI Emergency Extension Time am:
64306e1e7b am:
882e4e7ba0 am:
478d13d664 am:
17232346f0
Change-Id: I896fbc8000b44041f54f7e314eb1b970c4644389
Android Build Merger (Role) [Fri, 21 Dec 2018 16:49:03 +0000 (16:49 +0000)]
[automerger] Adding SUPL NI Emergency Extension Time am:
64306e1e7b am:
882e4e7ba0 am:
478d13d664
Change-Id: Ifd8d821683c3c61e2a0e10ac4ce0c24e74e06282
Android Build Merger (Role) [Fri, 21 Dec 2018 16:48:57 +0000 (16:48 +0000)]
[automerger] Adding SUPL NI Emergency Extension Time am:
64306e1e7b am:
882e4e7ba0
Change-Id: I2bb3f878634f4ab80f400fccbd4d1fe6610e5a82
Android Build Merger (Role) [Fri, 21 Dec 2018 16:48:50 +0000 (16:48 +0000)]
[automerger] Adding SUPL NI Emergency Extension Time am:
64306e1e7b
Change-Id: I944dc076c63ba9fd5101bc0366a342e057a13d47
WyattRiley [Fri, 21 Dec 2018 01:23:22 +0000 (17:23 -0800)]
Adding SUPL NI Emergency Extension Time
am:
1cd7883a76
Change-Id: I22286211589cbcc8739c5dfed3a839bada35646a
WyattRiley [Thu, 6 Dec 2018 19:43:58 +0000 (11:43 -0800)]
Adding SUPL NI Emergency Extension Time
Configurable by carrier config.xml resource
Bug:
118839234
Bug:
115361555
Bug:
112159033
Test: On device, see b/
115361555#comment14
Change-Id: I52e61656cca8b6fa6468d32d2e69bf60f4c83c61
Merged-In: I52e61656cca8b6fa6468d32d2e69bf60f4c83c61
WyattRiley [Thu, 6 Dec 2018 19:43:58 +0000 (11:43 -0800)]
Adding SUPL NI Emergency Extension Time
Configurable by carrier config.xml resource
Bug:
118839234
Bug:
115361555
Bug:
112159033
Test: On device, see b/
115361555#comment14
Change-Id: I52e61656cca8b6fa6468d32d2e69bf60f4c83c61
Merged-In: I52e61656cca8b6fa6468d32d2e69bf60f4c83c61
Jakub Pawlowski [Fri, 30 Nov 2018 16:22:48 +0000 (08:22 -0800)]
Bluetooth: Check descriptors size in BluetoothHidDeviceAppSdpSettings
am:
f843ccbf9e
Change-Id: I73800fa61a09d6a5e603582a0a4046a8bb7fd5d8
Jakub Pawlowski [Thu, 29 Nov 2018 17:54:21 +0000 (18:54 +0100)]
Bluetooth: Check descriptors size in BluetoothHidDeviceAppSdpSettings
Bug:
119819889
Test: compilation
Change-Id: If51d0e2af74d99758f79a603d40cc2f5c84e4dde
Merged-In: If51d0e2af74d99758f79a603d40cc2f5c84e4dde
Varun Shah [Mon, 19 Nov 2018 23:11:59 +0000 (15:11 -0800)]
Merge "RESTRICT AUTOMERGE: Added an app id security check in isAppForeground." into oc-dev
am:
546ba589a2
Change-Id: I0b63c0bef57320b7465c2fe4e45304fd637e712d
TreeHugger Robot [Mon, 19 Nov 2018 22:49:58 +0000 (22:49 +0000)]
Merge "RESTRICT AUTOMERGE: Added an app id security check in isAppForeground." into oc-dev
Guliz Tuncay [Fri, 16 Nov 2018 21:46:12 +0000 (13:46 -0800)]
[automerger] Select only preinstalled Spell Checker Services am:
fa265ed970 am:
c008f3df63 am:
8df481923f am:
6e652225ad am:
6bd38ca2aa
am:
608d567e43
Change-Id: I5d09ecdb574e347f5f8c8c86a7f6a8ecb26e42c4
Android Build Merger (Role) [Wed, 14 Nov 2018 20:07:40 +0000 (20:07 +0000)]
[automerger] Select only preinstalled Spell Checker Services am:
fa265ed970 am:
c008f3df63 am:
8df481923f am:
6e652225ad am:
6bd38ca2aa
Change-Id: I63d8639a52f0be081b397e1bb7813d1e7e4b8aa4
Android Build Merger (Role) [Wed, 14 Nov 2018 20:07:32 +0000 (20:07 +0000)]
[automerger] Select only preinstalled Spell Checker Services am:
fa265ed970 am:
c008f3df63 am:
8df481923f am:
6e652225ad
Change-Id: Iece38d8723b40e22f86f4aa599d42dbf9a2fcbab
Android Build Merger (Role) [Wed, 14 Nov 2018 20:07:25 +0000 (20:07 +0000)]
[automerger] Select only preinstalled Spell Checker Services am:
fa265ed970 am:
c008f3df63 am:
8df481923f
Change-Id: If661d9f3206b0e9da2a98ffb14b0ff38154cd757
Android Build Merger (Role) [Wed, 14 Nov 2018 20:07:20 +0000 (20:07 +0000)]
[automerger] Select only preinstalled Spell Checker Services am:
fa265ed970 am:
c008f3df63
Change-Id: I9541ff6206955ed3479d5b4aa6c78f23304d3165
Android Build Merger (Role) [Wed, 14 Nov 2018 20:07:12 +0000 (20:07 +0000)]
[automerger] Select only preinstalled Spell Checker Services am:
fa265ed970
Change-Id: I6a0825a14c8b0f38415cccacc315ba84eb88f5b9
Guliz Tuncay [Wed, 16 Aug 2017 19:02:31 +0000 (12:02 -0700)]
Select only preinstalled Spell Checker Services
When we are setting a new spell checker as the default one in
Secure.Settings, TSMS#findAvailSpellCheckerLocked can pick up
any available spell checker service. This violates the principle
that user should be warned whenever we are setting an untrusted
spell checker service as the default service, since the warning
dialog is never shown.
Fixes:
64764051
Bug:
118694079
Test: Manually as follows:
0. Make sure AOSP keyboard is pre-installed.
1. adb shell settings put --user 0 secure selected_spell_checker com.android.inputmethod.latin/.spellcheck.AndroidSpellCheckerService
2. tapas SampleSpellCheckerService
3. make -j
4. adb install --user 0 -r out/target/product/generic/system/app/SampleSpellCheckerService/SampleSpellCheckerService.apk
5. adb shell pm disable com.android.inputmethod.latin
6. adb shell settings get --user 0 secure selected_spell_checker
-> com.android.inputmethod.latin/.spellcheck.AndroidSpellCheckerService
7. adb reboot
8. adb shell settings get --user 0 secure selected_spell_checker
-> com.android.inputmethod.latin/.spellcheck.AndroidSpellCheckerService
Change-Id: I298ffbcfa5e32f43753f54fbebc40a414a5c0f9e
Merged-In: I298ffbcfa5e32f43753f54fbebc40a414a5c0f9e
Bill Yi [Sun, 11 Nov 2018 03:49:37 +0000 (19:49 -0800)]
Merge changes from topic "am-
9fd37bbd-f227-4135-a674-
78c7ef1f0468" into oc-dev
am:
bc7da75f87
Change-Id: Ibdf168a787a6208e78afce6ee311cfd84b198c4b
Bill Yi [Sun, 11 Nov 2018 03:47:36 +0000 (19:47 -0800)]
[automerger skipped] Import translations. DO NOT MERGE skipped:
f77737395b skipped:
640fb0a793
am:
c9590c8fc1 -s ours
Change-Id: I8c87d21d8f99ea3a8e9639a56e8acb10712e7366
Bill Yi [Sun, 11 Nov 2018 03:43:45 +0000 (19:43 -0800)]
Merge changes from topic "am-
6c55709f-f895-4072-8c00-
5133d079d8d8" into oc-dev
am:
cff099466e
Change-Id: I173094597612750f9c4645236ddeb972aa5ad7c5
Bill Yi [Sun, 11 Nov 2018 03:41:31 +0000 (19:41 -0800)]
[automerger skipped] Import translations. DO NOT MERGE skipped:
0697e9e6d7 skipped:
b702eb1807
am:
5e3def3f70 -s ours
Change-Id: Iab399a5abfc4c27aac2956e4d048ef491bd64a3e
TreeHugger Robot [Sun, 11 Nov 2018 03:33:51 +0000 (03:33 +0000)]
Merge changes from topic "am-
9fd37bbd-f227-4135-a674-
78c7ef1f0468" into oc-dev
* changes:
[automerger skipped] Import translations. DO NOT MERGE skipped:
f77737395b skipped:
640fb0a793
[automerger skipped] Import translations. DO NOT MERGE skipped:
f77737395b
Import translations. DO NOT MERGE
TreeHugger Robot [Sun, 11 Nov 2018 03:33:51 +0000 (03:33 +0000)]
Merge changes from topic "am-
9fd37bbd-f227-4135-a674-
78c7ef1f0468" into nyc-mr2-dev
* changes:
[automerger skipped] Import translations. DO NOT MERGE skipped:
f77737395b
Import translations. DO NOT MERGE