OSDN Git Service
Peter Eisentraut [Tue, 28 Jan 2003 21:57:12 +0000 (21:57 +0000)]
Factor out the code that detects the long long int snprintf format into a
separate macro. Also add support for %I64d which is the way on Windows.
The code that checks for the 64-bit int type now gives more reasonable
results when cross-compiling: In that case we just take the compiler's
information and trust that the arithmetic works. Disabling int64 is too
pessimistic.
Tom Lane [Tue, 28 Jan 2003 18:04:02 +0000 (18:04 +0000)]
Convert variable name to canonical spelling before checking for matches
in GUCArrayAdd/GUCArrayDelete. This prevents the multiple-entry bug
exhibited by Frank Lupo 28-Jan-2003.
Bruce Momjian [Tue, 28 Jan 2003 03:43:47 +0000 (03:43 +0000)]
Revert off setting mention for client_min_messages.
Set log_min_error_messages to the proper and agreed-upon default, PANIC
(off). (BACKPATCH)
Bruce Momjian [Tue, 28 Jan 2003 03:34:29 +0000 (03:34 +0000)]
Revert optimizer page count change.
Bruce Momjian [Mon, 27 Jan 2003 23:55:38 +0000 (23:55 +0000)]
Set log_min_error_messages to the proper and agreed-upon default, PANIC (off).
Backpatch to 7.3.X.
Bruce Momjian [Mon, 27 Jan 2003 23:19:18 +0000 (23:19 +0000)]
Add blank line.
Bruce Momjian [Mon, 27 Jan 2003 23:16:52 +0000 (23:16 +0000)]
Move:
> * Add the concept of dataspaces/tablespaces [tablespaces]
307d307
< * Add the concept of dataspaces/tablespaces [tablespaces]
Bruce Momjian [Mon, 27 Jan 2003 22:40:56 +0000 (22:40 +0000)]
Fix typo 233 pages -> 333 pages.
Tom Lane [Mon, 27 Jan 2003 20:51:54 +0000 (20:51 +0000)]
Upgrade cost estimation for joins, per discussion with Bradley Baetz.
Try to model the effect of rescanning input tuples in mergejoins;
account for JOIN_IN short-circuiting where appropriate. Also, recognize
that mergejoin and hashjoin clauses may now be more than single operator
calls, so we have to charge appropriate execution costs.
Bruce Momjian [Mon, 27 Jan 2003 06:25:03 +0000 (06:25 +0000)]
Remove mention of 6.5 max backends.
Tom Lane [Mon, 27 Jan 2003 00:51:06 +0000 (00:51 +0000)]
Get rid of last few unadorned 'permission denied' messages.
Tom Lane [Mon, 27 Jan 2003 00:23:38 +0000 (00:23 +0000)]
Prevent core dump when die_horribly() is called with null AH pointer.
Problem reported and fixed by Oliver Elphick.
Bruce Momjian [Sun, 26 Jan 2003 02:43:55 +0000 (02:43 +0000)]
Mark IN performance problem as fixed in 7.4
Bruce Momjian [Sun, 26 Jan 2003 01:19:22 +0000 (01:19 +0000)]
Include IPv6 addresses in pg_hba.conf even if IPv6 is not supported; at
suggestion of Peter.
Bruce Momjian [Sun, 26 Jan 2003 01:13:34 +0000 (01:13 +0000)]
Add:
> * Add group object ownership, so groups can rename/drop/grant on objects,
> so we can implement roles
Tom Lane [Sat, 25 Jan 2003 23:10:30 +0000 (23:10 +0000)]
Allow the planner to collapse explicit inner JOINs together, rather than
necessarily following the JOIN syntax to develop the query plan. The old
behavior is still available by setting GUC variable JOIN_COLLAPSE_LIMIT
to 1. Also create a GUC variable FROM_COLLAPSE_LIMIT to control the
similar decision about when to collapse sub-SELECT lists into their parent
lists. (This behavior existed already, but the limit was always
GEQO_THRESHOLD/2; now it's separately adjustable.)
Tom Lane [Sat, 25 Jan 2003 05:19:47 +0000 (05:19 +0000)]
Where available, use utime() or utimes() to update the file mod time
of the socket file and socket lock file; this should prevent both of them
from being removed by even the stupidest varieties of /tmp-cleaning
script. Per suggestion from Giles Lean.
Tom Lane [Sat, 25 Jan 2003 03:06:04 +0000 (03:06 +0000)]
Use stat(2) to probe for existing xlog segments in InstallXLogFileSegment,
rather than actually opening the files. This eliminates some corner cases
where the file indeed exists but open() fails for another reason, such
as being out of file descriptors. The net reliability gain is probably
tiny, since xlog.c is full of other file open calls that will elog(PANIC)
if they fail for any reason; but this specific failure mode has been
observed in the field, so we may as well fix it.
Tom Lane [Fri, 24 Jan 2003 21:53:29 +0000 (21:53 +0000)]
Suppress gcc warnings.
Tom Lane [Fri, 24 Jan 2003 03:58:44 +0000 (03:58 +0000)]
Modify planner's implied-equality-deduction code so that when a set
of known-equal expressions includes any constant expressions (including
Params from outer queries), we actively suppress any 'var = var'
clauses that are or could be deduced from the set, generating only the
deducible 'var = const' clauses instead. The idea here is to push down
the restrictions implied by the equality set to base relations whenever
possible. Once we have applied the 'var = const' clauses, the 'var = var'
clauses are redundant, and should be suppressed both to save work at
execution and to avoid double-counting restrictivity.
Peter Eisentraut [Thu, 23 Jan 2003 23:39:07 +0000 (23:39 +0000)]
Grant options, and cascading revoke. Grant options are allowed only for
users right now, not groups. Extension of has_foo_privileges functions to
query the grant options. Extension of aclitem type to store grantor.
Dave Cramer [Thu, 23 Jan 2003 18:49:22 +0000 (18:49 +0000)]
added fix from Joel Hock to get the inserted row into the current buffer
Tom Lane [Thu, 23 Jan 2003 15:18:40 +0000 (15:18 +0000)]
Fix obsolete error message (isImmutable doesn't exist).
Tom Lane [Thu, 23 Jan 2003 05:10:41 +0000 (05:10 +0000)]
Change CREATE TABLE AS / SELECT INTO to create the new table with OIDs,
for backwards compatibility with pre-7.3 behavior. Per discussion on
pgsql-general and pgsql-hackers.
Tom Lane [Thu, 23 Jan 2003 01:22:59 +0000 (01:22 +0000)]
Update 'Mathematical Functions' table to reflect 7.3 addition of float8
forms of ceil(), floor(), sign(). Back-patch this and other recent
doc fixes in this file to the 7.3 branch.
Tom Lane [Wed, 22 Jan 2003 20:44:20 +0000 (20:44 +0000)]
Fix sloppy comment.
Tom Lane [Wed, 22 Jan 2003 20:16:42 +0000 (20:16 +0000)]
Make estimation of mergejoin scan selectivities more robust, per recent
example from RaÇl GutiÅrrez.
Tom Lane [Wed, 22 Jan 2003 19:26:35 +0000 (19:26 +0000)]
Improve print_expr() a little. It's still not very bright though.
Tom Lane [Wed, 22 Jan 2003 00:07:00 +0000 (00:07 +0000)]
Implement choice between hash-based and sort-based grouping for doing
DISTINCT processing on the output of an IN sub-select.
Tom Lane [Tue, 21 Jan 2003 22:06:12 +0000 (22:06 +0000)]
Fix coredump problem in plpgsql's RETURN NEXT. When a SELECT INTO
that's selecting into a RECORD variable returns zero rows, make it
assign an all-nulls row to the RECORD; this is consistent with what
happens when the SELECT INTO target is not a RECORD. In support of
this, tweak the SPI code so that a valid tuple descriptor is returned
even when a SPI select returns no rows.
Michael Meskes [Tue, 21 Jan 2003 20:01:12 +0000 (20:01 +0000)]
Synced parser.
Tom Lane [Tue, 21 Jan 2003 19:44:26 +0000 (19:44 +0000)]
Avoid gratuitous variation in spelling of same error message.
Peter Eisentraut [Tue, 21 Jan 2003 10:11:52 +0000 (10:11 +0000)]
Fix sed expression for BSD sed.
Tom Lane [Mon, 20 Jan 2003 18:55:07 +0000 (18:55 +0000)]
IN clauses appearing at top level of WHERE can now be handled as joins.
There are two implementation techniques: the executor understands a new
JOIN_IN jointype, which emits at most one matching row per left-hand row,
or the result of the IN's sub-select can be fed through a DISTINCT filter
and then joined as an ordinary relation.
Along the way, some minor code cleanup in the optimizer; notably, break
out most of the jointree-rearrangement preprocessing in planner.c and
put it in a new file prep/prepjointree.c.
Bruce Momjian [Sun, 19 Jan 2003 00:13:31 +0000 (00:13 +0000)]
This patch includes a lot of minor cleanups to the SGML documentation,
including:
- replacing all the appropriate usages of <citetitle>PostgreSQL
...</citetitle> with &cite-user;, &cite-admin;, and so on
- fix an omission in the EXECUTE documentation
- add some more text to the EXPLAIN documentation
- improve the PL/PgSQL RETURN NEXT documentation (more work to do here)
- minor markup fixes
Neil Conway
Bruce Momjian [Sat, 18 Jan 2003 06:06:51 +0000 (06:06 +0000)]
Improve symlink handling for C tags file.
Bruce Momjian [Fri, 17 Jan 2003 17:15:14 +0000 (17:15 +0000)]
Add section on testing index scan.
Bruce Momjian [Fri, 17 Jan 2003 03:28:18 +0000 (03:28 +0000)]
Add dash to:
set-returning functions or SRF's.
for clarity.
Tom Lane [Fri, 17 Jan 2003 03:25:04 +0000 (03:25 +0000)]
Fix parse_agg.c to detect ungrouped Vars in sub-SELECTs; remove code
that used to do it in planner. That was an ancient kluge that was
never satisfactory; errors should be detected at parse time when possible.
But at the time we didn't have the support mechanism (expression_tree_walker
et al) to make it convenient to do in the parser.
Tom Lane [Fri, 17 Jan 2003 02:01:21 +0000 (02:01 +0000)]
Adjust API of expression_tree_mutator and query_tree_mutator to
simplify callers. It turns out the common case is that the caller
does want to recurse into sub-queries, so push support for that into
these subroutines.
Tom Lane [Thu, 16 Jan 2003 21:01:45 +0000 (21:01 +0000)]
Add code to print information about a detected deadlock cycle. The
printed data is comparable to what you could read in the pg_locks view,
were you fortunate enough to have been looking at it at the right time.
Tom Lane [Thu, 16 Jan 2003 18:26:02 +0000 (18:26 +0000)]
Ooops, didn't cut-and-paste quite enough code from ResolveNew;
with result that flatten_join_alias_vars failed to descend into subselects.
Tom Lane [Thu, 16 Jan 2003 15:27:59 +0000 (15:27 +0000)]
Fix bogus formatting of DROP DATABASE command, per Christopher Kings-Lynne.
Tom Lane [Thu, 16 Jan 2003 00:26:49 +0000 (00:26 +0000)]
Repair an embarrassingly large number of alphabetization mistakes in the
datetime token tables. Even more embarrassing, the regression tests
revealed some of the problems --- but evidently the bogus output wasn't
questioned. Add code to postmaster startup to directly check the tables
for correct ordering, in hopes of not being embarrassed like this again.
Peter Eisentraut [Wed, 15 Jan 2003 23:37:28 +0000 (23:37 +0000)]
Add remaining documentation tables to information schema.
Tom Lane [Wed, 15 Jan 2003 23:10:32 +0000 (23:10 +0000)]
Now that switch_outer processing no longer relies on being run after
join_references(), it's practical to consolidate all join_references()
processing into the set_plan_references traversal in setrefs.c. This
seems considerably cleaner than the old way where we did it for join
quals in createplan.c and for targetlists in setrefs.c.
Bruce Momjian [Wed, 15 Jan 2003 21:55:52 +0000 (21:55 +0000)]
Oops, put back changes. Those were Peter's, not mine.
Bruce Momjian [Wed, 15 Jan 2003 21:44:35 +0000 (21:44 +0000)]
Revert my changes to features.sgml.
Bruce Momjian [Wed, 15 Jan 2003 20:49:56 +0000 (20:49 +0000)]
More comment cleanups for shared_buffers in postgresql.conf.
Bruce Momjian [Wed, 15 Jan 2003 20:41:18 +0000 (20:41 +0000)]
Update shared_buffer comment in postgresql.conf.
Bruce Momjian [Wed, 15 Jan 2003 20:01:01 +0000 (20:01 +0000)]
Back out ORDER BY addition to Inet, for Tom.
Tom Lane [Wed, 15 Jan 2003 19:35:48 +0000 (19:35 +0000)]
Allow merge and hash joins to occur on arbitrary expressions (anything not
containing a volatile function), rather than only on 'Var = Var' clauses
as before. This makes it practical to do flatten_join_alias_vars at the
start of planning, which in turn eliminates a bunch of klugery inside the
planner to deal with alias vars. As a free side effect, we now detect
implied equality of non-Var expressions; for example in
SELECT ... WHERE a.x = b.y and b.y = 42
we will deduce a.x = 42 and use that as a restriction qual on a. Also,
we can remove the restriction introduced 12/5/02 to prevent pullup of
subqueries whose targetlists contain sublinks.
Still TODO: make statistical estimation routines in selfuncs.c and costsize.c
smarter about expressions that are more complex than plain Vars. The need
for this is considerably greater now that we have to be able to estimate
the suitability of merge and hash join techniques on such expressions.
Bruce Momjian [Wed, 15 Jan 2003 18:01:05 +0000 (18:01 +0000)]
Reorder VARCHAR() to appear before CHAR() in docs.
Bruce Momjian [Wed, 15 Jan 2003 16:45:17 +0000 (16:45 +0000)]
This patch fixes an incorrect statement and makes a few cleanups to
contrib/fulltextindex/README.fti
Backpatched to 7.3.X too.
Neil Conway
Bruce Momjian [Wed, 15 Jan 2003 16:40:24 +0000 (16:40 +0000)]
This patch includes some minor fixes and improvements to the SGML docs
for PL/PgSQL.
Neil Conway
Bruce Momjian [Wed, 15 Jan 2003 16:35:50 +0000 (16:35 +0000)]
Add ORDER BY for inet regression, pointed out by Rod Taylor.
Peter Eisentraut [Tue, 14 Jan 2003 23:19:34 +0000 (23:19 +0000)]
Add sql_features table to information schema. Generate the features list
in the documentation from that same data.
Bruce Momjian [Tue, 14 Jan 2003 22:52:57 +0000 (22:52 +0000)]
Readd #include netinet/in.h for FreeBSD.
Peter Eisentraut [Tue, 14 Jan 2003 10:19:02 +0000 (10:19 +0000)]
Escape ampersand.
Barry Lind [Tue, 14 Jan 2003 09:42:07 +0000 (09:42 +0000)]
Bumped up build number to 200
Barry Lind [Tue, 14 Jan 2003 09:13:51 +0000 (09:13 +0000)]
Patch from Florian Wunderlich to correctly support java Timestamps. Previously
the code would only capture milliseconds where as both postgres and the java
Timestamp object support greater resolution.
Also fixed a bug reported by Rhett Sutphin where the last digit of the
fractional seconds was lost when using timestamp without time zone
Modified Files:
jdbc/org/postgresql/jdbc1/AbstractJdbc1ResultSet.java
jdbc/org/postgresql/test/jdbc2/TimestampTest.java
Barry Lind [Tue, 14 Jan 2003 05:46:49 +0000 (05:46 +0000)]
Patch from Aaron Mulder to have pooled connections implement PGConnection
Modified Files:
jdbc/org/postgresql/jdbc2/optional/PooledConnectionImpl.java
jdbc/org/postgresql/test/jdbc2/optional/BaseDataSourceTest.java
Barry Lind [Tue, 14 Jan 2003 05:05:26 +0000 (05:05 +0000)]
Patch from Kris Jurka to improve the performance of getImportedKeys().
Use explicit joins to avoid using the genetic query optimizer. Also fixed
a regression test that was failing to compile. This change also cleans up
how key names are reported as per:
A change to the value of the FK_NAME column. Currently the returned value
is the triggers arguments which look like
"<unnamed>\000t2\000t1\000UNSPECIFIED\000a\000a\000"
This was required for server versions < 7.3 when a user did not supply
constraint names. Every constraint was named "<unnamed>"
. 7.3 has enforced unique constraint names per table so unnamed foreign
keys will have different names "$1", "$2" and so on. I've used logic
along the lines of the following to preserve the unique names in the
original scheme, but allow people who go to the trouble of naming their
constraints to see them:
if (triggerargs.startsWith("<unnamed>")) {
fkname = [the whole ugly trigger args name originally used];
} else {
fkname = [the actual fk name];
}
Modified Files:
jdbc/org/postgresql/jdbc1/AbstractJdbc1DatabaseMetaData.java
jdbc/org/postgresql/test/jdbc2/optional/ConnectionPoolTest.java
Bruce Momjian [Tue, 14 Jan 2003 00:47:35 +0000 (00:47 +0000)]
Add:
> o Allow PL/PgSQL to support array element assignment
Bruce Momjian [Mon, 13 Jan 2003 23:00:32 +0000 (23:00 +0000)]
Add Hugarian FAQ, from Laszlo Hornyak
Tom Lane [Mon, 13 Jan 2003 20:37:18 +0000 (20:37 +0000)]
Fix information_schema.sql install to work when building outside
source tree.
Tom Lane [Mon, 13 Jan 2003 18:10:53 +0000 (18:10 +0000)]
Reconsider mechanism for marking sub-selects that are at top level of
a qualification clause (and hence can get away with being sloppy about
distinguishing FALSE from UNKNOWN). We need to know this in subselect.c;
marking the subplans in setrefs.c is too late.
Hiroshi Inoue [Mon, 13 Jan 2003 04:28:55 +0000 (04:28 +0000)]
Change Adjust_lo_type() so that it doesn't cause an error
even when cast functions are allowed to be volatile.
Bruce Momjian [Mon, 13 Jan 2003 01:57:47 +0000 (01:57 +0000)]
Fixes to pgcvslog for last narrive entry.
Tom Lane [Mon, 13 Jan 2003 00:29:26 +0000 (00:29 +0000)]
Cause planner to account for evaluation costs in targetlists and
HAVING quals. Normally this is an insignificant effect --- but it
will not be insignificant when these clauses contain sub-selects.
The added costs cannot affect the planning of the query containing
them, but they might have an impact when the query is a sub-query
of a larger one.
Tom Lane [Mon, 13 Jan 2003 00:18:51 +0000 (00:18 +0000)]
Recent changes in sublink representation require exprType() to accept
SubPlan nodes, else explaining queries containing sublinks may fail.
Tom Lane [Sun, 12 Jan 2003 22:35:29 +0000 (22:35 +0000)]
Revise cost_qual_eval() to compute both startup (one-time) and per-tuple
costs for expression evaluation, not only per-tuple cost as before.
This extension is needed in order to deal realistically with hashed or
materialized sub-selects.
Tom Lane [Sun, 12 Jan 2003 22:01:38 +0000 (22:01 +0000)]
Fix wrong/misleading comments, be more consistent about where to call
ExecAssignResultTypeFromTL().
Tom Lane [Sun, 12 Jan 2003 18:42:59 +0000 (18:42 +0000)]
Fix some minor grammatical errors.
Bruce Momjian [Sun, 12 Jan 2003 18:36:22 +0000 (18:36 +0000)]
Update CHAR().
Peter Eisentraut [Sun, 12 Jan 2003 18:19:37 +0000 (18:19 +0000)]
Replace RelidGetNamespaceId() by get_rel_namespace().
Bruce Momjian [Sun, 12 Jan 2003 14:58:46 +0000 (14:58 +0000)]
Update CHAR() description.
Bruce Momjian [Sun, 12 Jan 2003 05:35:55 +0000 (05:35 +0000)]
Update date only.
Bruce Momjian [Sun, 12 Jan 2003 05:16:12 +0000 (05:16 +0000)]
Improve CHAR() description.
Tom Lane [Sun, 12 Jan 2003 04:03:34 +0000 (04:03 +0000)]
First cut at implementing IN (and NOT IN) via hashtables. There is
more to be done yet, but this is a good start.
Bruce Momjian [Sun, 12 Jan 2003 01:33:00 +0000 (01:33 +0000)]
SGML build cleanups from Neil Conway.
Bruce Momjian [Sat, 11 Jan 2003 21:02:49 +0000 (21:02 +0000)]
Fix capitalization.
Bruce Momjian [Sat, 11 Jan 2003 19:38:23 +0000 (19:38 +0000)]
Back out flockfile change for NetBSD. Giles Lean reports they are not
supported.
Tom Lane [Sat, 11 Jan 2003 17:22:19 +0000 (17:22 +0000)]
Cause symlinks for shared-library versioning to run in the standard
direction on HP-UX; our former approach has been obsolete since HPUX 9.
Giles Lean
Bruce Momjian [Sat, 11 Jan 2003 17:03:45 +0000 (17:03 +0000)]
Fix markup problem in link to other SGML file.
Tatsuo Ishii [Sat, 11 Jan 2003 06:55:11 +0000 (06:55 +0000)]
Fix typo in an error message
Bruce Momjian [Sat, 11 Jan 2003 05:04:14 +0000 (05:04 +0000)]
> > This patch improves the documentation for the shared_buffers GUC param.
>
> I'd suggest that the runtime.sgml description explicitly say "values of
> at least a few thousand are recommended for production installations".
Neil Conway
Bruce Momjian [Sat, 11 Jan 2003 05:01:03 +0000 (05:01 +0000)]
Rewrite for-loop, because this is not the Obfuscated C Code Contest.
Manfred Koizar
Bruce Momjian [Sat, 11 Jan 2003 04:58:44 +0000 (04:58 +0000)]
A tiny patch to fix a typo in configure.in and another one in
RELEASE_CHANGES.
Manfred Koizar
Bruce Momjian [Sat, 11 Jan 2003 00:39:52 +0000 (00:39 +0000)]
Add doc links from SET to SET_CONSTRAINTS, SET_SESSION_AUTH,
SET_TRANSACTION.
Peter Eisentraut [Sat, 11 Jan 2003 00:00:03 +0000 (00:00 +0000)]
Fix markup.
Tom Lane [Fri, 10 Jan 2003 23:54:24 +0000 (23:54 +0000)]
Create a new file executor/execGrouping.c to centralize utility routines
shared by nodeGroup, nodeAgg, and soon nodeSubplan.
Tom Lane [Fri, 10 Jan 2003 23:49:06 +0000 (23:49 +0000)]
Add missing <limits.h> for INT64_IS_BUSTED case.
Peter Eisentraut [Fri, 10 Jan 2003 22:03:30 +0000 (22:03 +0000)]
Read-only transactions, as defined in SQL.
Peter Eisentraut [Fri, 10 Jan 2003 21:57:44 +0000 (21:57 +0000)]
Do not shell-quote the name of the editor, so that the editor can be a
command with arguments.
Tom Lane [Fri, 10 Jan 2003 21:08:15 +0000 (21:08 +0000)]
Further tweaking of parsetree & plantree representation of SubLinks.
Simplify SubLink by storing just a List of operator OIDs, instead of
a list of incomplete OpExprs --- that was a bizarre and bulky choice,
with no redeeming social value since we have to build new OpExprs
anyway when forming the plan tree.
Peter Eisentraut [Fri, 10 Jan 2003 11:02:51 +0000 (11:02 +0000)]
Add optional drop behavior clause to REVOKE command, for SQL conformance.
Currently, only RESTRICT is allowed.
Peter Eisentraut [Fri, 10 Jan 2003 10:59:08 +0000 (10:59 +0000)]
Clean ip.c.
Tom Lane [Thu, 9 Jan 2003 20:50:53 +0000 (20:50 +0000)]
Adjust parser so that 'x NOT IN (subselect)' is converted to
'NOT (x IN (subselect))', that is 'NOT (x = ANY (subselect))',
rather than 'x <> ALL (subselect)' as we formerly did. This
opens the door to optimizing NOT IN the same way as IN, whereas
there's no hope of optimizing the expression using <>. Also,
convert 'x <> ALL (subselect)' to the NOT(IN) style, so that
the optimization will be available when processing rules dumped
by older Postgres versions.
initdb forced due to small change in SubLink node representation.
Tom Lane [Thu, 9 Jan 2003 18:27:39 +0000 (18:27 +0000)]
Add missing #include <getopt.h>.