OSDN Git Service
Neil Conway [Thu, 28 Jul 2005 07:51:13 +0000 (07:51 +0000)]
Refactor exec_cast_value() and exec_simple_cast_value(): since they do
not ever write through the `isnull' parameter, it does not need to be
an out parameter. Therefore it can be declared a "bool" rather than a
"bool *".
Neil Conway [Thu, 28 Jul 2005 07:38:33 +0000 (07:38 +0000)]
Mark a static array "const" to move a few bytes from the "data" segment
to the "text" segment. It would be possible to mark the elements of the
array "const" as well, but this would require multiple API changes and
does not seem to be worth the notational inconvenience.
Tom Lane [Thu, 28 Jul 2005 04:32:32 +0000 (04:32 +0000)]
Remove no-longer-needed hack to add pgsleep.c to regress.so.
Tom Lane [Thu, 28 Jul 2005 04:31:30 +0000 (04:31 +0000)]
Put libpgport into OBJS instead of LIBS, so that it gets included
into .def and .exp files automatically on Windows, AIX, and the like.
An additional benefit is that changes in libpgport files correctly
propagate to force rebuild of the backend executable. This is my
reworking of Rocco Altier's idea, and if it breaks anything it's
definitely my fault.
Tom Lane [Thu, 28 Jul 2005 04:03:14 +0000 (04:03 +0000)]
Fix a whole bunch of #includes that were either wrong or redundant.
The first rule of portability for us is 'thou shalt have no other gods
before c.h', and a whole lot of these files were either not including
c.h at all, or including random system headers beforehand, either of
which sins can mess up largefile support nicely. Once you have
included c.h, there is no need to re-include what it includes, either.
Tom Lane [Thu, 28 Jul 2005 03:15:52 +0000 (03:15 +0000)]
Remove some long-dead support for libpgtcl with Tk.
Tom Lane [Thu, 28 Jul 2005 00:26:30 +0000 (00:26 +0000)]
Fix breakage introduced in plpgsql CONTINUE patch.
Per Kevin McArthur.
Neil Conway [Wed, 27 Jul 2005 13:42:01 +0000 (13:42 +0000)]
Add some missing SGML markup.
Neil Conway [Wed, 27 Jul 2005 12:44:10 +0000 (12:44 +0000)]
Fix a few macro definitions to ensure that unary minus is enclosed in
parentheses. This avoids possible operator precedence problems, and
is consistent with most of the macro definitions in the tree.
Neil Conway [Wed, 27 Jul 2005 08:05:36 +0000 (08:05 +0000)]
Remove MMCacheLock -- it is no longer used. Per ITAGAKI Takahiro.
Neil Conway [Wed, 27 Jul 2005 05:14:12 +0000 (05:14 +0000)]
Avoid crashing pg_dump if we can't connect to the database server, and
no database has been explicitly specified. Per gripe from Omar Kilani.
Tom Lane [Tue, 26 Jul 2005 23:24:02 +0000 (23:24 +0000)]
Basic documentation for ROLEs. The user-manag chapter still needs to
be rewritten, but at least the reference pages are reasonably sane.
Tom Lane [Tue, 26 Jul 2005 22:37:50 +0000 (22:37 +0000)]
Minor correction: cause ALTER ROLE role ROLE rolenames to behave
sensibly, even though we don't document it.
Tom Lane [Tue, 26 Jul 2005 16:38:29 +0000 (16:38 +0000)]
Add a role property 'rolinherit' which, when false, denotes that the role
doesn't automatically inherit the privileges of roles it is a member of;
for such a role, membership in another role can be exploited only by doing
explicit SET ROLE. The default inherit setting is TRUE, so by default
the behavior doesn't change, but creating a user with NOINHERIT gives closer
adherence to our current reading of SQL99. Documentation still lacking,
and I think the information schema needs another look.
Tom Lane [Tue, 26 Jul 2005 00:04:19 +0000 (00:04 +0000)]
Add pg_has_role() family of privilege inquiry functions modeled after the
existing ones for object privileges. Update the information_schema for
roles --- pg_has_role() makes this a whole lot easier, removing the need
for most of the explicit joins with pg_user. The views should be a tad
faster now, too. Stephen Frost and Tom Lane.
Tom Lane [Mon, 25 Jul 2005 22:12:34 +0000 (22:12 +0000)]
Add SET ROLE. This is a partial commit of Stephen Frost's recent patch;
I'm still working on the has_role function and information_schema changes.
Bruce Momjian [Mon, 25 Jul 2005 17:17:41 +0000 (17:17 +0000)]
Add username for psql password prompt, if the username was specified.
Adrian Maier
Bruce Momjian [Mon, 25 Jul 2005 15:27:06 +0000 (15:27 +0000)]
Add:
> o Allow postgresql.conf file values to be changed via an SQL API
> o Allow the server to be stopped/restarted via an SQL API
Tom Lane [Mon, 25 Jul 2005 04:52:32 +0000 (04:52 +0000)]
Awhile back we replaced all uses of strcasecmp and strncasecmp with
pg_strcasecmp and pg_strncasecmp ... but I see some of the former have
crept back in.
Eternal vigilance is the price of locale independence, apparently.
Tom Lane [Mon, 25 Jul 2005 00:58:27 +0000 (00:58 +0000)]
Change build of regress.so to use Makefile.shlib instead of depending
on the not-very-good .so pattern rules in the port-specific Makefiles.
(This leaves only pgxs' MODULES case needing those rules.) Also,
compile pgsleep.c locally and add it to regress.so to avoid failure
on AIX.
Tom Lane [Sun, 24 Jul 2005 23:30:10 +0000 (23:30 +0000)]
Partial fixes for contrib build on AIX: include -lm where needed.
Per Rocco Altier.
Tom Lane [Sun, 24 Jul 2005 17:18:52 +0000 (17:18 +0000)]
Regenerate badly-obsolete README file.
Tom Lane [Sun, 24 Jul 2005 17:07:18 +0000 (17:07 +0000)]
With the interval/day patch, the horology regression test no longer
fails near DST transition days, so remove the advice about that testing
problem. Also improve the description of variant-comparison-file
selection.
Tom Lane [Sun, 24 Jul 2005 14:53:42 +0000 (14:53 +0000)]
Add variant expected file to cope with different spelling of a Python
error message in Python 2.3 and before. Per Michael Fuhr and buildfarm
results.
Bruce Momjian [Sun, 24 Jul 2005 04:37:07 +0000 (04:37 +0000)]
Fix rounding problem in interval_div by using rint(), and improve
interval_mul function.
Tom Lane [Sun, 24 Jul 2005 02:25:26 +0000 (02:25 +0000)]
Fix logic error in tbm_intersect: the intersection of a normal page and
a lossy page has to be lossy, because we don't know exactly which tuples
on the page should remain part of the bitmap. Per Jie Zhang.
Tom Lane [Sun, 24 Jul 2005 00:33:28 +0000 (00:33 +0000)]
Fix some failures to initialize table entries induced by recent autovacuum
integration. Not clear this explains recent stats problems, but it's
definitely wrong.
Tom Lane [Sat, 23 Jul 2005 21:05:48 +0000 (21:05 +0000)]
Simple constraint exclusion. For now, only child tables of inheritance
scans are candidates for exclusion; this should be fixed eventually.
Simon Riggs, with some help from Tom Lane.
Bruce Momjian [Sat, 23 Jul 2005 15:31:16 +0000 (15:31 +0000)]
Remove unintended code addition.
Bruce Momjian [Sat, 23 Jul 2005 15:29:47 +0000 (15:29 +0000)]
Macro alignment cleanup.
Bruce Momjian [Sat, 23 Jul 2005 14:53:21 +0000 (14:53 +0000)]
Improve computations of interval_div to prevent rounding problem on AIX.
Bruce Momjian [Sat, 23 Jul 2005 14:25:34 +0000 (14:25 +0000)]
Andrew pointed out that the current fix didn't handle dates that were
near daylight savings time boudaries. This handles it properly, e.g.
test=> select '2005-04-03 04:00:00'::timestamp at time zone
'America/Los_Angeles';
timezone
------------------------
2005-04-03 07:00:00-04
(1 row)
Tom Lane [Sat, 23 Jul 2005 14:18:57 +0000 (14:18 +0000)]
In the stats test, delay for the stats collector to catch up using a
function that actually sleeps, instead of busy-waiting. Perhaps this
will resolve some of the intermittent stats failures we keep seeing.
Bruce Momjian [Sat, 23 Jul 2005 02:02:27 +0000 (02:02 +0000)]
Fix AT TIME ZONE for timestamps without time zones:
test=> select (CURRENT_DATE + '05:00'::time)::timestamp at time zone
'Canada/Pacific';
timezone
------------------------
2005-07-22 08:00:00-04
(1 row)
Bruce Momjian [Fri, 22 Jul 2005 21:16:15 +0000 (21:16 +0000)]
Fix AT TIME ZONE for timestamps without time zones:
test=> select ('2005-07-20 00:00:00'::timestamp without time zone) at
time zone 'Europe/Paris';
timezone
------------------------
2005-07-19 22:00:00-04
Udpate documentation.
Tom Lane [Fri, 22 Jul 2005 19:55:50 +0000 (19:55 +0000)]
Fix insufficient check for overflow in tm2abstime(), per report from jw.
Tom Lane [Fri, 22 Jul 2005 19:12:02 +0000 (19:12 +0000)]
Fix compare_fuzzy_path_costs() to behave a bit more sanely. The original
coding would ignore startup cost differences of less than 1% of the
estimated total cost; which was OK for normal planning but highly not OK
if a very small LIMIT was applied afterwards, so that startup cost becomes
the name of the game. Instead, compare startup and total costs fuzzily
but independently. This changes the plan selected for two queries in the
regression tests; adjust expected-output files for resulting changes in
row order. Per reports from Dawid Kuroczko and Sam Mason.
Bruce Momjian [Fri, 22 Jul 2005 19:00:55 +0000 (19:00 +0000)]
More removal of unneeded parentheses.
Bruce Momjian [Fri, 22 Jul 2005 15:15:38 +0000 (15:15 +0000)]
More spacing adjustments
Bruce Momjian [Fri, 22 Jul 2005 05:08:26 +0000 (05:08 +0000)]
Update date/time comments.
Bruce Momjian [Fri, 22 Jul 2005 05:03:09 +0000 (05:03 +0000)]
More minor spacing improvements.
Bruce Momjian [Fri, 22 Jul 2005 03:46:34 +0000 (03:46 +0000)]
Code spacing improvement, particularly *tm spacing.
Bruce Momjian [Thu, 21 Jul 2005 20:37:21 +0000 (20:37 +0000)]
More comment update of time macros.
Bruce Momjian [Thu, 21 Jul 2005 18:06:13 +0000 (18:06 +0000)]
Update DAYS_PER_MONTH comment.
Add SECS_PER_YEAR and MINS_PER_HOUR macros.
Bruce Momjian [Thu, 21 Jul 2005 15:16:30 +0000 (15:16 +0000)]
Add comment about void* use in MemSet.
Bruce Momjian [Thu, 21 Jul 2005 13:43:16 +0000 (13:43 +0000)]
Add:
<
> * Research storing disk pages with no alignment/padding
Bruce Momjian [Thu, 21 Jul 2005 05:18:26 +0000 (05:18 +0000)]
Fix integer timestamp build for macro changes.
Bruce Momjian [Thu, 21 Jul 2005 04:48:42 +0000 (04:48 +0000)]
Add comment marking non-exact time conversion macros.
Bruce Momjian [Thu, 21 Jul 2005 04:41:43 +0000 (04:41 +0000)]
Remove unnecessary parentheses in assignments.
Add spaces where needed.
Reference time interval variables as tinterval.
Tom Lane [Thu, 21 Jul 2005 04:15:04 +0000 (04:15 +0000)]
Fix storage size for btree_gist interval indexes. Fix penalty
calculations for interval and time/timetz to behave sanely for both
integer and float timestamps; up to now I think it's been doing
something pretty strange...
Bruce Momjian [Thu, 21 Jul 2005 03:56:25 +0000 (03:56 +0000)]
Add time/date macros for code clarity:
#define DAYS_PER_YEAR 365.25
#define MONTHS_PER_YEAR 12
#define DAYS_PER_MONTH 30
#define HOURS_PER_DAY 24
Tom Lane [Wed, 20 Jul 2005 23:57:46 +0000 (23:57 +0000)]
Fix breakage of INSTALL document build.
Bruce Momjian [Wed, 20 Jul 2005 18:17:39 +0000 (18:17 +0000)]
/contrib/btree_gist adjustments for new 'day' interval value.
Bruce Momjian [Wed, 20 Jul 2005 17:24:39 +0000 (17:24 +0000)]
Update catalog version for INTERVAL day addition.
Bruce Momjian [Wed, 20 Jul 2005 16:42:32 +0000 (16:42 +0000)]
Add 'day' field to INTERVAL so 1 day interval can be distinguished from
24 hours. This is very helpful for daylight savings time:
select '2005-05-03 00:00:00 EST'::timestamp with time zone + '24 hours';
?column?
----------------------
2005-05-04 01:00:00-04
select '2005-05-03 00:00:00 EST'::timestamp with time zone + '1 day';
?column?
----------------------
2005-05-04 01:00:00-04
Michael Glaesemann
Bruce Momjian [Wed, 20 Jul 2005 03:50:24 +0000 (03:50 +0000)]
Fix interval division and multiplication, before:
test=> select '4 months'::interval / 5;
?column?
---------------
1 mon -6 days
(1 row)
after:
test=> select '4 months'::interval / 5;
?column?
----------
24 days
(1 row)
The problem was the use of rint() to round, and then find the remainder,
causing the negative values.
Neil Conway [Tue, 19 Jul 2005 01:27:59 +0000 (01:27 +0000)]
Documentation tweak: make <command>CREATE OPERATOR CLASS</command> into
an <xref/>.
Tom Lane [Mon, 18 Jul 2005 22:34:14 +0000 (22:34 +0000)]
Fix some bogosities in geometric-function documentation: add an entry
for circle(polygon), which was missing; remove bogus entry for
point(lseg, lseg), which does not exist, and the documentation seemed to
describe lseg_interpt, which we already document as an operator not a
function. Also remove entry for box_intersect, which likewise is
preferentially used via the operator #.
Bruce Momjian [Mon, 18 Jul 2005 20:57:53 +0000 (20:57 +0000)]
\pset numericsep -> numericlocale.
Bruce Momjian [Mon, 18 Jul 2005 19:27:37 +0000 (19:27 +0000)]
Fix len so decimal length is only added when a period appears in the output.
Tom Lane [Mon, 18 Jul 2005 19:12:09 +0000 (19:12 +0000)]
Avoid use of E'', and thereby creating an unnecessary version-dependency,
by using LIKE...ESCAPE instead. Per suggestion by andrew@supernews.
Tom Lane [Mon, 18 Jul 2005 19:09:09 +0000 (19:09 +0000)]
Avoid need for E'' construct by using regexp instead of LIKE. More
readable, and more like the other places in this file.
Bruce Momjian [Mon, 18 Jul 2005 18:58:45 +0000 (18:58 +0000)]
Fix numiericsep length computations.
Eugen Nedelcu
Tom Lane [Mon, 18 Jul 2005 17:40:14 +0000 (17:40 +0000)]
Adjust psql describe queries so that any pg_foo_is_visible() condition
is applied last, after other constraints such as name patterns. This
is useful first because the pg_foo_is_visible() functions are relatively
expensive, and second because it minimizes the prospects for race
conditions. The change is fragile though since it makes unwarranted
assumptions about planner behavior, ie, that WHERE clauses will be
executed in the original order if there's not reason to change it.
This should fix ... or at least hide ... an intermittent failure in the
prepared_xacts regression test, while we think about what else to do.
Tom Lane [Mon, 18 Jul 2005 17:17:12 +0000 (17:17 +0000)]
pgcrypto documentation update. Marko Kreen
Tom Lane [Mon, 18 Jul 2005 17:12:54 +0000 (17:12 +0000)]
Fortuna fixes. Marko Kreen
Tom Lane [Mon, 18 Jul 2005 17:09:01 +0000 (17:09 +0000)]
Small cleanups for pgcrypto. Marko Kreen
Tom Lane [Mon, 18 Jul 2005 16:35:06 +0000 (16:35 +0000)]
Fix C++-style comments, per Rocco Altier.
Tom Lane [Mon, 18 Jul 2005 15:53:28 +0000 (15:53 +0000)]
MemSet() must not cast its pointer argument to int32* until after it has
checked that the pointer is actually word-aligned. Casting a non-aligned
pointer to int32* is technically illegal per the C spec, and some recent
versions of gcc actually generate bad code for the memset() when given
such a pointer. Per report from Andrew Morrow.
Tom Lane [Sun, 17 Jul 2005 18:28:45 +0000 (18:28 +0000)]
Make pg_regress accept a command-line option for the temporary installation's
port number, and use a default value for it that is dependent on the
configuration-time DEF_PGPORT. Should make the world safe for running
parallel 'make check' in different branches. Back-patch as far as 7.4
so that this actually is useful.
Tom Lane [Fri, 15 Jul 2005 22:02:51 +0000 (22:02 +0000)]
Fix create_unique_plan() so it doesn't generate useless entries in the
output targetlist of the Unique or HashAgg plan. This code was OK when
written, but subsequent changes to use "physical tlists" where possible
had broken it: given an input subplan that has extra variables added to
avoid a projection step, it would copy those extra variables into the
upper tlist, which is pointless since a projection has to happen anyway.
Bruce Momjian [Fri, 15 Jul 2005 19:02:12 +0000 (19:02 +0000)]
Fix SGML spacing.
Tom Lane [Fri, 15 Jul 2005 18:39:59 +0000 (18:39 +0000)]
Check for out-of-range varoattno in deparse_context_for_subplan.
I have seen this case in CVS tip due to new "physical tlist" optimization
for subqueries. I believe it probably can't happen in existing releases,
but the check is not going to hurt anything, so backpatch to 8.0 just
in case.
Tom Lane [Fri, 15 Jul 2005 17:09:26 +0000 (17:09 +0000)]
Fix overenthusiastic optimization of 'x IN (SELECT DISTINCT ...)' and related
cases: we can't just consider whether the subquery's output is unique on its
own terms, we have to check whether the set of output columns we are going to
use will be unique. Per complaint from Luca Pireddu and test case from
Michael Fuhr.
Tom Lane [Thu, 14 Jul 2005 21:46:30 +0000 (21:46 +0000)]
Adjust permissions checking for ALTER OWNER commands: instead of
requiring superuserness always, allow an owner to reassign ownership
to any role he is a member of, if that role would have the right to
create a similar object. These three requirements essentially state
that the would-be alterer has enough privilege to DROP the existing
object and then re-CREATE it as the new role; so we might as well
let him do it in one step. The ALTER TABLESPACE case is a bit
squirrely, but the whole concept of non-superuser tablespace owners
is pretty dubious anyway. Stephen Frost, code review by Tom Lane.
Bruce Momjian [Thu, 14 Jul 2005 21:12:41 +0000 (21:12 +0000)]
Enable multi-byte thousands_sep and decimal_point for numericsep.
Bruce Momjian [Thu, 14 Jul 2005 15:54:21 +0000 (15:54 +0000)]
Make better thousands_sep default based on decimal marker value.
Bruce Momjian [Thu, 14 Jul 2005 08:42:37 +0000 (08:42 +0000)]
Change numericsep to a boolean, and make it locale-aware.
Bruce Momjian [Thu, 14 Jul 2005 07:32:01 +0000 (07:32 +0000)]
Add numeric separator support for latex and troff output methods.
Neil Conway [Thu, 14 Jul 2005 07:12:27 +0000 (07:12 +0000)]
Mark xml2 CREATE FUNCTIONs as IMMUTABLE, and use the "STRICT" syntax
rather than the deprecated "WITH (isStrict)" syntax. Patch from Ilia
Kantor, minor editorializing by Neil Conway.
Bruce Momjian [Thu, 14 Jul 2005 06:49:58 +0000 (06:49 +0000)]
barebones variable name -> tuples_only, for consistency.
Bruce Momjian [Thu, 14 Jul 2005 06:46:17 +0000 (06:46 +0000)]
Fix malloc length for new numeric separator patch.
Centralize malloc into function.
Neil Conway [Thu, 14 Jul 2005 06:17:36 +0000 (06:17 +0000)]
This doc patch replaces all inappropriate references to SQL:1999 when it
is used as if it were the latest (and/or still valid) SQL standard.
SQL:2003 is used in its place. Patch from Simon Riggs.
Tom Lane [Thu, 14 Jul 2005 05:13:45 +0000 (05:13 +0000)]
Integrate autovacuum functionality into the backend. There's still a
few loose ends to be dealt with, but it seems to work. Alvaro Herrera,
based on the contrib code by Matthew O'Connor.
Tom Lane [Wed, 13 Jul 2005 22:46:09 +0000 (22:46 +0000)]
Fix a couple of bogus comments, per Alvaro.
Tom Lane [Wed, 13 Jul 2005 17:12:56 +0000 (17:12 +0000)]
Remove extraneous space after -L ... it confuses SHLIB_LINK filter -L
hack.
Tom Lane [Wed, 13 Jul 2005 17:00:44 +0000 (17:00 +0000)]
Fix unwanted side-effects of recent SHLIB_LINK -L patch on existing
hacking of SHLIB_LINK for HPUX.
Bruce Momjian [Wed, 13 Jul 2005 15:59:32 +0000 (15:59 +0000)]
Fix #elif spacing too.
Tom Lane [Wed, 13 Jul 2005 15:25:55 +0000 (15:25 +0000)]
Fix libpq memory leak during PQreset() --- closePGconn() was not
freeing all transient state of the PGconn object.
Bruce Momjian [Wed, 13 Jul 2005 04:44:42 +0000 (04:44 +0000)]
Fix pgindent to not have blank line before #else in variable definition
section of a function.
Bruce Momjian [Wed, 13 Jul 2005 04:00:28 +0000 (04:00 +0000)]
Add backslashes to parentheses in awk regex because if not, they are
treated as regex groups.
Bruce Momjian [Wed, 13 Jul 2005 02:11:57 +0000 (02:11 +0000)]
Move -L flag around for shared builds:
I wrote:
> So either we code up some intelligence to put the "C" in the right
> position or we have to pass down "A B" and "D" separately from the
> main makefile.
The following patch might just do the former. Please try it out.
Peter E.
Neil Conway [Wed, 13 Jul 2005 02:10:42 +0000 (02:10 +0000)]
Documentation for some new PL/Perl features. Patch from David Fetter,
various editorialization from Neil Conway.
Tom Lane [Tue, 12 Jul 2005 23:06:48 +0000 (23:06 +0000)]
Hack around the discrepancy between default library search paths for
gcc and for HP's ld on HPUX. There may be better ways to do this,
but this seems to work for me...
Tom Lane [Tue, 12 Jul 2005 20:35:42 +0000 (20:35 +0000)]
Fix plperl crash with list value return for an array result type.
Reported by Michael Fuhr, fixed by Andrew Dunstan.
Tom Lane [Tue, 12 Jul 2005 20:27:45 +0000 (20:27 +0000)]
More pgcrypto fixes: handle long messages correctly, suppress
compiler warnings. Marko Kreen and Kris Jurka.
Bruce Momjian [Tue, 12 Jul 2005 16:05:12 +0000 (16:05 +0000)]
Improve comments for AdjustIntervalForTypmod.
Blank line adjustments.
Bruce Momjian [Tue, 12 Jul 2005 15:17:44 +0000 (15:17 +0000)]
Change 5e0 to 5.0, for consistency.
Tom Lane [Tue, 12 Jul 2005 01:16:22 +0000 (01:16 +0000)]
Fix plperl to do recursion safely, and fix a problem with array results.
Add suitable regression tests. Andrew Dunstan
Tom Lane [Mon, 11 Jul 2005 19:06:46 +0000 (19:06 +0000)]
Further tweaking of Win32-specific random code. Marko Kreen