OSDN Git Service
Bruce Momjian [Sat, 7 Feb 2009 20:05:44 +0000 (20:05 +0000)]
Remove documentation mention that hash indexes perform no better than
btree; keep mention about missing WAL logging.
Kenneth Marshall
Bruce Momjian [Sat, 7 Feb 2009 19:27:25 +0000 (19:27 +0000)]
Uppercase CHECK mention in relchecks documentation mention.
Bruce Momjian [Sat, 7 Feb 2009 17:17:34 +0000 (17:17 +0000)]
ecpg requires libpq; add Makefile rules to require libpq to be built
first.
Alvaro Herrera
Bruce Momjian [Sat, 7 Feb 2009 15:25:51 +0000 (15:25 +0000)]
Properly wrap new pg_dump doc text.
Bruce Momjian [Sat, 7 Feb 2009 15:00:27 +0000 (15:00 +0000)]
Update pg_constraint.conkey documentation description.
Bruce Momjian [Sat, 7 Feb 2009 14:31:30 +0000 (14:31 +0000)]
Document disabling the statistics collector pg_dump activity, and give a
bit more visibility to the PGOPTIONS environment variable supported by
libpq.
Bryce Nesbitt
Bruce Momjian [Sat, 7 Feb 2009 14:16:46 +0000 (14:16 +0000)]
Fix to_timestamp() to not require upper/lower case matching for meridian
designations (AM/PM). Also separate out matching of a meridian with
periods (e.g. A.M.) and with those without.
Do the same for AD/BC.
Brendan Jurd
Heikki Linnakangas [Sat, 7 Feb 2009 10:49:36 +0000 (10:49 +0000)]
Fix obsolete comment. Zdenek Kotala
Peter Eisentraut [Sat, 7 Feb 2009 01:02:55 +0000 (01:02 +0000)]
Set column privileges to supported
Tom Lane [Fri, 6 Feb 2009 23:43:24 +0000 (23:43 +0000)]
Fix cost_mergejoin's failure to adjust for rescanning of non-unique merge join
keys when considering a semi or anti join. This requires estimating the
selectivity of the merge qual as though it were a regular inner join condition.
To allow caching both that and the real outer-join-aware selectivity, split
RestrictInfo.this_selec into two fields.
This fixes one of the problems reported by Kevin Grittner.
Tom Lane [Fri, 6 Feb 2009 21:22:49 +0000 (21:22 +0000)]
Ooops, forgot to update COPY reference page to mention column privileges.
Tom Lane [Fri, 6 Feb 2009 21:15:12 +0000 (21:15 +0000)]
Clean up some loose ends from the column privileges patch: add
has_column_privilege and has_any_column_privilege SQL functions; fix the
information_schema views that are supposed to pay attention to column
privileges; adjust pg_stats to show stats for any column you have select
privilege on; and fix COPY to allow copying a subset of columns if the user
has suitable per-column privileges for all the columns.
To improve efficiency of some of the information_schema views, extend the
has_xxx_privilege functions to allow inquiring about the OR of a set of
privileges in just one call. This is just exposing capability that already
existed in the underlying aclcheck routines.
In passing, make the information_schema views report the owner's own
privileges as being grantable, since Postgres assumes this even when the grant
option bit is not set in the ACL. This is a longstanding oversight.
Also, make the new has_xxx_privilege functions for foreign data objects follow
the same coding conventions used by the older ones.
Stephen Frost and Tom Lane
Bruce Momjian [Fri, 6 Feb 2009 19:24:12 +0000 (19:24 +0000)]
Fix typo in docs.
Bruce Momjian [Fri, 6 Feb 2009 18:18:54 +0000 (18:18 +0000)]
Document ways to avoid libpq WSACleanup() overhead on Windows.
Andrew Chernow
Bruce Momjian [Thu, 5 Feb 2009 15:25:49 +0000 (15:25 +0000)]
Add PL/PgSQL FOUND and GET DIAGNOSTICS support for RETURN QUERY
statement
Pavel Stehule
Michael Meskes [Thu, 5 Feb 2009 08:28:47 +0000 (08:28 +0000)]
Mixing long and int entries of a union only works on some architectures.
Tom Lane [Thu, 5 Feb 2009 01:24:55 +0000 (01:24 +0000)]
Fix an old corner-case error in match_unsorted_outer(): don't consider
the cheapest-total inner path as a new candidate while truncating the
sort key list, if it already matched the full sort key list. This is
too much of a corner case to be worth back-patching, since it's unusual
for the cheapest total path to be sorted, and anyway no real harm is
done (except in JOIN_SEMI/ANTI cases where cost_mergejoin is a bit
broken at the moment). But it wasn't behaving as intended, so fix it.
Noted while examining a test case from Kevin Grittner. This error doesn't
explain his issue, but it does explain why "set enable_seqscan = off"
seemed to reproduce it for me.
Alvaro Herrera [Wed, 4 Feb 2009 21:30:41 +0000 (21:30 +0000)]
Fix some SGML-compiler warnings on -wxml mode.
Bruce Momjian [Wed, 4 Feb 2009 16:05:50 +0000 (16:05 +0000)]
Update read committed documentation to better explain undesirable
behavior of concurrent commands in cases where rows are being added and
removed from matching query criteria.
Minor word-smithing.
Michael Meskes [Wed, 4 Feb 2009 08:51:10 +0000 (08:51 +0000)]
Added result checks for calls to gmtime().
Michael Meskes [Tue, 3 Feb 2009 08:55:45 +0000 (08:55 +0000)]
Argh, wrong line copied again.
Michael Meskes [Tue, 3 Feb 2009 08:48:29 +0000 (08:48 +0000)]
Fixed copy&paste mistake that made library use uninitialized variable.
Andrew Dunstan [Tue, 3 Feb 2009 01:24:57 +0000 (01:24 +0000)]
allow alternative names for tclsh used on Windows
Tom Lane [Tue, 3 Feb 2009 00:59:26 +0000 (00:59 +0000)]
Add a failure check for syslogger's use of _beginthreadex(), and remove
unnecessary thread address output parameter, to make this code look more
like that in pg_restore.
Tom Lane [Mon, 2 Feb 2009 20:42:57 +0000 (20:42 +0000)]
Document the longstanding behavior of LIMIT NULL and OFFSET NULL,
per gripe from David Wheeler that this was mentioned nowhere.
In passing, editorialize a bit on the description of the SQL:2008
equivalent syntax.
Tom Lane [Mon, 2 Feb 2009 20:25:38 +0000 (20:25 +0000)]
Fix plpgsql to not treat INSERT INTO as an INTO-variables clause anywhere
in the string, not just at the start. Per bug #4629 from Martin Blazek.
Back-patch to 8.2; prior versions don't have the problem, at least not in
the reported case, because they don't try to recognize INTO in non-SELECT
statements. (IOW, this is really fallout from the RETURNING patch.)
Andrew Dunstan [Mon, 2 Feb 2009 20:07:37 +0000 (20:07 +0000)]
Provide for parallel restoration from a custom format archive. Each data and
post-data step is run in a separate worker child (a thread on Windows, a child
process elsewhere) up to the concurrent number specified by the new pg_restore
command-line --multi-thread | -m switch.
Andrew Dunstan, with some editing by Tom Lane.
Alvaro Herrera [Mon, 2 Feb 2009 19:31:40 +0000 (19:31 +0000)]
Allow reloption names to have qualifiers, initially supporting a TOAST
qualifier, and add support for this in pg_dump.
This allows TOAST tables to have user-defined fillfactor, and will also
enable us to move the autovacuum parameters to reloptions without taking
away the possibility of setting values for TOAST tables.
Michael Meskes [Mon, 2 Feb 2009 16:54:28 +0000 (16:54 +0000)]
When changing a regression test file one should also change the expected output file.
Michael Meskes [Mon, 2 Feb 2009 16:49:50 +0000 (16:49 +0000)]
Set memory segment to '0', just to be sure.
Michael Meskes [Mon, 2 Feb 2009 16:14:06 +0000 (16:14 +0000)]
Fixed auto allocation for binary data types.
Michael Meskes [Mon, 2 Feb 2009 15:35:28 +0000 (15:35 +0000)]
Fixed bug in %s handling.
Peter Eisentraut [Mon, 2 Feb 2009 09:49:29 +0000 (09:49 +0000)]
Put pg_user_mapping section into the right (alphabetical) order.
Tom Lane [Fri, 30 Jan 2009 21:21:18 +0000 (21:21 +0000)]
Fix unnest() to handle a toasted input array safely. Per report from
Alvaro.
Heikki Linnakangas [Fri, 30 Jan 2009 17:24:47 +0000 (17:24 +0000)]
Check that connection limit is within valid range. IOW, not < -1.
It's missing in older versions too, but it doesn't seem worth
back-porting. All negative are just harmlessly treated as "no limit", and
tightening the check might even brake an application that relies on it.
Peter Eisentraut [Fri, 30 Jan 2009 12:53:43 +0000 (12:53 +0000)]
Make messages consistent with existing ones
Peter Eisentraut [Fri, 30 Jan 2009 12:53:12 +0000 (12:53 +0000)]
Whitespace fix in message
Tom Lane [Fri, 30 Jan 2009 00:37:29 +0000 (00:37 +0000)]
Update back-branch release notes.
Tom Lane [Thu, 29 Jan 2009 19:59:59 +0000 (19:59 +0000)]
Update time zone data files to tzdata release 2009a: introduces Asia/Kathmandu
as the preferred spelling of that zone name, corrects historical DST
information for Switzerland and Cuba.
Tom Lane [Thu, 29 Jan 2009 19:23:42 +0000 (19:23 +0000)]
Replace argument-checking Asserts with regular test-and-elog checks in all
encoding conversion functions. These are not can't-happen cases because
it's possible to create a conversion with the wrong conversion function
for the specified encoding pair. That would lead to an Assert crash in
an Assert-enabled build, or incorrect conversion otherwise, neither of
which is desirable. This would be a DOS issue if production databases
were customarily built with asserts enabled, but fortunately that's not so.
Per an observation by Heikki.
Back-patch to all supported branches.
Teodor Sigaev [Thu, 29 Jan 2009 16:22:10 +0000 (16:22 +0000)]
Fix incorrect dereferencing of char* to array's index.
Per Tommy Gildseth <tommy.gildseth@usit.uio.no> report
Peter Eisentraut [Thu, 29 Jan 2009 09:38:38 +0000 (09:38 +0000)]
Message fix
Teodor Sigaev [Wed, 28 Jan 2009 18:31:32 +0000 (18:31 +0000)]
Fix bug with multiple evaluation of tsearch2 compatibility trigger, trigger
data should be restored.
Backpatch only for 8.3 because previous versions haven't such layer.
Magnus Hagander [Wed, 28 Jan 2009 15:32:21 +0000 (15:32 +0000)]
Change warning-silencing code not to cast the pointer type, instead
casting the value of the variable later.
Per comments from Tom.
Magnus Hagander [Wed, 28 Jan 2009 15:06:47 +0000 (15:06 +0000)]
Go over all OpenSSL return values and make sure we compare them
to the documented API value. The previous code got it right as
it's implemented, but accepted too much/too little compared to
the API documentation.
Per comment from Zdenek Kotala.
Magnus Hagander [Wed, 28 Jan 2009 11:19:37 +0000 (11:19 +0000)]
Support running as a service on Windows 7, by not specifying
the JOB_OBJECT_UILIMIT_HANDLES flag.
Dave Page & Magnus Hagander
Magnus Hagander [Tue, 27 Jan 2009 12:46:16 +0000 (12:46 +0000)]
Silence compiler warning on win32.
ITAGAKI Takahiro
Magnus Hagander [Tue, 27 Jan 2009 12:45:09 +0000 (12:45 +0000)]
Silence compiler warnings in new win32 locale code
when building on mingw.
ITAGAKI Takahiro
Peter Eisentraut [Tue, 27 Jan 2009 12:40:15 +0000 (12:40 +0000)]
Revert updatable views
Alvaro Herrera [Mon, 26 Jan 2009 19:41:06 +0000 (19:41 +0000)]
Allow extracting and parsing of reloptions from a bare pg_class tuple, and
refactor the relcache code that used to do that. This allows other callers
(particularly autovacuum) to do the same without necessarily having to open
and lock a table.
Peter Eisentraut [Mon, 26 Jan 2009 10:19:44 +0000 (10:19 +0000)]
Message format tuning
Tom Lane [Fri, 23 Jan 2009 19:58:06 +0000 (19:58 +0000)]
Tweak the existing special case for AIX in pg_getaddrinfo_all() to handle
yet another failure case in AIX's getaddrinfo(). Per report and patch
by Andrew Chernow.
Bruce Momjian [Fri, 23 Jan 2009 14:05:28 +0000 (14:05 +0000)]
Document that SELECT ... ORDER BY .. FOR UPDATE/SHARE might return
results out of order because of locking, per bug report 4593
Peter Eisentraut [Fri, 23 Jan 2009 12:43:32 +0000 (12:43 +0000)]
Message style review
Heikki Linnakangas [Fri, 23 Jan 2009 11:19:34 +0000 (11:19 +0000)]
Put back fast-path for the case that there's no backup blocks in
RestoreBkpBlocks. Went missing in my recent refactoring patch, as pointed
out by Simon's hot standby patch.
Peter Eisentraut [Thu, 22 Jan 2009 22:27:13 +0000 (22:27 +0000)]
Recreate ecpg_config.h with a stamp file created by config.status, same
way pg_config.h is handled. This avoids reruns of config.status on every
build, if configure has been rerun.
Tom Lane [Thu, 22 Jan 2009 20:16:10 +0000 (20:16 +0000)]
Support column-level privileges, as required by SQL standard.
Stephen Frost, with help from KaiGai Kohei and others
Heikki Linnakangas [Thu, 22 Jan 2009 19:25:00 +0000 (19:25 +0000)]
Only skip pages marked as clean in the visibility map, if the last 32
pages were marked as clean as well. The idea is to avoid defeating OS
readahead by skipping a page here and there, and also makes it less likely
that we miss an opportunity to advance relfrozenxid, for the sake of only
a few skipped pages.
Heikki Linnakangas [Thu, 22 Jan 2009 19:16:31 +0000 (19:16 +0000)]
Update comments to reflect that tgenabled is not a boolean anymore.
Jonah Harris, with minor tinkering by me.
Peter Eisentraut [Thu, 22 Jan 2009 17:27:55 +0000 (17:27 +0000)]
Automatic view update rules
Bernd Helmle
Magnus Hagander [Thu, 22 Jan 2009 10:09:48 +0000 (10:09 +0000)]
Explicitly bind gettext to the correct encoding on Windows.
Original patch from Hiroshi Inoue.
Magnus Hagander [Wed, 21 Jan 2009 12:45:06 +0000 (12:45 +0000)]
Remove stray ' character at end of line.
For some reason it broke OpenBSD compile even when it's inside a
#ifdef WIN32 block.....
Heikki Linnakangas [Wed, 21 Jan 2009 11:13:14 +0000 (11:13 +0000)]
Forgot to handle the new SPI_OK_REWRITTEN result code in a couple places.
Heikki Linnakangas [Wed, 21 Jan 2009 11:02:40 +0000 (11:02 +0000)]
Add new SPI_OK_REWRITTEN return code to SPI_execute and friends, for the
case that the command is rewritten into another type of command. The old
behavior to return the command tag of the last executed command was
pretty surprising. In PL/pgSQL, for example, it meant that if a command
was rewritten to a utility statement, FOUND wasn't set at all.
Magnus Hagander [Wed, 21 Jan 2009 10:30:02 +0000 (10:30 +0000)]
Make win32 builds always do SetEnvironmentVariable() when doing putenv().
Also, if linked against other versions than the default MSVCRT library
(for example the MSVC build which links against MSVCRT80), also update
the cache in the default MSVCRT at the same time.
This should fix the issues with setting LC_MESSAGES on the MSVC build.
Original patch from Hiroshi Inoue and Hiroshi Saito, much rewritten
by me.
Magnus Hagander [Wed, 21 Jan 2009 09:28:26 +0000 (09:28 +0000)]
Make some strings translatable again that were accidentally removed in
earlier patch to fix "printf-arguments".
Magnus Hagander [Wed, 21 Jan 2009 09:25:11 +0000 (09:25 +0000)]
Install .mo files for NLS as <program>-<version>.mo when building with MSVC
as well. Same change as made earlier for autoconf builds.
Per Hiroshi Inoue.
Heikki Linnakangas [Tue, 20 Jan 2009 18:59:37 +0000 (18:59 +0000)]
Add a new option to RestoreBkpBlocks() to indicate if a cleanup lock should
be used instead of the normal exclusive lock, and make WAL redo functions
responsible for calling RestoreBkpBlocks(). They know better what kind of a
lock they need.
At the moment, this just moves things around with no functional change, but
makes the hot standby patch that's under review cleaner.
Peter Eisentraut [Tue, 20 Jan 2009 09:58:50 +0000 (09:58 +0000)]
Do not msgmerge against /dev/null; merge against the pot file itself
instead.
Peter Eisentraut [Tue, 20 Jan 2009 09:10:20 +0000 (09:10 +0000)]
Revise the permission checking on user mapping DDL commands.
CREATE/ALTER/DROP USER MAPPING are now allowed either by the server owner or
by a user with USAGE privileges for his own user name. This is more or less
what the SQL standard wants anyway (plus "implementation-defined")
Hide information_schema.user_mapping_options.option_value, unless the current
user is the one associated with the user mapping, or is the server owner and
the mapping is for PUBLIC, or is a superuser. This is to protect passwords.
Also, fix a bug in information_schema._pg_foreign_servers, which hid servers
using wrappers where the current user did not have privileges on the wrapper.
The correct behavior is to hide servers where the current user has no
privileges on the server.
Bruce Momjian [Tue, 20 Jan 2009 02:38:37 +0000 (02:38 +0000)]
Update \d*S documentation to be more accurate; system objects are added
to the display, not restricted in the display; new text:
The letter <literal>S</literal> adds the listing of system
objects; without <literal>S</literal>, only non-system
objects are shown.
Bruce Momjian [Tue, 20 Jan 2009 02:13:42 +0000 (02:13 +0000)]
Make psql \d and \dt consistent for system tables, i.e prevent \d from
showing system tables, make \dS pattern show system table details, and
have \dtS show system and _user_ tables, to be consistent with other \d*
commands.
Bruce Momjian [Mon, 19 Jan 2009 18:44:32 +0000 (18:44 +0000)]
Document RELKIND_SPECIAL reference in psql, from <= 8.1.X.
Tom Lane [Mon, 19 Jan 2009 17:17:50 +0000 (17:17 +0000)]
Fix accidental (I suppose) introduction of non-ASCII quote marks.
Magnus Hagander [Mon, 19 Jan 2009 15:34:23 +0000 (15:34 +0000)]
Use the new text domain names ("postgres-8.4" instead of "postgres")
Hiroshi Inoue
Peter Eisentraut [Mon, 19 Jan 2009 14:24:13 +0000 (14:24 +0000)]
Avoid regression test cases that fail in locales that sort "v" and "w"
equally (in glibc: et_EE, sv_SE, tk_TM). It turns out that this was
already taken care of previously by select_1.out, which I had forgotten to
update for an unrelated change. But might as well avoid the issue
altogether.
Peter Eisentraut [Mon, 19 Jan 2009 13:38:47 +0000 (13:38 +0000)]
Alter regression test cases that rely on the sort order of "aa". Some
locales (da_DK, fo_FO, kl_GL, nb_NO, nn_NO in glibc) sort "aa" after "z".
Peter Eisentraut [Mon, 19 Jan 2009 12:02:29 +0000 (12:02 +0000)]
Alter the regression test cases that rely on the sort order of "ch" between
"cg" and "ci". This eliminates a test failure on the following glibc
locales: br_FR, cs_CZ, cy_GB, es_EC, es_US, hsb_DE, ig_NG, ik_CA, sk_SK.
Peter Eisentraut [Mon, 19 Jan 2009 08:59:13 +0000 (08:59 +0000)]
Message wordsmithing
Tom Lane [Sun, 18 Jan 2009 20:44:45 +0000 (20:44 +0000)]
Fix a pg_dump output ordering problem introduced in 8.3 by the addition of
array types for composite types. Although pg_dump understood it wasn't
supposed to dump these array types as separate objects, it must include
them in the dependency ordering analysis, and it was improperly assigning them
the same relatively-high sort priority as regular types. This resulted in
effectively moving composite types and tables up to that same high priority,
which broke any ordering requirements that weren't explicitly enforced by
dependencies. In particular user-defined operator classes, which should come
out before tables, failed to do so. Per report from Brendan Jurd.
In passing, also fix an ill-considered decision to give text search objects
the same sort priority as functions and operators --- the sort result looks
a lot nicer if different object types are kept separate. The recent
foreign-data patch had copied that decision, making the sort ordering even
messier :-(
Neil Conway [Sat, 17 Jan 2009 04:29:00 +0000 (04:29 +0000)]
Fix an ungrammatical statement.
Neil Conway [Sat, 17 Jan 2009 04:24:41 +0000 (04:24 +0000)]
Fix typo.
Peter Eisentraut [Fri, 16 Jan 2009 20:29:48 +0000 (20:29 +0000)]
Manual attempt to update this file.
Peter Eisentraut [Fri, 16 Jan 2009 20:21:46 +0000 (20:21 +0000)]
plpython_error.out is for Python 2.4, plpython_error_3.out is for Python 2.5,
as it was previously.
Heikki Linnakangas [Fri, 16 Jan 2009 13:27:24 +0000 (13:27 +0000)]
Add vacuum_freeze_table_age GUC option, to control when VACUUM should
ignore the visibility map and scan the whole table, to advance
relfrozenxid.
Peter Eisentraut [Fri, 16 Jan 2009 09:15:03 +0000 (09:15 +0000)]
Wordsmithing
Peter Eisentraut [Thu, 15 Jan 2009 22:33:19 +0000 (22:33 +0000)]
Remove period from primary error message.
Heikki Linnakangas [Thu, 15 Jan 2009 18:19:58 +0000 (18:19 +0000)]
Change explanation of pg_switch_xlog()'s return value to match code.
Teodor Sigaev [Thu, 15 Jan 2009 16:33:59 +0000 (16:33 +0000)]
Fix URL generation in headline. Only tag lexeme will be replaced by space.
Per http://archives.postgresql.org/pgsql-bugs/2008-12/msg00013.php
Teodor Sigaev [Thu, 15 Jan 2009 16:33:28 +0000 (16:33 +0000)]
Fix generation too long headline with ShortWords.
Per http://archives.postgresql.org/pgsql-hackers/2008-09/msg01088.php
Peter Eisentraut [Thu, 15 Jan 2009 13:49:57 +0000 (13:49 +0000)]
Cleanup pass over PL/Python NLS. Add translation support to PLy_elog and
PLy_exception_set, and clarify some error messages.
Peter Eisentraut [Thu, 15 Jan 2009 12:59:11 +0000 (12:59 +0000)]
Remove unneeded GETTEXT_TRIGGERS.
Peter Eisentraut [Thu, 15 Jan 2009 11:52:55 +0000 (11:52 +0000)]
NLS cleanup in ecpglib
Replace leftover instances of _() by ecpg_gettext(), the latter being the
correct way to refer to the library's message catalog, instead of the one of
the program using the library.
Drop NLS support for ecpg_log(), which is a debugging instrument similar to
elog() in the backend.
We cannot support NLS in the ecpg compatlib, because that requires
ecpg_gettext, which is in ecpglib, which is not a dependency of compatlib. It
doesn't seem worthwhile to worry about this, since the only translatable
string is "out of memory", and gettext probably won't be able to do much
without memory either.
Adjust messages to project style.
Peter Eisentraut [Thu, 15 Jan 2009 09:30:20 +0000 (09:30 +0000)]
Build needed things in src/test/regress/ first. And some build rules
normalization.
Peter Eisentraut [Thu, 15 Jan 2009 09:01:24 +0000 (09:01 +0000)]
Make .pot files depend on the makefiles, so that they are updated when the
file or trigger function lists are changed.
Bruce Momjian [Thu, 15 Jan 2009 01:53:49 +0000 (01:53 +0000)]
Modify distdir rule to skip .git directory.
Bruce Momjian [Thu, 15 Jan 2009 00:34:25 +0000 (00:34 +0000)]
Add documentation mention that full page writes have to be enabled for
full pages to be restored during recovery.
Per private report from Michael Renner
Bruce Momjian [Wed, 14 Jan 2009 21:59:19 +0000 (21:59 +0000)]
Make 'find' syntax consistent; add .git exclusion to make_ctags.
Peter Eisentraut [Wed, 14 Jan 2009 21:28:32 +0000 (21:28 +0000)]
Avoid version-control system directories when creating TAGS. Besides
being wasteful, this can collide with repostory metadata on case-insensitive
file sytems.
Bruce Momjian [Wed, 14 Jan 2009 21:18:30 +0000 (21:18 +0000)]
Remove empty #ifdef block.