OSDN Git Service

android-x86/system-bt.git
3 years agoL2cap shim: Implement L2CA_GetBleConnRole
Hansong Zhang [Wed, 13 Jan 2021 05:54:54 +0000 (21:54 -0800)]
L2cap shim: Implement L2CA_GetBleConnRole

Note: We haven't routed LE link property callbacks yet.

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: I987fbcede2e8e9e133418c72cb2d99dda0253b40

3 years agoRemove unused API L2CA_CancelBleConnectReq
Hansong Zhang [Wed, 13 Jan 2021 05:39:42 +0000 (21:39 -0800)]
Remove unused API L2CA_CancelBleConnectReq

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: Ie2e3ce9fcadbb98036bc38db2b3645b0e05009a3

3 years agogatt_disconnect: Remove L2CA_CancelBleConnectReq
Hansong Zhang [Wed, 13 Jan 2021 05:15:31 +0000 (21:15 -0800)]
gatt_disconnect: Remove L2CA_CancelBleConnectReq

When the link is not up, we need to cancel create connection.  In this
case, calling L2CA_CancelBleConnectReq() is just removing the gatt
direct connect client CONN_MGR_ID_L2CAP.  Then we clean up tcb.

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: Ie294b7ad9c4429af71c45afe7b0a1ae6327dee2c

3 years agoRefactor LE disconnnect reason
Hansong Zhang [Wed, 13 Jan 2021 03:06:44 +0000 (19:06 -0800)]
Refactor LE disconnnect reason

When we initiate a disconnection, the reason should always be terminated
by local host.  We only need to check the reason when there is a
disconnection complete HCI event.  Therefore, we can get rid of
L2CA_GetDisconnectReason().

The only GATT app using disconnect reason is HOGP, and the only
interesting state is connection timeout.  Send this event from shim.

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: I89973ece3ab5f24f3d1bc015daaf758d0600d002

3 years agoMerge changes I8e04ea0c,Ia710365d
Treehugger Robot [Wed, 13 Jan 2021 19:43:55 +0000 (19:43 +0000)]
Merge changes I8e04ea0c,Ia710365d

* changes:
  gd: Handle data status for extended advertising report
  gd: Handle scan response

3 years agop_clcb->reason is never set
Hansong Zhang [Wed, 13 Jan 2021 01:47:08 +0000 (17:47 -0800)]
p_clcb->reason is never set

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: I1a19ef5a938c6e8275c379a7caaffec711c8057f

3 years agoRemove unused data length API
Hansong Zhang [Wed, 13 Jan 2021 00:34:53 +0000 (16:34 -0800)]
Remove unused data length API

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: I5ac24f146dfee55b6e15f8bce80f034e6ff7c3c9

3 years agoSupport BTM_SetBleDataLength when L2cap shim is on
Hansong Zhang [Wed, 13 Jan 2021 00:22:00 +0000 (16:22 -0800)]
Support BTM_SetBleDataLength when L2cap shim is on

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: I672786a2414f34666f2734f9aa8c8e200a052466

3 years agoGATT: Set data length directly
Hansong Zhang [Wed, 13 Jan 2021 00:17:27 +0000 (16:17 -0800)]
GATT: Set data length directly

Since only GATT, hearing aid (hardcoded), JNI (hidden API) can set data
length, we just skip L2cap set data length path, and directly send HCI
command.

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: Id9dd7f9bdea69b025650ff7a287ba55c0d31db75

3 years agoClean up BTM_SetBleDataLength
Hansong Zhang [Wed, 13 Jan 2021 00:14:13 +0000 (16:14 -0800)]
Clean up BTM_SetBleDataLength

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: I217fd560afbda434e8bab7effc3716cfcd18a7c2

3 years agoSimplify max data length request
Hansong Zhang [Wed, 13 Jan 2021 00:11:26 +0000 (16:11 -0800)]
Simplify max data length request

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: I422f6bd0c3a246fb9395b116fdf53f7f56a4bc69

3 years agoBLE_LLT_INCLUDED is always true
Hansong Zhang [Tue, 12 Jan 2021 22:33:30 +0000 (14:33 -0800)]
BLE_LLT_INCLUDED is always true

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: If5daa3237ad771eb4f96d0f34d31a94b63433185

3 years agoClean up L2CA_UpdateBleConnParams
Hansong Zhang [Tue, 12 Jan 2021 21:03:29 +0000 (13:03 -0800)]
Clean up L2CA_UpdateBleConnParams

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: Ia5e9921eb14d6303b96ffbc85f31aa3f7d654eba

3 years agogd: Handle data status for extended advertising report
Chienyuan [Tue, 12 Jan 2021 14:34:44 +0000 (22:34 +0800)]
gd: Handle data status for extended advertising report

Tag: #gd-refactor
Bug: 177044452
Test: gd/cert/run --host
Change-Id: I8e04ea0cb1b8df795fdd4287a56262ac211c4f16

3 years agogd: Handle scan response
Chienyuan [Mon, 11 Jan 2021 14:25:11 +0000 (22:25 +0800)]
gd: Handle scan response

Tag: #gd-refactor
Bug: 177044452
Test: gd/cert/run --host
Change-Id: Ia710365dba1901803fd8c85d3cecb27f22d25bc5

3 years agoMerge "gd: Set scan response data based on AdvertisingType"
Treehugger Robot [Wed, 13 Jan 2021 06:22:34 +0000 (06:22 +0000)]
Merge "gd: Set scan response data based on AdvertisingType"

3 years agoMerge changes I442176d1,Ib147e50a,I9f4de837,Ib9cd95d0
Zach Johnson [Wed, 13 Jan 2021 04:45:23 +0000 (04:45 +0000)]
Merge changes I442176d1,Ib147e50a,I9f4de837,Ib9cd95d0

* changes:
  rusty-gd: most of the HCI shim layer
  move le_advertising_manager_test over to PyHci
  Emit checker for command status opcodes, remove unnecessary overloads
  HciLayerFacade -> HciFacade

3 years agorusty-gd: most of the HCI shim layer
Zach Johnson [Mon, 21 Dec 2020 18:01:45 +0000 (10:01 -0800)]
rusty-gd: most of the HCI shim layer

(command sending not connected yet)

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I442176d1e29485dab56dcaba53f0975de144a1fb

3 years agomove le_advertising_manager_test over to PyHci
Zach Johnson [Sat, 19 Dec 2020 03:29:07 +0000 (19:29 -0800)]
move le_advertising_manager_test over to PyHci

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run
Change-Id: Ib147e50a91dd0c9d31905317028e267ff2b71070

3 years agoEmit checker for command status opcodes, remove unnecessary overloads
Zach Johnson [Fri, 18 Dec 2020 22:00:37 +0000 (14:00 -0800)]
Emit checker for command status opcodes, remove unnecessary overloads

simplifies python, facades, etc

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run
Change-Id: I9f4de8373efb9bf07c55bcab9a7bc31a473d9c25

3 years agoHciLayerFacade -> HciFacade
Zach Johnson [Fri, 18 Dec 2020 21:08:26 +0000 (13:08 -0800)]
HciLayerFacade -> HciFacade

Layer is redundant

Bug: 171749953
Tag: #gd-refactor
Test: cert/run
Change-Id: Ib9cd95d069a57e590fa2b4c8b438ab01951d4ec6

3 years agoClean up BTA_GATTC_Open
Hansong Zhang [Tue, 12 Jan 2021 21:24:38 +0000 (13:24 -0800)]
Clean up BTA_GATTC_Open

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: I12263c05acd4ba04e09544b95388a13461dc4e93

3 years agoBTM_Sec: AUTHENTICATE should imply MITM
Hansong Zhang [Tue, 12 Jan 2021 07:48:47 +0000 (23:48 -0800)]
BTM_Sec: AUTHENTICATE should imply MITM

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: If492a5bfe2a3945ebf3f1d1a55c0a0f395b5f83b

3 years agoL2cap: Pass remote features to btm_sec
Hansong Zhang [Tue, 12 Jan 2021 05:49:01 +0000 (21:49 -0800)]
L2cap: Pass remote features to btm_sec

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: I0b8de4ce270caf18b1b07930f04e9905adebf622

3 years agoShim hack: Add SCO disconnect callback
Hansong Zhang [Tue, 12 Jan 2021 01:30:34 +0000 (17:30 -0800)]
Shim hack: Add SCO disconnect callback

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: I3f2ba43702542db6e07b1f6f61b9687ef178310c

3 years agoL2cap LE shim: Use link property listener
Hansong Zhang [Mon, 11 Jan 2021 23:00:21 +0000 (15:00 -0800)]
L2cap LE shim: Use link property listener

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: I171e0c21a83f9f5e6eca8aba5dc9861737c60c8b

3 years agoLE: Add link property listener and phy update
Hansong Zhang [Mon, 11 Jan 2021 21:15:15 +0000 (13:15 -0800)]
LE: Add link property listener and phy update

Add L2cap LE LinkPropertyListener.
Add PHY update listener for ACL and L2cap.

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: I691dbcd86d63998a7ff7f8cb5889bba53ad4aaca

3 years agoMerge changes I48f17bc8,I46294bbf,I74d0b45a,I749eb082,I71224efc, ...
Treehugger Robot [Tue, 12 Jan 2021 20:38:12 +0000 (20:38 +0000)]
Merge changes I48f17bc8,I46294bbf,I74d0b45a,I749eb082,I71224efc, ...

* changes:
  gd_acl: Add ACL connection history
  Add gd/common/strings::StringFormatTimeWithMilliseconds
  bt_headless: Add connect/disconnect timeouts
  Include BTM_PmRegister::callback
  Use main/shim/dumpsys::supervision_timeout_to_seconds
  Add main/shim/dumpsys::supervision_timeout_to_seconds
  bt_headless: Add connect test

3 years agogd_acl: Add ACL connection history
Chris Manton [Fri, 8 Jan 2021 17:59:25 +0000 (09:59 -0800)]
gd_acl: Add ACL connection history

Towards discoverable code

Bug: 176960731
Tag: #refactor
Test: gd/cert/run

Change-Id: I48f17bc8826530a998e4f11d1eecf32574e6ad88

3 years agoAdd gd/common/strings::StringFormatTimeWithMilliseconds
Chris Manton [Sat, 9 Jan 2021 00:52:30 +0000 (16:52 -0800)]
Add gd/common/strings::StringFormatTimeWithMilliseconds

Also fix local/gm timezone test issue

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: compile & verify basic functions working

Change-Id: I46294bbf69754be3bf4749fa1bb31320606659cf

3 years agobt_headless: Add connect/disconnect timeouts
Chris Manton [Fri, 8 Jan 2021 18:16:21 +0000 (10:16 -0800)]
bt_headless: Add connect/disconnect timeouts

Towards testable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run

Change-Id: I74d0b45a737efcbe1f855346d08a07e085e56107

3 years agoInclude BTM_PmRegister::callback
Chris Manton [Fri, 8 Jan 2021 18:15:45 +0000 (10:15 -0800)]
Include BTM_PmRegister::callback

Condition using tBTM_PM_REGISTER::

Bug: 163134718
Tag: #refactor
Test: gd/cert/run

Change-Id: I749eb082092adebdd441784db6f829c912839000

3 years agoUse main/shim/dumpsys::supervision_timeout_to_seconds
Chris Manton [Thu, 7 Jan 2021 22:51:59 +0000 (14:51 -0800)]
Use main/shim/dumpsys::supervision_timeout_to_seconds

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run

Change-Id: I71224efcf0026f69e83d19b711590f2222b80f92

3 years agoAdd main/shim/dumpsys::supervision_timeout_to_seconds
Chris Manton [Thu, 7 Jan 2021 22:50:02 +0000 (14:50 -0800)]
Add main/shim/dumpsys::supervision_timeout_to_seconds

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run

Change-Id: Icd73d874a7143efdf33383ad3b096305c21d98b8

3 years agobt_headless: Add connect test
Chris Manton [Thu, 7 Jan 2021 22:37:00 +0000 (14:37 -0800)]
bt_headless: Add connect test

Towards testable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run

Change-Id: I91eafe7e8047638581dcda75f60527572d842ec6

3 years agoIncrease RFC_MCB_RELEASE_INACT_TIMER to 20 seconds
Hansong Zhang [Tue, 12 Jan 2021 07:22:33 +0000 (23:22 -0800)]
Increase RFC_MCB_RELEASE_INACT_TIMER to 20 seconds

Say we first connect to a remote device using RFCOMM.  The remote
decides to bond with us before we establish a channel.  This could take
longer than 2 seconds.

In the past we handle this before we create L2cap channel.  However,
re-bond can happen during RFCOMM session, because security requirement
might have changed.

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: I7d5618b37d5414b10abe7497c3ea6819fb802db7

3 years agogd: Set scan response data based on AdvertisingType
Chienyuan [Mon, 11 Jan 2021 14:14:53 +0000 (22:14 +0800)]
gd: Set scan response data based on AdvertisingType

Tag: #gd-refactor
Bug: 169125803
Test: cert/run --host
Test: atest --host bluetooth_test_gd
Change-Id: Ib73a03398623fd99d6bf1234510048faef1ea60b

3 years agoMerge changes from topic "Refactor StartScan/StopScan for GD"
Treehugger Robot [Tue, 12 Jan 2021 01:59:25 +0000 (01:59 +0000)]
Merge changes from topic "Refactor StartScan/StopScan for GD"

* changes:
  gd: replace old scan APIs and refactor tests
  gd: Implement basic scan function

3 years agoInclude stack/gatt/gatt_db::stack/btm/btm_ble_int
Chris Manton [Mon, 11 Jan 2021 23:33:31 +0000 (15:33 -0800)]
Include stack/gatt/gatt_db::stack/btm/btm_ble_int

Broken yukawa build

Bug: 177256931
Test: Builds and compiles
Tag: #refactor
Change-Id: Icc5e6bf1a5c936b5de390abe719d84b2836b0169

3 years agoMerge changes Ice686602,I577c366c
Zach Johnson [Mon, 11 Jan 2021 23:46:29 +0000 (23:46 +0000)]
Merge changes Ice686602,I577c366c

* changes:
  rusty-gd: some facade cleanup
  rusty-gd: add le events to facade

3 years agobtm_process_clk_off_comp_evt is no-op
Hansong Zhang [Sat, 9 Jan 2021 00:24:37 +0000 (16:24 -0800)]
btm_process_clk_off_comp_evt is no-op

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: Ice1653170425e7fb0b6f116ab7982f76f0b0c0b4

3 years agoMerge "gatt: Extend Bluetooth GATT API with eatt support"
Jakub Pawlowski [Mon, 11 Jan 2021 22:28:49 +0000 (22:28 +0000)]
Merge "gatt: Extend Bluetooth GATT API with eatt support"

3 years agoLE L2cap security enforcement interface minor fix
Hansong Zhang [Sat, 9 Jan 2021 00:23:44 +0000 (16:23 -0800)]
LE L2cap security enforcement interface minor fix

Move the code for default impl.

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: I3faf430ac04fbb825595151b9ae5ca9cad233e55

3 years agoImplement robust caching (client)
HsingYuan Lo [Mon, 11 Jan 2021 10:14:48 +0000 (18:14 +0800)]
Implement robust caching (client)

Flag:
- Use flag to enable/disable robust caching on client side

When receiving service changed indication
- set read_db_hash flag to true

Read db hash function and response handler
- add bta_gattc_read_db_hash
- add bta_gattc_read_db_hash_cmpl
  - reset read_db_hash flag
  - If hash match, set states of all related clcb back to CONN_ST
  - If hash not match, start service discovery

When start service discovery is called
- read db hash first if read_db_hash flag is on
- start service discovery immediately if above request is rejected
- start service discovery immediately if read_db_hash flag is off

When receiving response during discover state
- call bta_gattc_read_db_hash_cmpl,
    if BTA_GATTC_DISCOVER_REQ_READ_DB_HASH is set
- call bta_gattc_read_ext_prop_desc_cmpl,
    if BTA_GATTC_DISCOVER_REQ_READ_EXT_PROP_DESC is set

When DATABASE OUT OF SYNC is received during connected state
- send the error(0x12) to application layer
- start service discovery immediately

When DATABASE OUT OF SYNC is received during discover state
- if the retry count exceeds the limit, do nothing
- otherwise restart service discovery again, and increase the retry count

When service discovery is completed (bta_gattc_explore_srvc_finished)
- if result is GATT_SUCCESS, reset the count to zero

Bug: 154056389
Test: compile & verify gatt client behavior
Tag: #feature
Change-Id: I8e3e03302c03f49bda40f0ec20ad5c607ef6dcdf

3 years agoL2cap: Reroute link callbacks to new listener
Hansong Zhang [Fri, 8 Jan 2021 23:53:03 +0000 (15:53 -0800)]
L2cap: Reroute link callbacks to new listener

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: I67a567c90e3162eea82583d2ed91e2c031a26e96

3 years agoL2cap: Send link callbacks to listener
Hansong Zhang [Fri, 8 Jan 2021 23:19:16 +0000 (15:19 -0800)]
L2cap: Send link callbacks to listener

Send OnRoleChange, OnReadClockOffset, OnModeChange, OnModeChange to
listener.

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: I2c5d0d2084a1064de620f4617a3b60ce11960ebe

3 years agoIntroduce L2cap classic link property listener
Hansong Zhang [Fri, 8 Jan 2021 20:53:29 +0000 (12:53 -0800)]
Introduce L2cap classic link property listener

For shim, and some other module in the future, to receive some link
callbacks, which are for non-security purposes.

Test: cert/run
Tag: #gd-refactor
Bug: 141555841
Change-Id: I8842ac63b98d8233f7af00a8d2e85a4ff166d828

3 years agoRe-log stack/btm/btm_dev::btm_sec_alloc_dev
Chris Manton [Thu, 7 Jan 2021 22:31:44 +0000 (14:31 -0800)]
Re-log stack/btm/btm_dev::btm_sec_alloc_dev

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run

Change-Id: I63bd3eb1a9fca3e2df3257bc4c3d899f1bb07380

3 years agoProperly include stack/btm/btm_sec::smp_int.h
Chris Manton [Thu, 7 Jan 2021 21:52:27 +0000 (13:52 -0800)]
Properly include stack/btm/btm_sec::smp_int.h

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run

Change-Id: I305c6e994fa4400ca3418f27b3af6aa20f38927b

3 years agoComplete stack/include/btm_client_interface::<BTM interface>
Chris Manton [Thu, 7 Jan 2021 21:11:11 +0000 (13:11 -0800)]
Complete stack/include/btm_client_interface::<BTM interface>

Towards modular code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run

Change-Id: I3c5e80a2b0745d847e09be0390176d2d8337f777

3 years agoAdd LOG_TAG stack/avct/avct_bcb_act::bluetooth
Chris Manton [Wed, 6 Jan 2021 22:11:45 +0000 (14:11 -0800)]
Add LOG_TAG  stack/avct/avct_bcb_act::bluetooth

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run

Change-Id: I0d885ccead7b0ef814d33bf6d0961a0376c10e10

3 years agoAdd stack/btm/btm_sec::NotifyBondingCanceled
Chris Manton [Tue, 5 Jan 2021 01:24:22 +0000 (17:24 -0800)]
Add stack/btm/btm_sec::NotifyBondingCanceled

Towards encapsulated code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run

Change-Id: I5a582d71c9637caf4985790aef32aafd71c21e3e

3 years agoUn-include stack/l2cap/l2c_link declare explictly
Chris Manton [Fri, 4 Dec 2020 16:42:44 +0000 (08:42 -0800)]
Un-include stack/l2cap/l2c_link declare explictly

Towards modular code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run

Change-Id: I81e882d6c9b8941390b985b017c74a3d0f31bd21

3 years agoRe-log btif/src/btif_av::btif_av_handle_event
Chris Manton [Fri, 4 Dec 2020 16:40:59 +0000 (08:40 -0800)]
Re-log btif/src/btif_av::btif_av_handle_event

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run
No-Typo-Check: Legacy terminology

Change-Id: I42597fc1d95fd47358433ec18ced3f41b08b06c8

3 years agoRe-log stack/gatt/gatt_api::GATTC_ConfigureMTU
Chris Manton [Sat, 2 Jan 2021 19:11:27 +0000 (11:11 -0800)]
Re-log stack/gatt/gatt_api::GATTC_ConfigureMTU

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run

Change-Id: I30f1d93eea21c74f8e8b59c66787f0e4d56de12a

3 years agoCanonicalize stack/gatt/gatt_attr::gatt_profile_cback
Chris Manton [Sat, 21 Nov 2020 01:34:39 +0000 (17:34 -0800)]
Canonicalize stack/gatt/gatt_attr::gatt_profile_cback

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run

Change-Id: I7dafaa0c6e624ada14f0f0beabc6ee2a123a2e0c

3 years agoUse proper API main/shim/acl::BTM_LogHistory
Chris Manton [Mon, 21 Dec 2020 18:44:20 +0000 (10:44 -0800)]
Use proper API main/shim/acl::BTM_LogHistory

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run

Change-Id: Iab4c4278a02e2d0dff4f4e40a18911dee2620c5b

3 years agoRe-log btif/src/btif_dm::btif_dm_proc_loc_oob
Chris Manton [Sat, 7 Nov 2020 02:39:32 +0000 (18:39 -0800)]
Re-log btif/src/btif_dm::btif_dm_proc_loc_oob

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run

Change-Id: I4024f1e1e5c572e51073021502079bc97199157c

3 years agoCanonicalize btif/src/btif_gatt::btgattInterface
Chris Manton [Thu, 19 Nov 2020 21:55:48 +0000 (13:55 -0800)]
Canonicalize btif/src/btif_gatt::btgattInterface

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run

Change-Id: I23c55595082991614ce445405fa46514cbbda5c5

3 years agoMerge "Updateability: Remove IBluetoothHeadsetPhone aidl"
Chen Chen [Mon, 11 Jan 2021 19:00:45 +0000 (19:00 +0000)]
Merge "Updateability: Remove IBluetoothHeadsetPhone aidl"

3 years agogatt: Extend Bluetooth GATT API with eatt support
Łukasz Rymanowski [Wed, 19 Aug 2020 12:51:19 +0000 (14:51 +0200)]
gatt: Extend Bluetooth GATT API with eatt support

Tag: #feature
Test: manually verified against device supporting EATT
Bug: 159786353
Sponsor: jpawlowski@
Change-Id: Ib128308b08fcb047b123480434009b45a65f8e1f

3 years agogd: replace old scan APIs and refactor tests
Chienyuan [Fri, 8 Jan 2021 09:45:35 +0000 (17:45 +0800)]
gd: replace old scan APIs and refactor tests

Tag: #gd-refactor
Bug: 177044452
Test: gd/cert/run --host
Change-Id: Ic54f0eba9e4783ea8c34e28f11f07b3b94a46fcb

3 years agogd: Implement basic scan function
Chienyuan [Thu, 7 Jan 2021 13:22:03 +0000 (21:22 +0800)]
gd: Implement basic scan function

Tag: #refactor
Bug: 169390539
Test: gd/cert/run --host
Change-Id: Ifb4ea21a4cdab2d3587a9d5d4cf1255be536b231

3 years agoMerge changes from topic "dip1.3"
Treehugger Robot [Fri, 8 Jan 2021 21:42:32 +0000 (21:42 +0000)]
Merge changes from topic "dip1.3"

* changes:
  Use Bluetooth UUID definitions of header file
  DIP: Implement API to get device identification information

3 years agorusty-gd: some facade cleanup
Zach Johnson [Fri, 18 Dec 2020 20:47:50 +0000 (12:47 -0800)]
rusty-gd: some facade cleanup

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Ice6866028f9ea6e1b94d7aa6a240258731d7aa32

3 years agorusty-gd: add le events to facade
Zach Johnson [Wed, 16 Dec 2020 23:14:47 +0000 (15:14 -0800)]
rusty-gd: add le events to facade

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I577c366cbeebb22492eea3bdc5ebcab9ebd27fa9

3 years agoMerge "rusty-gd: Fill in new and parse methods for *Data structs"
Qasim Javed [Fri, 8 Jan 2021 20:11:04 +0000 (20:11 +0000)]
Merge "rusty-gd: Fill in new and parse methods for *Data structs"

3 years agoL2cap LE shim improvements
Hansong Zhang [Wed, 6 Jan 2021 21:13:39 +0000 (13:13 -0800)]
L2cap LE shim improvements

Implement connection updates

Test: CtsVerifier
Tag: #gd-refactor
Bug: 141555841
Change-Id: I52891feb017020d9d557e8dac209f0474a18524d

3 years agoFix crash when removing bond to HID device
Jakub Pawlowski [Fri, 8 Jan 2021 13:05:58 +0000 (14:05 +0100)]
Fix crash when removing bond to HID device

This fixes:
JNI DETECTED ERROR IN APPLICATION: a thread (tid 4760 is making JNI calls
without being attached in call to ExceptionCheck

Bug: none
Test: manually connect and unbond HID device
Tag: #feature
Change-Id: I2f8bd0be6229c84ef34bd236962f00a69e630c5c

3 years agogd_acl: Assert with handle value
Chris Manton [Fri, 8 Jan 2021 01:45:07 +0000 (17:45 -0800)]
gd_acl: Assert with handle value

Toward stable code

Bug: 163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I7480ab4d560f92638e09e474ac44f38f923f528e

3 years agoUpdateability: Remove IBluetoothHeadsetPhone aidl
Chen Chen [Wed, 22 Jan 2020 19:03:05 +0000 (11:03 -0800)]
Updateability: Remove IBluetoothHeadsetPhone aidl

Bug: 147244266
Test: Build
Change-Id: I1b7d32fb44fbcb54ed73fd0ab9f20c81e5c60e16

3 years agoMerge changes Idef1560b,I40243c0f,I5c466874,Ie4d1438c,I38a17794, ...
Treehugger Robot [Fri, 8 Jan 2021 01:14:01 +0000 (01:14 +0000)]
Merge changes Idef1560b,I40243c0f,I5c466874,Ie4d1438c,I38a17794, ...

* changes:
  Complete hci legacy interface
  Re-log bta/ag/bta_ag_sco::bta_ag_remove_sco
  Re-log bta/ag/bta_ag_cmd::bta_ag_hfp_result
  Re-log bta/ag/bta_ag_main::bta_ag_api_result
  Add and use tBTM_CB::tACL_CB::Init
  Un-include stack/btm/btm_int
  Properly include stack/test/common/mock_btm_layer
  Use tACL_CONN::SupportsSecureConnections
  Use proper types bta/ag/bta_ag_sco::tBTA_AG_EVT
  Declare stack/gatt/gatt_utils::btm_ble_read_sec_key_size
  Add stack/include/hcidefs::hci_mode_text
  Use btm_client_interface::init,free
  btm_loghistory: HeadsetInterface::PhoneStateChange
  Use inclusive language
  Enum-ify stack/smp/smp_int::tSMP_EVENT,tSMP_BR_EVENT
  Various inclusion stack/::
  Add API btm_client_interface methods
  Declare explicitly global tBTM_CB
  Move stack/include/hcimsgs#defs into ble compilation unit
  Move stack/include/hcimsgs#defs into br_edr compilation unit
  Spell check HCIC_BLE_ENCRYPT_KEY_SIZE

3 years agorusty-gd: Fill in new and parse methods for *Data structs
Qasim Javed [Wed, 6 Jan 2021 22:36:10 +0000 (14:36 -0800)]
rusty-gd: Fill in new and parse methods for *Data structs

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest

Change-Id: Ifff55709c1a3d65ca443351e2e08effdd2fa34d8

3 years agoComplete hci legacy interface
Chris Manton [Thu, 7 Jan 2021 03:38:39 +0000 (19:38 -0800)]
Complete hci legacy interface

Towards modular and testable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Idef1560bb863b3fc400f2f2ec2cbc5c4495abf6d

3 years agoRe-log bta/ag/bta_ag_sco::bta_ag_remove_sco
Chris Manton [Fri, 18 Dec 2020 00:08:57 +0000 (16:08 -0800)]
Re-log bta/ag/bta_ag_sco::bta_ag_remove_sco

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I40243c0f58e142f6eddbcd85810446d0b3a70f5c

3 years agoRe-log bta/ag/bta_ag_cmd::bta_ag_hfp_result
Chris Manton [Fri, 18 Dec 2020 00:08:34 +0000 (16:08 -0800)]
Re-log bta/ag/bta_ag_cmd::bta_ag_hfp_result

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I5c46687486a1648c614ede6f495d7a13de3916fd

3 years agoRe-log bta/ag/bta_ag_main::bta_ag_api_result
Chris Manton [Sat, 19 Dec 2020 01:57:56 +0000 (17:57 -0800)]
Re-log bta/ag/bta_ag_main::bta_ag_api_result

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ie4d1438ced9daa7d74bea8c470508fdf562f045c

3 years agoAdd and use tBTM_CB::tACL_CB::Init
Chris Manton [Sat, 19 Dec 2020 04:22:26 +0000 (20:22 -0800)]
Add and use tBTM_CB::tACL_CB::Init

Towards encapsulated code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I38a17794c6f0af25b40d8b095621d9df658dff42

3 years agoUn-include stack/btm/btm_int
Chris Manton [Wed, 6 Jan 2021 01:42:27 +0000 (17:42 -0800)]
Un-include stack/btm/btm_int

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I1271da085b9ea67e579796e20e3664773ceefcd8

3 years agoProperly include stack/test/common/mock_btm_layer
Chris Manton [Thu, 7 Jan 2021 20:07:59 +0000 (12:07 -0800)]
Properly include stack/test/common/mock_btm_layer

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: I9c7c26669f9169747bf62d9d8a88668220a1abef

3 years agoUse tACL_CONN::SupportsSecureConnections
Chris Manton [Sat, 2 Jan 2021 03:12:36 +0000 (19:12 -0800)]
Use tACL_CONN::SupportsSecureConnections

Towards encapsulated code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I7bfe087dcc28cfaeb492db1e1a6ec276e1e29ce2

3 years agoUse proper types bta/ag/bta_ag_sco::tBTA_AG_EVT
Chris Manton [Tue, 15 Dec 2020 02:25:58 +0000 (18:25 -0800)]
Use proper types bta/ag/bta_ag_sco::tBTA_AG_EVT

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I43215ff771cb4163ced273778e527b63891287e7

3 years agoDeclare stack/gatt/gatt_utils::btm_ble_read_sec_key_size
Chris Manton [Wed, 6 Jan 2021 01:49:43 +0000 (17:49 -0800)]
Declare stack/gatt/gatt_utils::btm_ble_read_sec_key_size

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I6b2a9a8205ef3d393e4b85907f89bf222a26cce2

3 years agoAdd stack/include/hcidefs::hci_mode_text
Chris Manton [Sat, 19 Dec 2020 01:59:54 +0000 (17:59 -0800)]
Add stack/include/hcidefs::hci_mode_text

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I3ad073e4db75aad362c02e0e96d768ba40bb8452

3 years agoUse btm_client_interface::init,free
Chris Manton [Wed, 6 Jan 2021 01:48:55 +0000 (17:48 -0800)]
Use btm_client_interface::init,free

Towards modular code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Iba73720c0ded4b6091ad2bbec1ff4d9225fa731d

3 years agobtm_loghistory: HeadsetInterface::PhoneStateChange
Chris Manton [Thu, 17 Dec 2020 22:38:49 +0000 (14:38 -0800)]
btm_loghistory: HeadsetInterface::PhoneStateChange

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I3aee041f42df8446ee6853f2a6c9ee356c808b27

3 years agoUse inclusive language
Chris Manton [Wed, 6 Jan 2021 21:12:49 +0000 (13:12 -0800)]
Use inclusive language

Towards inclusive language

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Icb382782abddf5a63e1145b6a9f5e65526540fb7

3 years agoEnum-ify stack/smp/smp_int::tSMP_EVENT,tSMP_BR_EVENT
Chris Manton [Sun, 11 Oct 2020 23:58:33 +0000 (16:58 -0700)]
Enum-ify stack/smp/smp_int::tSMP_EVENT,tSMP_BR_EVENT

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Idf496f1d8156cab0c7c3db3418f3dffa4645eb3a

3 years agoVarious inclusion stack/::
Chris Manton [Wed, 6 Jan 2021 01:45:08 +0000 (17:45 -0800)]
Various inclusion stack/::

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Iba63fafcfe774cbf1e29c39fd5cf8ca7e67b918d

3 years agoAdd API btm_client_interface methods
Chris Manton [Wed, 6 Jan 2021 01:39:22 +0000 (17:39 -0800)]
Add API btm_client_interface methods

Towards modular code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I2b73a014bb83ccb65bc8db71dda4389f69a39536

3 years agoDeclare explicitly global tBTM_CB
Chris Manton [Wed, 6 Jan 2021 01:37:38 +0000 (17:37 -0800)]
Declare explicitly global tBTM_CB

Towards modular code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ia9f3f8208e4fd439196137e023e176ca95f645b4

3 years agoMove stack/include/hcimsgs#defs into ble compilation unit
Chris Manton [Tue, 5 Jan 2021 21:11:15 +0000 (13:11 -0800)]
Move stack/include/hcimsgs#defs into ble compilation unit

Removing unnecessary exposure

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I99c216852f96a8d12b1bdafc73414dc0ad03ff02

3 years agoMove stack/include/hcimsgs#defs into br_edr compilation unit
Chris Manton [Tue, 5 Jan 2021 21:06:10 +0000 (13:06 -0800)]
Move stack/include/hcimsgs#defs into br_edr compilation unit

Removing unnecessary exposure

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I103052d539966f9055d8aaad7a415ce4d617044e

3 years agoSpell check HCIC_BLE_ENCRYPT_KEY_SIZE
Chris Manton [Wed, 6 Jan 2021 21:26:58 +0000 (13:26 -0800)]
Spell check HCIC_BLE_ENCRYPT_KEY_SIZE

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I0097d9f4b3e428a6a1dcf1ed732a14f7b46a287b

3 years agoRevert "Updateability: Remove IBluetoothHeadsetPhone aidl"
chapin [Thu, 7 Jan 2021 17:00:29 +0000 (17:00 +0000)]
Revert "Updateability: Remove IBluetoothHeadsetPhone aidl"

Revert submission 1311861-BluetoothInCallService

Reason for revert: Bug: 176883407
Reverted Changes:
Ie3a5ceda5:UpdateAbility: Implement BluetoothInCallService an...
I2e3bc64eb:Updateability: Remove IBluetoothHeadsetPhone aidl
If26bab4ad:Bluetooth updateability: Move BluetoothPhoneServic...

Change-Id: Ia301026b4ce2cadd5e27c878f74f91c504be014f

3 years agoMerge "Implement bluetooth interface functions to check if a headset supports voice...
Treehugger Robot [Thu, 7 Jan 2021 17:55:04 +0000 (17:55 +0000)]
Merge "Implement bluetooth interface functions to check if a headset supports voice recognition as well as echo cancellation and/or noise reduction"

3 years agoMerge "Implement robust caching (server)"
HsingYuan Lo [Thu, 7 Jan 2021 10:00:58 +0000 (10:00 +0000)]
Merge "Implement robust caching (server)"

3 years agoImplement bluetooth interface functions to check if a headset supports
Rahul Sabnis [Mon, 14 Dec 2020 19:02:44 +0000 (11:02 -0800)]
Implement bluetooth interface functions to check if a headset supports
voice recognition as well as echo cancellation and/or noise reduction

Tag: #feature
Bug: 172960943
Test: Manual
Change-Id: I5e78b05f1bc5e4a44c506e02fe5fc79fdf3aebfd

3 years agohci_legacy_interface: Add Start/Cancel Inquiry
Chris Manton [Tue, 5 Jan 2021 18:20:53 +0000 (10:20 -0800)]
hci_legacy_interface: Add Start/Cancel Inquiry

Towards testable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ieb9aa232ccc29de4aec15b722ff7a105859a1ca4

3 years agoRe-log btif/src/btif_hf::btif_hf_upstreams_evt
Chris Manton [Thu, 17 Dec 2020 21:49:41 +0000 (13:49 -0800)]
Re-log btif/src/btif_hf::btif_hf_upstreams_evt

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ice0d88dfa5a2e80740ff86b4380d39eb2257b675