OSDN Git Service

android-x86/system-bt.git
3 years agoLE L2cap: Use client callback if locally initiated
Hansong Zhang [Tue, 15 Dec 2020 21:41:32 +0000 (13:41 -0800)]
LE L2cap: Use client callback if locally initiated

Don't use callbacks for registered service (we as server).  This could
confuse user (shim).

Tag: #gd-refactor
Test: CtsVerifier
Bug: 141555841
Change-Id: Icde090fa609043a61301c18782874dad9ade99d1

3 years agoMerge changes If1e078bd,I8ee5baf6
Zach Johnson [Wed, 16 Dec 2020 03:20:00 +0000 (03:20 +0000)]
Merge changes If1e078bd,I8ee5baf6

* changes:
  rusty-gd: refine stack ffi a bit
  Apply rustfmt to keep checkin hook happy

3 years agoMerge "Revert "Cert: Temporarily disable the SSP OOB test""
Treehugger Robot [Wed, 16 Dec 2020 03:14:36 +0000 (03:14 +0000)]
Merge "Revert "Cert: Temporarily disable the SSP OOB test""

3 years agoRevert "Cert: Temporarily disable the SSP OOB test"
Myles Watson [Wed, 16 Dec 2020 01:05:26 +0000 (01:05 +0000)]
Revert "Cert: Temporarily disable the SSP OOB test"

This reverts commit e17119395069b33a0f6e1080e80d5b1e10c35be4.

Reason for revert: The CL that fixed the test landed
Bug: 175033589
Test: cert/run SecurityTest
Tag: #gd-refactor
Change-Id: I4dd577f53a45abb2e0f6c52fc3d577ed6ab8e3ce

3 years agogd: Refactor ExtendedCreateAdvertiser function
Chienyuan [Tue, 15 Dec 2020 09:30:20 +0000 (17:30 +0800)]
gd: Refactor ExtendedCreateAdvertiser function

Tag: #gd-refactor
Bug: 169125803
Test: cert/run --host
Test: atest --host bluetooth_test_gd
Change-Id: I2fa3ddf5b50764e5dde5a613de473405824c4948

3 years agoMerge "Security: Wait for name request in link key notification"
Treehugger Robot [Tue, 15 Dec 2020 22:02:44 +0000 (22:02 +0000)]
Merge "Security: Wait for name request in link key notification"

3 years agoMerge changes I992b781d,Ic2cfde11,I8e8d5a05
Zach Johnson [Tue, 15 Dec 2020 21:56:21 +0000 (21:56 +0000)]
Merge changes I992b781d,Ic2cfde11,I8e8d5a05

* changes:
  rusty-gd: expose rust enums for enums
  rusty-gd: add builder structs
  rusty-gd: call children write_to()s

3 years agoMerge changes Icc40d3d8,I241bcf4e,I9406eb11,I8dea0a13,Ib4a05164, ...
Zach Johnson [Tue, 15 Dec 2020 21:55:03 +0000 (21:55 +0000)]
Merge changes Icc40d3d8,I241bcf4e,I9406eb11,I8dea0a13,Ib4a05164, ...

* changes:
  rusty-gd: update visibilities, put parse & to bytes on pub api
  rusty-gd: refine specialization
  rusty-gd: start specialzation frontend
  rusty-gd: add packet accessors
  rusty-gd: Add child & into for pub access packet structs
  rusty-gd: separate data storage from packet view

3 years agoMerge "LE Audio State Machine and Native Interface boilerplate"
Jakub Pawlowski [Tue, 15 Dec 2020 21:54:45 +0000 (21:54 +0000)]
Merge "LE Audio State Machine and Native Interface boilerplate"

3 years agorusty-gd: refine stack ffi a bit
Zach Johnson [Thu, 10 Dec 2020 21:08:19 +0000 (13:08 -0800)]
rusty-gd: refine stack ffi a bit

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: If1e078bdb64a41ee0a77e352617f39a0ab3155d5

3 years agoApply rustfmt to keep checkin hook happy
Zach Johnson [Tue, 15 Dec 2020 21:47:52 +0000 (13:47 -0800)]
Apply rustfmt to keep checkin hook happy

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I8ee5baf6fcfabcaefe08a7792e655e41cf502df1

3 years agoMerge "Change rust_grpcio modules to rust_protobuf."
Ivan Lozano [Tue, 15 Dec 2020 21:38:31 +0000 (21:38 +0000)]
Merge "Change rust_grpcio modules to rust_protobuf."

3 years agoMerge "Cert: Temporarily disable the SSP OOB test"
Myles Watson [Tue, 15 Dec 2020 19:32:11 +0000 (19:32 +0000)]
Merge "Cert: Temporarily disable the SSP OOB test"

3 years agoCert: Temporarily disable the SSP OOB test
Martin Brabham [Tue, 15 Dec 2020 18:29:34 +0000 (10:29 -0800)]
Cert: Temporarily disable the SSP OOB test

Waiting on another CL to fix the underlying issue before re-enabling

Bug: 175033589
Test: cert/run SecurityTest
Tag: #gd-refactor
Change-Id: If24dfb92d987d2dc147ed396b9f6b9d4d249347d

3 years agoSecurity: Wait for name request in link key notification
Martin Brabham [Mon, 14 Dec 2020 20:31:03 +0000 (12:31 -0800)]
Security: Wait for name request in link key notification

For classic SSP numeric comparison we must wait at the
UserConfirmationRequest in order to get the name before
we display it to the user.  However, in the Out of Band
data flow we never get a UserConfirmationRequest.

Thus, we must wait in the link key notification if we
have not yet received a name response.

Remove setting to std::nullopt as the operator= in
std::optional causes the underlying pointer to be reset
and thus freed, but still accessed by the pointer we passed.

Bug: 175033589
Test: cert/run SecurityTest:test_successful_dut_initiated_ssp_oob --repeat=20
Tag: #gd-refactor
Change-Id: Ic3f424e22a0c596b21969d4882d0a9b06f7433ab

3 years agoMerge "AV stream state machine logging"
Treehugger Robot [Tue, 15 Dec 2020 13:31:25 +0000 (13:31 +0000)]
Merge "AV stream state machine logging"

3 years agoMerge "gd: Fragmentation for periodic advertising"
Treehugger Robot [Tue, 15 Dec 2020 02:33:41 +0000 (02:33 +0000)]
Merge "gd: Fragmentation for periodic advertising"

3 years agoMerge "rusty-gd: rename interop to ffi"
Zach Johnson [Tue, 15 Dec 2020 00:21:46 +0000 (00:21 +0000)]
Merge "rusty-gd: rename interop to ffi"

3 years agoMerge changes I5bc0330c,I7d68ca08,I3f5bba04
Treehugger Robot [Mon, 14 Dec 2020 23:26:53 +0000 (23:26 +0000)]
Merge changes I5bc0330c,I7d68ca08,I3f5bba04

* changes:
  enum-ify bta/include/bta_api::SSR_
  btm_history: Add acl power mode state
  Properly retrieve acl_conn stack/acl/btm_acl::BTM_IsBleConnection

3 years agoMerge changes Id10b509c,I3f1a6073,I07885881
Zach Johnson [Mon, 14 Dec 2020 23:05:00 +0000 (23:05 +0000)]
Merge changes Id10b509c,I3f1a6073,I07885881

* changes:
  rusty-gd: mark vector field writing as unimplemented
  rusty-gd: add support for struct fields in write_to()
  rusty-gd: start writing scalar fields in write_to()

3 years agoenum-ify bta/include/bta_api::SSR_
Chris Manton [Tue, 8 Dec 2020 21:35:21 +0000 (13:35 -0800)]
enum-ify bta/include/bta_api::SSR_

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I5bc0330c7e9fbf902b0b1f000017f5d733c7dcce

3 years agobtm_history: Add acl power mode state
Chris Manton [Tue, 8 Dec 2020 19:01:48 +0000 (11:01 -0800)]
btm_history: Add acl power mode state

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I7d68ca082c683f663024309e577041ba5ff5d02e

3 years agoProperly retrieve acl_conn stack/acl/btm_acl::BTM_IsBleConnection
Chris Manton [Tue, 8 Dec 2020 19:02:06 +0000 (11:02 -0800)]
Properly retrieve acl_conn stack/acl/btm_acl::BTM_IsBleConnection

Towards encapsulation

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I3f5bba04de53378dad998c5471f9ca20cd6be2d6

3 years agoMerge changes If9886370,I80a0fbce
Treehugger Robot [Mon, 14 Dec 2020 21:32:45 +0000 (21:32 +0000)]
Merge changes If9886370,I80a0fbce

* changes:
  GD-Cert: Symbolize ASAN triggered crashes
  GD-Facade: Enable ASAN but disable container overflow check

3 years agoMerge "rusty-gd: implement btsnoop"
Zach Johnson [Mon, 14 Dec 2020 20:51:16 +0000 (20:51 +0000)]
Merge "rusty-gd: implement btsnoop"

3 years agoMerge "Use canonical version of rustfmt"
Treehugger Robot [Mon, 14 Dec 2020 20:25:19 +0000 (20:25 +0000)]
Merge "Use canonical version of rustfmt"

3 years agoPrint what module is being started/stopped in crash
Hansong Zhang [Wed, 9 Dec 2020 20:31:16 +0000 (12:31 -0800)]
Print what module is being started/stopped in crash

Tag: #stability
Bug: 174293959
Test: cert/run
Change-Id: Ie1b5d6af3bc57b3672ba10307d6b0fa9c6267706

3 years agorusty-gd: expose rust enums for enums
Zach Johnson [Sat, 12 Dec 2020 23:13:33 +0000 (15:13 -0800)]
rusty-gd: expose rust enums for enums

break parsing primitive type out, just for parsing

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I992b781dd83c3a047970ee25f9bf70e8e1e14f9e

3 years agorusty-gd: update visibilities, put parse & to bytes on pub api
Zach Johnson [Sat, 12 Dec 2020 20:40:44 +0000 (12:40 -0800)]
rusty-gd: update visibilities, put parse & to bytes on pub api

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Icc40d3d81fc5681d3e54536ae56a1e1bf5b90896

3 years agorusty-gd: add builder structs
Zach Johnson [Sat, 12 Dec 2020 22:40:26 +0000 (14:40 -0800)]
rusty-gd: add builder structs

by making them structs, you must name the parameters explicitly (which
is great for readability - also it doesn't matter which order you
specify them as long as you specify them all)

since builders can be constructed for middle structs in the lineage, add
None option for child enums

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Ic2cfde113ccd6f8475c7514c513ac7b62b3689e3

3 years agorusty-gd: refine specialization
Zach Johnson [Sat, 12 Dec 2020 20:15:28 +0000 (12:15 -0800)]
rusty-gd: refine specialization

no need for accessors, define RCs that get loaded upon construction

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I241bcf4e5f3ad95df37b4d0d3b174728965a4f7f

3 years agorusty-gd: call children write_to()s
Zach Johnson [Sat, 12 Dec 2020 20:50:55 +0000 (12:50 -0800)]
rusty-gd: call children write_to()s

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I8e8d5a054e9a3f57328d9a0c1cdbaec28a6df9e2

3 years agorusty-gd: start specialzation frontend
Zach Johnson [Sat, 12 Dec 2020 06:44:28 +0000 (22:44 -0800)]
rusty-gd: start specialzation frontend

comment out and mark internal parse & ctors as unimplemented (child
parsing not ready yet)

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I9406eb111c56a88d31f4973fc4cda6facc9c18bb

3 years agorusty-gd: add packet accessors
Zach Johnson [Sat, 12 Dec 2020 05:47:56 +0000 (21:47 -0800)]
rusty-gd: add packet accessors

accessors for all ancestor fields too
stubbed against accessor functions (until inner child is ready)

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I8dea0a1380b70a8b050e277dc3a388751000f7bf

3 years agorusty-gd: Add child & into for pub access packet structs
Zach Johnson [Sat, 12 Dec 2020 05:13:17 +0000 (21:13 -0800)]
rusty-gd: Add child & into for pub access packet structs

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Ib4a0516495246ab73b981f8259500f4ab2a98d17

3 years agorusty-gd: mark vector field writing as unimplemented
Zach Johnson [Fri, 11 Dec 2020 18:56:45 +0000 (10:56 -0800)]
rusty-gd: mark vector field writing as unimplemented

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost
Change-Id: Id10b509cdca7e05e63c09c04b8c27dc72787e70f

3 years agorusty-gd: separate data storage from packet view
Zach Johnson [Sat, 12 Dec 2020 00:38:08 +0000 (16:38 -0800)]
rusty-gd: separate data storage from packet view

create XYZData structs & enums, which will be internally accessed through
the exposed view

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost
Change-Id: I734e1ce5198223b51364e0cb5cd8370104c7b8ef

3 years agorusty-gd: add support for struct fields in write_to()
Zach Johnson [Fri, 11 Dec 2020 18:50:24 +0000 (10:50 -0800)]
rusty-gd: add support for struct fields in write_to()

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost
Change-Id: I3f1a60733d2bf6bd77064523171f08dcb855ba7b

3 years agorusty-gd: start writing scalar fields in write_to()
Zach Johnson [Fri, 11 Dec 2020 18:40:26 +0000 (10:40 -0800)]
rusty-gd: start writing scalar fields in write_to()

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost
Change-Id: I07885881aa19538e62bd9cdcdac79127349f60b6

3 years agoMerge "Fix valid check"
Treehugger Robot [Mon, 14 Dec 2020 19:33:10 +0000 (19:33 +0000)]
Merge "Fix valid check"

3 years agoGD-Cert: Symbolize ASAN triggered crashes
Jack He [Mon, 14 Dec 2020 07:33:40 +0000 (23:33 -0800)]
GD-Cert: Symbolize ASAN triggered crashes

* Use llvm-symbolizer
* https://github.com/google/sanitizers/wiki/AddressSanitizerCallStack

Bug: 175033589
Test: gd/cert/run
Tag: #gd-refactor
Change-Id: If9886370bdccd207d16104a7240349a8c68af7c5

3 years agoMerge "GD: Make destructors virtual not override"
Treehugger Robot [Mon, 14 Dec 2020 18:29:53 +0000 (18:29 +0000)]
Merge "GD: Make destructors virtual not override"

3 years agoFix valid check
Greg Kaiser [Mon, 14 Dec 2020 15:13:27 +0000 (07:13 -0800)]
Fix valid check

We were checking peer_lmp_feature_valid[0] twice; we add a check
of peer_lmp_feature_valid[1].

Test: TreeHugger
Change-Id: Ibce650f4120ac9e8b801920d5bf7f45c3d260317

3 years agoUse canonical version of rustfmt
ThiƩbaud Weksteen [Mon, 14 Dec 2020 10:34:16 +0000 (11:34 +0100)]
Use canonical version of rustfmt

Enable rustfmt repohook.

Test: repo upload
Change-Id: I9836672a755021c16b9f609cea147664f92bd6e5

3 years agogd: Fragmentation for periodic advertising
Chienyuan [Mon, 14 Dec 2020 07:52:17 +0000 (15:52 +0800)]
gd: Fragmentation for periodic advertising

Tag: #gd-refactor
Bug: 149221472
Test: cert/run --host
Test: atest --host bluetooth_test_gd
Change-Id: I7370716cd8b01ce54de92deca759cafd0590cc15

3 years agoGD-Facade: Enable ASAN but disable container overflow check
Jack He [Sat, 12 Dec 2020 00:01:58 +0000 (16:01 -0800)]
GD-Facade: Enable ASAN but disable container overflow check

* AddressSanitizerContainerOverflow has false positives because not
  all dependencies are compiled with ASAN according to:
  https://github.com/google/sanitizers/wiki/AddressSanitizerContainerOverflow
* Hence we need to disable container overflow check. We do this at
  compile time per instructiosn at:
  https://github.com/google/sanitizers/wiki/AddressSanitizerFlags#run-time-flags

Bug: 175033589
Test: gd/cert/run
Tag: #gd-refactor
Change-Id: I80a0fbcef022101b57d1c68919add6acf6aa81e4

3 years agoRe-log bta/sys/bta_sys_conn::bta_sys_notify_role_chg
Chris Manton [Tue, 8 Dec 2020 06:18:32 +0000 (22:18 -0800)]
Re-log bta/sys/bta_sys_conn::bta_sys_notify_role_chg

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I66b27249f3b0ca8e947218af817d9f5367304156

3 years agoAdd stack/include/btm_api_types::power_mode_status_text
Chris Manton [Tue, 8 Dec 2020 06:18:16 +0000 (22:18 -0800)]
Add stack/include/btm_api_types::power_mode_status_text

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I0b45c76cec34d7bcd1358066514a5c09c6d5f6bf

3 years agoRe-log bta/dm/bta_dm_pm::bta_dm_pm_ssr
Chris Manton [Mon, 7 Dec 2020 03:09:29 +0000 (19:09 -0800)]
Re-log bta/dm/bta_dm_pm::bta_dm_pm_ssr

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ie600fbf1c3da0c5850c9b4712862d78b3430bbe4

3 years agoMove and add stack/acl/acl::power_mode_state_text
Chris Manton [Sun, 6 Dec 2020 19:35:43 +0000 (11:35 -0800)]
Move and add stack/acl/acl::power_mode_state_text

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I2a63399e186f2e25f83b3288d6407f79d5a1e021

3 years agoAggregate send_sniff_subrating
Chris Manton [Mon, 7 Dec 2020 20:35:45 +0000 (12:35 -0800)]
Aggregate send_sniff_subrating

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I3581ab52af23e43bcbb1ebf4ffe0599552b1fa57

3 years agoCheck BTM_ReadPowerMode and BTM_SetPowerMode return values
Chris Manton [Sun, 6 Dec 2020 19:23:20 +0000 (11:23 -0800)]
Check BTM_ReadPowerMode and BTM_SetPowerMode return values

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I03a4a0005967957a56051d181965d7634f27073e

3 years agoMove power mode types into acl header
Chris Manton [Tue, 8 Dec 2020 01:08:26 +0000 (17:08 -0800)]
Move power mode types into acl header

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I5bf2c549ee1230c1a229797d085ef44aefef8edc

3 years agoStreamline stack/acl/btm_pm::BTM_SetSsrParams
Chris Manton [Tue, 8 Dec 2020 00:40:43 +0000 (16:40 -0800)]
Streamline stack/acl/btm_pm::BTM_SetSsrParams

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: If14075aab757f2e3b788b677b04c4b4a6ae1f90d

3 years agoAdd stack/acl/btm_acl::acl_address_to_handle
Chris Manton [Sun, 13 Dec 2020 16:45:05 +0000 (08:45 -0800)]
Add stack/acl/btm_acl::acl_address_to_handle

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: If28b4dbf8a28fc64489cda6d3d2425d3f961d987

3 years agoAdd StackAclBtmPm::btm_pm_get_power_manager_from_address
Chris Manton [Tue, 8 Dec 2020 00:28:29 +0000 (16:28 -0800)]
Add StackAclBtmPm::btm_pm_get_power_manager_from_address

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I99484639130e101db584866802564051ac9dd339

3 years agoAdd placeholder tPOWER_MODE_STATE::BTM_PM_ST_UNUSED
Chris Manton [Tue, 8 Dec 2020 00:20:33 +0000 (16:20 -0800)]
Add placeholder tPOWER_MODE_STATE::BTM_PM_ST_UNUSED

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I0d4770d61336826c9f170f92f7d6a33e7dc6fdc3

3 years agoDecouple stack/btm/btm_int_types::BTM_PM_ST_ from btm deps
Chris Manton [Tue, 8 Dec 2020 00:16:08 +0000 (16:16 -0800)]
Decouple stack/btm/btm_int_types::BTM_PM_ST_ from btm deps

These values are spec driven, not btm driven

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I20cd743600996812ff0d5ef0145d7bf209678017

3 years agoenum-ify bta/dm/bta_dm_int::BTA_DM_DI_
Chris Manton [Mon, 7 Dec 2020 23:53:49 +0000 (15:53 -0800)]
enum-ify bta/dm/bta_dm_int::BTA_DM_DI_

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I6b1176bda0f3646bd4ca2ff3b5e983f9cde1c30a

3 years agoenum-ify stack/btm/btm_int_types::BTM_PM_ST_
Chris Manton [Mon, 7 Dec 2020 22:16:24 +0000 (14:16 -0800)]
enum-ify stack/btm/btm_int_types::BTM_PM_ST_

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I096f0228fcec1f6116bfbbc5fd60b156f3a9893d

3 years agoAdd APIs for default acl behavior
Chris Manton [Thu, 3 Dec 2020 18:22:29 +0000 (10:22 -0800)]
Add APIs for default acl behavior

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I6b8fc419ae42480884fb821dbd5663150b7ab12f

3 years agoAdd tACL_CONN::InUse
Chris Manton [Sun, 13 Dec 2020 01:23:22 +0000 (17:23 -0800)]
Add tACL_CONN::InUse

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ic7b9697f532a711044bd47125823c4d3f1c5edd1

3 years agogd_acl: Add and connect btm_pm_on_mode_change
Chris Manton [Mon, 7 Dec 2020 20:35:28 +0000 (12:35 -0800)]
gd_acl: Add and connect btm_pm_on_mode_change

Bug: 166280067
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I0f811caefcd6d0a50f3e19c17592a40d13256cd7

3 years agoAdd ToLegacyHciMode
Chris Manton [Thu, 10 Dec 2020 21:30:24 +0000 (13:30 -0800)]
Add ToLegacyHciMode

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I6bdaf4b9d73fc95bb02518086bc89c1673a3d3cf

3 years agoUse strict return type HCI_SNIFF_SUB_RATE_SUPPORTED
Chris Manton [Wed, 9 Dec 2020 16:51:56 +0000 (08:51 -0800)]
Use strict return type HCI_SNIFF_SUB_RATE_SUPPORTED

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ieaa3b111093e170d4cca3eab327878f43e92a89b

3 years agoAdd external declaration
Chris Manton [Sun, 13 Dec 2020 00:55:56 +0000 (16:55 -0800)]
Add external declaration

Fixes targets db845c-userdebug aosp_zebu

Test: Builds and compiles
Tag: #refactor
Bug: 175472744
Change-Id: Iee4815d68ca59b0b58d21adfc0b1de9922c67b89

3 years agoMerge "Security: New API; GetOutOfBandData"
Treehugger Robot [Sun, 13 Dec 2020 05:33:30 +0000 (05:33 +0000)]
Merge "Security: New API; GetOutOfBandData"

3 years agoGD: Make destructors virtual not override
Myles Watson [Fri, 11 Dec 2020 22:23:04 +0000 (14:23 -0800)]
GD: Make destructors virtual not override

Bug: 175422340
Test: cert/run --host
Tag: #gd-refactor
Change-Id: I654988a00dbeeab9021386e48f3f21b4a5388f80

3 years agorusty-gd: rename interop to ffi
Zach Johnson [Thu, 10 Dec 2020 17:51:18 +0000 (09:51 -0800)]
rusty-gd: rename interop to ffi

be more consistent

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Ide822c27c2c06dec0a9d89d09d8e20344d7ff8cb

3 years agorusty-gd: implement btsnoop
Zach Johnson [Thu, 10 Dec 2020 02:47:27 +0000 (18:47 -0800)]
rusty-gd: implement btsnoop

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I38b5c6e8f870955c3ff1f93c681bdbd7aa503815

3 years agoMerge "rusty-gd: insert snoop logger on hal datapath"
Zach Johnson [Sun, 13 Dec 2020 04:17:24 +0000 (04:17 +0000)]
Merge "rusty-gd: insert snoop logger on hal datapath"

3 years agoUse properly typed tHCI_MODE
Chris Manton [Mon, 7 Dec 2020 21:52:48 +0000 (13:52 -0800)]
Use properly typed tHCI_MODE

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I7be7d39002e01da7777360d1467d99ea7287565c

3 years agoenum-ify stack/include/hcidefs::tHCI_MODE
Chris Manton [Mon, 7 Dec 2020 21:50:18 +0000 (13:50 -0800)]
enum-ify stack/include/hcidefs::tHCI_MODE

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ia1b8e41a463b57fb8b76624f1739a5c47fbb0cfd

3 years agoenum-ify bta/av/bta_av_int::BTA_AV_ROLE_
Chris Manton [Wed, 9 Dec 2020 16:34:40 +0000 (08:34 -0800)]
enum-ify bta/av/bta_av_int::BTA_AV_ROLE_

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I8461819d100f547f367314fbe9162d5397c0e847

3 years agoRe-include bta/dm/bta_dm_act
Chris Manton [Wed, 9 Dec 2020 17:27:57 +0000 (09:27 -0800)]
Re-include bta/dm/bta_dm_act

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ib05009e6cca74c21adb93c28fdb6d6d9f73c2507

3 years agogd_acl: Return errorcode upon connection fail
Chris Manton [Mon, 7 Dec 2020 03:33:49 +0000 (19:33 -0800)]
gd_acl: Return errorcode upon connection fail

Test: classic connections on live system
Bug: 173755948
Bug: 173986615
Tag: #refactor

Change-Id: I06697aae0c0dee1df119d535c77b2f56106faddf

3 years agogd_shim: Skip legacy dumpsys if no registrants
Chris Manton [Sun, 6 Dec 2020 17:23:18 +0000 (09:23 -0800)]
gd_shim: Skip legacy dumpsys if no registrants

Test: dumpsys on live system
Bug: 173755948
Tag: #refactor

Change-Id: I658e091c7f4fcd3977baea7534b8bc6d33a736cb

3 years agobtm: Specify supervision timeout in human readable units
Chris Manton [Sat, 5 Dec 2020 19:44:43 +0000 (11:44 -0800)]
btm: Specify supervision timeout in human readable units

Toward loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ib703546fb8e4e01584961d8a4beb4ab82d13ceb6

3 years agoAdd stack/acl/btm_acl::IsEprAvailable
Chris Manton [Sat, 5 Dec 2020 19:45:13 +0000 (11:45 -0800)]
Add stack/acl/btm_acl::IsEprAvailable

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I96ca5c527a46e4e862668aa981822961c4de5b29

3 years agogd: ISO manager boilerplate
Jakub Pawlowski [Wed, 9 Dec 2020 16:46:01 +0000 (17:46 +0100)]
gd: ISO manager boilerplate

Bug: 150670922
Tag: #gd-refactor
Test: PTS tests will be added in upcoming patches
Change-Id: I01ff1091e17c40aebfcf3a0b1f977479574d8f24

3 years agoMerge changes I7393adfc,Ibbce98d9,I6afb1930
Zach Johnson [Sat, 12 Dec 2020 04:56:35 +0000 (04:56 +0000)]
Merge changes I7393adfc,Ibbce98d9,I6afb1930

* changes:
  rusty-gd: reorganize HAL a bit
  rusty-gd: Add btsnoop config
  rusty-gd: add sysprop ffi for android

3 years agoMerge changes I54ab2506,I64ac8a87,I37b7d946,I6e152469
Treehugger Robot [Fri, 11 Dec 2020 23:49:22 +0000 (23:49 +0000)]
Merge changes I54ab2506,I64ac8a87,I37b7d946,I6e152469

* changes:
  btm: Log role change events
  Clean up main/shim/acl:: connection logging
  Re-log stack/btm/btm_sec::btm_sec_connected
  Re-order stack/btm/btm_sec::btm_sec_connected

3 years agoMerge "rusty-gd: Fix offsets for scalar fields."
Zach Johnson [Fri, 11 Dec 2020 23:41:47 +0000 (23:41 +0000)]
Merge "rusty-gd: Fix offsets for scalar fields."

3 years agorusty-gd: insert snoop logger on hal datapath
Zach Johnson [Wed, 9 Dec 2020 22:10:06 +0000 (14:10 -0800)]
rusty-gd: insert snoop logger on hal datapath

does not yet do interesting logging

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I9d787d8ccff5f85181f4e2c8e7bb795675dfbf72

3 years agorusty-gd: reorganize HAL a bit
Zach Johnson [Wed, 9 Dec 2020 20:56:33 +0000 (12:56 -0800)]
rusty-gd: reorganize HAL a bit

remove mpsc:: prefixes, and hide internals so it's not exported as part
of the public api

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I7393adfcdd52f3afa5051012ba0724155db87407

3 years agorusty-gd: Add btsnoop config
Zach Johnson [Wed, 9 Dec 2020 20:11:52 +0000 (12:11 -0800)]
rusty-gd: Add btsnoop config

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Ibbce98d9e12355e0bef63ef62cfbac8098884775

3 years agorusty-gd: add sysprop ffi for android
Zach Johnson [Wed, 9 Dec 2020 18:16:55 +0000 (10:16 -0800)]
rusty-gd: add sysprop ffi for android

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I6afb19301b0d1db3bcc06283d4d8b8cc1a855c74

3 years agoMerge changes Ia521f76e,I5e4b77c1
Zach Johnson [Fri, 11 Dec 2020 23:28:44 +0000 (23:28 +0000)]
Merge changes Ia521f76e,I5e4b77c1

* changes:
  rusty-gd: Allow paths and not just idents in submodules for GDDI
  rusty-gd: implement Stoppable for GDDI

3 years agoMerge "add rust defaults and turn off targets on mac"
Zach Johnson [Fri, 11 Dec 2020 23:11:34 +0000 (23:11 +0000)]
Merge "add rust defaults and turn off targets on mac"

3 years agobtm: Log role change events
Chris Manton [Sat, 5 Dec 2020 19:44:14 +0000 (11:44 -0800)]
btm: Log role change events

Toward loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I54ab2506625b810bc61036430aa231602395d0b6

3 years agoClean up main/shim/acl:: connection logging
Chris Manton [Fri, 4 Dec 2020 16:43:09 +0000 (08:43 -0800)]
Clean up main/shim/acl:: connection logging

Toward loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I64ac8a874cb3034df24990711e0155e63d4ef282

3 years agoRe-log stack/btm/btm_sec::btm_sec_connected
Chris Manton [Sat, 5 Dec 2020 17:57:03 +0000 (09:57 -0800)]
Re-log stack/btm/btm_sec::btm_sec_connected

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I37b7d9468fb7c328af69a37ec44bdb637eb1576c

3 years agoRe-order stack/btm/btm_sec::btm_sec_connected
Chris Manton [Sat, 5 Dec 2020 17:56:54 +0000 (09:56 -0800)]
Re-order stack/btm/btm_sec::btm_sec_connected

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I6e1524691e204aee43e1d46ba7b5aceff6f15ff9

3 years agoMerge changes Ife298e71,Ida5002ac
Treehugger Robot [Fri, 11 Dec 2020 21:41:40 +0000 (21:41 +0000)]
Merge changes Ife298e71,Ida5002ac

* changes:
  gd_acl: Diverge in stack/acl/btm_acl:: after connection
  Actively check tACL_CONN:: valid prior to feature use

3 years agoMerge changes I889bcc37,I5c801477,Ic77c6f95
Treehugger Robot [Fri, 11 Dec 2020 21:41:32 +0000 (21:41 +0000)]
Merge changes I889bcc37,I5c801477,Ic77c6f95

* changes:
  Use tACL_CONN:: le and lmp feature(s) upon valid
  Re-order stack/acl/btm_acl::btm_acl_created
  Add tACL_CONN:: le and lmp flags to condition feature validity

3 years agoadd rust defaults and turn off targets on mac
Zach Johnson [Fri, 11 Dec 2020 20:19:26 +0000 (12:19 -0800)]
add rust defaults and turn off targets on mac

Bug: 175349389
Test: compile
Change-Id: I115a5922945b6d06cf1f49ca9191665b2a45b627

3 years agoChange rust_grpcio modules to rust_protobuf.
Ivan Lozano [Fri, 11 Dec 2020 21:20:13 +0000 (16:20 -0500)]
Change rust_grpcio modules to rust_protobuf.

These two module types are being merged, so the existing rust_grpcio
modules need to be redefined as rust_protobuf modules.

Bug: 172952239
Test: mma
Change-Id: I0499a214e2e2b5d930ee7f40061369ef2f34da71

3 years agoMerge "Cert: Run script additions"
Treehugger Robot [Fri, 11 Dec 2020 20:50:56 +0000 (20:50 +0000)]
Merge "Cert: Run script additions"

3 years agoSecurity: New API; GetOutOfBandData
Martin Brabham [Tue, 1 Dec 2020 18:56:15 +0000 (10:56 -0800)]
Security: New API; GetOutOfBandData

Add a new API to the SecurityManager.  This API
will allow for a caller to fetch OOB data from the
controller.

Bug: 162984360
Tag: #gd-refactor
Test: cert/run --host SecurityTest:test_get_oob_data_from_dut_controller_p192_present
Change-Id: Icb204c110345c9113049a4b1e57aae56845e9f51

3 years agorusty-gd: Fix offsets for scalar fields.
Qasim Javed [Fri, 11 Dec 2020 19:14:49 +0000 (11:14 -0800)]
rusty-gd: Fix offsets for scalar fields.

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest

Change-Id: I758f0a8397341ae0ec0f8356ab96e9c2ecea14ae