OSDN Git Service
Lang Hames [Wed, 22 Jan 2020 04:35:40 +0000 (20:35 -0800)]
[ORC] Update examples to incorporate changes in
ce2207abaf9.
This should fix the builders that were failing due to broken JIT examples
after
ce2207abaf9.
LLVM GN Syncbot [Wed, 22 Jan 2020 04:19:38 +0000 (04:19 +0000)]
[gn build] Port
e53a9d96e6a
Carl Ritson [Wed, 22 Jan 2020 04:11:29 +0000 (13:11 +0900)]
[AMDGPU] SIRemoveShortExecBranches should not remove branches exiting loops
Summary:
Check that a s_cbranch_execz is not a loop exit before removing it.
As the pass is generating infinite loops.
Reviewers: cdevadas, arsenm, nhaehnle
Reviewed By: nhaehnle
Subscribers: kzhuravl, jvesely, wdng, yaxunl, tpr, t-tye, hiraditya, kerbowa, llvm-commits, dstuttard, foad
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72997
cdevadas [Wed, 22 Jan 2020 04:07:55 +0000 (13:07 +0900)]
Resubmit: [AMDGPU] Invert the handling of skip insertion.
The current implementation of skip insertion (SIInsertSkip) makes it a
mandatory pass required for correctness. Initially, the idea was to
have an optional pass. This patch inserts the s_cbranch_execz upfront
during SILowerControlFlow to skip over the sections of code when no
lanes are active. Later, SIRemoveShortExecBranches removes the skips
for short branches, unless there is a sideeffect and the skip branch is
really necessary.
This new pass will replace the handling of skip insertion in the
existing SIInsertSkip Pass.
Differential revision: https://reviews.llvm.org/D68092
Lang Hames [Wed, 22 Jan 2020 04:12:10 +0000 (20:12 -0800)]
[ORC] Fix a missing move in
ce2207abaf9.
This should fix the build failure at
http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/32524
and others.
Puyan Lotfi [Wed, 22 Jan 2020 03:45:23 +0000 (22:45 -0500)]
[clang][IFS][test] Temporary work around for in-process cc1 ASAN issues.
When using in-process cc1, the Clang Interface Stubs pipeline setup
exposes an ASAN bug. I am still investigating this issue but want to
green the bots for now. I don't think this is a huge issue since the
Clang Interface Stubs Driver setup code is the only code path that sets
up such a pipeline (ie N cc1's for N c files followed by another N cc1's
for to generate stub files for the same N c files).
This issue is being discussed in https://reviews.llvm.org/D69825.
If a resolution is not found soon, a bugzilla filling will be in order.
Lang Hames [Wed, 22 Jan 2020 00:28:30 +0000 (16:28 -0800)]
[ORC] Add support for emulated TLS to ORCv2.
This commit adds a ManglingOptions struct to IRMaterializationUnit, and replaces
IRCompileLayer::CompileFunction with a new IRCompileLayer::IRCompiler class. The
ManglingOptions struct defines the emulated-TLS state (via a bool member,
EmulatedTLS, which is true if emulated-TLS is enabled and false otherwise). The
IRCompileLayer::IRCompiler class wraps an IRCompiler (the same way that the
CompileFunction typedef used to), but adds a method to return the
IRCompileLayer::ManglingOptions that the compiler will use.
These changes allow us to correctly determine the symbols that will be produced
when a thread local global variable defined at the IR level is compiled with or
without emulated TLS. This is required for ORCv2, where MaterializationUnits
must declare their interface up-front.
Most ORCv2 clients should not require any changes. Clients writing custom IR
compilers will need to wrap their compiler in an IRCompileLayer::IRCompiler,
rather than an IRCompileLayer::CompileFunction, however this should be a
straightforward change (see modifications to CompileUtils.* in this patch for an
example).
Kazuaki Ishizaki [Wed, 22 Jan 2020 03:36:10 +0000 (11:36 +0800)]
[libcxxabi] NFC: Fix trivial typos in comments
Reviewers: EricWF, mclow.lists, Jim
Reviewed By: Jim
Subscribers: mgorny, christof, ldionne, libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D72151
Kazuaki Ishizaki [Wed, 22 Jan 2020 03:30:57 +0000 (11:30 +0800)]
[llvm] NFC: fix trivial typos in documents
Reviewers: hans, Jim
Reviewed By: Jim
Subscribers: jvesely, nhaehnle, mgorny, arphaman, bmahjour, kerbowa, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D73017
Jonas Devlieghere [Wed, 22 Jan 2020 03:01:38 +0000 (19:01 -0800)]
Revert "[Concepts] Placeholder constraints and abbreviated templates"
This temporarily reverts commit
e03ead6771fc97b11cb0c94b7f023142184ad25f
because it breaks LLDB.
http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/3356
http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/12872
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/6407/
Saar Raz [Wed, 22 Jan 2020 02:06:51 +0000 (04:06 +0200)]
[Concepts] Fix circular AST->Sema dependency in ASTConcept.cpp
Remove inappropriate Sema include in ASTConcept.cpp introduced by D72552 for the finer-grained includes actually needed.
Eli Friedman [Wed, 22 Jan 2020 01:28:47 +0000 (17:28 -0800)]
[polly] XFAIL memset_null.ll.
I'm working on a patch, but not sure how long it'll take.
Fangrui Song [Wed, 22 Jan 2020 01:02:25 +0000 (17:02 -0800)]
[test] Use yaml2obj -o %t instead of > %t
To improve consistency and avoid unneeded shell feature (output
redirection).
While here, make other changes to improve consistency
--docnum 1 => --docnum=1
-docnum=x => --docnum=x
Louis Dionne [Tue, 21 Jan 2020 20:39:43 +0000 (12:39 -0800)]
[libc++] Make sure std::is_scalar returns true for block types
Summary:
The compiler already treats them as scalar types, so the library should
too. Furthermore, this allows blocks to be used in more places, for
example in std::optional, which requires an object type.
rdar://problem/
57892832
Reviewers: dexonsmith, EricWF, mclow.lists
Differential Revision: https://reviews.llvm.org/D72708
Saar Raz [Wed, 22 Jan 2020 00:50:12 +0000 (02:50 +0200)]
[Concepts] Constraint Satisfaction Caching
Add a simple cache for constraint satisfaction results. Whether or not this simple caching
would be permitted in final C++2a is currently being discussed but it is required for
acceptable performance so we use it in the meantime, with the possibility of adding some
cache invalidation mechanisms later.
Differential Revision: https://reviews.llvm.org/D72552
Vedant Kumar [Wed, 22 Jan 2020 00:51:27 +0000 (16:51 -0800)]
[clang/Darwin] Remove __llvm_profile_counter_bias from export list for profiling
Do not export __llvm_profile_counter_bias when profiling is enabled
because this symbol is hidden and cannot be exported.
Should fix this bot error:
```
URL: http://green.lab.llvm.org/green/job/clang-stage1-RA/5678/consoleFull
Problem: Command Output (stdout):
--
ld: warning: cannot export hidden symbol ___llvm_profile_counter_bias
from
/Users/buildslave/jenkins/workspace/clang-stage1-RA/clang-build/lib/clang/11.0.0/lib/darwin/libclang_rt.profile_osx.a(InstrProfilingBiasVar.c.o)
ld: warning: cannot export hidden symbol ___llvm_profile_counter_bias
from
/Users/buildslave/jenkins/workspace/clang-stage1-RA/clang-build/lib/clang/11.0.0/lib/darwin/libclang_rt.profile_osx.a(InstrProfilingBiasVar.c.o)
```
Amara Emerson [Fri, 17 Jan 2020 22:34:26 +0000 (14:34 -0800)]
[AArch64] Don't generate gpr CSEL instructions in early-ifcvt if regclasses aren't compatible.
In GlobalISel we may in some unfortunate circumstances generate PHIs with
operands that are on separate banks. If-conversion doesn't currently check for
that case and ends up generating a CSEL on AArch64 with incorrect register
operands.
Differential Revision: https://reviews.llvm.org/D72961
Saar Raz [Wed, 22 Jan 2020 00:41:37 +0000 (02:41 +0200)]
[clang-tidy] Fix check for generic lambda invented template parameters
clang-tidy previously relied on there being no identifier for a TemplateTypeParmDecl for checking
whether 'decltype(x)' should be inserted, instead of checking whether or not it is implicit.
D65042 added new names for invented generic lambda template parameters, rendering that check incorrect.
Nicolas Vasilache [Wed, 22 Jan 2020 00:43:27 +0000 (19:43 -0500)]
Revert "[mlir][Linalg] Add tensor support to Linalg EDSC Builders"
This reverts commit
89e19e8eddd6dd0dc38d595b6784fb9ce65d9972.
This committed a stale version of the diff https://reviews.llvm.org/D72863 .. I apologize, reverting.
Nicolas Vasilache [Wed, 22 Jan 2020 00:37:18 +0000 (19:37 -0500)]
[mlir][Linalg] Add tensor support to Linalg EDSC Builders
Summary:
This diff extends the Linalg EDSC builders so we can easily create mixed
tensor/buffer linalg.generic ops. This is expected to be useful for
HLO -> Linalg lowering.
The `StructuredIndexed` struct is made to derive from `ValueHandle` and can
now capture a type + indexing expressions. This is used to represent return
tensors.
Pointwise unary and binary builders are extended to allow both output buffers
and return tensors. This has implications on the number of region arguments.
Reviewers: ftynse, herhut, hanchung, asaadaldien, stellaraccident
Reviewed By: asaadaldien
Subscribers: merge_guards_bot, mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, arpith-jacob, mgester, lucyrfox, aartbik, liufengdb, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72863
Saar Raz [Wed, 22 Jan 2020 00:03:05 +0000 (02:03 +0200)]
[Concepts] Placeholder constraints and abbreviated templates
This patch implements P1141R2 "Yet another approach for constrained declarations".
General strategy for this patch was:
- Expand AutoType to include optional type-constraint, reflecting the wording and easing the integration of constraints.
- Replace autos in parameter type specifiers with invented parameters in GetTypeSpecTypeForDeclarator, using the same logic
previously used for generic lambdas, now unified with abbreviated templates, by:
- Tracking the template parameter lists in the Declarator object
- Tracking the template parameter depth before parsing function declarators (at which point we can match template
parameters against scope specifiers to know if we have an explicit template parameter list to append invented parameters
to or not).
- When encountering an AutoType in a parameter context we check a stack of InventedTemplateParameterInfo structures that
contain the info required to create and accumulate invented template parameters (fields that were already present in
LambdaScopeInfo, which now inherits from this class and is looked up when an auto is encountered in a lambda context).
Differential Revision: https://reviews.llvm.org/D65042
Richard Smith [Tue, 21 Jan 2020 23:52:15 +0000 (15:52 -0800)]
List implicit operator== after implicit destructors in a vtable.
Summary:
We previously listed first declared members, then implicit operator=,
then implicit operator==, then implicit destructors. Per discussion on
https://github.com/itanium-cxx-abi/cxx-abi/issues/88, put the implicit
equality comparison operators at the very end, after all special member
functions.
This reinstates
add2b7e44ada46f30715b5c48823a9e9e317e0c3, reverted in
commit
89e43f04ba87a0da6e94863db149669c7536486b, with a fix for 32-bit
targets.
Reviewers: rjmccall
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72897
Adrian Prantl [Tue, 21 Jan 2020 23:31:58 +0000 (15:31 -0800)]
Fix typos
Andrei Elovikov [Tue, 21 Jan 2020 22:25:55 +0000 (14:25 -0800)]
[SLP] Don't allow Div/Rem as alternate opcodes
Summary:
We don't have control/verify what will be the RHS of the division, so it might
happen to be zero, causing UB.
Reviewers: Vasilis, RKSimon, ABataev
Reviewed By: ABataev
Subscribers: vporpo, ABataev, hiraditya, llvm-commits, vdmitrie
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72740
Jonas Devlieghere [Tue, 21 Jan 2020 23:14:28 +0000 (15:14 -0800)]
[lldb/Plugin] Move DisassemblerLLVMC for consistency with plugin (NFC)
Rename the DisassemblerLLVMC directory from llvm to LLVMC to match the
plugin name.
Jonas Devlieghere [Tue, 21 Jan 2020 23:01:36 +0000 (15:01 -0800)]
[lldb/Plugin] Rename MainThreadCheckerRuntime for consistency with plugin (NFC)
Renames MainThreadCheckerRuntime to
InstrumentationRuntimeMainThreadChecker to be consistent with the
directory structure and plugin name.
Jonas Devlieghere [Tue, 21 Jan 2020 22:55:13 +0000 (14:55 -0800)]
[lldb/Plugin] Rename UBSanRuntime for consistency with plugin (NFC)
Renames UBSanRuntime to InstrumentationRuntimeUBSan to be consistent
with the directory structure and plugin name.
Jonas Devlieghere [Tue, 21 Jan 2020 22:50:36 +0000 (14:50 -0800)]
[lldb/Plugin] Rename TSanRuntime for consistency with plugin (NFC)
Renames TSanRuntime to InstrumentationRuntimeTSan to be
consistent with the directory structure and plugin name.
Jonas Devlieghere [Tue, 21 Jan 2020 22:43:46 +0000 (14:43 -0800)]
[lldb/Plugin] Rename AddressSanitizerRuntime for consistency with plugin (NFC)
Renames AddressSanitizerRuntime to InstrumentationRuntimeASan to be
consistent with the directory structure and plugin name.
Jason Molenda [Tue, 21 Jan 2020 22:45:21 +0000 (14:45 -0800)]
Fix an over-suspend bug with LaunchInNewTerminalWithAppleScript sessions
When launching an inferior in a new terminal window via AppleScript
and the darwin-debug helper program, we could often end up with the
inferior process having a too-high suspend count, and it would never
resume execution.
lldb tries to wait until darwin-debug has finished its work and has
launched the inferior (WaitForProcessToSIGSTOP) but this wasn't
working correctly - and cannot be made to work.
This patch removes WaitForProcessToSIGSTOP, adds a special tiny
segment to the darwin-debug executable so it can be identified as
that binary (ExecExtraSuspend), and adds code to debugserver to
detect this segment. When debugserver sees this segment, it notes
that the next exec will be done with a launch-suspended flag. When
the next exec happens, debugserver forces an extra task_resume when
we resume the inferior.
An alternative approach would be if lldb could detect when the
inferior has been launched by darwin-debug unambiguously; monitoring
when the unix socket between darwin-debug and lldb was closed would
have been a reasonable way to do this too.
<rdar://problem/
29760580>
Differential Revision: https://reviews.llvm.org/D72963
Florian Hahn [Tue, 21 Jan 2020 22:32:34 +0000 (14:32 -0800)]
[AArch64] Add custom store lowering for 256 bit non-temporal stores.
Currently we fail to lower non-termporal stores for 256+ bit vectors
to STNPQ, because type legalization will split them up to 128 bit stores
and because there are no single non-temporal stores, creating STPNQ
in the Load/Store optimizer would be quite tricky.
This patch adds custom lowering for 256 bit non-temporal vector stores
to improve the generated code.
Reviewers: dmgreen, samparker, t.p.northover, ab
Reviewed By: dmgreen
Differential Revision: https://reviews.llvm.org/D72919
Matt Arsenault [Tue, 21 Jan 2020 22:12:26 +0000 (17:12 -0500)]
AMDGPU/GlobalISel: Merge trivial legalize rules
Also move constant-like rules together
Roman Lebedev [Tue, 21 Jan 2020 22:04:47 +0000 (01:04 +0300)]
[IR] Value::getPointerAlignment(): handle pointer constants
Summary:
New `@test13` in `Attributor/align.ll` is the main motivation - `null` pointer
really does not limit our alignment knowledge, in fact it is fully aligned
since it has no bits set.
Here we don't special-case `null` pointer because it is somewhat controversial
to add one more place where we enforce that `null` pointer is zero,
but instead we do the more general thing of trying to perform constant-fold
of pointer constant to an integer, and perform alignment inferrment on that.
Reviewers: jdoerfert, gchatelet, courbet, sstefan1
Reviewed By: jdoerfert
Subscribers: hiraditya, arphaman, jfb, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D73131
Florian Hahn [Tue, 21 Jan 2020 22:22:33 +0000 (14:22 -0800)]
[Matrix] Hide and describe matrix-propagate-shape option.
Andrei Elovikov [Wed, 15 Jan 2020 17:24:12 +0000 (09:24 -0800)]
[SLP] Add a test showing miscompilation in AltOpcode support
Reviewers: Vasilis, RKSimon, ABataev
Reviewed By: RKSimon, ABataev
Subscribers: ABataev, inglorion, dexonsmith, llvm-commits, vdmitrie
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72739
Alexandre Ganea [Tue, 21 Jan 2020 22:03:00 +0000 (17:03 -0500)]
[PATCH] Reland [Clang] Un-break scan-build after integrated-cc1 change
The issue was reported by @xazax.hun here: https://reviews.llvm.org/D69825#
1827826
"This patch (D69825) breaks scan-build-py which parses the output of "-###" to get -cc1 command. There might be other tools with the same problems. Could we either remove (in-process) from CC1Command::Print or add a line break?
Having the last line as a valid invocation is valuable and there might be tools relying on that."
Differential Revision: https://reviews.llvm.org/D72982
Matt Arsenault [Tue, 21 Jan 2020 21:37:15 +0000 (16:37 -0500)]
AMDGPU/GlobalISel: Merge G_PTR_ADD/G_PTR_MASK rules
Tim Shen [Wed, 13 Nov 2019 02:17:04 +0000 (18:17 -0800)]
[APInt] Fix tests that had wrong assumption about sdivs with negative quotient.
Reviewers: sanjoy
Subscribers: bixia, dexonsmith, sanjoy.google, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70156
Fred Riss [Mon, 20 Jan 2020 16:39:25 +0000 (08:39 -0800)]
[lldb/DataFormatters] Fix the `$$deference$$` synthetic child
Summary:
The ValueObject code checks for a special `$$dereference$$` synthetic
child to allow formatter providers to implement a natural
dereferencing behavior in `frame variable` for objects like smart
pointers.
This support was broken when used directly throught the Python API and
not trhough `frame variable`. The reason is that
SBFrame.FindVariable() will return by default the synthetic variable
if it exists, while `frame variable` will not do this eagerly. The
code in `ValueObject::Dereference()` accounted for the latter but not
for the former. The fix is trivial. The test change includes
additional covergage for the already-working bahevior as it wasn't
covered by the testsuite before.
This commit also adds a short piece of documentatione explaining that
it is possible (even advisable) to provide this synthetic child
outstide of the range of the normal children.
Reviewers: jingham
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D73053
Matt Arsenault [Tue, 21 Jan 2020 21:07:22 +0000 (16:07 -0500)]
AMDGPU/GlobalISel: Legalize G_PTR_ADD for arbitrary pointers
Pointers of unrecognized address spaces shoudl be treated as
global-like pointers. Even if loads and stores of them aren't handled,
dumb operations that just operate on the bits should work.
Jonas Devlieghere [Tue, 21 Jan 2020 21:21:34 +0000 (13:21 -0800)]
[lldb/CMake] Add check-lldb-shell and check-lldb-api targets for Xcode
The Xcode generator does not provide the auto-generated targets where
you can append a folder name to check-lldb. Instead add two custom lit
targets to run just the shell and api tests.
Vladimir Vereschaka [Tue, 21 Jan 2020 21:03:11 +0000 (13:03 -0800)]
Revert "List implicit operator== after implicit destructors in a vtable."
This reverts commit
add2b7e44ada46f30715b5c48823a9e9e317e0c3.
Failed "Clang::virtual-compare.cpp" test on the arm builders.
See
http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/3169
for details.
Alexandre Ganea [Tue, 21 Jan 2020 21:06:36 +0000 (16:06 -0500)]
Revert "[Clang] Un-break scan-build after integrated-cc1 change"
This reverts commit
a6883017ea9af529e89d7f89af2477378b6eafca.
Aaron Ballman [Tue, 21 Jan 2020 21:03:22 +0000 (16:03 -0500)]
Removing an accidentally duplicated line of test code to fix bots.
Etienne Pierre-Doray [Tue, 21 Jan 2020 20:43:17 +0000 (15:43 -0500)]
Allow arbitrary capability name in Thread Safety Analysis
Restricting the names of capabilities to only "role" or "mutex" makes
for awkward diagnostic text, such as with:
https://chromium-review.googlesource.com/c/chromium/src/+/
1948098/19/base/sequence_checker_unittest.nc#33
Jonas Devlieghere [Tue, 21 Jan 2020 20:25:45 +0000 (12:25 -0800)]
[lldb/Platform] Re-add ifdef's to guard macOS-only code.
I moved the code from the system initializer to PlatformMacOSX. The
defines are still necessary because MacOSX is initialized on other
platforms where the other platforms are not available.
Fangrui Song [Tue, 21 Jan 2020 20:23:49 +0000 (12:23 -0800)]
[APFloat][unittest] Fix -Wsign-compare after D69773
Eric Fiselier [Tue, 21 Jan 2020 20:10:47 +0000 (15:10 -0500)]
[clang-tidy] Fix check for Abseil internal namespace access
This change makes following modifications:
* If reference originated from macro expansion, we report location inside of
the macro instead of location where macro is referenced.
* If for any reason deduced location is not correct we silently ignore it.
Patch by Gennadiy Rozental (rogeeff@google.com)
Reviewed as https://reviews.llvm.org/D72484
Mark de Wever [Sun, 19 Jan 2020 16:01:12 +0000 (17:01 +0100)]
[Sema] Avoid Wrange-loop-analysis false positives
When Wrange-loop-analysis issues a diagnostic on a dependent type in a
template the diagnostic may not be valid for all instantiations. Therefore
the diagnostic is suppressed during the instantiation. Non dependent types
still issue a diagnostic.
The same can happen when using macros. Therefore the diagnostic is
disabled for macros.
Fixes https://bugs.llvm.org/show_bug.cgi?id=44556
Differential Revision: https://reviews.llvm.org/D73007
Sid Manning [Fri, 10 Jan 2020 17:58:21 +0000 (11:58 -0600)]
[lld][Hexagon] Add General Dynamic relocations (GD)
Differential revision: https://reviews.llvm.org/D72522
Marcello Maggioni [Sat, 18 Jan 2020 03:26:46 +0000 (19:26 -0800)]
[mlir] Fix LLVM intrinsic convesion generator for overloadable types.
Summary:
If an intrinsic has overloadable types like llvm_anyint_ty or
llvm_anyfloat_ty then to getDeclaration() we need to pass a list
of the types that are "undefined" essentially concretizing them.
This patch add support for deriving such types from the MLIR op
that has been matched.
Reviewers: andydavis1, ftynse, nicolasvasilache, antiagainst
Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, arpith-jacob, mgester, lucyrfox, liufengdb, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72974
Ehud Katz [Tue, 21 Jan 2020 19:48:07 +0000 (21:48 +0200)]
Fix tests of constant folding of fp operations on NaN values
Fix failures introduced due to change rG0b336b6048ae.
Quentin Colombet [Tue, 21 Jan 2020 19:07:15 +0000 (11:07 -0800)]
[GISelKnownBits] Make the max depth a parameter of the analysis
Allow users of that analysis to define the cut off depth of the
analysis instead of hardcoding 6.
NFC as the default parameter is 6.
Thomas Lively [Fri, 13 Dec 2019 23:15:22 +0000 (15:15 -0800)]
[WebAssembly] Split and recombine multivalue calls for ISel
Summary:
Multivalue calls both take and return an arbitrary number of
arguments, but ISel only supports one or the other in a single
instruction. To get around this, calls are modeled as two pseudo
instructions during ISel. These pseudo instructions, CALL_PARAMS and
CALL_RESULTS, are recombined into a single CALL MachineInstr in a
custom emit hook.
RegStackification and the MC layer will additionally need to be made
aware of multivalue calls before the tests will produce correct
output.
Reviewers: aheejin, dschuff
Subscribers: sbc100, jgravelle-google, hiraditya, sunfish, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71496
Daniel Kiss [Tue, 21 Jan 2020 19:24:57 +0000 (19:24 +0000)]
[lldb] Add a setting to not install the main executable
Summary:
Add setting target.auto-install-main-executable that controls whether
the main executable should be automatically installed when connected to
a remote platform even if it does not have an explicit install path
specified. The default is true as the current behaviour.
Reviewers: omjavaid, JDevlieghere, srhines, labath, clayborg
Reviewed By: clayborg
Subscribers: kevin.brodsky, lldb-commits, llvm-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D71761
Francesco Petrogalli [Tue, 21 Jan 2020 19:21:35 +0000 (19:21 +0000)]
Revert "[lldb] Add a setting to not install the main executable"
The commit has been reverted as it does not mention the author of the
patch.
This reverts commit
7c9bcba644c4fc2178e20060d9ba2ff1f50ae15e.
Krzysztof Parzyszek [Tue, 21 Jan 2020 19:19:27 +0000 (13:19 -0600)]
[Hexagon] Add REQUIRES: asserts to a testcase using -debug-only
Kostya Kortchinsky [Mon, 20 Jan 2020 17:50:22 +0000 (09:50 -0800)]
[scudo][standalone] Allow sched_getaffinity to fail
Summary:
In some configuration, `sched_getaffinity` can fail. Some reasons for
that being the lack of `CAP_SYS_NICE` capability or some syscall
filtering and so on.
This should not be fatal to the allocator, so in this situation, we
will fallback to the `MaxTSDCount` value specified in the allocator
configuration.
Reviewers: cferris, eugenis, hctim, morehouse, pcc
Subscribers: #sanitizers, llvm-commits
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D73055
Thomas Lively [Fri, 13 Dec 2019 18:41:25 +0000 (10:41 -0800)]
[WebAssembly][InstrEmitter] Foundation for multivalue call lowering
Summary:
WebAssembly is unique among upstream targets in that it does not at
any point use physical registers to store values. Instead, it uses
virtual registers to model positions in its value stack. This means
that some target-independent lowering activities that would use
physical registers need to use virtual registers instead for
WebAssembly and similar downstream targets. This CL generalizes the
existing `usesPhysRegsForPEI` lowering hook to
`usesPhysRegsForValues` in preparation for using it in more places.
One such place is in InstrEmitter for instructions that have variadic
defs. On register machines, it only makes sense for these defs to be
physical registers, but for WebAssembly they must be virtual registers
like any other values. This CL changes InstrEmitter to check the new
target lowering hook to determine whether variadic defs should be
physical or virtual registers.
These changes are necessary to support a generalized CALL instruction
for WebAssembly that is capable of returning an arbitrary number of
arguments. Fully implementing that instruction will require additional
changes that are described in comments here but left for a follow up
commit.
Reviewers: aheejin, dschuff, qcolombet
Subscribers: sbc100, jgravelle-google, hiraditya, sunfish, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71484
Lei Zhang [Fri, 17 Jan 2020 21:39:59 +0000 (16:39 -0500)]
[mlir][ods] Fix StringRef initialization in builders
For the generated builder taking in unwrapped attribute values,
if the argument is a string, we should avoid wrapping it in quotes;
otherwise we are always setting the string attribute to contain
the string argument's name. The quotes come from StrinAttr's
`constBuilderCall`, which is reasonable for string literals, but
not function arguments containing strings.
Differential Revision: https://reviews.llvm.org/D72977
Francesco Petrogalli [Tue, 21 Jan 2020 18:50:34 +0000 (18:50 +0000)]
[lldb] Add a setting to not install the main executable
Summary:
Add setting target.auto-install-main-executable that controls whether
the main executable should be automatically installed when connected to
a remote platform even if it does not have an explicit install path
specified. The default is true as the current behaviour.
Reviewers: omjavaid, JDevlieghere, srhines, labath, clayborg
Reviewed By: clayborg
Subscribers: kevin.brodsky, lldb-commits, llvm-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D71761
Reid Kleckner [Sat, 18 Jan 2020 20:38:08 +0000 (12:38 -0800)]
[TableGen] Use a table to lookup MVE intrinsic names
Summary:
Speeds up compilation of SemaDeclAttr.cpp by nine seconds:
0m49.555s - > 0m40.249s
Reviewers: simon_tatham, dmgreen, ostannard, MarkMurrayARM
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72984
Vedant Kumar [Tue, 21 Jan 2020 19:03:58 +0000 (11:03 -0800)]
[debugserver] Delete stale code referencing ppc
Ehud Katz [Tue, 21 Jan 2020 19:02:00 +0000 (21:02 +0200)]
[APFloat] Add support for operations on Signaling NaN
Fix PR30781
Differential Revision: https://reviews.llvm.org/D69774
Vedant Kumar [Tue, 21 Jan 2020 18:59:38 +0000 (10:59 -0800)]
[debugserver] Delete macOS/PPC debug server implementation
macOS/PPC support was dropped in 10.6 (Snow Leopard).
Differential Revision: https://reviews.llvm.org/D69524
Alexey Bader [Tue, 21 Jan 2020 11:43:18 +0000 (14:43 +0300)]
[Attr][Doc][NFC] Fix code snippet formatting for attribute documentation
Reviewers: aaron.ballman, Fznamznon
Subscribers: ebevhan, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D73104
Fangrui Song [Tue, 21 Jan 2020 18:33:48 +0000 (10:33 -0800)]
[APFloat][unittest] Fix -Wunused-variable after D69773
Alexey Bataev [Tue, 21 Jan 2020 18:01:23 +0000 (13:01 -0500)]
[OpenMP][Offloading] Fix the issue that omp_get_num_devices returns wrong number of devices, by Shiley Tian.
Summary:
This patch is to fix issue in the following simple case:
#include <omp.h>
#include <stdio.h>
int main(int argc, char *argv[]) {
int num = omp_get_num_devices();
printf("%d\n", num);
return 0;
}
Currently it returns 0 even devices exist. Since this file doesn't contain any
target region, the host entry is empty so further actions like initialization
will not be proceeded, leading to wrong device number returned by runtime
function call.
Reviewers: jdoerfert, ABataev, protze.joachim
Reviewed By: ABataev
Subscribers: protze.joachim
Tags: #openmp
Differential Revision: https://reviews.llvm.org/D72576
Ehud Katz [Tue, 21 Jan 2020 18:17:42 +0000 (20:17 +0200)]
[APFloat] Extend conversion from special strings
Add support for converting Signaling NaN, and a NaN Payload from string.
The NaNs (the string "nan" or "NaN") may be prefixed with 's' or 'S' for defining a Signaling NaN.
A payload for a NaN can be specified as a suffix.
It may be a octal/decimal/hexadecimal number in parentheses or without.
Differential Revision: https://reviews.llvm.org/D69773
Roman Lebedev [Tue, 21 Jan 2020 18:18:29 +0000 (21:18 +0300)]
[NFC][Codegen] Use MaybeAlign + APInt::getLimitedValue() when creating Alignment attr
Summary: Just an NFC code cleanup i stumbled upon when stumbling through clang alignment attribute handling.
Reviewers: erichkeane, gchatelet, courbet, jdoerfert
Reviewed By: gchatelet
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72993
Roman Lebedev [Tue, 21 Jan 2020 18:18:27 +0000 (21:18 +0300)]
[Codegen] Emit both AssumeAlignedAttr and AllocAlignAttr assumptions if they exist
Summary:
We shouldn't be just giving up if we find one of them
(like we currently do with `AssumeAlignedAttr`),
we should emit them all.
As the tests show, even if we materialized good knowledge
from `__attribute__((assume_aligned(32)`, it doesn't mean
`__attribute__((alloc_align([...])))` info won't be useful.
It might be, but that isn't given.
Reviewers: erichkeane, jdoerfert, aaron.ballman
Reviewed By: erichkeane
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72979
Jonas Devlieghere [Tue, 21 Jan 2020 17:47:02 +0000 (09:47 -0800)]
[lldb/tools] Update lldb-test's system initializer
After
a731c6ba94d0 the initializer only has to call the PlatformMacOSX
to initialize all the macOS platforms.
Fangrui Song [Thu, 2 Jan 2020 06:47:15 +0000 (22:47 -0800)]
[PowerPC] Delete PPCSubtarget::isDarwin and isDarwinABI
http://lists.llvm.org/pipermail/llvm-dev/2018-August/125614.html developers have agreed to remove Darwin support from POWER backends.
Reviewed By: sfertile
Differential Revision: https://reviews.llvm.org/D72067
Jonas Devlieghere [Tue, 21 Jan 2020 17:49:59 +0000 (09:49 -0800)]
[lldb/Hexagon] Include <mutex>
Fixes compiler error on macOS: error: no type named 'mutex' in namespace
'std'.
Fangrui Song [Mon, 20 Jan 2020 19:24:58 +0000 (11:24 -0800)]
[StackColoring] Remap PseudoSourceValue frame indices via MachineFunction::getPSVManager()
Reviewed By: dantrushin
Differential Revision: https://reviews.llvm.org/D73063
Kevin P. Neal [Fri, 20 Dec 2019 18:36:03 +0000 (13:36 -0500)]
[FPEnv][SystemZ] Platform-specific builtin constrained FP enablement
When constrained floating point is enabled the SystemZ-specific builtins
don't use constrained intrinsics in some cases. Fix that.
Differential Revision: https://reviews.llvm.org/D72722
Holger Wünsche [Tue, 21 Jan 2020 17:27:56 +0000 (09:27 -0800)]
[HIP] use GetProgramPath for executable discovery
This change replaces the manual building of executable paths
using llvm::sys::path::append with GetProgramPath.
This enables adding other paths in case executables reside
in different directories and makes the code easier to read.
Differential Revision: https://reviews.llvm.org/D72903
Jonas Devlieghere [Tue, 21 Jan 2020 17:40:06 +0000 (09:40 -0800)]
[lldb/Initializers] Move all macOS initializers into PlatformMacOSX
PlatformMacOSX is the main entry point to the plugin with the same name.
This is part of a greater refactoring to auto generate the initializers.
Differential revision: https://reviews.llvm.org/D73116
Krzysztof Parzyszek [Mon, 13 Jan 2020 22:07:30 +0000 (16:07 -0600)]
[Hexagon] Add support for Hexagon v67t microarchitecture (tiny core)
Sergej Jaskiewicz [Tue, 21 Jan 2020 16:40:34 +0000 (19:40 +0300)]
[libcxx] Support Python 3.8 in the test suite
Summary: `platform.linux_distribution()` has been deprecated in Python 3.5 and removed in Python 3.8.
Reviewers: bcain, bcraig, jroelofs, EricWF, mclow.lists, ldionne
Reviewed By: jroelofs
Subscribers: dexonsmith, christof, ldionne, libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D72501
Denis Khalikov [Tue, 21 Jan 2020 17:12:17 +0000 (12:12 -0500)]
[mlir][spirv] Simplify scalar type size calculation.
Simplify scalar type size calculation and reject boolean memrefs.
Differential Revision: https://reviews.llvm.org/D72999
Alexandre Ganea [Tue, 21 Jan 2020 16:58:11 +0000 (11:58 -0500)]
[Clang] Un-break scan-build after integrated-cc1 change
Differential Revision: https://reviews.llvm.org/D72982
Krzysztof Parzyszek [Tue, 21 Jan 2020 15:47:35 +0000 (09:47 -0600)]
Update spelling of {analyze,insert,remove}Branch in strings and comments
These names have been changed from CamelCase to camelCase, but there were
many places (comments mostly) that still used the old names.
This change is NFC.
Kadir Cetinkaya [Tue, 21 Jan 2020 15:49:32 +0000 (16:49 +0100)]
[clangd] Drop returntype/type when hovering over type-ish names
Summary:
Some names, e.g. constructor/destructor/conversions, already contain
the type info, no need to duplicate them in the hoverinfo.
Fixes https://github.com/clangd/clangd/issues/252
Reviewers: sammccall, ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D73110
Zakk Chen [Wed, 15 Jan 2020 14:41:08 +0000 (06:41 -0800)]
[RISCV] Check the target-abi module flag matches the option
Reviewers: lenary, asb
Reviewed By: lenary
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72768
Diogo Sampaio [Tue, 21 Jan 2020 15:31:33 +0000 (15:31 +0000)]
Revert "[ARM] Follow AACPS standard for volatile bit-fields access width"
This reverts commit
6a24339a45246b66bd3de88cc9c6a5b5e77c0645.
Submitted using ide button by mistake
Diogo Sampaio [Tue, 21 Jan 2020 15:13:24 +0000 (15:13 +0000)]
[ARM] Follow AACPS standard for volatile bit-fields access width
Summary:
This patch resumes the work of D16586.
According to the AAPCS, volatile bit-fields should
be accessed using containers of the widht of their
declarative type. In such case:
```
struct S1 {
short a : 1;
}
```
should be accessed using load and stores of the width
(sizeof(short)), where now the compiler does only load
the minimum required width (char in this case).
However, as discussed in D16586,
that could overwrite non-volatile bit-fields, which
conflicted with C and C++ object models by creating
data race conditions that are not part of the bit-field,
e.g.
```
struct S2 {
short a;
int b : 16;
}
```
Accessing `S2.b` would also access `S2.a`.
The AAPCS Release 2019Q1.1
(https://static.docs.arm.com/ihi0042/g/aapcs32.pdf)
section 8.1 Data Types, page 35, "Volatile bit-fields -
preserving number and width of container accesses" has been
updated to avoid conflict with the C++ Memory Model.
Now it reads in the note:
```
This ABI does not place any restrictions on the access widths
of bit-fields where the container overlaps with a non-bit-field member.
This is because the C/C++ memory model defines these as being separate
memory locations, which can be accessed by two threads
simultaneously. For this reason, compilers must be permitted to use a
narrower memory access width (including splitting the access
into multiple instructions) to avoid writing to a different memory location.
```
I've updated the patch D16586 to follow such behavior by verifying that we
only change volatile bit-field access when:
- it won't overlap with any other non-bit-field member
- we only access memory inside the bounds of the record
Regarding the number of memory accesses, that should be preserved, that will
be implemented by D67399.
Reviewers: rsmith, rjmccall, eli.friedman, ostannard
Subscribers: ostannard, kristof.beyls, cfe-commits, carwil, olista01
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72932
Simon Pilgrim [Tue, 21 Jan 2020 15:11:46 +0000 (15:11 +0000)]
[TargetLowering] SimplifyDemandedBits ISD::SRA multi-use handling
Call SimplifyMultipleUseDemandedBits to peek through extended source args with multiple uses
Benjamin Kramer [Tue, 21 Jan 2020 14:54:48 +0000 (15:54 +0100)]
Make dropTriviallyDeadConstantArrays not quadratic
Only look at the operands of dead constant arrays instead of all
constant arrays again.
Jinsong Ji [Mon, 20 Jan 2020 20:16:56 +0000 (20:16 +0000)]
[PowerPC][NFC] Reclaim TSFlags bit 6
We removed UseVSXReg flag in https://reviews.llvm.org/D58685
But we did not reclain the bit 6 it was assigned,
this will become confusing and a hole later..
We should reclaim it as early as possible before new bits.
Reviewed By: sfertile
Differential Revision: https://reviews.llvm.org/D72649
Simon Pilgrim [Tue, 21 Jan 2020 14:39:00 +0000 (14:39 +0000)]
[SelectionDAG] GetDemandedBits - remove ANY_EXTEND handling
Rely on SimplifyMultipleUseDemandedBits fallback instead.
Simon Pilgrim [Tue, 21 Jan 2020 14:24:34 +0000 (14:24 +0000)]
[X86] combineBT - use SimplifyDemandedBits instead of GetDemandedBits
Another step towards removing SelectionDAG::GetDemandedBits entirely
Haojian Wu [Tue, 21 Jan 2020 10:50:57 +0000 (11:50 +0100)]
[clangd] Capture the missing injected class names in findExplicitReferences.
Summary: Fixes https://github.com/clangd/clangd/issues/237.
Reviewers: kadircet, kbobyrev
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D73088
Simon Pilgrim [Tue, 21 Jan 2020 13:49:56 +0000 (13:49 +0000)]
[TargetLowering] SimplifyDemandedBits ANY_EXTEND/ANY_EXTEND_VECTOR_INREG multi-use handling
Call SimplifyMultipleUseDemandedBits to peek through extended source args with multiple uses
Pavel Labath [Tue, 21 Jan 2020 14:03:36 +0000 (15:03 +0100)]
[lldb/breakpad] Use new line table constructor
The old construction method can be quadratic for some inputs. This
approach guarantees a reasonable performance.
Pavel Labath [Tue, 21 Jan 2020 13:42:39 +0000 (14:42 +0100)]
[lldb/DWARF] Fix a leak in line table construction
We were creating a bunch of LineSequence objects but never deleting
them.
This fixes the leak and changes the code to use std::unique_ptr, to make
it harder to make the same mistake again.
LLVM GN Syncbot [Tue, 21 Jan 2020 13:36:16 +0000 (13:36 +0000)]
[gn build] Port
fccd0da5ee6
Adam Balogh [Wed, 4 Dec 2019 09:48:13 +0000 (10:48 +0100)]
[clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc
Finds cases where an integer expression is added to the result
of a memory allocation function instead of its argument.
Differential Revision: https://reviews.llvm.org/D71001
Matt Arsenault [Tue, 21 Jan 2020 13:18:39 +0000 (08:18 -0500)]
AMDGPU/GlobalISel: Add some baseline tests for unmerge legalization
Guillaume Chatelet [Mon, 20 Jan 2020 16:11:00 +0000 (17:11 +0100)]
[Alignment][NFC] Use Align with CreateElementUnorderedAtomicMemMove
Summary:
This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790
Reviewers: courbet
Subscribers: hiraditya, jfb, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D73050