OSDN Git Service

android-x86/frameworks-av.git
8 years agoMerge "Fix for security vulnerability in media server DO NOT MERGE" into lmp-dev
Jeff Tinker [Thu, 17 Sep 2015 17:04:15 +0000 (17:04 +0000)]
Merge "Fix for security vulnerability in media server DO NOT MERGE" into lmp-dev

8 years agoam 190786d3: (-s ours) am ae922517: Merge "DO NOT MERGE - IAudioFlinger: always initi...
Wei Jia [Thu, 17 Sep 2015 13:42:56 +0000 (13:42 +0000)]
am 190786d3: (-s ours) am ae922517: Merge "DO NOT MERGE - IAudioFlinger: always initialize variables to ensure no info leak when writing them to Parcel." into klp-dev

* commit '190786d3590c6b064a7d32eaa92f4a7b11cf16d5':
  DO NOT MERGE - IAudioFlinger: always initialize variables to ensure no info leak when writing them to Parcel.

8 years agoam ae922517: Merge "DO NOT MERGE - IAudioFlinger: always initialize variables to...
Wei Jia [Thu, 17 Sep 2015 13:36:52 +0000 (13:36 +0000)]
am ae922517: Merge "DO NOT MERGE - IAudioFlinger: always initialize variables to ensure no info leak when writing them to Parcel." into klp-dev

* commit 'ae92251730865e0c4bc59ef2a8fe9dacb6de41b9':
  DO NOT MERGE - IAudioFlinger: always initialize variables to ensure no info leak when writing them to Parcel.

8 years agoMerge "DO NOT MERGE - IAudioFlinger: always initialize variables to ensure no info...
Wei Jia [Thu, 17 Sep 2015 13:19:23 +0000 (13:19 +0000)]
Merge "DO NOT MERGE - IAudioFlinger: always initialize variables to ensure no info leak when writing them to Parcel." into lmp-dev

8 years agoMerge "DO NOT MERGE - IAudioFlinger: always initialize variables to ensure no info...
Wei Jia [Thu, 17 Sep 2015 13:19:08 +0000 (13:19 +0000)]
Merge "DO NOT MERGE - IAudioFlinger: always initialize variables to ensure no info leak when writing them to Parcel." into klp-dev

8 years agoam 38281f1c: am d386c5be: Merge "Fix heap data leak vulnerability" into klp-dev
Jeff Tinker [Wed, 16 Sep 2015 18:40:49 +0000 (18:40 +0000)]
am 38281f1c: am d386c5be: Merge "Fix heap data leak vulnerability" into klp-dev

* commit '38281f1cbcd4804095828f19b7954d5219560fcd':
  Fix heap data leak vulnerability

8 years agoam d386c5be: Merge "Fix heap data leak vulnerability" into klp-dev
Jeff Tinker [Wed, 16 Sep 2015 18:33:58 +0000 (18:33 +0000)]
am d386c5be: Merge "Fix heap data leak vulnerability" into klp-dev

* commit 'd386c5be9505d2db24048a6e08ab714f2151dac2':
  Fix heap data leak vulnerability

8 years agoMerge "Fix heap data leak vulnerability" into klp-dev
Jeff Tinker [Wed, 16 Sep 2015 18:17:46 +0000 (18:17 +0000)]
Merge "Fix heap data leak vulnerability" into klp-dev

8 years agoDO NOT MERGE - IAudioFlinger: always initialize variables to ensure no info leak...
Wei Jia [Thu, 10 Sep 2015 16:47:29 +0000 (09:47 -0700)]
DO NOT MERGE - IAudioFlinger: always initialize variables to ensure no info leak when writing them to Parcel.

Bug: 23953967
Change-Id: Ibbe841da149038675e9e8daea76c77558bc8564b
(cherry picked from commit 983dca391a76fb45df999fc40e8766b9ddb63511)

8 years agoDO NOT MERGE - IAudioFlinger: always initialize variables to ensure no info leak...
Wei Jia [Thu, 10 Sep 2015 16:47:29 +0000 (09:47 -0700)]
DO NOT MERGE - IAudioFlinger: always initialize variables to ensure no info leak when writing them to Parcel.

Bug: 23953967
Change-Id: Ibbe841da149038675e9e8daea76c77558bc8564b
(cherry picked from commit 983dca391a76fb45df999fc40e8766b9ddb63511)

8 years agoam 9860dcdf: (-s ours) am b21a6420: Merge "DO NOT MERGE NuCachedSource2: fix possible...
Wonsik Kim [Wed, 16 Sep 2015 07:43:55 +0000 (07:43 +0000)]
am 9860dcdf: (-s ours) am b21a6420: Merge "DO NOT MERGE NuCachedSource2: fix possible erroneous early free" into klp-dev

* commit '9860dcdf427d70e6aef4ce082be40a5459c466f4':
  DO NOT MERGE NuCachedSource2: fix possible erroneous early free

8 years agoam b21a6420: Merge "DO NOT MERGE NuCachedSource2: fix possible erroneous early free...
Wonsik Kim [Wed, 16 Sep 2015 07:37:16 +0000 (07:37 +0000)]
am b21a6420: Merge "DO NOT MERGE NuCachedSource2: fix possible erroneous early free" into klp-dev

* commit 'b21a642067477c72f419956da0ca8dafe0c04eab':
  DO NOT MERGE NuCachedSource2: fix possible erroneous early free

8 years agoMerge "DO NOT MERGE NuCachedSource2: fix possible erroneous early free" into lmp-dev
Wonsik Kim [Wed, 16 Sep 2015 07:11:18 +0000 (07:11 +0000)]
Merge "DO NOT MERGE NuCachedSource2: fix possible erroneous early free" into lmp-dev

8 years agoMerge "DO NOT MERGE NuCachedSource2: fix possible erroneous early free" into klp-dev
Wonsik Kim [Wed, 16 Sep 2015 07:11:04 +0000 (07:11 +0000)]
Merge "DO NOT MERGE NuCachedSource2: fix possible erroneous early free" into klp-dev

8 years agoFix heap data leak vulnerability
Jeff Tinker [Mon, 14 Sep 2015 20:55:23 +0000 (13:55 -0700)]
Fix heap data leak vulnerability

bug: 23600291
Change-Id: I7979e9e25ada01c13775be8580d433a8b4ce4ffe

8 years agoFix for security vulnerability in media server DO NOT MERGE
Jeff Tinker [Mon, 14 Sep 2015 18:55:43 +0000 (11:55 -0700)]
Fix for security vulnerability in media server DO NOT MERGE

bug: 23540426
Change-Id: I7ca419e4008967a0387649e5293ac9d4be71d3c4

8 years agoMerge "DO NOT MERGE Avoid size_t overflow in base64 decoding once again" into lmp-dev
Wonsik Kim [Mon, 14 Sep 2015 06:30:56 +0000 (06:30 +0000)]
Merge "DO NOT MERGE Avoid size_t overflow in base64 decoding once again" into lmp-dev

8 years agoDO NOT MERGE NuCachedSource2: fix possible erroneous early free
Wonsik Kim [Tue, 8 Sep 2015 08:32:28 +0000 (17:32 +0900)]
DO NOT MERGE NuCachedSource2: fix possible erroneous early free

Because the constructor of NuCachedSource2 sent a message to
AHandlerReflector object, AHandlerReflector::onMessageReceived could
have executed just before the object gets wrapped in a strong
pointer, resulting in erroneous early free. Fix the issue by using
static Create function to ensure the message is sent after the
object is wrapped in a sp.

Bug: 23882800
Change-Id: I38a9d7a3083f184b4c81d0b00ba1661721278855

8 years agoDO NOT MERGE NuCachedSource2: fix possible erroneous early free
Wonsik Kim [Tue, 8 Sep 2015 08:32:28 +0000 (17:32 +0900)]
DO NOT MERGE NuCachedSource2: fix possible erroneous early free

Because the constructor of NuCachedSource2 sent a message to
AHandlerReflector object, AHandlerReflector::onMessageReceived could
have executed just before the object gets wrapped in a strong
pointer, resulting in erroneous early free. Fix the issue by using
static Create function to ensure the message is sent after the
object is wrapped in a sp.

Bug: 23882800
Change-Id: I38a9d7a3083f184b4c81d0b00ba1661721278855

8 years agoDO NOT MERGE Avoid size_t overflow in base64 decoding once again
Wonsik Kim [Fri, 11 Sep 2015 07:31:18 +0000 (16:31 +0900)]
DO NOT MERGE Avoid size_t overflow in base64 decoding once again

Switch to foundation base64 function in OggExtractor and fix the
issue there.

This reverts commit 28314aef9e8a666dbb75bbd555f6566a6c991f1c.

Bug: 23707088
Change-Id: I268bd50431de5b5e579343bf1b425c42ada6daba

8 years agoam 8cfd0ac4: (-s ours) am 741a3351: Merge "DO NOT MERGE - IAudioFlinger: clear config...
Wei Jia [Sat, 12 Sep 2015 08:49:21 +0000 (08:49 +0000)]
am 8cfd0ac4: (-s ours) am 741a3351: Merge "DO NOT MERGE - IAudioFlinger: clear config before reading it from parcel." into klp-dev

* commit '8cfd0ac4b05f3151f1083564f46f05b5f525af8a':
  DO NOT MERGE - IAudioFlinger: clear config before reading it from parcel.

8 years agoam 44da08ed: (-s ours) am b659b4c7: Merge "DO NOT MERGE fix build" into klp-dev
Wonsik Kim [Sat, 12 Sep 2015 08:49:20 +0000 (08:49 +0000)]
am 44da08ed: (-s ours) am b659b4c7: Merge "DO NOT MERGE fix build" into klp-dev

* commit '44da08ed957157645e1c8776bb59924b1bb7f61c':
  DO NOT MERGE fix build

8 years agoam 1507bbb0: (-s ours) am 1784a8db: Merge "DO NOT MERGE Avoid size_t overflow in...
Wonsik Kim [Sat, 12 Sep 2015 08:49:19 +0000 (08:49 +0000)]
am 1507bbb0: (-s ours) am 1784a8db: Merge "DO NOT MERGE Avoid size_t overflow in base64 decoding once again" into klp-dev

* commit '1507bbb00e78c297b1aca01f580f529b55009f94':
  DO NOT MERGE Avoid size_t overflow in base64 decoding once again

8 years agoam c256004a: am 69ae6a87: libstagefright: fix A_Refl to return immediately when there...
Wei Jia [Sat, 12 Sep 2015 08:49:17 +0000 (08:49 +0000)]
am c256004a: am 69ae6a87: libstagefright: fix A_Refl to return immediately when there is an error.

* commit 'c256004a8cbf4dc1d647957243cf8be1a3c7bec4':
  libstagefright: fix A_Refl to return immediately when there is an error.

8 years agoam 741a3351: Merge "DO NOT MERGE - IAudioFlinger: clear config before reading it...
Wei Jia [Fri, 11 Sep 2015 14:10:14 +0000 (14:10 +0000)]
am 741a3351: Merge "DO NOT MERGE - IAudioFlinger: clear config before reading it from parcel." into klp-dev

* commit '741a335126a562ae8f5883cc0b02ba72f40e56f3':
  DO NOT MERGE - IAudioFlinger: clear config before reading it from parcel.

8 years agoMerge "DO NOT MERGE - IAudioFlinger: clear config before reading it from parcel....
Wei Jia [Fri, 11 Sep 2015 13:55:30 +0000 (13:55 +0000)]
Merge "DO NOT MERGE - IAudioFlinger: clear config before reading it from parcel." into lmp-dev

8 years agoMerge "DO NOT MERGE - IAudioFlinger: clear config before reading it from parcel....
Wei Jia [Fri, 11 Sep 2015 13:54:59 +0000 (13:54 +0000)]
Merge "DO NOT MERGE - IAudioFlinger: clear config before reading it from parcel." into klp-dev

8 years agoam b659b4c7: Merge "DO NOT MERGE fix build" into klp-dev
Wonsik Kim [Fri, 11 Sep 2015 07:50:35 +0000 (07:50 +0000)]
am b659b4c7: Merge "DO NOT MERGE fix build" into klp-dev

* commit 'b659b4c7e1405056d189b44bd96036b6500dd378':
  DO NOT MERGE fix build

8 years agoMerge "DO NOT MERGE fix build" into klp-dev
Wonsik Kim [Fri, 11 Sep 2015 07:34:53 +0000 (07:34 +0000)]
Merge "DO NOT MERGE fix build" into klp-dev

8 years agoDO NOT MERGE fix build
Wonsik Kim [Fri, 11 Sep 2015 07:14:18 +0000 (16:14 +0900)]
DO NOT MERGE fix build

Bug: 23707088

Change-Id: Ib0d6cbc52710f33310d21b2eae1f243f0f8e8bca

8 years agoam 1784a8db: Merge "DO NOT MERGE Avoid size_t overflow in base64 decoding once again...
Wonsik Kim [Fri, 11 Sep 2015 07:25:22 +0000 (07:25 +0000)]
am 1784a8db: Merge "DO NOT MERGE Avoid size_t overflow in base64 decoding once again" into klp-dev

* commit '1784a8dbbc73b3e6033340d107b6c08478b962c8':
  DO NOT MERGE Avoid size_t overflow in base64 decoding once again

8 years agoMerge "Revert "Avoid size_t overflow in base64 decoding once again"" into lmp-dev
Wonsik Kim [Fri, 11 Sep 2015 06:59:11 +0000 (06:59 +0000)]
Merge "Revert "Avoid size_t overflow in base64 decoding once again"" into lmp-dev

8 years agoRevert "Avoid size_t overflow in base64 decoding once again"
Wonsik Kim [Fri, 11 Sep 2015 06:51:10 +0000 (06:51 +0000)]
Revert "Avoid size_t overflow in base64 decoding once again"

This reverts commit c9ac5dfdafed1c66beae090cafa97002764e0ca3.

Change-Id: Iae9707bbd8641a0bb00fcda39a20eb8b8f4f5232

8 years agoMerge "Avoid size_t overflow in base64 decoding once again" into lmp-dev
Wonsik Kim [Fri, 11 Sep 2015 06:49:37 +0000 (06:49 +0000)]
Merge "Avoid size_t overflow in base64 decoding once again" into lmp-dev

8 years agoMerge "DO NOT MERGE Avoid size_t overflow in base64 decoding once again" into klp-dev
Wonsik Kim [Fri, 11 Sep 2015 06:49:22 +0000 (06:49 +0000)]
Merge "DO NOT MERGE Avoid size_t overflow in base64 decoding once again" into klp-dev

8 years agoam 69ae6a87: libstagefright: fix A_Refl to return immediately when there is an error.
Wei Jia [Thu, 10 Sep 2015 21:23:55 +0000 (21:23 +0000)]
am 69ae6a87: libstagefright: fix A_Refl to return immediately when there is an error.

* commit '69ae6a87342d5260d8d8660accc8aa1b9367dbbe':
  libstagefright: fix A_Refl to return immediately when there is an error.

8 years agoDO NOT MERGE - IAudioFlinger: clear config before reading it from parcel.
Wei Jia [Wed, 9 Sep 2015 16:48:34 +0000 (09:48 -0700)]
DO NOT MERGE - IAudioFlinger: clear config before reading it from parcel.

Bug: 23905951
Bug: 23912202
Change-Id: Id13a9d3cae2c09e7381b841e67ddfb188274d74c
(cherry picked from commit e995e477ad59b79145200c8f1e9e13c16c682d59)

8 years agoDO NOT MERGE - IAudioFlinger: clear config before reading it from parcel.
Wei Jia [Wed, 9 Sep 2015 16:48:34 +0000 (09:48 -0700)]
DO NOT MERGE - IAudioFlinger: clear config before reading it from parcel.

Bug: 23905951
Bug: 23912202
Change-Id: Id13a9d3cae2c09e7381b841e67ddfb188274d74c
(cherry picked from commit e995e477ad59b79145200c8f1e9e13c16c682d59)

8 years agoDO NOT MERGE Avoid size_t overflow in base64 decoding once again
Wonsik Kim [Mon, 7 Sep 2015 06:52:27 +0000 (15:52 +0900)]
DO NOT MERGE Avoid size_t overflow in base64 decoding once again

Switch to foundation base64 function in OggExtractor and fix the
issue there.

Bug: 23707088
Change-Id: I999ae911177c88dc13f9ee9796ca93c5928b20b0

8 years agoAvoid size_t overflow in base64 decoding once again
Wonsik Kim [Mon, 7 Sep 2015 06:52:27 +0000 (15:52 +0900)]
Avoid size_t overflow in base64 decoding once again

Switch to foundation base64 function in OggExtractor and fix the
issue there.

Bug: 23707088
Change-Id: I999ae911177c88dc13f9ee9796ca93c5928b20b0

8 years agoDO NOT MERGE: Protect data source access with mutex during disconnect
Robert Shih [Wed, 2 Sep 2015 21:02:47 +0000 (14:02 -0700)]
DO NOT MERGE: Protect data source access with mutex during disconnect

Bug: 23658148
Change-Id: Ic37cac7b5d166143e0b77e9919b0aaef486e4fdd

8 years agolibstagefright: fix A_Refl to return immediately when there is an error.
Wei Jia [Fri, 4 Sep 2015 16:13:37 +0000 (09:13 -0700)]
libstagefright: fix A_Refl to return immediately when there is an error.

Bug: 23609206
Change-Id: I2ad25fb208df17f5a5b6d6b356eff2f400627f22
(cherry picked from commit 715dcb9c90d86c1a02a0da056f3cee8875ad1230)

8 years agoam c1e989e7: am 13ff64c2: Merge "Zero out return values in media binder calls" into...
Robert Shih [Thu, 3 Sep 2015 18:05:44 +0000 (18:05 +0000)]
am c1e989e7: am 13ff64c2: Merge "Zero out return values in media binder calls" into klp-dev

* commit 'c1e989e76a461ea69e293839b3c29b634a462bd5':
  Zero out return values in media binder calls

8 years agoam 3732a3ac: am ab203130: Merge "Make IEffect command more robust (second try)" into...
Andy Hung [Thu, 3 Sep 2015 18:05:43 +0000 (18:05 +0000)]
am 3732a3ac: am ab203130: Merge "Make IEffect command more robust (second try)" into klp-dev

* commit '3732a3acafa7eb621bc26cca3eb00150ea12d2e2':
  Make IEffect command more robust (second try)

8 years agoam 16e12007: am 74888428: Merge "Fix timedtext parsing" into klp-dev
Marco Nelissen [Thu, 3 Sep 2015 18:05:42 +0000 (18:05 +0000)]
am 16e12007: am 74888428: Merge "Fix timedtext parsing" into klp-dev

* commit '16e12007ab1581e1b6aa973f3c83b2a45a816881':
  Fix timedtext parsing

8 years agoam 13ff64c2: Merge "Zero out return values in media binder calls" into klp-dev
Robert Shih [Thu, 3 Sep 2015 17:52:44 +0000 (17:52 +0000)]
am 13ff64c2: Merge "Zero out return values in media binder calls" into klp-dev

* commit '13ff64c2db84f4e7cac3396700e333b48c42c7ee':
  Zero out return values in media binder calls

8 years agoam ab203130: Merge "Make IEffect command more robust (second try)" into klp-dev
Andy Hung [Thu, 3 Sep 2015 17:52:43 +0000 (17:52 +0000)]
am ab203130: Merge "Make IEffect command more robust (second try)" into klp-dev

* commit 'ab20313074bb109f29f677c3f09d5da1a48c94e7':
  Make IEffect command more robust (second try)

8 years agoam 74888428: Merge "Fix timedtext parsing" into klp-dev
Marco Nelissen [Thu, 3 Sep 2015 17:52:42 +0000 (17:52 +0000)]
am 74888428: Merge "Fix timedtext parsing" into klp-dev

* commit '74888428e51a2aa123e301912d09973bd9310c33':
  Fix timedtext parsing

8 years agoam 03b7f72b: (-s ours) am 9d916c77: DO NOT MERGE - libstagefright: sanity check size...
Wei Jia [Thu, 3 Sep 2015 17:24:20 +0000 (17:24 +0000)]
am 03b7f72b: (-s ours) am 9d916c77: DO NOT MERGE - libstagefright: sanity check size before dereferencing pointer in Utils.cpp

* commit '03b7f72b98ef0a4fa58a84a27d2f8735342faf58':
  DO NOT MERGE - libstagefright: sanity check size before dereferencing pointer in Utils.cpp

8 years agoMerge "Zero out return values in media binder calls" into klp-dev
Robert Shih [Thu, 3 Sep 2015 17:21:20 +0000 (17:21 +0000)]
Merge "Zero out return values in media binder calls" into klp-dev

8 years agoMerge "Make IEffect command more robust (second try)" into klp-dev
Andy Hung [Thu, 3 Sep 2015 17:16:12 +0000 (17:16 +0000)]
Merge "Make IEffect command more robust (second try)" into klp-dev

8 years agoam 9d916c77: DO NOT MERGE - libstagefright: sanity check size before dereferencing...
Wei Jia [Thu, 3 Sep 2015 17:14:06 +0000 (17:14 +0000)]
am 9d916c77: DO NOT MERGE - libstagefright: sanity check size before dereferencing pointer in Utils.cpp

* commit '9d916c771ca32cb2d0df27b85ce3e17bb6b48eaf':
  DO NOT MERGE - libstagefright: sanity check size before dereferencing pointer in Utils.cpp

8 years agoMerge "Fix timedtext parsing" into klp-dev
Marco Nelissen [Thu, 3 Sep 2015 17:05:55 +0000 (17:05 +0000)]
Merge "Fix timedtext parsing" into klp-dev

8 years agoDO NOT MERGE - libstagefright: sanity check size before dereferencing pointer in...
Wei Jia [Tue, 1 Sep 2015 18:14:18 +0000 (11:14 -0700)]
DO NOT MERGE - libstagefright: sanity check size before dereferencing pointer in Utils.cpp

Also remove some CHECK's.

Bug: 23680780
Change-Id: I62d0941e203e40209fa6fbe3f923f3efdc5a6c23
(cherry picked from commit 7bb772e0c643ff3292599cf485b9dbf232bf39a4)

8 years agoDO NOT MERGE - libstagefright: sanity check size before dereferencing pointer in...
Wei Jia [Tue, 1 Sep 2015 18:14:18 +0000 (11:14 -0700)]
DO NOT MERGE - libstagefright: sanity check size before dereferencing pointer in Utils.cpp

Also remove some CHECK's.

Bug: 23680780
Change-Id: I62d0941e203e40209fa6fbe3f923f3efdc5a6c23
(cherry picked from commit 7bb772e0c643ff3292599cf485b9dbf232bf39a4)

8 years agoam 436b32d1: am d2605273: Ogg: avoid size_t overflow in base64 decoding
Wonsik Kim [Thu, 3 Sep 2015 07:59:29 +0000 (07:59 +0000)]
am 436b32d1: am d2605273: Ogg: avoid size_t overflow in base64 decoding

* commit '436b32d1eb75cf20d09776549bd7f7a11fa569a1':
  Ogg: avoid size_t overflow in base64 decoding

8 years agoam d2605273: Ogg: avoid size_t overflow in base64 decoding
Wonsik Kim [Thu, 3 Sep 2015 07:54:01 +0000 (07:54 +0000)]
am d2605273: Ogg: avoid size_t overflow in base64 decoding

* commit 'd26052738f7b095b7e318c8dde7f32db0a48450c':
  Ogg: avoid size_t overflow in base64 decoding

8 years agoOgg: avoid size_t overflow in base64 decoding
Wonsik Kim [Wed, 2 Sep 2015 07:02:19 +0000 (16:02 +0900)]
Ogg: avoid size_t overflow in base64 decoding

Bug: 23707088
Change-Id: I8d32841fee3213c721cdcc57788807ea64d19d74

8 years agoZero out return values in media binder calls
Robert Shih [Wed, 2 Sep 2015 23:46:59 +0000 (16:46 -0700)]
Zero out return values in media binder calls

More specifically when handling:
* GET_STREAM_VOLUME in IAudioPolicyService, and
* GET_CURRENT_POSITION and GET_DURATION in IMediaPlayer

This prevents leaking uninitialized values across binder in error cases.

Bug: 23756261
Change-Id: I0ffd900ab12b685b0611259ade4a3efb1ec5defe

8 years agoMake IEffect command more robust (second try)
Andy Hung [Tue, 1 Sep 2015 20:07:56 +0000 (20:07 +0000)]
Make IEffect command more robust (second try)

Bug: 23540907
Change-Id: If30cfa535ad51521053706fc40fc98d893db5bc7
(cherry picked from commit 10e6660cc5da65b027c90489ba7ac55d1504e012)

8 years agoFix timedtext parsing
Marco Nelissen [Thu, 27 Aug 2015 20:49:32 +0000 (13:49 -0700)]
Fix timedtext parsing

Add bounds checking and fix other bugs.

Bug: 23284974
Bug: 23541506
Bug: 23542351
Bug: 23542352
Change-Id: I53551efdf109ce1833e0c361efaf4cee7a851023

8 years agoam fba72ab0: am f394f121: Merge "libmedia: clear reply data for IEffect command"...
Andy Hung [Fri, 28 Aug 2015 21:16:40 +0000 (21:16 +0000)]
am fba72ab0: am f394f121: Merge "libmedia: clear reply data for IEffect command" into klp-dev

* commit 'fba72ab0fcf7298492dcd9e3045913435d30d3a9':
  libmedia: clear reply data for IEffect command

8 years agoam f394f121: Merge "libmedia: clear reply data for IEffect command" into klp-dev
Andy Hung [Fri, 28 Aug 2015 21:08:45 +0000 (21:08 +0000)]
am f394f121: Merge "libmedia: clear reply data for IEffect command" into klp-dev

* commit 'f394f12167fddbc755855d06b615509517c99f14':
  libmedia: clear reply data for IEffect command

8 years agoMerge "libmedia: clear reply data for IEffect command" into klp-dev
Andy Hung [Fri, 28 Aug 2015 20:49:57 +0000 (20:49 +0000)]
Merge "libmedia: clear reply data for IEffect command" into klp-dev

8 years agoam d437c777: am 0981df6e: IMediaPlayer.cpp: make sure structures are initialized...
Nick Kralevich [Thu, 27 Aug 2015 21:51:52 +0000 (21:51 +0000)]
am d437c777: am 0981df6e: IMediaPlayer.cpp: make sure structures are initialized to 0

* commit 'd437c77716fcf454d99b8424bb01f37643b970cc':
  IMediaPlayer.cpp: make sure structures are initialized to 0

8 years agoam 0981df6e: IMediaPlayer.cpp: make sure structures are initialized to 0
Nick Kralevich [Thu, 27 Aug 2015 21:45:45 +0000 (21:45 +0000)]
am 0981df6e: IMediaPlayer.cpp: make sure structures are initialized to 0

* commit '0981df6e3db106bfb7a56a2b668c012fcc34dd2c':
  IMediaPlayer.cpp: make sure structures are initialized to 0

8 years agoIMediaPlayer.cpp: make sure structures are initialized to 0
Nick Kralevich [Thu, 20 Aug 2015 16:56:39 +0000 (09:56 -0700)]
IMediaPlayer.cpp: make sure structures are initialized to 0

Credit https://code.google.com/p/android/issues/detail?id=183310

Bug: 23515142
Change-Id: Idbd66fb148bd0ac1dd78f8651d0164f2a41e2427
(cherry picked from commit b73b826cc16291b33649402497efbe0f946413bd)

8 years agolibmedia: clear reply data for IEffect command
Andy Hung [Wed, 26 Aug 2015 23:34:33 +0000 (16:34 -0700)]
libmedia: clear reply data for IEffect command

Bug: 23540907
Change-Id: Ib89afc6b273b0eb310bbc5a1bd92b1e3d407c249

8 years agoam f9a51893: (-s ours) am 9a2be5d4: Merge "DO NOT MERGE - Fix software video decoder...
Abhishek Arya [Tue, 25 Aug 2015 05:30:46 +0000 (05:30 +0000)]
am f9a51893: (-s ours) am 9a2be5d4: Merge "DO NOT MERGE - Fix software video decoder buffer size calculation" into klp-dev

* commit 'f9a51893d739000cd70caf10c83d0e603371f5b1':
  DO NOT MERGE - Fix software video decoder buffer size calculation

8 years agoam 3a7ff4c7: (-s ours) am a5f50e98: DO NOT MERGE - SoftwareRenderer: sanity check...
Wei Jia [Tue, 25 Aug 2015 05:30:44 +0000 (05:30 +0000)]
am 3a7ff4c7: (-s ours) am a5f50e98: DO NOT MERGE - SoftwareRenderer: sanity check buffer size before copying data.

* commit '3a7ff4c754fcb99c29621ed94b08ed6fb65f6495':
  DO NOT MERGE - SoftwareRenderer: sanity check buffer size before copying data.

8 years agoam 9a2be5d4: Merge "DO NOT MERGE - Fix software video decoder buffer size calculation...
Abhishek Arya [Tue, 25 Aug 2015 05:23:24 +0000 (05:23 +0000)]
am 9a2be5d4: Merge "DO NOT MERGE - Fix software video decoder buffer size calculation" into klp-dev

* commit '9a2be5d49d57b239bf6345f033eab01ba98f3889':
  DO NOT MERGE - Fix software video decoder buffer size calculation

8 years agoam a5f50e98: DO NOT MERGE - SoftwareRenderer: sanity check buffer size before copying...
Wei Jia [Tue, 25 Aug 2015 05:23:23 +0000 (05:23 +0000)]
am a5f50e98: DO NOT MERGE - SoftwareRenderer: sanity check buffer size before copying data.

* commit 'a5f50e98d1408addcaaac27e4d13981163d12a15':
  DO NOT MERGE - SoftwareRenderer: sanity check buffer size before copying data.

8 years agoMerge "DO NOT MERGE - Fix software video decoder buffer size calculation" into lmp-dev
Abhishek Arya [Tue, 25 Aug 2015 04:00:11 +0000 (04:00 +0000)]
Merge "DO NOT MERGE - Fix software video decoder buffer size calculation" into lmp-dev

8 years agoMerge "DO NOT MERGE - Fix software video decoder buffer size calculation" into klp-dev
Abhishek Arya [Tue, 25 Aug 2015 04:00:04 +0000 (04:00 +0000)]
Merge "DO NOT MERGE - Fix software video decoder buffer size calculation" into klp-dev

8 years agoDO NOT MERGE - Fix software video decoder buffer size calculation
Marco Nelissen [Tue, 16 Jun 2015 21:50:36 +0000 (14:50 -0700)]
DO NOT MERGE - Fix software video decoder buffer size calculation

Various software video decoders would specify the buffer size as if it were
fully cropped, which then failed a sanity check in SoftwareRenderer.
They now return the full buffer size.

Bug: 21717327
Bug: 21443020
Change-Id: I19fcd091827ebd52a95a5509281a07ccc156e0e5
(cherry picked from commit 3ecc9db40b1fb9c7f807a5892e5c9625aac1fb06)

8 years agoDO NOT MERGE - Fix software video decoder buffer size calculation
Marco Nelissen [Tue, 16 Jun 2015 21:50:36 +0000 (14:50 -0700)]
DO NOT MERGE - Fix software video decoder buffer size calculation

Various software video decoders would specify the buffer size as if it were
fully cropped, which then failed a sanity check in SoftwareRenderer.
They now return the full buffer size.

Bug: 21717327
Bug: 21443020
Change-Id: I19fcd091827ebd52a95a5509281a07ccc156e0e5
(cherry picked from commit 3ecc9db40b1fb9c7f807a5892e5c9625aac1fb06)

8 years agoDO NOT MERGE - SoftwareRenderer: sanity check buffer size before copying data.
Wei Jia [Mon, 8 Jun 2015 21:01:42 +0000 (14:01 -0700)]
DO NOT MERGE - SoftwareRenderer: sanity check buffer size before copying data.

Bug: 21443020
Change-Id: I63cf86217b8201fb41809c23e4b752b845a93ee2
(cherry picked from commit 760f92f8b6da9c9cf128cb18fe3c09402fdde6cd)

8 years agoDO NOT MERGE - SoftwareRenderer: sanity check buffer size before copying data.
Wei Jia [Mon, 8 Jun 2015 21:01:42 +0000 (14:01 -0700)]
DO NOT MERGE - SoftwareRenderer: sanity check buffer size before copying data.

Bug: 21443020
Change-Id: I63cf86217b8201fb41809c23e4b752b845a93ee2
(cherry picked from commit 760f92f8b6da9c9cf128cb18fe3c09402fdde6cd)

8 years agoam 0f3ab16c: am af7e33f6: libstagefright: check overflow before memory allocation...
Wei Jia [Sun, 23 Aug 2015 19:15:04 +0000 (19:15 +0000)]
am 0f3ab16c: am af7e33f6: libstagefright: check overflow before memory allocation in OMXCodec.cpp

* commit '0f3ab16c827a43534597cb38515951ff736f9740':
  libstagefright: check overflow before memory allocation in OMXCodec.cpp

8 years agoam 09f71c56: am dedaca6f: Limit allocations to avoid out-of-memory
Marco Nelissen [Sun, 23 Aug 2015 19:15:02 +0000 (19:15 +0000)]
am 09f71c56: am dedaca6f: Limit allocations to avoid out-of-memory

* commit '09f71c5621799e0f030b4a8058d2fb4df5977de0':
  Limit allocations to avoid out-of-memory

8 years agoam af7e33f6: libstagefright: check overflow before memory allocation in OMXCodec.cpp
Wei Jia [Sun, 23 Aug 2015 19:08:27 +0000 (19:08 +0000)]
am af7e33f6: libstagefright: check overflow before memory allocation in OMXCodec.cpp

* commit 'af7e33f6043c0be1c0310d675884e3b263ca2438':
  libstagefright: check overflow before memory allocation in OMXCodec.cpp

8 years agoam dedaca6f: Limit allocations to avoid out-of-memory
Marco Nelissen [Sun, 23 Aug 2015 19:08:25 +0000 (19:08 +0000)]
am dedaca6f: Limit allocations to avoid out-of-memory

* commit 'dedaca6f04ac9f95fabe3b64d44cd1a2050f079e':
  Limit allocations to avoid out-of-memory

8 years agolibstagefright: check overflow before memory allocation in OMXCodec.cpp
Wei Jia [Fri, 21 Aug 2015 23:49:51 +0000 (16:49 -0700)]
libstagefright: check overflow before memory allocation in OMXCodec.cpp

Bug: 23416608
Change-Id: I4dacd38ed42db8f4887c3ee386dc909451f4346f

9 years agoLimit allocations to avoid out-of-memory
Marco Nelissen [Thu, 4 Jun 2015 18:01:15 +0000 (11:01 -0700)]
Limit allocations to avoid out-of-memory

Corrupt files could cause very large allocations, limit them to something
more reasonable.

Bug: 17769851
Change-Id: Ib0f722fd6fddff873bd7a547aac456e608c34c84

9 years agoam eecc406f: am 3b42241a: Merge "Prevent integer issues in ID3::Iterator::findFrame...
Robert Shih [Sat, 22 Aug 2015 01:18:32 +0000 (01:18 +0000)]
am eecc406f: am 3b42241a: Merge "Prevent integer issues in ID3::Iterator::findFrame" into klp-dev

* commit 'eecc406f462ef2b3a73cd6bf3c05f7cb45382276':
  Prevent integer issues in ID3::Iterator::findFrame

9 years agoam 3b42241a: Merge "Prevent integer issues in ID3::Iterator::findFrame" into klp-dev
Robert Shih [Sat, 22 Aug 2015 01:08:44 +0000 (01:08 +0000)]
am 3b42241a: Merge "Prevent integer issues in ID3::Iterator::findFrame" into klp-dev

* commit '3b42241aab5855964d1bd60268ae21c2d9cc6065':
  Prevent integer issues in ID3::Iterator::findFrame

9 years agoMerge "Prevent integer issues in ID3::Iterator::findFrame" into klp-dev
Robert Shih [Sat, 22 Aug 2015 00:54:32 +0000 (00:54 +0000)]
Merge "Prevent integer issues in ID3::Iterator::findFrame" into klp-dev

9 years agoPrevent integer issues in ID3::Iterator::findFrame
Joshua J. Drake [Sat, 15 Aug 2015 13:17:03 +0000 (08:17 -0500)]
Prevent integer issues in ID3::Iterator::findFrame

Integer overflows could occur a few places within findFrame. These can lead to
out-of-bounds reads and potentially infinite loops. Ensure that arithmetic does
not wrap around to prevent these behaviors.

Bug: 23285192
Change-Id: I72a61df7d5719d1d3f2bd0b37fba86f0f4bbedee

9 years agoam f814f84e: (-s ours) am d8816a13: DO NOT MERGE libstagefright: Fix crash in convert...
Wei Jia [Fri, 21 Aug 2015 20:03:06 +0000 (20:03 +0000)]
am f814f84e: (-s ours) am d8816a13: DO NOT MERGE libstagefright: Fix crash in convertMetaDataToMessage

* commit 'f814f84e09191af23bbf8d307f02704e20cc887c':
  DO NOT MERGE libstagefright: Fix crash in convertMetaDataToMessage

9 years agoam d8816a13: DO NOT MERGE libstagefright: Fix crash in convertMetaDataToMessage
Wei Jia [Fri, 21 Aug 2015 19:57:30 +0000 (19:57 +0000)]
am d8816a13: DO NOT MERGE libstagefright: Fix crash in convertMetaDataToMessage

* commit 'd8816a13dbcafd5d61d26a8a6b2e892452bca1a7':
  DO NOT MERGE libstagefright: Fix crash in convertMetaDataToMessage

9 years agoDO NOT MERGE libstagefright: Fix crash in convertMetaDataToMessage
Wei Jia [Thu, 25 Jun 2015 18:46:54 +0000 (11:46 -0700)]
DO NOT MERGE libstagefright: Fix crash in convertMetaDataToMessage

- The ABuffer used for the Message has a preset value of 1024, if
  flattening the meta data exceeds this value, a check fails hence
  the crash.
- This change creates a new ABuffer if the buffer size would exceed
  the buffer capacity.

Bug: 22771132

CRs-Fixed: 857850

(cherry picked from commit 4bce636865bdf0e2a79fc9a5d9a69107649c850d)

Change-Id: Ia0a963e9872f646791e75b710ff9e227a66af4f9

9 years agoam ca095ac2: (-s ours) am 8de6d690: Fix build break DO NOT MERGE
Jeff Tinker [Fri, 21 Aug 2015 18:59:11 +0000 (18:59 +0000)]
am ca095ac2: (-s ours) am 8de6d690: Fix build break DO NOT MERGE

* commit 'ca095ac251ad02ad745d763f37ec3fcc5a8aa2ea':
  Fix build break DO NOT MERGE

9 years agoam 8de6d690: Fix build break DO NOT MERGE
Jeff Tinker [Fri, 21 Aug 2015 18:51:27 +0000 (18:51 +0000)]
am 8de6d690: Fix build break DO NOT MERGE

* commit '8de6d690ae5843bd8e005deedea571596f79bbd3':
  Fix build break DO NOT MERGE

9 years agoFix build break DO NOT MERGE
Jeff Tinker [Fri, 21 Aug 2015 16:58:12 +0000 (09:58 -0700)]
Fix build break DO NOT MERGE

related-to-bug: 23223325

Change-Id: I7b09712b5f18912abddd50b75f6edaf860e894c1

9 years agoam fd1d6df5: (-s ours) am c2153d0d: DO NOT MERGE Part of fix for libmedia OOB write...
Jeff Tinker [Fri, 21 Aug 2015 16:27:33 +0000 (16:27 +0000)]
am fd1d6df5: (-s ours) am c2153d0d: DO NOT MERGE Part of fix for libmedia OOB write anywhere

* commit 'fd1d6df52f4c33f59d44abdbcdd0ec5b9a20f059':
  DO NOT MERGE Part of fix for libmedia OOB write anywhere

9 years agoam c2153d0d: DO NOT MERGE Part of fix for libmedia OOB write anywhere
Jeff Tinker [Fri, 21 Aug 2015 15:36:21 +0000 (15:36 +0000)]
am c2153d0d: DO NOT MERGE Part of fix for libmedia OOB write anywhere

* commit 'c2153d0dc800d0718788dccd0f2a2d29f4647c03':
  DO NOT MERGE Part of fix for libmedia OOB write anywhere

9 years agoMerge "DO NOT MERGE Part of fix for libmedia OOB write anywhere" into lmp-dev
Abhishek Arya [Fri, 21 Aug 2015 15:22:37 +0000 (15:22 +0000)]
Merge "DO NOT MERGE Part of fix for libmedia OOB write anywhere" into lmp-dev

9 years agoDO NOT MERGE Part of fix for libmedia OOB write anywhere
Jeff Tinker [Tue, 18 Aug 2015 00:57:47 +0000 (17:57 -0700)]
DO NOT MERGE Part of fix for libmedia OOB write anywhere

Clarify that decrypt destination is not a pointer for
secure case.

b/23223325

Change-Id: I642dcf790a9eb9e32175f3e0d8f040c82228e3ac
(cherry picked from commit ed555d70d80964f40563d89a4e6d6a80f83f4b89)

9 years agoam f839b2a3: (-s ours) am 5aa887ef: am 59bfb7aa: (-s ours) am 18a8124f: am da0a48d2...
Marco Nelissen [Thu, 20 Aug 2015 20:39:14 +0000 (20:39 +0000)]
am f839b2a3: (-s ours) am 5aa887ef: am 59bfb7aa: (-s ours) am 18a8124f: am da0a48d2: (-s ours) am 6020f066: am b294a97a: am 6cba5819: am 51bfaf6c: am 1afea551: am ce73af07: DO NOT MERGE Fail more gracefully on allocation failure

* commit 'f839b2a33c46f3520684f0a839760cca36a6b4c7':
  DO NOT MERGE Fail more gracefully on allocation failure

9 years agoam 5aa887ef: am 59bfb7aa: (-s ours) am 18a8124f: am da0a48d2: (-s ours) am 6020f066...
Marco Nelissen [Thu, 20 Aug 2015 20:30:04 +0000 (20:30 +0000)]
am 5aa887ef: am 59bfb7aa: (-s ours) am 18a8124f: am da0a48d2: (-s ours) am 6020f066: am b294a97a: am 6cba5819: am 51bfaf6c: am 1afea551: am ce73af07: DO NOT MERGE Fail more gracefully on allocation failure

* commit '5aa887ef44238e9a727564fe9051933f8b42e399':
  DO NOT MERGE Fail more gracefully on allocation failure