OSDN Git Service

android-x86/system-bt.git
5 years agoMerge "Add packet parser tests to TEST_MAPPING"
Zach Johnson [Fri, 5 Apr 2019 02:31:23 +0000 (19:31 -0700)]
Merge "Add packet parser tests to TEST_MAPPING"
am: 42f90b5519

Change-Id: I7f73702671e88960d1d68932744c1eb5eb5c6a4d

5 years agoMerge "Add packet parser tests to TEST_MAPPING"
Treehugger Robot [Fri, 5 Apr 2019 02:19:38 +0000 (02:19 +0000)]
Merge "Add packet parser tests to TEST_MAPPING"

5 years agoMerge "Fix handling of startup_timer_expired"
Sunny Kapdi [Fri, 5 Apr 2019 01:52:01 +0000 (18:52 -0700)]
Merge "Fix handling of startup_timer_expired"
am: b0388ceb17

Change-Id: I37f856cd7941404a5a276f40c015626760cfda66

5 years agoMerge "Fix handling of startup_timer_expired"
Treehugger Robot [Fri, 5 Apr 2019 01:35:30 +0000 (01:35 +0000)]
Merge "Fix handling of startup_timer_expired"

5 years agoAdd packet parser tests to TEST_MAPPING
Zach Johnson [Fri, 5 Apr 2019 00:21:31 +0000 (17:21 -0700)]
Add packet parser tests to TEST_MAPPING

Test: atest bluetooth_packet_parser_test
Change-Id: If82370a834825cd265fac3c7e100176b94c79bb0

5 years agoPDL: L2CAP packet definition
Myles Watson [Fri, 5 Apr 2019 00:21:33 +0000 (17:21 -0700)]
PDL: L2CAP packet definition
am: a4cd53c63a

Change-Id: I8b6e714f1a2298db2e9f0b360568d74a02b33a06

5 years agoPDL: HCI packet definition
Myles Watson [Fri, 5 Apr 2019 00:21:13 +0000 (17:21 -0700)]
PDL: HCI packet definition
am: cc57c6b64e

Change-Id: I4f6ce897126af4d06096368eab52bf3be6e9ea6a

5 years agopacket: Add the PDL Packet Generator
Ajay Panicker [Fri, 5 Apr 2019 00:20:54 +0000 (17:20 -0700)]
packet: Add the PDL Packet Generator
am: 4d6b760fad

Change-Id: Ibc5520ff6856b46df5c624f9c3aca4158625ab81

5 years agoPDL: L2CAP packet definition
Myles Watson [Mon, 25 Mar 2019 22:25:08 +0000 (15:25 -0700)]
PDL: L2CAP packet definition

Test: Comparison with the SPEC
      bluetooth_test_gd --gtest_filter="*L2cap*"
Change-Id: If29036fa7147b27d5a79458773c5eb772eb15817

5 years agoPDL: HCI packet definition
Myles Watson [Mon, 25 Mar 2019 22:24:43 +0000 (15:24 -0700)]
PDL: HCI packet definition

Test: Comparison with the SPEC
      bluetooth_test_gd --gtest_filter="*Acl*"
Change-Id: I48fcd2655edb54d831f8b395de9a209c46049189

5 years agopacket: Add the PDL Packet Generator
Ajay Panicker [Wed, 6 Feb 2019 22:02:36 +0000 (14:02 -0800)]
packet: Add the PDL Packet Generator

Test: bluetooth_packet_parser_test
Change-Id: Ia741e608aebff7b55d005a37e0f0eaeae63767a8

5 years agoFix memory leak of reactor and reactor_unittest
Chienyuan [Thu, 4 Apr 2019 04:32:55 +0000 (21:32 -0700)]
Fix memory leak of reactor and reactor_unittest
am: 2d7f3b71a7

Change-Id: I7507ded9a4bac7f686d0717bb03661e76868ccfa

5 years agoPacketBuilderTest: Modify member array
Chienyuan [Thu, 4 Apr 2019 04:32:40 +0000 (21:32 -0700)]
PacketBuilderTest: Modify member array
am: ebed359a56

Change-Id: Ib1448ee622a2dd79bbd8dab201e0b2dcc8a1b34b

5 years agoFix memory leak of reactor and reactor_unittest
Chienyuan [Sat, 30 Mar 2019 00:33:41 +0000 (17:33 -0700)]
Fix memory leak of reactor and reactor_unittest

* Fix memory leak happen in below two cases

Case 1

1. Reactable1 register
2. Reactable2 register
3. Reactable2 unregister during the callback event of Reactable2
4. Reactable1 unregister

In step 3, reactable_removed_ will set to true due to unregister while
reactable->is_executing_ is true, it makes sure we delete Reactable2
after the callback is executed. But it will cause Reactable1 to not be
deleted in step 4.

To avoid this, we can reset reactable_removed_ to false after Reactable
deleted.

Case 2

1. Reactable1 register
2. Reactable2 register
3. Reactable2 unregister during the callback event of Reactable2
4. Reactable1 unregister from different thread during step 3 processing

In step 3, although we reset reactable_removed_ to false after Reactable2
deleted immediately for case 1, if other thread unregister Reactable1
before Reactable2 deleted, Reactable1 will fail to be deleted.

To avoid thie, we add a local variable to check if the Reacable is
executing. If not, deleted the Reactable directly.

* Add unittest for these two cases
* Fix memory leak in reactor_unittest
* Turn on cfi and address flag

Test: sudo ./bluetooth_test_gd
Change-Id: I0a0ca79b439fd3a1bf3ec0fa2b2a43a88e037fbb

5 years agoPacketBuilderTest: Modify member array
Chienyuan [Wed, 3 Apr 2019 23:12:36 +0000 (16:12 -0700)]
PacketBuilderTest: Modify member array

Test: sudo ./bluetooth_test_gd
Change-Id: Ibf015899c9430a25d7ae64f5bcc82a13e8f80871

5 years agoMerge "Handle Bluetooth HAL service died"
Ugo Yu [Wed, 3 Apr 2019 18:57:43 +0000 (11:57 -0700)]
Merge "Handle Bluetooth HAL service died"
am: fcaed46d9e

Change-Id: I105aad49177d7987fd0ad97fdad9d22359fd32d6

5 years agoMerge "Handle Bluetooth HAL service died"
Treehugger Robot [Wed, 3 Apr 2019 18:45:12 +0000 (18:45 +0000)]
Merge "Handle Bluetooth HAL service died"

5 years agoHandle Bluetooth HAL service died
Ugo Yu [Tue, 2 Apr 2019 13:55:14 +0000 (21:55 +0800)]
Handle Bluetooth HAL service died

Bug: 129320921
Test: kill Bluetooth HAL
Change-Id: I83c897f5a9def52b2050a3e73d97f99b1b71aa3b

5 years agoFix handling of startup_timer_expired
Sunny Kapdi [Sat, 30 Mar 2019 00:42:38 +0000 (17:42 -0700)]
Fix handling of startup_timer_expired

1. The startup_timer needs to be less than
3 sec to allow the wakelock to be held by
the stack and needs to be less than the
BLE_START_TIMEOUT of framework.
2. On expiry of startup_timer, just abort
as there is no proper recovery steps here.

Test: "adb shell cat dev/ttyHS0" when Bluetooth is OFF
      Turn on Bluetooth
Bug: 129394377
Change-Id: I1a397bab5c88fe7ef8ccbc369897903ee5d0a36a
Merged-In: I1a397bab5c88fe7ef8ccbc369897903ee5d0a36a

5 years agoMerge "RootCanal: Add beacons by default"
Myles Watson [Wed, 3 Apr 2019 03:52:15 +0000 (20:52 -0700)]
Merge "RootCanal: Add beacons by default"
am: ca152a6705

Change-Id: I5dc0e3cceb7ae1cb4e4a4cb4d5e31c52a6ee6343

5 years agoMerge "RootCanal: Add beacons by default"
Treehugger Robot [Wed, 3 Apr 2019 03:40:38 +0000 (03:40 +0000)]
Merge "RootCanal: Add beacons by default"

5 years agoMerge "packet: Add Packet classes and tests"
Myles Watson [Wed, 3 Apr 2019 01:37:51 +0000 (18:37 -0700)]
Merge "packet: Add Packet classes and tests"
am: a275910a49

Change-Id: I930470fa3921157afe771cab7f427168c89f6a95

5 years agoAdd service change handle for Hearing Aids
weichinweng [Wed, 3 Apr 2019 01:36:31 +0000 (18:36 -0700)]
Add service change handle for Hearing Aids
am: c410c2e7f1

Change-Id: I77c2bec2821d939fe8323d64ab051260bf9d57ee

5 years agoMerge "packet: Add Packet classes and tests"
Treehugger Robot [Wed, 3 Apr 2019 01:01:06 +0000 (01:01 +0000)]
Merge "packet: Add Packet classes and tests"

5 years agopacket: Add Packet classes and tests
Myles Watson [Mon, 1 Apr 2019 20:21:25 +0000 (13:21 -0700)]
packet: Add Packet classes and tests

Test: atest bluetooth_test_gd
Change-Id: I8e124d5123cff3354f5c451b3806904a2d60b38d

5 years agoAdd service change handle for Hearing Aids
weichinweng [Wed, 20 Mar 2019 10:53:11 +0000 (18:53 +0800)]
Add service change handle for Hearing Aids

When receive service changed indication from Hearing Aid (which indicates
Hearing Aid service changed), it will refresh the hearing aid attribute
handle to ensure the attribute handle is correct.

Bug: 122008481
Test: 1.run unit test
2.After Pair old version FW HearingAid, Disconnect/Reconnect new version
FW HearingAId, then check whether HearingAid is working fine.
3.After Pair old version FW HearingAid, Bluetooth off/on to reconnect
new version FW HearingAId, then check whether HearingAid is working
fine.
Change-Id: I48eae10a3016429f35f4f904752be93bb419d515

5 years agoFix for GATT not returning disconnect callback.
Jakub Pawlowski [Tue, 2 Apr 2019 21:22:59 +0000 (14:22 -0700)]
Fix for GATT not returning disconnect callback.
am: 8edcc90e45

Change-Id: Ib0e1bf8b76c163eafbd909d81f0137dc9a247d25

5 years agoFix for GATT not returning disconnect callback.
Jakub Pawlowski [Tue, 2 Apr 2019 17:21:14 +0000 (19:21 +0200)]
Fix for GATT not returning disconnect callback.

Before recent refactor GATT was using the L2CAP layer to start LE
connections. Since the refactor, GATT talks directly to added
connection_manager, just like L2CAP.
L2CAP does have it's own timer for direct connections, that was
returning conneciton failure after timeout. After switching to
connection_manager, GATT no longer receives those callbacks.

This patch makes the connection_manager send the on_connection_timed_out
callback, and wire it to same handler that L2CAP layer was using before.

Test: unit tests added
Bug: 125553095
Change-Id: Iaf8be46fe8eed49f78ddbc6a2f3516bc8279e91f

5 years agoRootCanal: Add beacons by default
Myles Watson [Tue, 2 Apr 2019 20:57:46 +0000 (13:57 -0700)]
RootCanal: Add beacons by default

Bug: 129546852
Test: Scan for devices using RootCanal as the Bluetooth chip
Change-Id: Ia17535bffbcdde28db5120f99aad45a915f1a7ca

5 years agoMerge "Common: remove GD related stuff from common"
Jack He [Tue, 2 Apr 2019 20:57:49 +0000 (13:57 -0700)]
Merge "Common: remove GD related stuff from common"
am: 98695adc1c

Change-Id: I13d8f4c471ad366b52740f2d39faf78600e9f9a1

5 years agoMerge "Common: remove GD related stuff from common"
Treehugger Robot [Tue, 2 Apr 2019 20:07:54 +0000 (20:07 +0000)]
Merge "Common: remove GD related stuff from common"

5 years agoCommon: remove GD related stuff from common
Jack He [Mon, 1 Apr 2019 23:20:14 +0000 (16:20 -0700)]
Common: remove GD related stuff from common

* Remove reactor, thread, handler, alarm, repeating alarm from common/
  since they are already copied into gd/os
* Extract thread and alarm benchmarks into gd:bluetooth_benchmark_gd
* Enable host side unit tests for system/bt in TEST_MAPPING

Bug: 129537494
Test: run benchmark, run unit tests
Change-Id: Id5d7592067bab3275976dfc710e4d751c43b9df8

5 years agoAvoid using erase()d iterator
Greg Kaiser [Tue, 2 Apr 2019 17:02:47 +0000 (10:02 -0700)]
Avoid using erase()d iterator
am: 120f377694

Change-Id: I5039b59eae6da98daa35581a51ed9112d9cb1d73

5 years agobtif_storage: Avoid extra std::string copies
Greg Kaiser [Tue, 2 Apr 2019 17:02:34 +0000 (10:02 -0700)]
btif_storage: Avoid extra std::string copies
am: 709a29f9e9

Change-Id: I5867967366a9e17af8529153d7ea37f7bd78e72d

5 years agoAvoid using erase()d iterator
Greg Kaiser [Mon, 1 Apr 2019 13:47:23 +0000 (06:47 -0700)]
Avoid using erase()d iterator

After calling erase(it), 'it' is no longer valid and should not be
used as it was in the 'it++' of the 'for' loop.  We change to
update 'it' to the result of erase(), and only perform 'it++' if
we're not erasing it.

Test: TreeHugger
Change-Id: If7889fdca76a6883aeb4341be1a6fff466585e29

5 years agobtif_storage: Avoid extra std::string copies
Greg Kaiser [Tue, 26 Mar 2019 16:09:28 +0000 (09:09 -0700)]
btif_storage: Avoid extra std::string copies

When a function takes a const std::string reference for an
argument, it's inefficient to pass in std::string::c_str().

Test: TreeHugger
Change-Id: Ibd00c10a08ab853875fd16739bce5851f6b42639

5 years agoMerge "Fix use of uninitialised variable"
Yi Kong [Tue, 2 Apr 2019 08:16:31 +0000 (01:16 -0700)]
Merge "Fix use of uninitialised variable"
am: 52b5f32e07

Change-Id: I315935b706a7386547caac06c8e8f981e71e7431

5 years agoMerge "Fix use of uninitialised variable"
Yi Kong [Tue, 2 Apr 2019 08:04:02 +0000 (08:04 +0000)]
Merge "Fix use of uninitialised variable"

5 years agoMerge "Disable Link layer socket device test in rootcanal"
Hansong Zhang [Tue, 2 Apr 2019 04:23:36 +0000 (21:23 -0700)]
Merge "Disable Link layer socket device test in rootcanal"
am: 460d035101

Change-Id: Id72df7c7f5336a337575c4bc29c5f0cee15b4d53

5 years agoMerge "Disable Link layer socket device test in rootcanal"
Treehugger Robot [Tue, 2 Apr 2019 04:14:33 +0000 (04:14 +0000)]
Merge "Disable Link layer socket device test in rootcanal"

5 years ago[automerger skipped] Merge "Revert "DO NOT MERGE Hearing Aid: Add JNI API for add...
Weichin Weng [Tue, 2 Apr 2019 02:14:04 +0000 (19:14 -0700)]
[automerger skipped] Merge "Revert "DO NOT MERGE Hearing Aid: Add JNI API for add/remove whitelist""
am: 864fe7ad39 -s ours
am skip reason: subject contains skip directive

Change-Id: I5c1ff1bbe0f3c7fc665e6f89d4eabebecd26a961

5 years agoMerge "Revert "DO NOT MERGE Hearing Aid: Add JNI API for add/remove whitelist""
Weichin Weng [Tue, 2 Apr 2019 01:48:09 +0000 (01:48 +0000)]
Merge "Revert "DO NOT MERGE Hearing Aid: Add JNI API for add/remove whitelist""

5 years agoDisable Link layer socket device test in rootcanal
Hansong Zhang [Mon, 1 Apr 2019 23:33:52 +0000 (16:33 -0700)]
Disable Link layer socket device test in rootcanal

Test: presubmit
Bug: 129537494
Change-Id: I852da314ab65052a0e1a794f5faa9f21e1249efe

5 years agoMerge "Fix assert macro logical inversion"
Zach Johnson [Mon, 1 Apr 2019 21:15:17 +0000 (14:15 -0700)]
Merge "Fix assert macro logical inversion"
am: c5b38fae53

Change-Id: I1651a93c09137f8a5d159cf056d3ea3d0c115831

5 years agoMerge "Fix assert macro logical inversion"
Zach Johnson [Mon, 1 Apr 2019 20:12:03 +0000 (20:12 +0000)]
Merge "Fix assert macro logical inversion"

5 years agoFix assert macro logical inversion
Zach Johnson [Fri, 29 Mar 2019 19:45:50 +0000 (12:45 -0700)]
Fix assert macro logical inversion

Rename FATAL_WHEN to ASSERT and LOG_FATAL_WHEN to ASSERT_LOG

Test: atest
Change-Id: I0e6e15ce7cfbb89e76910181f164e8ff32abc033

5 years agoRevert "DO NOT MERGE Hearing Aid: Add JNI API for add/remove whitelist"
weichinweng [Fri, 29 Mar 2019 06:07:52 +0000 (14:07 +0800)]
Revert "DO NOT MERGE Hearing Aid: Add JNI API for add/remove whitelist"

This reverts commit d65f697c011cc6e5eaad767de3ec726cfd25b27f.
This CL is merge into AOSP in error due to the block copy from
pi-dev-plus-aosp

Test: run unit test
Change-Id: I9e206465e832d263084895b7c7b808df4573f986
Merged-In: Iab11567fa326b6837a621c1edc93e0eceb04ec43

5 years agoFix use of uninitialised variable
Yi Kong [Fri, 29 Mar 2019 23:15:50 +0000 (16:15 -0700)]
Fix use of uninitialised variable

The fallthrough code path on L264 does not initialise the type variable
but it is used on L270.

Test: m checkbuild
Bug: 129566813
Change-Id: I18eb3b9be1712bac844aeb804ab76b218580c4b6

5 years agoMerge "Fix potential null point dereference"
Hansong Zhang [Fri, 29 Mar 2019 16:20:02 +0000 (09:20 -0700)]
Merge "Fix potential null point dereference"
am: 6bb3296e5e

Change-Id: I92ba1186cf0517023faafc1251b34bc513522000

5 years agoMerge "Fix potential null point dereference"
Hansong Zhang [Fri, 29 Mar 2019 15:55:25 +0000 (15:55 +0000)]
Merge "Fix potential null point dereference"

5 years agoFix potential null point dereference
Ted Wang [Fri, 29 Mar 2019 08:20:27 +0000 (16:20 +0800)]
Fix potential null point dereference

Use find() to check element in map to avoid unknow element been insert
into map causing null point dereference.

Bug: 121310341
Test: Manual connect/disconnect headset
Change-Id: If127086ec4beb9b735ef3c72456e8e2209826b57

5 years agoMerge changes Ice4cee21,I6e579811,Ieae0cb21
Zach Johnson [Fri, 29 Mar 2019 01:20:26 +0000 (18:20 -0700)]
Merge changes Ice4cee21,I6e579811,Ieae0cb21
am: 7c12a1727d

Change-Id: Ie2fd9170d55c4ef2cf2a7b7864489e37dac17e6a

5 years agoMerge changes Ice4cee21,I6e579811,Ieae0cb21
Zach Johnson [Fri, 29 Mar 2019 01:15:40 +0000 (01:15 +0000)]
Merge changes Ice4cee21,I6e579811,Ieae0cb21

* changes:
  RootCanal: Add more scripts
  RootCanal: Desktop simulation envrionment
  RootCanal: New Directory Structure

5 years agoMerge "Get gd os tests running on host"
Zach Johnson [Fri, 29 Mar 2019 00:50:06 +0000 (17:50 -0700)]
Merge "Get gd os tests running on host"
am: d4e4cc2f51

Change-Id: Icc5eb98cf87d1311b35a5730b5497a290cdace2d

5 years agoMerge "Get gd os tests running on host"
Zach Johnson [Fri, 29 Mar 2019 00:37:33 +0000 (00:37 +0000)]
Merge "Get gd os tests running on host"

5 years agoMerge "Run code coverage only on host target"
Hansong Zhang [Thu, 28 Mar 2019 22:02:52 +0000 (15:02 -0700)]
Merge "Run code coverage only on host target"
am: 36277fcc67

Change-Id: I8dabacad4bc7c30001a55827c8f976704a89d549

5 years agoRootCanal: Add more scripts
Myles Watson [Thu, 7 Feb 2019 23:21:25 +0000 (15:21 -0800)]
RootCanal: Add more scripts

Test: Connect to HCI sockets and LinkLayer sockets
Change-Id: Ice4cee21f295bbb3a3fe35cfe44073028e65d811

5 years agoRootCanal: Desktop simulation envrionment
Myles Watson [Wed, 13 Feb 2019 20:36:32 +0000 (12:36 -0800)]
RootCanal: Desktop simulation envrionment

Test: nativetest64/root-canal/root-canal [TEST_PORT] [HCI_PORT] [LINK_PORT]
      python scripts/test_channel.py

Change-Id: I6e57981182c392366d7d97249d837694b49dfa4e

5 years agoRootCanal: New Directory Structure
Myles Watson [Fri, 18 Jan 2019 19:42:33 +0000 (11:42 -0800)]
RootCanal: New Directory Structure

model/controller/ contains the simulated chip
model/devices/ contains simulated devices
model/setup/ contains the test model
packets/link_layer/ contains the fake LMP packets

Test: cts-verifier Insecure RFCOMM test
      LinkLayerPacketBuilderTest
      rootcanal-packets_test_host
Change-Id: Ieae0cb21f7d57c03797f800797cedae59dd70e49

5 years agoGet gd os tests running on host
Zach Johnson [Thu, 28 Mar 2019 02:15:38 +0000 (19:15 -0700)]
Get gd os tests running on host

* Run os tests on host
* Fix flaky hander clear test
* Move to linux_generic
* Remove dependency on libchrome
* Allow alarms to run on linux host where we can't get CAP_WAKE_ALARM

Test: atest bluetooth_gd_test_os
Change-Id: Ia95ce39169ac8c963052e3252e7b39ef32bd5bb1

5 years agoMerge "Run code coverage only on host target"
Treehugger Robot [Thu, 28 Mar 2019 21:42:33 +0000 (21:42 +0000)]
Merge "Run code coverage only on host target"

5 years agoRun code coverage only on host target
Hansong Zhang [Wed, 27 Mar 2019 22:49:13 +0000 (15:49 -0700)]
Run code coverage only on host target

Bug: 129421924
Test: run code coverage
Change-Id: I1dc681c72d8af29e43ccb1441ffd218059b8056c

5 years agoMerge "BQR: Fix for the issue that Bluetooth keeps on crashing if the controller...
Ray Kuo [Thu, 28 Mar 2019 16:48:48 +0000 (09:48 -0700)]
Merge "BQR: Fix for the issue that Bluetooth keeps on crashing if the controller firmware does not support the BQR feature."
am: c19e159920

Change-Id: Ieb9dfdb35d8740114c2a94e0453de6762ef4ecc9

5 years agoMerge "BQR: Fix for the issue that Bluetooth keeps on crashing if the controller...
Treehugger Robot [Thu, 28 Mar 2019 16:37:55 +0000 (16:37 +0000)]
Merge "BQR: Fix for the issue that Bluetooth keeps on crashing if the controller firmware does not support the BQR feature."

5 years agoMerge "Only use the new format in gd/"
Zach Johnson [Thu, 28 Mar 2019 03:19:58 +0000 (20:19 -0700)]
Merge "Only use the new format in gd/"
am: 8b3df83108

Change-Id: I4129cc39765902b3aec64180c814e8105ef95693

5 years agoMerge "Only use the new format in gd/"
Zach Johnson [Thu, 28 Mar 2019 03:09:39 +0000 (03:09 +0000)]
Merge "Only use the new format in gd/"

5 years agoMerge "Copy reactor classes to new directory"
Hansong Zhang [Wed, 27 Mar 2019 22:41:57 +0000 (15:41 -0700)]
Merge "Copy reactor classes to new directory"
am: 10a6432c6a

Change-Id: If973570cbc40c3110cb9a0caa63ad2c461523aa6

5 years agoMerge "Copy reactor classes to new directory"
Treehugger Robot [Wed, 27 Mar 2019 22:32:09 +0000 (22:32 +0000)]
Merge "Copy reactor classes to new directory"

5 years agoOnly use the new format in gd/
Myles Watson [Wed, 27 Mar 2019 22:26:49 +0000 (15:26 -0700)]
Only use the new format in gd/

Test: Upload a change with long lines
Change-Id: Iba4a08f9556219bfada9a13272463acbf7ddbdce

5 years agoMerge "A2DP: Initialize the UIPC HAL only when those binderized HALs are not enabled"
Cheney Ni [Wed, 27 Mar 2019 21:34:30 +0000 (14:34 -0700)]
Merge "A2DP: Initialize the UIPC HAL only when those binderized HALs are not enabled"
am: 2ef65b9065

Change-Id: Ic82f8948428d14e4761892ad53334b2bacdd00d3

5 years agoMerge "A2DP: Initialize the UIPC HAL only when those binderized HALs are not enabled"
Treehugger Robot [Wed, 27 Mar 2019 21:07:29 +0000 (21:07 +0000)]
Merge "A2DP: Initialize the UIPC HAL only when those binderized HALs are not enabled"

5 years agoCopy reactor classes to new directory
Hansong Zhang [Tue, 19 Mar 2019 23:17:42 +0000 (16:17 -0700)]
Copy reactor classes to new directory

Test: compile and run unit test
Change-Id: Ie704bf6b80f24bcae86d557ca351a893dcf8bdfa

5 years agoMerge "Hearing aid: use new common/Timer"
Hansong Zhang [Wed, 27 Mar 2019 17:44:20 +0000 (10:44 -0700)]
Merge "Hearing aid: use new common/Timer"
am: 39eba7165c

Change-Id: I31592f1e4ea83cb41e94b50ce76c1e578dffa35c

5 years agoMerge "Hearing aid: use new common/Timer"
Treehugger Robot [Wed, 27 Mar 2019 17:26:06 +0000 (17:26 +0000)]
Merge "Hearing aid: use new common/Timer"

5 years agoA2DP: Initialize the UIPC HAL only when those binderized HALs are not enabled
Cheney Ni [Wed, 27 Mar 2019 12:58:49 +0000 (20:58 +0800)]
A2DP: Initialize the UIPC HAL only when those binderized HALs are not enabled

When using BluetoothA2dp / BluetoothAudio HAL, the UIPC won't be used,
and is no need to do the initialization. If it is up, there will be an
uipc-main thread running, and we have to release by the UIPC_Close API
before the A2DP source restarting. If we are acquiring a new one before
released, some of its resource will be leaked, and causes the stack
abnormal.

Bug: 128256722
Test: Check uipc-main is running when using the legacy HAL only
Change-Id: Icc8ea102d29c92b58c77099979d17e85e5cb9a83

5 years agoAdd test about post/clear task from callback for handler
Chienyuan [Mon, 25 Mar 2019 16:39:33 +0000 (09:39 -0700)]
Add test about post/clear task from callback for handler
am: 13369ff8d1

Change-Id: Iafc38c79a208bd37c3c9872d3e0db1f43ca21cd6

5 years agoAdd test about post/clear task from callback for handler
Chienyuan [Sat, 23 Mar 2019 00:12:52 +0000 (17:12 -0700)]
Add test about post/clear task from callback for handler

Test: sudo ./bluetooth_test_common
Change-Id: Ibbf8622a705d3523638ef6cc9e6a62130b877637

5 years agoHearing aid: use new common/Timer
Hansong Zhang [Thu, 21 Mar 2019 18:21:31 +0000 (11:21 -0700)]
Hearing aid: use new common/Timer

Previously osi/alarm cannot be cancelled or freed while in a callback.
Replace it with common/Timer. It's safe to be cancelled in a callback
and well tested.

Bug: 119533256
Test: manual
Change-Id: I73c7c98d683c85ec8f0f4256c3e4bccf3e11b56a

5 years agoMerge "Fallback to the legacy HAL when IBluetoothAudioProvidersFactory is unsupported"
Cheney Ni [Fri, 22 Mar 2019 07:55:34 +0000 (00:55 -0700)]
Merge "Fallback to the legacy HAL when IBluetoothAudioProvidersFactory is unsupported"
am: 86ef0c76da

Change-Id: Ie257f7cad6ed4180e8ae3ea858b52edcdbd06f72

5 years agoMerge "Fallback to the legacy HAL when IBluetoothAudioProvidersFactory is unsupported"
Treehugger Robot [Fri, 22 Mar 2019 07:46:23 +0000 (07:46 +0000)]
Merge "Fallback to the legacy HAL when IBluetoothAudioProvidersFactory is unsupported"

5 years agoBQR: Fix for the issue that Bluetooth keeps on crashing if the
Ray Kuo [Thu, 21 Mar 2019 09:55:47 +0000 (17:55 +0800)]
BQR: Fix for the issue that Bluetooth keeps on crashing if the
controller firmware does not support the BQR feature.

Considering for the Treble case, it might upgrade the system image
only and the BQR feature will be enabled on a device whose Bluetooth
controller firmware does not support the BQR feature. The change is
not to crash the system if the controller firmware does not handle the
BQR VSC.

Bug: 129037162
Test: Enabled the BQR feature on the device whose Bluetooth controller
firmware does not support the BQR feature. The Bluetooth can be turned
on and works normally.

Change-Id: I6e9310a2b604679ba300e558ae4482887501e022

5 years agoMerge "Refine the log messages of audio_bluetooth_hal"
Cheney Ni [Thu, 21 Mar 2019 02:10:50 +0000 (19:10 -0700)]
Merge "Refine the log messages of audio_bluetooth_hal"
am: cb7b7e432f

Change-Id: If20d0574941b1a3d24119d24b862e30d571ede90

5 years agoMerge "Add a workaround to play A2DP SBC Mono"
Cheney Ni [Thu, 21 Mar 2019 02:10:18 +0000 (19:10 -0700)]
Merge "Add a workaround to play A2DP SBC Mono"
am: 532316c0ae

Change-Id: Ic7f2a1442ede61a7720f2e7c25cda02efc551411

5 years agoMerge "Refine the log messages of audio_bluetooth_hal"
Treehugger Robot [Thu, 21 Mar 2019 02:03:49 +0000 (02:03 +0000)]
Merge "Refine the log messages of audio_bluetooth_hal"

5 years agoMerge "Add a workaround to play A2DP SBC Mono"
Treehugger Robot [Thu, 21 Mar 2019 02:03:11 +0000 (02:03 +0000)]
Merge "Add a workaround to play A2DP SBC Mono"

5 years agoMerge "Add event_value to BluetoothClassicPairingEventReported"
Jack He [Thu, 21 Mar 2019 00:46:39 +0000 (17:46 -0700)]
Merge "Add event_value to BluetoothClassicPairingEventReported"
am: a0060ceed6

Change-Id: I9d2823e129b28fc2b59c788a8245018d07226679

5 years agoMerge "Add event_value to BluetoothClassicPairingEventReported"
Treehugger Robot [Thu, 21 Mar 2019 00:33:08 +0000 (00:33 +0000)]
Merge "Add event_value to BluetoothClassicPairingEventReported"

5 years agoMerge "Use PLOG rather than LOG strerror(errno)."
Elliott Hughes [Wed, 20 Mar 2019 19:52:40 +0000 (12:52 -0700)]
Merge "Use PLOG rather than LOG strerror(errno)."
am: fa450772a8

Change-Id: I4fa20e7921ba336ddc866e3596e1f1e602eea5d6

5 years agoMerge "Use PLOG rather than LOG strerror(errno)."
Elliott Hughes [Wed, 20 Mar 2019 19:41:28 +0000 (19:41 +0000)]
Merge "Use PLOG rather than LOG strerror(errno)."

5 years agoRefine the log messages of audio_bluetooth_hal
Cheney Ni [Wed, 20 Mar 2019 11:53:35 +0000 (19:53 +0800)]
Refine the log messages of audio_bluetooth_hal

This CL follows the review suggestions at aosp/920718 and aosp/925233 to
refine logs.

Bug: none
Test: check logs manually
Change-Id: I3c57afaf6d416752687a7a697a310fe98c8ee495

5 years agoAdd a workaround to play A2DP SBC Mono
Cheney Ni [Mon, 11 Mar 2019 12:49:11 +0000 (20:49 +0800)]
Add a workaround to play A2DP SBC Mono

There is a similar WAR of aosp/522661 at A2DP legacy HAL. In order to
suport MONO channel mode, the PCM audio is pulled as STEREO and mixed
into MONO by the Bluetooth Audio HAL.

Test: Playing SBC mono with Headset
Bug: 127593318
Change-Id: I78f3973ba6c8c733dc18122288a915daed97be65

5 years agoAdd event_value to BluetoothClassicPairingEventReported
Jack He [Wed, 20 Mar 2019 11:04:36 +0000 (04:04 -0700)]
Add event_value to BluetoothClassicPairingEventReported

* Add an event_value field to log status value such as
 - encryption enabled state
 - simple pairing mode
 - secure connection host support
 - delete all flag
* Use the event_value field to log above information during
  classic pairing process instead

Bug: 128966402
Test: make
Change-Id: I2a87c3837754bfc5bcd55f72325400c428c2ca25

5 years agoAdd Rx RSSI logs for Hearing Aids
Stanley Tng [Mon, 18 Mar 2019 20:34:55 +0000 (13:34 -0700)]
Add Rx RSSI logs for Hearing Aids
am: 10c80b5ce2

Change-Id: I1bbded7fff9ddf1c4d1bb637df1d86d565371d07

5 years agoFallback to the legacy HAL when IBluetoothAudioProvidersFactory is unsupported
Cheney Ni [Thu, 14 Mar 2019 12:58:59 +0000 (20:58 +0800)]
Fallback to the legacy HAL when IBluetoothAudioProvidersFactory is unsupported

Because the stack may run without the new BluetoothAudio HAL like GSI
under old devices, it will be nullptr to getService from the
IBluetoothAudioProvidersFactory in such condition. We take nullptr as
unsupported, and fallback to the legacy HAL.

Bug: 128419724
Test: Manually running A2DP and hearing aid with / without the HAL
Change-Id: I606abc3e5b63b7857c3307c879fd4cbe46dd05d9

5 years agoAdd Rx RSSI logs for Hearing Aids
Stanley Tng [Mon, 25 Feb 2019 20:05:22 +0000 (12:05 -0800)]
Add Rx RSSI logs for Hearing Aids

When there is a data buffer flush (which indicates data congestion),
the received RSSI will be queried for this connection multiple times and
logged in the dumpsys.

Bug: 124331686
Test: Manual test
Change-Id: I686f4e34bda3f8067b42d6b41ca8bf316a5bf6f1

5 years agoUse PLOG rather than LOG strerror(errno).
Elliott Hughes [Fri, 15 Mar 2019 03:22:17 +0000 (20:22 -0700)]
Use PLOG rather than LOG strerror(errno).

Test: builds
Change-Id: I75c3311ce00fccc79b8efc198ce69ffed96e805a

5 years agoMerge "Allow to disable the rootcanal test console with a property"
Jorge Moreira Broche [Thu, 14 Mar 2019 20:35:43 +0000 (13:35 -0700)]
Merge "Allow to disable the rootcanal test console with a property"
am: ddd6a6f7c0

Change-Id: Id29f2fbec572e3cbab7273a8223caf7394414add

5 years agoMerge "Allow to disable the rootcanal test console with a property"
Jorge Moreira Broche [Thu, 14 Mar 2019 20:19:03 +0000 (20:19 +0000)]
Merge "Allow to disable the rootcanal test console with a property"

5 years agoMerge "No need to abort the audio HAL / Bluetooth when failed to suspend"
Cheney Ni [Thu, 14 Mar 2019 18:24:59 +0000 (11:24 -0700)]
Merge "No need to abort the audio HAL / Bluetooth when failed to suspend"
am: 0cc83418b1

Change-Id: Ia71c87eb6fe33267eee4339d759ee96edaf3ee0a

5 years agoMerge "No need to abort the audio HAL / Bluetooth when failed to suspend"
Treehugger Robot [Thu, 14 Mar 2019 18:08:12 +0000 (18:08 +0000)]
Merge "No need to abort the audio HAL / Bluetooth when failed to suspend"