mark results from sysconf() queries as static

that way queries are done once per thread

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

validate stack size in QThread::setStackSize()

that way threads will not fail if it is less than the minimum, the warning
from QThread::start() is basically invisible to GUI users unless
application is started from terminal which is far from ideal. one has
to install own message handler via qInstallMsgHandler() to make such
warnings noticable to GUI users, possible via QErrorMessage, which should
be errors in fact and printed via qCritical() but making such changes is
beyond the scope of this commit

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

avoid copy in qt_toX11Pixmap()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

simplify QPaintEngineEx::supportsTransformations() logic

remove redundant forward declaration of QPixmapFilter class in qpaintengineex_p header

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

move misc drawing helper functions to the top of qdrawhelper source

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

mark qt_bayer_matrix constant and qConvertRgb16To32() function as static

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

optimize QRasterPaintEnginePrivate::isUnclipped() methods

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

replace conditional memory rotation templates with their body

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused and internal virtual QPaintEngineEx methods

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove forward declaration of non-existing qt_stroke_dash()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused and internal QPathClipper::ClipperMode enums

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

return result of QWingedEdge::toPath() directly in QPathClipper::clip()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove redundant qt_memrotate90_template<T, T>() specialization

same implementation as the generic one

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove code for always false condition in brushes pattern cache

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove redundant QFont enums casts and constructs

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

mark CSS parser constants as static

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove redundant qglobal header inclusion from qbackingstore source

use local instead of system style headers inclusion while at it

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused interpolate_pixel_unaligned_2() drawing helper

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

move qt_get_named_rgb() to qcolor source file, replace qt_get_colornames() with its body

that way the qt_get_named_rgb() function can be made static and marked
inline. the loop in QColor::colorNames() can be unrolled by the compiler
too. while at it, remove the duplicate code in the SVG handler

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused and internal QWidgetPrivate::DrawWidgetFlags enums

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused QWidgetBackingStore::beginPaint() argument

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

update tables data to CLDR v36.1

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

mark some constants as static

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

add unifdef to build dependencies of Debian package [ci skip]

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

fix regression since 28d63e9b27d82c2de090d72699b273b77b28de30

apparently if default is used the cursor may not be one from theme set
via XcursorSetTheme(), it affects not only left_ptr alternative too so
try non-alternative first

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

correct cast qualifier in blend_untransformed_argb()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

move non-shared drawing helper functions to qdrawhelper source file

also mark comp_func_Plus_one_pixel() as static while at it

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

add libsm-dev to build dependencies of Debian package [ci skip]

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

optimize blend_src_generic() drawing helper

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused and internal qt_paint_device_metric()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

append to OBJECT_DEPENDS property from katie_setup_target() macro

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

update unicode data tables to v13.0

combining types which harfbuzz does not support are no longer added to the
tables too, this should make obtaining properties of text faster.

special language table used to probe fonts for scripts support should be
reviewed once new CLDR version is released to add proper language entries
if present in likelySubtags.xml

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

use static strings for RCC tags/attributes

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused QScript::Lexer members

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove code for always false condition in QRasterPaintEngine

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused QRasterPaintEnginePrivate::getPenFunc() method

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

get rid of QRasterPaintEnginePrivate::deviceRectUnclipped member

not used anywhere but in QRasterPaintEnginePrivate::systemStateChanged()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused drawing function prototypes

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

replace default with QSpanData::None case in getOperator()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

correct reinterpret_cast<T> qualifier in destFetch()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

avoid temporaries in qt_gradient_quint32() and qt_gradient_quint16()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

replace qt_rectfill_template<T> with its body in QT_RECTFILL() macro

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

mark some fast drawing helper functions as static

while at it, make RadialFetchPlain::fetch() static function and merge
qt_fetch_radial_gradient_template<> into qt_fetch_radial_gradient()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

optimize drawing helper function tables

avoids many functions calls, while at it const-ify and assign variables
once only where possible. replacing pre-processor macros is done to make
the code more readable and easy to search for function calls

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused drawing helper functions

since those functions are marked inline, neither GCC nor Clang warn that
they are not used even with -Wunused

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

avoid copy in qt_alphargbblit_quint32() , qt_alphamapblit_quint32() and qt_alphamapblit_quint32()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

always use full paths for installation

now that CPack is no longer supported relative paths are no longer
required. this change also fixes the headers optimizations upon
installation since it requires full paths to work

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

avoid copy in QSQLiteDriver::primaryIndex() and QSQLiteDriver::record()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused QScriptValue::ResolveFlag enums

use correct type for the flags while at it and remove internal
QScriptValue::scope() and QScriptValue::setScope() methods

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused QListWidgetItemPrivate::q member

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove explicit dependencies from Debian package control file

dh_shlibdeps can detect them and their removal makes the control file
more suitable for producing package files for Debian/Ubuntu releases
other than the current Debian stable release which I am using it for

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove code for always false condition in QDirModelPrivate

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

update translations [ci skip]

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove LPR support leftovers

removes the NSL and NIS optional dependencies and effectively speeds up
the initialization of printing dialog and obtaining of information about
prineters. this change leaves CUPS as the only option to support
printing

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused and internal QUnixPrintWidget::updatePrinter()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused and private QGraphicsItemPrivate::subFocusItemChange()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused qplatformdefs header definitions

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove deprecated Qt::DateFormat enums

indent and replace default with enum case while at it. automated
adjustments can be done with the following command:

find -type f -exec sed \
    -e 's|Qt::SystemLocaleDate|Qt::SystemLocaleShortDate|g' \
    -e 's|Qt::LocalDate|Qt::SystemLocaleShortDate|g' \
    -e 's|Qt::LocaleDate|Qt::DefaultLocaleShortDate|g' -i {} +

if you are doing it to git repository, move it out of the way as the
command may corrupt it.

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

avoid relocations in QString::arg() QChar/char overloads

QString's += operator reallocates data and the temporary shared null will
not be used

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

fix blank characters check in QChar::isSpace()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

update list of supported operating systems in qglobal header

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

move plugin verification pattern to qt_find_pattern()

making it and the its length static aswell as removing redundant check if
pattern is null while at it

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

replace 0 with Q_NULLPTR where applicable

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused checks for debug-build plugins

QT_NO_DEBUG_PLUGIN_CHECK is defined for any UNIX-like operating system,
which is the only type Katie supports. this change will reduce the size of
plugins slightly and loading plugins will be faster.

Q_PLUGIN_INSTANCE() plugins macro is private so it was merged into
Q_EXPORT_PLUGIN2() and rebrand QFactoryLoader cache key while at it.

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove compat leftovers

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

correct brushes QRC prefix in BrushManagerProxy::setBrushManager()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

drop support for static plugins

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

fix loading of plugins with a relative file name

the libraries path was missing from the list returned by
QCoreApplication::libraryPaths() which as stated in its documentation
is used when dynamically loading libraries so that's also fixed with this
change and is required for the libraries lookup.

obviously, QLibraryPrivate::findOrCreate() was not looking for libraries at
all despite the function name so code for that had to be moved from
QLibraryPrivate::load_sys() which makes it possible to load not only plugins
but also library with relative file name.

support for QLibrary::LoadHint::LoadArchiveMemberHint was dropped in the
process, QLibrary::LoadHint::ImprovedSearchHeuristics is not used thus
removed.

in the future QCoreApplication::pluginPaths() may be added to separate the
library/plugin paths but for now compatibility with projects expecting it
to return plugin paths will be kept. when that is done
QCoreApplication::libraryPaths() will check LD_LIBRARY_PATH instead of
QT_PLUGIN_PATH environment variable.

upstream commit:
https://github.com/qt/qtbase/commit/418890e0748384eb684f33b10dc6f32493aee54b

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove redundant condition in QFileInfoPrivate::getFileName()

if the string is null, setting it to empty is will only change its
reference to shared empty

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

inline qstrcmp() function for performance reasons

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

silence dpkg-gensymbols during packaging [ci skip]

otherwise it dumps ~30k lines of symbols everytime a fresh package is build

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove <MODULE>_FIND_QUIETLY overrides from CMake modules

since find_package_handle_standard_args() is used and no status messages
are printed by the modules there is no reason to set <MODULE>_FIND_QUIETLY
variable (which should be prefixed with the actual module name, not upper
case)

do not append application path to library paths

this was used for dll/bundles support most likely, on UNIX however adding
it to the library paths is incorrect. The runtime path (RPATH) hardcoded
into libraries/binaries should be searched instead however that is not
supported and removed by most distributions on purpose.

with this change application startup time is reduced by a lot since the
binary paths (/bin, /sbin, etc.) do not have to be listed which usually
contain large number of binaries and even symbolic/hard links

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

create leading directories of settings filepath

for compatibility with code expecting it to be created

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

prefix standard function calls in qt_print_backtrace()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

indent QNetworkReplyImplPrivate::_q_networkSessionConnected()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused registerHelper<T>() argument

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove qlocalserver_tcp source file

used for symbian, wince and integrity which are no longer supported

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

replace 0 with Q_NULLPTR where applicable

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

use foreach() for iteration in QThread::exit()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused QtFontFamily::synthetic member

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused qt_fallback_font_family() and qt_x11_set_fallback_font_family()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove abstract file handler support leftovers

no longer supported since e02ce5c0e02ad7a830f11d281b2641362a1df2c0

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

use custom CMake module for PostgreSQL

the module CMake provides cannot detect it in Travis

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

drop QSqlDriverCreator support

it is prone to race condition and not used, if anyone wants to add
driver it should really be a plugin

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove WITH_PNG AND WITH_SQLITE options, build SQLite driver into KtSql module

both are not really optional, that is why internal copies of the PNG and
SQLite projects sources are bundled.

by making the SQLite SQL driver built-in the plasma-desktop process
memory usage was reduced by roughly 4MB.

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

replace 0 with Q_NULLPTR where applicable

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove unused QDeclarativeJS::NodePool::m_codeCache member

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

get rid of QFileIconProviderPrivate

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove redundant condition in QIconTheme::QIconTheme()

fallback theme is hicolor

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

use foreach() for iteration in QIconLoader::findIconHelper()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

use CLOCK_MONOTONIC_COARSE if available in do_gettime()

used by jemalloc for an example, as for the exact precision lose it is not
clear what it is from the clock_gettime() manual page. it is not clear from
the patch posted at https://lwn.net/Articles/347811/ nor from the commit
message at https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/include/linux/time.h?h=v5.6-rc1&id=da15cfdae03351c689736f8d142618592e3cebc3
either.

https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux_for_real_time/7/html/tuning_guide/using_coarse_posix_clocks_for_application_timestamping
claims that it is 1ms which seems like a good trade-off to me

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

update QSettings group methods documentation

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

session management requires X11 ICE extension in addition to SM

while at it, remove X11_LIBRARIES from the list of additional libraries
of KtGui component to avoid overlinking

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove compatibility Qt::Modifier::UNICODE_ACCEL enum

upstream commit:
https://github.com/qt/qtbase/commit/bc6ad75d18a029da363afc4f6007aefc7962a8ad

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

rewrite CMake modules to use pkg-config search first and fallback to path lookup

reducec the configuration/build time

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

replace 0 with Q_NULLPTR in QSharedDataPointer and QExplicitlySharedDataPointer

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

remove CPack related variables, CPack will not be supported

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

optimize QString::multiArg()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>