OSDN Git Service

android-x86/system-bt.git
6 years agoGATT: Fix usage of 16 and 32 bit UUID's in Discover services by UUID am: a84a40afd3
Hemant Gupta [Tue, 22 May 2018 19:25:33 +0000 (12:25 -0700)]
GATT: Fix usage of 16 and 32 bit UUID's in Discover services by UUID am: a84a40afd3
am: ec034fd9c6

Change-Id: Ib918ece461f99a4853c6338a456020920fc86ca3

6 years agoGATT: Fix usage of 16 and 32 bit UUID's in Discover services by UUID
Hemant Gupta [Tue, 22 May 2018 19:03:13 +0000 (12:03 -0700)]
GATT: Fix usage of 16 and 32 bit UUID's in Discover services by UUID
am: a84a40afd3

Change-Id: Iaac3700166b006b3fcd6c259d36f52b3f605c9a1

6 years agoMerge "HFP: Set audio handle for active device during incoming call" am: 9bef78a5b6...
Jack He [Tue, 22 May 2018 18:45:28 +0000 (11:45 -0700)]
Merge "HFP: Set audio handle for active device during incoming call" am: 9bef78a5b6 am: 1267c7e4d6
am: f542d83795

Change-Id: Ib40e8f507bfdec8bdb10287b33f9bfed6185fce3

6 years agoMerge "HFP: Set audio handle for active device during incoming call" am: 9bef78a5b6
Jack He [Tue, 22 May 2018 18:36:34 +0000 (11:36 -0700)]
Merge "HFP: Set audio handle for active device during incoming call" am: 9bef78a5b6
am: 1267c7e4d6

Change-Id: Ib78a0f309d12f489ff2f6d98e18dad485a300952

6 years agoMerge "HFP: Set audio handle for active device during incoming call"
Jack He [Tue, 22 May 2018 18:31:23 +0000 (11:31 -0700)]
Merge "HFP: Set audio handle for active device during incoming call"
am: 9bef78a5b6

Change-Id: I5ee74df6c21914f1b03e045d60a1fa40e3cc1096

6 years agoMerge "HFP: Set audio handle for active device during incoming call"
Treehugger Robot [Tue, 22 May 2018 18:17:38 +0000 (18:17 +0000)]
Merge "HFP: Set audio handle for active device during incoming call"

6 years agoMerge "Use the effective peer MTU when preparing the codec configuration" am: 35b08f5...
Pavlin Radoslavov [Tue, 22 May 2018 18:07:43 +0000 (11:07 -0700)]
Merge "Use the effective peer MTU when preparing the codec configuration" am: 35b08f5708 am: b578b37882
am: 196c09d117

Change-Id: I57d451b693151b2d3a766177a7144390ea737213

6 years agoMerge "Don't mix internal AVDTP state when connecting to two devices" am: d0eff6ef6c...
Pavlin Radoslavov [Tue, 22 May 2018 17:51:55 +0000 (10:51 -0700)]
Merge "Don't mix internal AVDTP state when connecting to two devices" am: d0eff6ef6c am: 89d81544de
am: ce8c382ac8

Change-Id: I364778e602bac98a2e767c8d7aa1b0e39c4644dd

6 years agoMerge "Use the effective peer MTU when preparing the codec configuration" am: 35b08f5708
Pavlin Radoslavov [Tue, 22 May 2018 17:44:41 +0000 (10:44 -0700)]
Merge "Use the effective peer MTU when preparing the codec configuration" am: 35b08f5708
am: b578b37882

Change-Id: I080f3bad3e6e5e4731e95ec87dee80a5149d75cf

6 years agoMerge "Use the effective peer MTU when preparing the codec configuration"
Pavlin Radoslavov [Tue, 22 May 2018 17:40:06 +0000 (10:40 -0700)]
Merge "Use the effective peer MTU when preparing the codec configuration"
am: 35b08f5708

Change-Id: Id2a86ff485aa61c60bd61ea55c296164983fe159

6 years agoMerge "Don't mix internal AVDTP state when connecting to two devices" am: d0eff6ef6c
Pavlin Radoslavov [Tue, 22 May 2018 17:36:12 +0000 (10:36 -0700)]
Merge "Don't mix internal AVDTP state when connecting to two devices" am: d0eff6ef6c
am: 89d81544de

Change-Id: I1f505d46c5a138cd0c89e63669c00fe20637a2fb

6 years agoMerge "Use the effective peer MTU when preparing the codec configuration"
Treehugger Robot [Tue, 22 May 2018 17:32:18 +0000 (17:32 +0000)]
Merge "Use the effective peer MTU when preparing the codec configuration"

6 years agoMerge "Don't mix internal AVDTP state when connecting to two devices"
Pavlin Radoslavov [Tue, 22 May 2018 17:30:46 +0000 (10:30 -0700)]
Merge "Don't mix internal AVDTP state when connecting to two devices"
am: d0eff6ef6c

Change-Id: I2d538de9b73bdcb12800cc30eb38c848f384dc83

6 years agoMerge "Don't mix internal AVDTP state when connecting to two devices"
Treehugger Robot [Tue, 22 May 2018 17:25:31 +0000 (17:25 +0000)]
Merge "Don't mix internal AVDTP state when connecting to two devices"

6 years agoMerge "gatt_api: Avoid possible NULL dereference" am: bea526992d am: ac64837245
Greg Kaiser [Tue, 22 May 2018 16:47:38 +0000 (09:47 -0700)]
Merge "gatt_api: Avoid possible NULL dereference" am: bea526992d am: ac64837245
am: f6dd53faf0

Change-Id: I2f020a1f4ca61a8bd12ced3006a0ab31682b36a2

6 years agoMerge "gatt_api: Avoid possible NULL dereference" am: bea526992d
Greg Kaiser [Tue, 22 May 2018 16:42:31 +0000 (09:42 -0700)]
Merge "gatt_api: Avoid possible NULL dereference" am: bea526992d
am: ac64837245

Change-Id: I3b84a95ff4f5f6b110856c35c4e3ea658672011a

6 years agoMerge "gatt_api: Avoid possible NULL dereference"
Greg Kaiser [Tue, 22 May 2018 16:38:13 +0000 (09:38 -0700)]
Merge "gatt_api: Avoid possible NULL dereference"
am: bea526992d

Change-Id: Ic37eb3f50d9458b162e12a38a9d9164119f71c69

6 years agoMerge "gatt_api: Avoid possible NULL dereference"
Treehugger Robot [Tue, 22 May 2018 16:28:29 +0000 (16:28 +0000)]
Merge "gatt_api: Avoid possible NULL dereference"

6 years agoGATT: Fix usage of 16 and 32 bit UUID's in Discover services by UUID am: 37fdb267db...
Hemant Gupta [Tue, 22 May 2018 16:05:50 +0000 (09:05 -0700)]
GATT: Fix usage of 16 and 32 bit UUID's in Discover services by UUID am: 37fdb267db am: 92237a264c
am: a6ba11dfba

Change-Id: I8b4466146c68024071649e0b860977805a98ab1e

6 years agoUse the effective peer MTU when preparing the codec configuration
Pavlin Radoslavov [Tue, 22 May 2018 09:03:20 +0000 (02:03 -0700)]
Use the effective peer MTU when preparing the codec configuration

Added new method A2dpCodecConfig::getEffectiveMtu() and use it
to obtain the effective MTU per peer per codec.
The effective peer MTU could be smaller than the one reported
by the peer (e.g., for interoperability reasons).

Bug: 77913350
Test: Manual
Change-Id: Idd5230681ac5856fd18dd33ac48723c6ea609e16

6 years agoGATT: Fix usage of 16 and 32 bit UUID's in Discover services by UUID am: 37fdb267db
Hemant Gupta [Tue, 22 May 2018 15:58:08 +0000 (08:58 -0700)]
GATT: Fix usage of 16 and 32 bit UUID's in Discover services by UUID am: 37fdb267db
am: 92237a264c

Change-Id: I4616a28500041b306814c49da49ae85066cb2694

6 years agoGATT: Fix usage of 16 and 32 bit UUID's in Discover services by UUID
Hemant Gupta [Tue, 22 May 2018 15:52:15 +0000 (08:52 -0700)]
GATT: Fix usage of 16 and 32 bit UUID's in Discover services by UUID
am: 37fdb267db

Change-Id: I7f2ac1a2f2af399cb61d878f95c99c3bf5684590

6 years agoGATT: Fix usage of 16 and 32 bit UUID's in Discover services by UUID
Hemant Gupta [Tue, 22 May 2018 03:55:50 +0000 (09:25 +0530)]
GATT: Fix usage of 16 and 32 bit UUID's in Discover services by UUID

Fix improper usage of 16 and 32 bit UUID's in Disocever services by UUID
Fixes PTS test cases GATT/CL/GAD/BV-08-C and GATT/CL/GAR/BV-03-C.

Test: PTS test cases GATT/CL/GAD/BV-08-C and GATT/CL/GAR/BV-03-C passes

Bug: 80095184
Change-Id: Ia0a26bd20ee68c5c7db0bc00036634f6719f25e9

6 years agogatt_api: Avoid possible NULL dereference
Greg Kaiser [Tue, 22 May 2018 13:59:48 +0000 (06:59 -0700)]
gatt_api: Avoid possible NULL dereference

We move a logging statement which dereferences a NULL pointer
until after the NULL check, and expand the error message for
the NULL check to include the function name.

Test: TreeHugger
Change-Id: Ib5134b0d6b9ec5da95ee62da9412b977925000ee

6 years agoDon't mix internal AVDTP state when connecting to two devices
Pavlin Radoslavov [Fri, 18 May 2018 03:38:44 +0000 (20:38 -0700)]
Don't mix internal AVDTP state when connecting to two devices

There is a race condition when connecting to two devices, and
the connection to one of the devices is not powered on.

Because of the race condition, the wrong tBTA_AV_LCB entry inside
bta_av_sig_chg() might be allocated for the connection to
the device that is powered on. As a result of that, when
the connection attempt to the powered off device times out,
we will use the wrong bta_handle to close the existing AVDTP connection to
the device that is connected.

Also:
 - Add a new function BTA_AvObtainPeerChannelIndex() to select the
   appropriate AvdtpCcb entry if there an outgoing connection request
   while an incoming connection is received.
 - Added/updated log messages to help debugging similar issues in the future
 - Removed unnecessary SetActivePeer() call inside the BtifAv state
   machine for A2DP Source to avoid additional internal/transient glitches

Test: Manual
Bug: 79697137
Change-Id: Ie55e3dcf6c6a15637ce3631f2828548a2423d881

6 years agoGATT: Fix usage of 16 and 32 bit UUID's in Discover services by UUID
Hemant Gupta [Tue, 22 May 2018 03:55:50 +0000 (09:25 +0530)]
GATT: Fix usage of 16 and 32 bit UUID's in Discover services by UUID

Fix improper usage of 16 and 32 bit UUID's in Disocever services by UUID
Fixes PTS test cases GATT/CL/GAD/BV-08-C and GATT/CL/GAR/BV-03-C.

Test: PTS test cases GATT/CL/GAD/BV-08-C and GATT/CL/GAR/BV-03-C passes

Bug: 80095184
Change-Id: Ia0a26bd20ee68c5c7db0bc00036634f6719f25e9

6 years agoSimplify bta_gattc_sdp_callback am: cabb39c432 am: 0f1b7d0cd8
Jakub Pawlowski [Tue, 22 May 2018 00:34:54 +0000 (17:34 -0700)]
Simplify bta_gattc_sdp_callback am: cabb39c432 am: 0f1b7d0cd8
am: 6f917e837a

Change-Id: I0ec99468d812f45e5a5cc85139a195c69055d717

6 years agoSimplify bta_gattc_sdp_callback am: cabb39c432
Jakub Pawlowski [Tue, 22 May 2018 00:30:12 +0000 (17:30 -0700)]
Simplify bta_gattc_sdp_callback am: cabb39c432
am: 0f1b7d0cd8

Change-Id: I1f4ef1a49c53ff059a1ba2fd7e194534788d0400

6 years agoSimplify bta_gattc_sdp_callback
Jakub Pawlowski [Tue, 22 May 2018 00:24:09 +0000 (17:24 -0700)]
Simplify bta_gattc_sdp_callback
am: cabb39c432

Change-Id: I22016fd73cb6b01bb56aa82c712c8c1dbdcdc09f

6 years agoHFP: Set audio handle for active device during incoming call
Jack He [Tue, 22 May 2018 00:09:29 +0000 (17:09 -0700)]
HFP: Set audio handle for active device during incoming call

* Set audio handle for active device during incoming call
* Change debug level logging to warning level when SCO is not allowed to
  open or when RING command is not allowed to be sent

Bug: 77949569
Test: connect with HFP devices and receive incoming call
Change-Id: Ibc2caf740f94817ae725786e35e8592390167ce2

6 years agoMerge "HFP: Return SDP status to HFP layer" am: 0522a227b3 am: 5dcccc86e6
Jack He [Mon, 21 May 2018 23:28:27 +0000 (16:28 -0700)]
Merge "HFP: Return SDP status to HFP layer" am: 0522a227b3 am: 5dcccc86e6
am: 1297328bad

Change-Id: I942f4a8c00a3927f716ae2b89687a9bc6685d265

6 years agoUnify logging in gatt_api.cc am: 431cf613c4 am: 0a6b361ef8
Jakub Pawlowski [Mon, 21 May 2018 23:15:53 +0000 (16:15 -0700)]
Unify logging in gatt_api.cc am: 431cf613c4 am: 0a6b361ef8
am: 3aa8c16e3c

Change-Id: Ic35fea603904377e36d5675eb27641d908f36c1f

6 years agoMerge "HFP: Return SDP status to HFP layer" am: 0522a227b3
Jack He [Mon, 21 May 2018 22:37:31 +0000 (15:37 -0700)]
Merge "HFP: Return SDP status to HFP layer" am: 0522a227b3
am: 5dcccc86e6

Change-Id: I057c9f5d45fca858d93ea380ae4b2d87d18c70e2

6 years agoUnify logging in gatt_api.cc am: 431cf613c4
Jakub Pawlowski [Mon, 21 May 2018 22:36:06 +0000 (15:36 -0700)]
Unify logging in gatt_api.cc am: 431cf613c4
am: 0a6b361ef8

Change-Id: Id258ef3abd5cfadabc96c297c5079fa805506ad9

6 years agoSimplify bta_gattc_sdp_callback
Jakub Pawlowski [Fri, 18 May 2018 22:57:01 +0000 (15:57 -0700)]
Simplify bta_gattc_sdp_callback

* join multiple if statements to improve readability
* malloc and free memory just once for tBTA_GATTC_CB_DATA

Test: compilation
Change-Id: I907645ed04ed4b628a3b24785b1ccd16b69d83bb

6 years agoHFP: Return SDP status to HFP layer am: 90174f3514
Jack He [Mon, 21 May 2018 22:23:37 +0000 (15:23 -0700)]
HFP: Return SDP status to HFP layer am: 90174f3514
am: babe4002b6

Change-Id: I83bd930d81f5b77ab7245abb6d16445cfb92560f

6 years agoHFP: Return SDP status to HFP layer
Jack He [Mon, 21 May 2018 22:03:59 +0000 (15:03 -0700)]
HFP: Return SDP status to HFP layer
am: 90174f3514

Change-Id: I38ab45b2f5697977ca3d6a6d9e53a4ee24935e76

6 years agoMerge "HFP: Return SDP status to HFP layer"
Jack He [Mon, 21 May 2018 21:54:56 +0000 (14:54 -0700)]
Merge "HFP: Return SDP status to HFP layer"
am: 0522a227b3

Change-Id: I50e4a44b66ef727bd8243fc2182a2ddb36bbfbb1

6 years agoUnify logging in gatt_api.cc
Jakub Pawlowski [Mon, 21 May 2018 21:45:31 +0000 (14:45 -0700)]
Unify logging in gatt_api.cc
am: 431cf613c4

Change-Id: Ia4fa67a5c03c9c8b478550ff89534005d13a9165

6 years agoMerge "HFP: Return SDP status to HFP layer"
Treehugger Robot [Mon, 21 May 2018 21:20:07 +0000 (21:20 +0000)]
Merge "HFP: Return SDP status to HFP layer"

6 years agoUnify logging in gatt_api.cc
Jakub Pawlowski [Mon, 21 May 2018 16:38:48 +0000 (09:38 -0700)]
Unify logging in gatt_api.cc

- always log conn_id as hex value
- use "=" instead of ":" as delimiter between name and value
- get rid of StringPrintf

Test: compilation
Change-Id: Ia35b79c3732b19661e4655d5cf0923b7e701985f

6 years agoHFP: Return SDP status to HFP layer
Jack He [Sun, 20 May 2018 03:05:02 +0000 (20:05 -0700)]
HFP: Return SDP status to HFP layer

* Fix an error introduced in change Ic0b4498dd623d0ea31b4513d6b7861cae390bc72
  so that SDP status is sent up to the HFP BTA layer
* With SDP status correctly passed up, HFP BTA layer can correctly
  determine when to continue SDP search for HSP
* When open connection to HFP or HSP devices, use a control block's
  registered services instead of passing in opening services every time
  from BTIF layer
* Do not use a control block that are in CONNECTING or DISCONNECTING
  state
* Add a crash in btif_hf.cc:connect_int() to gurantee that no control
  block is in connecting or disconnecting state when connect_int is
  called as it should be guranteed by the btif queue configuration

Bug: 74234576
Test: connect to headset, make calls and hangup
Change-Id: I5e2bce8c2f0f51bd3fd3e85e82827c5fb5e92887
(cherry picked from commit 4bf260f2b71c15f091290b16f6c7948b21fa7c49)

6 years agoHFP: Return SDP status to HFP layer
Jack He [Sun, 20 May 2018 03:05:02 +0000 (20:05 -0700)]
HFP: Return SDP status to HFP layer

* Fix an error introduced in change Ic0b4498dd623d0ea31b4513d6b7861cae390bc72
  so that SDP status is sent up to the HFP BTA layer
* With SDP status correctly passed up, HFP BTA layer can correctly
  determine when to continue SDP search for HSP
* When open connection to HFP or HSP devices, use a control block's
  registered services instead of passing in opening services every time
  from BTIF layer
* Do not use a control block that are in CONNECTING or DISCONNECTING
  state
* Add a crash in btif_hf.cc:connect_int() to gurantee that no control
  block is in connecting or disconnecting state when connect_int is
  called as it should be guranteed by the btif queue configuration

Bug: 74234576
Test: connect to headset, make calls and hangup
Change-Id: I5e2bce8c2f0f51bd3fd3e85e82827c5fb5e92887

6 years agoMerge "AVRCP: Route CType NOT_IMPLEMENTED as a response" into pi-dev am: 436f56f20c
Myles Watson [Sat, 19 May 2018 00:36:32 +0000 (17:36 -0700)]
Merge "AVRCP: Route CType NOT_IMPLEMENTED as a response" into pi-dev am: 436f56f20c
am: bdff60d21c

Change-Id: I12a12272cc110090faab5ee272881589fbcb6670

6 years agoMerge "AVRCP: Route CType NOT_IMPLEMENTED as a response" into pi-dev
Myles Watson [Sat, 19 May 2018 00:26:41 +0000 (17:26 -0700)]
Merge "AVRCP: Route CType NOT_IMPLEMENTED as a response" into pi-dev
am: 436f56f20c

Change-Id: I759f0640c662c18427c77ff211ddd5ae11b221ab

6 years agoMerge "AVRCP: Route CType NOT_IMPLEMENTED as a response" into pi-dev
TreeHugger Robot [Sat, 19 May 2018 00:08:21 +0000 (00:08 +0000)]
Merge "AVRCP: Route CType NOT_IMPLEMENTED as a response" into pi-dev

6 years agoAVRCP: Route CType NOT_IMPLEMENTED as a response am: f74cecf93e am: 6a5e210804
Myles Watson [Fri, 18 May 2018 21:19:43 +0000 (14:19 -0700)]
AVRCP: Route CType NOT_IMPLEMENTED as a response am: f74cecf93e am: 6a5e210804
am: f3a308b77a

Change-Id: I8a468bc9f9f5d8b0a9467016af4f95ad75c39fae

6 years agoAVRCP: Route CType NOT_IMPLEMENTED as a response am: f74cecf93e
Myles Watson [Fri, 18 May 2018 21:15:10 +0000 (14:15 -0700)]
AVRCP: Route CType NOT_IMPLEMENTED as a response am: f74cecf93e
am: 6a5e210804

Change-Id: If966673e261a623f9b397e813ab44eec3e59b37b

6 years agoAVRCP: Route CType NOT_IMPLEMENTED as a response
Myles Watson [Fri, 18 May 2018 21:12:06 +0000 (14:12 -0700)]
AVRCP: Route CType NOT_IMPLEMENTED as a response
am: f74cecf93e

Change-Id: I1e9c0c55cc7f510f04c6a6add316248c6ae6ca52

6 years agoAVRCP: Route CType NOT_IMPLEMENTED as a response
Myles Watson [Fri, 18 May 2018 18:31:33 +0000 (11:31 -0700)]
AVRCP: Route CType NOT_IMPLEMENTED as a response

Fixes: 79698590
Test: net_test_avrcp, Connect to the Anker MP140
Change-Id: Ie88dcea949ecb33bc3d76d86b07ab0396a21500d
(cherry picked from commit f74cecf93e648e861363aa312bef08327f19a26a)

6 years agoAVRCP: Route CType NOT_IMPLEMENTED as a response
Myles Watson [Fri, 18 May 2018 18:31:33 +0000 (11:31 -0700)]
AVRCP: Route CType NOT_IMPLEMENTED as a response

Bug: 79698590
Test: net_test_avrcp, Connect to the Anker MP140
Change-Id: Ie88dcea949ecb33bc3d76d86b07ab0396a21500d

6 years agoAdd General Reject for invalid PDU ID am: 7570175750 am: e259e19c82
tedwang [Thu, 17 May 2018 18:46:29 +0000 (11:46 -0700)]
Add General Reject for invalid PDU ID am: 7570175750 am: e259e19c82
am: c66997eecf

Change-Id: I872595fdf013fc9246c153f99cb18a9f25a4ff8c

6 years agoAdd General Reject for invalid PDU ID am: 7570175750
tedwang [Thu, 17 May 2018 18:42:10 +0000 (11:42 -0700)]
Add General Reject for invalid PDU ID am: 7570175750
am: e259e19c82

Change-Id: Id9f5d8cb142c01915c198c4eae6db687cbc985f4

6 years agoAdd General Reject for invalid PDU ID
tedwang [Thu, 17 May 2018 18:38:35 +0000 (11:38 -0700)]
Add General Reject for invalid PDU ID
am: 7570175750

Change-Id: I47d646e48c002a241806f49d058f1674e8b1e2a6

6 years agoMerge "Respond reject with INVALID_PARAMETER when register for invalid event ID"...
tedwang [Thu, 17 May 2018 13:58:22 +0000 (06:58 -0700)]
Merge "Respond reject with INVALID_PARAMETER when register for invalid event ID" into pi-dev am: f1ae2359c5
am: f6531734ea

Change-Id: Ief63a75a7d802c407902a6364efa64e7e0b31866

6 years agoMerge "Add General Reject for invalid PDU ID" into pi-dev am: 759463fbd7
tedwang [Thu, 17 May 2018 13:57:45 +0000 (06:57 -0700)]
Merge "Add General Reject for invalid PDU ID" into pi-dev am: 759463fbd7
am: b834537f9c

Change-Id: Ie2445aed2e0ff5fd2f56873de2f6350ddba831d2

6 years agoMerge "AVRCP: Verify SetBrowsedPlayer player ID" into pi-dev am: 0f2fef3bfa
Hansong Zhang [Thu, 17 May 2018 13:56:46 +0000 (06:56 -0700)]
Merge "AVRCP: Verify SetBrowsedPlayer player ID" into pi-dev am: 0f2fef3bfa
am: b19e3b3924

Change-Id: Iff9dda28e2e018c6e0ad7c317afef6944f99ea0d

6 years agoMerge "AVRCP: Respond UID Changed for invalid Get Item Attributes command" into pi...
Hansong Zhang [Thu, 17 May 2018 13:56:23 +0000 (06:56 -0700)]
Merge "AVRCP: Respond UID Changed for invalid Get Item Attributes command" into pi-dev am: e5c4f78345
am: fc36054dc1

Change-Id: I7716ba0ee6f59926a3c8ea967f277601812dcc15

6 years agoMerge "Respond reject with INVALID_PARAMETER when register for invalid event ID"...
tedwang [Thu, 17 May 2018 13:47:56 +0000 (06:47 -0700)]
Merge "Respond reject with INVALID_PARAMETER when register for invalid event ID" into pi-dev
am: f1ae2359c5

Change-Id: Ib45ab00fcb68ba2e212372e457169c60e0c8dd27

6 years agoMerge "Add General Reject for invalid PDU ID" into pi-dev
tedwang [Thu, 17 May 2018 13:47:23 +0000 (06:47 -0700)]
Merge "Add General Reject for invalid PDU ID" into pi-dev
am: 759463fbd7

Change-Id: Ie32a40d584c86d5d5d34785b4718ec2f866a8000

6 years agoMerge "AVRCP: Verify SetBrowsedPlayer player ID" into pi-dev
Hansong Zhang [Thu, 17 May 2018 13:46:15 +0000 (06:46 -0700)]
Merge "AVRCP: Verify SetBrowsedPlayer player ID" into pi-dev
am: 0f2fef3bfa

Change-Id: I844366fdadf2e6ac343a6856c556949c0c03b2ea

6 years agoMerge "AVRCP: Respond UID Changed for invalid Get Item Attributes command" into pi-dev
Hansong Zhang [Thu, 17 May 2018 13:45:45 +0000 (06:45 -0700)]
Merge "AVRCP: Respond UID Changed for invalid Get Item Attributes command" into pi-dev
am: e5c4f78345

Change-Id: Ie5de37208a6028405900255045cee1ecc2af1d1c

6 years agoMerge "Respond reject with INVALID_PARAMETER when register for invalid event ID"...
TreeHugger Robot [Thu, 17 May 2018 13:32:39 +0000 (13:32 +0000)]
Merge "Respond reject with INVALID_PARAMETER when register for invalid event ID" into pi-dev

6 years agoMerge "Add General Reject for invalid PDU ID" into pi-dev
TreeHugger Robot [Thu, 17 May 2018 13:32:20 +0000 (13:32 +0000)]
Merge "Add General Reject for invalid PDU ID" into pi-dev

6 years agoMerge "AVRCP: Verify SetBrowsedPlayer player ID" into pi-dev
TreeHugger Robot [Thu, 17 May 2018 13:31:13 +0000 (13:31 +0000)]
Merge "AVRCP: Verify SetBrowsedPlayer player ID" into pi-dev

6 years ago[automerger skipped] Don't update the MTU across multiple A2DP connections that are...
Pavlin Radoslavov [Thu, 17 May 2018 13:31:12 +0000 (06:31 -0700)]
[automerger skipped] Don't update the MTU across multiple A2DP connections that are open am: fb691de015  -s ours
am: dd2634bea8  -s ours

Change-Id: Ie9a9b25231dae2852182af59f605adb1381754c2

6 years agoMerge "AVRCP: Respond UID Changed for invalid Get Item Attributes command" into pi-dev
TreeHugger Robot [Thu, 17 May 2018 13:30:21 +0000 (13:30 +0000)]
Merge "AVRCP: Respond UID Changed for invalid Get Item Attributes command" into pi-dev

6 years ago[automerger skipped] Don't update the MTU across multiple A2DP connections that are...
Pavlin Radoslavov [Thu, 17 May 2018 13:17:39 +0000 (06:17 -0700)]
[automerger skipped] Don't update the MTU across multiple A2DP connections that are open
am: fb691de015  -s ours

Change-Id: I73a525a744d50526b4dabd0eb4b04376e57bada9

6 years agoAdd General Reject for invalid PDU ID
tedwang [Tue, 15 May 2018 14:21:39 +0000 (22:21 +0800)]
Add General Reject for invalid PDU ID

Add Avrcp Browse General Reject packet
Respond general reject when undefined AVRCP Browsing PDU ID sent from
remote.

Bug: 79376704
Test: run host native test net_test_btpackets
Change-Id: I8a44d8e3f0cc5fac89e23217726c76ede4aff916
(cherry picked from commit 3fbf8b4fff8b52b781fa611e0b62c97bca28d76f)

6 years agoDon't update the MTU across multiple A2DP connections that are open am: 1200c75df8...
Pavlin Radoslavov [Wed, 16 May 2018 21:09:48 +0000 (14:09 -0700)]
Don't update the MTU across multiple A2DP connections that are open am: 1200c75df8 am: fd90d087f1
am: 3970d6d597

Change-Id: Ia40397883b2bc2bff885a6cea046ca9c2056dfc3

6 years agoDon't update the MTU across multiple A2DP connections that are open
Pavlin Radoslavov [Wed, 16 May 2018 02:21:03 +0000 (19:21 -0700)]
Don't update the MTU across multiple A2DP connections that are open

Remove function bta_av_chk_mtu() that updates the MTU to the smallest
value across all open A2DP connections, because that function is not needed.
Such MTU update is problematic for Multi-A2DP, because some codecs cannot
be initialized/used if the MTU is too small. E.g., for LDAC the
MTU value used for the codec initialization must be at least 679.

Bug: 79675742
Test: Manual - (1)Connect Bose QC35; (2)Connect Sony SRS-XB2; (3)Play music
Change-Id: I8048a1bf6df6d4d6291bf3570a95b5182af15b6a
Merged-In: I8048a1bf6df6d4d6291bf3570a95b5182af15b6a
(cherry picked from commit 1200c75df85ac3d4f49b91039334077ada60e0cb)

6 years agoDon't update the MTU across multiple A2DP connections that are open am: 1200c75df8
Pavlin Radoslavov [Wed, 16 May 2018 20:52:13 +0000 (13:52 -0700)]
Don't update the MTU across multiple A2DP connections that are open am: 1200c75df8
am: fd90d087f1

Change-Id: I3abc1367524d8fa3cf7cd3b256c9eba9d10b7606

6 years agoDon't update the MTU across multiple A2DP connections that are open
Pavlin Radoslavov [Wed, 16 May 2018 20:48:39 +0000 (13:48 -0700)]
Don't update the MTU across multiple A2DP connections that are open
am: 1200c75df8

Change-Id: Ia64122410907b4ab25b6c1efd29b9459d9a6b45f

6 years agoAdd General Reject for invalid PDU ID
tedwang [Tue, 15 May 2018 14:21:39 +0000 (22:21 +0800)]
Add General Reject for invalid PDU ID

Add Avrcp Browse General Reject packet
Respond general reject when undefined AVRCP Browsing PDU ID sent from
remote.

Bug: 79376704
Test: run host native test net_test_btpackets
Change-Id: I8a44d8e3f0cc5fac89e23217726c76ede4aff916

6 years agoDon't update the MTU across multiple A2DP connections that are open
Pavlin Radoslavov [Wed, 16 May 2018 02:21:03 +0000 (19:21 -0700)]
Don't update the MTU across multiple A2DP connections that are open

Remove function bta_av_chk_mtu() that updates the MTU to the smallest
value across all open A2DP connections, because that function is not needed.
Such MTU update is problematic for Multi-A2DP, because some codecs cannot
be initialized/used if the MTU is too small. E.g., for LDAC the
MTU value used for the codec initialization must be at least 679.

Bug: 79675742
Test: Manual - (1)Connect Bose QC35; (2)Connect Sony SRS-XB2; (3)Play music
Change-Id: I8048a1bf6df6d4d6291bf3570a95b5182af15b6a

6 years ago[automerger skipped] Merge "Print extra error code if LDAC encoder fails to initializ...
Pavlin Radoslavov [Wed, 16 May 2018 01:57:13 +0000 (18:57 -0700)]
[automerger skipped] Merge "Print extra error code if LDAC encoder fails to initialize" into pi-dev am: ca2d3b62be  -s ours
am: 05d914a14f  -s ours

Change-Id: Id1cde778ad89ab5bba6b75622abb04a9e3e3daa3

6 years agoHID: Update state to disconnected in virtual unplug am: 53c7924cb2
Hemant Gupta [Wed, 16 May 2018 01:49:26 +0000 (18:49 -0700)]
HID: Update state to disconnected in virtual unplug am: 53c7924cb2
am: a5ccf6ce89

Change-Id: I0ea8e006ecc57da055baa423c9837b157159e423

6 years ago[automerger skipped] Merge "Print extra error code if LDAC encoder fails to initializ...
Pavlin Radoslavov [Wed, 16 May 2018 01:49:02 +0000 (18:49 -0700)]
[automerger skipped] Merge "Print extra error code if LDAC encoder fails to initialize" into pi-dev
am: ca2d3b62be  -s ours

Change-Id: Iec541681ea71a08d2ca3f1457886665fee8fd9de

6 years agoMerge "Print extra error code if LDAC encoder fails to initialize" into pi-dev
TreeHugger Robot [Wed, 16 May 2018 01:34:58 +0000 (01:34 +0000)]
Merge "Print extra error code if LDAC encoder fails to initialize" into pi-dev

6 years agoHID: Update state to disconnected in virtual unplug
Hemant Gupta [Wed, 16 May 2018 01:25:28 +0000 (18:25 -0700)]
HID: Update state to disconnected in virtual unplug
am: 53c7924cb2

Change-Id: I7727c35cc81f732fc8385cb236fc951e5b8381d9

6 years agoMerge "Respond reject with INVALID_PARAMETER when register for invalid event ID"...
tedwang [Wed, 16 May 2018 00:47:26 +0000 (17:47 -0700)]
Merge "Respond reject with INVALID_PARAMETER when register for invalid event ID" am: 4298549380 am: 0244fc1c1f
am: 5fa6170632

Change-Id: I2b6032f0540f46e8918560f263a50427dea02f43

6 years agoMerge "Print extra error code if LDAC encoder fails to initialize" am: 3a537a3e07...
Pavlin Radoslavov [Wed, 16 May 2018 00:45:35 +0000 (17:45 -0700)]
Merge "Print extra error code if LDAC encoder fails to initialize" am: 3a537a3e07 am: c31fde65c7
am: 311814385d

Change-Id: I27ea1c06ba3cf1198660393fd3fb35d16889820e

6 years agoMerge "Respond reject with INVALID_PARAMETER when register for invalid event ID"...
tedwang [Wed, 16 May 2018 00:29:22 +0000 (17:29 -0700)]
Merge "Respond reject with INVALID_PARAMETER when register for invalid event ID" am: 4298549380
am: 0244fc1c1f

Change-Id: I79efd457de254a5239dc78c553e214197fe27b7f

6 years agoMerge "Respond reject with INVALID_PARAMETER when register for invalid event ID"
tedwang [Wed, 16 May 2018 00:24:45 +0000 (17:24 -0700)]
Merge "Respond reject with INVALID_PARAMETER when register for invalid event ID"
am: 4298549380

Change-Id: I4e02d05557fc9d3cb9d052c633f0e496f849334c

6 years agoMerge "Print extra error code if LDAC encoder fails to initialize" am: 3a537a3e07
Pavlin Radoslavov [Wed, 16 May 2018 00:16:47 +0000 (17:16 -0700)]
Merge "Print extra error code if LDAC encoder fails to initialize" am: 3a537a3e07
am: c31fde65c7

Change-Id: I0e607f0361c2de6a089cb9d03e45b4a58b37b903

6 years agoMerge "Respond reject with INVALID_PARAMETER when register for invalid event ID"
Treehugger Robot [Wed, 16 May 2018 00:12:44 +0000 (00:12 +0000)]
Merge "Respond reject with INVALID_PARAMETER when register for invalid event ID"

6 years agoMerge "Print extra error code if LDAC encoder fails to initialize"
Pavlin Radoslavov [Wed, 16 May 2018 00:05:35 +0000 (17:05 -0700)]
Merge "Print extra error code if LDAC encoder fails to initialize"
am: 3a537a3e07

Change-Id: I6dd95962d924044315b90a52ada37a8fc3c5b21a

6 years agoAVRCP: Respond UID Changed for invalid Get Item Attributes command am: 335d6e62b0...
Hansong Zhang [Tue, 15 May 2018 23:50:59 +0000 (16:50 -0700)]
AVRCP: Respond UID Changed for invalid Get Item Attributes command am: 335d6e62b0 am: ac5adbde45
am: 43ac963a53

Change-Id: Iceb456e3a6b85056a0e6308601233d0a6c8954ff

6 years agoPrint extra error code if LDAC encoder fails to initialize
Pavlin Radoslavov [Tue, 15 May 2018 10:19:41 +0000 (03:19 -0700)]
Print extra error code if LDAC encoder fails to initialize

Also, add a missing CHECK() assert that the LDAC handle is valid.

Bug: 79675742
Test: Code compilation
Change-Id: I4bd51ed978eadc2aecc27d199e6f01bb31c9a631
Merged-In: I4bd51ed978eadc2aecc27d199e6f01bb31c9a631
(cherry picked from commit d963d2b2827aa6f1638eaa87597f28bb9d7a88d4)

6 years agoMerge "Print extra error code if LDAC encoder fails to initialize"
Treehugger Robot [Tue, 15 May 2018 23:21:27 +0000 (23:21 +0000)]
Merge "Print extra error code if LDAC encoder fails to initialize"

6 years agoAdd respond Reject with Invalid parameter for Unknown Capability ID am: bf514e3954...
tedwang [Tue, 15 May 2018 23:21:12 +0000 (16:21 -0700)]
Add respond Reject with Invalid parameter for Unknown Capability ID am: bf514e3954 am: da4e76d165
am: 659d72d979

Change-Id: I6febcc24cbb70af820b33ed9426d4de3b375c381

6 years agoRespond reject with INVALID_PARAMETER when register for invalid event ID
tedwang [Tue, 15 May 2018 07:25:11 +0000 (15:25 +0800)]
Respond reject with INVALID_PARAMETER when register for invalid event ID

It should respond reject with INVALID_PARAMETER instead of
INVALID_COMMAND while remote registering for an invalid event ID

Bug: 79377562
Test: PTS AVRCP/TG/NFY/BI-01-C
Change-Id: Ic006cb2f6584216f9457af5576dd2d39adaa3cf5
(cherry picked from commit d51c1dc6777eeb4d414c67e38999af436aaf71a8)

6 years agoRespond reject with INVALID_PARAMETER when register for invalid event ID
tedwang [Tue, 15 May 2018 07:25:11 +0000 (15:25 +0800)]
Respond reject with INVALID_PARAMETER when register for invalid event ID

It should respond reject with INVALID_PARAMETER instead of
INVALID_COMMAND while remote registering for an invalid event ID

Bug: 79377562
Test: PTS AVRCP/TG/NFY/BI-01-C
Change-Id: Ic006cb2f6584216f9457af5576dd2d39adaa3cf5

6 years agoAVRCP: Respond UID Changed for invalid Get Item Attributes command am: 335d6e62b0
Hansong Zhang [Tue, 15 May 2018 22:35:33 +0000 (15:35 -0700)]
AVRCP: Respond UID Changed for invalid Get Item Attributes command am: 335d6e62b0
am: ac5adbde45

Change-Id: Ic41890ca881353914d4937b61a81f75e289c982b

6 years agoAdd respond Reject with Invalid parameter for Unknown Capability ID am: bf514e3954
tedwang [Tue, 15 May 2018 22:35:02 +0000 (15:35 -0700)]
Add respond Reject with Invalid parameter for Unknown Capability ID am: bf514e3954
am: da4e76d165

Change-Id: Idf42383c603ec63acbfd3f20614b7562a1caa5fa

6 years agoAVRCP: Respond UID Changed for invalid Get Item Attributes command
Hansong Zhang [Tue, 15 May 2018 22:29:52 +0000 (15:29 -0700)]
AVRCP: Respond UID Changed for invalid Get Item Attributes command
am: 335d6e62b0

Change-Id: I90881349400f9d62723119fda172255bae1801b9

6 years agoAdd respond Reject with Invalid parameter for Unknown Capability ID
tedwang [Tue, 15 May 2018 22:29:28 +0000 (15:29 -0700)]
Add respond Reject with Invalid parameter for Unknown Capability ID
am: bf514e3954

Change-Id: I03cf9138cf3d7049cef4375a450d05dba36d5215

6 years agoMerge "AVRCP: Verify SetBrowsedPlayer player ID" am: 3103d311f4 am: ea82a8308d
Hansong Zhang [Tue, 15 May 2018 21:35:53 +0000 (14:35 -0700)]
Merge "AVRCP: Verify SetBrowsedPlayer player ID" am: 3103d311f4 am: ea82a8308d
am: 3e942d40ec

Change-Id: Ie5f573a64869e6102ecca251095a38365f69a261

6 years agoUse identity addr in BLE scan filter am: 9183ce4961
Claire Treyz [Tue, 15 May 2018 21:26:08 +0000 (14:26 -0700)]
Use identity addr in BLE scan filter am: 9183ce4961
am: e7bc6aa854

Change-Id: I48a3ea7d99ac558a68f8175b521c3e5a0bc2b3c5

6 years agoMerge "AVRCP: Verify SetBrowsedPlayer player ID" am: 3103d311f4
Hansong Zhang [Tue, 15 May 2018 20:45:02 +0000 (13:45 -0700)]
Merge "AVRCP: Verify SetBrowsedPlayer player ID" am: 3103d311f4
am: ea82a8308d

Change-Id: I4b7f286570f2ef65e7574f809b80c61890154009