OSDN Git Service
Tom Lane [Thu, 17 Feb 2011 00:24:45 +0000 (19:24 -0500)]
Fix bogus test for hypothetical indexes in get_actual_variable_range().
That function was supposing that indexoid == 0 for a hypothetical index,
but that is not likely to be true in any non-toy implementation of an index
adviser, since assigning a fake OID is the only way to know at EXPLAIN time
which hypothetical index got selected. Fix by adding a flag to
IndexOptInfo to mark hypothetical indexes. Back-patch to 9.0 where
get_actual_variable_range() was added.
Gurjeet Singh
Tom Lane [Wed, 16 Feb 2011 22:24:06 +0000 (17:24 -0500)]
Add backwards-compatible declarations of some core GIN support functions.
These are needed to support reloading dumps of 9.0 installations containing
contrib/intarray or contrib/tsearch2. Since not only regular dump/reload
but binary upgrade would fail, it seems worth the trouble to carry these
stubs for awhile. Note that the contrib opclasses referencing these
functions will still work fine, since GIN doesn't actually pay any
attention to the declared signature of a support function.
Peter Eisentraut [Wed, 16 Feb 2011 21:14:38 +0000 (23:14 +0200)]
Also process psqlrc when running psql -l
This was previously not very useful, but with many people customizing
the linestyle, it is nice for a consistent appearance.
Peter Eisentraut [Wed, 16 Feb 2011 21:06:36 +0000 (23:06 +0200)]
Better support for thread-support flag detection with clang
When testing the stderr produced by various thread-support flags, also
run a compilation in addition to a link, because clang warns on
certain flags when compiling but not when linking.
Peter Eisentraut [Wed, 16 Feb 2011 20:19:29 +0000 (22:19 +0200)]
Fix for warnings-free compilation with Python 3.2
The first argument of PyEval_EvalCode() was changed from PyCodeObject*
to PyObject* because of PEP 384.
Bruce Momjian [Wed, 16 Feb 2011 20:16:57 +0000 (15:16 -0500)]
In pg_upgrade, no need to initialize global struct values; they are
always zeros. Also no need to free memory before we exit.
Simon Riggs [Wed, 16 Feb 2011 19:29:37 +0000 (19:29 +0000)]
Hot Standby feedback for avoidance of cleanup conflicts on standby.
Standby optionally sends back information about oldestXmin of queries
which is then checked and applied to the WALSender's proc->xmin.
GetOldestXmin() is modified slightly to agree with GetSnapshotData(),
so that all backends on primary include WALSender within their snapshots.
Note this does nothing to change the snapshot xmin on either master or
standby. Feedback piggybacks on the standby reply message.
vacuum_defer_cleanup_age is no longer used on standby, though parameter
still exists on primary, since some use cases still exist.
Simon Riggs, review comments from Fujii Masao, Heikki Linnakangas, Robert Haas
Tom Lane [Wed, 16 Feb 2011 17:39:45 +0000 (12:39 -0500)]
Make a no-op ALTER EXTENSION UPDATE give just a NOTICE, not ERROR.
This seems a bit more user-friendly.
Alvaro Herrera [Wed, 16 Feb 2011 17:06:17 +0000 (14:06 -0300)]
Cleanup ClusterInfo initialization in pg_upgrade
Robert Haas [Wed, 16 Feb 2011 15:24:50 +0000 (10:24 -0500)]
WAL receiver shouldn't try to send a reply when dying.
Per report from, and discussion with, Fujii Masao.
Tom Lane [Wed, 16 Feb 2011 06:52:04 +0000 (01:52 -0500)]
Add FOREACH IN ARRAY looping to plpgsql.
(I'm not entirely sure that we've finished bikeshedding the syntax details,
but the functionality seems OK.)
Pavel Stehule, reviewed by Stephen Frost and Tom Lane
Robert Haas [Wed, 16 Feb 2011 02:28:48 +0000 (21:28 -0500)]
pg_ctl promote
Fujii Masao, reviewed by Robert Haas, Stephen Frost, and Magnus Hagander.
Itagaki Takahiro [Wed, 16 Feb 2011 02:19:11 +0000 (11:19 +0900)]
Export the external file reader used in COPY FROM as APIs.
They are expected to be used by extension modules like file_fdw.
There are no user-visible changes.
Itagaki Takahiro
Reviewed and tested by Kevin Grittner and Noah Misch.
Bruce Momjian [Wed, 16 Feb 2011 00:01:33 +0000 (19:01 -0500)]
Fix bug in 9.1 pg_upgrade processing of old/new relations; adjust debug
output.
Tom Lane [Tue, 15 Feb 2011 23:09:41 +0000 (18:09 -0500)]
Fix corner case for binary upgrade: extension functions in pg_catalog.
Normally, pg_dump summarily excludes functions in pg_catalog from
consideration. However, some extensions may create functions in pg_catalog
(adminpack already does that, and extensions for procedural languages will
likely do it too). In binary-upgrade mode, we have to dump such functions,
or the extension will be incomplete after upgrading. Per experimentation
with adminpack.
Alvaro Herrera [Tue, 15 Feb 2011 22:52:32 +0000 (19:52 -0300)]
Make pg_upgrade compile again
Tom Lane [Tue, 15 Feb 2011 20:49:54 +0000 (15:49 -0500)]
Add CheckTableNotInUse calls in DROP TABLE and DROP INDEX.
Recent releases had a check on rel->rd_refcnt in heap_drop_with_catalog,
but failed to cover the possibility of pending trigger events at DROP time.
(Before 8.4 we didn't even check the refcnt.) When the trigger events were
eventually fired, you'd get "could not open relation with OID nnn" errors,
as in recent report from strk. Better to throw a suitable error when the
DROP is attempted.
Also add a similar check in DROP INDEX.
Back-patch to all supported branches.
Bruce Momjian [Tue, 15 Feb 2011 20:00:07 +0000 (15:00 -0500)]
Adjust pg_upgrade error message, array freeing, and add error check.
Tom Lane [Tue, 15 Feb 2011 19:21:45 +0000 (14:21 -0500)]
Bring hstore's comment into line with style of other contrib comments.
All the other ones that are primarily a new datatype say "data type for
<purpose>", so make this one similar.
Tom Lane [Tue, 15 Feb 2011 18:27:03 +0000 (13:27 -0500)]
Fix obsolete comment.
Comment about MaxAllocSize was not updated when the TOAST-header macros
were replaced in 8.3 "varvarlena" changes. Per report from Frederik Ramm.
Robert Haas [Tue, 15 Feb 2011 17:02:53 +0000 (12:02 -0500)]
Assorted corrections to the patch to add WAL receiver replies.
Per reports from Fujii Masao.
Robert Haas [Tue, 15 Feb 2011 13:00:04 +0000 (08:00 -0500)]
Rename max_predicate_locks_per_transaction.
The new name, max_pred_locks_per_transaction, is shorter.
Kevin Grittner, per discussion.
Peter Eisentraut [Mon, 14 Feb 2011 19:52:32 +0000 (21:52 +0200)]
Allow make check in PL directories
Also add make check-world target, and refactor pg_regress invocation
code in makefiles a bit.
Robert Haas [Tue, 15 Feb 2011 04:17:35 +0000 (23:17 -0500)]
Avoid a few more SET DATA TYPE table rewrites.
When the new type is an unconstrained domain over the old type, we don't
need to rewrite the table.
Noah Misch and Robert Haas
Robert Haas [Tue, 15 Feb 2011 03:37:37 +0000 (22:37 -0500)]
Delete stray word from comment.
Tom Lane [Tue, 15 Feb 2011 01:59:42 +0000 (20:59 -0500)]
Rethink naming of contrib/intagg extension.
Initially it was called int_aggregate after the old SQL file, but since
the documentation just says "intagg" and that's also the directory name,
let's conform to that instead.
Simon Riggs [Tue, 15 Feb 2011 00:59:29 +0000 (00:59 +0000)]
Additional required docs for pg_constraint catalog entry
Noted by Bernd Helmle
Simon Riggs [Tue, 15 Feb 2011 00:51:39 +0000 (00:51 +0000)]
PITR can stop at a named restore point when recovery target = time
though must not update the last transaction timestamp.
Plus comment and message cleanup for recent named restore point.
Fujii Masao, minor changes by me
Tom Lane [Tue, 15 Feb 2011 00:45:46 +0000 (19:45 -0500)]
Fix MSVC build scripts for recent extension-related changes.
Untested, but we'll soon see if the buildfarm likes this.
Tom Lane [Mon, 14 Feb 2011 21:07:00 +0000 (16:07 -0500)]
Rearrange extension-related views as per recent discussion.
The original design of pg_available_extensions did not consider the
possibility of version-specific control files. Split it into two views:
pg_available_extensions shows information that is generic about an
extension, while pg_available_extension_versions shows all available
versions together with information that could be version-dependent.
Also, add an SRF pg_extension_update_paths() to assist in checking that
a collection of update scripts provide sane update path sequences.
Tom Lane [Mon, 14 Feb 2011 17:32:42 +0000 (12:32 -0500)]
Small improvements to external-projects documentation.
Simon Riggs [Tue, 15 Feb 2011 00:08:15 +0000 (00:08 +0000)]
Add version-sensitive SQL for psql when constraints NOT VALID
Bug report and fix by Andres Freund
Tom Lane [Mon, 14 Feb 2011 06:10:44 +0000 (01:10 -0500)]
Fix obsolete references to old-style contrib installation methods.
Tom Lane [Mon, 14 Feb 2011 04:42:13 +0000 (23:42 -0500)]
Remove no-longer-needed special case hacks in MSVC build scripts.
Tom Lane [Mon, 14 Feb 2011 04:33:18 +0000 (23:33 -0500)]
More fixups for "unpackaged" conversion scripts.
Tom Lane [Mon, 14 Feb 2011 03:53:00 +0000 (22:53 -0500)]
Assorted fixups for "unpackaged" conversion scripts.
From first pass of testing. Notably, there seems to be no need for
adminpack--unpackaged--1.0.sql because none of the objects that the
old module creates would ever be dumped by pg_dump anyway (they are
all in pg_catalog).
Tom Lane [Mon, 14 Feb 2011 02:24:14 +0000 (21:24 -0500)]
Avoid use of CREATE OR REPLACE FUNCTION in extension installation files.
It was never terribly consistent to use OR REPLACE (because of the lack of
comparable functionality for data types, operators, etc), and
experimentation shows that it's now positively pernicious in the extension
world. We really want a failure to occur if there are any conflicts, else
it's unclear what the extension-ownership state of the conflicted object
ought to be. Most of the time, CREATE EXTENSION will fail anyway because
of conflicts on other object types, but an extension defining only
functions can succeed, with bad results.
Tom Lane [Mon, 14 Feb 2011 01:06:41 +0000 (20:06 -0500)]
Convert contrib modules to use the extension facility.
This isn't fully tested as yet, in particular I'm not sure that the
"foo--unpackaged--1.0.sql" scripts are OK. But it's time to get some
buildfarm cycles on it.
sepgsql is not converted to an extension, mainly because it seems to
require a very nonstandard installation process.
Dimitri Fontaine and Tom Lane
Tom Lane [Sun, 13 Feb 2011 18:38:05 +0000 (13:38 -0500)]
Support replacing MODULE_PATHNAME during extension script file execution.
This avoids the need to find a way to make PGXS' .sql.in-to-.sql rule
insert the right thing. We'll just deprecate use of that hack for
extensions.
Tom Lane [Sun, 13 Feb 2011 18:03:41 +0000 (13:03 -0500)]
Change the naming convention for extension files to use double dashes.
This allows us to have an unambiguous rule for deconstructing the names
of script files and secondary control files, without having to forbid
extension and version names from containing any dashes. We do have to
forbid them from containing double dashes or leading/trailing dashes,
but neither restriction is likely to bother anyone in practice.
Per discussion, this seems like a better solution overall than the
original design.
Bruce Momjian [Sun, 13 Feb 2011 14:29:01 +0000 (09:29 -0500)]
Clarify documentation for libpq's PQescapeBytea to mention the new hex
format.
Modify PQescapeStringConn() docs to be consisent with other escaping
functions.
Add mention problems with pre-9.0 versions of libpq using not understanding
bytea hex format to the 9.0 release notes.
Backpatch to 9.0 docs.
Bruce Momjian [Sun, 13 Feb 2011 05:17:55 +0000 (00:17 -0500)]
Back out libpq doc change; not ready yet.
Bruce Momjian [Sun, 13 Feb 2011 05:14:08 +0000 (00:14 -0500)]
Fix reverse 'if' test in path_is_relative_and_below_cwd(), per Tom.
Tom Lane [Sat, 12 Feb 2011 21:40:41 +0000 (16:40 -0500)]
Refactor ALTER EXTENSION UPDATE to have cleaner multi-step semantics.
This change causes a multi-step update sequence to behave exactly as if the
updates had been commanded one at a time, including updating the "requires"
dependencies afresh at each step. The initial implementation took the
shortcut of examining only the final target version's "requires" and
changing the catalog entry but once. But on reflection that's a bad idea,
since it could lead to executing old update scripts under conditions
different than they were designed/tested for. Better to expend a few extra
cycles and avoid any surprises.
In the same spirit, if a CREATE EXTENSION FROM operation involves applying
a series of update files, it will act as though the CREATE had first been
done using the initial script's target version and then the additional
scripts were invoked with ALTER EXTENSION UPDATE.
I also removed the restriction about not changing encoding in secondary
control files. The new rule is that a script is assumed to be in whatever
encoding the control file(s) specify for its target version. Since this
reimplementation causes us to read each intermediate version's control
file, there's no longer any uncertainty about which encoding setting would
get applied.
Bruce Momjian [Sat, 12 Feb 2011 14:47:51 +0000 (09:47 -0500)]
Properly handle Win32 paths of 'E:abc', which can be either absolute or
relative, by creating a function path_is_relative_and_below_cwd() to
check for specific requirements. It is unclear if this fixes a security
problem or not but the new code is more robust.
Peter Eisentraut [Sat, 12 Feb 2011 13:54:13 +0000 (15:54 +0200)]
DDL support for collations
- collowner field
- CREATE COLLATION
- ALTER COLLATION
- DROP COLLATION
- COMMENT ON COLLATION
- integration with extensions
- pg_dump support for the above
- dependency management
- psql tab completion
- psql \dO command
Robert Haas [Sat, 12 Feb 2011 13:27:55 +0000 (08:27 -0500)]
Teach ALTER TABLE .. SET DATA TYPE to avoid some table rewrites.
When the old type is binary coercible to the new type and the using
clause does not change the column contents, we can avoid a full table
rewrite, though any indexes on the affected columns will still need
to be rebuilt. This applies, for example, when changing a varchar
column to be of type text.
The prior coding assumed that the set of operations that force a
rewrite is identical to the set of operations that must be propagated
to tables making use of the affected table's rowtype. This is
no longer true: even though the tuples in those tables wouldn't
need to be modified, the data type change invalidate indexes built
using those composite type columns. Indexes on the table we're
actually modifying can be invalidated too, of course, but the
existing machinery is sufficient to handle that case.
Along the way, add some debugging messages that make it possible
to understand what operations ALTER TABLE is actually performing
in these cases.
Noah Misch and Robert Haas
Tom Lane [Sat, 12 Feb 2011 03:53:43 +0000 (22:53 -0500)]
Clean up installation directory choices for extensions.
Arrange for the control files to be in $SHAREDIR/extension not
$SHAREDIR/contrib, since we're generally trying to deprecate the term
"contrib" and this is a once-in-many-moons opportunity to get rid of it in
install paths. Fix PGXS to install the $EXTENSION file into that directory
no matter what MODULEDIR is set to; a nondefault MODULEDIR should only
affect the script and secondary extension files. Fix the control file
directory parameter to be interpreted relative to $SHAREDIR, to avoid a
surprising disconnect between how you specify that and what you set
MODULEDIR to.
Per discussion with David Wheeler.
Tom Lane [Sat, 12 Feb 2011 02:25:20 +0000 (21:25 -0500)]
Add support for multiple versions of an extension and ALTER EXTENSION UPDATE.
This follows recent discussions, so it's quite a bit different from
Dimitri's original. There will probably be more changes once we get a bit
of experience with it, but let's get it in and start playing with it.
This is still just core code. I'll start converting contrib modules
shortly.
Dimitri Fontaine and Tom Lane
Alvaro Herrera [Fri, 11 Feb 2011 22:42:15 +0000 (19:42 -0300)]
Fix comment recently obsoleted
Robert Haas [Fri, 11 Feb 2011 21:57:58 +0000 (16:57 -0500)]
Allow tab-completion of :variable even as first word on a line.
Christoph Berg
Robert Haas [Fri, 11 Feb 2011 16:55:12 +0000 (11:55 -0500)]
Typo fixes. receivedUpto should be capitalized consistently.
Robert Haas [Fri, 11 Feb 2011 13:47:38 +0000 (08:47 -0500)]
Tweak find_composite_type_dependencies API a bit more.
Per discussion with Noah Misch, the previous coding, introduced by
my commit
65377e0b9c0e0397b1598b38b6a7fb8b6f740d39 on 2011-02-06,
was really an abuse of RELKIND_COMPOSITE_TYPE, since the caller in
typecmds.c is actually passing the name of a domain. So go back
having a type name argument, but make the first argument a Relation
rather than just a string so we can tell whether it's a table or
a foreign table and emit the proper error message.
Alvaro Herrera [Thu, 10 Feb 2011 22:47:57 +0000 (19:47 -0300)]
Fix isolation tester Makefile so that it runs in a VPATH build
Tom Lane [Thu, 10 Feb 2011 22:36:44 +0000 (17:36 -0500)]
Extend "ALTER EXTENSION ADD object" to permit "DROP object" as well.
Per discussion, this is something we should have sooner rather than later,
and it doesn't take much additional code to support it.
Alvaro Herrera [Thu, 10 Feb 2011 22:30:57 +0000 (19:30 -0300)]
Fix the isolation tester compilation on VPATH builds
Bruce Momjian [Thu, 10 Feb 2011 21:57:25 +0000 (16:57 -0500)]
Fix "variable not used" warnings when USE_WIDE_UPPER_LOWER is not
defined.
Peter Eisentraut [Thu, 10 Feb 2011 20:49:46 +0000 (22:49 +0200)]
Update comment
It was still claiming that the keyword list is in keywords.c, when it
is now in kwlist.h.
Bruce Momjian [Thu, 10 Feb 2011 20:39:41 +0000 (15:39 -0500)]
Fix pg_get_encoding_from_locale() function call parameters to match
prototype for cases where there is no multi-language support.
Heikki Linnakangas [Thu, 10 Feb 2011 19:00:29 +0000 (21:00 +0200)]
Send status updates back from standby server to master, indicating how far
the standby has written, flushed, and applied the WAL. At the moment, this
is for informational purposes only, the values are only shown in
pg_stat_replication system view, but in the future they will also be needed
for synchronous replication.
Extracted from Simon riggs' synchronous replication patch by Robert Haas, with
some tweaking by me.
Magnus Hagander [Thu, 10 Feb 2011 14:09:35 +0000 (15:09 +0100)]
Track last time for statistics reset on databases and bgwriter
Tracks one counter for each database, which is reset whenever
the statistics for any individual object inside the database is
reset, and one counter for the background writer.
Tomas Vondra, reviewed by Greg Smith
Magnus Hagander [Thu, 10 Feb 2011 11:10:13 +0000 (12:10 +0100)]
Use NOWAIT when including WAL in base backup
Avoids warning and waiting for the last segment to be
archived, which isn't necessary when we're including the
required WAL in the backup itself.
Heikki Linnakangas [Thu, 10 Feb 2011 10:00:53 +0000 (12:00 +0200)]
Allocate all entries in the serializable xid hash up-front, so that you don't
run out of shared memory when you try to assign an xid to a transaction.
Kevin Grittner
Andrew Dunstan [Thu, 10 Feb 2011 09:47:32 +0000 (04:47 -0500)]
Use correct name and URL for MinGW-w64, error noticed by Gurjeet Singh.
Tom Lane [Thu, 10 Feb 2011 04:27:07 +0000 (23:27 -0500)]
Fix improper matching of resjunk column names for FOR UPDATE in subselect.
Flattening of subquery range tables during setrefs.c could lead to the
rangetable indexes in PlanRowMark nodes not matching up with the column
names previously assigned to the corresponding resjunk ctid (resp. tableoid
or wholerow) columns. Typical symptom would be either a "cannot extract
system attribute from virtual tuple" error or an Assert failure. This
wasn't a problem before 9.0 because we didn't support FOR UPDATE below the
top query level, and so the final flattening could never renumber an RTE
that was relevant to FOR UPDATE. Fix by using a plan-tree-wide unique
number for each PlanRowMark to label the associated resjunk columns, so
that the number need not change during flattening.
Per report from David Johnston (though I'm darned if I can see how this got
past initial testing of the relevant code). Back-patch to 9.0.
Itagaki Takahiro [Thu, 10 Feb 2011 01:58:18 +0000 (10:58 +0900)]
Fix typo in the documentation.
by Kevin Grittner
Tom Lane [Thu, 10 Feb 2011 00:17:33 +0000 (19:17 -0500)]
Fix pg_upgrade to handle extensions.
This follows my proposal of yesterday, namely that we try to recreate the
previous state of the extension exactly, instead of allowing CREATE
EXTENSION to run a SQL script that might create some entirely-incompatible
on-disk state. In --binary-upgrade mode, pg_dump won't issue CREATE
EXTENSION at all, but instead uses a kluge function provided by
pg_upgrade_support to recreate the pg_extension row (and extension-level
pg_depend entries) without creating any member objects. The member objects
are then restored in the same way as if they weren't members, in particular
using pg_upgrade's normal hacks to preserve OIDs that need to be preserved.
Then, for each member object, ALTER EXTENSION ADD is issued to recreate the
pg_depend entry that marks it as an extension member.
In passing, fix breakage in pg_upgrade's enum-type support: somebody didn't
fix it when the noise word VALUE got added to ALTER TYPE ADD. Also,
rationalize parsetree representation of COMMENT ON DOMAIN and fix
get_object_address() to allow OBJECT_DOMAIN.
Peter Eisentraut [Wed, 9 Feb 2011 21:26:48 +0000 (23:26 +0200)]
Information schema views for collation support
Add the views character_sets, collations, and
collation_character_set_applicability.
Tom Lane [Wed, 9 Feb 2011 19:05:34 +0000 (14:05 -0500)]
Rethink order of operations for dumping extension member objects.
My original idea of doing extension member identification during
getDependencies() didn't work correctly: we have to mark member tables as
not-to-be-dumped rather earlier than that, else their subsidiary objects
like indexes get dumped anyway. Rearrange code to mark them early enough.
Tom Lane [Wed, 9 Feb 2011 16:55:32 +0000 (11:55 -0500)]
Implement "ALTER EXTENSION ADD object".
This is an essential component of making the extension feature usable;
first because it's needed in the process of converting an existing
installation containing "loose" objects of an old contrib module into
the extension-based world, and second because we'll have to use it
in pg_dump --binary-upgrade, as per recent discussion.
Loosely based on part of Dimitri Fontaine's ALTER EXTENSION UPGRADE
patch.
Bruce Momjian [Wed, 9 Feb 2011 13:16:49 +0000 (08:16 -0500)]
Remove more SGML tabs.
Bruce Momjian [Wed, 9 Feb 2011 13:15:38 +0000 (08:15 -0500)]
Remove tabs in SGML file.
Heikki Linnakangas [Wed, 9 Feb 2011 10:15:08 +0000 (12:15 +0200)]
Fix allocation of RW-conflict pool in the new predicate lock manager, and
also take the RW-conflict pool into account in the PredicateLockShmemSize()
estimate.
Magnus Hagander [Wed, 9 Feb 2011 09:59:53 +0000 (10:59 +0100)]
Implement NOWAIT option for BASE_BACKUP command
Specifying this option makes the server not wait for the
xlog to be archived, or emit a warning that it can't,
instead leaving the responsibility with the client.
This is useful when the log is being streamed using
the streaming protocol in parallel with the backup,
without having log archiving enabled.
Tom Lane [Tue, 8 Feb 2011 23:12:17 +0000 (18:12 -0500)]
Suppress some compiler warnings in recent commits.
Older versions of gcc tend to throw "variable might be clobbered by
`longjmp' or `vfork'" warnings whenever a variable is assigned in more than
one place and then used after the end of a PG_TRY block. That's reasonably
easy to work around in execute_extension_script, and the overhead of
unconditionally saving/restoring the GUC variables seems unlikely to be a
serious concern.
Also clean up logic in ATExecValidateConstraint to make it easier to read
and less likely to provoke "variable might be used uninitialized in this
function" warnings.
Tom Lane [Tue, 8 Feb 2011 21:22:20 +0000 (16:22 -0500)]
Fix merge conflict.
Tom Lane [Tue, 8 Feb 2011 21:08:41 +0000 (16:08 -0500)]
Core support for "extensions", which are packages of SQL objects.
This patch adds the server infrastructure to support extensions.
There is still one significant loose end, namely how to make it play nice
with pg_upgrade, so I am not yet committing the changes that would make
all the contrib modules depend on this feature.
In passing, fix a disturbingly large amount of breakage in
AlterObjectNamespace() and callers.
Dimitri Fontaine, reviewed by Anssi Kääriäinen,
Itagaki Takahiro, Tom Lane, and numerous others
Peter Eisentraut [Tue, 8 Feb 2011 21:04:18 +0000 (23:04 +0200)]
Per-column collation support
This adds collation support for columns and domains, a COLLATE clause
to override it per expression, and B-tree index support.
Peter Eisentraut
reviewed by Pavel Stehule, Itagaki Takahiro, Robert Haas, Noah Misch
Heikki Linnakangas [Tue, 8 Feb 2011 19:47:38 +0000 (21:47 +0200)]
Fix typo, by Kevin Grittner.
Simon Riggs [Tue, 8 Feb 2011 19:44:50 +0000 (19:44 +0000)]
Continue long tradition of bumping the catalog version a little late.
Simon Riggs [Tue, 8 Feb 2011 19:39:08 +0000 (19:39 +0000)]
Named restore points in recovery. Users can record named points, then
new recovery.conf parameter recovery_target_name allows PITR to
specify named points as recovery targets.
Jaime Casanova, reviewed by Euler Taveira de Oliveira, plus minor edits
Simon Riggs [Tue, 8 Feb 2011 18:30:22 +0000 (18:30 +0000)]
Basic Recovery Control functions for use in Hot Standby. Pause, Resume,
Status check functions only. Also, new recovery.conf parameter to
pause_at_recovery_target, default on.
Simon Riggs, reviewed by Fujii Masao
Heikki Linnakangas [Tue, 8 Feb 2011 16:14:26 +0000 (18:14 +0200)]
UINT64_MAX isn't defined on MSVC.
Simon Riggs [Tue, 8 Feb 2011 14:38:02 +0000 (14:38 +0000)]
Remove rare corner case for data loss when triggering standby server.
If the standby was streaming when trigger file arrives, check also in the
archive for additional WAL files. This is a corner case since it is
unlikely that we would trigger a failover while the master is still
available and sending data to standby, while at the same time running in
archive mode and also while the streaming standby has fallen behind archive.
Someone would eventually be unlucky; we must plug all gaps however small.
Fujii Masao
Simon Riggs [Tue, 8 Feb 2011 12:23:20 +0000 (12:23 +0000)]
Extend ALTER TABLE to allow Foreign Keys to be added without initial validation.
FK constraints that are marked NOT VALID may later be VALIDATED, which uses an
ShareUpdateExclusiveLock on constraint table and RowShareLock on referenced
table. Significantly reduces lock strength and duration when adding FKs.
New state visible from psql.
Simon Riggs, with reviews from Marko Tiikkaja and Robert Haas
Heikki Linnakangas [Tue, 8 Feb 2011 07:03:08 +0000 (09:03 +0200)]
Fix copy-pasto in description of pg_serial, and silence compiler warning
about uninitialized field you get on some compilers.
Robert Haas [Tue, 8 Feb 2011 03:04:29 +0000 (22:04 -0500)]
Avoid having autovacuum workers wait for relation locks.
Waiting for relation locks can lead to starvation - it pins down an
autovacuum worker for as long as the lock is held. But if we're doing
an anti-wraparound vacuum, then we still wait; maintenance can no longer
be put off.
To assist with troubleshooting, if log_autovacuum_min_duration >= 0,
we log whenever an autovacuum or autoanalyze is skipped for this reason.
Per a gripe by Josh Berkus, and ensuing discussion.
Heikki Linnakangas [Mon, 7 Feb 2011 22:24:23 +0000 (00:24 +0200)]
Oops, forgot to bump catversion in the Serializable Snapshot Isolation patch.
I thought we didn't need that, but then I remembered that it added a new
SLRU subdirectory, pg_serial. While we're at it, document what pg_serial is.
Heikki Linnakangas [Mon, 7 Feb 2011 21:46:51 +0000 (23:46 +0200)]
Implement genuine serializable isolation level.
Until now, our Serializable mode has in fact been what's called Snapshot
Isolation, which allows some anomalies that could not occur in any
serialized ordering of the transactions. This patch fixes that using a
method called Serializable Snapshot Isolation, based on research papers by
Michael J. Cahill (see README-SSI for full references). In Serializable
Snapshot Isolation, transactions run like they do in Snapshot Isolation,
but a predicate lock manager observes the reads and writes performed and
aborts transactions if it detects that an anomaly might occur. This method
produces some false positives, ie. it sometimes aborts transactions even
though there is no anomaly.
To track reads we implement predicate locking, see storage/lmgr/predicate.c.
Whenever a tuple is read, a predicate lock is acquired on the tuple. Shared
memory is finite, so when a transaction takes many tuple-level locks on a
page, the locks are promoted to a single page-level lock, and further to a
single relation level lock if necessary. To lock key values with no matching
tuple, a sequential scan always takes a relation-level lock, and an index
scan acquires a page-level lock that covers the search key, whether or not
there are any matching keys at the moment.
A predicate lock doesn't conflict with any regular locks or with another
predicate locks in the normal sense. They're only used by the predicate lock
manager to detect the danger of anomalies. Only serializable transactions
participate in predicate locking, so there should be no extra overhead for
for other transactions.
Predicate locks can't be released at commit, but must be remembered until
all the transactions that overlapped with it have completed. That means that
we need to remember an unbounded amount of predicate locks, so we apply a
lossy but conservative method of tracking locks for committed transactions.
If we run short of shared memory, we overflow to a new "pg_serial" SLRU
pool.
We don't currently allow Serializable transactions in Hot Standby mode.
That would be hard, because even read-only transactions can cause anomalies
that wouldn't otherwise occur.
Serializable isolation mode now means the new fully serializable level.
Repeatable Read gives you the old Snapshot Isolation level that we have
always had.
Kevin Grittner and Dan Ports, reviewed by Jeff Davis, Heikki Linnakangas and
Anssi Kääriäinen
Itagaki Takahiro [Mon, 7 Feb 2011 07:51:39 +0000 (16:51 +0900)]
Fix a comment for MergeAttributes.
We forgot to adjust it when we changed relistemp to relpersistence.
Andrew Dunstan [Mon, 7 Feb 2011 02:36:56 +0000 (21:36 -0500)]
Supply now required HeUTF8 macro for plperl where it's missing, per buildfarm results.
Itagaki Takahiro [Mon, 7 Feb 2011 01:46:56 +0000 (10:46 +0900)]
Fix error messages for FreeFile in COPY command.
They are extracted from COPY API patch.
suggested by Noah Misch
Bruce Momjian [Sun, 6 Feb 2011 23:32:27 +0000 (18:32 -0500)]
remove tags.
Andrew Dunstan [Sun, 6 Feb 2011 22:29:26 +0000 (17:29 -0500)]
Force strings passed to and from plperl to be in UTF8 encoding.
String are converted to UTF8 on the way into perl and to the
database encoding on the way back. This avoids a number of
observed anomalies, and ensures Perl a consistent view of the
world.
Some minor code cleanups are also accomplished.
Alex Hunsaker, reviewed by Andy Colson.
Bruce Momjian [Sun, 6 Feb 2011 17:04:42 +0000 (12:04 -0500)]
Adjust libpq docs to be clearer about 'hostaddr' usage by rewording and
using an itemized list.
Bruce Momjian [Sun, 6 Feb 2011 15:46:15 +0000 (10:46 -0500)]
Rename macro DECIMAL to DECIMAL_T to help pgindent; this is already
done for a few other macros in that file, for other reasons. I also
remove pgindent/README mention of the file.
Magnus Hagander [Sun, 6 Feb 2011 06:46:14 +0000 (07:46 +0100)]
IDENTIFY_SYSTEM now returns 3 fields, not 2
Robert Haas [Sun, 6 Feb 2011 05:26:27 +0000 (00:26 -0500)]
Tighten ALTER FOREIGN TABLE .. SET DATA TYPE checks.
If the foreign table's rowtype is being used as the type of a column in
another table, we can't just up and change its data type. This was
already checked for composite types and ordinary tables, but we
previously failed to enforce it for foreign tables.
Bruce Momjian [Sat, 5 Feb 2011 04:27:45 +0000 (23:27 -0500)]
Add C comment about why older compilers complain about basebackup.c's
longjump.
Andrew Dunstan [Sat, 5 Feb 2011 01:49:39 +0000 (20:49 -0500)]
Attempt to unbreak MSVC builds after pipe.c move.