OSDN Git Service

android-x86/frameworks-native.git
6 years agoValidate the size of all dex paths eagerly
Calin Juravle [Thu, 6 Jul 2017 23:29:11 +0000 (16:29 -0700)]
Validate the size of all dex paths eagerly

Also, increase the PKG_PATH_MAX which is used as the max path length to
1024. This should accommodate reasonably long dex path (to cover for
longer secondary dex files paths).

If a dex path  exceeds 1024 characters the dex file will not be compiled.

Bug: 63285397
Test: manual
1) create an artifical long paths under gmscore:
2) update /data/system/package-dex-usage.list to simulate the use of those
dex file
3) run `adb shell cmd package compile -r bg-dexopt --secondary-dex
com.google.android.gms`
4) observe that a 256+ characters dex path is ok while a 1024+ long one
fails.
5) run `adb shell cmd package reconcile-secondary-dex-files
com.google.android.gms` and check no errors are present.

Change-Id: I23b34013e32c5c64ca9c1381cc4d8d67e7121cc8

6 years agoFix BufferHub state machine to return errors on invalid transitions.
Corey Tabaka [Fri, 7 Jul 2017 01:04:27 +0000 (18:04 -0700)]
Fix BufferHub state machine to return errors on invalid transitions.

The consumer side of the BufferHub flow did not have an adequate
state machine to track transitions and return errors when Acquire
or Release are requested from the wrong state. This bug allowed
other buggy usage to go unnoticed.

- Fix the consumer state machine to correctly validate all requests.
- Add tests to verify correctness of the fix.

Tested BufferHub with the new test before and after the fix and
verified that the test catches the problem and that the fix solves
the problem.

Bug: 62886596
Bug: 63149525
Test: bufferhub_tests passes.
Change-Id: I802679ed74c7f505b9243ba4048824350d4e37be

6 years agoRestore PDX support to atrace.
Corey Tabaka [Fri, 7 Jul 2017 00:34:22 +0000 (00:34 +0000)]
Restore PDX support to atrace.
am: a6c0a721bd

Change-Id: I39bd28bde2cad630c8891727670724df3c234ab6

6 years agoRestore PDX support to atrace.
Corey Tabaka [Wed, 31 May 2017 23:37:40 +0000 (16:37 -0700)]
Restore PDX support to atrace.

Restore PDX service tracing in atrace. This time only enable poking PDX services
when the "pdx" trace category is included.

Bug: 62882199
Test: Run systrace with/without pdx category and observe correct poke behavior.

Change-Id: I478332a661c3b8bc6061fda43f64b75d8113b305

6 years agoFix concurrent access bug in VrFlinger.
Corey Tabaka [Thu, 6 Jul 2017 22:39:49 +0000 (15:39 -0700)]
Fix concurrent access bug in VrFlinger.

VR surface queues have erroneous concurrent access from two threads
because of misplaced lock guards. Move the locking to cover the
queue accesses.

Bug: 62886596
Bug: 63149525
Test: Extensive logging shows that buffers are accessed in the
 correct order and that the consistency of the queues is now
 maintained.

Change-Id: I649e3d75a2230cf3aff50886df9958917d3aa4bf

6 years agoClear callbacks when destroying DvrHwcClient
Pat Plunkett [Thu, 29 Jun 2017 22:40:41 +0000 (15:40 -0700)]
Clear callbacks when destroying DvrHwcClient

When a DvrHwcClient is destroyed, the VrComposer retains a reference to its
observer. Because registerObserver returns a non-OK status if an observer
is already registered, this was causing subsequent DvrHwcClients to not be
created.

This was an issue with the CompatibilityUiOverlay app on standalone
headsets. CompatibilityUiOverlay was destroying its DvrHwcClient when turning
the screen off, but upon turning the screen back on, CompatibilityUiOverlay
was unable to create another DvrHwcClient.

Bug: 63139142
Test: Turn the screen off/on for a standalone headset, observe
CompatibilityUiOverlay running.

Change-Id: Ie45e961d2bf977ab9a661e23c558354d3a96ae20

7 years agodvrReadBufferQueueDequeue: allow empty metadata
Jiwen 'Steve' Cai [Sat, 1 Jul 2017 00:04:28 +0000 (17:04 -0700)]
dvrReadBufferQueueDequeue: allow empty metadata

Currently, when there is no metadata on the read buffer queue, we have
to pass in dummy out_metadata; otherwise the API always return
-EINVAL. This CL allows (nullptr, 0) as legit input and add test to
cover that.

Bug: 62958474
Test: Ran the updated DvrBufferQueueTest
Change-Id: I0ad666006a5d93b67a48b9c34f27e325dfa9a419

7 years agosurfaceflinger: refresh after latching any buffer
Chia-I Wu [Fri, 30 Jun 2017 23:24:33 +0000 (23:24 +0000)]
surfaceflinger: refresh after latching any buffer
am: a36bf92663

Change-Id: If437e00a4c8aeda42f26150066a4fd7baaad485e

7 years agosurfaceflinger: refresh after latching any buffer
Chia-I Wu [Fri, 30 Jun 2017 19:51:05 +0000 (12:51 -0700)]
surfaceflinger: refresh after latching any buffer

We should not skip refresh when a latched buffer happens to have an
empty dirty region.  Also, we should signal a layer update when we
skip refresh.

Bug: 62752640
Test: manual
Change-Id: Ia603e7eeb37491c6ece7ea08d5d1e3b7ba93e6fa

7 years agoMake default permission checks in performance service more restrictive.
Corey Tabaka [Fri, 30 Jun 2017 18:27:57 +0000 (11:27 -0700)]
Make default permission checks in performance service more restrictive.

- Check sending process in unrestricted policies.
- Allow IsTrustedUid() to cache results for better runtime efficiency.
- Update tests to verify unrestricted policy behavior.

Bug: 62468109
Test: performance_service_tests passes.
Change-Id: I0614879c8bde35ffeda2f673a3da68092433dc1a

7 years agoMerge "Fix potential access to invalid memory during shutdown" into oc-dr1-dev
Daniel Nicoara [Fri, 30 Jun 2017 15:46:07 +0000 (15:46 +0000)]
Merge "Fix potential access to invalid memory during shutdown" into oc-dr1-dev
am: 77e9eeba69

Change-Id: I5b5703ab3b70755d3f8b8e2674c7c32ce0e1c05b

7 years agoMerge "Fix potential access to invalid memory during shutdown" into oc-dr1-dev
TreeHugger Robot [Fri, 30 Jun 2017 15:36:48 +0000 (15:36 +0000)]
Merge "Fix potential access to invalid memory during shutdown" into oc-dr1-dev

7 years agoMerge "Add dvr api entries for sensor enable/disable" into oc-dr1-dev
Luke Song [Fri, 30 Jun 2017 02:20:48 +0000 (02:20 +0000)]
Merge "Add dvr api entries for sensor enable/disable" into oc-dr1-dev
am: 0a9bae53bc

Change-Id: I8ad0fedbac9cf950bf6917a524cb50839b41a362

7 years agoMerge "Add dvr api entries for sensor enable/disable" into oc-dr1-dev
Luke Song [Fri, 30 Jun 2017 02:14:54 +0000 (02:14 +0000)]
Merge "Add dvr api entries for sensor enable/disable" into oc-dr1-dev

7 years agoMerge "Trust navbar panel and accessibility overlays" into oc-dr1-dev
Phil Weaver [Fri, 30 Jun 2017 02:04:48 +0000 (02:04 +0000)]
Merge "Trust navbar panel and accessibility overlays" into oc-dr1-dev
am: b5f0e91c4c

Change-Id: Ia00e2b0cbaba95b3265171bbe1e13cb86813c511

7 years agoMerge "Trust navbar panel and accessibility overlays" into oc-dr1-dev
Phil Weaver [Fri, 30 Jun 2017 01:57:31 +0000 (01:57 +0000)]
Merge "Trust navbar panel and accessibility overlays" into oc-dr1-dev

7 years agoInclude tracking state bits to DvrPose.
Okan Arikan [Mon, 26 Jun 2017 17:57:24 +0000 (10:57 -0700)]
Include tracking state bits to DvrPose.

These will be used internally for debugging so VrCore
has an idea about what's going on with Tango.

Bug: 62917278
Test: No functional change.
Change-Id: I7f5f7a2ccad4f0259ee5219726bf0e6890f34187

7 years agoAdd dvr api entries for sensor enable/disable
Luke Song [Tue, 27 Jun 2017 21:03:45 +0000 (14:03 -0700)]
Add dvr api entries for sensor enable/disable

Follow-up to ag/2263549 because we want to use it in VrCore now.

Bug: 63070540
Test: Api call in VrCore
Change-Id: Ic3b2c68ade31008ada8078a74ebe2945748143ae

7 years agoFix potential access to invalid memory during shutdown
Daniel Nicoara [Fri, 23 Jun 2017 16:48:01 +0000 (12:48 -0400)]
Fix potential access to invalid memory during shutdown

Since binder threads have a reference to the callback, need to make sure
it is properly reset before deleting the DvrHwcClient object.

Bug: 63139142
Test: Ran on device to ensure VrCore restart don't result in crashes in
DvrHwcClient
Change-Id: I559844a70d4483fee3148526f704d234994a96d4

7 years agoMerge changes Id4647e54,I66b6edbd into oc-dr1-dev
Corey Tabaka [Thu, 29 Jun 2017 18:50:09 +0000 (18:50 +0000)]
Merge changes Id4647e54,I66b6edbd into oc-dr1-dev
am: bf72631a10

Change-Id: Ib1f5d7cc4841124c4f5fc1ea543ce3984dc26d16

7 years agoMerge changes I9047b298,Id9554d6b into oc-dr1-dev
Corey Tabaka [Thu, 29 Jun 2017 18:49:52 +0000 (18:49 +0000)]
Merge changes I9047b298,Id9554d6b into oc-dr1-dev
am: e6ffd49479

Change-Id: I8ac6a10b071dd5293dda9347d590b92c9cea0124

7 years agoMerge changes Id4647e54,I66b6edbd into oc-dr1-dev
TreeHugger Robot [Thu, 29 Jun 2017 18:44:52 +0000 (18:44 +0000)]
Merge changes Id4647e54,I66b6edbd into oc-dr1-dev

* changes:
  Fix VR surface attributes.
  DVR API: Implement support for deleting surface attributes.

7 years agoMerge changes I9047b298,Id9554d6b into oc-dr1-dev
TreeHugger Robot [Thu, 29 Jun 2017 18:44:35 +0000 (18:44 +0000)]
Merge changes I9047b298,Id9554d6b into oc-dr1-dev

* changes:
  libdvr: Add performance API to platform library.
  libpdx_uds: Fix uninitialized variable bug.

7 years agoMerge "Add VrFlinger dumpsys to SurfaceFlinger" into oc-dr1-dev
Karthik Ravi Shankar [Thu, 29 Jun 2017 04:28:27 +0000 (04:28 +0000)]
Merge "Add VrFlinger dumpsys to SurfaceFlinger" into oc-dr1-dev
am: ae11e71bb7

Change-Id: Ic3ac3d8b16a14aed3fb3553616c4adec23044f7a

7 years agoMerge "Add VrFlinger dumpsys to SurfaceFlinger" into oc-dr1-dev
TreeHugger Robot [Thu, 29 Jun 2017 04:21:05 +0000 (04:21 +0000)]
Merge "Add VrFlinger dumpsys to SurfaceFlinger" into oc-dr1-dev

7 years agoFix VR surface attributes.
Corey Tabaka [Fri, 23 Jun 2017 03:39:42 +0000 (20:39 -0700)]
Fix VR surface attributes.

VR surface attributes had two issues that prevented the full extent
of their use:
1. The older clang version missed that templated copy constructor
   and assignment operators do not override the default ones in
   the Variant class. This caused issues with certain types when
   copy constructing / assigning from another Variant of the same
   type. This was noticed by running tests with a newer version of
   clang which provided warnings.
2. C++ rules about implicit conversion to bool from types that
   decay to pointers causes subtle issues with Variants that have
   bool elements.

   For example this assignment compiles but produces the wrong
   result:

   const int array[3] = { 1, 2, 3};
   Variant<int, bool, std::array<int, 3>> variant = array;
   EXPECT_FALSE(variant.is<bool>()); // Actually true.

   Here the programmer might accidentally think that the std::array
   element of the variant can be assigned from the regular array.
   This doesn't work, but instead the compiler decays the array to
   a pointer and assigns the bool element to true.

The first issue is addressed by defining copy/move constructors /
assignment operators on Variant and deleting the default ones from
the internal Union type for extra safety.

The second issue is addressed by making a more restrictive version
of the std::is_constructible trait that rejects bool construction
from types that decay to pointers. Once this was put in place the
erroneous use cases no longer compiled and is fixed as part of
this CL.

Tests are updated to verify the fixes to these issues.

Bug: 62557221
Test: pdx_tests and dvr_api-test passes.
Change-Id: Id4647e54e0a7b1753217fe7fe351462fe5bcfd83

7 years agolibdvr: Add performance API to platform library.
Corey Tabaka [Fri, 23 Jun 2017 23:20:07 +0000 (16:20 -0700)]
libdvr: Add performance API to platform library.

- Add dvrPerformanceSetSchedulerPolicy API. Only this API is exposed
  through the DVR platform library, the older API will be deprecated.
- Add permission checks to all performanced APIs.
- Allow services with android.permission.RESTRICTED_VR_ACCESS to change
  scheduler policy for VR apps.
- Minor updates to use the updated PDX service API. The older API will
  be deprecated soon.
- Add tests for permission checks and policy API.

Most of the tests are automatic however, there is one manual step for
testing the android.permission.RESTRICTED_VR_ACCESS (e.g. trusted uid)
check. Because there is no reliable way to determine the UID of VrCore
from the gtest, instead the gtest looks for an env var named
GTEST_TRUSTED_UID; if this is set the value is used as a uid and the
trusted uid tests are enabled.

Bug: 62468109
Test: 'GTEST_TRUSTED_UID=<VrCore UID> performance_service_tests' passes.
Change-Id: I9047b298a015a69535b655a299ca26c179e2d57d

7 years agoDVR API: Implement support for deleting surface attributes.
Corey Tabaka [Thu, 8 Jun 2017 21:29:58 +0000 (14:29 -0700)]
DVR API: Implement support for deleting surface attributes.

- Implement support for deleting surface attributes using the "NONE"
  attribute type.
- Add tests for attribute events and attribute deletion.

Bug: 62456002
Test: dvr_api-test passes.
Change-Id: I66b6edbd35077596d89e85829bcbe7c52829ef5b

7 years agoAdd VrFlinger dumpsys to SurfaceFlinger
Karthik Ravi Shankar [Wed, 28 Jun 2017 22:40:24 +0000 (15:40 -0700)]
Add VrFlinger dumpsys to SurfaceFlinger

When we do dumpsys SurfaceFlinger, we get no information about the
layers/what is composed when the device is in VR mode.

Bug: 63113212
Test:
VrFlinger state:
Application Surfaces:
Surface 0: surface_id=11 process_id=5550 user_id=10104 visible=1
z_order=0 queue_ids=29,37
Surface 1: surface_id=13 process_id=5035 user_id=10130 visible=1
z_order=0 queue_ids=53,65

Direct Surfaces:
Surface 0: surface_id=8 process_id=5563 user_id=10104 visible=1
z_order=0 queue_ids=17

Display metrics:     1440x2880 537.882x537.882 dpi @ 60 Hz
Post thread resumed: 1
Active layers:       1

Layer 0: type=Device surface_id=8 buffer_id=19

Hardware Composer Debug Info:
-------------------------------
HWC2 display_id: 0
layer:   30 z: 0 compositon: Device/Device alpha: 255 format:
RGBA_8888_UBWC dataspace:0x00000000 transform: 0/0/0 buffer_id:
0x70b4877500
color modes supported: 0 7 9 current mode: 7
current transform:
  1.08  -0.02  -0.02   0.00
  -0.07   1.03  -0.07   0.00
  -0.01  -0.01   1.09   0.00
  0.00   0.00   0.00   1.00
-------------------------------

This section doesn't appear when the device is not in VR mode.

Change-Id: I2961a05fc3ea303e070be08de355fb6e56c3d0db
Signed-off-by: Karthik Ravi Shankar <karthikrs@google.com>
7 years agoMerge "Add telephony related dumpsys in the telephony monitor bugreports" into oc...
Jayachandran C [Wed, 28 Jun 2017 19:11:19 +0000 (19:11 +0000)]
Merge "Add telephony related dumpsys in the telephony monitor bugreports" into oc-dr1-dev
am: d16d297825

Change-Id: Id02616a3d6084a18bdf6a3b87868eb1e1f905a9a

7 years agoMerge "Add telephony related dumpsys in the telephony monitor bugreports" into oc...
TreeHugger Robot [Wed, 28 Jun 2017 19:01:17 +0000 (19:01 +0000)]
Merge "Add telephony related dumpsys in the telephony monitor bugreports" into oc-dr1-dev

7 years agolibpdx_uds: Fix uninitialized variable bug.
Corey Tabaka [Mon, 26 Jun 2017 23:51:43 +0000 (16:51 -0700)]
libpdx_uds: Fix uninitialized variable bug.

In this code path epoll_wait() returns 0 when the operation times
out, but there is no condition to catch this and return the
approptiate status. This allows the event value to be used
uninitialized, which returns a junk pending event mask.

This bug results in BufferHub queues sometimes thinking that the
producer side of the buffer hung up, when the junk value happens
to have the EPOLLHUP bit set.

Bug: 62886596
Test: Observe VR app switching stability.
Change-Id: Id9554d6bf224fd27815ff042ac145f59041d0aae

7 years agoAdd telephony related dumpsys in the telephony monitor bugreports
Jayachandran C [Sat, 10 Jun 2017 22:08:12 +0000 (15:08 -0700)]
Add telephony related dumpsys in the telephony monitor bugreports

Collect dumpsys for the following in telephony monitor auto
generated bugreports for better debugging

1) TelephonyDebugService
2) CarrierConfig
3) Connectivity

Test: Verified telephony monintor auto generated bugreport

Bug: 62504502
Change-Id: Ia2a9e1ff5b289dec7a4d0bb4e8ef85fb413df87a

7 years agoMerge "Merge "SurfaceFlinger: Last minute log removal." into oc-dev am: 56cca289cc...
Android Build Merger (Role) [Wed, 28 Jun 2017 00:09:20 +0000 (00:09 +0000)]
Merge "Merge "SurfaceFlinger: Last minute log removal." into oc-dev am: 56cca289cc am: d5547979ec" into oc-dr1-dev-plus-aosp

7 years agoMerge "SurfaceFlinger: Last minute log removal." into oc-dev am: 56cca289cc
Robert Carr [Wed, 28 Jun 2017 00:09:08 +0000 (00:09 +0000)]
Merge "SurfaceFlinger: Last minute log removal." into oc-dev am: 56cca289cc
am: a75a975dc8

Change-Id: I1b4544d48d3248edc5621af1218b38a3ad0d9cae

7 years agoMerge "SurfaceFlinger: Last minute log removal." into oc-dev am: 56cca289cc
Robert Carr [Wed, 28 Jun 2017 00:09:08 +0000 (00:09 +0000)]
Merge "SurfaceFlinger: Last minute log removal." into oc-dev am: 56cca289cc
am: d5547979ec

Change-Id: I1a6c13f9fd00d082425b374e440e5d8482260b73

7 years agoMerge "SurfaceFlinger: Last minute log removal." into oc-dev
Robert Carr [Wed, 28 Jun 2017 00:06:38 +0000 (00:06 +0000)]
Merge "SurfaceFlinger: Last minute log removal." into oc-dev
am: 56cca289cc

Change-Id: Ib4448b62b985fac82c24fb81aef550ba7d0280a9

7 years agoMerge "SurfaceFlinger: Last minute log removal." into oc-dev
Robert Carr [Wed, 28 Jun 2017 00:06:37 +0000 (00:06 +0000)]
Merge "SurfaceFlinger: Last minute log removal." into oc-dev
am: 56cca289cc

Change-Id: I07e2b1c1efd0cc8eec73467fdd4ef88bf36f081c

7 years agoMerge "SurfaceFlinger: Last minute log removal." into oc-dev
TreeHugger Robot [Tue, 27 Jun 2017 23:59:16 +0000 (23:59 +0000)]
Merge "SurfaceFlinger: Last minute log removal." into oc-dev

7 years agoMerge "libgui: New mutex for ConsumerBase frame callbacks" into oc-dev am: fb672ba37b
Dan Stoza [Tue, 27 Jun 2017 23:04:08 +0000 (23:04 +0000)]
Merge "libgui: New mutex for ConsumerBase frame callbacks" into oc-dev am: fb672ba37b
am: f64e75d2f0

Change-Id: Icf927506ab83ac03c754658625520eca4cd1b529

7 years agoMerge "libgui: New mutex for ConsumerBase frame callbacks" into oc-dev am: fb672ba37b
Dan Stoza [Tue, 27 Jun 2017 23:03:33 +0000 (23:03 +0000)]
Merge "libgui: New mutex for ConsumerBase frame callbacks" into oc-dev am: fb672ba37b
am: 1813e093bd

Change-Id: I9ca3c8a6bb058177cf47e8d0f8ca5a38d003c686

7 years agoMerge "libgui: New mutex for ConsumerBase frame callbacks" into oc-dev
Dan Stoza [Tue, 27 Jun 2017 23:01:03 +0000 (23:01 +0000)]
Merge "libgui: New mutex for ConsumerBase frame callbacks" into oc-dev
am: fb672ba37b

Change-Id: I90f2ebe102c40c70620ca12bda5000b455109d26

7 years agoMerge "libgui: New mutex for ConsumerBase frame callbacks" into oc-dev
Dan Stoza [Tue, 27 Jun 2017 23:01:03 +0000 (23:01 +0000)]
Merge "libgui: New mutex for ConsumerBase frame callbacks" into oc-dev
am: fb672ba37b

Change-Id: I14c99a3137f086eca4e1c1ab2f8877ae6df88a4a

7 years agoMerge "libgui: New mutex for ConsumerBase frame callbacks" into oc-dev
TreeHugger Robot [Tue, 27 Jun 2017 22:54:05 +0000 (22:54 +0000)]
Merge "libgui: New mutex for ConsumerBase frame callbacks" into oc-dev

7 years agoSurfaceFlinger: Last minute log removal.
Robert Carr [Tue, 27 Jun 2017 20:51:07 +0000 (13:51 -0700)]
SurfaceFlinger: Last minute log removal.

Whoops.

Test: Log removed!
Change-Id: I4593352cf565603a4507c6ef13504b167d882eec

7 years agoMerge "resolve merge conflicts of 40da4609e to oc-dr1-dev-plus-aosp" into oc-dr1...
Jiyong Park [Tue, 27 Jun 2017 08:07:13 +0000 (08:07 +0000)]
Merge "resolve merge conflicts of 40da4609e to oc-dr1-dev-plus-aosp" into oc-dr1-dev-plus-aosp

7 years agoMerge "Fix hidl_ssvc_poll thread issues" into oc-dr1-dev
Peng Xu [Tue, 27 Jun 2017 04:47:32 +0000 (04:47 +0000)]
Merge "Fix hidl_ssvc_poll thread issues" into oc-dr1-dev
am: d8ef90752b

Change-Id: I713984531740a01f33335d516393a522b662d53c

7 years agoMerge "Fix hidl_ssvc_poll thread issues" into oc-dr1-dev
TreeHugger Robot [Tue, 27 Jun 2017 04:43:20 +0000 (04:43 +0000)]
Merge "Fix hidl_ssvc_poll thread issues" into oc-dr1-dev

7 years agoresolve merge conflicts of 40da4609e to oc-dr1-dev-plus-aosp
Jiyong Park [Tue, 27 Jun 2017 00:59:06 +0000 (09:59 +0900)]
resolve merge conflicts of 40da4609e to oc-dr1-dev-plus-aosp

Test: I solemnly swear I tested this conflict resolution.
Change-Id: I0c4a9e0648674b78391e257f6a94bd1e325e1964

7 years agoMerge "libbinder: really make it available to vendors" am: 2bb661ca09
Jiyong Park [Tue, 27 Jun 2017 00:45:13 +0000 (00:45 +0000)]
Merge "libbinder: really make it available to vendors" am: 2bb661ca09
am: 99daab345f

Change-Id: Ief871803389339a3d423787502535c824f35e74e

7 years agoMerge "libbinder: really make it available to vendors"
Jiyong Park [Tue, 27 Jun 2017 00:42:42 +0000 (00:42 +0000)]
Merge "libbinder: really make it available to vendors"
am: 2bb661ca09

Change-Id: I58c2069544d39337b3a054a29fe8fdf98d00a33e

7 years agoMerge "libbinder: really make it available to vendors"
Treehugger Robot [Tue, 27 Jun 2017 00:35:48 +0000 (00:35 +0000)]
Merge "libbinder: really make it available to vendors"

7 years agoTrust navbar panel and accessibility overlays
Phil Weaver [Mon, 26 Jun 2017 23:22:26 +0000 (16:22 -0700)]
Trust navbar panel and accessibility overlays

Fixes: 62048165
Fixes: 62341768
Test: Enable maximum screen display and font size, enable TalkBack.
Enable Select to Speak with FAB, enable TalkBack.

Change-Id: Ia96373200adf9c5d306e9c61da9c65ba412c9430

7 years agoFix hidl_ssvc_poll thread issues
Peng Xu [Sun, 25 Jun 2017 23:43:02 +0000 (16:43 -0700)]
Fix hidl_ssvc_poll thread issues

1) Patch poll wake up handling logic so that thread no longer quits
   on spurious wake up.
2) Patch(simplify) thread initialization, so that it will not hang
   on waiting for conditional variable.

Test: 1) send signal 3 to system_server, does not observe thread quit.
Test: 2) adb shell "stop;start" many times, every time thread starts.

Bug: 62933449
Bug: 62933799

Merged-In: Icb7477e9d75338b9742e144fc2687d5ced91e89e
Change-Id: Icb7477e9d75338b9742e144fc2687d5ced91e89e

7 years agolibbinder: really make it available to vendors
Jiyong Park [Fri, 14 Apr 2017 04:19:48 +0000 (21:19 -0700)]
libbinder: really make it available to vendors

Fixed a bug that vendor variant of the lib is not built due to missing
global include path.

Bug: 36426473
Bug: 36079834
Test: BOARD_VNDK_VERSION=current m -j libbinder.vendor successful

Change-Id: Ice32a23023d7fd9b78c084c3bef455f7008fe4da

7 years agolibgui: New mutex for ConsumerBase frame callbacks
Dan Stoza [Mon, 26 Jun 2017 21:27:18 +0000 (14:27 -0700)]
libgui: New mutex for ConsumerBase frame callbacks

Adds a new mutex to protect ConsumerBase's mFrameAvailableListener
separately from the main mMutex. This prevents deadlocks when trying
to perform callbacks in response to other calls that come through
ConsumerBase.

Bug: 62915791
Test: EncodeVirtualDisplayWithCompositionTest#
          testRenderingMaxResolutionRemotely

Change-Id: I244dc2d83488e452d9690c0d7847c9ff15a95dbb

7 years agoMerge "libgui: export EGL headers." into oc-dr1-dev
Steven Moreland [Mon, 26 Jun 2017 17:59:55 +0000 (17:59 +0000)]
Merge "libgui: export EGL headers." into oc-dr1-dev
am: be2e363c9e

Change-Id: Id87eb01463f03ba0bcbe4948a93f3add60fc0b7e

7 years agoMerge "libgui: export EGL headers." into oc-dr1-dev
TreeHugger Robot [Mon, 26 Jun 2017 17:54:11 +0000 (17:54 +0000)]
Merge "libgui: export EGL headers." into oc-dr1-dev

7 years agoMerge "Revert "libui: Load a.h.graphics.mapper passthrough service on library load...
Jeff Vander Stoep [Sat, 24 Jun 2017 00:28:22 +0000 (00:28 +0000)]
Merge "Revert "libui: Load a.h.graphics.mapper passthrough service on library load"" into oc-dr1-dev
am: 274f72eb9b

Change-Id: Ie94b3b6d08c4ca0a13902fd4ec71e4bc7808831f

7 years agoMerge "Revert "libui: Load a.h.graphics.mapper passthrough service on library load...
TreeHugger Robot [Sat, 24 Jun 2017 00:04:43 +0000 (00:04 +0000)]
Merge "Revert "libui: Load a.h.graphics.mapper passthrough service on library load"" into oc-dr1-dev

7 years agoRevert "libui: Load a.h.graphics.mapper passthrough service on library load"
Jeff Vander Stoep [Fri, 23 Jun 2017 18:41:04 +0000 (11:41 -0700)]
Revert "libui: Load a.h.graphics.mapper passthrough service on library load"

This reverts commit 75ca86f072f82d38b21e0a13234ecbc2c24cb6ab.

avc: denied { read } name="hw" scontext=u:r:cameraserver:s0
tcontext=u:object_r:system_file:s0 tclass=dir
avc: denied { read } name="hw" scontext=u:r:folio_daemon:s0
tcontext=u:object_r:system_file:s0 tclass=dir
avc: denied { read } name="hw" scontext=u:r:hal_imsrtp:s0
tcontext=u:object_r:system_file:s0 tclass=dir
avc: denied { read } name="hw" scontext=u:r:idmap:s0
tcontext=u:object_r:system_file:s0 tclass=dir
avc: denied { read } name="hw" scontext=u:r:mediaextractor:s0
tcontext=u:object_r:system_file:s0 tclass=dir
avc: denied { read } name="hw" scontext=u:r:mediametrics:s0
tcontext=u:object_r:system_file:s0 tclass=dir
avc: denied { read } name="hw" scontext=u:r:webview_zygote:s0
tcontext=u:object_r:system_file:s0 tclass=dir

Bug: 62353585
Bug: 62912747
Bug: 35197529
Test: build and boot device. Launch camera, take pictures.
Change-Id: Ic6884f7235edb9191034a285414eb93aa44ac23c

7 years agoMerge "Make VR HWC DPI a configurable property" into oc-dr1-dev
Kevin Schoedel [Fri, 23 Jun 2017 20:48:10 +0000 (20:48 +0000)]
Merge "Make VR HWC DPI a configurable property" into oc-dr1-dev
am: 281a0c26c0

Change-Id: I3ec8cc3bea80ab946c7576f9de2c470ace2fb72f

7 years agoMerge "Make VR HWC DPI a configurable property" into oc-dr1-dev
TreeHugger Robot [Fri, 23 Jun 2017 20:39:03 +0000 (20:39 +0000)]
Merge "Make VR HWC DPI a configurable property" into oc-dr1-dev

7 years agoMerge "IWYU RegionHelper += <limits>" am: bbf3096e22 am: f08008db9f
Steven Moreland [Fri, 23 Jun 2017 19:42:54 +0000 (19:42 +0000)]
Merge "IWYU RegionHelper += <limits>" am: bbf3096e22 am: f08008db9f
am: 836513bfbf

Change-Id: I164150132bd6518e52894823b10d108e86eed81b

7 years agoMerge "IWYU RegionHelper += <limits>" am: bbf3096e22
Steven Moreland [Fri, 23 Jun 2017 19:36:01 +0000 (19:36 +0000)]
Merge "IWYU RegionHelper += <limits>" am: bbf3096e22
am: f08008db9f

Change-Id: Ida5d67d96a8c3eb87f25202872b2c30ed5b6c25e

7 years agoMerge "IWYU RegionHelper += <limits>"
Steven Moreland [Fri, 23 Jun 2017 19:23:34 +0000 (19:23 +0000)]
Merge "IWYU RegionHelper += <limits>"
am: bbf3096e22

Change-Id: I9dd08e98eee2924554b623f755869fac35a80605

7 years agoMerge "IWYU RegionHelper += <limits>"
Treehugger Robot [Fri, 23 Jun 2017 19:18:41 +0000 (19:18 +0000)]
Merge "IWYU RegionHelper += <limits>"

7 years agoDisable setting saved_cmdline_size am: ba54d5baf4
John Reck [Fri, 23 Jun 2017 19:08:31 +0000 (19:08 +0000)]
Disable setting saved_cmdline_size am: ba54d5baf4
am: acc79d7cfe

Change-Id: I8be566b029a6ec93334e7a4dd37eec12846b1f60

7 years agoDisable setting saved_cmdline_size am: ba54d5baf4
John Reck [Fri, 23 Jun 2017 19:04:01 +0000 (19:04 +0000)]
Disable setting saved_cmdline_size am: ba54d5baf4
am: 64dac11cc0

Change-Id: I293be9ed5486024c479a0ef133086f825e259048

7 years agoDisable setting saved_cmdline_size
John Reck [Fri, 23 Jun 2017 19:02:13 +0000 (19:02 +0000)]
Disable setting saved_cmdline_size
am: ba54d5baf4

Change-Id: Icd17c5257c03fd9e33114c5760ece6c21c74d025

7 years agoDisable setting saved_cmdline_size
John Reck [Fri, 23 Jun 2017 19:00:44 +0000 (19:00 +0000)]
Disable setting saved_cmdline_size
am: ba54d5baf4

Change-Id: I447ad42ad4c245013e488701a61d8ce2348a368d

7 years agoIWYU RegionHelper += <limits>
Steven Moreland [Fri, 23 Jun 2017 17:23:41 +0000 (10:23 -0700)]
IWYU RegionHelper += <limits>

Test: compiles when transitive dependency is removed
Bug: 35363681
Change-Id: Ia405e41102e6ded07720e424167df7e4d080581e

7 years agoDisable setting saved_cmdline_size
John Reck [Fri, 23 Jun 2017 16:44:08 +0000 (09:44 -0700)]
Disable setting saved_cmdline_size

Minimal revert of the addition of increasing
the saved_cmdline_size. This change
exposed kernel bugs that prevented
atrace from working.

Bug: 62375794
Test: manual
Change-Id: Ie946b9246ce9ba22af59dbf0b9fe8a59a5fa1f3f

7 years agoEGL: add color space validation
Courtney Goeltzenleuchter [Fri, 23 Jun 2017 02:40:16 +0000 (02:40 +0000)]
EGL: add color space validation
am: 15f79786e1

Change-Id: I05600bda5553b6e5f49a055f30cfef60db4fa9e8

7 years agolibgui: export EGL headers.
Steven Moreland [Fri, 23 Jun 2017 00:50:49 +0000 (17:50 -0700)]
libgui: export EGL headers.

Many libgui headers use these headers so not exporting
these breaks BOARD_VNDK_VERSION=current builds.

Test: headers resolved with BOARD_VNDK_VERSION=current
Change-Id: I085faeda4f8ad8a07d91e81222b8031a0dd1858a

7 years agoEGL: add color space validation
Courtney Goeltzenleuchter [Tue, 20 Jun 2017 14:12:54 +0000 (08:12 -0600)]
EGL: add color space validation

We want Android to support multiple color spaces as
that can be implemented entirely in the eglapi.cpp wrapper.
These additional dataspaces do not require special behavior
by the driver and may not recognize EGL_GL_COLORSPACE_DISPLAY_P3_EXT,
EGL_GL_COLORSPACE_DISPLAY_P3_LINEAR_EXT, and related attributes.
Therefor, need to filter out those attributes before calling
the driver.
In the future there may be new extensions that do require
driver support. When that happens we'll need to update
stripColorSpaceAttribute to treat that correctly.

Test: Android CTS
      adb -d shell am start \
      -n com.drawelements.deqp/android.app.NativeActivity \
      -e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
      --deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Bug: 62424735
Change-Id: I0f0867feb73055100636d326213183ef1f052b7c
(cherry picked from commit eeaa52bc65b5cfaca1f0de44635b57919179df29)

7 years agoMerge "surfaceflinger: discard stale commands" into oc-dev am: f8ca9a0875
Chia-I Wu [Thu, 22 Jun 2017 20:47:38 +0000 (20:47 +0000)]
Merge "surfaceflinger: discard stale commands" into oc-dev am: f8ca9a0875
am: 3addef29f7

Change-Id: Ica0906d38bbf2df75f10a6108600c3c1646ab80d

7 years agoMerge "LibGUI remove DEBUG" into oc-dev am: be597daebd
Fabien Sanglard [Thu, 22 Jun 2017 20:47:14 +0000 (20:47 +0000)]
Merge "LibGUI remove DEBUG" into oc-dev am: be597daebd
am: 45bf98c36e

Change-Id: Ic223a6dfb10324fbdd2b2609072a0088eff4fbd9

7 years agoDisable skip Validate on client composition am: 269c236109
Fabien Sanglard [Thu, 22 Jun 2017 20:46:48 +0000 (20:46 +0000)]
Disable skip Validate on client composition am: 269c236109
am: 0ff681ca77

Change-Id: I7331077ef129e55aed38f10f19732a22eb842bd6

7 years agoMerge "surfaceflinger: discard stale commands" into oc-dev am: f8ca9a0875
Chia-I Wu [Thu, 22 Jun 2017 20:15:00 +0000 (20:15 +0000)]
Merge "surfaceflinger: discard stale commands" into oc-dev am: f8ca9a0875
am: 49cdc635a2

Change-Id: I84da842894b25f11b665bd3b4adf597b3aee94ef

7 years agoMerge "LibGUI remove DEBUG" into oc-dev am: be597daebd
Fabien Sanglard [Thu, 22 Jun 2017 20:14:32 +0000 (20:14 +0000)]
Merge "LibGUI remove DEBUG" into oc-dev am: be597daebd
am: d9517fe958

Change-Id: Id677c4ba2c28922c4a3f64fdc2b114d3e3031dbd

7 years agoDisable skip Validate on client composition am: 269c236109
Fabien Sanglard [Thu, 22 Jun 2017 20:14:10 +0000 (20:14 +0000)]
Disable skip Validate on client composition am: 269c236109
am: 89283e56d6

Change-Id: Id8e05d219ef73616cdef7152008b487050f25373

7 years agoMerge "surfaceflinger: discard stale commands" into oc-dev
Chia-I Wu [Thu, 22 Jun 2017 20:07:16 +0000 (20:07 +0000)]
Merge "surfaceflinger: discard stale commands" into oc-dev
am: f8ca9a0875

Change-Id: I6b7ce1798d2fe753c577ff3baa954283c372b80c

7 years agoMerge "LibGUI remove DEBUG" into oc-dev
Fabien Sanglard [Thu, 22 Jun 2017 20:06:51 +0000 (20:06 +0000)]
Merge "LibGUI remove DEBUG" into oc-dev
am: be597daebd

Change-Id: Iece9f1428655c8674cf62a92ecb0a088ad74b629

7 years agoDisable skip Validate on client composition
Fabien Sanglard [Thu, 22 Jun 2017 20:06:31 +0000 (20:06 +0000)]
Disable skip Validate on client composition
am: 269c236109

Change-Id: I4c0a4a90ff0ca2e39075ad643d1892597301d3fd

7 years agoMerge "surfaceflinger: discard stale commands" into oc-dev
Chia-I Wu [Thu, 22 Jun 2017 20:04:12 +0000 (20:04 +0000)]
Merge "surfaceflinger: discard stale commands" into oc-dev
am: f8ca9a0875

Change-Id: Ief69f6fcf0c738612b14b94d65b3ae1555973d6c

7 years agoMerge "LibGUI remove DEBUG" into oc-dev
Fabien Sanglard [Thu, 22 Jun 2017 20:03:13 +0000 (20:03 +0000)]
Merge "LibGUI remove DEBUG" into oc-dev
am: be597daebd

Change-Id: I65756ce89b4a10d2df403f9f9a4ce2cacdaafda0

7 years agoDisable skip Validate on client composition
Fabien Sanglard [Thu, 22 Jun 2017 20:02:43 +0000 (20:02 +0000)]
Disable skip Validate on client composition
am: 269c236109

Change-Id: Ib0d2f8a9e59cf4618ed029fe35391f566d11bcfb

7 years agoMerge "surfaceflinger: discard stale commands" into oc-dev
Chia-I Wu [Thu, 22 Jun 2017 19:59:35 +0000 (19:59 +0000)]
Merge "surfaceflinger: discard stale commands" into oc-dev

7 years agoMerge "LibGUI remove DEBUG" into oc-dev
Fabien Sanglard [Thu, 22 Jun 2017 19:56:29 +0000 (19:56 +0000)]
Merge "LibGUI remove DEBUG" into oc-dev

7 years agoDisable skip Validate on client composition
Fabien Sanglard [Thu, 22 Jun 2017 18:35:16 +0000 (11:35 -0700)]
Disable skip Validate on client composition

SurfaceFlinger should not skip validate when GLComposition is
needed. This can happen when SF decides to force GLComposition
(like when a screen rotation occurs).

Bug: 62906801
Test: Manual
Change-Id: I248146eade395a124cb149773287abd88ae36511

7 years agosurfaceflinger: discard stale commands
Chia-I Wu [Thu, 22 Jun 2017 17:48:28 +0000 (10:48 -0700)]
surfaceflinger: discard stale commands

When we skip validate, we may have stale commands on the command
buffer.  They should be discarded.

Bug: 62906801
Test: manual
Change-Id: Ie7921ba75ab2252b834cda6924e1fcfdf236f759

7 years agoLibGUI remove DEBUG
Fabien Sanglard [Thu, 22 Jun 2017 18:13:49 +0000 (11:13 -0700)]
LibGUI remove DEBUG

DEBUG_ONLY_CODE flag enables expensive checks such as
BufferQueueCore::validateConsistencyLocked() which when running
represents 15.1% of SurfaceFlinger total runtime. Enabling these
check for "eng" build only make "userdebug" build closer to "user".

Test: Manual
Bug: 62905241
Change-Id: I77065ecf4e62261c3f02b1cad9966d5c4845c639

7 years agoMerge "Skip Validate am: 249c0ae80a am: 9837ce8210" into oc-dr1-dev-plus-aosp
Android Build Merger (Role) [Thu, 22 Jun 2017 06:02:10 +0000 (06:02 +0000)]
Merge "Skip Validate am: 249c0ae80a am: 9837ce8210" into oc-dr1-dev-plus-aosp

7 years agoSkip Validate am: 249c0ae80a
Fabien Sanglard [Thu, 22 Jun 2017 06:01:34 +0000 (06:01 +0000)]
Skip Validate am: 249c0ae80a
am: 9837ce8210

Change-Id: If81e98cd140426c5cc33595205fd9d4c26bef044

7 years agoSkip Validate am: 249c0ae80a
Fabien Sanglard [Thu, 22 Jun 2017 06:01:00 +0000 (06:01 +0000)]
Skip Validate am: 249c0ae80a
am: 8976c6ae37

Change-Id: I400dfd8d484779e5523353b002164f4f5ea41e03

7 years agoSkip Validate
Fabien Sanglard [Thu, 22 Jun 2017 05:58:06 +0000 (05:58 +0000)]
Skip Validate
am: 249c0ae80a

Change-Id: I336fce473d21e5fdfb80ad8eb48f1df5a24497d8

7 years agoSkip Validate
Fabien Sanglard [Thu, 22 Jun 2017 05:57:15 +0000 (05:57 +0000)]
Skip Validate
am: 249c0ae80a

Change-Id: I55a564d600a422915f43111f4e02a10857512fcf

7 years agoSkip Validate
Fabien Sanglard [Tue, 20 Jun 2017 02:22:36 +0000 (19:22 -0700)]
Skip Validate

b/37474580
b/62806392

Test: marlin, ryu

Change-Id: I09e0c52cb7c914dcd883dc771d97a365c89f7037

7 years agoMerge "Update dumpstate binary file name" into oc-dr1-dev
Jibu Joseph [Thu, 22 Jun 2017 04:41:37 +0000 (04:41 +0000)]
Merge "Update dumpstate binary file name" into oc-dr1-dev
am: 8d897e6003

Change-Id: Idfd13cc794eb170c16d203f7f8b78077ac37db80