OSDN Git Service
Hansong Zhang [Mon, 28 Sep 2020 23:19:52 +0000 (23:19 +0000)]
L2CAP: Remove unused ConnectRsp am:
3dbda905a5
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1440333
Change-Id: I1c1428f21cc3233903e686f9cae3b922e08c8518
Hansong Zhang [Mon, 28 Sep 2020 21:41:52 +0000 (21:41 +0000)]
RFCOMM, AVDT, HID: L2cap signal id is not used am:
ade4d449cd
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1440416
Change-Id: I4399b307c9f1bcc565319eba09b60a9a49133bf2
Hansong Zhang [Mon, 28 Sep 2020 21:28:57 +0000 (21:28 +0000)]
Include initial remote config in pL2CA_ConfigCfm_Cb am:
aec9dadc2e
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1440332
Change-Id: I4d30931e1ce85e2593d04ef2fdae81bae5952cfd
Hansong Zhang [Mon, 28 Sep 2020 20:55:14 +0000 (20:55 +0000)]
Serialize L2CAP connect ind/cfm, config ind, cfm am:
b737b6dcda
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1440691
Change-Id: I20205d2b00a0576eb2413dce747356262db40bf2
Hansong Zhang [Mon, 28 Sep 2020 20:55:12 +0000 (20:55 +0000)]
L2cap: Auto send ConnectRsp am:
d8d7224c2e
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1440654
Change-Id: I260ba6995b80b8f1ffc8bfee879c9b27d3320b04
Hansong Zhang [Mon, 28 Sep 2020 20:55:08 +0000 (20:55 +0000)]
Check for control block nullptr on l2cap error am:
d77658a680
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1440653
Change-Id: I3c574634a60a0a4f376b8670330a848045689efb
Hansong Zhang [Mon, 28 Sep 2020 20:55:05 +0000 (20:55 +0000)]
L2cap channel cb: Store who initiated dynamic channel am:
7bfe49749a
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1440652
Change-Id: I3c642a89b7ca5c38fad8ed3905f224a32c67a738
Hansong Zhang [Mon, 28 Sep 2020 20:55:02 +0000 (20:55 +0000)]
We always send pL2CA_ConfigCfm_Cb with status OK am:
40b23cc4ab
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1440651
Change-Id: I21c840a6db17549af0a378cf5af3f57c91facd93
Hansong Zhang [Mon, 28 Sep 2020 20:54:58 +0000 (20:54 +0000)]
L2cap shim clean up am:
ee79913590
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1440315
Change-Id: I4158575f6fc937f5c061aad1e9bf14b72381c274
Hansong Zhang [Mon, 28 Sep 2020 20:54:55 +0000 (20:54 +0000)]
L2CAP_FLUSHABLE_PKT is never used am:
6b63057385
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1440314
Change-Id: Ie5273670372d83b30ff1f6cf3406843496d917d7
Hansong Zhang [Mon, 28 Sep 2020 20:54:51 +0000 (20:54 +0000)]
Minor clean up in l2c_api am:
324f7e9cec
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1440313
Change-Id: I436a7ffeabe9c926062f05831aea7056396b1158
Hansong Zhang [Mon, 28 Sep 2020 20:54:48 +0000 (20:54 +0000)]
L2cap: Simplify DisconnectRsp am:
014930dadc
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1440312
Change-Id: Iefab338e11f2815cce8e352d679f2e410cae93a0
Hansong Zhang [Mon, 28 Sep 2020 20:54:29 +0000 (20:54 +0000)]
Remove unused L2cap code am:
2d291bead0
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1440311
Change-Id: Ie3beca412e99a47bfe4d2d07452ed1d98388d0ef
Hansong Zhang [Mon, 28 Sep 2020 20:54:24 +0000 (20:54 +0000)]
Simplify avdt_sec_check_complete_term am:
1d6fa5e136
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439087
Change-Id: Ie361553e46e0bf5c56503b0a1153d9791bba476f
Hansong Zhang [Mon, 28 Sep 2020 20:53:44 +0000 (20:53 +0000)]
Simplify bnep_sec_check_complete am:
86fbde4a5e
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439086
Change-Id: Idb4a0b924b656e23556d6161da055fe6a8de2398
Hansong Zhang [Mon, 28 Sep 2020 20:00:18 +0000 (13:00 -0700)]
L2CAP: Remove unused ConnectRsp
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ifa6fc5470aeda670eb51482ed91a2b7ab665a813
Hansong Zhang [Mon, 28 Sep 2020 19:40:00 +0000 (12:40 -0700)]
RFCOMM, AVDT, HID: L2cap signal id is not used
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I53b2236b8603b4d8a3c6a49f8ae1355020a657e5
Hansong Zhang [Mon, 28 Sep 2020 19:20:19 +0000 (12:20 -0700)]
Include initial remote config in pL2CA_ConfigCfm_Cb
So we don't need to send a separate pL2CA_ConfigInd_Cb.
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I75dafa4bc38a1c5a7773db6be5665b30ad88b006
Hansong Zhang [Mon, 28 Sep 2020 19:03:43 +0000 (19:03 +0000)]
l2c_csm: Use pL2CA_Error_Cb on error am:
30a07c56e1
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439085
Change-Id: I5d53012f81c0ee4358948654418600b897f1f34b
Hansong Zhang [Mon, 28 Sep 2020 19:02:50 +0000 (19:02 +0000)]
Regard L2CAP_CFG_PENDING as failure am:
5b85860bd5
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439084
Change-Id: I9d42ccf85dc915acb2561a63d2718bbb1d5c08bf
Hansong Zhang [Mon, 28 Sep 2020 06:59:00 +0000 (23:59 -0700)]
Serialize L2CAP connect ind/cfm, config ind, cfm
Make them happen at one place.
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ie6b073312f77d837009783dcdbbf6835dfe71985
Hansong Zhang [Sun, 27 Sep 2020 23:49:17 +0000 (16:49 -0700)]
L2cap: Auto send ConnectRsp
In the past, L2cap user can decide whether to accept or reject a
ConnectReq. If reject, the channel is closed.
Now let L2cap layer always auto accept the remote ConnectReq and start
config process. If the L2cap user wants to reject, they can send a
DisconnectReq. According to L2cap state machine, a DisconnectReq after
ConnectRsp terminates the channel, which is equivalent to sending a
negative ConnectRsp, as before.
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ibed56206148922356e8d9cb10650e9d82ab61225
Hansong Zhang [Sun, 27 Sep 2020 23:30:03 +0000 (16:30 -0700)]
Check for control block nullptr on l2cap error
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ie041822b2f51aa20e57fa35f90c432a6c96733d5
Hansong Zhang [Sun, 27 Sep 2020 23:12:43 +0000 (16:12 -0700)]
L2cap channel cb: Store who initiated dynamic channel
Use pL2CA_ConfigCfm_Cb to let user know the direction.
Later the user can run check in ConnectInd or ConnectCfm callback.
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Iae663e6bea0fc9426c5dfbbfc52bd1ae848f2965
Hansong Zhang [Sun, 27 Sep 2020 22:53:12 +0000 (15:53 -0700)]
We always send pL2CA_ConfigCfm_Cb with status OK
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I4865330b4c48fe507bd6df72a5e362a616744ef4
Hansong Zhang [Sun, 27 Sep 2020 22:18:57 +0000 (15:18 -0700)]
L2cap shim clean up
Now we send ConfigReq and ConfigRsp automatically, we need to send
callbacks automatically.
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I34e9a8afef63fed21befeda5c3a66e425d6ffaf8
Hansong Zhang [Sun, 27 Sep 2020 21:23:20 +0000 (14:23 -0700)]
L2CAP_FLUSHABLE_PKT is never used
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I21ef421c0fcc0f85ab4497fb4ff47bd83a242673
Hansong Zhang [Mon, 28 Sep 2020 16:48:11 +0000 (16:48 +0000)]
Introduce pL2CA_Error_Cb am:
b6e5a07555
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439083
Change-Id: I4af7949c994761ee6b3a7b6c2808a8077fafdfc7
Hansong Zhang [Mon, 28 Sep 2020 16:47:19 +0000 (16:47 +0000)]
l2c_csm: Remove unused variable am:
5020f1c00f
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439082
Change-Id: I7a4ad9d2b31de4811798dcbb206702be137de7b2
Hansong Zhang [Sun, 27 Sep 2020 07:24:48 +0000 (00:24 -0700)]
Minor clean up in l2c_api
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I4e7f7d610dba175c9d0abc3d23038891acf31242
Hansong Zhang [Sun, 27 Sep 2020 07:12:49 +0000 (00:12 -0700)]
L2cap: Simplify DisconnectRsp
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working & OPP
Change-Id: I3c4c18bc6d55fe3aa8acda4db8d72f97781729ec
Hansong Zhang [Sun, 27 Sep 2020 07:03:53 +0000 (00:03 -0700)]
Remove unused L2cap code
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working & OPP
Change-Id: I3fce28b929e0d8685656b64725d8d36e37a082b4
Hansong Zhang [Sun, 27 Sep 2020 00:59:51 +0000 (17:59 -0700)]
Simplify avdt_sec_check_complete_term
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Iabddefde41cc2f63b306efe0cd4eb7e59116141b
Hansong Zhang [Sun, 27 Sep 2020 00:42:02 +0000 (17:42 -0700)]
Simplify bnep_sec_check_complete
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ifc0edea758f4d1e0847f5b00fc49b51b4ad00344
Hansong Zhang [Sat, 26 Sep 2020 23:58:47 +0000 (16:58 -0700)]
l2c_csm: Use pL2CA_Error_Cb on error
Note that we only have two result codes, because the user only needs to
know whether it's during ConnectRsp or ConfigRsp (except for HIDH
retry), which we need further research.
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I24aa7bf8487c9b2b69fc455cfdb52a7ec758b90b
Hansong Zhang [Sat, 26 Sep 2020 23:48:40 +0000 (16:48 -0700)]
Regard L2CAP_CFG_PENDING as failure
Since all L2CAP users disconnect if the status is not OK.
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I112400c2081be12d038426c1e8ea82229d5b9f4a
Hansong Zhang [Sat, 26 Sep 2020 23:39:28 +0000 (16:39 -0700)]
Introduce pL2CA_Error_Cb
L2CAP notifies users error in ConnectRsp and ConfigRsp through this
callback function (not linked so far). Next step is we send success
through pL2CA_ConnectCfm_Cb and pL2CA_ConfigCfm_Cb.
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I4456487d36248408fc1c31403d107baef05e3646
Hansong Zhang [Sat, 26 Sep 2020 23:20:31 +0000 (16:20 -0700)]
l2c_csm: Remove unused variable
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ie11caa34cc55ed7e4aa6789df4cf08725998c73a
Treehugger Robot [Mon, 28 Sep 2020 03:01:03 +0000 (03:01 +0000)]
Merge "Add missing runtime dependency of android.hardware.bluetooth@1.1-service.btlinux" am:
960730c35b
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439973
Change-Id: Ic78e1a205f0e6c32291968257f6e069b1579dfb9
Treehugger Robot [Mon, 28 Sep 2020 02:28:06 +0000 (02:28 +0000)]
Merge "Add missing runtime dependency of android.hardware.bluetooth@1.1-service.btlinux"
Treehugger Robot [Mon, 28 Sep 2020 00:38:30 +0000 (00:38 +0000)]
Merge "Set apex_available property" am:
9a5637591a
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1432812
Change-Id: I56e4f7d5776bace6a9bec765aedc4a6f34add49f
Treehugger Robot [Mon, 28 Sep 2020 00:05:12 +0000 (00:05 +0000)]
Merge "Set apex_available property"
Hansong Zhang [Sun, 27 Sep 2020 16:11:38 +0000 (16:11 +0000)]
L2CAP ERTM: Fix p_ccb->max_rx_mtu am:
8308c24d8a
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439081
Change-Id: I07e1644a16015e7ec5d7876a365a28ecf4eee2de
Hansong Zhang [Sun, 27 Sep 2020 07:25:37 +0000 (07:25 +0000)]
Use hidh_on_l2cap_error for error handling am:
95149a585c
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439959
Change-Id: I306d906901998af5c5cf41b844e32b16df7a7722
Hansong Zhang [Sun, 27 Sep 2020 07:25:34 +0000 (07:25 +0000)]
Use hidd_on_l2cap_error for error handling am:
407ad73659
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439638
Change-Id: Ice0383502cc4ed8210dd326671a17fbecbf5e154
Hansong Zhang [Sun, 27 Sep 2020 07:25:31 +0000 (07:25 +0000)]
HID: Simplify security check code am:
a412f6bbb3
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439965
Change-Id: I6f128e6bd65565bf44ad6e1257c92fb26c692258
Hansong Zhang [Sun, 27 Sep 2020 07:25:28 +0000 (07:25 +0000)]
Use rfc_on_l2cap_error for error handling am:
d3c390b077
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439637
Change-Id: I70c2c8bf6286149d4a09cce25d67fe4a1a311c61
Hansong Zhang [Sun, 27 Sep 2020 07:25:25 +0000 (07:25 +0000)]
Use avct_on_l2cap_error for error handling am:
4e82f0d26c
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439964
Change-Id: Id17abbde51854c5b624f6a7527244e4aa11eff01
Hansong Zhang [Sun, 27 Sep 2020 07:25:21 +0000 (07:25 +0000)]
Use avdt_on_l2cap_error for error handling am:
ece51101ed
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439963
Change-Id: I26b046a88658c748960d09e4f3499ad09ae48a37
Hansong Zhang [Sun, 27 Sep 2020 07:24:40 +0000 (07:24 +0000)]
Use avct_br_on_l2cap_error am:
4e00fa771a
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439962
Change-Id: Ib7c8310fc78799f021ca72a51576ea13cda577f2
Hansong Zhang [Sun, 27 Sep 2020 06:38:13 +0000 (23:38 -0700)]
L2CAP ERTM: Fix p_ccb->max_rx_mtu
Use the old value, which was removed in
I78c3d65fdaf14addf80607ce5105221e52447a9e.
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working & OPP
Change-Id: I90a8f94d16f87df2d4ce8bb0de8130d544affd12
Hansong Zhang [Sat, 26 Sep 2020 06:06:13 +0000 (23:06 -0700)]
Use hidh_on_l2cap_error for error handling
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I098743c83c82445618d02c2d8491890d8f765fee
Hansong Zhang [Sat, 26 Sep 2020 06:18:33 +0000 (23:18 -0700)]
Use hidd_on_l2cap_error for error handling
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I96bb727b01b8f0114d9f0cba1b8068e9591fae1f
Hansong Zhang [Sat, 26 Sep 2020 06:04:26 +0000 (23:04 -0700)]
HID: Simplify security check code
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ief3f87adbe41c1d4c5ea848fcddc3d1a3352166b
Hansong Zhang [Sat, 26 Sep 2020 06:30:27 +0000 (23:30 -0700)]
Use rfc_on_l2cap_error for error handling
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I32a6be12ab14a27c9c0502961bf5bd9bdbdff005
Hansong Zhang [Sat, 26 Sep 2020 00:40:04 +0000 (17:40 -0700)]
Use avct_on_l2cap_error for error handling
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I6e35a51a175b43d9b0dc5bb5be859e2d5ff94fa1
Hansong Zhang [Sat, 26 Sep 2020 00:35:36 +0000 (17:35 -0700)]
Use avdt_on_l2cap_error for error handling
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I03f15d69e86d12b53fa4ee7fc711d4dca8a294aa
Hansong Zhang [Sat, 26 Sep 2020 00:12:47 +0000 (17:12 -0700)]
Use avct_br_on_l2cap_error
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I40fb1d61ff9375d0da2e1f4c83d42d5b273699c4
Hansong Zhang [Sun, 27 Sep 2020 00:30:14 +0000 (00:30 +0000)]
Use gap_on_l2cap_error for error handling am:
09f5d7f465
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439960
Change-Id: Ib5e1789effa96f6aafc4398099c917629c4baafe
Hansong Zhang [Sat, 26 Sep 2020 22:48:00 +0000 (22:48 +0000)]
Use gatt_on_l2cap_error for error handling am:
e8dc945f4d
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439958
Change-Id: If3d908794800893809af613fbf2e8074801eaa71
Hansong Zhang [Sat, 26 Sep 2020 22:47:56 +0000 (22:47 +0000)]
Simplify bnep_on_l2cap_error am:
3b18048449
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439957
Change-Id: Id3c875a660cbfcb4ee6ced2bb9ff295246e717b9
Hansong Zhang [Sat, 26 Sep 2020 22:47:51 +0000 (22:47 +0000)]
Use bnep_on_l2cap_error for error handling am:
44b477a8bc
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439956
Change-Id: I802e48ec1b85f25fab4b78fffd694b1eb04f7f46
Hansong Zhang [Sat, 26 Sep 2020 22:47:48 +0000 (22:47 +0000)]
Simplify sdp_on_l2cap_error am:
c86dcd3704
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439955
Change-Id: Ic1e19306b0ecb910bd748253c4942a2d27747c1c
Hansong Zhang [Sat, 26 Sep 2020 22:47:43 +0000 (22:47 +0000)]
SDP failure reason isn't used am:
bd04c8dcd3
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439954
Change-Id: Icd7308889c4a0539d0dfec6dafe4331565ce3817
Hansong Zhang [Sat, 26 Sep 2020 22:47:38 +0000 (22:47 +0000)]
SDP: Move L2cap error handling to one place am:
ceac9ce032
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439953
Change-Id: I3b3da3e0744c427ab6cd59aef7e6cd369cf5c755
Hansong Zhang [Sat, 26 Sep 2020 22:47:34 +0000 (22:47 +0000)]
Remove unused code in l2c_api am:
3fd840f421
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439952
Change-Id: Ife055cc136ed77f80a45feb0193d10db676a5c44
Hansong Zhang [Sat, 26 Sep 2020 22:46:46 +0000 (22:46 +0000)]
Remove L2CA_ErtmConnectRsp am:
11e328e0d4
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439636
Change-Id: I34423e5fddcd4364baee29219edfafea54dcd9eb
Tianyu Jiang [Fri, 25 Sep 2020 22:36:20 +0000 (15:36 -0700)]
Add missing runtime dependency of android.hardware.bluetooth@1.1-service.btlinux
so that hwasan build succeeds.
Test: lunch aosp_??????-userdebug && m SANITIZE_TARGET=hwaddress -j36
Bug:
169083233
Change-Id: I78da891664c2667aa449969b6f06f030e624b2e7
(cherry picked from commit
7181fb9f9e6823e06e718de5727f123b4073e05e)
Hansong Zhang [Sat, 26 Sep 2020 05:51:13 +0000 (05:51 +0000)]
Remove L2CA_ErtmConnectReq am:
415e2e80ff
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439635
Change-Id: Ifb146de6d763c881c42b47e813b7c31d22d5a835
Hansong Zhang [Sat, 26 Sep 2020 05:50:27 +0000 (05:50 +0000)]
L2CAP: Use ERTM info during registration, not conn req am:
1877084886
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439634
Change-Id: I5985b42406af81a0dd00737fec8882b86898cb84
Hansong Zhang [Sat, 26 Sep 2020 01:20:51 +0000 (01:20 +0000)]
Clean up unused defines and imports am:
f1ed22df09
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439633
Change-Id: I27bd6dc4a030a76d2b0a196eeb749505f23dfdef
Hansong Zhang [Sat, 26 Sep 2020 01:20:48 +0000 (01:20 +0000)]
L2cap user: Use ConfigCfm_Cb as channel open indicator am:
2304c36e52
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439632
Change-Id: I1ee0509fb3773e0c74a2ea27e40b7172909b2972
Hansong Zhang [Sat, 26 Sep 2020 01:20:44 +0000 (01:20 +0000)]
L2C_CSM: Send ConfigCfm to user after ConfigInd am:
4bac7e4a78
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439775
Change-Id: Ie274e249a4865bcbe8cb3a8b52f2ec9dc6139c38
Hansong Zhang [Sat, 26 Sep 2020 01:20:40 +0000 (01:20 +0000)]
L2CA_ConfigCfm_Cb only need to provide result am:
da8ec43139
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439774
Change-Id: Ie88ef37e16467bd8809df2ca44d710fc56a775fc
Hansong Zhang [Sat, 26 Sep 2020 01:20:36 +0000 (01:20 +0000)]
HIDD: Treat unacceptable QOS as normal failure am:
3c87d00189
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439773
Change-Id: Ib50488e6972f13614ac9fa352032213221650a62
Hansong Zhang [Sat, 26 Sep 2020 01:20:31 +0000 (01:20 +0000)]
L2CA_ConfigReq and L2CA_ConfigRsp are internal now am:
acc416288e
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439772
Change-Id: I0cbd5d725f6053d051f35b1e40c98fe6883a25c5
Hansong Zhang [Sat, 26 Sep 2020 01:20:27 +0000 (01:20 +0000)]
Remove L2CA_ConfigReq in client code am:
e91542d478
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1439451
Change-Id: I68652917693600c85d10e10574c5f4f64d7c51f6
Hansong Zhang [Sat, 26 Sep 2020 01:20:24 +0000 (01:20 +0000)]
L2CAP module will send ConfigReq for you am:
65acfa23cf
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1438418
Change-Id: I4ea5f0e86c2bf834b348f7f3750517f0fed4550f
Hansong Zhang [Sat, 26 Sep 2020 01:20:20 +0000 (01:20 +0000)]
L2CAP: Don't allow sending re-config am:
db34984d29
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1438672
Change-Id: If31d05d271340f2dd41561a4bc7142f223b9927b
Hansong Zhang [Sat, 26 Sep 2020 01:20:15 +0000 (01:20 +0000)]
L2CA_ConfigRsp is always invoked with status OK am:
8588d5cdd1
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1438671
Change-Id: I593f15a4d4157df2a7109c2c43d74559a7cbabd8
Hansong Zhang [Sat, 26 Sep 2020 01:20:12 +0000 (01:20 +0000)]
L2CAP: Provide a default ERTM option am:
0640f93856
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1438417
Change-Id: I18acbf65f5eab682de8073b98875f828da5056fa
Hansong Zhang [Sat, 26 Sep 2020 01:20:07 +0000 (01:20 +0000)]
Some ERTM values are constant am:
1b6d60e504
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1438416
Change-Id: I0803905600edcfd0c0012d51917c584815ef87d8
Hansong Zhang [Sat, 26 Sep 2020 01:20:03 +0000 (01:20 +0000)]
Remove unnecessary definition am:
989e83b5c1
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1438415
Change-Id: I82073c462fe23457dc86e2cb3580de5da844b8d0
Treehugger Robot [Sat, 26 Sep 2020 01:19:01 +0000 (01:19 +0000)]
Merge "HciCaptures: Add CommandComplete" am:
08fd1d6421
Original change: https://android-review.googlesource.com/c/platform/system/bt/+/
1438313
Change-Id: Idc051f11ee5ccf06d7b241fb5dc66261ae34bc0f
Hansong Zhang [Sat, 26 Sep 2020 00:03:33 +0000 (17:03 -0700)]
Use gap_on_l2cap_error for error handling
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I8faaa5f586e3133d1a5c7ff890ad27a87ee9433a
Hansong Zhang [Fri, 25 Sep 2020 23:54:05 +0000 (16:54 -0700)]
Use gatt_on_l2cap_error for error handling
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I7a2fbc5805662270588d152ead932ffa02fc9dc6
Hansong Zhang [Fri, 25 Sep 2020 23:37:51 +0000 (16:37 -0700)]
Simplify bnep_on_l2cap_error
Both cases are doing the same thing.
Error reason isn't used throughout the stack.
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ib3793f96c0d8a2907fc41d9a24712d2db78a0665
Hansong Zhang [Fri, 25 Sep 2020 23:37:05 +0000 (16:37 -0700)]
Use bnep_on_l2cap_error for error handling
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ieb28a7bbdea106a5e51e9bf996ecba9dab71f15a
Hansong Zhang [Fri, 25 Sep 2020 23:29:29 +0000 (16:29 -0700)]
Simplify sdp_on_l2cap_error
Both cases are doing the same thing (send disconnect request is no-op if
channel is not open, and then free the control block).
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I9b29899164b00fd9072e4dc37cfc30dd095c3524
Hansong Zhang [Fri, 25 Sep 2020 23:27:47 +0000 (16:27 -0700)]
SDP failure reason isn't used
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I1ee477914c1f13f43f868a28f18b372e36baf752
Hansong Zhang [Fri, 25 Sep 2020 23:24:52 +0000 (16:24 -0700)]
SDP: Move L2cap error handling to one place
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I903127f07ae97349d1fa7625d20835b46dbe9063
Hansong Zhang [Fri, 25 Sep 2020 23:16:48 +0000 (16:16 -0700)]
Remove unused code in l2c_api
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ifdcb0a14919e75103796246cddb9011393e0035a
Hansong Zhang [Fri, 25 Sep 2020 22:32:40 +0000 (15:32 -0700)]
Remove L2CA_ErtmConnectRsp
Just use L2CA_ConnectRsp.
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ie95ed09c9d2e79fabd9d6eae6a038a6896a8e558
Hansong Zhang [Fri, 25 Sep 2020 22:27:51 +0000 (15:27 -0700)]
Remove L2CA_ErtmConnectReq
Now that the p_ertm_info parameter is unused, just use L2CA_ConnectReq.
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I458e0d8bcc2809c8bc2d295be29516be05bf05ba
Hansong Zhang [Fri, 25 Sep 2020 22:18:09 +0000 (15:18 -0700)]
L2CAP: Use ERTM info during registration, not conn req
ERTM info is stored in p_ccb->p_rcb. Use that as the source of truth.
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I78c3d65fdaf14addf80607ce5105221e52447a9e
Hansong Zhang [Fri, 25 Sep 2020 21:57:49 +0000 (14:57 -0700)]
Clean up unused defines and imports
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I5c47ee320085664b3db68ff4a5860aa931d1376d
Hansong Zhang [Fri, 25 Sep 2020 21:32:11 +0000 (14:32 -0700)]
L2cap user: Use ConfigCfm_Cb as channel open indicator
When the user receives ConfigCfm_Cb, it's guaranteed that ConfigInd_Cb
is received with correct option enforced.
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I6de12f1ba6e9612f6a84b399e7fc984a7f3c3c72
Hansong Zhang [Fri, 25 Sep 2020 20:24:55 +0000 (13:24 -0700)]
L2C_CSM: Send ConfigCfm to user after ConfigInd
This way, users know that a ConfigCfm event with status OK means channel
is established. No need to further keep track of state.
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I90295349c53d57aa859c5bb65e6f28a299714b3d
Hansong Zhang [Fri, 25 Sep 2020 19:39:16 +0000 (12:39 -0700)]
L2CA_ConfigCfm_Cb only need to provide result
Users only care about result.
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ife07db2454f938fb1dd1b7fde2136b8de887fa3b
Hansong Zhang [Fri, 25 Sep 2020 19:17:12 +0000 (12:17 -0700)]
HIDD: Treat unacceptable QOS as normal failure
Bug:
159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I7d37c46f7c6b16a55afafe04b62081d43f63c122