OSDN Git Service
Tom Lane [Thu, 17 Jul 2008 16:02:12 +0000 (16:02 +0000)]
Add dump support for SortBy nodes. Needed this while debugging a reported
problem with DISTINCT, so might as well commit it.
Bruce Momjian [Thu, 17 Jul 2008 01:34:33 +0000 (01:34 +0000)]
Add to TODO:
>
> * Reduce locking requirements for creating a trigger
>
> http://archives.postgresql.org/pgsql-hackers/2008-06/msg00635.php
>
Bruce Momjian [Wed, 16 Jul 2008 21:03:45 +0000 (21:03 +0000)]
Add URL for:
* Implement SQL:2003 window functions
>
> http://archives.postgresql.org/pgsql-hackers/2008-06/msg00380.php
>
Tom Lane [Wed, 16 Jul 2008 19:33:25 +0000 (19:33 +0000)]
Fix previous patch so that it actually works --- consider TRUNCATE foo, public.foo
Tom Lane [Wed, 16 Jul 2008 16:55:24 +0000 (16:55 +0000)]
Add a "provariadic" column to pg_proc to eliminate the remarkably expensive
need to deconstruct proargmodes for each pg_proc entry inspected by
FuncnameGetCandidates(). Fixes function lookup performance regression
caused by yesterday's variadic-functions patch.
In passing, make pg_proc.probin be NULL, rather than a dummy value '-',
in cases where it is not actually used for the particular type of function.
This should buy back some of the space cost of the extra column.
Bruce Momjian [Wed, 16 Jul 2008 16:54:08 +0000 (16:54 +0000)]
Allow TRUNCATE foo, foo to succeed, per report from Nikhils.
Bruce Momjian [Wed, 16 Jul 2008 15:30:19 +0000 (15:30 +0000)]
Add to TODO:
>
> o Add external tool to auto-tune some postgresql.conf parameters
>
> http://archives.postgresql.org/pgsql-hackers/2008-06/msg00000.php
>
Tom Lane [Wed, 16 Jul 2008 01:30:23 +0000 (01:30 +0000)]
Support "variadic" functions, which can accept a variable number of arguments
so long as all the trailing arguments are of the same (non-array) type.
The function receives them as a single array argument (which is why they
have to all be the same type).
It might be useful to extend this facility to aggregates, but this patch
doesn't do that.
This patch imposes a noticeable slowdown on function lookup --- a follow-on
patch will fix that by adding a redundant column to pg_proc.
Pavel Stehule
Bruce Momjian [Wed, 16 Jul 2008 00:48:54 +0000 (00:48 +0000)]
Add array_fill() to create arrays initialized with a value.
Pavel Stehule
Bruce Momjian [Tue, 15 Jul 2008 18:24:59 +0000 (18:24 +0000)]
Fix alignment of SGML array docs.
Bruce Momjian [Tue, 15 Jul 2008 17:45:03 +0000 (17:45 +0000)]
Add Swedish_Sweden.1252 Windows locale example to docs.
Bruce Momjian [Tue, 15 Jul 2008 16:06:06 +0000 (16:06 +0000)]
Addendum: psql sequence value display patch was originally written by
Euler Taveira de Oliveira.
Bruce Momjian [Tue, 15 Jul 2008 15:03:41 +0000 (15:03 +0000)]
Add to TODO:
>
> o Reduce PITR WAL file size by removing full page writes and
> by removing trailing bytes to improve compression
Bruce Momjian [Tue, 15 Jul 2008 13:55:20 +0000 (13:55 +0000)]
Add TODO:
>
> * Consider decreasing the I/O caused by updating tuple hint bits
>
> http://archives.postgresql.org/pgsql-hackers/2008-05/msg00847.php
>
Bruce Momjian [Tue, 15 Jul 2008 03:17:51 +0000 (03:17 +0000)]
Done:
> o -Have psql show current values for a sequence
Bruce Momjian [Tue, 15 Jul 2008 03:16:03 +0000 (03:16 +0000)]
Have psql \d show the value of sequence columns.
Dickson S. Guedes
Bruce Momjian [Tue, 15 Jul 2008 01:35:23 +0000 (01:35 +0000)]
Clarify that locale names on Windows are more verbose.
Report from Martin Saschek
Bruce Momjian [Mon, 14 Jul 2008 23:13:04 +0000 (23:13 +0000)]
Add comment about literal strings in our syntax not being translated in
psql.
Bruce Momjian [Mon, 14 Jul 2008 22:57:21 +0000 (22:57 +0000)]
Add to TODO:
> * Improve ability to modify views via ALTER TABLE
>
> http://archives.postgresql.org/pgsql-hackers/2008-05/msg00691.php
Bruce Momjian [Mon, 14 Jul 2008 22:51:48 +0000 (22:51 +0000)]
Add column storage type to psql \d+ display.
Gregory Stark
Bruce Momjian [Mon, 14 Jul 2008 22:00:04 +0000 (22:00 +0000)]
In psql, rename trans_* variables to translate_*, for clarity.
Bruce Momjian [Mon, 14 Jul 2008 20:54:18 +0000 (20:54 +0000)]
Done:
< * Add temporal versions of generate_series()
> * -Add temporal versions of generate_series()
Bruce Momjian [Mon, 14 Jul 2008 17:54:54 +0000 (17:54 +0000)]
Add URL for:
* Consider allowing control of upper/lower case folding of unquoted
identifiers
> http://archives.postgresql.org/pgsql-hackers/2008-07/msg00415.php
Bruce Momjian [Mon, 14 Jul 2008 17:16:13 +0000 (17:16 +0000)]
Done, per Simon:
< o Fix server restart problem when the server was shutdown during
> o -Fix server restart problem when the server was shutdown during
Tom Lane [Mon, 14 Jul 2008 03:22:32 +0000 (03:22 +0000)]
Clean up buildfarm failures arising from the seemingly straightforward page
macros patch :-(. Results from both baiji and mastodon imply that MSVC
fails to perceive offsetof(PageHeaderData, pd_linp[0]) as a constant
expression in some contexts where offsetof(PageHeaderData, pd_linp) works
fine. Sloth, thy name is Micro.
Tom Lane [Mon, 14 Jul 2008 00:51:46 +0000 (00:51 +0000)]
Create a type-specific typanalyze routine for tsvector, which collects stats
on the most common individual lexemes in place of the mostly-useless default
behavior of counting duplicate tsvectors. Future work: create selectivity
estimation functions that actually do something with these stats.
(Some other things we ought to look at doing: using the Lossy Counting
algorithm in compute_minimal_stats, and using the element-counting idea for
stats on regular arrays.)
Jan Urbanski
Tom Lane [Sun, 13 Jul 2008 21:50:04 +0000 (21:50 +0000)]
Change the PageGetContents() macro to guarantee its result is maxalign'd,
thereby forestalling any problems with alignment of the data structure placed
there. Since SizeOfPageHeaderData is maxalign'd anyway in 8.3 and HEAD, this
does not actually change anything right now, but it is foreseeable that the
header size will change again someday. I had to fix a couple of places that
were assuming that the content offset is just SizeOfPageHeaderData rather than
MAXALIGN(SizeOfPageHeaderData). Per discussion of Zdenek's page-macros patch.
Tom Lane [Sun, 13 Jul 2008 20:45:47 +0000 (20:45 +0000)]
Clean up the use of some page-header-access macros: principally, use
SizeOfPageHeaderData instead of sizeof(PageHeaderData) in places where that
makes the code clearer, and avoid casting between Page and PageHeader where
possible. Zdenek Kotala, with some additional cleanup by Heikki Linnakangas.
I did not apply the parts of the proposed patch that would have resulted in
slightly changing the on-disk format of hash indexes; it seems to me that's
not a win as long as there's any chance of having in-place upgrade for 8.4.
Tom Lane [Sat, 12 Jul 2008 16:20:06 +0000 (16:20 +0000)]
Fix a couple of stray misuses of "binary compatible".
Peter Eisentraut [Sat, 12 Jul 2008 10:44:56 +0000 (10:44 +0000)]
More replacements of binary compatible to binary coercible.
Tom Lane [Sat, 12 Jul 2008 02:28:43 +0000 (02:28 +0000)]
Don't make --enable-cassert turn on RANDOMIZE_ALLOCATED_MEMORY automatically;
it's just too dang expensive. Per recent discussion, but I just got my
nose rubbed in it again while doing some performance checking.
Tom Lane [Sat, 12 Jul 2008 00:44:38 +0000 (00:44 +0000)]
Const-ify the arguments of str_tolower() and friends to suppress compile
warnings. Clean up various unneeded cruft that was left behind after
creating those routines. Introduce some convenience functions str_tolower_z
etc to eliminate tedious and error-prone double arguments in formatting.c.
(Currently there seems no need to export the latter, but maybe reconsider
this later.)
Tom Lane [Fri, 11 Jul 2008 21:06:29 +0000 (21:06 +0000)]
Multi-column GIN indexes. Teodor Sigaev
Teodor Sigaev [Fri, 11 Jul 2008 11:56:48 +0000 (11:56 +0000)]
Add caching of query to GIN/GiST consistent function.
Per performance gripe from nomao.com
Peter Eisentraut [Fri, 11 Jul 2008 07:02:43 +0000 (07:02 +0000)]
Allow binary-coercible types for cast function arguments and return types.
Document return type of cast functions.
Also change documentation to prefer the term "binary coercible" in its
present sense instead of the previous term "binary compatible".
Alvaro Herrera [Fri, 11 Jul 2008 02:10:14 +0000 (02:10 +0000)]
Make sure we only try to free snapshots that have been passed through
CopySnapshot, per Neil Conway. Also add a comment about the assumption in
GetSnapshotData that the argument is statically allocated.
Also, fix some more typos in comments in snapmgr.c.
Neil Conway [Fri, 11 Jul 2008 00:00:29 +0000 (00:00 +0000)]
Fix a few typos in comments in snapmgr.c, and sort header inclusions
alphabetically.
Tom Lane [Thu, 10 Jul 2008 22:08:17 +0000 (22:08 +0000)]
Add unchangeable GUC "variables" segment_size, wal_block_size, and
wal_segment_size to make those configuration parameters available to clients,
in the same way that block_size was previously exposed. Bernd Helmle, with
comments from Abhijit Menon-Sen and some further tweaking by me.
Tom Lane [Thu, 10 Jul 2008 02:14:03 +0000 (02:14 +0000)]
Tighten up SS_finalize_plan's computation of valid_params to exclude Params of
the current query level that aren't in fact output parameters of the current
initPlans. (This means, for example, output parameters of regular subplans.)
To make this work correctly for output parameters coming from sibling
initplans requires rejiggering the API of SS_finalize_plan just a bit:
we need the siblings to be visible to it, rather than hidden as
SS_make_initplan_from_plan had been doing. This is really part of my response
to bug #4290, but I concluded this part probably shouldn't be back-patched,
since all that it's doing is to make a debugging cross-check tighter.
Tom Lane [Thu, 10 Jul 2008 01:17:29 +0000 (01:17 +0000)]
Fix mis-calculation of extParam/allParam sets for plan nodes, as seen in
bug #4290. The fundamental bug is that masking extParam by outer_params,
as finalize_plan had been doing, caused us to lose the information that
an initPlan depended on the output of a sibling initPlan. On reflection
the best thing to do seemed to be not to try to adjust outer_params for
this case but get rid of it entirely. The only thing it was really doing
for us was to filter out param IDs associated with SubPlan nodes, and that
can be done (with greater accuracy) while processing individual SubPlan
nodes in finalize_primnode. This approach was vindicated by the discovery
that the masking method was hiding a second bug: SS_finalize_plan failed to
remove extParam bits for initPlan output params that were referenced in the
main plan tree (it only got rid of those referenced by other initPlans).
It's not clear that this caused any real problems, given the limited use
of extParam by the executor, but it's certainly not what was intended.
I originally thought that there was also a problem with needing to include
indirect dependencies on external params in initPlans' param sets, but it
turns out that the executor handles this correctly so long as the depended-on
initPlan is earlier in the initPlans list than the one using its output.
That seems a bit of a fragile assumption, but it is true at the moment,
so I just documented it in some code comments rather than making what would
be rather invasive changes to remove the assumption.
Back-patch to 8.1. Previous versions don't have the case of initPlans
referring to other initPlans' outputs, so while the existing logic is still
questionable for them, there are not any known bugs to be fixed. So I'll
refrain from changing them for now.
Tom Lane [Wed, 9 Jul 2008 15:56:49 +0000 (15:56 +0000)]
Increase PG_SYSLOG_LIMIT (the max line length sent to syslog()) from 128 to
1024 to improve performance when sending large elog messages. Also add a
comment about why we use that number.
Since this represents an externally visible behavior change, and might
possibly result in portability issues, it seems best not to back-patch it.
Tom Lane [Tue, 8 Jul 2008 22:17:41 +0000 (22:17 +0000)]
Fix performance bug in write_syslog(): the code to preferentially break the
log message at newlines cost O(N^2) for very long messages with few or no
newlines. For messages in the megabyte range this became the dominant cost.
Per gripe from Achilleas Mantzios.
Patch all the way back, since this is a safe change with no portability
risks. I am also thinking of increasing PG_SYSLOG_LIMIT, but that should
be done separately.
Heikki Linnakangas [Tue, 8 Jul 2008 15:11:58 +0000 (15:11 +0000)]
Fix WAL file cutoff point calculation in pg_standby.
Patch by Simon Riggs, per bug report from Ferenc Felhoffer
Neil Conway [Tue, 8 Jul 2008 03:25:42 +0000 (03:25 +0000)]
Minor improvements to the Gin internal documentation.
Bruce Momjian [Tue, 8 Jul 2008 02:07:29 +0000 (02:07 +0000)]
Add comment for deadlock_timeout:
/* This is PGC_SIGHUP so all backends have the same value. */
Tom Lane [Mon, 7 Jul 2008 20:24:55 +0000 (20:24 +0000)]
Fix estimate_num_groups() to assume that GROUP BY expressions yielding boolean
results always contribute two groups, regardless of the expression contents.
This is very substantially more accurate than the regular heuristic for
certain boolean tests like "col IS NULL". Per gripe from Sam Mason.
Back-patch to all supported releases, since the behavior of
estimate_num_groups() hasn't changed all that much since 7.4.
Tom Lane [Mon, 7 Jul 2008 18:09:46 +0000 (18:09 +0000)]
Fix AT TIME ZONE (in all three variants) so that we first try to interpret
the timezone argument as a timezone abbreviation, and only try it as a full
timezone name if that fails. The zic database has four zones (CET, EET, MET,
WET) that are full daylight-savings zones and yet have names that are the
same as their abbreviations for standard time, resulting in ambiguity.
In the timestamp input functions we resolve the ambiguity by preferring the
abbreviation, and AT TIME ZONE should work the same way. (No functionality
is lost because the zic database also has other names for these zones, eg
Europe/Zurich.) Per gripe from Jaromir Talir.
Backpatch to 8.1. Older releases did not have the issue because AT TIME ZONE
only accepted abbreviations not zone names. (Thus, this patch also arguably
fixes a compatibility botch introduced at 8.1: in ambiguous cases we now
behave the same as 8.0 did.)
Peter Eisentraut [Mon, 7 Jul 2008 16:11:35 +0000 (16:11 +0000)]
Added documentation for function xmlagg.
Tom Lane [Sun, 6 Jul 2008 19:48:45 +0000 (19:48 +0000)]
Prevent integer overflows during units conversion when displaying a GUC
variable that has units. Per report from Stefan Kaltenbrunner.
Backport to 8.2. I also backported my patch of 2007-06-21 that prevented
comparable overflows on the input side, since that now seems to have enough
field track record to be back-patched safely. That patch included addition
of hints listing the available unit names, which I did not bother to strip
out of it --- this will make a little more work for the translators, but
they can copy the translation from 8.3, and anyway an untranslated hint
is better than no hint.
Teodor Sigaev [Fri, 4 Jul 2008 13:21:18 +0000 (13:21 +0000)]
Fix initialization of GinScanEntryData.partialMatch
Magnus Hagander [Fri, 4 Jul 2008 10:50:18 +0000 (10:50 +0000)]
Fix a couple of bugs in win32 shmem name generation:
* Don't cut off the prefix. With this fix, it's again readable.
* Properly store it in the Global namespace as intended.
Tom Lane [Thu, 3 Jul 2008 20:58:47 +0000 (20:58 +0000)]
Add a function pg_get_keywords() to let clients find out the set of keywords
known to the SQL parser. Dave Page
Peter Eisentraut [Thu, 3 Jul 2008 16:01:10 +0000 (16:01 +0000)]
Don't refer to the database name "regression" inside the regression test
scripts, to allow running the test successfully with another database name.
Peter Eisentraut [Thu, 3 Jul 2008 15:59:55 +0000 (15:59 +0000)]
Don't print the name of the database in psql \z.
Peter Eisentraut [Thu, 3 Jul 2008 15:36:20 +0000 (15:36 +0000)]
Clean up weird whitespace. Separate patch to simplifiy the next change.
Joe Conway [Thu, 3 Jul 2008 03:56:57 +0000 (03:56 +0000)]
When an ERROR happens on a dblink remote connection, take
pains to pass the ERROR message components locally, including
using the passed SQLSTATE. Also wrap the passed info in an
appropriate CONTEXT message. Addresses complaint by Henry
Combrinck. Joe Conway, with much good advice from Tom Lane.
Tom Lane [Thu, 3 Jul 2008 03:37:17 +0000 (03:37 +0000)]
Fix psql's \d and allied commands to work with all server versions back to 7.4.
Guillaume Lelarge, with some additional fixes by me.
Bruce Momjian [Thu, 3 Jul 2008 02:49:54 +0000 (02:49 +0000)]
Update source code comment about when to use gettext_noop().
Tom Lane [Thu, 3 Jul 2008 00:04:24 +0000 (00:04 +0000)]
Fix transaction-lifespan memory leak in xpath(). Report by Matt Magoffin,
fix by Kris Jurka.
Bruce Momjian [Tue, 1 Jul 2008 21:49:04 +0000 (21:49 +0000)]
Documentation patch by Kevin L. McBride explaining GUC lock variables,
which are available if LOCK_DEBUG is defined.
Tom Lane [Tue, 1 Jul 2008 21:07:33 +0000 (21:07 +0000)]
Remove GUC extra_desc strings that are redundant with the enum value lists.
Bruce Momjian [Tue, 1 Jul 2008 18:26:30 +0000 (18:26 +0000)]
Add URL for:
* Add database and transaction-level triggers
Bruce Momjian [Tue, 1 Jul 2008 18:09:09 +0000 (18:09 +0000)]
Add to TODO:
> * Fix TRUNCATE ... RESTART IDENTITY so its affect on sequences is rolled
> back on transaction abort
Heikki Linnakangas [Tue, 1 Jul 2008 11:46:48 +0000 (11:46 +0000)]
Move volatility, language, etc. modifiers before function body in the pg_dump
output for CREATE FUNCTION. This makes it easier to read especially if the
function body is long.
Original idea and patch by Greg Sabino Mullane, though this is a stripped
down version of that.
Heikki Linnakangas [Tue, 1 Jul 2008 10:33:09 +0000 (10:33 +0000)]
Extend VacAttrStats to allow typanalyze functions to store statistic values
of different types than the underlying column. The capability isn't yet
used for anything, but will be required by upcoming patch to analyze
tsvector columns.
Jan Urbanski
Magnus Hagander [Tue, 1 Jul 2008 06:36:11 +0000 (06:36 +0000)]
"debug" level was supposed to be hidden, since it's just an alias for debug2.
Magnus Hagander [Tue, 1 Jul 2008 06:08:31 +0000 (06:08 +0000)]
Split apart message_level_options into one set for server-side settings and
one for client-side, restoring the previous behaviour with different
sort order for the 'log' level. Also, remove redundant list of available
options, since the enum code will output it automatically.
Tom Lane [Tue, 1 Jul 2008 03:40:55 +0000 (03:40 +0000)]
Fix identify_system_timezone() so that it tests the behavior of the system
timezone setting in the current year and for 100 years back, rather than
always examining years 1904-2004. The original coding would have problems
distinguishing zones whose behavior diverged only after 2004; which is a
situation we will surely face sometime, if it's not out there already.
In passing, also prevent selection of the dummy "Factory" timezone, even
if that's exactly what the system is using. Reporting time as GMT seems
better than that.
Tom Lane [Tue, 1 Jul 2008 02:09:34 +0000 (02:09 +0000)]
Teach autovacuum how to determine whether a temp table belongs to a crashed
backend. If so, send a LOG message to the postmaster log, and if the table
is beyond the vacuum-for-wraparound horizon, forcibly drop it. Per recent
discussions. Perhaps we ought to back-patch this, but it probably needs
to age a bit in HEAD first.
Bruce Momjian [Tue, 1 Jul 2008 00:08:18 +0000 (00:08 +0000)]
Issue psql connection warnings on connection start and via \c, per
observation by David Fetter.
Bruce Momjian [Mon, 30 Jun 2008 22:10:43 +0000 (22:10 +0000)]
Fix recovery.conf boolean variables to take the same range of string
values as postgresql.conf.
Bruce Momjian [Mon, 30 Jun 2008 19:45:15 +0000 (19:45 +0000)]
Add psql TODO:
> o Add "auto" expanded mode that outputs in expanded format if
> "wrapped" mode can't wrap the output to the screen width
>
> http://archives.postgresql.org/pgsql-hackers/2008-05/msg00417.php
>
Bruce Momjian [Mon, 30 Jun 2008 19:41:37 +0000 (19:41 +0000)]
Add psql TODO item:
> o Add option to wrap column values at whitespace boundaries,
> rather than chopping them at a fixed width.
> Currently, "wrapped" format chops values into fixed
> widths. Perhaps the word wrapping could use the same
> algorithm documented in the W3C specification.
> http://archives.postgresql.org/pgsql-hackers/2008-05/msg00404.php
> http://www.w3.org/TR/CSS21/tables.html#auto-table-layout
Teodor Sigaev [Mon, 30 Jun 2008 18:30:48 +0000 (18:30 +0000)]
ltree support for multibyte encodings. Patch was made by
laser <laserlist@pgsqldb.com> with some editorization by me.
Heikki Linnakangas [Mon, 30 Jun 2008 10:58:47 +0000 (10:58 +0000)]
Turn PGBE_ACTIVITY_SIZE into a GUC variable, track_activity_query_size.
As the buffer could now be a lot larger than before, and copying it could
thus be a lot more expensive than before, use strcpy instead of memcpy to
copy the query string, as was already suggested in comments. Also, only copy
the PgBackendStatus struct and string if the slot is in use.
Patch by Thomas Lee, with some changes by me.
Tom Lane [Sun, 29 Jun 2008 21:04:01 +0000 (21:04 +0000)]
Remove unnecessary coziness of GIN code with datum copying. Now that
space is tracked via GetMemoryChunkSpace, there's really no advantage
to duplicating datumCopy's innards here. This is one bit of my toast
indirection patch that should go in anyway.
Tom Lane [Sat, 28 Jun 2008 16:45:22 +0000 (16:45 +0000)]
If pnstrdup is going to be promoted to a generally available function,
it ought to conform to the rest of palloc.h in using Size for sizes.
Tom Lane [Fri, 27 Jun 2008 20:54:37 +0000 (20:54 +0000)]
Consider a clause to be outerjoin_delayed if it references the nullable side
of any lower outer join, even if it also references the non-nullable side and
so could not get pushed below the outer join anyway. We need this in case
the clause is an OR clause: if it doesn't get marked outerjoin_delayed,
create_or_index_quals() could pull an indexable restriction for the nullable
side out of it, leading to wrong results as demonstrated by today's bug
report from toruvinn. (See added regression test case for an example.)
In principle this has been wrong for quite a while. In practice I don't
think any branch before 8.3 can really show the failure, because
create_or_index_quals() will only pull out indexable conditions, and before
8.3 those were always strict. So though we might have improperly generated
null-extended rows in the outer join, they'd get discarded from the result
anyway. The gating factor that makes the failure visible is that 8.3
considers "col IS NULL" to be indexable. Hence I'm not going to risk
back-patching further than 8.3.
Magnus Hagander [Fri, 27 Jun 2008 18:58:14 +0000 (18:58 +0000)]
Fix standalone libpq build on win32.
Hiroshi Saito
Tom Lane [Fri, 27 Jun 2008 03:56:55 +0000 (03:56 +0000)]
Improve planner's estimation of the size of an append relation: rather than
taking the maximum of any child rel's width, we should weight the widths
proportionally to the number of rows expected from each child. In hindsight
this is obviously correct because row width is really a proxy for the total
physical size of the relation. Per discussion with Scott Carey (bug #4264).
Bruce Momjian [Fri, 27 Jun 2008 02:44:31 +0000 (02:44 +0000)]
Mention actual function names in documentation of how to pass binary
values to libpq.
Bruce Momjian [Fri, 27 Jun 2008 02:38:29 +0000 (02:38 +0000)]
Add to TODO:
>
> * Fix system views like pg_stat_all_tables to use set-returning
> functions, rather than views of per-column functions
Tom Lane [Fri, 27 Jun 2008 01:52:59 +0000 (01:52 +0000)]
Clarify plpgsql documentation by not treating IF THEN ELSE IF ... as a
truly distinct version of IF. Per suggestion from Marko Kreen.
Tom Lane [Fri, 27 Jun 2008 00:36:16 +0000 (00:36 +0000)]
Modify the recently-added probe for -Wl,--as-needed some more, because RHEL-4
vintage Linux is even more broken than we realized: a link to libreadline
will succeed, and fail only at runtime. It seems that an AC_TRY_RUN test
is the only reliable way to check whether this is really safe. Per report
from Tatsuo.
Bruce Momjian [Thu, 26 Jun 2008 22:24:42 +0000 (22:24 +0000)]
Use SGML table to show backslash string escapes, rather than have them
appear in a paragraph.
Andy Anderson
Bruce Momjian [Thu, 26 Jun 2008 19:18:37 +0000 (19:18 +0000)]
Add MERGE TODO URL:
> http://archives.postgresql.org/pgsql-hackers/2008-04/msg01890.php
Bruce Momjian [Thu, 26 Jun 2008 18:25:24 +0000 (18:25 +0000)]
Fix pg_ctl bug where detection of binary location from postopts
wasn't working.
Teodor Sigaev [Thu, 26 Jun 2008 16:06:37 +0000 (16:06 +0000)]
Fix bug "select lower('asd') = 'asd'" returns false with multibyte encoding
and non-C locale. Fix is just to use correct source's length for char2wchar
call.
Michael Meskes [Thu, 26 Jun 2008 08:04:05 +0000 (08:04 +0000)]
Synced parser
Bruce Momjian [Thu, 26 Jun 2008 03:58:00 +0000 (03:58 +0000)]
Add TODO about security:
* Improve server security options
http://archives.postgresql.org/pgsql-hackers/2008-04/msg01875.php
http://archives.postgresql.org/pgsql-hackers/2008-05/msg00000.php
Bruce Momjian [Thu, 26 Jun 2008 03:54:28 +0000 (03:54 +0000)]
More FAQ URL updates from Curtis Gallant.
Bruce Momjian [Thu, 26 Jun 2008 03:51:56 +0000 (03:51 +0000)]
Simplify 'pg_ctl restart' detection of first argument in
postmaster.opts.
Bruce Momjian [Thu, 26 Jun 2008 03:02:27 +0000 (03:02 +0000)]
Update FAQ URLs as suggested by Curtis Gallant.
Bruce Momjian [Thu, 26 Jun 2008 02:53:19 +0000 (02:53 +0000)]
Add to TODO:
>
> * Improve LDAP authentication configuration options
>
> http://archives.postgresql.org/pgsql-hackers/2008-04/msg01745.php
Bruce Momjian [Thu, 26 Jun 2008 02:47:19 +0000 (02:47 +0000)]
Fix 'pg_ctl restart' to preserve command-line arguments.
Bruce Momjian [Thu, 26 Jun 2008 01:35:45 +0000 (01:35 +0000)]
Use SYSTEMQUOTE as concatentation to strings, rather than %s printf
patterns, for clarity.
Bruce Momjian [Thu, 26 Jun 2008 01:12:20 +0000 (01:12 +0000)]
Remove use of postmaster.opts.default by pg_ctl.
Tom Lane [Tue, 24 Jun 2008 17:58:27 +0000 (17:58 +0000)]
Reduce the alignment requirement of type "name" from int to char, and arrange
to suppress zero-padding of "name" entries in indexes.
The alignment change is unlikely to save any space, but it is really needed
anyway to make the world safe for our widespread practice of passing plain
old C strings to functions that are declared as taking Name. In the previous
coding, the C compiler was entitled to assume that a Name pointer was
word-aligned; but we were failing to guarantee that. I think the reason
we'd not seen failures is that usually the only thing that gets done with
such a pointer is strcmp(), which is hard to optimize in a way that exploits
word-alignment. Still, some enterprising compiler guy will probably think
of a way eventually, or we might change our code in a way that exposes
more-obvious optimization opportunities.
The padding change is accomplished in one-liner fashion by declaring the
"name" index opclasses to use storage type "cstring" in pg_opclass.h.
Normally btree and hash don't allow a nondefault storage type, because they
don't have any provisions for converting the input datum to another type.
However, because name and cstring are effectively the same thing except for
padding, no conversion is needed --- we only need index_form_tuple() to treat
the datum as being cstring not name, and this is sufficient. This seems to
make for about a one-third reduction in the typical sizes of system catalog
indexes that involve "name" columns, of which we have many.
These two changes are only weakly related, but the alignment change makes
me feel safer that the padding change won't introduce problems, so I'm
committing them together.
Bruce Momjian [Tue, 24 Jun 2008 15:53:24 +0000 (15:53 +0000)]
TODO item done:
< o Prevent pg_dump/pg_restore from being affected by
> o -Prevent pg_dump/pg_restore from being affected by
Tom Lane [Tue, 24 Jun 2008 01:15:36 +0000 (01:15 +0000)]
Oops, make the MSVC build put fmgroids.h where it needs to be.
Per buildfarm results.