OSDN Git Service
Bruce Momjian [Sun, 6 Mar 2011 11:34:58 +0000 (06:34 -0500)]
Improve pg_upgrade relation name check logic for pre-8.4 servers.
Bruce Momjian [Sun, 6 Mar 2011 03:09:35 +0000 (22:09 -0500)]
Update new pg_upgrade comment about pre-8.4 TOAST tables.
Bruce Momjian [Sun, 6 Mar 2011 02:12:21 +0000 (21:12 -0500)]
Restructure pg_upgrade checks because pre-8.4 Postgres did not rename
toast file names to match the new relfilenode.
Bruce Momjian [Sun, 6 Mar 2011 01:18:31 +0000 (20:18 -0500)]
Fix pg_upgrade to print the proper database name for file transfer
failures.
Bruce Momjian [Sun, 6 Mar 2011 00:32:53 +0000 (19:32 -0500)]
Print clearer failure message when pg_upgrade fails due to a fatal
error.
Bruce Momjian [Sat, 5 Mar 2011 23:32:06 +0000 (18:32 -0500)]
Fix parallel gmake for extension directory addition in PL languages.
Andrew Dunstan [Sat, 5 Mar 2011 21:21:37 +0000 (16:21 -0500)]
Add PL extension files to MSVC Install procedure.
Tom Lane [Sat, 5 Mar 2011 20:34:10 +0000 (15:34 -0500)]
Adjust documentation about pg_pltemplate to reflect latest thinking.
It's more likely that pg_pltemplate will go away in the future than
that we'll add additional specialized infrastructure for it.
Tom Lane [Sat, 5 Mar 2011 20:13:15 +0000 (15:13 -0500)]
Make plpythonu language use plpython2 shared library directly.
The original scheme for this was to symlink plpython.$DLSUFFIX to
plpython2.$DLSUFFIX, but that doesn't work on Windows, and only
accidentally failed to fail because of the way that CREATE LANGUAGE created
or didn't create new C functions. My changes of yesterday exposed the
weakness of that approach. To fix, get rid of the symlink and make
pg_pltemplate show what's really going on.
Tom Lane [Sat, 5 Mar 2011 19:03:06 +0000 (14:03 -0500)]
Convert createlang/droplang to use CREATE/DROP EXTENSION.
In createlang this is a one-line change. In droplang there's a whole
lot of cruft that can be discarded since the extension mechanism now
manages removal of the language's support functions.
Also, add deprecation notices to these two programs' reference pages,
since per discussion we may toss them overboard altogether in a release
or two.
Robert Haas [Sat, 5 Mar 2011 18:00:54 +0000 (13:00 -0500)]
Remove one copy of duplicated alpha4 release note.
Noted by Andy Colson
Peter Eisentraut [Sat, 5 Mar 2011 14:50:03 +0000 (16:50 +0200)]
Update of SQL feature conformance
Robert Haas [Sat, 5 Mar 2011 14:53:05 +0000 (09:53 -0500)]
Add missing word.
Robert Haas [Sat, 5 Mar 2011 14:36:19 +0000 (09:36 -0500)]
First cut at 9.1alpha4 release notes.
Robert Haas [Sat, 5 Mar 2011 12:36:35 +0000 (07:36 -0500)]
Remove emphasis from 9.1alpha3 items.
In preparation for 9.1alpha4 release notes, where only the 9.1alpha4
features will be emphasized.
Tom Lane [Sat, 5 Mar 2011 06:08:38 +0000 (01:08 -0500)]
Update documentation to reflect that standard PLs are now extensions.
Recommend use of CREATE EXTENSION rather than plain CREATE LANGUAGE
where relevant. Encourage PL authors to provide extension wrappers
for their PLs.
Tom Lane [Sat, 5 Mar 2011 02:51:14 +0000 (21:51 -0500)]
Create extension infrastructure for the core procedural languages.
This mostly just involves creating control, install, and
update-from-unpackaged scripts for them. However, I had to adjust plperl
and plpython to not share the same support functions between variants,
because we can't put the same function into multiple extensions.
catversion bump forced due to new contents of pg_pltemplate, and because
initdb now installs plpgsql as an extension not a bare language.
Add support for regression testing these as extensions not bare
languages.
Fix a couple of other issues that popped up while testing this: my initial
hack at pg_dump binary-upgrade support didn't work right, and we don't want
an extra schema permissions test after all.
Documentation changes still to come, but I'm committing now to see
whether the MSVC build scripts need work (likely they do).
Robert Haas [Fri, 4 Mar 2011 22:26:37 +0000 (17:26 -0500)]
Refactor seclabel.c to use the new check_object_ownership function.
This avoids duplicate (and not-quite-matching) code, and makes the logic
for SECURITY LABEL match COMMENT and ALTER EXTENSION ADD/DROP.
Peter Eisentraut [Fri, 4 Mar 2011 21:39:44 +0000 (23:39 +0200)]
Don't allow CREATE TABLE AS to create a column with invalid collation
It is possible that an expression ends up with a collatable type but
without a collation. CREATE TABLE AS could then create a table based
on that. But such a column cannot be dumped with valid SQL syntax, so
we disallow creating such a column.
per test report from Noah Misch
Tom Lane [Fri, 4 Mar 2011 21:08:24 +0000 (16:08 -0500)]
Allow non-superusers to create (some) extensions.
Remove the unconditional superuser permissions check in CREATE EXTENSION,
and instead define a "superuser" extension property, which when false
(not the default) skips the superuser permissions check. In this case
the calling user only needs enough permissions to execute the commands
in the extension's installation script. The superuser property is also
enforced in the same way for ALTER EXTENSION UPDATE cases.
In other ALTER EXTENSION cases and DROP EXTENSION, test ownership of
the extension rather than superuserness. ALTER EXTENSION ADD/DROP needs
to insist on ownership of the target object as well; to do that without
duplicating code, refactor comment.c's big switch for permissions checks
into a separate function in objectaddress.c.
I also removed the superuserness checks in pg_available_extensions and
related functions; there's no strong reason why everybody shouldn't
be able to see that info.
Also invent an IF NOT EXISTS variant of CREATE EXTENSION, and use that
in pg_dump, so that dumps won't fail for installed-by-default extensions.
We don't have any of those yet, but we will soon.
This is all per discussion of wrapping the standard procedural languages
into extensions. I'll make those changes in a separate commit; this is
just putting the core infrastructure in place.
Peter Eisentraut [Fri, 4 Mar 2011 20:14:37 +0000 (22:14 +0200)]
When creating a collation, check that the locales can be loaded
This is the same check that would happen later when the collation is
used, but it's friendlier to check the collation already when it is
created.
Tom Lane [Fri, 4 Mar 2011 16:38:45 +0000 (11:38 -0500)]
In initialize_SSL, don't fail unnecessarily when home dir is unavailable.
Instead, just act as though the certificate file(s) are not present.
There is only one case where this need be a hard failure condition: when
sslmode is verify-ca or verify-full, not having a root cert file is an
error. Change the logic so that we complain only in that case, and
otherwise fall through cleanly. This is how it used to behave pre-9.0,
but my patch
4ed4b6c54e5fab24ab2624d80e26f7546edc88ad of 2010-05-26 broke
the case. Per report from Christian Kastner.
Heikki Linnakangas [Fri, 4 Mar 2011 13:37:09 +0000 (15:37 +0200)]
You must hold a lock on the heap page when you call
CheckForSerializableConflictOut(), because it can set hint bits.
YAMAMOTO Takashi
Andrew Dunstan [Fri, 4 Mar 2011 00:41:54 +0000 (19:41 -0500)]
Add a comment explaining the recent fix for plpython breakage in commit
4c966d9.
Mostly text supplied by Jan Urbański.
Tom Lane [Thu, 3 Mar 2011 20:55:47 +0000 (15:55 -0500)]
Further refine patch for commenting operator implementation functions.
Instead of manually maintaining the "implementation of XXX operator"
comments in pg_proc.h, delete all those entries and let initdb create
them via a join. To let initdb figure out which name to use when there
is a conflict, change the comments for deprecated operators to say they
are deprecated --- which seems like a good thing to do anyway.
Tom Lane [Thu, 3 Mar 2011 18:22:18 +0000 (13:22 -0500)]
Fix citext's upgrade-from-unpackaged script to set its collation correctly.
Although there remains some debate about how CREATE TYPE should represent
the collation property, this doesn't really affect what we need to do in
citext's script, so go ahead and fix that.
Tom Lane [Thu, 3 Mar 2011 18:03:34 +0000 (13:03 -0500)]
Run a portal's cleanup hook immediately when pushing it to DONE state.
This works around the problem noted by Yamamoto Takashi in bug #5906,
that there were code paths whereby we could reach AtCleanup_Portals
with a portal's cleanup hook still unexecuted. The changes I made
a few days ago were intended to prevent that from happening, and
I think that on balance it's still a good thing to avoid, so I don't
want to remove the Assert in AtCleanup_Portals. Hence do this instead.
Michael Meskes [Thu, 3 Mar 2011 12:43:50 +0000 (13:43 +0100)]
Added new version of ecpg's parser generator script. This one was written by
Andy Colson <andy@squeakycode.net>.
Heikki Linnakangas [Thu, 3 Mar 2011 07:42:02 +0000 (09:42 +0200)]
Add tab-completion for table name after JOIN.
Andrey Popp
Tom Lane [Thu, 3 Mar 2011 06:43:38 +0000 (01:43 -0500)]
Add -lm to SHLIB_LINK for contrib/btree_gist.
Now that btree_gist contains a reference to isinf(), this is necessary
at least on some platforms. Per buildfarm.
Tom Lane [Thu, 3 Mar 2011 06:33:19 +0000 (01:33 -0500)]
Mark operator implementation functions as such in their comments.
Historically, we've not had separate comments for built-in pg_operator
entries, but relied on the comments for the underlying functions. The
trouble with this approach is that there isn't much of anything to suggest
to users that they'd be better off using the operators instead. So, move
all the relevant comments into pg_operator, and give each underlying
function a comment that just says "implementation of XXX operator".
There are only about half a dozen cases where it seems reasonable to use
the underlying function interchangeably with the operator; in these cases
I left the same comment in place on the function as on the operator.
While at it, establish a policy that every built-in function and operator
entry should have a comment: there are now queries in the opr_sanity
regression test that will complain if one doesn't. This only required
adding a dozen or two more entries than would have been there anyway.
I also spent some time trying to eliminate gratuitous inconsistencies in
the style of the comments, though it's hopeless to suppose that more won't
creep in soon enough.
Per my proposal of 2010-10-15.
Peter Eisentraut [Wed, 2 Mar 2011 21:10:41 +0000 (23:10 +0200)]
Add collations to information_schema.usage_privileges
This is faked information like for domains.
Tom Lane [Wed, 2 Mar 2011 21:11:05 +0000 (16:11 -0500)]
Add 'collatable' to the Parameters section of CREATE TYPE.
Tom Lane [Wed, 2 Mar 2011 19:43:24 +0000 (14:43 -0500)]
Add KNNGIST support to contrib/btree_gist.
This extends GiST's support for nearest-neighbor searches to many of the
standard data types.
Teodor Sigaev
Peter Eisentraut [Wed, 2 Mar 2011 19:15:28 +0000 (21:15 +0200)]
Support for DragonFly BSD
Mapped to NetBSD, the closest existing match. (Even though DragonFly
BSD is derived from FreeBSD, the shared library version numbering
matches NetBSD, and the rest is mostly the same among all BSD
variants.)
per "Rumko"
Tom Lane [Wed, 2 Mar 2011 16:39:18 +0000 (11:39 -0500)]
Fix erroneous documentation of the syntax of CREATE CONSTRAINT TRIGGER.
The grammar requires a specific ordering of the clauses, but the
documentation showed a different order. This error was introduced in
commit
b47953f9c69d48a9261bd643e3170017b93f6337, which merged the CREATE
CONSTRAINT TRIGGER documentation into the CREATE TRIGGER page. There is
no code bug AFAICS.
Tom Lane [Wed, 2 Mar 2011 16:17:03 +0000 (11:17 -0500)]
Correct mistaken claims about EXPLAIN ANALYZE's handling of triggers.
Time spent executing AFTER triggers is not included in the runtime of the
associated ModifyTable node; in my patch of yesterday I confused queuing of
these triggers with their actual execution. Spotted by Marko Tiikkaja.
Andrew Dunstan [Tue, 1 Mar 2011 23:59:31 +0000 (18:59 -0500)]
Fix plpython breakage detected on certain Fedora machines on buildfarm.
Patch from Jan Urbański.
Peter Eisentraut [Tue, 1 Mar 2011 21:35:18 +0000 (23:35 +0200)]
Additional PL/Python regression test expected file
plpython_subtransaction test needs a separate expected file
specifically for Python 2.5.
Heikki Linnakangas [Tue, 1 Mar 2011 18:46:57 +0000 (20:46 +0200)]
Change pg_last_xlog_receive_location() not to move backwards. That makes
it a lot more useful for determining which standby is most up-to-date,
for example. There was long discussions on whether overwriting existing
existing WAL makes sense to begin with, and whether we should do some more
extensive variable renaming, but this change nevertheless seems quite
uncontroversial.
Fujii Masao, reviewed by Jeff Janes, Robert Haas, Stephen Frost.
Heikki Linnakangas [Tue, 1 Mar 2011 17:05:16 +0000 (19:05 +0200)]
Fix bugs in Serializable Snapshot Isolation.
Change the way UPDATEs are handled. Instead of maintaining a chain of
tuple-level locks in shared memory, copy any existing locks on the old
tuple to the new tuple at UPDATE. Any existing page-level lock needs to
be duplicated too, as a lock on the new tuple. That was neglected
previously.
Store xmin on tuple-level predicate locks, to distinguish a lock on an old
already-recycled tuple from a new tuple at the same physical location.
Failure to distinguish them caused loops in the tuple-lock chains, as
reported by YAMAMOTO Takashi. Although we don't use the chain representation
of UPDATEs anymore, it seems like a good idea to store the xmin to avoid
some false positives if no other reason.
CheckSingleTargetForConflictsIn now correctly handles the case where a lock
that's being held is not reflected in the local lock table. That happens
if another backend acquires a lock on our behalf due to an UPDATE or a page
split.
PredicateLockPageCombine now retains locks for the page that is being
removed, rather than removing them. This prevents a potentially dangerous
false-positive inconsistency where the local lock table believes that a lock
is held, but it is actually not.
Dan Ports and Kevin Grittner
Peter Eisentraut [Tue, 1 Mar 2011 16:45:34 +0000 (18:45 +0200)]
Dump the COLLATABLE attribute in CREATE TYPE
This was previously omitted by accident.
Tom Lane [Tue, 1 Mar 2011 16:36:01 +0000 (11:36 -0500)]
Update discussion of EXPLAIN to reflect existence of ModifyTable nodes.
Back-patch to 9.0, since this was changed then.
Tom Lane [Tue, 1 Mar 2011 16:32:13 +0000 (11:32 -0500)]
Include the target table in EXPLAIN output for ModifyTable nodes.
Per discussion, this seems important for plans involving writable CTEs,
since there can now be more than one ModifyTable node in the plan.
To retain the same formatting as for target tables of scan nodes, we
show only one target table, which will be the parent table in case of
an UPDATE or DELETE on an inheritance tree. Individual child tables
can be determined by inspecting the child plan trees if needed.
Robert Haas [Tue, 1 Mar 2011 16:32:23 +0000 (11:32 -0500)]
Avoid excessive Hot Standby feedback messages.
Without this patch, when wal_receiver_status_interval=0, indicating that no
status messages should be sent, Hot Standby feedback messages are instead sent
extremely frequently.
Fujii Masao, with documentation changes by me.
Tom Lane [Tue, 1 Mar 2011 04:27:18 +0000 (23:27 -0500)]
Rearrange snapshot handling to make rule expansion more consistent.
With this patch, portals, SQL functions, and SPI all agree that there
should be only a CommandCounterIncrement between the queries that are
generated from a single SQL command by rule expansion. Fetching a whole
new snapshot now happens only between original queries. This is equivalent
to the existing behavior of EXPLAIN ANALYZE, and it was judged to be the
best choice since it eliminates one source of concurrency hazards for
rules. The patch should also make things marginally faster by reducing the
number of snapshot push/pop operations.
The patch removes pg_parse_and_rewrite(), which is no longer used anywhere.
There was considerable discussion about more aggressive refactoring of the
query-processing functions exported by postgres.c, but for the moment
nothing more has been done there.
I also took the opportunity to refactor snapmgr.c's API slightly: the
former PushUpdatedSnapshot() has been split into two functions.
Marko Tiikkaja, reviewed by Steve Singer and Tom Lane
Andrew Dunstan [Tue, 1 Mar 2011 02:31:39 +0000 (21:31 -0500)]
Robert Haas [Mon, 28 Feb 2011 17:48:46 +0000 (12:48 -0500)]
Rename pg_stat_replication.apply_location to replay_location.
For consistency with pg_last_xlog_replay_location. Per discussion.
Peter Eisentraut [Mon, 28 Feb 2011 17:43:36 +0000 (19:43 +0200)]
Fix regression tests after PL/Python custom SPI exceptions patch
Peter Eisentraut [Mon, 28 Feb 2011 16:41:10 +0000 (18:41 +0200)]
PL/Python custom SPI exceptions
This provides a separate exception class for each error code that the
backend defines, as well as the ability to get the SQLSTATE from the
exception object.
Jan Urbański, reviewed by Steve Singer
Tom Lane [Mon, 28 Feb 2011 06:17:18 +0000 (01:17 -0500)]
Add documentation for data-modifying statements in WITH clauses.
Marko Tiikkaja, somewhat reworked by Tom
Bruce Momjian [Sun, 27 Feb 2011 23:03:49 +0000 (18:03 -0500)]
Document that last vacuum statistics and counts are for non-FULL vacuums.
Peter Eisentraut [Sun, 27 Feb 2011 15:09:56 +0000 (17:09 +0200)]
PL/Python explicit subtransactions
Adds a context manager, obtainable by plpy.subtransaction(), to run a
group of statements in a subtransaction.
Jan Urbański, reviewed by Steve Singer, additional scribbling by me
Peter Eisentraut [Sun, 27 Feb 2011 12:00:19 +0000 (14:00 +0200)]
Remove remaining expected file for Python 2.2
We don't have complete expected coverage for Python 2.2 anyway, so it
doesn't seem worth keeping this one around that no one appears to be
updating anyway. Visual inspection of the differences ought to be
good enough for those few who care about this obsolete Python version.
Tom Lane [Sun, 27 Feb 2011 18:43:29 +0000 (13:43 -0500)]
Refactor the executor's API to support data-modifying CTEs better.
The originally committed patch for modifying CTEs didn't interact well
with EXPLAIN, as noted by myself, and also had corner-case problems with
triggers, as noted by Dean Rasheed. Those problems show it is really not
practical for ExecutorEnd to call any user-defined code; so split the
cleanup duties out into a new function ExecutorFinish, which must be called
between the last ExecutorRun call and ExecutorEnd. Some Asserts have been
added to these functions to help verify correct usage.
It is no longer necessary for callers of the executor to call
AfterTriggerBeginQuery/AfterTriggerEndQuery for themselves, as this is now
done by ExecutorStart/ExecutorFinish respectively. If you really need to
suppress that and do it for yourself, pass EXEC_FLAG_SKIP_TRIGGERS to
ExecutorStart.
Also, refactor portal commit processing to allow for the possibility that
PortalDrop will invoke user-defined code. I think this is not actually
necessary just yet, since the portal-execution-strategy logic forces any
non-pure-SELECT query to be run to completion before we will consider
committing. But it seems like good future-proofing.
Bruce Momjian [Sun, 27 Feb 2011 17:21:25 +0000 (12:21 -0500)]
Be less detailed about reporting shared memory failure by avoiding the
output of actual Postgres parameter _values_ related to shared memory,
and suggesting that these are only possible parameters to reduce.
Magnus Hagander [Sun, 27 Feb 2011 11:35:31 +0000 (12:35 +0100)]
Fix verbose display of REPLICATION role attribute
Josh Kupershmidt
Bruce Momjian [Sun, 27 Feb 2011 08:50:12 +0000 (03:50 -0500)]
Fix markup for pg_options_to_table() to report the return column names,
per suggestion from Andrew.
Heikki Linnakangas [Sat, 26 Feb 2011 21:36:24 +0000 (23:36 +0200)]
Increase the default for wal_sender_delay from 200ms to 1s. Now that WAL
sender is immediately woken up by transaction commit, there's no need to
wake up so aggressively.
Andrew Dunstan [Sat, 26 Feb 2011 19:17:57 +0000 (14:17 -0500)]
Add a configure check for Python.h if building with python.
Bruce Momjian [Sat, 26 Feb 2011 17:47:29 +0000 (12:47 -0500)]
Document that pg_options_to_table() also works for
pg_attribute.attoptions.
Bruce Momjian [Sat, 26 Feb 2011 17:26:25 +0000 (12:26 -0500)]
Fix doc patch --- pg_options_to_table() returns "setof record".
Peter Eisentraut [Sat, 26 Feb 2011 14:53:11 +0000 (16:53 +0200)]
Table function support for PL/Python
This allows functions with multiple OUT parameters returning both one
or multiple records (RECORD or SETOF RECORD).
Jan Urbański, reviewed by Hitoshi Harada
Bruce Momjian [Sat, 26 Feb 2011 06:55:26 +0000 (01:55 -0500)]
Document pg_options_to_table() (not previously documented)
Tom Lane [Sat, 26 Feb 2011 04:53:34 +0000 (23:53 -0500)]
Fix order of shutdown processing when CTEs contain inter-references.
We need ExecutorEnd to run the ModifyTable nodes to completion in
reverse order of initialization, not forward order. Easily done
by constructing the list back-to-front.
Tom Lane [Fri, 25 Feb 2011 23:56:23 +0000 (18:56 -0500)]
Support data-modifying commands (INSERT/UPDATE/DELETE) in WITH.
This patch implements data-modifying WITH queries according to the
semantics that the updates all happen with the same command counter value,
and in an unspecified order. Therefore one WITH clause can't see the
effects of another, nor can the outer query see the effects other than
through the RETURNING values. And attempts to do conflicting updates will
have unpredictable results. We'll need to document all that.
This commit just fixes the code; documentation updates are waiting on
author.
Marko Tiikkaja and Hitoshi Harada
Alvaro Herrera [Fri, 25 Feb 2011 22:39:02 +0000 (19:39 -0300)]
Update pageinspect--1.0.sql to match the upgrade script
Per comment from Tom
Alvaro Herrera [Fri, 25 Feb 2011 22:04:25 +0000 (19:04 -0300)]
Fix pageinspect's heap_page_item to return infomasks as 32 bit values
HeapTupleHeader's t_infomask and t_infomask2 are defined as 16-bit
unsigned integers, so when the 16th bit was set, heap_page_item was
returning them as negative values, which was ugly.
The change to pageinspect--unpackaged--1.0.sql allows a module upgraded
from 9.0 to be cleanly updated from the previous definition.
Robert Haas [Thu, 24 Feb 2011 23:58:38 +0000 (18:58 -0500)]
Named restore point improvements.
Emit a log message when creating a named restore point, and improve
documentation for pg_create_restore_point().
Euler Taveira de Oliveira, per suggestions from Thom Brown, with some
additional wordsmithing by me.
Itagaki Takahiro [Thu, 24 Feb 2011 12:05:40 +0000 (21:05 +0900)]
More psql tab-completion for new commands.
- ALTER FOREIGN DATA WRAPPER with HANDLER
- ALTER TABLE VALIDATE CONSTRAINT
- ALTER TYPE ADD VALUE
- COPY with ENCODING and FORCE NOT NULL
- CREATE FOREIGN DATA WRAPPER with HANDLER
- CREATE TRIGGER ... INSTEAD OF
Itagaki Takahiro [Thu, 24 Feb 2011 01:13:27 +0000 (10:13 +0900)]
Add tab-completion for CREATE UNLOGGED TABLE in psql,
and fix unexpected completion for DROP TEMP and UNIQUE.
Bruce Momjian [Wed, 23 Feb 2011 04:31:45 +0000 (23:31 -0500)]
Update wording about information schema and name which views potentially
can have duplicates, per request from Tom.
Itagaki Takahiro [Wed, 23 Feb 2011 00:54:32 +0000 (09:54 +0900)]
Make the second words lowercase in psql's \d titles for unlogged tables.
Tom Lane [Wed, 23 Feb 2011 00:23:23 +0000 (19:23 -0500)]
Add a relkind field to RangeTblEntry to avoid some syscache lookups.
The recent additions for FDW support required checking foreign-table-ness
in several places in the parse/plan chain. While it's not clear whether
that would really result in a noticeable slowdown, it seems best to avoid
any performance risk by keeping a copy of the relation's relkind in
RangeTblEntry. That might have some other uses later, anyway.
Per discussion.
Peter Eisentraut [Tue, 22 Feb 2011 21:33:44 +0000 (23:33 +0200)]
Add PL/Python functions for quoting strings
Add functions plpy.quote_ident, plpy.quote_literal,
plpy.quote_nullable, which wrap the equivalent SQL functions.
To be able to propagate char * constness properly, make the argument
of quote_literal_cstr() const char *. This also makes it more
consistent with quote_identifier().
Jan Urbański, reviewed by Hitoshi Harada, some refinements by Peter
Eisentraut
Robert Haas [Tue, 22 Feb 2011 19:42:45 +0000 (14:42 -0500)]
Fix a couple of unlogged tables goofs.
"SELECT ... INTO UNLOGGED tabname" works, but wasn't documented; CREATE
UNLOGGED SEQUENCE and CREATE UNLOGGED VIEW failed an assertion, instead
of throwing a sensible error.
Latter issue reported by Itagaki Takahiro; patch review by Tom Lane.
Tom Lane [Tue, 22 Feb 2011 18:08:22 +0000 (13:08 -0500)]
Allow binary I/O of type "void".
void_send is useful for the same reason that void_out doesn't throw error,
namely that someone might do "select void_returning_func(...)" from a
client that prefers to operate in binary mode. The void_recv function may
or may not have any practical use, but we provide it for symmetry.
Radosław Smogura
Bruce Momjian [Tue, 22 Feb 2011 14:06:18 +0000 (09:06 -0500)]
Reword information_schema duplicate constraint warning text.
Tom Lane [Tue, 22 Feb 2011 02:41:08 +0000 (21:41 -0500)]
Remove ExecRemoveJunk(), which is no longer used anywhere.
This was a leftover from the pre-8.1 design of junkfilters. It doesn't
seem to have any reason to live, since it's merely a combination of two
easy function calls, and not a well-designed combination at that (it
encourages callers to leak the result tuple).
Tom Lane [Tue, 22 Feb 2011 02:18:04 +0000 (21:18 -0500)]
Fix dangling-pointer problem in before-row update trigger processing.
ExecUpdate checked for whether ExecBRUpdateTriggers had returned a new
tuple value by seeing if the returned tuple was pointer-equal to the old
one. But the "old one" was in estate->es_junkFilter's result slot, which
would be scribbled on if we had done an EvalPlanQual update in response to
a concurrent update of the target tuple; therefore we were comparing a
dangling pointer to a live one. Given the right set of circumstances we
could get a false match, resulting in not forcing the tuple to be stored in
the slot we thought it was stored in. In the case reported by Maxim Boguk
in bug #5798, this led to "cannot extract system attribute from virtual
tuple" failures when trying to do "RETURNING ctid". I believe there is a
very-low-probability chance of more serious errors, such as generating
incorrect index entries based on the original rather than the
trigger-modified version of the row.
In HEAD, change all of ExecBRInsertTriggers, ExecIRInsertTriggers,
ExecBRUpdateTriggers, and ExecIRUpdateTriggers so that they continue to
have similar APIs. In the back branches I just changed
ExecBRUpdateTriggers, since there is no bug in the ExecBRInsertTriggers
case.
Bruce Momjian [Tue, 22 Feb 2011 01:14:02 +0000 (20:14 -0500)]
Move information_schema duplicate constraint note to the top of the
information schema documentation because it affects several tables.
Bruce Momjian [Mon, 21 Feb 2011 14:15:09 +0000 (09:15 -0500)]
Update docs about new role privileges reference, per Alvaro.
Itagaki Takahiro [Mon, 21 Feb 2011 07:26:58 +0000 (16:26 +0900)]
Fix pg_server_to_client, that was broken in the previous commit.
Itagaki Takahiro [Mon, 21 Feb 2011 05:08:04 +0000 (14:08 +0900)]
Add ENCODING option to COPY TO/FROM and file_fdw.
File encodings can be specified separately from client encoding.
If not specified, client encoding is used for backward compatibility.
Cases when the encoding doesn't match client encoding are slower
than matched cases because we don't have conversion procs for other
encodings. Performance improvement would be be a future work.
Original patch by Hitoshi Harada, and modified by me.
Bruce Momjian [Mon, 21 Feb 2011 03:20:57 +0000 (22:20 -0500)]
Merge two documentation permission chapters into a single chapter.
Tom Lane [Sun, 20 Feb 2011 19:55:07 +0000 (14:55 -0500)]
Minor logic fix for new levenshtein implementation.
Alexander Korotkov
Tom Lane [Sun, 20 Feb 2011 19:06:59 +0000 (14:06 -0500)]
Add contrib/file_fdw foreign-data wrapper for reading files via COPY.
This is both very useful in its own right, and an important test case
for the core FDW support.
This commit includes a small refactoring of copy.c to expose its option
checking code as a separately callable function. The original patch
submission duplicated hundreds of lines of that code, which seemed pretty
unmaintainable.
Shigeru Hanada, reviewed by Itagaki Takahiro and Tom Lane
Tom Lane [Sun, 20 Feb 2011 05:17:18 +0000 (00:17 -0500)]
Implement an API to let foreign-data wrappers actually be functional.
This commit provides the core code and documentation needed. A contrib
module test case will follow shortly.
Shigeru Hanada, Jan Urbanski, Heikki Linnakangas
Bruce Momjian [Sun, 20 Feb 2011 05:01:08 +0000 (00:01 -0500)]
Adjust documentation wording of window function ORDER BY to not mention
avg() because it was inaccurate.
Bruce Momjian [Sun, 20 Feb 2011 00:00:19 +0000 (19:00 -0500)]
Documentation update for UTF16 surrogate pairs in UTF8 encoding.
Marko Kreen
Bruce Momjian [Sat, 19 Feb 2011 23:21:03 +0000 (18:21 -0500)]
Document that an SQL-standard-compliant query that expects a unique row
from information_schema.referential_constraints might return several in
Postgres because we allow duplicate-named constraints in the same
schema.
Peter Eisentraut [Sat, 19 Feb 2011 14:52:24 +0000 (16:52 +0200)]
Invalidate PL/Python functions with composite type argument when the
type changes.
The invalidation will cause the type information to be refetched, and
everything will work.
Jan Urbański, reviewed by Alex Hunsaker
Bruce Momjian [Sat, 19 Feb 2011 13:14:32 +0000 (08:14 -0500)]
Initialize variable to quiet compiler.
Peter Eisentraut [Sat, 19 Feb 2011 06:54:58 +0000 (08:54 +0200)]
Set psql client encoding from locale by default
Add a new libpq connection option client_encoding (which includes the
existing PGCLIENTENCODING environment variable), which besides an
encoding name accepts a special value "auto" that tries to determine
the encoding from the locale in the client's environment, using the
mechanisms that have been in use in initdb.
psql sets this new connection option to "auto" when running from a
terminal and not overridden by setting PGCLIENTENCODING.
original code by Heikki Linnakangas, with subsequent contributions by
Jaime Casanova, Peter Eisentraut, Stephen Frost, Ibrar Ahmed
Tom Lane [Sat, 19 Feb 2011 05:06:18 +0000 (00:06 -0500)]
Create the catalog infrastructure for foreign-data-wrapper handlers.
Add a fdwhandler column to pg_foreign_data_wrapper, plus HANDLER options
in the CREATE FOREIGN DATA WRAPPER and ALTER FOREIGN DATA WRAPPER commands,
plus pg_dump support for same. Also invent a new pseudotype fdw_handler
with properties similar to language_handler.
This is split out of the "FDW API" patch for ease of review; it's all stuff
we will certainly need, regardless of any other details of the FDW API.
FDW handler functions will not actually get called yet.
In passing, fix some omissions and infelicities in foreigncmds.c.
Shigeru Hanada, Jan Urbanski, Heikki Linnakangas
Bruce Momjian [Sat, 19 Feb 2011 04:23:52 +0000 (23:23 -0500)]
Improve text search prefix doc addition.
Bruce Momjian [Sat, 19 Feb 2011 03:39:17 +0000 (22:39 -0500)]
Document that text search comparisons happen after text search
configuration rules.
Erik Rijkers
Tom Lane [Fri, 18 Feb 2011 19:05:42 +0000 (14:05 -0500)]
Un-break building with BTREE_BUILD_STATS.
This has been broken for awhile, but not clear it's worth back-patching.
Euler Taveira de Oliveira
Tom Lane [Fri, 18 Feb 2011 18:11:45 +0000 (13:11 -0500)]
Fix parallel pg_restore to handle comments on POST_DATA items correctly.
The previous coding would try to process all SECTION_NONE items in the
initial sequential-restore pass, which failed if they were dependencies of
not-yet-restored items. Fix by postponing such items into the parallel
processing pass once we have skipped any non-PRE_DATA item.
Back-patch into 9.0; the original parallel-restore coding in 8.4 did not
have this bug, so no need to change it.
Report and diagnosis by Arnd Hannemann.
Tom Lane [Fri, 18 Feb 2011 16:55:57 +0000 (11:55 -0500)]
One more hack to make contrib upgrades from 9.0 match fresh 9.1 installs.
intarray and tsearch2 both reference core support functions in their GIN
opclasses, and the signatures of those functions changed for 9.1. We added
backwards-compatible pg_proc entries for the functions in order to allow
9.0 dump files to be restored at all, but that hack leaves the opclasses
pointing at pg_proc entries different from what they'd point to if the
contrib modules were installed fresh in 9.1. To forestall any possibility
of future problems, fix the opclasses to match fresh installs via the
expedient of direct UPDATEs on pg_amproc in the update-from-unpackaged
scripts. (Yech ... but the alternatives are worse, or require far more
effort than seems justified right now.)
Note: updating pg_amproc is sufficient because there will be no pg_depend
entries corresponding to these dependencies, since the referenced functions
are all pinned.