OSDN Git Service

kde/Katie.git
3 years agoproperly initialize QEventDispatcherUNIXPrivate members
Ivailo Monev [Thu, 21 Jan 2021 19:44:44 +0000 (21:44 +0200)]
properly initialize QEventDispatcherUNIXPrivate members

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoREADME update [ci skip]
Ivailo Monev [Thu, 21 Jan 2021 15:50:20 +0000 (17:50 +0200)]
README update [ci skip]

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agofix alpha detection in fix_color_table()
Ivailo Monev [Thu, 21 Jan 2021 02:11:08 +0000 (04:11 +0200)]
fix alpha detection in fix_color_table()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove shared pointer tracking leftovers
Ivailo Monev [Wed, 20 Jan 2021 23:45:35 +0000 (01:45 +0200)]
remove shared pointer tracking leftovers

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoreview build macro comments
Ivailo Monev [Wed, 20 Jan 2021 23:07:27 +0000 (01:07 +0200)]
review build macro comments

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agopthread_attr_setstacksize() is standardized by POSIX.1-2001, do not check for it
Ivailo Monev [Wed, 20 Jan 2021 22:56:58 +0000 (00:56 +0200)]
pthread_attr_setstacksize() is standardized by POSIX.1-2001, do not check for it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agofeclearexcept() is standardized by POSIX.1-2001, do not check for it
Ivailo Monev [Wed, 20 Jan 2021 22:37:29 +0000 (00:37 +0200)]
feclearexcept() is standardized by POSIX.1-2001, do not check for it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoget rid of QCustomScopedPointer
Ivailo Monev [Wed, 20 Jan 2021 22:27:47 +0000 (00:27 +0200)]
get rid of QCustomScopedPointer

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoreplace std::this_thread::yield() with sched_yield() in QThread::yieldCurrentThread()
Ivailo Monev [Wed, 20 Jan 2021 22:26:56 +0000 (00:26 +0200)]
replace std::this_thread::yield() with sched_yield() in QThread::yieldCurrentThread()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoset thread priority from the thread itself
Ivailo Monev [Wed, 20 Jan 2021 21:11:18 +0000 (23:11 +0200)]
set thread priority from the thread itself

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agomake use of katie_generate_obsolete() in katie_generate_public()
Ivailo Monev [Wed, 20 Jan 2021 21:10:03 +0000 (23:10 +0200)]
make use of katie_generate_obsolete() in katie_generate_public()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove code for always false condition in QX11Data::clipboardReadIncrementalProperty()
Ivailo Monev [Wed, 20 Jan 2021 19:13:16 +0000 (21:13 +0200)]
remove code for always false condition in QX11Data::clipboardReadIncrementalProperty()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove code for always false condition in QX11Info::getX11Data()
Ivailo Monev [Wed, 20 Jan 2021 17:30:20 +0000 (19:30 +0200)]
remove code for always false condition in QX11Info::getX11Data()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove unused and private QX11Info methods
Ivailo Monev [Wed, 20 Jan 2021 17:18:10 +0000 (19:18 +0200)]
remove unused and private QX11Info methods

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoconvert some virtual isDocumentType methods to inline virtual call
Ivailo Monev [Wed, 20 Jan 2021 16:09:19 +0000 (18:09 +0200)]
convert some virtual isDocumentType methods to inline virtual call

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoproperly initialize QDomNodeListPrivate members
Ivailo Monev [Wed, 20 Jan 2021 15:47:18 +0000 (17:47 +0200)]
properly initialize QDomNodeListPrivate members

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoproperly initialize QUrlPrivate members
Ivailo Monev [Wed, 20 Jan 2021 15:26:04 +0000 (17:26 +0200)]
properly initialize QUrlPrivate members

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove unused QUrlErrorInfo::_expected member
Ivailo Monev [Wed, 20 Jan 2021 14:46:55 +0000 (16:46 +0200)]
remove unused QUrlErrorInfo::_expected member

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove declaration of non-existing QUrl methods
Ivailo Monev [Wed, 20 Jan 2021 13:38:24 +0000 (15:38 +0200)]
remove declaration of non-existing QUrl methods

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove unused QX11PixmapData::Uninitialized enum
Ivailo Monev [Wed, 20 Jan 2021 13:18:26 +0000 (15:18 +0200)]
remove unused QX11PixmapData::Uninitialized enum

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agopartially revert 9c70701677c8406d4d91a0b2c830c49f09a84785
Ivailo Monev [Wed, 20 Jan 2021 12:53:22 +0000 (14:53 +0200)]
partially revert 9c70701677c8406d4d91a0b2c830c49f09a84785

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agouse virtual methods for SSL configuration of QNetworkReply
Ivailo Monev [Wed, 20 Jan 2021 10:18:43 +0000 (12:18 +0200)]
use virtual methods for SSL configuration of QNetworkReply

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agouse foreach() for iteration in generateSubObjectXml()
Ivailo Monev [Wed, 20 Jan 2021 09:54:54 +0000 (11:54 +0200)]
use foreach() for iteration in generateSubObjectXml()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoproperly initialize QRegExp member
Ivailo Monev [Wed, 20 Jan 2021 08:31:34 +0000 (10:31 +0200)]
properly initialize QRegExp member

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agopre-allocate a more realistic size for integer conversion buffer
Ivailo Monev [Mon, 18 Jan 2021 12:42:15 +0000 (14:42 +0200)]
pre-allocate a more realistic size for integer conversion buffer

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoseparate logic for invalid and intermidiate integer conversion failures
Ivailo Monev [Mon, 18 Jan 2021 12:25:44 +0000 (14:25 +0200)]
separate logic for invalid and intermidiate integer conversion failures

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove redundant QLocalePrivate::bytearrayToLongLong() argument
Ivailo Monev [Mon, 18 Jan 2021 11:00:51 +0000 (13:00 +0200)]
remove redundant QLocalePrivate::bytearrayToLongLong() argument

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agofix xvfb script exit in case of test failure
Ivailo Monev [Mon, 18 Jan 2021 00:02:37 +0000 (02:02 +0200)]
fix xvfb script exit in case of test failure

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove redundant CustomWidgetsInfo::acceptCustomWidgets() reimplementation
Ivailo Monev [Thu, 14 Jan 2021 06:05:23 +0000 (08:05 +0200)]
remove redundant CustomWidgetsInfo::acceptCustomWidgets() reimplementation

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agocorrect copying of QByteArrayMatcher and QStringMatcher skip tables
Ivailo Monev [Thu, 14 Jan 2021 05:54:27 +0000 (07:54 +0200)]
correct copying of QByteArrayMatcher and QStringMatcher skip tables

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoavoid memmove() and memcpy() in QRegionPrivate
Ivailo Monev [Wed, 13 Jan 2021 10:47:29 +0000 (12:47 +0200)]
avoid memmove() and memcpy() in QRegionPrivate

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agocompared with definition in getX11AutoRepeat()
Ivailo Monev [Wed, 13 Jan 2021 06:39:02 +0000 (08:39 +0200)]
compared with definition in getX11AutoRepeat()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove unused QLayoutPrivate::autoNewChild member
Ivailo Monev [Wed, 13 Jan 2021 06:38:37 +0000 (08:38 +0200)]
remove unused QLayoutPrivate::autoNewChild member

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agomark warning case in QXmlStreamReader::addData() as unlikely
Ivailo Monev [Wed, 13 Jan 2021 03:45:14 +0000 (05:45 +0200)]
mark warning case in QXmlStreamReader::addData() as unlikely

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoavoid temporaries in QXmlUtils::isPublicID() and QXmlUtils::isNCName()
Ivailo Monev [Wed, 13 Jan 2021 03:44:55 +0000 (05:44 +0200)]
avoid temporaries in QXmlUtils::isPublicID() and QXmlUtils::isNCName()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agocompiler warning fix
Ivailo Monev [Tue, 12 Jan 2021 16:33:51 +0000 (18:33 +0200)]
compiler warning fix

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoinclude string header for memcpy() in qendian header
Ivailo Monev [Tue, 12 Jan 2021 16:13:41 +0000 (18:13 +0200)]
include string header for memcpy() in qendian header

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agode-inline QBuffer::setData() overload for performance reasons
Ivailo Monev [Tue, 12 Jan 2021 14:31:54 +0000 (16:31 +0200)]
de-inline QBuffer::setData() overload for performance reasons

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoproperly initialize and delete QImageWriterPrivate members
Ivailo Monev [Tue, 12 Jan 2021 13:51:05 +0000 (15:51 +0200)]
properly initialize and delete QImageWriterPrivate members

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agomerge qcommonstylepixmaps_p header into qcommonstyle source file
Ivailo Monev [Tue, 12 Jan 2021 12:16:06 +0000 (14:16 +0200)]
merge qcommonstylepixmaps_p header into qcommonstyle source file

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agouse correct type for script in qt_addPatternProps() and getFcPattern()
Ivailo Monev [Tue, 12 Jan 2021 08:13:01 +0000 (10:13 +0200)]
use correct type for script in qt_addPatternProps() and getFcPattern()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agouse correct type for meta type in qNumVariantToHelper<T>()
Ivailo Monev [Tue, 12 Jan 2021 08:12:28 +0000 (10:12 +0200)]
use correct type for meta type in qNumVariantToHelper<T>()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoREADME and CONTRIBUTING typos [ci skip]
Ivailo Monev [Tue, 12 Jan 2021 02:53:44 +0000 (04:53 +0200)]
README and CONTRIBUTING typos [ci skip]

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoopen new iterator from QTextBoundaryFinder copy-constructor
Ivailo Monev [Tue, 12 Jan 2021 02:47:07 +0000 (04:47 +0200)]
open new iterator from QTextBoundaryFinder copy-constructor

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove unused QPixmapFilter::UserFilter enum
Ivailo Monev [Tue, 12 Jan 2021 02:39:44 +0000 (04:39 +0200)]
remove unused QPixmapFilter::UserFilter enum

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoreference count QTextBoundaryFinderPrivate
Ivailo Monev [Tue, 12 Jan 2021 02:38:16 +0000 (04:38 +0200)]
reference count QTextBoundaryFinderPrivate

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoproperly indent qxbmhandler source file
Ivailo Monev [Tue, 12 Jan 2021 01:58:19 +0000 (03:58 +0200)]
properly indent qxbmhandler source file

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove redundant else statements in QNativeSocketEnginePrivate::nativeConnect()
Ivailo Monev [Mon, 11 Jan 2021 05:15:00 +0000 (07:15 +0200)]
remove redundant else statements in QNativeSocketEnginePrivate::nativeConnect()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agomark QApplication::graphicsSystem() and QApplication::setGraphicsSystem() as deprecated
Ivailo Monev [Mon, 11 Jan 2021 05:14:23 +0000 (07:14 +0200)]
mark QApplication::graphicsSystem() and QApplication::setGraphicsSystem() as deprecated

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agocorrect comment in plugins build file
Ivailo Monev [Sun, 10 Jan 2021 15:39:29 +0000 (17:39 +0200)]
correct comment in plugins build file

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove now redundant _PATH_RESCONF definition check
Ivailo Monev [Sun, 10 Jan 2021 15:38:49 +0000 (17:38 +0200)]
remove now redundant _PATH_RESCONF definition check

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agofix some QCoreApplication/QApplication thread-safety issues
Ivailo Monev [Sun, 10 Jan 2021 06:01:42 +0000 (08:01 +0200)]
fix some QCoreApplication/QApplication thread-safety issues

for reference:
https://pubs.opengroup.org/onlinepubs/9699919799/functions/exec.html

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agomove QT_NO_DEBUG_STREAM override to qconfig header
Ivailo Monev [Sun, 10 Jan 2021 02:50:16 +0000 (04:50 +0200)]
move QT_NO_DEBUG_STREAM override to qconfig header

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agonote Open Group documentation in CONTRIBUTING file
Ivailo Monev [Sun, 10 Jan 2021 02:01:10 +0000 (04:01 +0200)]
note Open Group documentation in CONTRIBUTING file

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoeliminate QGraphicsSystem
Ivailo Monev [Sun, 10 Jan 2021 01:30:38 +0000 (03:30 +0200)]
eliminate QGraphicsSystem

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agode-duplicate code in QMotifStyle::standardPalette()
Ivailo Monev [Sat, 9 Jan 2021 13:52:07 +0000 (15:52 +0200)]
de-duplicate code in QMotifStyle::standardPalette()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove unused definition in QMotifStyle::drawPrimitive()
Ivailo Monev [Sat, 9 Jan 2021 13:48:47 +0000 (15:48 +0200)]
remove unused definition in QMotifStyle::drawPrimitive()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoupdate POT files [ci skip]
Ivailo Monev [Sat, 9 Jan 2021 13:41:27 +0000 (15:41 +0200)]
update POT files [ci skip]

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove some redundant int constructs
Ivailo Monev [Sat, 9 Jan 2021 12:27:53 +0000 (14:27 +0200)]
remove some redundant int constructs

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agofix regression since b3722d96b0d97638a45d2b40f607eed510d89d41
Ivailo Monev [Sat, 9 Jan 2021 11:02:34 +0000 (13:02 +0200)]
fix regression since b3722d96b0d97638a45d2b40f607eed510d89d41

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove non-raster graphics systems support leftovers
Ivailo Monev [Sat, 9 Jan 2021 09:46:10 +0000 (11:46 +0200)]
remove non-raster graphics systems support leftovers

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove unused QPixmapData methods
Ivailo Monev [Sat, 9 Jan 2021 09:24:56 +0000 (11:24 +0200)]
remove unused QPixmapData methods

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agouse QImage::constScanLine() where possible in QX11PixmapData
Ivailo Monev [Sat, 9 Jan 2021 02:35:11 +0000 (04:35 +0200)]
use QImage::constScanLine() where possible in QX11PixmapData

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoadd QBuffer test
Ivailo Monev [Sat, 9 Jan 2021 00:50:04 +0000 (02:50 +0200)]
add QBuffer test

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agocopy the result of nl_langinfo()
Ivailo Monev [Sat, 9 Jan 2021 00:17:21 +0000 (02:17 +0200)]
copy the result of nl_langinfo()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoimplement option to print backtrace on warning message
Ivailo Monev [Fri, 8 Jan 2021 13:42:47 +0000 (15:42 +0200)]
implement option to print backtrace on warning message

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agokeep QByteArray reference in QProcessPrivate::createChannel()
Ivailo Monev [Fri, 8 Jan 2021 11:39:02 +0000 (13:39 +0200)]
keep QByteArray reference in QProcessPrivate::createChannel()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agostore native file path outside loop in QFSFileEngine::open()
Ivailo Monev [Fri, 8 Jan 2021 11:38:11 +0000 (13:38 +0200)]
store native file path outside loop in QFSFileEngine::open()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agodo not undefine listen() from qnet_unix_p header
Ivailo Monev [Fri, 8 Jan 2021 11:17:43 +0000 (13:17 +0200)]
do not undefine listen() from qnet_unix_p header

qt_safe_listen() is no more

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoalways use clock_gettime() in QElapsedTimer() and qt_gettime()
Ivailo Monev [Fri, 8 Jan 2021 10:25:03 +0000 (12:25 +0200)]
always use clock_gettime() in QElapsedTimer() and qt_gettime()

upstream commits:
https://github.com/qt/qtbase/commit/46e2c9441761f75f19b2780e8f1616102128dedd
https://github.com/qt/qtbase/commit/51ddaabb81ae55d13aaabfdf45ee7db4d7c9bba2

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agobump the minimum to POSIX.1-2001
Ivailo Monev [Fri, 8 Jan 2021 07:08:30 +0000 (09:08 +0200)]
bump the minimum to POSIX.1-2001

many POSIX.1-2001 functions are used right now such as strcasecmp(),
strncasecmp(), htonl(), etc.

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agofix regression since 9f5d79e38d9268e72cf27e6fb6ea3728811cffd7
Ivailo Monev [Fri, 8 Jan 2021 06:49:34 +0000 (08:49 +0200)]
fix regression since 9f5d79e38d9268e72cf27e6fb6ea3728811cffd7

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agouse plain ushort array in QString streaming operator
Ivailo Monev [Fri, 8 Jan 2021 06:06:35 +0000 (08:06 +0200)]
use plain ushort array in QString streaming operator

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agominor QColor::isValidColor() optimization
Ivailo Monev [Fri, 8 Jan 2021 01:59:12 +0000 (03:59 +0200)]
minor QColor::isValidColor() optimization

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agomake it easy to switch source for NetBSD [ci skip]
Ivailo Monev [Thu, 7 Jan 2021 23:58:49 +0000 (01:58 +0200)]
make it easy to switch source for NetBSD [ci skip]

e.g. setting DISTNAME to version to build stable release or even commit
hash to build specific revision

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoNetBSD pkglint warning fix
Ivailo Monev [Thu, 7 Jan 2021 23:56:22 +0000 (01:56 +0200)]
NetBSD pkglint warning fix

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove redundant QT_BEGIN_HEADER and QT_END_HEADER definitions
Ivailo Monev [Thu, 7 Jan 2021 22:31:52 +0000 (00:31 +0200)]
remove redundant QT_BEGIN_HEADER and QT_END_HEADER definitions

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoproperly initialize QGifHandler members
Ivailo Monev [Thu, 7 Jan 2021 08:19:33 +0000 (10:19 +0200)]
properly initialize QGifHandler members

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoproperly initialize QXmlNamespaceSupportPrivate members
Ivailo Monev [Thu, 7 Jan 2021 07:51:47 +0000 (09:51 +0200)]
properly initialize QXmlNamespaceSupportPrivate members

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoinitialize QXmlInputSourcePrivate members via constructor
Ivailo Monev [Thu, 7 Jan 2021 07:37:18 +0000 (09:37 +0200)]
initialize QXmlInputSourcePrivate members via constructor

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoproperly initialize QDataBuffer members
Ivailo Monev [Thu, 7 Jan 2021 07:14:08 +0000 (09:14 +0200)]
properly initialize QDataBuffer members

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoproperly initialize QPaintDevice member
Ivailo Monev [Thu, 7 Jan 2021 07:06:47 +0000 (09:06 +0200)]
properly initialize QPaintDevice member

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agooptimize QColor construction from Qt::GlobalColor
Ivailo Monev [Thu, 7 Jan 2021 05:18:38 +0000 (07:18 +0200)]
optimize QColor construction from Qt::GlobalColor

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agouse single variable assignment in read_xpm_body()
Ivailo Monev [Thu, 7 Jan 2021 05:17:27 +0000 (07:17 +0200)]
use single variable assignment in read_xpm_body()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agouse cheaper character comparison in QColor::setNamedColor()
Ivailo Monev [Thu, 7 Jan 2021 04:49:14 +0000 (06:49 +0200)]
use cheaper character comparison in QColor::setNamedColor()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agouse loop-local variables in write_xpm_image()
Ivailo Monev [Thu, 7 Jan 2021 02:58:16 +0000 (04:58 +0200)]
use loop-local variables in write_xpm_image()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agouse qint16 type for KeyNameTblSize
Ivailo Monev [Thu, 7 Jan 2021 02:45:46 +0000 (04:45 +0200)]
use qint16 type for KeyNameTblSize

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove redundant variable in read_xpm_body()
Ivailo Monev [Thu, 7 Jan 2021 02:38:23 +0000 (04:38 +0200)]
remove redundant variable in read_xpm_body()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agocorrect buffer size in xpm_color_name()
Ivailo Monev [Thu, 7 Jan 2021 02:38:02 +0000 (04:38 +0200)]
correct buffer size in xpm_color_name()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove unused variable in qt_read_xpm_array()
Ivailo Monev [Thu, 7 Jan 2021 02:09:37 +0000 (04:09 +0200)]
remove unused variable in qt_read_xpm_array()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoreplace QXpmHandler::readImage() with its body
Ivailo Monev [Thu, 7 Jan 2021 01:56:13 +0000 (03:56 +0200)]
replace QXpmHandler::readImage() with its body

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove unused qMetaTypeId<T>() argument
Ivailo Monev [Wed, 6 Jan 2021 23:51:06 +0000 (01:51 +0200)]
remove unused qMetaTypeId<T>() argument

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoremove unused QMetaTypeId2<T>::MetaType enum
Ivailo Monev [Wed, 6 Jan 2021 23:50:35 +0000 (01:50 +0200)]
remove unused QMetaTypeId2<T>::MetaType enum

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agotop-level CMake file review
Ivailo Monev [Wed, 6 Jan 2021 23:14:42 +0000 (01:14 +0200)]
top-level CMake file review

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agouse plain integer in QMetaTypeId<T>::qt_metatype_id() lazy initializer
Ivailo Monev [Wed, 6 Jan 2021 12:58:15 +0000 (14:58 +0200)]
use plain integer in QMetaTypeId<T>::qt_metatype_id() lazy initializer

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agocompiler warning fix
Ivailo Monev [Wed, 6 Jan 2021 10:48:21 +0000 (12:48 +0200)]
compiler warning fix

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agorename qt_read_xpm_image_or_array() so that the function name implies what it does
Ivailo Monev [Wed, 6 Jan 2021 10:04:45 +0000 (12:04 +0200)]
rename qt_read_xpm_image_or_array() so that the function name implies what it does

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agoproperly initialize QImage member
Ivailo Monev [Wed, 6 Jan 2021 09:58:42 +0000 (11:58 +0200)]
properly initialize QImage member

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agouse constant iterator in write_xpm_image()
Ivailo Monev [Wed, 6 Jan 2021 09:46:37 +0000 (11:46 +0200)]
use constant iterator in write_xpm_image()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
3 years agomark warning cases in QXpmHandler as unlikely
Ivailo Monev [Wed, 6 Jan 2021 09:41:14 +0000 (11:41 +0200)]
mark warning cases in QXpmHandler as unlikely

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>