OSDN Git Service
Alex Light [Mon, 9 Jan 2017 21:31:06 +0000 (13:31 -0800)]
Try really hard for JIT in test 916
Sometimes we would fail to jit stuff due to high load. This makes us
try even harder to JIT so we won't fail in these scenarios.
Test: mma -j40 test-art-host
Test: stress --cpu 60 &; while ./test/run-test --host 916; do ; done
Change-Id: Ic944582bf021f119b8bc3f135af508ed8a8586c4
Treehugger Robot [Thu, 12 Jan 2017 20:22:57 +0000 (20:22 +0000)]
Merge "ART: Add GetCurrentThread and GetThreadInfo"
Hiroshi Yamauchi [Thu, 12 Jan 2017 19:50:46 +0000 (19:50 +0000)]
Merge "Don't need to block in AddWeakGlobalRef and MonitorList::Add under CC."
Hiroshi Yamauchi [Thu, 12 Jan 2017 18:58:38 +0000 (18:58 +0000)]
Merge "Fix race condition btw DelayReferenceRefernent vs Reference.clear()."
Andreas Gampe [Thu, 12 Jan 2017 04:57:40 +0000 (20:57 -0800)]
ART: Add GetCurrentThread and GetThreadInfo
Add support for GetCurrentThread and GetThreadInfo. Add tests.
Bug:
31684593
Test: m test-art-host-run-test-924-threads
Change-Id: Ic2bc4c9b5c283e4eefe4075b6abe251b8be499c8
Nicolas Geoffray [Thu, 12 Jan 2017 18:00:02 +0000 (18:00 +0000)]
Merge "Revert "Refactor ClassLinker::LinkInterfaceMethods().""
Nicolas Geoffray [Thu, 12 Jan 2017 17:59:39 +0000 (17:59 +0000)]
Revert "Refactor ClassLinker::LinkInterfaceMethods()."
Fails libcore tests.
This reverts commit
afbd71ffbcc7b37067d3a4703648e62fc0e55e6f.
Change-Id: I611620f915025a0c077a78a480b2b730b3be3de8
Treehugger Robot [Thu, 12 Jan 2017 16:51:36 +0000 (16:51 +0000)]
Merge "ART: Simplify 9xx OnLoad setup"
Treehugger Robot [Thu, 12 Jan 2017 12:39:01 +0000 (12:39 +0000)]
Merge "Refactor ClassLinker::LinkInterfaceMethods()."
Treehugger Robot [Thu, 12 Jan 2017 12:24:01 +0000 (12:24 +0000)]
Merge "MIPS32: Change java.lang.Math.abs(float/double) intrinsics"
Vladimir Marko [Mon, 19 Dec 2016 17:32:17 +0000 (17:32 +0000)]
Refactor ClassLinker::LinkInterfaceMethods().
Add a helper class and split LinkInterfaceMethods() into
several functions to improve readability. Even with this
change, it is still almost 250 lines long.
Fix the method array reallocation to use the appropriate
linear allocator for the class's defining loader. Given that
this is a native reallocation, failure to reallocate would
result in an abort, so CHECK() that we get a non-null array
instead of expecting a null and asserting a pending OOME.
Test: m test-art-host
Change-Id: I8ff8257e4271ae8c975ea4b33fd8af36e1a1f77e
Nicolas Geoffray [Thu, 12 Jan 2017 10:46:23 +0000 (10:46 +0000)]
Merge "Revert "ART: Ensure plugin is loaded on AttachAgent""
Nicolas Geoffray [Thu, 12 Jan 2017 10:46:04 +0000 (10:46 +0000)]
Revert "ART: Ensure plugin is loaded on AttachAgent"
Test fails.
Bug:
31682382
This reverts commit
ad2dc875ce29c3fafc1129a2a25184df28b66a10.
Change-Id: Id15d9d5478d2f72a4dc59f119944a311be7bc989
Goran Jakovljevic [Wed, 11 Jan 2017 12:42:38 +0000 (13:42 +0100)]
MIPS32: Change java.lang.Math.abs(float/double) intrinsics
abs.s and abs.d instructions can't be used when NAN2008=0 (R2 and
before). In these cases, abs(NaN) might change other bits (not just
sign bit).
This fixes test failure 631-checker-fp-abs for MIPS32.
Bug:
30758343
Test: mma test-art-target-run-test on CI20
Change-Id: I352efd66f2f72740406462c9ccc3bc4b1b5aea20
Treehugger Robot [Thu, 12 Jan 2017 07:20:35 +0000 (07:20 +0000)]
Merge "ART: Ensure plugin is loaded on AttachAgent"
Treehugger Robot [Thu, 12 Jan 2017 06:19:22 +0000 (06:19 +0000)]
Merge "Revert "Make object allocation entrypoints only take a class.""
Andreas Gampe [Thu, 12 Jan 2017 03:53:50 +0000 (19:53 -0800)]
ART: Simplify 9xx OnLoad setup
Provide the default implementation in common_load.cc, and only
mark cases that deviate.
Bug:
31455788
Test: m test-art-host-run-test
Change-Id: I40d467fb344405c443805749ced6717574430b75
Hiroshi Yamauchi [Thu, 12 Jan 2017 02:58:38 +0000 (02:58 +0000)]
Revert "Make object allocation entrypoints only take a class."
960-default-smali64 is failing.
This reverts commit
2b615ba29c4dfcf54aaf44955f2eac60f5080b2e.
Change-Id: Iebb8ee5a917fa84c5f01660ce432798524d078ef
Andreas Gampe [Wed, 11 Jan 2017 16:36:59 +0000 (08:36 -0800)]
ART: Ensure plugin is loaded on AttachAgent
Agents require the JVMTI plugin. Ensure that it is loaded when
trying to satisfy an AttachAgent request. Amend test 909.
Bug:
31682382
Test: m test-art-host-run-test-909-attach-agent
Change-Id: Id99d0315b5b2577167dd8f8448a052e04f3ed2e5
Andreas Gampe [Thu, 12 Jan 2017 01:21:20 +0000 (01:21 +0000)]
Merge "ART: Add raw monitor API"
Andreas Gampe [Tue, 10 Jan 2017 00:42:21 +0000 (16:42 -0800)]
ART: Add raw monitor API
Add support for CreateRawMonitor, DestroyRawMonitor,
RawMonitorEnter, RawMonitorExit, RawMonitorWait, RawMonitorNotify
and RawMonitorNotifyAll.
Bug:
31455788
Test: m test-art-host-run-test-923-monitors
Change-Id: I4eeab8011b547ae0ea8b2317701c68ce56677f79
Treehugger Robot [Wed, 11 Jan 2017 21:15:47 +0000 (21:15 +0000)]
Merge "Set timeout before connect to adb in jdwp."
Mathieu Chartier [Wed, 11 Jan 2017 21:10:28 +0000 (21:10 +0000)]
Merge "Increase thread suspension timeout for debug builds"
Orion Hodson [Wed, 11 Jan 2017 19:18:51 +0000 (19:18 +0000)]
Merge "Revert "ART: Compiler support for invoke-polymorphic.""
Orion Hodson [Wed, 11 Jan 2017 18:58:15 +0000 (18:58 +0000)]
Revert "ART: Compiler support for invoke-polymorphic."
This reverts commit
02e3092f8d98f339588e48691db77f227b48ac1e.
Reasons for revert:
- Breaks MIPS/MIPS64 build.
- Fails under GCStress test on x64.
- Different x64 build configuration doesn't like relocation.
Change-Id: I512555b38165d05f8a07e8aed528f00302061001
Mathieu Chartier [Wed, 11 Jan 2017 18:09:30 +0000 (10:09 -0800)]
Increase thread suspension timeout for debug builds
The current timeout may be causing some test failures. Also print how
long we waited.
Test: test-art-host -j32
Change-Id: Ib8a9c68ab4571efc8456c098b03bf35f648bfaf1
Treehugger Robot [Wed, 11 Jan 2017 18:30:04 +0000 (18:30 +0000)]
Merge "liblog: use log/log.h to access ALOG macros"
Treehugger Robot [Wed, 11 Jan 2017 18:08:03 +0000 (18:08 +0000)]
Merge "ART: Compiler support for invoke-polymorphic."
Mathieu Chartier [Wed, 11 Jan 2017 17:59:34 +0000 (17:59 +0000)]
Merge "Move most of art::Thread to ObjPtr"
Mathieu Chartier [Wed, 11 Jan 2017 17:47:30 +0000 (17:47 +0000)]
Merge "Fix possible deadlock in AddAccessFlags and ClearAccessFlags"
Orion Hodson [Thu, 1 Dec 2016 10:33:51 +0000 (10:33 +0000)]
ART: Compiler support for invoke-polymorphic.
Adds basic support to invoke method handles in compiled code.
Enables method verification for methods containing invoke-polymorphic.
Adds k45cc/k45rc output to Instruction::DumpString() which
was found to be missing when enabling verification.
Include stack traces in test 957-methodhandle-transforms for
failures so they can be easily identified.
Bug:
30550796,
33191393
Test: art/test/run-test 953
Test: m test-art-run-test
Change-Id: Ic9a96ea24906087597d96ad8159a5bc349d06950
Mark Salyzyn [Tue, 10 Jan 2017 23:12:38 +0000 (15:12 -0800)]
liblog: use log/log.h to access ALOG macros
Test: compile
Bug:
30465923
Change-Id: Ia2699768da1af6d508472360baa08c77c07fca01
Nicolas Geoffray [Wed, 11 Jan 2017 14:05:08 +0000 (14:05 +0000)]
Merge "Keep resolved String in HLoadString."
Treehugger Robot [Wed, 11 Jan 2017 12:58:15 +0000 (12:58 +0000)]
Merge "ARM: Instruction set features clean-up."
Vladimir Marko [Wed, 11 Jan 2017 11:25:38 +0000 (11:25 +0000)]
Merge "Remove the unused SMP instruction set feature option."
Nicolas Geoffray [Wed, 11 Jan 2017 10:37:54 +0000 (10:37 +0000)]
Merge "Make object allocation entrypoints only take a class."
Nicolas Geoffray [Fri, 6 Jan 2017 14:40:07 +0000 (14:40 +0000)]
Make object allocation entrypoints only take a class.
Change motivated by:
- Dex cache compression: having the allocation fast path do a
dex cache lookup will be too expensive. So instead, rely on the
compiler having direct access to the class (either through BSS for
AOT, or JIT tables for JIT).
- Inlining: the entrypoints relied on the caller of the allocation to
have the same dex cache as the outer method (stored at the bottom of
the stack). This meant we could not inline methods from a different
dex file that do allocations. By avoiding the dex cache lookup in
the entrypoint, we can now remove this restriction.
Code expansion on average for Docs/Gms/FB/Framework (go/lem numbers):
- Around 0.8% on arm64
- Around 1% for x64, arm
- Around 1.5% on x86
Test: test-art-host, test-art-target, ART_USE_READ_BARRIER=true/false
Test: test-art-host, test-art-target, ART_DEFAULT_GC_TYPE=SS ART_USE_TLAB=true
Change-Id: I41f3748bb4d251996aaf6a90fae4c50176f9295f
Treehugger Robot [Wed, 11 Jan 2017 10:28:16 +0000 (10:28 +0000)]
Merge "Do not return patchoat for dexopt needed."
Przemyslaw Szczepaniak [Wed, 11 Jan 2017 10:15:43 +0000 (10:15 +0000)]
Merge "Track libcore java.lang.reflect.Proxy update"
Nicolas Geoffray [Wed, 11 Jan 2017 09:08:09 +0000 (09:08 +0000)]
Merge "Recognize getClass() in RTP."
Mathieu Chartier [Wed, 11 Jan 2017 00:48:11 +0000 (16:48 -0800)]
Fix possible deadlock in AddAccessFlags and ClearAccessFlags
Reload the value each loop iteration or else it will spin forever
if the CAS fails due to another thread adding a different flag.
Test: mm
Change-Id: Idc320921597acc20d56301899b398756563029f2
Treehugger Robot [Wed, 11 Jan 2017 00:42:14 +0000 (00:42 +0000)]
Merge "Make all class redefinition operations after suspend_all infallible"
Treehugger Robot [Wed, 11 Jan 2017 00:26:10 +0000 (00:26 +0000)]
Merge "ART: Add system properties support"
Mathieu Chartier [Tue, 10 Jan 2017 23:54:41 +0000 (15:54 -0800)]
Move most of art::Thread to ObjPtr
Bug:
31113334
Test: test-art-host
Change-Id: I73d0de3c875d3ec3d732034fdc961dae79ef4070
Alex Light [Tue, 10 Jan 2017 21:33:56 +0000 (13:33 -0800)]
Make all class redefinition operations after suspend_all infallible
We can guarantee that the mutations to the class, classloader, method
& stack data-structures which occur after the suspend_all can never
fail. This will simplify implementing the required semantics of class
redefinition with respect to atomically updating multiple classes at
once.
Test: mma -j40 test-art-host
Change-Id: Iab95c66afbdcfe161a9486f5fb7193c53642c060
Nicolas Geoffray [Mon, 9 Jan 2017 20:54:52 +0000 (20:54 +0000)]
Keep resolved String in HLoadString.
For the following reasons:
- Avoids needing to do a lookup again in CodeGenerator::EmitJitRoots.
- Fixes races where we the string was GC'ed before CodeGenerator::EmitJitRoots.
- Makes it possible to do GVN on the same string but defined in different
dex files.
Test: test-art-host, test-art-target
Change-Id: If2b5d3079f7555427b1b96ab04546b3373fcf921
Andreas Gampe [Tue, 10 Jan 2017 03:21:06 +0000 (19:21 -0800)]
ART: Add system properties support
Add simple support for GetSystemProperties, GetSystemProperty and
SetSystemProperty. Add a test.
Bug:
31455788
Test: m test-art-host-run-test-922-properties
Change-Id: I02914f04643f0f8fab96f1b372925c2c5306fc9b
Mathieu Chartier [Tue, 10 Jan 2017 18:40:25 +0000 (18:40 +0000)]
Merge "Fix some issues reported by Valgrind"
Mathieu Chartier [Tue, 10 Jan 2017 18:09:21 +0000 (18:09 +0000)]
Merge "Delete extra arm64/mips64 MterpReturn suspend check"
Treehugger Robot [Tue, 10 Jan 2017 17:04:13 +0000 (17:04 +0000)]
Merge "Revert "Revert "Add basic implementation of IsModifiableClass"""
Treehugger Robot [Tue, 10 Jan 2017 17:01:12 +0000 (17:01 +0000)]
Merge "Revert "Revert "Add basic checks for redefinition."""
Przemyslaw Szczepaniak [Wed, 17 Aug 2016 16:46:38 +0000 (17:46 +0100)]
Track libcore java.lang.reflect.Proxy update
Test: make -j 32 & booted device & m test-art-host
Bug:
28666126
Change-Id: I6e7d75fd904e9b130925756ef1ff1122c25ab245
Mathieu Chartier [Tue, 10 Jan 2017 02:48:11 +0000 (18:48 -0800)]
Delete extra arm64/mips64 MterpReturn suspend check
Doing a suspend check after moving the result into the shadow frame
result_register_ is not safe since result_register_ is not a GC
root. The suspend check is unnecessary since the opcodes that branch
to MterpReturn already do a suspend check.
This could maybe explain one crash for CC that was seen after calling
a getter that had no compiled code.
The extra suspend check appears to only be present on arm64 amd mips64.
Test: test-art-target ART_TEST_INTERPRETER=true
Bug:
33211261
Change-Id: I70b8863f40a25a26f278ac8ef0d57e083b663e0f
Alex Light [Tue, 10 Jan 2017 15:41:24 +0000 (07:41 -0800)]
Revert "Revert "Add basic implementation of IsModifiableClass""
This reverts commit
c66c077d40db58ec239f93a9c42b9939439c85c7.
Reason for revert: Problem with preceding CL fixed.
Test: mma -j40 test-art-host
Alex Light [Tue, 10 Jan 2017 15:37:17 +0000 (15:37 +0000)]
Revert "Revert "Add basic checks for redefinition.""
This reverts commit
f9d41c1d269f3031c0a89e34fc4a04303e186958.
Reason for revert: Fixed issue of missing target skip.
Test: mma -j40 test-art-host
Change-Id: Ibe632e1f3063373950fb873e1716d0439c561297
Nicolas Geoffray [Mon, 19 Dec 2016 09:18:07 +0000 (09:18 +0000)]
Recognize getClass() in RTP.
Also always keep around the resolved field
in related HInstructions to avoid resolving it again
and again.
Test: test-art-host, 631-checker-get-class
Change-Id: I3bc6be11f3eb175c635e746006f39865947e0669
Nicolas Geoffray [Tue, 10 Jan 2017 12:10:09 +0000 (12:10 +0000)]
Merge "The HBoundsCheck should be the index input of String.charAt."
Nicolas Geoffray [Tue, 10 Jan 2017 09:00:28 +0000 (09:00 +0000)]
Merge "Revert "Add basic checks for redefinition.""
Nicolas Geoffray [Tue, 10 Jan 2017 08:58:44 +0000 (08:58 +0000)]
Revert "Add basic checks for redefinition."
Test fails.
This reverts commit
10f02fb4f026c493c69b21d4ec7c3096970357e1.
Change-Id: I21abfff0d7cd4ec840447f19819b7859b90f45b2
Nicolas Geoffray [Tue, 10 Jan 2017 08:59:54 +0000 (08:59 +0000)]
Merge "Revert "Add basic implementation of IsModifiableClass""
Nicolas Geoffray [Tue, 10 Jan 2017 08:59:31 +0000 (08:59 +0000)]
Revert "Add basic implementation of IsModifiableClass"
Built on top of a failing change.
This reverts commit
b4e51ebfa23a1cb175a6c317ac4a69228709e78f.
Change-Id: I7f4dbe22271a9c04e518bceabba12c95cad3c6f7
Treehugger Robot [Tue, 10 Jan 2017 01:52:42 +0000 (01:52 +0000)]
Merge "Add basic implementation of IsModifiableClass"
Mathieu Chartier [Tue, 10 Jan 2017 01:04:32 +0000 (01:04 +0000)]
Merge "Use relative futex timeout in SuspendAllInternal."
Alex Light [Tue, 10 Jan 2017 00:28:58 +0000 (16:28 -0800)]
Add basic implementation of IsModifiableClass
Currently we just flatly disallow some types of modifications that
might be allowed in the future.
Bug:
31684578
Test: mma -j40 test-art-host
Change-Id: Ica76d12276eb11b318da2f642591ea78766f36ad
Treehugger Robot [Tue, 10 Jan 2017 00:22:41 +0000 (00:22 +0000)]
Merge "ART: Add method modifiers functions"
Treehugger Robot [Tue, 10 Jan 2017 00:13:40 +0000 (00:13 +0000)]
Merge "Add basic checks for redefinition."
Dan Willemsen [Mon, 9 Jan 2017 23:55:50 +0000 (23:55 +0000)]
Merge "Remove oat-target* rules"
Treehugger Robot [Mon, 9 Jan 2017 22:57:24 +0000 (22:57 +0000)]
Merge "ART: Add method code item functions"
Andreas Gampe [Mon, 9 Jan 2017 22:40:25 +0000 (14:40 -0800)]
ART: Add method modifiers functions
Add support for IsMethodNative, IsMethodObsolete and IsMethodSynthetic.
Add tests.
Bug:
34163329
Test: m test-art-host-run-test-910-methods
Change-Id: I89077cfde1f37861ccb718345b753dfae1d6abe3
Alex Light [Sat, 7 Jan 2017 00:21:48 +0000 (16:21 -0800)]
Add basic checks for redefinition.
This adds some checks for redefined classes. Currently it checks that
the transformed class has the same name, interfaces, and access flags.
Other checks will be added in the future.
Test: mma -j40 test-art-host
Change-Id: Iaa94e9e8688db1985d15f27acf3ddb53908a1c8b
Nicolas Geoffray [Mon, 9 Jan 2017 14:02:45 +0000 (14:02 +0000)]
The HBoundsCheck should be the index input of String.charAt.
Otherwise, the charAt call may be licmed but the bounds check
stay in the loop.
bug:
33909430
bug:
28330359
Test: 632-checker-char-at-bounds
Change-Id: I3cb749785c26ff8a016a7103899e9b19a24d5022
Tao Wu [Sun, 8 Jan 2017 09:20:21 +0000 (01:20 -0800)]
Set timeout before connect to adb in jdwp.
Sometimes adb is in buggy status and just doesn't accept our
connection. Add a timeout in art side to make sure we aren't
stuck there.
Bug:
34140694
Test: mma -j40 test-art-host
Test: ./art/tools/run-jdwp-tests.sh --mode=host --variant=X64
Change-Id: Ia7756d5c03b57e87fe9642b0d32728aa6cead65c
Signed-off-by: Tao Wu <lepton@google.com>
Andreas Gampe [Mon, 9 Jan 2017 19:38:04 +0000 (11:38 -0800)]
ART: Add method code item functions
Add support for GetArgumentsSize, GetMaxLocals and GetMethodLocation
support. Add tests.
Bug:
34163329
Test: m test-art-host-run-test-910-methods
Change-Id: I14b5d02bf0513dc5a8d3f4ea17c849ab08b8554a
Treehugger Robot [Mon, 9 Jan 2017 21:04:09 +0000 (21:04 +0000)]
Merge "ART: Change no-image run-test dependency"
Hiroshi Yamauchi [Mon, 9 Jan 2017 20:26:01 +0000 (20:26 +0000)]
Merge "Simplify the collector names."
Treehugger Robot [Mon, 9 Jan 2017 20:25:59 +0000 (20:25 +0000)]
Merge "ART: Add trivial implementation of extensions"
Andreas Gampe [Mon, 9 Jan 2017 18:50:17 +0000 (10:50 -0800)]
ART: Add trivial implementation of extensions
We do not need extension support.
Bug:
31455788
Test: m test-art-host
Change-Id: I40e9435ad3ffee83070c522a1938509db4cc889e
Andreas Gampe [Mon, 9 Jan 2017 18:42:25 +0000 (10:42 -0800)]
ART: Change no-image run-test dependency
Let the no-image run-test Make configuration depend on the pic
image for prebuilding. This is what the run-test/run-test-jar
configuration will use.
Test: m ART_TEST_RUN_TEST_NO_IMAGE=true test-art-host && rm $ANDROID_HOST_OUT/framework/x86*/* && m ART_TEST_RUN_TEST_NO_IMAGE=true test-art-host
Change-Id: I5c02e76d5e51a63416705a58f733135b688158c2
Treehugger Robot [Mon, 9 Jan 2017 17:53:25 +0000 (17:53 +0000)]
Merge "ART: Add GetObjectSize and GetObjectHashCode"
Serban Constantinescu [Wed, 26 Oct 2016 10:15:00 +0000 (11:15 +0100)]
ARM: Instruction set features clean-up.
Clean-up the instruction set features for ARM. Remove all the CPU variants
that are not supported or used with ART.
Remove:
- Old cpu variants (eg: arm7tdmi - does not have the features needed by ART).
- M & R class cpu variants (currently ART only runs on A class cpus).
- cpu variants that are unlikely to be used with ART (eg: cyclone).
Test: mma test-art-target && mma test-art-host
Change-Id: I2b7e5169022ea0a5a943281381b9446c52e17364
Serban Constantinescu [Fri, 23 Sep 2016 10:06:03 +0000 (11:06 +0100)]
Remove the unused SMP instruction set feature option.
The SMP option is currently not used in the ART codebase
(and it rots away).
Single CPU systems that run SMP code should be able to deal
with it nicely (otherwise the CPU has some serious problems).
Test: mma test-art-target && mma test-art-host
Change-Id: Ifaab42b29de1062866a0af7525de2f834a4a5a57
Anton Kirilov [Fri, 6 Jan 2017 13:33:42 +0000 (13:33 +0000)]
Fix some issues reported by Valgrind
* Update the target suppression file.
* Disable the detection of mismatched free() / delete / delete []
calls, since it results in a lot of false positives (a known
Valgrind limitation associated with asymmetric inlining of
operator new() and operator delete()).
* Avoid a memory leak in the code generator tests, caused by the
fact that the VIXL-based ARM code generator does not always use
the arena allocator.
* Fix an access to uninitialized memory.
Test: m valgrind-test-art-target
Test: valgrind --leak-check=full --show-mismatched-frees=no \
--ignore-range-below-sp=1024-1 \
--suppressions=valgrind-target-suppressions.txt \
dalvikvm ...
Change-Id: I891a3247aa9828226b4e62c69d6e1c8398d757b8
Richard Uhler [Thu, 8 Dec 2016 09:48:01 +0000 (09:48 +0000)]
Do not return patchoat for dexopt needed.
Dex preopt now always compiles PIC, so patchoat is no longer needed to
relocate prebuilts on first boot or system update when the boot image is
relocated.
The only remaining case when patchoat would be used on oat files is the rare,
unexpected case when something bad happens to the device, such as a boot loop,
to cause the prebuilt boot image to be relocated again. In this case, non-PIC
oat files compiled on device may have up-to-date dex and image checksums but
wrong patch deltas. In this case, it is fine to recompile the oat file from
scratch using dex2oat rather than using patchoat.
Test: oat_file_assistant_test
Bug:
33192586
Change-Id: If3f2457c7b358e1328476a460a0f15bfa89b7def
rock.yeh [Fri, 23 Dec 2016 07:11:13 +0000 (15:11 +0800)]
Use relative futex timeout in SuspendAllInternal.
This erroneously used an absolute timeout for FUTEX_WAIT, potentially
causing it to block for MUCH longer than 10 seconds.
http://man7.org/linux/man-pages/man2/futex.2.html
Note: for FUTEX_WAIT, timeout is interpreted as a relative value.
Error case:
kernel time: 15842.476344
nsec:
31694950164731
12-22 20:25:48.020043 0 0 F [15842.476344][HeapTaskDaemon:3008]
futex_wait
00000070fcdf8980 1 1
31694950164731
Normal case:
kernel time: 15842.476344
nsec:
15842476344
Block backtrace:
"HeapTaskDaemon" sysTid=3008
#00 pc
000000000001bcac /system/lib64/libc.so (syscall+28)
#01 pc
0000000000461db0 /system/lib64/libart.so
(_ZN3art10ThreadList18SuspendAllInternalEPNS_6ThreadES2_S2_b+720)
#02 pc
000000000046249c /system/lib64/libart.so
(_ZN3art10ThreadList10SuspendAllEPKcb+532)
#03 pc
00000000001e8fc8 /system/lib64/libart.so
(_ZN3art2gc9collector9MarkSweep9RunPhasesEv+232)
#04 pc
00000000001e1694 /system/lib64/libart.so
(_ZN3art2gc9collector16GarbageCollector3RunENS0_7GcCauseEb+332)
#05 pc
0000000000211500 /system/lib64/libart.so
(_ZN3art2gc4Heap22CollectGarbageInternalENS0_9collector6GcTypeENS0_7Gc
CauseEb+3048)
#06 pc
0000000000218acc /system/lib64/libart.so
(_ZN3art2gc4Heap12ConcurrentGCEPNS_6ThreadEb+124)
#07 pc
000000000021fbf4 /system/lib64/libart.so
(_ZN3art2gc4Heap16ConcurrentGCTask3RunEPNS_6ThreadE+36)
This is a fix patch log and each timeout log interval of 10 seconds:
12-27 03:27:46.153744 1631 1713 E art : Unexpected time out during
suspend all.
12-27 03:27:56.154401 1631 1713 E art : Unexpected time out during
suspend all.
12-27 03:28:06.154956 1631 1713 E art : Unexpected time out during
suspend all.
Nicolas Geoffray [Sat, 7 Jan 2017 13:46:59 +0000 (13:46 +0000)]
Merge "Find the classpath boundary for being assignable to an interface."
Nicolas Geoffray [Wed, 21 Dec 2016 16:54:52 +0000 (16:54 +0000)]
Find the classpath boundary for being assignable to an interface.
Test: verifier_deps_test, test-art-host
Change-Id: Icab3a5a9f94f6a38fa8ef320f93ac14691a732d3
Dan Willemsen [Sat, 7 Jan 2017 07:14:05 +0000 (23:14 -0800)]
Remove oat-target* rules
This really only did anything for the 'mm' case, and was broken:
* Didn't find any apps (needed to search app/*/*.apk)
* Attempted to build framework/pm.odex instead of
framework/oat/arm/pm.odex.
* Caused Kati to re-read all the makefiles any time the contents of
system/app or system/framework changed.
Test: m -j installclean; m -j a (repeat until kati doesn't regenerate)
m -j pmlib; m -j a (doesn't regenerate)
Change-Id: Icca6556f0de952b8fbc740433272766a1ce5cdc9
Andreas Gampe [Sat, 7 Jan 2017 02:00:20 +0000 (18:00 -0800)]
ART: Add GetObjectSize and GetObjectHashCode
Add support for these two functions. Add tests.
Bug:
31684578
Test: m test-art-host-run-test-920-objects
Change-Id: If5dfb5aedddee47e5d739b0c56c7d264ba6e2d51
Treehugger Robot [Sat, 7 Jan 2017 02:20:28 +0000 (02:20 +0000)]
Merge "Revert "Revert "Create test for field access in obsolete methods."""
Treehugger Robot [Sat, 7 Jan 2017 02:07:08 +0000 (02:07 +0000)]
Merge "Make GetErrorName allocate the output buffer."
Treehugger Robot [Sat, 7 Jan 2017 01:55:10 +0000 (01:55 +0000)]
Merge "ART: Add GetClassLoader"
Andreas Gampe [Fri, 6 Jan 2017 23:50:55 +0000 (15:50 -0800)]
ART: Add GetClassLoader
Add support for GetClassLoader. Add a test.
Bug:
31684578
Test: m test-art-host-run-test-912-classes
Change-Id: I629ec2a1f4843bc3b28e40111805e250be44d993
Andreas Gampe [Fri, 6 Jan 2017 23:49:35 +0000 (23:49 +0000)]
Merge "ART: Add GetImplementedInterfaces"
Andreas Gampe [Fri, 6 Jan 2017 23:03:37 +0000 (23:03 +0000)]
Merge changes Ia14276d3,I7f063806
* changes:
ART: Add GetClassModifiers
ART: Add GetClassMethods
Hiroshi Yamauchi [Fri, 6 Jan 2017 23:03:26 +0000 (15:03 -0800)]
Simplify the collector names.
To make it easier to distinguish the collector names in the GC logs.
Bug:
12687968
Test: test-art-host with CC.
Change-Id: I23d06a4f8f4b0447d0904c0cb813e080277a2e9e
Alex Light [Fri, 6 Jan 2017 22:44:23 +0000 (14:44 -0800)]
Make GetErrorName allocate the output buffer.
Previously we were simply returning a static pointer which isn't
allowed by the spec.
Test: mma -j40 test-art-host
Change-Id: I84cfb81e58d479c7c0d5ee352f5b005183895c82
Alex Light [Fri, 6 Jan 2017 16:58:19 +0000 (16:58 +0000)]
Revert "Revert "Create test for field access in obsolete methods.""
This reverts commit
b710a0e0e32193d345a4bfeb93649de2503489be.
Reason for revert: Fixed test issue
Test: ART_TEST_RUN_TEST_NDEBUG=true mma -j40 test-art-host
Change-Id: I30b758a61afa0eb132af239e8071ea79eab58ac1
Andreas Gampe [Fri, 6 Jan 2017 22:20:39 +0000 (14:20 -0800)]
ART: Add GetImplementedInterfaces
Add support for GetImplementedInterfaces. Add a test. Add cleanup
to some existing tests.
Bug:
31684578
Test: m test-art-host-run-test-912-classes
Change-Id: Ic75bf3bba3b568232178d8525501122826b5a430
Andreas Gampe [Fri, 6 Jan 2017 21:07:19 +0000 (13:07 -0800)]
ART: Add GetClassModifiers
Add support for GetClassModifiers. Add a test.
Bug:
31684578
Test: m test-art-host-run-test-912-classes
Change-Id: Ia14276d3139503ce35f7684bd846b371e9eafa25
Treehugger Robot [Fri, 6 Jan 2017 21:07:06 +0000 (21:07 +0000)]
Merge "Also use ThreadList::Dump() in empty checkpoint timeout."