OSDN Git Service
Bruce Momjian [Tue, 7 Oct 2008 00:19:48 +0000 (00:19 +0000)]
Improve backend flowchart to show more detail.
Tom Lane [Tue, 7 Oct 2008 00:05:55 +0000 (00:05 +0000)]
Fix oversight in recent patch to support multiple read positions in
tuplestore: in READFILE state tuplestore_select_read_pointer must
save the current file seek position in the read pointer being
deactivated.
Tom Lane [Mon, 6 Oct 2008 20:29:38 +0000 (20:29 +0000)]
Fix up ruleutils.c for CTE features. The main problem was that
get_name_for_var_field didn't have enough context to interpret a reference to
a CTE query's output. Fixing this requires separate hacks for the regular
deparse case (pg_get_ruledef) and for the EXPLAIN case, since the available
context information is quite different. It's pretty nearly parallel to the
existing code for SUBQUERY RTEs, though. Also, add code to make sure we
qualify a relation name that matches a CTE name; else the CTE will mistakenly
capture the reference when reloading the rule.
In passing, fix a pre-existing problem with get_name_for_var_field not working
on variables in targetlists of SubqueryScan plan nodes. Although latent all
along, this wasn't a problem until we made EXPLAIN VERBOSE try to print
targetlists. To do this, refactor the deparse_context_for_plan API so that
the special case for SubqueryScan is all on ruleutils.c's side.
Tom Lane [Mon, 6 Oct 2008 17:39:26 +0000 (17:39 +0000)]
When expanding a whole-row Var into a RowExpr during ResolveNew(), attach
the column alias names of the RTE referenced by the Var to the RowExpr.
This is needed to allow ruleutils.c to correctly deparse FieldSelect nodes
referencing such a construct. Per my recent bug report.
Adding a field to RowExpr forces initdb (because of stored rules changes)
so this solution is not back-patchable; which is unfortunate because 8.2
and 8.3 have this issue. But it only affects EXPLAIN for some pretty odd
corner cases, so we can probably live without a solution for the back
branches.
Tom Lane [Mon, 6 Oct 2008 15:15:22 +0000 (15:15 +0000)]
Fix GetCTEForRTE() to deal with the possibility that the RTE it's given came
from a query level above the current ParseState.
Heikki Linnakangas [Mon, 6 Oct 2008 14:13:17 +0000 (14:13 +0000)]
Use fork names instead of numbers in the file names for additional
relation forks. While the file names are not visible to users, for those
that do peek into the data directory, it's nice to have more descriptive
names. Per Greg Stark's suggestion.
Tom Lane [Mon, 6 Oct 2008 13:59:37 +0000 (13:59 +0000)]
Editorial improvements to description of pg_settings view.
Magnus Hagander [Mon, 6 Oct 2008 13:05:40 +0000 (13:05 +0000)]
Add columns boot_val and reset_val to the pg_settings view, to expose
the value a parameter has at server start and will have after RESET,
respectively.
Greg Smith, with some modifications by me.
Heikki Linnakangas [Mon, 6 Oct 2008 08:04:11 +0000 (08:04 +0000)]
Index FSMs needs to be vacuumed as well. Report by Jeff Davis.
Tom Lane [Mon, 6 Oct 2008 05:03:27 +0000 (05:03 +0000)]
Random speculation about the reason for PPC64 buildfarm failures:
maybe isalnum is returning a value with the low-order byte all zero?
Tom Lane [Mon, 6 Oct 2008 02:55:20 +0000 (02:55 +0000)]
Experimental patch to see if it fixes MSVC builds ...
Tom Lane [Mon, 6 Oct 2008 02:12:56 +0000 (02:12 +0000)]
Fix the implicit-RTE code to be able to handle implicit RTEs for CTEs, as
well as regular tables. Per discussion, this seems necessary to meet the
principle of least astonishment.
In passing, simplify the error messages in warnAutoRange(). Now that we
have parser error position info for these errors, it doesn't seem very
useful to word the error message differently depending on whether we are
inside a sub-select or not.
Tom Lane [Mon, 6 Oct 2008 00:07:28 +0000 (00:07 +0000)]
Fix a missed case in int8-exp-three-digits.out, per buildfarm results.
Tom Lane [Sun, 5 Oct 2008 23:18:37 +0000 (23:18 +0000)]
Tweak the overflow checks in integer division functions to complain if the
machine produces zero (rather than the more usual minimum-possible-integer)
for the only possible overflow case. This has been seen to occur for at least
some word widths on some hardware, and it's cheap enough to check for
everywhere. Per Peter's analysis of buildfarm reports.
This could be back-patched, but in the absence of any gripes from the field
I doubt it's worth the trouble.
Tom Lane [Sun, 5 Oct 2008 22:50:55 +0000 (22:50 +0000)]
Improve behavior of WITH RECURSIVE with an untyped literal in the
non-recursive term. Per an example from Dickson S. Guedes.
Tom Lane [Sun, 5 Oct 2008 22:20:17 +0000 (22:20 +0000)]
Fix markTargetListOrigin() to not fail on a simple-Var reference to a
recursive CTE that we're still in progress of analyzing. Add a similar guard
to the similar code in expandRecordVariable(), and tweak regression tests to
cover this case. Per report from Dickson S. Guedes.
Peter Eisentraut [Sun, 5 Oct 2008 18:56:09 +0000 (18:56 +0000)]
Remove some unportable tests
Peter Eisentraut [Sun, 5 Oct 2008 17:33:17 +0000 (17:33 +0000)]
Remove obsolete internal functions istrue, isfalse, isnottrue, isnotfalse,
nullvalue, nonvalue. A long time ago, these were used to implement the SQL
constructs IS TRUE, etc.
Peter Eisentraut [Sun, 5 Oct 2008 15:46:35 +0000 (15:46 +0000)]
Reverse int8.out and int8-exp-three-digits.out mixup.
Peter Eisentraut [Sun, 5 Oct 2008 14:26:30 +0000 (14:26 +0000)]
Additional test coverage for int8 type (int8.c)
int8-exp-three-digits.out update untested, might need refinement.
Peter Eisentraut [Sun, 5 Oct 2008 14:20:03 +0000 (14:20 +0000)]
Additional test coverage for boolean type (bool.c)
Tom Lane [Sat, 4 Oct 2008 21:56:55 +0000 (21:56 +0000)]
Implement SQL-standard WITH clauses, including WITH RECURSIVE.
There are some unimplemented aspects: recursive queries must use UNION ALL
(should allow UNION too), and we don't have SEARCH or CYCLE clauses.
These might or might not get done for 8.4, but even without them it's a
pretty useful feature.
There are also a couple of small loose ends and definitional quibbles,
which I'll send a memo about to pgsql-hackers shortly. But let's land
the patch now so we can get on with other development.
Yoshiyuki Asaba, with lots of help from Tatsuo Ishii and Tom Lane
Peter Eisentraut [Sat, 4 Oct 2008 13:55:45 +0000 (13:55 +0000)]
Additional string function tests for coverage of oracle_compat.c
Tom Lane [Sat, 4 Oct 2008 02:19:08 +0000 (02:19 +0000)]
Add a note about how to check for bare < and & in SGML docs, before the
knowledge disappears again.
Peter Eisentraut [Fri, 3 Oct 2008 15:37:18 +0000 (15:37 +0000)]
Add regression test for macaddr type. Enhance documentation about accepted
input formats.
Peter Eisentraut [Fri, 3 Oct 2008 15:35:17 +0000 (15:35 +0000)]
Fix coverage targets so that HTML view is reliably updated when test data
changes. Add some documenting comments.
Peter Eisentraut [Fri, 3 Oct 2008 08:00:16 +0000 (08:00 +0000)]
Put back the copying of some of the regression test data files for vpath
builds. It is too complicated to fix in another way for now.
Heikki Linnakangas [Fri, 3 Oct 2008 07:33:10 +0000 (07:33 +0000)]
Add relation fork support to pg_relation_size() function. You can now pass
name of a fork ('main' or 'fsm', at the moment) to pg_relation_size() to
get the size of a specific fork. Defaults to 'main', if none given.
While we're at it, modify pg_relation_size to take a regclass as argument,
instead of separate variants taking oid and name. This change is
transparent to typical use where the table name is passed as a string
literal, like pg_relation_size('table'), but will break queries like
pg_relation_size(namecol), where namecol is of type name. text-type input
still works, and using a non-schema-qualified table name is not very
reliable anyway, so this is unlikely to break anyone's queries in practice.
Bruce Momjian [Thu, 2 Oct 2008 20:59:31 +0000 (20:59 +0000)]
Update README.HOT to reflect new snapshot tracking and xmin advancement
code in 8.4.
Tom Lane [Thu, 2 Oct 2008 13:47:38 +0000 (13:47 +0000)]
Fix improper display of fractional seconds in interval values
when using --enable-integer-datetimes and a non-ISO datestyle.
Ron Mayer
Tom Lane [Thu, 2 Oct 2008 12:25:25 +0000 (12:25 +0000)]
Partial fix for contrib vpath breakage.
Heikki Linnakangas [Thu, 2 Oct 2008 12:20:50 +0000 (12:20 +0000)]
Make the blkno arguments bigints instead of int4s. A signed int4 is not
large enough for block numbers higher than 2^31. The old pre-FSM-rewrite
pg_freespacemap implementation got this right. While we're at it, remove
some unnecessary #includes.
Heikki Linnakangas [Thu, 2 Oct 2008 10:26:51 +0000 (10:26 +0000)]
Fix function name in pg_freespacemap docs. It's "pg_freespace", not
"pg_freespacemap". Reported by hubert depesz lubaczewski.
Peter Eisentraut [Thu, 2 Oct 2008 08:11:11 +0000 (08:11 +0000)]
Update pg_regress calls in PL checks to handle vpath builds.
Peter Eisentraut [Wed, 1 Oct 2008 22:38:57 +0000 (22:38 +0000)]
Allow pg_regress to be run outside the build tree. Look for input files
in both input and output dir, to handle vpath builds more simply.
Tom Lane [Wed, 1 Oct 2008 19:51:50 +0000 (19:51 +0000)]
Improve tuplestore.c to support multiple concurrent read positions.
This facility replaces the former mark/restore support but is otherwise
upward-compatible with previous uses. It's expected to be needed for
single evaluation of CTEs and also for window functions, so I'm committing
it separately instead of waiting for either one of those patches to be
finished. Per discussion with Greg Stark and Hitoshi Harada.
Note: I removed nodeFunctionscan's mark/restore support, instead of bothering
to update it for this change, because it was dead code anyway.
Magnus Hagander [Wed, 1 Oct 2008 15:35:32 +0000 (15:35 +0000)]
Link libpq with libgssapi if configure finds it, as
required by at least NetBSD.
Markus Schaaf
Tom Lane [Wed, 1 Oct 2008 14:59:23 +0000 (14:59 +0000)]
Suppress an uninitialized-variable warning (not all versions of gcc
complain here, but some do)
Heikki Linnakangas [Wed, 1 Oct 2008 08:12:14 +0000 (08:12 +0000)]
Fix WAL redo of FSM truncation. We can't call smgrtruncate() during WAL
replay, because it tries to XLogInsert().
Tom Lane [Tue, 30 Sep 2008 14:15:58 +0000 (14:15 +0000)]
Fix compiler warning (unportable sprintf usage)
Tom Lane [Tue, 30 Sep 2008 12:51:07 +0000 (12:51 +0000)]
Fix misspelled comment
Heikki Linnakangas [Tue, 30 Sep 2008 11:17:07 +0000 (11:17 +0000)]
Rewrite pg_freespacemap to match the new FSM implementation. I missed these
changes from the main FSM commit for some reason.
Heikki Linnakangas [Tue, 30 Sep 2008 11:11:28 +0000 (11:11 +0000)]
Forgot to bump catalog version in the commit of FSM rewrite.
Heikki Linnakangas [Tue, 30 Sep 2008 10:52:14 +0000 (10:52 +0000)]
Rewrite the FSM. Instead of relying on a fixed-size shared memory segment, the
free space information is stored in a dedicated FSM relation fork, with each
relation (except for hash indexes; they don't use FSM).
This eliminates the max_fsm_relations and max_fsm_pages GUC options; remove any
trace of them from the backend, initdb, and documentation.
Rewrite contrib/pg_freespacemap to match the new FSM implementation. Also
introduce a new variant of the get_raw_page(regclass, int4, int4) function in
contrib/pageinspect that let's you to return pages from any relation fork, and
a new fsm_page_contents() function to inspect the new FSM pages.
Tom Lane [Sun, 28 Sep 2008 20:42:12 +0000 (20:42 +0000)]
Dept of second thoughts: let's make sure that get_index_stats_hook is only
applied to expression indexes, not to plain relations. The original coding
in btcostestimate conflated the two cases, but it's not hard to use
get_relation_stats_hook instead when we're looking to the underlying relation.
Tom Lane [Sun, 28 Sep 2008 19:51:40 +0000 (19:51 +0000)]
Add hooks to let plugins override the planner's lookups in pg_statistic.
Simon Riggs, with some editorialization by me.
Andrew Dunstan [Sat, 27 Sep 2008 16:53:54 +0000 (16:53 +0000)]
Compare escaped chars case insensitively for ILIKE - per gripe from TGL.
Tom Lane [Fri, 26 Sep 2008 15:35:28 +0000 (15:35 +0000)]
Fix pointer-advancement bugs in MS and US cases of new to_timestamp() code.
Alex Hunsaker
Tom Lane [Fri, 26 Sep 2008 02:16:40 +0000 (02:16 +0000)]
Make LIKE throw an error if the escape character is at the end of the pattern
(ie, has nothing to quote), rather than silently ignoring the character as has
been our historical behavior. This is required by SQL spec and should help
reduce the sort of user confusion seen in bug #4436. Per discussion.
This is not so much a bug fix as a definitional change, and it could break
existing applications; so not back-patched. It might deserve being mentioned
as an incompatibility in the 8.4 release notes.
Tom Lane [Thu, 25 Sep 2008 03:28:56 +0000 (03:28 +0000)]
Establish the rule that array types should have the same typdelim as their
element types. Since the backend doesn't actually pay attention to the array
type's delimiter, this has no functional effect, but it seems better for the
catalog entries to be consistent. Per gripe from Greg Mullane and subsequent
discussion.
Bruce Momjian [Wed, 24 Sep 2008 19:51:22 +0000 (19:51 +0000)]
Add documentation about when trigger values NEW/OLD return NULL.
Jeff Davis
Bruce Momjian [Wed, 24 Sep 2008 19:46:44 +0000 (19:46 +0000)]
Fix integral timestamps so the output is consistent in all cases to
round:
select interval '0:0:0.7', interval '@ 0.70 secs', interval '0.7
seconds';
Ron Mayer
Heikki Linnakangas [Wed, 24 Sep 2008 19:33:15 +0000 (19:33 +0000)]
Fix pg_dump bug in the database-level collation patch. "datcollate" and
"datctype" columns were misspelled. Per report from Chris Browne.
Tom Lane [Wed, 24 Sep 2008 16:52:46 +0000 (16:52 +0000)]
Fix more problems with rewriter failing to set Query.hasSubLinks when inserting
a SubLink expression into a rule query. We missed cases where the original
query contained a sub-SELECT in a function in FROM, a multi-row VALUES list,
or a RETURNING list. Per bug #4434 from Dean Rasheed and subsequent
investigation.
Back-patch to 8.1; older releases don't have the issue because they didn't
try to be smart about setting hasSubLinks only when needed.
Bruce Momjian [Wed, 24 Sep 2008 16:30:26 +0000 (16:30 +0000)]
Fix markup tag error, envvar -> envar.
Tom Lane [Wed, 24 Sep 2008 14:40:00 +0000 (14:40 +0000)]
Fix unportable syntax used in recent patch. Per results from
buildfarm member 'bear'.
Magnus Hagander [Wed, 24 Sep 2008 09:00:44 +0000 (09:00 +0000)]
Silence compiler warning caused by recent collation patch.
Magnus Hagander [Wed, 24 Sep 2008 08:59:42 +0000 (08:59 +0000)]
Make sure pg_control is opened in binary mode, to deal
with situtations when the file contains an EOF maker
(0x1A) on Windows.
ITAGAKI Takahiro
Magnus Hagander [Tue, 23 Sep 2008 21:12:03 +0000 (21:12 +0000)]
Only show source file and line numbers to superusers, for consistent
security level with other parts of the system.
Per gripe from Tom
Bruce Momjian [Tue, 23 Sep 2008 20:35:38 +0000 (20:35 +0000)]
Add comment about the use of EXEC_BACKEND.
Bruce Momjian [Tue, 23 Sep 2008 20:20:07 +0000 (20:20 +0000)]
Mention battery-backed cache under hardware selection options.
Heikki Linnakangas [Tue, 23 Sep 2008 10:58:03 +0000 (10:58 +0000)]
Tighten the check in initdb and CREATE DATABASE that the chosen encoding
matches the encoding of the locale. LC_COLLATE is now checked in addition
to LC_CTYPE.
Heikki Linnakangas [Tue, 23 Sep 2008 09:20:39 +0000 (09:20 +0000)]
Make LC_COLLATE and LC_CTYPE database-level settings. Collation and
ctype are now more like encoding, stored in new datcollate and datctype
columns in pg_database.
This is a stripped-down version of Radek Strnad's patch, with further
changes by me.
Tom Lane [Mon, 22 Sep 2008 14:21:44 +0000 (14:21 +0000)]
Get rid of pgpass_from_client tracking inside libpq --- given the conclusion
that presence of the password in the conninfo string must be checked *before*
risking a connection attempt, there is no point in checking it afterwards.
This makes the specification of PQconnectionUsedPassword() a bit simpler
and perhaps more generally useful, too.
Tom Lane [Mon, 22 Sep 2008 13:55:14 +0000 (13:55 +0000)]
Fix dblink_connect() so that it verifies that a password is supplied in the
conninfo string *before* trying to connect to the remote server, not after.
As pointed out by Marko Kreen, in certain not-very-plausible situations
this could result in sending a password from the postgres user's .pgpass file,
or other places that non-superusers shouldn't have access to, to an
untrustworthy remote server. The cleanest fix seems to be to expose libpq's
conninfo-string-parsing code so that dblink can check for a password option
without duplicating the parsing logic.
Joe Conway, with a little cleanup by Tom Lane
Tom Lane [Sun, 21 Sep 2008 19:38:56 +0000 (19:38 +0000)]
Simplify the definitions of a couple of system views by using SELECT *
instead of listing all the columns returned by the underlying function.
initdb not forced since this patch doesn't actually change anything about
the stored form of the views. It just means there's one less place to change
if someone wants to add columns to them.
Tom Lane [Fri, 19 Sep 2008 20:06:13 +0000 (20:06 +0000)]
Add a PQfireResultCreateEvents function to allow applications to mimic the
sequence of operations that libpq goes through while creating a PGresult.
Also, remove ill-considered "const" decoration on parameters passed to
event procedures.
Tom Lane [Fri, 19 Sep 2008 19:03:41 +0000 (19:03 +0000)]
Create a selectivity estimation function for the text search @@ operator.
Jan Urbanski
Tom Lane [Fri, 19 Sep 2008 16:40:40 +0000 (16:40 +0000)]
Improve the recently-added libpq events code to provide more consistent
guarantees about whether event procedures will receive DESTROY events.
They no longer need to defend themselves against getting a DESTROY
without a successful prior CREATE.
Andrew Chernow
Magnus Hagander [Fri, 19 Sep 2008 14:43:46 +0000 (14:43 +0000)]
Mark SessionReplicationRole as PGDLLIMPORT so it
can be used from Slony functions.
Per report from Hiroshi Saito.
Peter Eisentraut [Fri, 19 Sep 2008 13:08:08 +0000 (13:08 +0000)]
Add additional rules so that make init-po for ecpg gets up to date flex and
bison output. Without these, make can sometimes be tempted to invoke its
built-in rules using lex and yacc, which can fail if those commands are not
available.
This was a main cause for the NLS web site breakage.
Alvaro Herrera [Fri, 19 Sep 2008 04:57:10 +0000 (04:57 +0000)]
Optimize CleanupTempFiles by having a boolean flag that keeps track of whether
there are FD_XACT_TEMPORARY files to clean up at transaction end.
Per performance profiling results on AWeber's huge systems.
Patch by me after an idea suggested by Simon Riggs.
Tom Lane [Wed, 17 Sep 2008 20:57:35 +0000 (20:57 +0000)]
Preliminary release notes for upcoming back branch releases.
Tom Lane [Wed, 17 Sep 2008 14:18:39 +0000 (14:18 +0000)]
Update time zone data files to tzdata release 2008f (DST law changes in
Argentina, Bahamas, Brazil, Mauritius, Morocco, Pakistan, Palestine, Paraguay).
Tom Lane [Wed, 17 Sep 2008 13:15:55 +0000 (13:15 +0000)]
Allow ShowBufferUsage() to report the number of reads/writes that have
occurred to temporary files. This replaces the unused
NDirectFileRead/NDirectFileWrite counters.
Itagaki Takahiro
Tom Lane [Wed, 17 Sep 2008 04:31:08 +0000 (04:31 +0000)]
Add an "events" system to libpq, whereby applications can get callbacks that
enable them to manage private data associated with PGconns and PGresults.
Andrew Chernow and Merlin Moncure
Tom Lane [Tue, 16 Sep 2008 22:31:21 +0000 (22:31 +0000)]
Clean up a couple of weird corner cases in interval parsing: make -yyyy-mm be
interpreted as expected (the sign should affect months too), and get rid of
hard-wired assumption that unmarked signed values must be hours (if integers)
or seconds (if floats). The former was just a bug in my previous patch,
while the latter may have made sense at one time but seems illogical now
that we support determination of the units from typmod information.
Ron Mayer and myself.
Tom Lane [Tue, 16 Sep 2008 01:56:26 +0000 (01:56 +0000)]
Widen the nLocks counts in local lock tables from int to int64. This
forestalls potential overflow when the same table (or other object, but
usually tables) is accessed by very many successive queries within a single
transaction. Per report from Michael Milligan.
Back-patch to 8.0, which is as far back as the patch conveniently applies.
There have been no reports of overflow in pre-8.3 releases, but clearly the
risk existed all along. (Michael's report suggests that 8.3 may consume lock
counts faster than prior releases, but with no test case to look at it's hard
to be sure about that. Widening the counts seems a good future-proofing
measure in any event.)
Tom Lane [Tue, 16 Sep 2008 00:49:41 +0000 (00:49 +0000)]
Fix multiple memory leaks in xml_out(). Per report from Matt Magoffin.
Tom Lane [Mon, 15 Sep 2008 23:37:40 +0000 (23:37 +0000)]
Fix caching of foreign-key-checking queries so that when a replan is needed,
we regenerate the SQL query text not merely the plan derived from it. This
is needed to handle contingencies such as renaming of a table or column
used in an FK. Pre-8.3, such cases worked despite the lack of replanning
(because the cached plan needn't actually change), so this is a regression.
Per bug #4417 from Benjamin Bihler.
Magnus Hagander [Mon, 15 Sep 2008 20:55:04 +0000 (20:55 +0000)]
Fix error messages from recent pg_hba parsing patch to use errcontext()
to indicate where the error occurred.
Tom Lane [Mon, 15 Sep 2008 18:43:41 +0000 (18:43 +0000)]
Change hash indexes to store only the hash code rather than the whole indexed
value. This means that hash index lookups are always lossy and have to be
rechecked when the heap is visited; however, the gain in index compactness
outweighs this when the indexed values are wide. Also, we only need to
perform datatype comparisons when the hash codes match exactly, rather than
for every entry in the hash bucket; so it could also win for datatypes that
have expensive comparison functions. A small additional win is gained by
keeping hash index pages sorted by hash code and using binary search to reduce
the number of index tuples we have to look at.
Xiao Meng
This commit also incorporates Zdenek Kotala's patch to isolate hash metapages
and hash bitmaps a bit better from the page header datastructures.
Magnus Hagander [Mon, 15 Sep 2008 12:41:54 +0000 (12:41 +0000)]
Add missing quotes.
Magnus Hagander [Mon, 15 Sep 2008 12:32:57 +0000 (12:32 +0000)]
Parse pg_hba.conf in postmaster, instead of once in each backend for
each connection. This makes it possible to catch errors in the pg_hba
file when it's being reloaded, instead of silently reloading a broken
file and failing only when a user tries to connect.
This patch also makes the "sameuser" argument to ident authentication
optional.
Peter Eisentraut [Mon, 15 Sep 2008 12:18:00 +0000 (12:18 +0000)]
Avoid compiler warning about variable used before assigned.
Magnus Hagander [Mon, 15 Sep 2008 08:50:09 +0000 (08:50 +0000)]
Polish and Turkish FAQ also needed converting to UTF8
Magnus Hagander [Mon, 15 Sep 2008 08:40:46 +0000 (08:40 +0000)]
Convert Russian FAQ to UTF8, to make it render properly on the website.
Tom Lane [Fri, 12 Sep 2008 18:29:49 +0000 (18:29 +0000)]
Update citext's documentation to match the recently-applied patch,
per David Wheeler.
Tom Lane [Fri, 12 Sep 2008 14:56:13 +0000 (14:56 +0000)]
Skip opfamily check in eclass_matches_any_index() when the index isn't a
btree. We can't easily tell whether clauses generated from the equivalence
class could be used with such an index, so just assume that they might be.
This bit of over-optimization prevented use of non-btree indexes for nestloop
inner indexscans, in any case where the join uses an equality operator that
is also a btree operator --- which in particular is typically true for hash
indexes. Noted while trying to test the current hash index patch.
Peter Eisentraut [Fri, 12 Sep 2008 08:43:53 +0000 (08:43 +0000)]
Update man page build instructions.
Tom Lane [Thu, 11 Sep 2008 23:52:48 +0000 (23:52 +0000)]
Add a duration option to pgbench, so that test length can be specified in seconds
instead of by number of transactions to run. Takahiro Itagaki
Tom Lane [Thu, 11 Sep 2008 17:32:34 +0000 (17:32 +0000)]
Tighten up to_date/to_timestamp so that they are more likely to reject
erroneous input, rather than silently producing bizarre results as formerly
happened.
Brendan Jurd
Tom Lane [Thu, 11 Sep 2008 15:27:30 +0000 (15:27 +0000)]
Adjust the parser to accept the typename syntax INTERVAL ... SECOND(n)
and the literal syntax INTERVAL 'string' ... SECOND(n), as required by the
SQL standard. Our old syntax put (n) directly after INTERVAL, which was
a mistake, but will still be accepted for backward compatibility as well
as symmetry with the TIMESTAMP cases.
Change intervaltypmodout to show it in the spec's way, too. (This could
potentially affect clients, if there are any that analyze the typmod of an
INTERVAL in any detail.)
Also fix interval input to handle 'min:sec.frac' properly; I had overlooked
this case in my previous patch.
Document the use of the interval fields qualifier, which up to now we had
never mentioned in the docs. (I think the omission was intentional because
it didn't work per spec; but it does now, or at least close enough to be
credible.)
Alvaro Herrera [Thu, 11 Sep 2008 14:01:10 +0000 (14:01 +0000)]
Initialize the minimum frozen Xid in vac_update_datfrozenxid using
GetOldestXmin() instead of RecentGlobalXmin; this is safer because we do not
depend on the latter being correctly set elsewhere, and while it is more
expensive, this code path is not performance-critical. This is a real
risk for autovacuum, because it can execute whole cycles without doing
a single vacuum, which would mean that RecentGlobalXmin would stay at its
initialization value, FirstNormalTransactionId, causing a bogus value to be
inserted in pg_database. This bug could explain some recent reports of
failure to truncate pg_clog.
At the same time, change the initialization of RecentGlobalXmin to
InvalidTransactionId, and ensure that it's set to something else whenever
it's going to be used. Using it as FirstNormalTransactionId in HOT page
pruning could incur in data loss. InitPostgres takes care of setting it
to a valid value, but the extra checks are there to prevent "special"
backends from behaving in unusual ways.
Per Tom Lane's detailed problem dissection in 29544.
1221061979@sss.pgh.pa.us
Tom Lane [Wed, 10 Sep 2008 19:16:22 +0000 (19:16 +0000)]
Tweak newly added set_config_sourcefile() so that the target record
isn't left corrupt if guc_strdup should fail.
Tom Lane [Wed, 10 Sep 2008 18:29:41 +0000 (18:29 +0000)]
Make our parsing of INTERVAL literals spec-compliant (or at least a heck of
a lot closer than it was before). To do this, tweak coerce_type() to pass
through the typmod information when invoking interval_in() on an UNKNOWN
constant; then fix DecodeInterval to pay attention to the typmod when deciding
how to interpret a units-less integer value. I changed one or two other
details as well. I believe the code now reacts as expected by spec for all
the literal syntaxes that are specifically enumerated in the spec. There
are corner cases involving strings that don't exactly match the set of fields
called out by the typmod, for which we might want to tweak the behavior some
more; but I think this is an area of user friendliness rather than spec
compliance. There remain some non-compliant details about the SQL syntax
(as opposed to what's inside the literal string); but at least we'll throw
error rather than silently doing the wrong thing in those cases.
Alvaro Herrera [Wed, 10 Sep 2008 18:09:20 +0000 (18:09 +0000)]
Add "source file" and "source line" information to each GUC variable.
initdb forced due to changes in the pg_settings view.
Magnus Hagander and Alvaro Herrera.
Tom Lane [Wed, 10 Sep 2008 17:01:07 +0000 (17:01 +0000)]
Avoid using sprintf() for a simple octal conversion in PQescapeByteaInternal.
Improves performance, per suggestion from Rudolf Leitgeb (bug #4414).
The backend did this right already, but not libpq.
Tom Lane [Wed, 10 Sep 2008 01:09:45 +0000 (01:09 +0000)]
Fix a couple of places where the plpgsql grammar would produce an unhelpful
'syntax error' message, rather than something that might draw one's
attention to a missing or wrong-type variable declaration. Per recent
gripe.
Tom Lane [Tue, 9 Sep 2008 18:58:09 +0000 (18:58 +0000)]
Improve the plan cache invalidation mechanism to make it invalidate plans
when user-defined functions used in a plan are modified. Also invalidate
plans when schemas, operators, or operator classes are modified; but for these
cases we just invalidate everything rather than tracking exact dependencies,
since these types of objects seldom change in a production database.
Tom Lane; loosely based on a patch by Martin Pihlak.