OSDN Git Service

android-x86/system-bt.git
4 years agoAdd remote cid insertion to packet for transmission
Chris Manton [Fri, 8 Nov 2019 19:10:28 +0000 (11:10 -0800)]
Add remote cid insertion to packet for transmission
am: dee1a25870

Change-Id: Ifbc4e4ccb671cbbda36e2c98561807d851f93658

4 years agoAdd remote cid insertion to packet for transmission
Chris Manton [Fri, 8 Nov 2019 05:42:09 +0000 (21:42 -0800)]
Add remote cid insertion to packet for transmission

The remote cid is inserted into the packet to identify
the proper destination channel endpoint for data
packets.

Bug: 143697964
Test: Verified using wireshark

Change-Id: Iab2faa2f767b67810b39559e780a0aee6d3df464

4 years agoSuppress logging qualcomm debug unknown handle message
Chris Manton [Fri, 8 Nov 2019 07:10:17 +0000 (23:10 -0800)]
Suppress logging qualcomm debug unknown handle message
am: 578888176b

Change-Id: I61ec2083fad50d97022bc005f620bc97425850a3

4 years agoL2CAP: Notify DynamicChannel open after configuration is done
Hansong Zhang [Fri, 8 Nov 2019 05:36:58 +0000 (21:36 -0800)]
L2CAP: Notify DynamicChannel open after configuration is done
am: 6662d506e8

Change-Id: I2cdcf48c58b242d2528def38fbeb601ba7551c7c

4 years agoSuppress logging qualcomm debug unknown handle message
Chris Manton [Thu, 7 Nov 2019 23:43:37 +0000 (15:43 -0800)]
Suppress logging qualcomm debug unknown handle message

Bug: 143697964
Test: Verified logging messages suppressed during operation

Change-Id: Ic38bb6addbec348ef38d0801322d006109ad377a

4 years agoL2CAP: Notify DynamicChannel open after configuration is done
Hansong Zhang [Fri, 8 Nov 2019 01:09:00 +0000 (17:09 -0800)]
L2CAP: Notify DynamicChannel open after configuration is done

DynamicChannel is usable only after two-way configuration is done. Also
we need to cancel alarm when we receive a response for signalling
packet.

Test: cert/run_cert.sh
Bug: 141557006
Change-Id: Iff769fda8af277734566a74327e85ddd4b78771a

4 years agoHCI: Add LeScanningManager
Myles Watson [Thu, 7 Nov 2019 20:29:49 +0000 (12:29 -0800)]
HCI: Add LeScanningManager
am: 73ffe7659a

Change-Id: Icfe3605e68724271bbb80be64e0ba06c2dfc9e4d

4 years agoHCI: Make Controller getters virtual and const
Myles Watson [Thu, 7 Nov 2019 20:29:44 +0000 (12:29 -0800)]
HCI: Make Controller getters virtual and const
am: f3916a0504

Change-Id: Ica8afb5194a81ea1f8d5e6cbbd77b4a9562dd1b4

4 years agoHCI: Add LeScanningManager
Myles Watson [Fri, 18 Oct 2019 17:49:46 +0000 (10:49 -0700)]
HCI: Add LeScanningManager

Bug: 139080884
Test: bluetooth_test_gd
Change-Id: Ie0aee4042330e2789727aaffda818279b71e02ca

4 years agoHCI: Make Controller getters virtual and const
Myles Watson [Thu, 7 Nov 2019 18:26:54 +0000 (10:26 -0800)]
HCI: Make Controller getters virtual and const

Getters that are virtual and const make testing easier for
modules that depend on the controller.

Bug: 139080884
Test: bluetooth_test_gd
Change-Id: Icde03e69f1ebd19c819a6b443665a6de0721505e

4 years agoRootCanal: update last_le_advertisement_
Chienyuan [Thu, 7 Nov 2019 13:28:33 +0000 (05:28 -0800)]
RootCanal: update last_le_advertisement_
am: 1290e969ee

Change-Id: If7ac690de6e10a4a13218536fc1336950c373582

4 years agoRootCanal: update last_le_advertisement_
Chienyuan [Thu, 7 Nov 2019 09:37:26 +0000 (17:37 +0800)]
RootCanal: update last_le_advertisement_

Test: run_cert.sh
Change-Id: I1411ab07361c0d7fca7b262fa1a53892b614eb9a

4 years agoMerge "Hci: Add extended scanning packets to hci_packets"
Myles Watson [Wed, 6 Nov 2019 23:38:25 +0000 (15:38 -0800)]
Merge "Hci: Add extended scanning packets to hci_packets"
am: 0f0d6e2d19

Change-Id: I89e1c4bfc3b1d6f0db5042f8cce59e7af582b1bc

4 years agoMerge "Hci: Add extended scanning packets to hci_packets"
Treehugger Robot [Wed, 6 Nov 2019 23:20:46 +0000 (23:20 +0000)]
Merge "Hci: Add extended scanning packets to hci_packets"

4 years agoadd legacy shim l2cap tests
Chris Manton [Wed, 6 Nov 2019 22:44:21 +0000 (14:44 -0800)]
add legacy shim l2cap tests
am: c8c5a88094

Change-Id: I556413954544d598f5b073c61a36bb10b57e773d

4 years agoHci: Add extended scanning packets to hci_packets
Myles Watson [Wed, 6 Nov 2019 19:08:04 +0000 (11:08 -0800)]
Hci: Add extended scanning packets to hci_packets

LeSetExtendedScanParameters
LeSetExtendedScanEnable
LeExtendedScanParams

Bug: 139080884
Test: builds
Change-Id: Id7e528c1343c8c885d4a0d2997dbff01bc42f920

4 years agoMerge "Remove unused module"
Chris Manton [Wed, 6 Nov 2019 17:00:56 +0000 (09:00 -0800)]
Merge "Remove unused module"
am: a95e34592b

Change-Id: I2cc5ca53fad2bab2e5652ee0fa6f5223f280ec8c

4 years agoadd legacy shim l2cap tests
Chris Manton [Tue, 5 Nov 2019 19:39:07 +0000 (11:39 -0800)]
add legacy shim l2cap tests

Bug: 143697964
Test: out/host/linux-x86/nativetest64/bluetooth_test_legacy/bluetooth_test_legacy

Change-Id: I67166a5e0f7e6733bb695026d89ef226c4eae2c1

4 years agoMerge "Remove unused module"
Treehugger Robot [Wed, 6 Nov 2019 16:47:51 +0000 (16:47 +0000)]
Merge "Remove unused module"

4 years agoMerge "Revert "RootCanal: Upgrade the LinkLayer in RootCanal to PDL""
Chienyuan Huang [Wed, 6 Nov 2019 15:16:19 +0000 (07:16 -0800)]
Merge "Revert "RootCanal: Upgrade the LinkLayer in RootCanal to PDL""
am: 1286c303ac

Change-Id: I6063da0f4d8b5e84c3021eb03508856e4d268aa2

4 years agoMerge "Cert: remove unregister_controllers"
Chienyuan [Wed, 6 Nov 2019 15:14:00 +0000 (07:14 -0800)]
Merge "Cert: remove unregister_controllers"
am: 0b682131d4

Change-Id: Ic5af55421dfd1afd37cd7a3fe78f6383f28d2d6a

4 years agoMerge "Revert "RootCanal: Upgrade the LinkLayer in RootCanal to PDL""
Treehugger Robot [Wed, 6 Nov 2019 13:52:57 +0000 (13:52 +0000)]
Merge "Revert "RootCanal: Upgrade the LinkLayer in RootCanal to PDL""

4 years agoRevert "RootCanal: Upgrade the LinkLayer in RootCanal to PDL"
Chienyuan Huang [Wed, 6 Nov 2019 12:52:58 +0000 (12:52 +0000)]
Revert "RootCanal: Upgrade the LinkLayer in RootCanal to PDL"

This reverts commit 52aac47002c7c7743c5b9f755add77c13e564f61.

Reason for revert: need more stress test
Bug: 143877063

Change-Id: Idf0f6e2f874b7ae5569a6857abc71f7e697699e4

4 years agoMerge "Cert: remove unregister_controllers"
Treehugger Robot [Wed, 6 Nov 2019 12:17:16 +0000 (12:17 +0000)]
Merge "Cert: remove unregister_controllers"

4 years agoMerge "Remove unused events in acl manager"
Chris Manton [Wed, 6 Nov 2019 08:29:02 +0000 (00:29 -0800)]
Merge "Remove unused events in acl manager"
am: d5f1e626e0

Change-Id: I6de2afc50b952e3f0829feb82e045af01f06359d

4 years agoMerge "Remove unused events in acl manager"
Treehugger Robot [Wed, 6 Nov 2019 08:03:42 +0000 (08:03 +0000)]
Merge "Remove unused events in acl manager"

4 years agoCert: remove unregister_controllers
Chienyuan [Wed, 6 Nov 2019 08:02:42 +0000 (16:02 +0800)]
Cert: remove unregister_controllers

Bug: 144002854
Test: run_cert.sh
Change-Id: I3ec164e82f9a045a4c10dc08b941d8c4634ec984

4 years agoRemove unused events in acl manager
Chris Manton [Tue, 5 Nov 2019 23:11:27 +0000 (15:11 -0800)]
Remove unused events in acl manager

Bug: 143697964
Test: Boots into gd without crashing
Change-Id: I344ef68cde2221b4d526c1fe347c92758f22b80a

4 years agoMerge "Add avrcp_device_fuzz."
Mitch Phillips [Wed, 6 Nov 2019 02:24:06 +0000 (18:24 -0800)]
Merge "Add avrcp_device_fuzz."
am: 8466ef4d9c

Change-Id: I4680c634a6baf3615cf5cf21bf56786d6b8dd799

4 years agoMerge "Add avrcp_device_fuzz."
Treehugger Robot [Wed, 6 Nov 2019 02:05:41 +0000 (02:05 +0000)]
Merge "Add avrcp_device_fuzz."

4 years agoRemove unused module
Chris Manton [Tue, 5 Nov 2019 23:12:51 +0000 (15:12 -0800)]
Remove unused module

Bug: 143697964
Test: Boots into Gd without crashing
Change-Id: Idbf807aeee7e911ed3c0e9c5c891219683e318ff

4 years agoMerge "Rootcanal: Le resolving list hci cmds"
Calvin Huang [Tue, 5 Nov 2019 23:01:26 +0000 (15:01 -0800)]
Merge "Rootcanal: Le resolving list hci cmds"
am: bb0d621d7a

Change-Id: I7436b677f50e972eaec75ac3ab2cf68e592887fb

4 years agoMerge "Rootcanal: Le resolving list hci cmds"
Treehugger Robot [Tue, 5 Nov 2019 22:44:45 +0000 (22:44 +0000)]
Merge "Rootcanal: Le resolving list hci cmds"

4 years agoMerge "Standardize l2cap shim naming"
Chris Manton [Tue, 5 Nov 2019 20:29:05 +0000 (12:29 -0800)]
Merge "Standardize l2cap shim naming"
am: 7f2b95e390

Change-Id: If53d309fd3263997b1548fc1fb5ca8ca98f2f4ba

4 years agoMerge "Standardize l2cap shim naming"
Treehugger Robot [Tue, 5 Nov 2019 20:14:33 +0000 (20:14 +0000)]
Merge "Standardize l2cap shim naming"

4 years agoMerge "[system][bt] fix -Wimplicit-fallthrough"
Nick Desaulniers [Tue, 5 Nov 2019 20:02:17 +0000 (12:02 -0800)]
Merge "[system][bt] fix -Wimplicit-fallthrough"
am: 119ba692eb

Change-Id: I442f92a48889168b428491515bee452cf84d96bb

4 years agoMerge "[system][bt] fix -Wimplicit-fallthrough"
Treehugger Robot [Tue, 5 Nov 2019 19:27:24 +0000 (19:27 +0000)]
Merge "[system][bt] fix -Wimplicit-fallthrough"

4 years agoStandardize l2cap shim naming
Chris Manton [Tue, 5 Nov 2019 05:11:18 +0000 (21:11 -0800)]
Standardize l2cap shim naming

Bug: 143697964
Test: bluetooth_test_gd

Change-Id: I565ba159c95848591780116b09655ff23edbe842

4 years agoMerge "Initial security manager API create/remove bond."
Martin Brabham [Tue, 5 Nov 2019 17:26:14 +0000 (09:26 -0800)]
Merge "Initial security manager API create/remove bond."
am: 97935e845e

Change-Id: I56563a361112134c54bcdb1858a8d0e576009e17

4 years agoMerge "Initial security manager API create/remove bond."
Treehugger Robot [Tue, 5 Nov 2019 16:57:05 +0000 (16:57 +0000)]
Merge "Initial security manager API create/remove bond."

4 years agoRootcanal: Le resolving list hci cmds
Calvin Huang [Fri, 1 Nov 2019 23:35:55 +0000 (16:35 -0700)]
Rootcanal: Le resolving list hci cmds

HciLeAddDeviceToResolvingList
HciLeRemoveDeviceFromResolvingList
HciLeClearResolvingList
HciLeSetPrivacyMode

Bug: 138260499
Test: run run_device_cert.sh
Change-Id: I6b9eb84d2fb3925ba556eeea7c52c7cc7b47aa44

4 years agoMerge "[system][bt] address -Wimplicit-fallthrough"
Nick Desaulniers [Tue, 5 Nov 2019 01:36:13 +0000 (17:36 -0800)]
Merge "[system][bt] address -Wimplicit-fallthrough"
am: 3266acff6f

Change-Id: I28b4ad697522d385b004f92f837873baf8709313

4 years agoHCI: Add Fragmentation
Myles Watson [Tue, 5 Nov 2019 01:33:59 +0000 (17:33 -0800)]
HCI: Add Fragmentation
am: b6a5ecf540

Change-Id: Icde40ad88494bc62b3e51b1b000057b35134e6e7

4 years agoMerge "[system][bt] address -Wimplicit-fallthrough"
Nick Desaulniers [Tue, 5 Nov 2019 00:12:14 +0000 (00:12 +0000)]
Merge "[system][bt] address -Wimplicit-fallthrough"

4 years ago[system][bt] address -Wimplicit-fallthrough
Nick Desaulniers [Fri, 1 Nov 2019 16:05:35 +0000 (09:05 -0700)]
[system][bt] address -Wimplicit-fallthrough

The compiler upgrade in b/139945549 can now check C code for
-Wimplicit-fallthrough. In b/143713277, were moving the cflags for
projects that disable this warning to cppflags. For this subsystem, just
address the warnings and remove disabling it.

These cases should be carefully reviewed; modifications that weren't
additions of fallthrough attributes were likely existing bugs.

Bug: 139945549
Bug: 143713277
Test: mm
Change-Id: Icafeed1d18991e83f42e5efd13e8ab8d15068d79
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
4 years agoHCI: Add Fragmentation
Myles Watson [Tue, 29 Oct 2019 23:31:14 +0000 (16:31 -0700)]
HCI: Add Fragmentation

Bug: 141921396
Test: builds
Change-Id: I9741755987461558509dbc22613cd9e26338af23

4 years agoMerge "[system][bt] fix -Wc99-designator"
Nick Desaulniers [Mon, 4 Nov 2019 20:12:16 +0000 (12:12 -0800)]
Merge "[system][bt] fix -Wc99-designator"
am: 341e3cb7c7

Change-Id: Iaee95ebfca731a69f996f9584f7df49d4c9c7ca9

4 years agoMerge "[system][bt] fix -Wc99-designator"
Treehugger Robot [Mon, 4 Nov 2019 19:54:27 +0000 (19:54 +0000)]
Merge "[system][bt] fix -Wc99-designator"

4 years agoMerge "Connect inquiry API query implementation"
Chris Manton [Mon, 4 Nov 2019 19:48:51 +0000 (11:48 -0800)]
Merge "Connect inquiry API query implementation"
am: 512d6de79e

Change-Id: I7916dfbb8e0dc6ae57775b47d2ce484f9d46c63c

4 years agoL2CAP: Dequeue next request if previous response is invalid
Hansong Zhang [Mon, 4 Nov 2019 19:43:04 +0000 (11:43 -0800)]
L2CAP: Dequeue next request if previous response is invalid
am: 6f1ec72e73

Change-Id: I8d9781c9d633d077dee5130cdb8b28a3cc73d8f9

4 years agoMerge "Connect inquiry API query implementation"
Treehugger Robot [Mon, 4 Nov 2019 19:41:00 +0000 (19:41 +0000)]
Merge "Connect inquiry API query implementation"

4 years agoL2CAP: Dequeue next request if previous response is invalid
Hansong Zhang [Mon, 4 Nov 2019 18:12:02 +0000 (10:12 -0800)]
L2CAP: Dequeue next request if previous response is invalid

If we drop the invalid response packet without dequeuing next request,
the outgoing request queue will stuck. We should dequeue it as long as
the signalling id matches.

Also fix the scid/dcid mismatch in cert stack.

Test: cert/run_cert.sh. test_open_two_channels should be fixed.
Bug: 141557006
Change-Id: Id4dd9f279ece55aa5e78443c8027df91af1dd7c8

4 years agoInitial security manager API create/remove bond.
Martin Brabham [Fri, 29 Mar 2019 19:02:30 +0000 (12:02 -0700)]
Initial security manager API create/remove bond.

 - Main manager implementation and tests
 - Channel implementation and tests

Bug: 142341184
Test: atest --host -t bluetooth_test_gd:SecurityManagerTest bluetooth_test_gd:SecurityManagerChannelTest
Change-Id: I6291b1219d2e5cde6a4d770c9267e20860a164ae

4 years agoConnect inquiry API query implementation
Chris Manton [Mon, 4 Nov 2019 18:00:55 +0000 (10:00 -0800)]
Connect inquiry API query implementation

Bug: 143697964
Test: Verified inquiry sequence on actual device
Change-Id: I75721aa2db56c6fa28d322d3b08a32991e6d37b1

4 years agoMerge "Return matching device in CreateDatabase when called twice"
Martin Brabham [Mon, 4 Nov 2019 17:53:34 +0000 (09:53 -0800)]
Merge "Return matching device in CreateDatabase when called twice"
am: 64c649904e

Change-Id: I1771c66b66b52c59bd72e826cac6befa18645b8e

4 years agoMerge "RootCanal:Add Hci cmds"
Calvin Huang [Mon, 4 Nov 2019 17:53:03 +0000 (09:53 -0800)]
Merge "RootCanal:Add Hci cmds"
am: 2b3c42a964

Change-Id: I95b997343754c6849cf8e5d14334d4c6ece95292

4 years agoMerge "Return matching device in CreateDatabase when called twice"
Treehugger Robot [Mon, 4 Nov 2019 17:41:30 +0000 (17:41 +0000)]
Merge "Return matching device in CreateDatabase when called twice"

4 years agoReturn matching device in CreateDatabase when called twice
Martin Brabham [Mon, 4 Nov 2019 03:11:55 +0000 (19:11 -0800)]
Return matching device in CreateDatabase when called twice

Bug: N/A
Test: atest --host -t bluetooth_test_gd:DeviceTest bluetooth_test_gd:DeviceDatabaseTest bluetooth_test_gd:DualDeviceTest
Change-Id: Ic8df7da1f3f003994acbdde773e2131b614d3def

4 years agoMerge "RootCanal:Add Hci cmds"
Treehugger Robot [Mon, 4 Nov 2019 17:38:12 +0000 (17:38 +0000)]
Merge "RootCanal:Add Hci cmds"

4 years agoMerge "RootCanal: Upgrade the LinkLayer in RootCanal to PDL"
Chienyuan [Sun, 3 Nov 2019 00:36:29 +0000 (17:36 -0700)]
Merge "RootCanal: Upgrade the LinkLayer in RootCanal to PDL"
am: 0c9f7ee2cb

Change-Id: I26fcbdbbaa906a0cf6b6beae014fc369cd3da176

4 years agoMerge "RootCanal: Upgrade the LinkLayer in RootCanal to PDL"
Treehugger Robot [Sun, 3 Nov 2019 00:28:31 +0000 (00:28 +0000)]
Merge "RootCanal: Upgrade the LinkLayer in RootCanal to PDL"

4 years agoMerge "Expose psm value through l2cap classic service"
Chris Manton [Fri, 1 Nov 2019 22:22:29 +0000 (15:22 -0700)]
Merge "Expose psm value through l2cap classic service"
am: e63a120951

Change-Id: I15d9c9004429ad052611a20f3c44f3e638d8989c

4 years agoMerge "Expose psm value through l2cap classic service"
Treehugger Robot [Fri, 1 Nov 2019 21:59:08 +0000 (21:59 +0000)]
Merge "Expose psm value through l2cap classic service"

4 years agoMerge "Use proper PBF boundary for upper layer packets"
Chris Manton [Fri, 1 Nov 2019 21:08:03 +0000 (14:08 -0700)]
Merge "Use proper PBF boundary for upper layer packets"
am: 61b86ee115

Change-Id: Ieda83730679b5e0369750fd857675082511086db

4 years agoMerge "Use proper PBF boundary for upper layer packets"
Chris Manton [Fri, 1 Nov 2019 20:46:16 +0000 (20:46 +0000)]
Merge "Use proper PBF boundary for upper layer packets"

4 years agoExpose psm value through l2cap classic service
Chris Manton [Fri, 1 Nov 2019 20:28:45 +0000 (13:28 -0700)]
Expose psm value through l2cap classic service

Test: Compiles
Bug: 143697964

Change-Id: I87c81491581fb55bda942f26f3fa3a6bf4989a08

4 years ago[system][bt] fix -Wc99-designator
Nick Desaulniers [Fri, 1 Nov 2019 20:25:56 +0000 (13:25 -0700)]
[system][bt] fix -Wc99-designator

Fixes the observed warning:
error: mixture of designated and non-designated initializers in the same
initializer list is a C99 extension [-Werror,-Wc99-designator]

Bug: 143622397
Test: mm
Change-Id: I5835e729979d8fb3f928821d4cd6aff693b14ab7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
4 years agoMerge "Add information request after acl connect"
Chris Manton [Fri, 1 Nov 2019 17:57:47 +0000 (10:57 -0700)]
Merge "Add information request after acl connect"
am: f207913f6d

Change-Id: Ieb99220a0fd0aafa0eed34864528172aeeff2561

4 years agoMerge changes I238c23f5,I7c7b8045
Chris Manton [Fri, 1 Nov 2019 17:57:19 +0000 (10:57 -0700)]
Merge changes I238c23f5,I7c7b8045
am: 56d3bc0d21

Change-Id: I130edc1ecea001a94f02d7c70bfc86a1c2e5ac79

4 years agoMerge "Add information request after acl connect"
Treehugger Robot [Fri, 1 Nov 2019 17:31:34 +0000 (17:31 +0000)]
Merge "Add information request after acl connect"

4 years agoMerge changes I238c23f5,I7c7b8045
Treehugger Robot [Fri, 1 Nov 2019 17:31:28 +0000 (17:31 +0000)]
Merge changes I238c23f5,I7c7b8045

* changes:
  Extend l2cap functionality for CoC
  Swap cid parameters

4 years agoRootCanal: Upgrade the LinkLayer in RootCanal to PDL
Chienyuan [Thu, 31 Oct 2019 06:01:28 +0000 (14:01 +0800)]
RootCanal: Upgrade the LinkLayer in RootCanal to PDL

Bug: 140384404
Test: run_cert.sh
Change-Id: I913c345f7bd6eb258c3c70ebce1a38a1fa4a764f

4 years agoMerge "HCI Classic ACL: Queue pending connection requests"
Hansong Zhang [Fri, 1 Nov 2019 05:21:39 +0000 (22:21 -0700)]
Merge "HCI Classic ACL: Queue pending connection requests"
am: b6f973ee83

Change-Id: I3af0ca8d9104e261592c7ebcd7a354625e2f4cfc

4 years agoMerge "HCI Classic ACL: Queue pending connection requests"
Treehugger Robot [Fri, 1 Nov 2019 05:15:32 +0000 (05:15 +0000)]
Merge "HCI Classic ACL: Queue pending connection requests"

4 years agoAdd information request after acl connect
Chris Manton [Thu, 31 Oct 2019 21:36:02 +0000 (14:36 -0700)]
Add information request after acl connect

The 2 information requests are optional, but convention
by legacy android stack and other devices I've tested against
send these commands after acl connection.

Bug: 143697964
Test: Verified on actual device with wireshark

Change-Id: Idd651ac30e8d843c88105f4145756320c0f68902

4 years agoExtend l2cap functionality for CoC
Chris Manton [Fri, 1 Nov 2019 03:39:11 +0000 (20:39 -0700)]
Extend l2cap functionality for CoC

Keep packets flowing after reception
Add search for channel using remote id

Bug: 143697964
Test: Verified using wireshark

Change-Id: I238c23f58f215316223bf28548422759016bc8ab

4 years agoSwap cid parameters
Chris Manton [Thu, 31 Oct 2019 23:19:14 +0000 (16:19 -0700)]
Swap cid parameters

Confusingly the destination cid in this packet is actually the cid
of the remote and the source cid is the cid of the local.

Bug: 143697964
Test: Verified correct behavior on wireshark
Change-Id: I7c7b80458d91c2cbd48b5990ae9202fc062cd59b

4 years agoUse proper PBF boundary for upper layer packets
Chris Manton [Thu, 31 Oct 2019 21:32:18 +0000 (14:32 -0700)]
Use proper PBF boundary for upper layer packets

Test: Verified with legacy stack
Bug: 143697964
Change-Id: I13a602e08c337180767b0a219804c964a5947506

4 years agoRootCanal:Add Hci cmds
Calvin Huang [Fri, 1 Nov 2019 02:12:25 +0000 (19:12 -0700)]
RootCanal:Add Hci cmds

Add HciReadEncryptionKeySize and HciWriteSecureConnectionHostSupport

Bug: 138260499
Test: run run_device_cert.sh
Change-Id: Icd49a9e0b3fbbbeedf180946a8ba4801ea18a2b8

4 years agoMerge changes Iec8b53b8,I6f74be04
Myles Watson [Thu, 31 Oct 2019 23:56:03 +0000 (16:56 -0700)]
Merge changes Iec8b53b8,I6f74be04
am: e4fe73706e

Change-Id: I9ac3517f64071375dcb0cbd26e142e61c4854157

4 years agoMerge changes Iec8b53b8,I6f74be04
Treehugger Robot [Thu, 31 Oct 2019 23:43:02 +0000 (23:43 +0000)]
Merge changes Iec8b53b8,I6f74be04

* changes:
  packet: Add Fragmentation
  packet: Add Append for reassembly

4 years agoHCI Classic ACL: Queue pending connection requests
Hansong Zhang [Thu, 31 Oct 2019 16:50:08 +0000 (09:50 -0700)]
HCI Classic ACL: Queue pending connection requests

* Send next connection request after connection_complete event, if there
is already a pending outgoing connection_request,
accept_connection_request, or reject_connection_request.
* Don't allow sending connection_request, or accept connection, if there
is already a device with same Address connected.
* Also fix a memory leak in grpc_root_server and inquiry_test.

Bug: 143620554
Test: bluetooth_test_gd and cert/run_cert.sh
Change-Id: I4ea321eafa7857bfa3ad3fdfa0ebfa07a162ff4b

4 years agopacket: Add Fragmentation
Myles Watson [Tue, 29 Oct 2019 23:31:14 +0000 (16:31 -0700)]
packet: Add Fragmentation

Bug: 141921396
Test: builds
Change-Id: Iec8b53b83b9ba3efbee8b45738161d3db5cf0837

4 years agopacket: Add Append for reassembly
Myles Watson [Wed, 30 Oct 2019 18:19:48 +0000 (11:19 -0700)]
packet: Add Append for reassembly

Bug: 141921396
Test: bluetooth_test_gd --gtest_filter=*MultiViewAppend*
Change-Id: I6f74be0406bb2fae5713782dee0f6874386d7e17

4 years agoMerge "DO NOT MERGE - qt-qpr1-dev-plus-aosp-without-vendor@5915889 into stage-aosp...
TreeHugger Robot [Thu, 31 Oct 2019 18:38:50 +0000 (18:38 +0000)]
Merge "DO NOT MERGE - qt-qpr1-dev-plus-aosp-without-vendor@5915889 into stage-aosp-master" into stage-aosp-master

4 years agoMerge changes I9693f8e4,I3568a3dc
Hansong Zhang [Thu, 31 Oct 2019 17:01:47 +0000 (10:01 -0700)]
Merge changes I9693f8e4,I3568a3dc
am: 56fb21419f

Change-Id: I01a0c0df72e01da859dfb84ee437439efa4521f1

4 years agoMerge changes I9693f8e4,I3568a3dc
Treehugger Robot [Thu, 31 Oct 2019 16:35:47 +0000 (16:35 +0000)]
Merge changes I9693f8e4,I3568a3dc

* changes:
  L2CAP Classic Cert: Auto generate cid for incoming request
  L2CAP: Fix SignallingManager request queuing

4 years agoMerge "Signal id of zero is silently ignored per spec"
Chris Manton [Thu, 31 Oct 2019 06:19:37 +0000 (23:19 -0700)]
Merge "Signal id of zero is silently ignored per spec"
am: 0d739b0da2

Change-Id: I2726be8bf93bd483d8ff33b83b53a949b2bdb1ea

4 years agoMerge "Signal id of zero is silently ignored per spec"
Treehugger Robot [Thu, 31 Oct 2019 05:53:42 +0000 (05:53 +0000)]
Merge "Signal id of zero is silently ignored per spec"

4 years agoMerge changes I33b0ace1,I3af9a79d
Chris Manton [Thu, 31 Oct 2019 00:22:00 +0000 (17:22 -0700)]
Merge changes I33b0ace1,I3af9a79d
am: e7fb7c087d

Change-Id: I9b069f443e789943f352c002c5e2916cd594a5d4

4 years agoMerge changes I33b0ace1,I3af9a79d
Treehugger Robot [Thu, 31 Oct 2019 00:01:36 +0000 (00:01 +0000)]
Merge changes I33b0ace1,I3af9a79d

* changes:
  Separate out connect actions for initiate/target
  Remove channel connection timeouts

4 years agoL2CAP Classic Cert: Auto generate cid for incoming request
Hansong Zhang [Wed, 30 Oct 2019 23:43:39 +0000 (16:43 -0700)]
L2CAP Classic Cert: Auto generate cid for incoming request

Previously the scid on cert side was hardcoded. Instead, let the cert
stack generate one, from kFirstDynamicChannelForIncomingRequest.

Test: run_cert_test
Bug: 143543622
Change-Id: I9693f8e4666c80bb62fedd0d94163e38f71211ae

4 years agoMerge "Revert "RootCanal: Upgrade the LinkLayer in RootCanal to PDL""
Colin Cross [Wed, 30 Oct 2019 21:38:07 +0000 (14:38 -0700)]
Merge "Revert "RootCanal: Upgrade the LinkLayer in RootCanal to PDL""
am: 0634491d10

Change-Id: I7e3cc7c54ba0eb5baeb5bf4a7b3ea965ce9ec128

4 years agoL2CAP: Fix SignallingManager request queuing
Hansong Zhang [Mon, 28 Oct 2019 21:55:02 +0000 (14:55 -0700)]
L2CAP: Fix SignallingManager request queuing

We should always wait for an outgoing request to be handled before
sending the next one. Fix the logic in queuing.

Test: run_cert_test.sh
Bug: 141557006
Change-Id: I3568a3dca4857f1ba4fa47618408f40e2f1f7d04

4 years agoMerge "Revert "RootCanal: Upgrade the LinkLayer in RootCanal to PDL""
Colin Cross [Wed, 30 Oct 2019 20:39:36 +0000 (20:39 +0000)]
Merge "Revert "RootCanal: Upgrade the LinkLayer in RootCanal to PDL""

4 years agoDO NOT MERGE - qt-qpr1-dev-plus-aosp-without-vendor@5915889 into stage-aosp-master
Xin Li [Wed, 30 Oct 2019 18:50:41 +0000 (11:50 -0700)]
DO NOT MERGE - qt-qpr1-dev-plus-aosp-without-vendor@5915889 into stage-aosp-master

Bug: 142003500
Change-Id: I9273c7462b91567750d149aee63f91635e1c3fc9

4 years agoSeparate out connect actions for initiate/target
Chris Manton [Tue, 29 Oct 2019 23:28:29 +0000 (16:28 -0700)]
Separate out connect actions for initiate/target

One connect path is soliciated the other as a response
to the service being listened on.

Bug: 141758481
Test: Compiles and bluetooth_test_gd

Change-Id: I33b0ace1c3b691632db9a89ed85892187d3c5fed

4 years agoRemove channel connection timeouts
Chris Manton [Wed, 30 Oct 2019 18:31:41 +0000 (11:31 -0700)]
Remove channel connection timeouts

Defer timeout to lower layer.
Remove hex values for psms
Formalize cid name change to abstract away actual l2cap channel
identifiers from clients.
  (cid) channel_id ==>  connection interface descriptor

Bug: 141758481
Test: Compiles
Change-Id: I3af9a79d7fd721d0d58b131e15cdd7c0204b90cf

4 years agoRevert "RootCanal: Upgrade the LinkLayer in RootCanal to PDL"
Cody Schuffelen [Wed, 30 Oct 2019 18:39:20 +0000 (18:39 +0000)]
Revert "RootCanal: Upgrade the LinkLayer in RootCanal to PDL"

This reverts commit f58a420f29d3d37fcbceb5b8ce8c5dd12ecc3124.

Reason for revert: Crashing on cuttlefish
Bug: 143621633

Change-Id: I2dcd365093ba68c8d917e5a029484b0a7e132ce6

4 years agoSignal id of zero is silently ignored per spec
Chris Manton [Wed, 30 Oct 2019 18:14:09 +0000 (11:14 -0700)]
Signal id of zero is silently ignored per spec

Must initialize with a valid signal id.

Bug: 141758481
Test: Verified connection response recieved with non-zero signal id
Change-Id: Icf0ca6a3404759da3734c2d760683a71063340a4