git.osdn.net Git - android-x86/system-bt.git/log

(root) / android-x86 / system-bt.git / log

Hansong Zhang [Mon, 31 Aug 2020 19:36:39 +0000 (19:36 +0000)]

Remove unused log to improve readability am: 92ddaf3500

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1415696

Change-Id: Id21349f79bf406346f23d30dd9ff508a4f01eb89

commit | commitdiff | tree

Hansong Zhang [Mon, 31 Aug 2020 19:36:35 +0000 (19:36 +0000)]

Only RFCOMM Uses btm_sec_mx_access_request am: c05b125733

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1414911

Change-Id: I1a3767e4b7e3963110f273fbe12bf09e859bb1de

commit | commitdiff | tree

Hansong Zhang [Sun, 30 Aug 2020 22:59:18 +0000 (15:59 -0700)]

Remove unused log to improve readability

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I1ab7ef85730f6d5c857f12c1bf54db1d17d503d2

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 22:41:45 +0000 (15:41 -0700)]

Only RFCOMM Uses btm_sec_mx_access_request

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I992a5477f71e630531d29c720f51e8473a551eff

commit | commitdiff | tree

Treehugger Robot [Mon, 31 Aug 2020 17:12:31 +0000 (17:12 +0000)]

Merge changes I93466084,I1e1ed49c,Id825a84e am: 4a31743313

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1413991

Change-Id: I38d76c645b9c9dbf30cfcefb1466932c965d8c0b

commit | commitdiff | tree

Treehugger Robot [Mon, 31 Aug 2020 16:57:00 +0000 (16:57 +0000)]

Merge changes I93466084,I1e1ed49c,Id825a84e

* changes:
  Add API stack/l2cap/l2c_ble::l2cble_conn_comp_from_address_with_type
  Add API stack/acl/btm_acl::acl_link_role_from_handle
  Add btm_identity_addr_to_random_pseudo_from_address_with_type

commit | commitdiff | tree

Zach Johnson [Mon, 31 Aug 2020 15:44:35 +0000 (15:44 +0000)]

Merge changes I5719d43c,Ia756d0fa,Iba08e90a,Ia5d1b195,I678011f4, ... am: 5003bafea4

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1415692

Change-Id: I1c0101f2ed97869ff5f324c58df3067d32bbece5

commit | commitdiff | tree

Zach Johnson [Mon, 31 Aug 2020 15:27:14 +0000 (15:27 +0000)]

Merge changes I5719d43c,Ia756d0fa,Iba08e90a,Ia5d1b195,I678011f4, ...

* changes:
  Replace unreadable AG state machine
  good riddance AV stream state machine
  Replace AV non state machine function table
  Replace BTA AV state machine
  Flatten bta_hd_sm_execute
  Remove unused parameter from bta_hd_vc_unplug_act
  Remove unused parameter from bta_hd_disconnect_act
  Remove unused parameter from bta_hd_unregister_act
  Replace unreadable HD state machine
  Replace HH unreadable state machine
  BTA_HH_LE_INCLUDED is always true
  Remove unreferenced mce file & headers
  btif_mce_get_interface is never called
  Callbacks are never used
  Remove MCE code that now no longer does anything
  BTA_MceGetRemoteMasInstances does nothing
  bta_mce_get_remote_mas_instances is never referenced
  bta_mce_enable is never referenced
  bta_mce_sm_execute is never referenced
  Remove now unused BTA_MceEnable
  btif_mce_execute_service is never called
  booleans are a thing for a reason
  Simplify BTA_SdpCreate/RemoveRecordByUser
  Simplfy BTA_SdpSearch
  simplify BTA_SdpEnable
  Burninate SDP "state machine"

commit | commitdiff | tree

Chris Manton [Thu, 27 Aug 2020 16:49:14 +0000 (09:49 -0700)]

Add API stack/l2cap/l2c_ble::l2cble_conn_comp_from_address_with_type

Towards readable code

Bug: 163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I93466084b186f972fc572d9c076db52fdc23b89c

commit | commitdiff | tree

Chris Manton [Mon, 17 Aug 2020 23:09:35 +0000 (16:09 -0700)]

Add API stack/acl/btm_acl::acl_link_role_from_handle

Bug: 162984360
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I1e1ed49c3f0d489c4e087f0520d2626d7d300b94

commit | commitdiff | tree

Chris Manton [Thu, 27 Aug 2020 17:28:39 +0000 (10:28 -0700)]

Add btm_identity_addr_to_random_pseudo_from_address_with_type

Towards readable code

Bug: 163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Id825a84e4ffabc0f0d42a97410c0622643bb0516

commit | commitdiff | tree

Chris Manton [Mon, 31 Aug 2020 08:29:51 +0000 (08:29 +0000)]

Add API stack/btm/btm_ble::btm_ble_connected_from_address_with_type am: aa83ca2ab1

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1413990

Change-Id: I8db5123d0b0e1f68c32a6e2de5e8c198c436ec37

commit | commitdiff | tree

Chris Manton [Mon, 31 Aug 2020 08:29:50 +0000 (08:29 +0000)]

Streamline stack/btm/btm_ble::btm_ble_connected am: ae2a56f23b

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1413188

Change-Id: I7bcda96072b76d1196fc75d07411df9ea748abf6

commit | commitdiff | tree

Chris Manton [Mon, 31 Aug 2020 08:29:48 +0000 (08:29 +0000)]

Add gd acl init flag am: adda403c4c

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1405273

Change-Id: I8e54a10f495a585b23f0ee538cfba12cb0836ad7

commit | commitdiff | tree

Chris Manton [Thu, 27 Aug 2020 16:44:19 +0000 (09:44 -0700)]

Add API stack/btm/btm_ble::btm_ble_connected_from_address_with_type

Towards readable code

Bug: 163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I829bd8c510a41a2d56faeacb91a4478d4f0e4ce9

commit | commitdiff | tree

Chris Manton [Thu, 27 Aug 2020 04:45:19 +0000 (21:45 -0700)]

Streamline stack/btm/btm_ble::btm_ble_connected

Towards readable code

Bug: 163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Iad0e19c806b57778cda859f9bf2b45386ab427ed

commit | commitdiff | tree

Chris Manton [Wed, 19 Aug 2020 20:36:54 +0000 (13:36 -0700)]

Add gd acl init flag

Tag: #gd-refactor
Bug: 159815595
Test: cert/run --host
Change-Id: If8344697c48a4a68eeb7606905c1d3b14e3da43a

commit | commitdiff | tree

Treehugger Robot [Mon, 31 Aug 2020 04:05:50 +0000 (04:05 +0000)]

Merge "Remove unnecessary command check" am: 208e046154

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1415693

Change-Id: Ifd78cbea3fde9ac5f905fb7349403a252bc309e8

commit | commitdiff | tree

Treehugger Robot [Mon, 31 Aug 2020 03:49:46 +0000 (03:49 +0000)]

Merge "Remove unnecessary command check"

commit | commitdiff | tree

Chris Manton [Sun, 30 Aug 2020 19:59:27 +0000 (19:59 +0000)]

Add new api stack/acl/ble_acl::acl_ble__complete am: aedeefc290

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1414000

Change-Id: I865e7eef3d45e70d00a3646a21b1673599eb5c57

commit | commitdiff | tree

Chris Manton [Sun, 30 Aug 2020 19:59:25 +0000 (19:59 +0000)]

Remove unused defs am: 5a20cf1674

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1412077

Change-Id: Ib69b91dbd275d513edd2a7b7da230e61d9599bb7

commit | commitdiff | tree

Chris Manton [Sun, 30 Aug 2020 19:59:23 +0000 (19:59 +0000)]

Remove tBT_TRANSPORT from acl_refresh_remote_address am: 132fefe378

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1413993

Change-Id: I10f1f39bfd8f9747817d0f7487554fe2c3f079ff

commit | commitdiff | tree

Chris Manton [Sun, 30 Aug 2020 19:59:21 +0000 (19:59 +0000)]

enum-ify tBTM_BLE_CONN_ST am: 218716ea25

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1415688

Change-Id: I1161d23e89254b72db822367ad1cb135e2a8ffc1

commit | commitdiff | tree

Chris Manton [Sun, 30 Aug 2020 19:59:19 +0000 (19:59 +0000)]

Add helpers to stack/include/bt_types::tBLE_BD_ADDR am: 3abbc0520f

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1414371

Change-Id: I0b1a3a985c5cfff47b005d3b06fe0ab97de4b0cb

commit | commitdiff | tree

Chris Manton [Sun, 30 Aug 2020 18:58:51 +0000 (11:58 -0700)]

Remove unnecessary command check

Test fix complements
https://android-review.googlesource.com/c/platform/system/bt/+/1409768

Bug: 155399771
Test: bluetooth_test_gd
--gtest_filter=LeExtendedAdvertisingManagerTest.create_advertiser_tes
Tag: #gd-refactor

Change-Id: I19f37f82624c4daaeea6a2e8f61fdd92ea442d4a

commit | commitdiff | tree

Zach Johnson [Sun, 30 Aug 2020 17:51:38 +0000 (10:51 -0700)]

Replace unreadable AG state machine

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I5719d43ccc8f378766bef82b0af94694c2f1f2f7

commit | commitdiff | tree

Zach Johnson [Sun, 30 Aug 2020 17:14:36 +0000 (10:14 -0700)]

good riddance AV stream state machine

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ia756d0fa09529918b2f9a7638613831989a5d986

commit | commitdiff | tree

Chris Manton [Thu, 27 Aug 2020 18:45:27 +0000 (11:45 -0700)]

Add new api stack/acl/ble_acl::acl_ble__complete

Towards readable code

Bug: 163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ia7814ef21e2e06197df8354796318f824f21e19c

commit | commitdiff | tree

Chris Manton [Thu, 27 Aug 2020 00:58:37 +0000 (17:58 -0700)]

Remove unused defs

Towards readable code

Bug: 163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ia1f71f374b9d84b819e071e6317eb2fc72576d27

commit | commitdiff | tree

Chris Manton [Thu, 27 Aug 2020 17:08:07 +0000 (10:08 -0700)]

Remove tBT_TRANSPORT from acl_refresh_remote_address

By definition this always requires LE transport

Towards readable code

Bug: 163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ia209c486a181700ae687cda99ebd8e3b91443c30

commit | commitdiff | tree

Chris Manton [Sun, 30 Aug 2020 03:47:05 +0000 (20:47 -0700)]

enum-ify tBTM_BLE_CONN_ST

Towards readable code

Bug: 163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I6abd2e511178562e5bc199e60bcd4b167c601a54

commit | commitdiff | tree

Chris Manton [Thu, 27 Aug 2020 22:33:39 +0000 (15:33 -0700)]

Add helpers to stack/include/bt_types::tBLE_BD_ADDR

Towards readable code

Bug: 163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I399924925467f2505836908e331ea24030789f8e

commit | commitdiff | tree

Zach Johnson [Sun, 30 Aug 2020 16:07:51 +0000 (09:07 -0700)]

Replace AV non state machine function table

switch connects the event id to the function itself more closely

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Iba08e90a55c7dbde2181ca7fd76277df10688572

commit | commitdiff | tree

Zach Johnson [Sun, 30 Aug 2020 16:00:44 +0000 (09:00 -0700)]

Replace BTA AV state machine

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ia5d1b19565dddf9ac94ceff688b8a74ce245dc67

commit | commitdiff | tree

Zach Johnson [Sat, 29 Aug 2020 17:25:53 +0000 (10:25 -0700)]

Flatten bta_hd_sm_execute

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I678011f408c41ef990a3f3b46f39614f5a57b3ee

commit | commitdiff | tree

Zach Johnson [Sat, 29 Aug 2020 17:19:04 +0000 (10:19 -0700)]

Remove unused parameter from bta_hd_vc_unplug_act

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I291c8d725c06f88273841fa85eb1d7d44a891c24

commit | commitdiff | tree

Zach Johnson [Sat, 29 Aug 2020 17:17:57 +0000 (10:17 -0700)]

Remove unused parameter from bta_hd_disconnect_act

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I34f1b75567f5f76c6acaa11bf78d3550bcde76d0

commit | commitdiff | tree

Zach Johnson [Sat, 29 Aug 2020 17:16:50 +0000 (10:16 -0700)]

Remove unused parameter from bta_hd_unregister_act

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Iefae3c72524d7349da92ad63db39129d9202ec2a

commit | commitdiff | tree

Zach Johnson [Sat, 29 Aug 2020 17:12:24 +0000 (10:12 -0700)]

Replace unreadable HD state machine

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I0d8ac9b2b123981fbfa5677f72fc187d8c20c45c

commit | commitdiff | tree

Treehugger Robot [Sat, 29 Aug 2020 04:33:04 +0000 (04:33 +0000)]

Merge "role is unused" am: 85fd1e009c

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1414929

Change-Id: Id280974c023b2ef8d76fcb8f0490e8678682f323

commit | commitdiff | tree

Treehugger Robot [Sat, 29 Aug 2020 04:16:22 +0000 (04:16 +0000)]

Merge "role is unused"

commit | commitdiff | tree

Chris Manton [Sat, 29 Aug 2020 03:48:16 +0000 (03:48 +0000)]

Create stack/include/ble_hci_link_interface am: 648c5bb5a0

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1412076

Change-Id: Iddfaff1f515ab66d4d14e00f8b00b7e3729025d9

commit | commitdiff | tree

Chris Manton [Sat, 29 Aug 2020 01:21:59 +0000 (01:21 +0000)]

Remove unused defs TRACE_ stack/include/bt_types.h am: debbd630a2

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1415351

Change-Id: Ie3cd3241630fe887bc10e6d5be4fff8ffc5a9662

commit | commitdiff | tree

Chris Manton [Sat, 29 Aug 2020 01:21:58 +0000 (01:21 +0000)]

Move def BLE_ADDR_TYPE_ID_BIT closer to relatives am: 649d4bdb52

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1415350

Change-Id: Ib854faadfc544d7b4fb3729fb6e8e66d60c22e60

commit | commitdiff | tree

Chris Manton [Sat, 29 Aug 2020 01:21:56 +0000 (01:21 +0000)]

Remove unused defs BLE_ADDR_IS_STATIC am: 5da8afde4f

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1415349

Change-Id: Ief9cf6b81c4d60da8f19f73f6867cac0ea3d2a11

commit | commitdiff | tree

Chris Manton [Sat, 29 Aug 2020 01:21:54 +0000 (01:21 +0000)]

Use local constant for service/low_energy_client am: d6134ce12e

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1415348

Change-Id: I9a5596554f4a6b8f2c58dc0750a25bc1a7ebbb45

commit | commitdiff | tree

Chris Manton [Thu, 27 Aug 2020 00:53:57 +0000 (17:53 -0700)]

Create stack/include/ble_hci_link_interface

Towards proper interfaces

Bug: 163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I99a8e02fa0f6448245271aa722f92b0943fd6849

commit | commitdiff | tree

Zach Johnson [Sat, 29 Aug 2020 00:37:27 +0000 (17:37 -0700)]

Replace HH unreadable state machine

this is slightly more readable

future patches can simplify this a bit more

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I190fcecca2d7f66c3877e3b4a0ee886d0cf3d721

commit | commitdiff | tree

Zach Johnson [Fri, 28 Aug 2020 23:52:39 +0000 (16:52 -0700)]

BTA_HH_LE_INCLUDED is always true

stop corrupting the code formatting

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I0b5dd0a15c4ab73f2e4a9eb9c01cb3f94b02b2fd

commit | commitdiff | tree

Chris Manton [Fri, 28 Aug 2020 23:34:22 +0000 (16:34 -0700)]

Remove unused defs TRACE_ stack/include/bt_types.h

Towards readable code

Bug: 163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I89a528d780f5bc2643a742368ae52a0df5ebd4ed

commit | commitdiff | tree

Chris Manton [Fri, 28 Aug 2020 22:24:00 +0000 (15:24 -0700)]

Move def BLE_ADDR_TYPE_ID_BIT closer to relatives

Towards readable code

Bug: 163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ib4f9f1a670b9a029f54eebc97035a33d79539bee

commit | commitdiff | tree

Chris Manton [Fri, 28 Aug 2020 21:40:32 +0000 (14:40 -0700)]

Remove unused defs BLE_ADDR_IS_STATIC

And:
PHY_LE_1M_MASK
PHY_LE_2M_MASK
PHY_LE_CODED_MASK
BLE_ADDR_TYPE_MASK

Towards readable code

Bug: 163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I1d5f20fb16e4845b5b4150393b467c2d9f683bf5

commit | commitdiff | tree

Chris Manton [Fri, 28 Aug 2020 21:42:50 +0000 (14:42 -0700)]

Use local constant for service/low_energy_client

PHY_LE_1M_MASK

Towards readable code

Bug: 163134718
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I6bdecd0a24181a62faab53ef64e85347af1215d0

commit | commitdiff | tree

Zach Johnson [Fri, 28 Aug 2020 23:27:22 +0000 (16:27 -0700)]

Remove unreferenced mce file & headers

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I5f9a8ff41e9905298fc955c1fcf5fb0018f52760

commit | commitdiff | tree

Zach Johnson [Fri, 28 Aug 2020 23:23:45 +0000 (16:23 -0700)]

btif_mce_get_interface is never called

remove statics that are no longer referenced

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I7d09765e225ef25a80dedf24c81a629a7910fe60

commit | commitdiff | tree

Zach Johnson [Fri, 28 Aug 2020 23:18:41 +0000 (16:18 -0700)]

Callbacks are never used

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I3bdc9627d072d27a8b7f911342575f4400abfd97

commit | commitdiff | tree

Zach Johnson [Fri, 28 Aug 2020 23:08:50 +0000 (16:08 -0700)]

Remove MCE code that now no longer does anything

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: If97d3f702f30d957f75dcda9a792deea4696358a

commit | commitdiff | tree

Zach Johnson [Fri, 28 Aug 2020 23:03:29 +0000 (16:03 -0700)]

BTA_MceGetRemoteMasInstances does nothing

the state machine that handles this does not exist
anymore, since it was never actually registered.

delete delete delete

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I2e96eef51205d8ee2c36866cd64a56796266bc64

commit | commitdiff | tree

Zach Johnson [Fri, 28 Aug 2020 22:59:34 +0000 (15:59 -0700)]

bta_mce_get_remote_mas_instances is never referenced

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Id7586339efb0c325aa58d6501147a90a74526bab

commit | commitdiff | tree

Zach Johnson [Fri, 28 Aug 2020 22:57:39 +0000 (15:57 -0700)]

bta_mce_enable is never referenced

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I9c206f21641623395f98d4f556e40cbdf4cb22ce

commit | commitdiff | tree

Zach Johnson [Fri, 28 Aug 2020 22:55:12 +0000 (15:55 -0700)]

bta_mce_sm_execute is never referenced

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Id6488edfe6466de7a9e2ab9d6a40259d5245b121

commit | commitdiff | tree

Zach Johnson [Fri, 28 Aug 2020 22:48:38 +0000 (15:48 -0700)]

Remove now unused BTA_MceEnable

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: If7f46048da5a3eb87a4f8e1dd111a0ec4e44cef9

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 21:14:12 +0000 (14:14 -0700)]

role is unused

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I092c176d244409bb96120a968284709a1fb745c6

commit | commitdiff | tree

Zach Johnson [Fri, 28 Aug 2020 22:41:47 +0000 (15:41 -0700)]

btif_mce_execute_service is never called

also remove orphaned static functions
the compiler complained about

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I15513e28422d66c06745781987054ce61d4f083f

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 22:38:34 +0000 (22:38 +0000)]

L2CA_SetIdleTimeout is unused am: 193df8156d

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1415049

Change-Id: Id677f1e5bebde308f823cb6e7db90bc54ad17894

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 22:38:33 +0000 (22:38 +0000)]

p_tcb->att_lcid is always L2CAP_ATT_CID am: 6f879be680

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1415048

Change-Id: I8459ea135df590bdb1fd3fd76daf2f7c90ad5c33

commit | commitdiff | tree

Zach Johnson [Fri, 28 Aug 2020 22:18:43 +0000 (15:18 -0700)]

booleans are a thing for a reason

so don't create an enum that looks like
a boolean and doesn't add any helpful context

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I1b43513dd49e1bec17695783cb5e370f306892fc

commit | commitdiff | tree

Zach Johnson [Fri, 28 Aug 2020 22:14:27 +0000 (15:14 -0700)]

Simplify BTA_SdpCreate/RemoveRecordByUser

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I27826c96110cf9c3b533a26275cb7eb22edc1dcf

commit | commitdiff | tree

Zach Johnson [Fri, 28 Aug 2020 22:08:56 +0000 (15:08 -0700)]

Simplfy BTA_SdpSearch

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I7b3459a08d98db2f2de3e4beaf94117e0fdb1a1c

commit | commitdiff | tree

Zach Johnson [Fri, 28 Aug 2020 22:01:51 +0000 (15:01 -0700)]

simplify BTA_SdpEnable

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Icda2d2d0a1499c87691481f53b8b5c0008dbb98b

commit | commitdiff | tree

Zach Johnson [Fri, 28 Aug 2020 21:53:06 +0000 (14:53 -0700)]

Burninate SDP "state machine"

yeah it's not a real state machine

first step to cleaning up the object passing

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I78985e8284cd02ce538954c58c8d51945885c23d

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 21:09:42 +0000 (21:09 +0000)]

L2CAP_HIGH_PRI_CHAN_QUOTA_IS_CONFIGURABLE is unused am: 784c8b32d4

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1414928

Change-Id: I5431f67c6a10f5f90bb9a41ad33f3bba4d18505d

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 20:14:15 +0000 (13:14 -0700)]

L2CA_SetIdleTimeout is unused

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Iadfc923936e0fcd2f64454d3d989bceb79e5cb6f

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 20:12:26 +0000 (13:12 -0700)]

p_tcb->att_lcid is always L2CAP_ATT_CID

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: If4eacc4c2650188a7952d5bb2387c5d835d1fa4e

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 18:06:55 +0000 (11:06 -0700)]

L2CAP_HIGH_PRI_CHAN_QUOTA_IS_CONFIGURABLE is unused

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I03c91cd0d9b1162eedf87a77451730bab7109883

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 17:45:49 +0000 (17:45 +0000)]

Remove unused code in bta_sys.h am: f56fd33169

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1414295

Change-Id: I623dabf345edd306bbcc5635c6f8f3194be71f08

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 17:45:47 +0000 (17:45 +0000)]

no_smp_on_br is never true am: b664d7c988

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1414294

Change-Id: I49c996f3461d514a0342b1411ed8dbb063191c2d

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 17:45:44 +0000 (17:45 +0000)]

Remove unused code in l2c_api.h am: 1398ab8eed

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1414293

Change-Id: I8e64b78ad91fcedd04a26d79d3d8ee8fecd3dd22

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 17:45:40 +0000 (17:45 +0000)]

p_nocp_cb is never set am: 1cd1238c69

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1414292

Change-Id: I832da1cabfc563c25404361f995c164493208242

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 12:47:46 +0000 (12:47 +0000)]

pL2CA_CreditsReceived_Cb is no longer useful am: c666229f40

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1413765

Change-Id: Ic11567265a7965194b076e26ab0648ff6303cf7a

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 07:20:07 +0000 (00:20 -0700)]

Remove unused code in bta_sys.h

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I83c089521f6e97ac1bc1f985a344f99f9f148043

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 07:08:20 +0000 (00:08 -0700)]

no_smp_on_br is never true

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Idea65ba2ce06532f6739c801136fad1526c7e000

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 07:02:06 +0000 (07:02 +0000)]

gap_credits_received_cb is no longer useful am: b921e5395d

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1413764

Change-Id: I9ea89f0a72a6b2e21313fcb69627e996b4d27af6

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 07:02:05 +0000 (07:02 +0000)]

Hearing aid doesn't care about credit received event am: 181808d214

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1413763

Change-Id: I30aebed508f01234b945429331510bf3f645328a

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 01:11:44 +0000 (01:11 +0000)]

Remove remaining fixed channel code in bta_jv am: 93d587227f

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1414370

Change-Id: I99de1d664466a01d929463f2f12393743d74cf28

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 01:11:42 +0000 (01:11 +0000)]

Remove unused fixed channel related stuff am: 6f741834f5

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1414369

Change-Id: Iefcc7e9264e689af204330e5248b99048bcd9bb6

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 01:11:25 +0000 (01:11 +0000)]

Remove unused code am: a43711c3b7

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1414368

Change-Id: I57a30ebbc593d21ba523ad75f5a05c524f72b175

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 01:11:23 +0000 (01:11 +0000)]

sock->fixed_chan is always false am: 9e15059b97

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1414127

Change-Id: I64bede5a56336f852b517547f5a97e3f82827358

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 01:11:22 +0000 (01:11 +0000)]

sock->fixed_chane is always false, and remove unused code am: 3d0d241b84

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1414126

Change-Id: I637654a70abaaa8167e897d8865fb60eb9bd6061

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 01:11:20 +0000 (01:11 +0000)]

bta_jv_l2cap_connect_le is unused am: baa23e13ea

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1414125

Change-Id: Ib3b03bc73533226bb6bffc6127c1cd906b67e147

commit | commitdiff | tree

Hansong Zhang [Fri, 28 Aug 2020 01:11:18 +0000 (01:11 +0000)]

Remove l2cap fixed channel socket am: 8bdc254eea

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1414124

Change-Id: I2081772c332b40ff75ab46446dccceedb5ac4805

commit | commitdiff | tree

Hansong Zhang [Thu, 27 Aug 2020 23:06:00 +0000 (16:06 -0700)]

Remove unused code in l2c_api.h

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I7ab31403b9918c579b5f6a29248da331741644cb

commit | commitdiff | tree

Hansong Zhang [Thu, 27 Aug 2020 23:04:04 +0000 (16:04 -0700)]

p_nocp_cb is never set

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Iad8d115f4f84a48b1bbe47edcc84c2fd834dc0c3

commit | commitdiff | tree

Hansong Zhang [Thu, 27 Aug 2020 22:53:42 +0000 (15:53 -0700)]

pL2CA_CreditsReceived_Cb is no longer useful

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ic8085cedcfed0f18bb50853ca19d68983e80f904

commit | commitdiff | tree

Hansong Zhang [Thu, 27 Aug 2020 22:52:47 +0000 (15:52 -0700)]

gap_credits_received_cb is no longer useful

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I38779d4d17ba7c1f403e83a61bb269cd361a7c7f

commit | commitdiff | tree

Hansong Zhang [Thu, 27 Aug 2020 22:51:46 +0000 (15:51 -0700)]

Hearing aid doesn't care about credit received event

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ifc1f7b26c072c36d515ef68dc4a199633ea583e4

commit | commitdiff | tree

Hansong Zhang [Thu, 27 Aug 2020 22:47:51 +0000 (15:47 -0700)]

Remove remaining fixed channel code in bta_jv

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I867225280fb535a8ad9ce2cd6a0318984ede39bf

commit | commitdiff | tree

Hansong Zhang [Thu, 27 Aug 2020 22:39:35 +0000 (15:39 -0700)]

Remove unused fixed channel related stuff

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ibd41658323bfdf0e3ddd7803587e43a7105edc7d

commit | commitdiff | tree

Hansong Zhang [Thu, 27 Aug 2020 22:31:12 +0000 (15:31 -0700)]

Remove unused code

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I85be9ef424d55f31902765e6e47350865b0d2e12

commit | commitdiff | tree

Hansong Zhang [Thu, 27 Aug 2020 22:29:36 +0000 (15:29 -0700)]

sock->fixed_chan is always false

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I410124d0269aae3ed602b4995d0b94a43996e699

system/bt

RSS Atom

About OSDN

Find Software

Develop Software

Help