OSDN Git Service
Ivailo Monev [Thu, 23 Jul 2020 16:47:34 +0000 (16:47 +0000)]
review some compiler and language definition checks
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
Ivailo Monev [Thu, 23 Jul 2020 16:21:11 +0000 (16:21 +0000)]
move build specs from qglobal to qconfig header
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
Ivailo Monev [Thu, 23 Jul 2020 15:09:19 +0000 (15:09 +0000)]
inline memory rotation functions and mark them static
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
Ivailo Monev [Thu, 23 Jul 2020 14:24:09 +0000 (14:24 +0000)]
assume conditions that are asserted in drawing helpers
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
Ivailo Monev [Thu, 23 Jul 2020 13:46:50 +0000 (13:46 +0000)]
remove redundant header inclusions in qpaintengine_raster source
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
Ivailo Monev [Thu, 23 Jul 2020 13:13:20 +0000 (13:13 +0000)]
remove unused and internal qt_memrotate180()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
Ivailo Monev [Thu, 23 Jul 2020 12:29:41 +0000 (12:29 +0000)]
fix all-in-one build related issue properly
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
Ivailo Monev [Thu, 23 Jul 2020 12:12:36 +0000 (12:12 +0000)]
remove redundant QT_ALLINONE definition guards
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
Ivailo Monev [Thu, 16 Jul 2020 12:52:17 +0000 (12:52 +0000)]
optimize QDBusConnection methods
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 14 Jul 2020 16:22:07 +0000 (16:22 +0000)]
optimize QIcuCodec::allMibs()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 14 Jul 2020 14:32:46 +0000 (14:32 +0000)]
review qnamespace header style and replace Qt::AlignmentFlag synonyms while at it
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 14 Jul 2020 14:03:03 +0000 (14:03 +0000)]
merge Q_ASSERT() and Q_ASSERT_X() definition conditionals
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 14 Jul 2020 01:13:08 +0000 (01:13 +0000)]
review qglobal header comments, style, etc.
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 14 Jul 2020 00:40:11 +0000 (00:40 +0000)]
leave notes in scripts about relevant wiki pages
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 14 Jul 2020 00:26:02 +0000 (00:26 +0000)]
remove redundant cast in qt_x11_getX11InfoForWindow()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 14 Jul 2020 00:25:24 +0000 (00:25 +0000)]
avoid temporary in QObjectPrivate::_q_reregisterTimers()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 14 Jul 2020 00:05:48 +0000 (00:05 +0000)]
use foreach() for iteration in qDBusFindAdaptorConnector()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 14 Jul 2020 00:05:33 +0000 (00:05 +0000)]
use loop-local variable in qt_x11_getX11InfoForWindow()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 14 Jul 2020 00:05:01 +0000 (00:05 +0000)]
remove unused qDBusFindAdaptorConnector() overload
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 10 Jul 2020 01:32:43 +0000 (01:32 +0000)]
avoid color masking/unmasking in init_gray() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Thu, 9 Jul 2020 12:12:05 +0000 (12:12 +0000)]
use static stops list in QGradient::stops()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Thu, 9 Jul 2020 12:11:07 +0000 (12:11 +0000)]
optimize QBrush::isOpaque()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 6 Jul 2020 16:23:07 +0000 (16:23 +0000)]
remove unused QInternalMimeData::canReadData()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 6 Jul 2020 11:37:10 +0000 (11:37 +0000)]
use static list in QFontDatabase::standardSizes()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Thu, 2 Jul 2020 01:27:59 +0000 (01:27 +0000)]
use foreach() for iteration in QIconLoader::findIconHelper()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 1 Jul 2020 14:26:43 +0000 (14:26 +0000)]
avoid temporaries in QCleanlooksStyle::drawControl()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 29 Jun 2020 17:06:46 +0000 (17:06 +0000)]
optimize QStyle::itemTextRect()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 29 Jun 2020 16:58:59 +0000 (16:58 +0000)]
optimize QRect/QRectF animation interpolators
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 29 Jun 2020 16:40:16 +0000 (16:40 +0000)]
use exclusive conditionals in QUnifiedTimer::timerEvent()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 29 Jun 2020 16:39:21 +0000 (16:39 +0000)]
avoid pointer with zero comparison
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 29 Jun 2020 16:38:52 +0000 (16:38 +0000)]
remove redundant QPropertyAnimation::event() implementation
shadowed by QVariantAnimation::event() reimplementation
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 29 Jun 2020 13:10:21 +0000 (13:10 +0000)]
optimize QETWidget::translatePaintEvent()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 29 Jun 2020 13:09:22 +0000 (13:09 +0000)]
de-virtualize QApplication::x11ClientMessage()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 28 Jun 2020 20:12:00 +0000 (20:12 +0000)]
avoid temporaries in QWidgetPrivate::show_sys()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 28 Jun 2020 20:11:26 +0000 (20:11 +0000)]
remove unused QX11Data::xdndHandleStatus() arguments
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 28 Jun 2020 18:37:17 +0000 (18:37 +0000)]
optimize QFontEngine::addGlyphsToPath()
possible due to
53dadb4f2abd0ba41f8ec1deb16fc700b3c187d5
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 28 Jun 2020 17:53:34 +0000 (17:53 +0000)]
replace use of XSetWMName() with XStoreName() and XSetWMIconName() with XSetIconName()
that way no static storage is used for the strings
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 28 Jun 2020 17:33:15 +0000 (17:33 +0000)]
replace xdndEnable() and xdndObtainData() with their body
avoids string constructors and conversions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 28 Jun 2020 16:35:54 +0000 (16:35 +0000)]
correct warning message in QImageData::doImageIO()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 28 Jun 2020 16:18:32 +0000 (16:18 +0000)]
export QCryptographicHash via Q_NETWORK_EXPORT
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 28 Jun 2020 16:15:24 +0000 (16:15 +0000)]
do not guard QLibraryInfo class with QT_NO_SETTINGS definition
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 28 Jun 2020 15:42:45 +0000 (15:42 +0000)]
inline get_font_bits() and get_font_bits()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 28 Jun 2020 15:42:29 +0000 (15:42 +0000)]
use single variable assignment QTreeWidgetItemIterator::QTreeWidgetItemIterator()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 27 Jun 2020 21:09:40 +0000 (21:09 +0000)]
remove redundant qfragmentmap source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 27 Jun 2020 21:09:17 +0000 (21:09 +0000)]
remove declaration of non-existing QFragmentMapData<T>::removeAndRebalance()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 27 Jun 2020 20:40:13 +0000 (20:40 +0000)]
avoid copy in QFontMetrics::boundingRect()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 27 Jun 2020 20:27:46 +0000 (20:27 +0000)]
remove unused QTestFontEngine class
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 27 Jun 2020 16:33:41 +0000 (16:33 +0000)]
avoid temporary in QTextEngine::length()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 27 Jun 2020 16:31:32 +0000 (16:31 +0000)]
remove unused QTextEngine::Mode enums
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 27 Jun 2020 16:19:46 +0000 (16:19 +0000)]
replace qt_x11ft_convert_pattern() with its body
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 27 Jun 2020 16:07:25 +0000 (16:07 +0000)]
replace QFontEngine::addBitmapFontToPath() with its body
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 27 Jun 2020 15:25:00 +0000 (15:25 +0000)]
remove unused weightFromInteger() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 27 Jun 2020 15:06:27 +0000 (15:06 +0000)]
remove unused QFontEngine::removeGlyphFromCache() and its reimplementation
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 27 Jun 2020 14:59:35 +0000 (14:59 +0000)]
remove unused static capitalize() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 27 Jun 2020 14:59:15 +0000 (14:59 +0000)]
remove unused QtFontStyle members
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 27 Jun 2020 14:28:09 +0000 (14:28 +0000)]
remove declaration of non-existing QFontDatabase::loadXlfd()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 27 Jun 2020 14:27:16 +0000 (14:27 +0000)]
remove unused font engine helpers members and functions arguments
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 27 Jun 2020 13:51:42 +0000 (13:51 +0000)]
remove unused Katie::match() argument and redundant variable
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 27 Jun 2020 13:50:32 +0000 (13:50 +0000)]
use single variable assignment in QQuaternion::slerp() and QQuaternion::nlerp()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 22 Jun 2020 17:59:04 +0000 (17:59 +0000)]
remove redundant access specifier in in QCalendarDateSectionValidator class declaration
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 22 Jun 2020 17:58:02 +0000 (17:58 +0000)]
avoid temporary in QDateTimeEditPrivate::stepBy()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 22 Jun 2020 17:57:45 +0000 (17:57 +0000)]
remove default QDateTimeEdit::wheelEvent() reimplementation
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 22 Jun 2020 17:41:19 +0000 (17:41 +0000)]
move default case to bottom in QDateTimeEdit::keyPressEvent()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 22 Jun 2020 17:25:01 +0000 (17:25 +0000)]
remove now unused variable in QAbstractSlider::keyPressEvent()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 22 Jun 2020 17:07:06 +0000 (17:07 +0000)]
optimize QAbstractSpinBoxPrivate::bound()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 22 Jun 2020 17:06:43 +0000 (17:06 +0000)]
replace switch with if statement in QAbstractSlider::changeEvent()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 22 Jun 2020 16:58:24 +0000 (16:58 +0000)]
optimize QAbstractSlider::keyPressEvent()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 22 Jun 2020 16:44:42 +0000 (16:44 +0000)]
remove stub QSystemTrayIconPrivate::updateMenu_sys()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 22 Jun 2020 16:44:21 +0000 (16:44 +0000)]
remove redundant Q_UNUSED() macro calls in QCompletionEngine::filterHistory()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 22 Jun 2020 16:43:58 +0000 (16:43 +0000)]
replace zero with Q_NULLPTR check in QCompletionEngine::filterHistory()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 22 Jun 2020 16:23:42 +0000 (16:23 +0000)]
avoid redundant qreal construct in QMatrix4x4::determinant()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 22 Jun 2020 16:22:21 +0000 (16:22 +0000)]
mark constant as static in QStandardPaths::writableLocation()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 22 Jun 2020 11:52:32 +0000 (11:52 +0000)]
remove non-documented and unused qIntCast() functions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 21 Jun 2020 18:35:05 +0000 (18:35 +0000)]
reimplement QDesktopService via QStandardPaths
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 21 Jun 2020 18:34:38 +0000 (18:34 +0000)]
optimize QStandardPaths getters
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 20 Jun 2020 16:36:11 +0000 (16:36 +0000)]
Revert "remove unused StyleSelector::freeNode()"
This reverts commit
0ecbc71d82bbdfb41953229981f4dd9cd9654d24.
used by selector in CSS parser test
Ivailo Monev [Sat, 20 Jun 2020 16:25:20 +0000 (16:25 +0000)]
avoid temporaries in QTextHtmlParser::declarationsForNode()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 20 Jun 2020 16:02:45 +0000 (16:02 +0000)]
do not check for built-in styles in QStyleFactory::keys()
styles are not build as plugins
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 20 Jun 2020 15:48:46 +0000 (15:48 +0000)]
make widget argument of drawArrow() function required
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 20 Jun 2020 15:10:39 +0000 (15:10 +0000)]
optimize QCommonStyle::drawPrimitive() and QCommonStyle::drawControl()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 19 Jun 2020 19:27:03 +0000 (19:27 +0000)]
use foreach() for iteration in QScript::__setupPackage__()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 19 Jun 2020 19:04:39 +0000 (19:04 +0000)]
remove unused integerFromString() overload
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 19 Jun 2020 18:50:44 +0000 (18:50 +0000)]
replace qt_openDocument() and qt_launchWebBrowser() with their body
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 19 Jun 2020 18:49:03 +0000 (18:49 +0000)]
de-inline if condition in QThread::setTerminationEnabled()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Thu, 18 Jun 2020 01:13:53 +0000 (01:13 +0000)]
remove unused constructWindowTitleFromFilePath() function
should've been removed with
231dc75f8a1f84db6093de7ab2a279fa0e36bd3f
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Thu, 18 Jun 2020 00:45:17 +0000 (00:45 +0000)]
optimize some QMainWindowLayoutState methods
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Thu, 18 Jun 2020 00:43:56 +0000 (00:43 +0000)]
avoid temporary in QMainWindow::menuWidget()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Thu, 18 Jun 2020 00:13:50 +0000 (00:13 +0000)]
replace QVarLengthArray with dynamic arrays where possible
avoids resizing in e.g. qDrawBorderPixmap(), there are more places where
performance can be squeezed by doing the same thing
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 17 Jun 2020 23:50:46 +0000 (23:50 +0000)]
use single variable assignment in getPatternFill() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 17 Jun 2020 23:16:11 +0000 (23:16 +0000)]
Set theme jekyll-theme-slate
Ivailo Monev [Wed, 17 Jun 2020 23:03:03 +0000 (23:03 +0000)]
remove unused QX11Data::PatternFills::opaque member
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 17 Jun 2020 23:02:08 +0000 (23:02 +0000)]
remove redundant cases in gesture recognizers
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 17 Jun 2020 22:41:34 +0000 (22:41 +0000)]
use new style cast in QClipboard::mimeData()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 17 Jun 2020 22:26:29 +0000 (22:26 +0000)]
avoid temporary in QKeySequence::toString()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 17 Jun 2020 22:26:08 +0000 (22:26 +0000)]
indent qt_XTranslateKey() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 17 Jun 2020 18:29:03 +0000 (18:29 +0000)]
update QChar normalization test data
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 17 Jun 2020 17:56:01 +0000 (17:56 +0000)]
optimize QKeySequence::matches()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 17 Jun 2020 17:11:48 +0000 (17:11 +0000)]
optimize QKeySequencePrivate::keyBindings table
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 17 Jun 2020 17:07:47 +0000 (17:07 +0000)]
optimize assert in QGestureManager::deliverEvents()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 17 Jun 2020 16:11:36 +0000 (16:11 +0000)]
optimize qt_pixmap_thread_test() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
OSDN Git Service
