OSDN Git Service

pg-rex/syncrep.git
14 years agoThrid try. It seems my two checkouts need some cleaning up.
Michael Meskes [Tue, 5 Jan 2010 16:58:37 +0000 (16:58 +0000)]
Thrid try. It seems my two checkouts need some cleaning up.

14 years agoStill not correct.
Michael Meskes [Tue, 5 Jan 2010 16:52:15 +0000 (16:52 +0000)]
Still not correct.

14 years agoAdjusted CVS headers.
Michael Meskes [Tue, 5 Jan 2010 16:49:46 +0000 (16:49 +0000)]
Adjusted CVS headers.

14 years agoApplied patch by Boszormenyi Zoltan <zb@cybertec.at> to add sqlda support to
Michael Meskes [Tue, 5 Jan 2010 16:38:23 +0000 (16:38 +0000)]
Applied patch by Boszormenyi Zoltan <zb@cybertec.at> to add sqlda support to
ecpg in both native and compatiblity mode.

14 years agoMove the default configuration for the MSVC build system to config_default.pl,
Magnus Hagander [Tue, 5 Jan 2010 13:31:58 +0000 (13:31 +0000)]
Move the default configuration for the MSVC build system to config_default.pl,
and allow using config.pl to override the defaults. config.pl is removed from
the repository, so changes there will no longer show up when doing diff, and
will not prevent switching branches and such things.

config.pl would normally be used to override single values, but if an
old-style config.pl is read, it will override the entire default configuration,
making it backwards compatible.

14 years agoDisable linker warning 4197 on Win64, that is caused by the fact that we export
Magnus Hagander [Tue, 5 Jan 2010 11:12:50 +0000 (11:12 +0000)]
Disable linker warning 4197 on Win64, that is caused by the fact that we export
symbols both using __declspec(dllexport) (via the PGDLLIMPORT macro) and using
full-dll-export. This works without warning on Win32, but not on Win64.

In passing, fix the fact that the framework could never deal with more than
one disbled linker warning - because MSVC wants commas between linker warnings,
and semicolons between compiler warnings...

14 years agoUse _mm_pause() for win64 spin_delay(), per note from Tsutomu Yamada.
Magnus Hagander [Tue, 5 Jan 2010 11:06:28 +0000 (11:06 +0000)]
Use _mm_pause() for win64 spin_delay(), per note from Tsutomu Yamada.

14 years agoFurther code review for genbki.pl. Improve comments, fix some
Tom Lane [Tue, 5 Jan 2010 06:41:44 +0000 (06:41 +0000)]
Further code review for genbki.pl.  Improve comments, fix some
rather random code choices, don't slavishly duplicate the original
pg_attribute.h's failure to put an OID into Schema_pg_index entries.

14 years agoFix a few places where we needed -I. in CPPFLAGS to work properly in
Tom Lane [Tue, 5 Jan 2010 03:56:52 +0000 (03:56 +0000)]
Fix a few places where we needed -I. in CPPFLAGS to work properly in
VPATH builds.  We had this already in several places, but not all.

14 years agoRemove too-smart-for-its-own-good optimization of not overwriting the output
Tom Lane [Tue, 5 Jan 2010 02:34:03 +0000 (02:34 +0000)]
Remove too-smart-for-its-own-good optimization of not overwriting the output
files when they haven't changed.  This confuses make because the build fails
to update the file timestamps, and so it keeps on doing the action over again.

14 years agoVerify input in pg_read_file().
Itagaki Takahiro [Tue, 5 Jan 2010 01:29:36 +0000 (01:29 +0000)]
Verify input in pg_read_file().

14 years agoFix parallel-make timing problem.
Tom Lane [Tue, 5 Jan 2010 01:20:35 +0000 (01:20 +0000)]
Fix parallel-make timing problem.

14 years agoGet rid of the need for manual maintenance of the initial contents of
Tom Lane [Tue, 5 Jan 2010 01:06:57 +0000 (01:06 +0000)]
Get rid of the need for manual maintenance of the initial contents of
pg_attribute, by having genbki.pl derive the information from the various
catalog header files.  This greatly simplifies modification of the
"bootstrapped" catalogs.

This patch finally kills genbki.sh and Gen_fmgrtab.sh; we now rely entirely on
Perl scripts for those build steps.  To avoid creating a Perl build dependency
where there was not one before, the output files generated by these scripts
are now treated as distprep targets, ie, they will be built and shipped in
tarballs.  But you will need a reasonably modern Perl (probably at least
5.6) if you want to build from a CVS pull.

The changes to the MSVC build process are untested, and may well break ---
we'll soon find out from the buildfarm.

John Naylor, based on ideas from Robert Haas and others

14 years agoRemove sometimes inaccurate error hint about source of wrongly encoded data.
Andrew Dunstan [Mon, 4 Jan 2010 20:38:31 +0000 (20:38 +0000)]
Remove sometimes inaccurate error hint about source of wrongly encoded data.

14 years agoCheck values passed back from PLPerl to the database, via function return,
Andrew Dunstan [Mon, 4 Jan 2010 20:29:59 +0000 (20:29 +0000)]
Check values passed back from PLPerl to the database, via function return,
trigger tuple modification or SPI call, to ensure they are valid in the
server encoding. Along the way, replace uses of SvPV(foo, PL_na)
with SvPV_nolen(foo) as recommended in the perl docs. Bug report from
Hannu Krosing.

14 years agoAdd a Win64-specific spin_delay() function.
Magnus Hagander [Mon, 4 Jan 2010 17:10:24 +0000 (17:10 +0000)]
Add a Win64-specific spin_delay() function.
We can't use the same as before, since MSVC on Win64 doesn't
support inline assembly.

14 years agoImprove PGXS makefile system to allow the module's makefile to specify
Tom Lane [Mon, 4 Jan 2010 16:34:11 +0000 (16:34 +0000)]
Improve PGXS makefile system to allow the module's makefile to specify
where to install DATA and DOCS files.  This is mainly intended to allow
versioned installation, eg, install into contrib/fooM.N/ rather than
directly into contrib/.

Mark Cave-Ayland

14 years agoWrite an end-of-backup WAL record at pg_stop_backup(), and wait for it at
Heikki Linnakangas [Mon, 4 Jan 2010 12:50:50 +0000 (12:50 +0000)]
Write an end-of-backup WAL record at pg_stop_backup(), and wait for it at
recovery instead of reading the backup history file. This is more robust,
as it stops you from prematurely starting up an inconsisten cluster if the
backup history file is lost for some reason, or if the base backup was
never finished with pg_stop_backup().

This also paves the way for a simpler streaming replication patch, which
doesn't need to care about backup history files anymore.

The backup history file is still created and archived as before, but it's
not used by the system anymore. It's just for informational purposes now.

Bump PG_CONTROL_VERSION as the location of the backup startpoint is now
written to a new field in pg_control, and catversion because initdb is
required

Original patch by Fujii Masao per Simon's idea, with further fixes by me.

14 years agoWhen estimating the selectivity of an inequality "column > constant" or
Tom Lane [Mon, 4 Jan 2010 02:44:40 +0000 (02:44 +0000)]
When estimating the selectivity of an inequality "column > constant" or
"column < constant", and the comparison value is in the first or last
histogram bin or outside the histogram entirely, try to fetch the actual
column min or max value using an index scan (if there is an index on the
column).  If successful, replace the lower or upper histogram bound with
that value before carrying on with the estimate.  This limits the
estimation error caused by moving min/max values when the comparison
value is close to the min or max.  Per a complaint from Josh Berkus.

It is tempting to consider using this mechanism for mergejoinscansel as well,
but that would inject index fetches into main-line join estimation not just
endpoint cases.  I'm refraining from that until we can get a better handle
on the costs of doing this type of lookup.

14 years agoSilence compiler warning about printf format for HANDLE.
Itagaki Takahiro [Mon, 4 Jan 2010 01:06:21 +0000 (01:06 +0000)]
Silence compiler warning about printf format for HANDLE.

14 years agoDept of second thoughts: my first cut at supporting "x IS NOT NULL" btree
Tom Lane [Sun, 3 Jan 2010 05:39:08 +0000 (05:39 +0000)]
Dept of second thoughts: my first cut at supporting "x IS NOT NULL" btree
indexscans would do the wrong thing if index_rescan() was called with a
NULL instead of a new set of scankeys and the index was DESC order,
because sk_strategy would not get flipped a second time.  I think
that those provisions for a NULL argument are dead code now as far as the
core backend goes, but possibly somebody somewhere is still using it.
In any case, this refactoring seems clearer, and it's definitely shorter.

14 years agoMake ssize_t 64-bit on Win64, for compatibility with for example plpython.
Magnus Hagander [Sat, 2 Jan 2010 22:47:37 +0000 (22:47 +0000)]
Make ssize_t 64-bit on Win64, for compatibility with for example plpython.

14 years agoAdd missing schema-qualification in tab completion query.
Tom Lane [Sat, 2 Jan 2010 21:28:46 +0000 (21:28 +0000)]
Add missing schema-qualification in tab completion query.

14 years agoFix similar_escape() to convert parentheses to non-capturing style.
Tom Lane [Sat, 2 Jan 2010 20:59:16 +0000 (20:59 +0000)]
Fix similar_escape() to convert parentheses to non-capturing style.
This is needed to avoid unwanted interference with SUBSTRING behavior,
as per bug #5257 from Roman Kononov.  Also, add some basic intelligence
about character classes (bracket expressions) since we now have several
behaviors that aren't appropriate inside a character class.

As with the previous patch in this area, I'm reluctant to back-patch
since it might affect applications that are relying on the prior
behavior.

14 years agocheck_exclusion_constraint didn't actually work correctly for index
Tom Lane [Sat, 2 Jan 2010 17:53:57 +0000 (17:53 +0000)]
check_exclusion_constraint didn't actually work correctly for index
expressions: FormIndexDatum requires the estate's scantuple to already point
at the tuple the values are supposedly being extracted from.  Adjust test
case so that this type of confusion will be exposed.
Per report from hubert depesz lubaczewski.

14 years agoUpdate copyright for the year 2010.
Bruce Momjian [Sat, 2 Jan 2010 16:58:17 +0000 (16:58 +0000)]
Update copyright for the year 2010.

14 years agoSilence compiler warning about size of size_t being larger than the result
Magnus Hagander [Sat, 2 Jan 2010 15:18:42 +0000 (15:18 +0000)]
Silence compiler warning about size of size_t being larger than the result
variable it's stored in. We know this can never happen. Per discussion.

14 years agoSet proper sizes for size_t and void* on 64-bit Windows builds.
Magnus Hagander [Sat, 2 Jan 2010 13:56:37 +0000 (13:56 +0000)]
Set proper sizes for size_t and void* on 64-bit Windows builds.

Tsutomu Yamada

14 years agoSupport 64-bit shared memory when building on 64-bit Windows.
Magnus Hagander [Sat, 2 Jan 2010 12:18:45 +0000 (12:18 +0000)]
Support 64-bit shared memory when building on 64-bit Windows.

Tsutomu Yamada

14 years agoFix one more cast for _open_osfhandle().
Magnus Hagander [Sat, 2 Jan 2010 12:01:29 +0000 (12:01 +0000)]
Fix one more cast for _open_osfhandle().

Tsutomu Yamada

14 years agoFix cast for _open_osfhandle().
Magnus Hagander [Sat, 2 Jan 2010 12:00:08 +0000 (12:00 +0000)]
Fix cast for _open_osfhandle().

Tsutomu Yamada

14 years agoAdd an "argisrow" field to NullTest nodes, following a plan made way back in
Tom Lane [Fri, 1 Jan 2010 23:03:10 +0000 (23:03 +0000)]
Add an "argisrow" field to NullTest nodes, following a plan made way back in
8.2beta but never carried out.  This avoids repetitive tests of whether the
argument is of scalar or composite type.  Also, be a bit more paranoid about
composite arguments in some places where we previously weren't checking.

14 years agoSupport "x IS NOT NULL" clauses as indexscan conditions. This turns out
Tom Lane [Fri, 1 Jan 2010 21:53:49 +0000 (21:53 +0000)]
Support "x IS NOT NULL" clauses as indexscan conditions.  This turns out
to be just a minor extension of the previous patch that made "x IS NULL"
indexable, because we can treat the IS NOT NULL condition as if it were
"x < NULL" or "x > NULL" (depending on the index's NULLS FIRST/LAST option),
just like IS NULL is treated like "x = NULL".  Aside from any possible
usefulness in its own right, this is an important improvement for
index-optimized MAX/MIN aggregates: it is now reliably possible to get
a column's min or max value cheaply, even when there are a lot of nulls
cluttering the interesting end of the index.

14 years agoSilence compiler warning on 64-bit windows build
Magnus Hagander [Fri, 1 Jan 2010 19:57:07 +0000 (19:57 +0000)]
Silence compiler warning on 64-bit windows build

14 years agoDetect a 64-bit build environment on Windows, and generate the appropriate
Magnus Hagander [Fri, 1 Jan 2010 17:34:25 +0000 (17:34 +0000)]
Detect a 64-bit build environment on Windows, and generate the appropriate
project files.

Based on the work of Tsutomu Yamada, but much refactored.

14 years agoDelete solution cache file on clean, if it exists.
Magnus Hagander [Fri, 1 Jan 2010 16:58:53 +0000 (16:58 +0000)]
Delete solution cache file on clean, if it exists.

14 years agoUpdate SQL features supported list
Peter Eisentraut [Fri, 1 Jan 2010 16:54:48 +0000 (16:54 +0000)]
Update SQL features supported list

14 years agoMake the win32 putenv() override update *all* present versions of the
Magnus Hagander [Fri, 1 Jan 2010 14:57:16 +0000 (14:57 +0000)]
Make the win32 putenv() override update *all* present versions of the
MSVCRxx runtime, not just the current + Visual Studio 6 (MSVCRT). Clearly
there can be an almost unlimited number of runtimes loaded at the same
time.

Per report from Hiroshi Inoue

14 years agoSuppress compiler warning, per buildfarm member narwhal
Tom Lane [Thu, 31 Dec 2009 22:11:10 +0000 (22:11 +0000)]
Suppress compiler warning, per buildfarm member narwhal

14 years agoSuppress compiler warning (pid_t isn't int everywhere)
Tom Lane [Thu, 31 Dec 2009 22:07:36 +0000 (22:07 +0000)]
Suppress compiler warning (pid_t isn't int everywhere)

14 years agoAdd missing 'static' tag.
Tom Lane [Thu, 31 Dec 2009 21:47:12 +0000 (21:47 +0000)]
Add missing 'static' tag.

14 years agoRedefine Datum as uintptr_t, instead of unsigned long.
Tom Lane [Thu, 31 Dec 2009 19:41:37 +0000 (19:41 +0000)]
Redefine Datum as uintptr_t, instead of unsigned long.

This is more in keeping with modern practice, and is a first step towards
porting to Win64 (which has sizeof(pointer) > sizeof(long)).

Tsutomu Yamada, Magnus Hagander, Tom Lane

14 years agoUpdate SQL features list for aggregate ORDER BY support
Peter Eisentraut [Thu, 31 Dec 2009 14:51:16 +0000 (14:51 +0000)]
Update SQL features list for aggregate ORDER BY support

14 years agoAdd information_schema.triggered_update_columns
Peter Eisentraut [Thu, 31 Dec 2009 14:41:23 +0000 (14:41 +0000)]
Add information_schema.triggered_update_columns

This reflects the recently added support for triggers on columns.

14 years agoenable examples to compile on Windows. patch from Hiroshi Saito.
Andrew Dunstan [Thu, 31 Dec 2009 00:16:47 +0000 (00:16 +0000)]
enable examples to compile on Windows. patch from Hiroshi Saito.

14 years agoFill in information schema column for trigger WHEN condition
Peter Eisentraut [Wed, 30 Dec 2009 22:48:10 +0000 (22:48 +0000)]
Fill in information schema column for trigger WHEN condition

14 years agoDept of second thoughts: recursive case in ANALYZE shouldn't emit a
Tom Lane [Wed, 30 Dec 2009 21:21:33 +0000 (21:21 +0000)]
Dept of second thoughts: recursive case in ANALYZE shouldn't emit a
pgstats message.  This might need to be done differently later, but
with the current logic that's what should happen.

14 years agoRevise pgstat's tracking of tuple changes to improve the reliability of
Tom Lane [Wed, 30 Dec 2009 20:32:14 +0000 (20:32 +0000)]
Revise pgstat's tracking of tuple changes to improve the reliability of
decisions about when to auto-analyze.

The previous code depended on n_live_tuples + n_dead_tuples - last_anl_tuples,
where all three of these numbers could be bad estimates from ANALYZE itself.
Even worse, in the presence of a steady flow of HOT updates and matching
HOT-tuple reclamations, auto-analyze might never trigger at all, even if all
three numbers are exactly right, because n_dead_tuples could hold steady.

To fix, replace last_anl_tuples with an accurately tracked count of the total
number of committed tuple inserts + updates + deletes since the last ANALYZE
on the table.  This can still be compared to the same threshold as before, but
it's much more trustworthy than the old computation.  Tracking this requires
one more intra-transaction counter per modified table within backends, but no
additional memory space in the stats collector.  There probably isn't any
measurable speed difference; if anything it might be a bit faster than before,
since I was able to eliminate some per-tuple arithmetic operations in favor of
adding sums once per (sub)transaction.

Also, simplify the logic around pgstat vacuum and analyze reporting messages
by not trying to fold VACUUM ANALYZE into a single pgstat message.

The original thought behind this patch was to allow scheduling of analyzes
on parent tables by artificially inflating their changes_since_analyze count.
I've left that for a separate patch since this change seems to stand on its
own merit.

14 years agoUpdate SQL conformance: search conditions on triggers are supported
Peter Eisentraut [Wed, 30 Dec 2009 19:37:47 +0000 (19:37 +0000)]
Update SQL conformance: search conditions on triggers are supported

14 years agoRevert makefile refactoring (version 1.123) because it doesn't work
Peter Eisentraut [Wed, 30 Dec 2009 13:48:52 +0000 (13:48 +0000)]
Revert makefile refactoring (version 1.123) because it doesn't work
when building several files at once (e.g.,
gmake postgres-A4.pdf postgres-US.pdf).

14 years agoExclude part of the product name string that is localized in Japanese versions
Magnus Hagander [Wed, 30 Dec 2009 12:26:41 +0000 (12:26 +0000)]
Exclude part of the product name string that is localized in Japanese versions
of MSVC when detecting MSVC version.

Hiroshi Inoue

14 years agoReset minRecoveryPoint at checkpoints, so that we don't uselessly update
Heikki Linnakangas [Wed, 30 Dec 2009 08:37:21 +0000 (08:37 +0000)]
Reset minRecoveryPoint at checkpoints, so that we don't uselessly update
it in the control file at crash recovery following an archive recovery.

Per Fujii Masao and subsequent discussion.

14 years agoSet errno to zero before invoking SSL_read or SSL_write. It appears that
Tom Lane [Wed, 30 Dec 2009 03:45:46 +0000 (03:45 +0000)]
Set errno to zero before invoking SSL_read or SSL_write.  It appears that
at least in some Windows versions, these functions are capable of returning
a failure indication without setting errno.  That puts us into an infinite
loop if the previous value happened to be EINTR.  Per report from Brendan
Hill.

Back-patch to 8.2.  We could take it further back, but since this is only
known to be an issue on Windows and we don't support Windows before 8.2,
it does not seem worth the trouble.

14 years agoReject invalid input in int2vectorin.
Robert Haas [Wed, 30 Dec 2009 01:29:22 +0000 (01:29 +0000)]
Reject invalid input in int2vectorin.

Since the int2vector type is intended only for internal use, this patch doesn't
worry about prettifying the error messages, which has the fringe benefit of
avoiding creating additional translatable strings.  For a type intended to be
used by end-users, we would want to do better, but the approach taken here
seems like the correct trade-off for this case.

Caleb Welton

14 years agoAdd an index on pg_inherits.inhparent, and use it to avoid seqscans in
Tom Lane [Tue, 29 Dec 2009 22:00:14 +0000 (22:00 +0000)]
Add an index on pg_inherits.inhparent, and use it to avoid seqscans in
find_inheritance_children().  This is a complete no-op in databases without
any inheritance.  In databases where there are just a few entries in
pg_inherits, it could conceivably be a small loss.  However, in databases with
many inheritance parents, it can be a big win.

14 years agoAdd the ability to store inheritance-tree statistics in pg_statistic,
Tom Lane [Tue, 29 Dec 2009 20:11:45 +0000 (20:11 +0000)]
Add the ability to store inheritance-tree statistics in pg_statistic,
and teach ANALYZE to compute such stats for tables that have subclasses.
Per my proposal of yesterday.

autovacuum still needs to be taught about running ANALYZE on parent tables
when their subclasses change, but the feature is useful even without that.

14 years agoPrevious fix for temporary file management broke returning a set from
Heikki Linnakangas [Tue, 29 Dec 2009 17:40:59 +0000 (17:40 +0000)]
Previous fix for temporary file management broke returning a set from
PL/pgSQL function within an exception handler. Make sure we use the right
resource owner when we create the tuplestore to hold returned tuples.

Simplify tuplestore API so that the caller doesn't need to be in the right
memory context when calling tuplestore_put* functions. tuplestore.c
automatically switches to the memory context used when the tuplestore was
created. Tuplesort was already modified like this earlier. This patch also
removes the now useless MemoryContextSwitch calls from callers.

Report by Aleksei on pgsql-bugs on Dec 22 2009. Backpatch to 8.1, like
the previous patch that broke this.

14 years agoSmall wording improvement and clarification in PL/pgSQL trigger documentation
Peter Eisentraut [Mon, 28 Dec 2009 19:11:51 +0000 (19:11 +0000)]
Small wording improvement and clarification in PL/pgSQL trigger documentation

14 years agoRemove PGDLLIMPORT used for binary upgrade; must be on the externs, per Tom.
Bruce Momjian [Mon, 28 Dec 2009 18:49:05 +0000 (18:49 +0000)]
Remove PGDLLIMPORT used for binary upgrade;  must be on the externs, per Tom.

14 years agoAdd PGDLLIMPORT for binary_upgrade global variables so shared object
Bruce Momjian [Mon, 28 Dec 2009 18:39:03 +0000 (18:39 +0000)]
Add PGDLLIMPORT for binary_upgrade global variables so shared object
libraries can access them.

14 years agoRemove non-ascii characters from source code.
Bruce Momjian [Mon, 28 Dec 2009 18:09:44 +0000 (18:09 +0000)]
Remove non-ascii characters from source code.

14 years agoAvoid memory leak if pgstat_vacuum_stat is interrupted partway through.
Tom Lane [Sun, 27 Dec 2009 19:40:07 +0000 (19:40 +0000)]
Avoid memory leak if pgstat_vacuum_stat is interrupted partway through.
The temporary hash tables made by pgstat_collect_oids should be allocated
in a short-term memory context, which is not the default behavior of
hash_create.  Noted while looking through hash_create calls in connection
with Robert Haas' recent complaint.

This is a pre-existing bug, but it doesn't seem important enough to
back-patch.  The hash table is not so large that it would matter unless this
happened many times within a session, which seems quite unlikely.

14 years agoRemove a couple of unnecessary calls of CreateCacheMemoryContext. These
Tom Lane [Sun, 27 Dec 2009 18:55:52 +0000 (18:55 +0000)]
Remove a couple of unnecessary calls of CreateCacheMemoryContext.  These
probably got there via blind copy-and-paste from one of the legitimate
callers, so rearrange and comment that code a bit to make it clearer that
this isn't a necessary prerequisite to hash_create.  Per observation
from Robert Haas.

14 years agoRemove now unreferenced variable.
Magnus Hagander [Sun, 27 Dec 2009 16:11:28 +0000 (16:11 +0000)]
Remove now unreferenced variable.

14 years agoIf the MSVCRT module is not found in the current binary, proceed to update
Magnus Hagander [Sun, 27 Dec 2009 16:01:39 +0000 (16:01 +0000)]
If the MSVCRT module is not found in the current binary, proceed to update
system and local environments anyway, instead of aborting. (This will
happen in a MSVC build with no or very few external libraries linked in)

14 years agoAdd backend and pg_dump code to allow preservation of pg_enum oids, for
Bruce Momjian [Sun, 27 Dec 2009 14:50:46 +0000 (14:50 +0000)]
Add backend and pg_dump code to allow preservation of pg_enum oids, for
use in binary upgrades.

Bump catalog version for detection by pg_migrator of new backend API.

14 years agoZero-label enums:
Bruce Momjian [Sat, 26 Dec 2009 16:55:21 +0000 (16:55 +0000)]
Zero-label enums:

Allow enums to be created with zero labels, for use during binary upgrade.

14 years agoFix brain fade in join-removal patch: a pushed-down clause in the outer join's
Tom Lane [Fri, 25 Dec 2009 17:11:32 +0000 (17:11 +0000)]
Fix brain fade in join-removal patch: a pushed-down clause in the outer join's
restrict list is not just something to ignore, it's actually grounds to
abandon the optimization entirely.  Per bug #5255 from Matteo Beccati.

14 years agoAdd missing <indexterm><primary>...</primary>...</indexterm> tags for a couple
Robert Haas [Fri, 25 Dec 2009 01:09:31 +0000 (01:09 +0000)]
Add missing <indexterm><primary>...</primary>...</indexterm> tags for a couple
of HS-related parameters.

Fujii Masao

14 years agoUpgrade to latest ppport.h. Patch from Tim Bunce.
Andrew Dunstan [Fri, 25 Dec 2009 00:24:59 +0000 (00:24 +0000)]
Upgrade to latest ppport.h. Patch from Tim Bunce.

14 years agoTry to improve the clarity of the psql documentation for the \d family of
Tom Lane [Thu, 24 Dec 2009 23:36:39 +0000 (23:36 +0000)]
Try to improve the clarity of the psql documentation for the \d family of
commands, as per recent discussion.  Includes suggestions from Adrian Klaver
and Filip Rembialkowski.

14 years agoRename EnumValuesCreate() single-letter variable names to useful
Bruce Momjian [Thu, 24 Dec 2009 22:17:58 +0000 (22:17 +0000)]
Rename EnumValuesCreate() single-letter variable names to useful
variable names.

14 years agoBinary upgrade:
Bruce Momjian [Thu, 24 Dec 2009 22:09:24 +0000 (22:09 +0000)]
Binary upgrade:

Modify pg_dump --binary-upgrade and add backend support routines to
support the preservation of pg_type oids when doing a binary upgrade.
This allows user-defined composite types and arrays to be binary
upgraded.

14 years agoFix wrong WAL info value generated when gistContinueInsert() performs an
Tom Lane [Thu, 24 Dec 2009 17:52:04 +0000 (17:52 +0000)]
Fix wrong WAL info value generated when gistContinueInsert() performs an
index page split.  This would result in index corruption, or even more likely
an error during WAL replay, if we were unlucky enough to crash during
end-of-recovery cleanup after having completed an incomplete GIST insertion.

Yoichi Hirai

14 years agoRevert brainfart: Of course the wildcard only works in GNU make itself.
Peter Eisentraut [Wed, 23 Dec 2009 19:42:15 +0000 (19:42 +0000)]
Revert brainfart: Of course the wildcard only works in GNU make itself.
Instead, add a few targets that were missing.

14 years agoReplace target list by a wildcard, so that this workaround makefile
Peter Eisentraut [Wed, 23 Dec 2009 19:17:45 +0000 (19:17 +0000)]
Replace target list by a wildcard, so that this workaround makefile
also works transparently for lesser used targets.

14 years agoAllow the index name to be omitted in CREATE INDEX, causing the system to
Tom Lane [Wed, 23 Dec 2009 17:41:45 +0000 (17:41 +0000)]
Allow the index name to be omitted in CREATE INDEX, causing the system to
choose an index name the same as it would do for an unnamed index constraint.
(My recent changes to the index naming logic have helped to ensure that this
will be a reasonable choice.)  Per a suggestion from Peter.

A necessary side-effect is to promote CONCURRENTLY to type_func_name_keyword
status, ie, it can't be a table/column/index name anymore unless quoted.
This is not all bad, since we have heard more than once of people typing
CREATE INDEX CONCURRENTLY ON foo (...) and getting a normal index build of
an index named "concurrently", which was not what they wanted.  Now this
syntax will result in a concurrent build of an index with system-chosen
name; which they can rename afterwards if they want something else.

14 years agoRemove code that attempted to rename index columns to keep them in sync with
Tom Lane [Wed, 23 Dec 2009 16:43:43 +0000 (16:43 +0000)]
Remove code that attempted to rename index columns to keep them in sync with
their underlying table columns.  That code was not bright enough to cope with
collision situations (ie, new name conflicts with some other column of the
index).  Since there is no functional reason to do this at all, trying to
upgrade the logic to be bulletproof doesn't seem worth the trouble.

This change means that both the index name and the column names of an index
are set when it's created, and won't be automatically changed when the
underlying table columns are renamed.  Neatnik DBAs are still free to rename
them manually, of course.

14 years agoAdd basic build support for Visual Studio 2008, without resorting to
Magnus Hagander [Wed, 23 Dec 2009 13:27:04 +0000 (13:27 +0000)]
Add basic build support for Visual Studio 2008, without resorting to
generating the build files for 2005 and then converting them.

14 years agoAlways pass catalog id to the options validator function specified in
Heikki Linnakangas [Wed, 23 Dec 2009 12:23:59 +0000 (12:23 +0000)]
Always pass catalog id to the options validator function specified in
CREATE FOREIGN DATA WRAPPER. Arguably it wasn't a bug because the
documentation said that it's passed the catalog ID or zero, but surely
we should provide it when it's known. And there isn't currently any
scenario where it's not known, and I can't imagine having one in the
future either, so better remove the "or zero" escape hatch and always
pass a valid catalog ID. Backpatch to 8.4.

Martin Pihlak

14 years agoRename pg_dump.c TypeInfo variable tinfo to tyinfo, for clarity.
Bruce Momjian [Wed, 23 Dec 2009 04:10:50 +0000 (04:10 +0000)]
Rename pg_dump.c TypeInfo variable tinfo to tyinfo, for clarity.

14 years agoAdjust naming of indexes and their columns per recent discussion.
Tom Lane [Wed, 23 Dec 2009 02:35:25 +0000 (02:35 +0000)]
Adjust naming of indexes and their columns per recent discussion.

Index expression columns are now named after the FigureColname result for
their expressions, rather than always being "pg_expression_N".  Digits are
appended to this name if needed to make the column name unique within the
index.  (That happens for regular columns too, thus fixing the old problem
that CREATE INDEX fooi ON foo (f1, f1) fails.  Before exclusion indexes
there was no real reason to do such a thing, but now maybe there is.)

Default names for indexes and associated constraints now include the column
names of all their columns, not only the first one as in previous practice.
(Of course, this will be truncated as needed to fit in NAMEDATALEN.  Also,
pkey indexes retain the historical behavior of not naming specific columns
at all.)

An example of the results:

regression=# create table foo (f1 int, f2 text,
regression(# exclude (f1 with =, lower(f2) with =));
NOTICE:  CREATE TABLE / EXCLUDE will create implicit index "foo_f1_lower_exclusion" for table "foo"
CREATE TABLE
regression=# \d foo_f1_lower_exclusion
Index "public.foo_f1_lower_exclusion"
 Column |  Type   | Definition
--------+---------+------------
 f1     | integer | f1
 lower  | text    | lower(f2)
btree, for table "public.foo"

14 years agoDisallow comments on columns of relation types other than tables, views,
Tom Lane [Tue, 22 Dec 2009 23:54:17 +0000 (23:54 +0000)]
Disallow comments on columns of relation types other than tables, views,
and composite types, which are the only relkinds for which pg_dump support
exists for dumping column comments.  There is no obvious usefulness for
comments on columns of sequences or toast tables; and while comments on
index columns might have some value, it's not worth the risk of compatibility
problems due to possible changes in the algorithm for assigning names to
index columns.  Per discussion.

In consequence, remove now-dead code for copying such comments in CREATE TABLE
LIKE.

14 years agoIn CREATE SEQUENCE dump, put MINVALUE before MAXVALUE so it reads better.
Peter Eisentraut [Tue, 22 Dec 2009 23:27:41 +0000 (23:27 +0000)]
In CREATE SEQUENCE dump, put MINVALUE before MAXVALUE so it reads better.

14 years agoMore cleanups for the recent large object permissions patch.
Robert Haas [Mon, 21 Dec 2009 01:34:11 +0000 (01:34 +0000)]
More cleanups for the recent large object permissions patch.

Rewrite or adjust various comments for clarity.  Remove one bogus comment that
doesn't reflect what the code actually does.  Improve the description of the
lo_compat_privileges option.

14 years agoThere is no good reason for the CREATE TABLE LIKE INCLUDING COMMENTS code to
Tom Lane [Sun, 20 Dec 2009 18:28:14 +0000 (18:28 +0000)]
There is no good reason for the CREATE TABLE LIKE INCLUDING COMMENTS code to
have hard-wired knowledge of the rules for naming index columns.  It can
just look at the actual names in the source index, instead.  Do some minor
formatting cleanup too.

14 years agoFix two small typos in Hot Standby docs.
Robert Haas [Sun, 20 Dec 2009 03:49:58 +0000 (03:49 +0000)]
Fix two small typos in Hot Standby docs.

John Naylor

14 years agoAdd documentation why reassigning PL/Python function parameters in the
Peter Eisentraut [Sat, 19 Dec 2009 22:23:21 +0000 (22:23 +0000)]
Add documentation why reassigning PL/Python function parameters in the
function body can have undesirable outcomes. (bug #5232)

14 years agoAdd hot standby to release notes
Peter Eisentraut [Sat, 19 Dec 2009 20:33:12 +0000 (20:33 +0000)]
Add hot standby to release notes

14 years agoTranslation updates
Peter Eisentraut [Sat, 19 Dec 2009 20:23:26 +0000 (20:23 +0000)]
Translation updates

14 years agoConvert tabs to spaces in SGML.
Bruce Momjian [Sat, 19 Dec 2009 17:49:50 +0000 (17:49 +0000)]
Convert tabs to spaces in SGML.

14 years agoSigh, I managed to break the no-links-in-plain-text-docs rule too...
Tom Lane [Sat, 19 Dec 2009 05:37:01 +0000 (05:37 +0000)]
Sigh, I managed to break the no-links-in-plain-text-docs rule too...

14 years agoAdd a whitespace to fix the query to dump large objects.
Itagaki Takahiro [Sat, 19 Dec 2009 04:13:30 +0000 (04:13 +0000)]
Add a whitespace to fix the query to dump large objects.

PL/pgSQL-by-default patch broke the code for 8.3 <= server_version < 8.5.

14 years agoBump catversion to reflect the fact that HS patch changed pg_proc
Tom Lane [Sat, 19 Dec 2009 04:08:32 +0000 (04:08 +0000)]
Bump catversion to reflect the fact that HS patch changed pg_proc
contents, and PG_CONTROL_VERSION to reflect the fact that it changed
pg_control contents.  (I see we did at least remember to change
XLOG_PAGE_MAGIC for the WAL contents changes.)

14 years agoAdd missing Id keyword to alter_large_object.sgml.
Itagaki Takahiro [Sat, 19 Dec 2009 03:29:28 +0000 (03:29 +0000)]
Add missing Id keyword to alter_large_object.sgml.

14 years agoplpgsql patch broke the MSVC build, too.
Tom Lane [Sat, 19 Dec 2009 02:44:06 +0000 (02:44 +0000)]
plpgsql patch broke the MSVC build, too.

14 years agoJoin in the fun of editorializing on the alpha release notes.
Tom Lane [Sat, 19 Dec 2009 02:38:54 +0000 (02:38 +0000)]
Join in the fun of editorializing on the alpha release notes.

14 years agoUpdate ecpg regression tests to plpgsql installed by default.
Alvaro Herrera [Sat, 19 Dec 2009 02:38:51 +0000 (02:38 +0000)]
Update ecpg regression tests to plpgsql installed by default.

14 years agoUpdate tutorial on the fact that backslash commands are no longer listed in
Alvaro Herrera [Sat, 19 Dec 2009 02:34:17 +0000 (02:34 +0000)]
Update tutorial on the fact that backslash commands are no longer listed in
psql's startup banner.

14 years agoAdjust some more places in the documentation to match the fact that
Tom Lane [Sat, 19 Dec 2009 01:49:02 +0000 (01:49 +0000)]
Adjust some more places in the documentation to match the fact that
plpgsql is now installed by default.