OSDN Git Service
Rich Felker [Mon, 22 Apr 2013 14:17:56 +0000 (10:17 -0400)]
fix reversed argument order x86_64 sigsetjmp's call to sigprocmask
this caused sigsetjmp not to save the signal mask but instead to
clobber it with whatever happened to be in the sigjmb_buf prior to the
call.
Rich Felker [Sat, 20 Apr 2013 18:07:01 +0000 (14:07 -0400)]
comment potentially-confusing use of struct crypt_data type
Rich Felker [Sat, 20 Apr 2013 18:03:12 +0000 (14:03 -0400)]
mention bits headers in another part of copyright file
Rich Felker [Sat, 20 Apr 2013 18:02:55 +0000 (14:02 -0400)]
update copyright year
Rich Felker [Sat, 20 Apr 2013 18:01:33 +0000 (14:01 -0400)]
clarify that bits headers are included as public headers
Rich Felker [Sat, 20 Apr 2013 15:51:58 +0000 (11:51 -0400)]
make dynamic linker accept : or \n as path separator
this allows /etc/ld-musl-$(ARCH).path to contain one path per line,
which is much more convenient for users than the :-delimited format,
which was a source of repeated and unnecessary confusion. for
simplicity, \n is also accepted in environment variables, though it
should probably not be used there.
at the same time, issues with overly long paths invoking UB or getting
truncated have been fixed. such issues should not have arisen with the
environment (which is size-limited) but could have been generated by a
path file larger than 2**31 bytes in length.
Rich Felker [Sun, 14 Apr 2013 05:51:00 +0000 (01:51 -0400)]
release notes for 0.9.10
Rich Felker [Thu, 11 Apr 2013 02:38:46 +0000 (22:38 -0400)]
make ifaddrs.h expose sys/socket.h
the getifaddrs interface seems to have been invented by glibc, and
they expose socket.h, so for us not to do so is just gratuitous
incompatibility with the interface we're mimicing.
rofl0r [Tue, 9 Apr 2013 09:00:52 +0000 (11:00 +0200)]
getifaddrs: implement proper ipv6 netmasks
Rich Felker [Tue, 9 Apr 2013 03:09:11 +0000 (23:09 -0400)]
mbrtowc: do not leave mbstate_t in permanent-fail state after EILSEQ
the standard is clear that the old behavior is conforming: "In this
case, [EILSEQ] shall be stored in errno and the conversion state is
undefined."
however, the specification of mbrtowc has one peculiarity when the
source argument is a null pointer: in this case, it's required to
behave as mbrtowc(NULL, "", 1, ps). no motivation is provided for this
requirement, but the natural one that comes to mind is that the intent
is to reset the mbstate_t object. for stateful encodings, such
behavior is actually specified: "If the corresponding wide character
is the null wide character, the resulting state described shall be the
initial conversion state." but in the case of UTF-8 where the
mbstate_t object contains a partially-decoded character rather than a
shift state, a subsequent '\0' byte indicates that the previous
partial character is incomplete and thus an illegal sequence.
naturally, applications using their own mbstate_t object should clear
it themselves after an error, but the standard presently provides no
way to clear the builtin mbstate_t object used when the ps argument is
a null pointer. I suspect this issue may be addressed in the future by
specifying that a null source argument resets the state, as this seems
to have been the intent all along.
for what it's worth, this change also slightly reduces code size.
Rich Felker [Tue, 9 Apr 2013 03:01:32 +0000 (23:01 -0400)]
implement mbtowc directly, not as a wrapper for mbrtowc
the interface contract for mbtowc admits a much faster implementation
than mbrtowc can achieve; wrapping mbrtowc with an extra call frame
only made the situation worse.
since the regex implementation uses mbtowc already, this change should
improve regex performance too. it may be possible to improve
performance in other places internally by switching from mbrtowc to
mbtowc.
Rich Felker [Tue, 9 Apr 2013 02:49:59 +0000 (22:49 -0400)]
optimize mbrtowc
this simple change, in my measurements, makes about a 7% performance
improvement. at first glance this change would seem like a
compiler-specific hack, since the modified code is not even used.
however, I suspect the reason is that I'm eliminating a second path
into the main body of the code, allowing the compiler more flexibility
to optimize the normal (hot) path into the main body. so even if it
weren't for the measurable (and quite notable) difference in
performance, I think the change makes sense.
Rich Felker [Tue, 9 Apr 2013 02:29:46 +0000 (22:29 -0400)]
fix out-of-bounds access in UTF-8 decoding
SA and SB are used as the lowest and highest valid starter bytes, but
the value of SB was one-past the last valid starter. this caused
access past the end of the state table when the illegal byte '\xf5'
was encountered in a starter position. the error did not show up in
full-character decoding tests, since the bogus state read from just
past the table was unlikely to admit any continuation bytes as valid,
but would have shown up had we tested feeding '\xf5' to the
byte-at-a-time decoding in mbrtowc: it would cause the funtion to
wrongly return -2 rather than -1.
I may eventually go back and remove all references to SA and SB,
replacing them with the values; this would make the code more
transparent, I think. the original motivation for using macros was to
allow misguided users of the code to redefine them for the purpose of
enlarging the set of accepted sequences past the end of Unicode...
Rich Felker [Mon, 8 Apr 2013 03:19:00 +0000 (23:19 -0400)]
fix signalfd not to ignore flags
also include fallback code for broken kernels that don't support the
flags. as usual, the fallback has a race condition that can leak file
descriptors.
Rich Felker [Sat, 6 Apr 2013 22:32:11 +0000 (18:32 -0400)]
silence nonsensical warnings in timer_create
Rich Felker [Sat, 6 Apr 2013 21:50:37 +0000 (17:50 -0400)]
add support for program_invocation[_short]_name
this is a bit ugly, and the motivation for supporting it is
questionable. however the main factors were:
1. it will be useful to have this for certain internal purposes
anyway -- things like syslog.
2. applications can just save argv[0] in main, but it's hard to fix
non-portable library code that's depending on being able to get the
invocation name without the main application's help.
Rich Felker [Sat, 6 Apr 2013 21:15:58 +0000 (17:15 -0400)]
fix argument omission in ABI-compat weak_alias for fscanf
Isaac Dunham [Sat, 6 Apr 2013 06:20:28 +0000 (23:20 -0700)]
Add ABI compatability aliases.
GNU used several extensions that were incompatible with C99 and POSIX,
so they used alternate names for the standard functions.
The result is that we need these to run standards-conformant programs
that were linked with glibc.
Rich Felker [Sat, 6 Apr 2013 05:15:08 +0000 (01:15 -0400)]
fix type error in pthread_create, introduced with pthread_getattr_np
rofl0r [Fri, 5 Apr 2013 22:04:52 +0000 (00:04 +0200)]
getifaddrs: remove unused label
rofl0r [Fri, 5 Apr 2013 20:47:30 +0000 (22:47 +0200)]
getifaddrs: use if_nameindex to enumerate interfaces
rofl0r [Fri, 5 Apr 2013 20:08:03 +0000 (22:08 +0200)]
getifaddrs: one less indent level
rofl0r [Fri, 5 Apr 2013 20:06:35 +0000 (22:06 +0200)]
getifaddrs: less malloc
rofl0r [Fri, 5 Apr 2013 17:59:40 +0000 (19:59 +0200)]
include/ifaddrs.h: add prototypes for get/freeifaddrs
rofl0r [Fri, 5 Apr 2013 17:26:51 +0000 (19:26 +0200)]
add getifaddrs
supports ipv4 and ipv6, but not the "extended" usage where
usage statistics and other info are assigned to ifa_data members
of duplicate entries with AF_PACKET family.
rofl0r [Fri, 5 Apr 2013 16:57:06 +0000 (18:57 +0200)]
net/if.h: add some missing IFF_ constants
Rich Felker [Fri, 5 Apr 2013 02:36:49 +0000 (22:36 -0400)]
add prototype for dn_skipname
Rich Felker [Fri, 5 Apr 2013 02:36:30 +0000 (22:36 -0400)]
implement dn_skipname (legacy resolver function)
rofl0r [Fri, 5 Apr 2013 00:32:51 +0000 (02:32 +0200)]
add arpa/tftp.h
Rich Felker [Fri, 5 Apr 2013 00:09:50 +0000 (20:09 -0400)]
fix type issues in stdint.h so underlying types of 64-bit types match ABI
Rich Felker [Thu, 4 Apr 2013 23:57:23 +0000 (19:57 -0400)]
eliminate bits/wchar.h
the preprocessor can reliably determine the signedness of wchar_t.
L'\0' is used for 0 in the expressions so that, if the underlying type
of wchar_t is long rather than int, the promoted type of the
expression will match the type of wchar_t.
Rich Felker [Thu, 4 Apr 2013 23:50:55 +0000 (19:50 -0400)]
eliminate gcc dependency for testing char signedness in limits.h
Rich Felker [Thu, 4 Apr 2013 23:23:47 +0000 (19:23 -0400)]
add put*ent functions for passwd/group files and similar for shadow
since shadow does not yet support enumeration (getspent), the
corresponding FILE-based get and put versions are also subbed out for
now. this is partly out of laziness and partly because it's not clear
how they should work in the presence of TCB shadow files. the stubs
should make it possible to compile some software that expects them to
exist, but such software still may not work properly.
Rich Felker [Thu, 4 Apr 2013 18:55:42 +0000 (14:55 -0400)]
cleanup wcstombs
remove redundant headers and comments; this file is completely trivial
now. also, avoid temp var.
Rich Felker [Thu, 4 Apr 2013 18:53:53 +0000 (14:53 -0400)]
cleanup mbstowcs wrapper
remove unneeded headers. this file is utterly trivial now and there's
no sense in having a comment to state that it's in the public domain.
Rich Felker [Thu, 4 Apr 2013 18:51:05 +0000 (14:51 -0400)]
minor optimization to mbstowcs
there is no need to zero-fill an mbstate_t object in the caller;
mbsrtowcs will automatically treat a null pointer as the initial
state.
Rich Felker [Thu, 4 Apr 2013 18:48:48 +0000 (14:48 -0400)]
fix incorrect range checks in wcsrtombs
negative values of wchar_t need to be treated in the non-ASCII case so
that they can properly generate EILSEQ rather than getting truncated
to 8bit values and stored in the output.
Rich Felker [Thu, 4 Apr 2013 18:42:35 +0000 (14:42 -0400)]
overhaul mbsrtowcs
these changes fix at least two bugs:
- misaligned access to the input as uint32_t for vectorized ASCII test
- incorrect src pointer after stopping on EILSEQ
in addition, the text of the standard makes it unclear whether the
mbstate_t object is to be modified when the destination pointer is
null; previously it was cleared either way; now, it's only cleared
when the destination is non-null. this change may need revisiting, but
it should not affect most applications, since calling mbsrtowcs with
non-zero state can only happen when the head of the string was already
processed with mbrtowc.
finally, these changes shave about 20% size off the function and seem
to improve performance by 1-5%.
rofl0r [Tue, 2 Apr 2013 02:38:23 +0000 (04:38 +0200)]
re-add useconds_t
this type was removed back in
5243e5f1606a9c6fcf01414e ,
because it was removed from the XSI specs.
however some apps use it.
since it's in the POSIX reserved namespace, we can expose it
unconditionally.
rofl0r [Tue, 2 Apr 2013 00:51:40 +0000 (02:51 +0200)]
add arpa/nameser_compat.h
the contents of this header are already in arpa/nameser.h
rofl0r [Tue, 2 Apr 2013 00:48:39 +0000 (02:48 +0200)]
make tm_zone etc visible under _GNU_SOURCE
rofl0r [Tue, 2 Apr 2013 00:47:07 +0000 (02:47 +0200)]
__time_to_tm: initialize tm_zone and tm_gmtoff
Szabolcs Nagy [Mon, 1 Apr 2013 18:02:32 +0000 (18:02 +0000)]
add syscall numbers for the new kcmp and finit_module syscalls
and remove syscall todos from microblaze
Szabolcs Nagy [Mon, 1 Apr 2013 17:54:39 +0000 (17:54 +0000)]
add the new SO_REUSEPORT socket option to mips and powerpc
SO_REUSEPORT implementation was merged in the linux kernel commit
c617f398edd4db2b8567a28e899a88f8f574798d 2013-01-23
Szabolcs Nagy [Sat, 23 Mar 2013 19:58:33 +0000 (19:58 +0000)]
add new socket options to sys/socket.h following linux
Szabolcs Nagy [Sat, 23 Mar 2013 19:55:23 +0000 (19:55 +0000)]
adding ethernet protocol ids to if_ether.h following linux
Szabolcs Nagy [Sat, 23 Mar 2013 19:51:34 +0000 (19:51 +0000)]
add ADJ_SETOFFSET timex mode bit (new in linux v2.6.39)
Szabolcs Nagy [Sat, 23 Mar 2013 19:49:38 +0000 (19:49 +0000)]
add new linux tcp socket option flags to netinet/tcp.h
Rich Felker [Mon, 1 Apr 2013 15:20:12 +0000 (11:20 -0400)]
fix typo in setpriority syscall wrapper
Rich Felker [Mon, 1 Apr 2013 03:27:57 +0000 (23:27 -0400)]
provide prototype for pthread_getattr_np
Rich Felker [Mon, 1 Apr 2013 03:25:55 +0000 (23:25 -0400)]
implement pthread_getattr_np
this function is mainly (purely?) for obtaining stack address
information, but we also provide the detach state since it's easy to
do anyway.
Rich Felker [Wed, 27 Mar 2013 03:07:31 +0000 (23:07 -0400)]
remove __SYSCALL_SSLEN arch macro in favor of using public _NSIG
the issue at hand is that many syscalls require as an argument the
kernel-ABI size of sigset_t, intended to allow the kernel to switch to
a larger sigset_t in the future. previously, each arch was defining
this size in syscall_arch.h, which was redundant with the definition
of _NSIG in bits/signal.h. as it's used in some not-quite-portable
application code as well, _NSIG is much more likely to be recognized
and understood immediately by someone reading the code, and it's also
shorter and less cluttered.
note that _NSIG is actually 65/129, not 64/128, but the division takes
care of throwing away the off-by-one part.
Rich Felker [Wed, 27 Mar 2013 02:54:57 +0000 (22:54 -0400)]
provide emulation of fcntl F_DUPFD_CLOEXEC on old kernels
I'm not entirely happy with the amount of ugliness here, but since
F_DUPFD_CLOEXEC is used elsewhere in code that's expected to work on
old kernels (popen), it seems necessary. reportedly even some modern
kernels went back and broke F_DUPFD_CLOEXEC (making it behave like
plain F_DUPFD), so it might be necessary to add some additional fixup
code later to deal with that issue too.
Rich Felker [Mon, 25 Mar 2013 15:34:22 +0000 (11:34 -0400)]
in pipe2, use pipe() rather than __syscall(SYS_pipe, ...) for fallback
SYS_pipe is not usable directly in general, since mips has a very
broken calling convention for the pipe syscall. instead, just call the
function, so that the mips-specific ugliness is isolated in
mips/pipe.s and not copied elsewhere.
Rich Felker [Mon, 25 Mar 2013 02:41:38 +0000 (22:41 -0400)]
rewrite popen to use posix_spawn instead of fragile vfork hacks
Rich Felker [Mon, 25 Mar 2013 02:40:54 +0000 (22:40 -0400)]
remove cruft from pre-posix_spawn version of the system function
Rich Felker [Sun, 24 Mar 2013 00:02:31 +0000 (20:02 -0400)]
add deprecated SIGIOT alias for SIGABRT
reportedly some programs (e.g. showkeys in the kbd package) use it.
Rich Felker [Sat, 23 Mar 2013 22:59:30 +0000 (18:59 -0400)]
fix multiple bugs in syslog interfaces
1. as reported by William Haddon, the value returned by snprintf was
wrongly used as a length passed to sendto, despite it possibly
exceeding the buffer length. this could lead to invalid reads and
leaking additional data to syslog.
2. openlog was storing a pointer to the ident string passed by the
caller, rather than copying it. this bug is shared with (and even
documented in) other implementations like glibc, but such behavior
does not seem to meet the requirements of the standard.
3. extremely long ident provided to openlog, or corrupt ident due to
the above issue, could possibly have resulted in buffer overflows.
despite having the potential for smashing the stack, i believe the
impact is low since ident points to a short string literal in typical
application usage (and per the above bug, other usages will break
horribly on other implementations).
4. when used with LOG_NDELAY, openlog was not connecting the
newly-opened socket; sendto was being used instead. this defeated the
main purpose of LOG_NDELAY: preparing for chroot.
5. the default facility was not being used at all, so all messages
without an explicit facility passed to syslog were getting logged at
the kernel facility.
6. setlogmask was not thread-safe; no synchronization was performed
updating the mask. the fix uses atomics rather than locking to avoid
introducing a lock in the fast path for messages whose priority is not
in the mask.
7. in some code paths, the syslog lock was being unlocked twice; this
could result in releasing a lock that was actually held by a different
thread.
some additional enhancements to syslog such as a default identifier
based on argv[0] or similar may still be desired; at this time, only
the above-listed bugs have been fixed.
Rich Felker [Sun, 10 Mar 2013 03:34:11 +0000 (22:34 -0500)]
remove soname from libc.so/ld-musl
it serves no purpose (binaries linked against musl as -lc/libc.so
automatically get the right DT_NEEDED value of libc.so) and causes
ldconfig to misbehave (making a symlink to ld-musl named libc.so in
/lib). ldconfig is not used on pure musl systems, but if ld-musl is
installed on a system where it's not the primary libc, this will
pollute the system /lib with a symlink to musl named libc.so, which
should NOT exist and could cause problems linking native apps. also,
the existence of the soname caused spurious warnings from ldconfig
when /lib and /usr/lib were the same physical directory.
Rich Felker [Thu, 7 Mar 2013 04:57:39 +0000 (23:57 -0500)]
fix epoll structure alignment on non-x86_64 archs
this fix is far from ideal and breaks the rule of not using
arch-specific #ifdefs, but for now we just need a solution to the
existing breakage.
the underlying problem is that the kernel folks made a very stupid
decision to make misalignment of this struct part of the kernel
API/ABI for x86_64, in order to avoid writing a few extra lines of
code to handle both 32- and 64-bit userspace on 64-bit kernels. I had
just added the packed attribute unconditionally thinking it was
harmless on 32-bit archs, but non-x86 32-bit archs have 8-byte
alignment on 64-bit types.
Rich Felker [Wed, 6 Mar 2013 14:32:52 +0000 (09:32 -0500)]
fix missing type error in grp.h from adding fgetgrent
Rich Felker [Tue, 5 Mar 2013 00:22:14 +0000 (19:22 -0500)]
fix types for wctype_t and wctrans_t
wctype_t was incorrectly "int" rather than "long" on x86_64. not only
is this an ABI incompatibility; it's also a major design flaw if we
ever wanted wctype_t to be implemented as a pointer, which would be
necessary if locales support custom character classes, since int is
too small to store a converted pointer. this commit fixes wctype_t to
be unsigned long on all archs, matching the LSB ABI; this change does
not matter for C code, but for C++ it affects mangling.
the same issue applied to wctrans_t. glibc/LSB defines this type as
const __int32_t *, but since no such definition is visible, I've just
expanded the definition, int, everywhere.
it would be nice if these types (which don't vary by arch) could be in
wctype.h, but the OB XSI requirement in POSIX that wchar.h expose some
types and functions from wctype.h precludes doing so. glibc works
around this with some hideous hacks, but trying to duplicate that
would go against the intent of musl's headers.
Rich Felker [Mon, 4 Mar 2013 22:05:45 +0000 (17:05 -0500)]
fix some obscure header type size/alignment issues
Rich Felker [Tue, 26 Feb 2013 13:54:31 +0000 (08:54 -0500)]
fix wrong float_t on x86_64
x86_64 does not have excess precision, at all
Rich Felker [Tue, 26 Feb 2013 06:46:39 +0000 (01:46 -0500)]
fix cruft in utmp.h that was broken by changes in utmpx.h
patch by Chris Spiegel.
Rich Felker [Tue, 26 Feb 2013 06:42:11 +0000 (01:42 -0500)]
fix integer type issue in strverscmp
lenl-lenr is not a valid expression for a signed int return value from
strverscmp, since after implicit conversion from size_t to int this
difference could have the wrong sign or might even be zero. using the
difference for char values works since they're bounded well within the
range of differences representable by int, but it does not work for
size_t values.
Rich Felker [Tue, 26 Feb 2013 06:36:47 +0000 (01:36 -0500)]
implement non-stub strverscmp
patch by Isaac Dunham.
Rich Felker [Tue, 26 Feb 2013 06:30:36 +0000 (01:30 -0500)]
namespace conformance to latest standards in strings.h
Rich Felker [Fri, 22 Feb 2013 04:54:25 +0000 (23:54 -0500)]
replace stub with working strcasestr
Rich Felker [Fri, 22 Feb 2013 04:19:18 +0000 (23:19 -0500)]
fix wrong return value from wmemmove on forward copies
rofl0r [Thu, 21 Feb 2013 14:40:08 +0000 (15:40 +0100)]
scsci/sg.h: fix usage of undefined macro HZ
this macro is 100 on all archs, at least in userspace, according
to kernel headers.
rofl0r [Thu, 21 Feb 2013 14:35:34 +0000 (15:35 +0100)]
add arpa/ftp.h
Rich Felker [Thu, 21 Feb 2013 04:01:22 +0000 (23:01 -0500)]
use memcmp instead of str[n]cmp for temp function XXXXXX checking
Rich Felker [Thu, 21 Feb 2013 03:58:46 +0000 (22:58 -0500)]
fix error cases in mkostemps core
1. wrong return value and missing errno for negative suffix len
2. failure to catch suffix len > strlen
3. remove unwanted clearing of input string in invalid case
Rich Felker [Thu, 21 Feb 2013 03:56:53 +0000 (22:56 -0500)]
remove leftover unused variable in mktemp after refactoring
Rich Felker [Thu, 21 Feb 2013 03:43:23 +0000 (22:43 -0500)]
add mkostemp, mkstemps, and mkostemps functions and reorganize temp internals
based on patch contributed by Anthony G. Basile (blueness)
some issues remain with the filename generation algorithm and other
small bugs, but this patch has been sitting around long enough that I
feel it's best to get it committed and then work out any remaining
issues.
Rich Felker [Sun, 17 Feb 2013 19:30:19 +0000 (14:30 -0500)]
remove unused #undef environ now that libc.h no longer #defines it
Rich Felker [Sun, 17 Feb 2013 19:24:39 +0000 (14:24 -0500)]
consistently use the internal name __environ for environ
patch by Jens Gustedt.
previously, the intended policy was to use __environ in code that must
conform to the ISO C namespace requirements, and environ elsewhere.
this policy was not followed in practice anyway, making things
confusing. on top of that, Jens reported that certain combinations of
link-time optimization options were breaking with the inconsistent
references; this seems to be a compiler or linker bug, but having it
go away is a nice side effect of the changes made here.
Rich Felker [Sun, 17 Feb 2013 18:21:56 +0000 (13:21 -0500)]
add fgetgrent function
based on patch by Isaac Dunham, moved to its own file to avoid
increasing bss on static linked programs not using this nonstandard
function but using the standard getgrent function, and vice versa.
Rich Felker [Thu, 7 Feb 2013 08:13:35 +0000 (03:13 -0500)]
fix typo in newly-added error message for EOWNERDEAD
Rich Felker [Thu, 7 Feb 2013 08:05:54 +0000 (03:05 -0500)]
improve error strings
this definitely has the potential to be a bikeshed topic, so some
justification is in order. most of the changes made fit into one of
the following categories:
1. alignment with text in posix, xsh 2.3
2. eliminating overly-specific text for shared error codes
3. making the message match more closely with the macro name
4. removing extraneous words
in particular, the EAGAIN/EWOULDBLOCK text is updated to match the
description of EAGAIN (which covers both uses) rather than saying the
operation would block, and ENOTSUP/EOPNOTSUPP is updated not to
mention sockets.
the distinction between ENFILE/EMFILE has also been clarified; ENFILE
is aligned with the posix text, and EMFILE, which lacks concise posix
text matching any historic message, is updated to emphasize that the
exhausted resource is not open files/open file descriptions, but
rather the integer 'address space' of file descriptors.
some messages may be further tweaked based on feedback.
rofl0r [Wed, 6 Feb 2013 01:15:51 +0000 (02:15 +0100)]
arm: add __aeabi_atexit()
arm eabi requires this symbol for static C++ dtors.
usually it is provided by libstdc++, but when a C++ program
doesn't use the std lib (free-standing), the libc has to provide
it.
this was encountered while building transmission, which
depends on such a C++ library (libutp).
this function is nearly identical to __cxa_atexit, but it has the
order of argumens swapped for "performance reasons".
see page 25 of
http://infocenter.arm.com/help/topic/com.arm.doc.ihi0043d/IHI0043D_rtabi.pdf
there are other aeabi specific C++ support functions missing, but
it is not clear yet that GCC makes use of them so we omit them for
the moment.
rofl0r [Wed, 6 Feb 2013 01:11:49 +0000 (02:11 +0100)]
Makefile: make it possible to build arch specific C files
Rich Felker [Sun, 3 Feb 2013 23:21:04 +0000 (18:21 -0500)]
base system() on posix_spawn
this avoids duplicating the fragile logic for executing an external
program without fork.
Rich Felker [Sun, 3 Feb 2013 22:09:47 +0000 (17:09 -0500)]
fix unsigned comparison bug in posix_spawn
read should never return anything but 0 or sizeof ec here, but if it
does, we want to treat any other return as "success". then the caller
will get back the pid and is responsible for waiting on it when it
immediately exits.
Rich Felker [Sun, 3 Feb 2013 21:42:40 +0000 (16:42 -0500)]
overhaul posix_spawn to use CLONE_VM instead of vfork
the proposed change was described in detail in detail previously on
the mailing list. in short, vfork is unsafe because:
1. the compiler could make optimizations that cause the child to
clobber the parent's local vars.
2. strace is buggy and allows the vforking parent to run before the
child execs when run under strace.
the new design uses a close-on-exec pipe instead of vfork semantics to
synchronize the parent and child so that the parent does not return
before the child has finished using its arguments (and now, also its
stack). this also allows reporting exec failures to the caller instead
of giving the caller a child that mysteriously exits with status 127
on exec error.
basic testing has been performed on both the success and failure code
paths. further testing should be done.
Rich Felker [Sun, 3 Feb 2013 21:09:05 +0000 (16:09 -0500)]
streamline old-kernel fallback path of pipe2 to use syscalls directly
also, don't waste code/time on F_GETFL since pipes always have blank
flags initially (at least on old kernels, which are all this fallback
code matters for).
Rich Felker [Sun, 3 Feb 2013 06:26:33 +0000 (01:26 -0500)]
fix regression that made shared libs crash on arm
Rich Felker [Sat, 2 Feb 2013 07:07:38 +0000 (02:07 -0500)]
dynamically allocate storage for gethostby* buffers
this change shaves ~1k off libc.so bss size, and also avoids hard
errors in the case where the static buffer was not large enough to
hold the result.
this whole framework is really ugly and might should be replaced or at
least heavily overhauled when some changes/factorizations are made to
getaddrinfo internals in the future.
Rich Felker [Sat, 2 Feb 2013 06:59:53 +0000 (01:59 -0500)]
fix blank ai_canonname from getaddrinfo for non-CNAMEs
Rich Felker [Sat, 2 Feb 2013 06:32:12 +0000 (01:32 -0500)]
fix memory leak due to double call to getaddrinfo in gethostbyname*
Rich Felker [Sat, 2 Feb 2013 06:31:10 +0000 (01:31 -0500)]
fix error returns in gethostby*_r functions
they're supposed to return an error code rather than using errno.
Rich Felker [Sat, 2 Feb 2013 05:59:25 +0000 (00:59 -0500)]
fix uninitialized map_len being used in munmap failure paths in load_library
this bug seems to have been introduced when the map_library signatures
was changed to return the mapping in a temp dso structure instead of
into separate variables.
Rich Felker [Sat, 2 Feb 2013 03:25:19 +0000 (22:25 -0500)]
fix stale locks left behind when pthread_create fails
this bug seems to have been around a long time.
Rich Felker [Sat, 2 Feb 2013 03:23:24 +0000 (22:23 -0500)]
if pthread_create fails, it must not attempt mmap if there is no mapping
this bug was introduced when support for application-provided stacks
was originally added.
Rich Felker [Sat, 2 Feb 2013 03:10:40 +0000 (22:10 -0500)]
pthread stack treatment overhaul for application-provided stacks, etc.
the main goal of these changes is to address the case where an
application provides a stack of size N, but TLS has size M that's a
significant portion of the size N (or even larger than N), thus giving
the application less stack space than it expected or no stack at all!
the new strategy pthread_create now uses is to only put TLS on the
application-provided stack if TLS is smaller than 1/8 of the stack
size or 2k, whichever is smaller. this ensures that the application
always has "close enough" to what it requested, and the threshold is
chosen heuristically to make sure "sane" amounts of TLS still end up
in the application-provided stack.
if TLS does not fit the above criteria, pthread_create uses mmap to
obtain space for TLS, but still uses the application-provided stack
for actual call frame stack. this is to avoid wasting memory, and for
the sake of supporting ugly hacks like garbage collection based on
assumptions that the implementation will use the provided stack range.
in order for the above heuristics to ever succeed, the amount of TLS
space wasted on POSIX TSD (pthread_key_create based) needed to be
reduced. otherwise, these changes would preclude any use of
pthread_create without mmap, which would have serious memory usage and
performance costs for applications trying to create huge numbers of
threads using pre-allocated stack space. the new value of
PTHREAD_KEYS_MAX is the minimum allowed by POSIX, 128. this should
still be plenty more than real-world applications need, especially now
that C11/gcc-style TLS is now supported in musl, and most apps and
libraries choose to use that instead of POSIX TSD when available.
at the same time, PTHREAD_STACK_MIN has been decreased. it was
originally set to PAGE_SIZE back when there was no support for TLS or
application-provided stacks, and requests smaller than a whole page
did not make sense. now, there are two good reasons to support
requests smaller than a page: (1) applications could provide
pre-allocated stacks smaller than a page, and (2) with smaller stack
sizes, stack+TLS+TSD can all fit in one page, making it possible for
applications which need huge numbers of threads with minimal stack
needs to allocate exactly one page per thread. the new value of
PTHREAD_STACK_MIN, 2k, is aligned with the minimum size for
sigaltstack.
rofl0r [Sat, 2 Feb 2013 02:08:57 +0000 (03:08 +0100)]
make some arrays const
this way they'll go into .rodata, decreasing memory pressure.
Rich Felker [Fri, 1 Feb 2013 21:41:53 +0000 (16:41 -0500)]
replace __wake function with macro that performs direct syscall
this should generate faster and smaller code, especially with inline
syscalls. the conditional with cnt is ugly, but thankfully cnt is
always a constant anyway so it gets evaluated at compile time. it may
be preferable to make separate __wake and __wakeall macros without a
count argument.
priv flag is not used yet; private futex support still needs to be
done at some point in the future.
Rich Felker [Fri, 1 Feb 2013 20:57:28 +0000 (15:57 -0500)]
fix up minor misplacement of restrict keyword in spawnattr sched stubs
Rich Felker [Fri, 1 Feb 2013 06:49:07 +0000 (01:49 -0500)]
release notes for 0.9.9