OSDN Git Service
Ioannis Valasakis [Fri, 9 Nov 2018 13:54:36 +0000 (13:54 +0000)]
staging: greybus: add extra space around OR operator
Add extra spaces around the OR operator.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioannis Valasakis [Fri, 9 Nov 2018 13:54:30 +0000 (13:54 +0000)]
staging: greybus: remove multiple blank lines
Remove extra blank lines to conform with coding style.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioannis Valasakis [Fri, 9 Nov 2018 13:54:23 +0000 (13:54 +0000)]
staging: greybus: remove space before tab
Remove extra space before a tab character.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioannis Valasakis [Fri, 9 Nov 2018 13:54:09 +0000 (13:54 +0000)]
staging: greybus: remove multiple blank lines
Remove continuous multiple blank lines.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioannis Valasakis [Fri, 9 Nov 2018 13:54:00 +0000 (13:54 +0000)]
staging: greybus: correct SPDX License Identifier
Replace SPDX License Identifier comments with C comments.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioannis Valasakis [Fri, 9 Nov 2018 13:53:54 +0000 (13:53 +0000)]
staging: greybus: align arguments with parentheses
Align arguments with the right side of the open left parentheses.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioannis Valasakis [Fri, 9 Nov 2018 13:53:46 +0000 (13:53 +0000)]
staging: greybus: fix SPDX License Identifier
Replace the SPDX identifier with standard C comment.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioannis Valasakis [Fri, 9 Nov 2018 13:53:31 +0000 (13:53 +0000)]
staging: greybus: align parameters to parentheses
Align parameters to the right side of the left parentheses
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioannis Valasakis [Fri, 9 Nov 2018 13:53:24 +0000 (13:53 +0000)]
staging: greybus: shorten comparison to NULL
Shorten pointer NULL check by simple truth test.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gao Xiang [Fri, 9 Nov 2018 16:07:50 +0000 (00:07 +0800)]
staging: erofs: fix undefined LZ4_decompress_safe_partial()
It needs an explicit LZ4 library dependency
if lz4 compression is enabled, found by kbuild randconfig.
Reported-by: kbuild test robot <lkp@intel.com>
Fixes:
05f9d4a0c8c4 ("staging: erofs: use the new LZ4_decompress_safe_partial()")
Signed-off-by: Gao Xiang <hsiangkao@aol.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alexey Skidanov [Tue, 9 Oct 2018 19:08:37 +0000 (22:08 +0300)]
staging: android: ion: Add per-heap counters
Heap statistics have been removed and currently even basics statistics
are missing.
This patch creates per heap debugfs directory /sys/kernel/debug/<heap_name>
and adds the following counters:
- the number of allocated buffers;
- the number of allocated bytes;
- the number of allocated bytes watermark.
Signed-off-by: Alexey Skidanov <alexey.skidanov@intel.com>
Acked-by: Laura Abbott <labbott@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Irenge Jules Bashizi [Thu, 8 Nov 2018 22:00:29 +0000 (22:00 +0000)]
staging: davinci_vpfe: Remove multiple blank space
Remove multiple blank space complained by checkpatch
Signed-off-by: Irenge Jules Bashizi <jbi.octave@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Irenge Jules Bashizi [Thu, 8 Nov 2018 21:12:05 +0000 (21:12 +0000)]
staging: davinci_vpfe: Change to !format
Change from if(format==NULL) to if(!format) to remove checkpatch warning
Signed-off-by: Irenge Jules Bashizi <jbi.octave@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Maya Nakamura [Thu, 8 Nov 2018 07:23:50 +0000 (23:23 -0800)]
staging: rtlwifi: Add spaces for comments
Add spaces before and after text in comments.
Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Maya Nakamura [Thu, 8 Nov 2018 07:22:18 +0000 (23:22 -0800)]
staging: rtlwifi: Remove empty comment
Remove a comment that does not contain any text.
Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Maya Nakamura [Thu, 8 Nov 2018 07:21:40 +0000 (23:21 -0800)]
staging: rtlwifi: Improve line endings
Edit statements so that the line does not end with an assignment operator
or a parenthesis.
Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 7 Nov 2018 20:09:20 +0000 (20:09 +0000)]
staging: wlan-ng: reformatting in prism2mib.c to fit 80 character limit
Reformat lines over 80 characters in prism2mib.c to resolve "line over
80 characters" warnings reported by checkpatch.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 7 Nov 2018 20:09:18 +0000 (20:09 +0000)]
staging: wlan-ng: formatting change in cfg80211.c
Resolve "line over 80 characters" warning reported by checkpatch by
splitting function header over 2 lines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Carmeli Tamir [Wed, 7 Nov 2018 20:44:24 +0000 (15:44 -0500)]
staging: emxx_udc: Added missing le16_to_cpu conversions
Fixed sparse tool warnings due to missing convesion from
le16 to cpu endienness.
Signed-off-by: Carmeli Tamir <carmeli.tamir@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Carmeli Tamir [Wed, 7 Nov 2018 20:44:23 +0000 (15:44 -0500)]
staging: emxx_udc: Added missing __iomem modifier to handle p_regs
Since in nbu2ss_drv_probe() p_regs is assigned from mmio_base, which is
marked as __iomem, p_regs also should be market with __iomem.
Signed-off-by: Carmeli Tamir <carmeli.tamir@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Carmeli Tamir [Wed, 7 Nov 2018 20:44:22 +0000 (15:44 -0500)]
staging: emxx_udc: Added static modifier to udc_controller
Added static modifier to the udc_controller, since it's only
required within emxx_udc.c.
Signed-off-by: Carmeli Tamir <carmeli.tamir@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nishad Kamdar [Wed, 7 Nov 2018 12:48:54 +0000 (18:18 +0530)]
staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface
Use the gpiod interface instead of the deprecated old non-descriptor
interface in olpc_dcon_xo_1.c.
Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Brady [Mon, 22 Oct 2018 19:17:08 +0000 (20:17 +0100)]
staging: bcm2835-audio: interpolate audio delay
When the BCM2835 audio output is used, userspace sees a jitter up to 10ms
in the audio position, aka "delay" -- the number of frames that must
be output before a new frame would be played.
Make this a bit nicer for userspace by interpolating the position
using the CPU clock.
The overhead is small -- an extra ktime_get() every time a GPU message
is sent -- and another call and a few calculations whenever the delay
is sought from userland.
At 48,000 frames per second, i.e. approximately 20 microseconds per
frame, it would take a clock inaccuracy of
20 microseconds in 10 milliseconds -- 2,000 parts per million --
to result in an inaccurate estimate, whereas
crystal- or resonator-based clocks typically have an
inaccuracy of 10s to 100s of parts per million.
Signed-off-by: Mike Brady <mikebrady@eircom.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Adham Abozaeid [Tue, 6 Nov 2018 00:01:17 +0000 (00:01 +0000)]
staging: wilc1000: remove unused flags in handle_cfg_param()
handle_cfg_param() receives a bit map that describes what to be changed.
Some of these bits flags aren't referred to from elsewhere and can be
removed.
Signed-off-by: Adham Abozaeid <adham.abozaeid@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gao Xiang [Thu, 8 Nov 2018 04:00:36 +0000 (12:00 +0800)]
staging: erofs: use the new LZ4_decompress_safe_partial()
LZ4_decompress_safe_partial() can now decode exactly the nb of bytes
requested after the upstreamed commit
2209fda323e2 ("lib/lz4: update LZ4
decompressor module"), remove the erofs hacked lz4 decompression code.
A more cleaned compressor wrapper will be introduced in the subsequent
patches in order to prepare for supporting multiple compression algorithms.
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Thu, 8 Nov 2018 11:02:24 +0000 (11:02 +0000)]
media: staging: tegra-vde: print long unsigned using %lu format specifier
The frame.flags & FLAG_B_FRAME is promoted to a long unsigned because
of the use of the BIT() macro when defining FLAG_B_FRAME and causing a
build warning. Fix this by using the %lu format specifer.
Cleans up warning:
drivers/staging/media/tegra-vde/tegra-vde.c:267:5: warning: format
specifies type 'int' but the argument has type 'unsigned long' [-Wformat]
Fixes:
42e764d05712 ("staging: tegravde: replace bit assignment with macro")
Cc: Ioannis Valasakis <code@wizofe.uk>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cristian Sicilia [Sun, 4 Nov 2018 14:50:40 +0000 (15:50 +0100)]
staging: rtlwifi: SET_RATE_ID inline no arg reuse
The macro SET_RATE_ID is a definition in function
and undefined at end of function.
Make it as inline avoid the arg reuse for macro,
the name is changed in _rtl_rate_id, following the
same function pattern in the file.
Signed-off-by: Cristian Sicilia <sicilia.cristian@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Yangtao Li [Mon, 5 Nov 2018 15:23:58 +0000 (10:23 -0500)]
staging: vt6655: fix small typo
Correct spelling mistakes of "Calculate"
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Yangtao Li [Mon, 5 Nov 2018 15:31:21 +0000 (10:31 -0500)]
Staging: rtl8712: fix small typo
ture->true
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Yangtao Li [Mon, 5 Nov 2018 15:34:33 +0000 (10:34 -0500)]
staging: rtl8723bs: fix small typo
ture->true
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Tue, 30 Oct 2018 17:23:54 +0000 (17:23 +0000)]
staging: comedi: ni_labpc_common: Use insn->n in AO insn_write handler
The `insn_write` handler for the AO subdevice (`labpc_ao_insn_write()`)
currently ignores `insn->n` (the number of samples to write) and assumes
a single sample is to be written. But `insn->n` could be 0, meaning no
samples should be written, in which case `data[0]` is invalid.
Follow the usual Comedi guidelines and change `labpc_ao_insn_write()` to
write the specified number of samples. This fixes the assumption that
`data[0]` is valid.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Tue, 30 Oct 2018 14:44:16 +0000 (14:44 +0000)]
staging: comedi: cb_pcidda: Use insn->n in AO insn_write handler
The `insn_write` handler for the AO subdevice
(`cb_pcidda_ao_insn_write()`) currently ignores `insn->n` (the number of
samples to write) and assumes a single sample is to be written. But
`insn->n` could be 0, meaning no samples should be written, in which
case `data[0]` is invalid.
Follow the usual Comedi guidelines and change
`cb_pcidda_ao_insn_write()` to write the specified number of samples.
This fixes the assumption that `data[0]` is valid.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Wed, 31 Oct 2018 12:29:56 +0000 (12:29 +0000)]
staging: comedi: addi_apci_3501: Use insn->n in EEPROM insn_read handler
The `insn_read` handler for the EEPROM subdevice
(`apci3501_eeprom_insn_read()`) currently ignores `insn->n` (the number
of samples to be read) and assumes a single sample is to be read. But
`insn->n` could be 0, meaning no samples should be read, in which case
`data[0]` ought not to be written. (The comedi core at least ensures
that `data[0]` exists, but we should not rely on that.)
Following the usual Comedi guidelines and interpret `insn->n` as the
number of samples to be read, but only read the EEPROM location once and
make `insn->n` copies, as we don't expect the contents of the EEPROM
location to change between readings.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Tue, 30 Oct 2018 14:17:13 +0000 (14:17 +0000)]
staging: comedi: Check length of INSN_CONFIG_TIMER_1 instruction
The contents of the Comedi configuration instruction
`INSN_CONFIG_TIMER_1` instruction are not very well defined, but the one
driver that uses it (the "cb_pcidas64" driver for the PCI-DAS4020/12
card) assumes its `insn->n` is 5. Add a check in
`check_insn_config_length()` to verify that `insn->n` is correct for
this configuration instruction.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Tue, 30 Oct 2018 14:17:12 +0000 (14:17 +0000)]
staging: comedi: cb_pcidas64: Use insn->n in EEPROM insn_read handler
The `insn_read` handler for the EEPROM subdevice (`eeprom_insn_read()`)
currently ignores `insn->n` (the number of samples to be read) and
assumes a single sample is to be read. But `insn->n` could be 0,
meaning no samples should be read, in which case `data[0]` ought not to
be written. (The comedi core at least ensures that `data[0]` exists,
but we should not rely on that.)
Follow the usual Comedi guidelines and interpret `insn->n` as the number
of samples to be read, but only read the EEPROM location once and make
`insn->n` copies, as we don't expect the contents of the EEPROM location
to change between readings.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Tue, 30 Oct 2018 14:17:11 +0000 (14:17 +0000)]
staging: comedi: cb_pcidas64: Use insn->n in AO insn_write handler
The `insn_write` handler for the AO subdevice (`ao_winsn()` currently
ignores `insn->n` (the number of samples to write) and assumes a single
sample is to be written. But `insn->n` could be 0, meaning no samples
should be written, in which case `data[0]` is invalid.
Follow the usual Comedi guidelines and change `ao_winsn()` to write the
specified number of samples. This fixes the assumption that `data[0]`
is valid.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hans de Goede [Mon, 22 Oct 2018 14:57:50 +0000 (16:57 +0200)]
staging: vboxvideo: Use DRM_FB_HELPER_DEFAULT_OPS
Use DRM_FB_HELPER_DEFAULT_OPS rather then open-coding it.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hans de Goede [Mon, 22 Oct 2018 14:57:49 +0000 (16:57 +0200)]
staging: vboxvideo: Drop DRM_MODE_FB_CMD define
This is a leftover from when the driver was out of tree and also build
against older kernels.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hans de Goede [Mon, 22 Oct 2018 14:57:48 +0000 (16:57 +0200)]
staging: vboxvideo: Add myself as MODULE_AUTHOR
Add myself as MODULE_AUTHOR.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hans de Goede [Mon, 22 Oct 2018 14:57:47 +0000 (16:57 +0200)]
staging: vboxvideo: Fixup some #ifdef-s
Add #ifdef CONFIG_PM_SLEEP around the suspend/hibernate functions.
Remove unnecessary #ifdef CONFIG_COMPAT, the .compat_ioctl member is
always available and if CONFIG_COMPAT is not set then drm_compat_ioctl
is defined to NULL.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hans de Goede [Mon, 22 Oct 2018 14:57:46 +0000 (16:57 +0200)]
staging: vboxvideo: Use PCI_DEVICE() for our pci_id table
Use PCI_DEVICE() for our pci_id table and also simplify the terminating
entry tio just "{ }".
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hans de Goede [Mon, 22 Oct 2018 14:57:45 +0000 (16:57 +0200)]
staging: vboxvideo: Cleanup header use
Stop adding -Iinclude/drm to the CFLAGS and stop using the obsolete
"include-all" drm/drmP.h header.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Sat, 27 Oct 2018 20:28:50 +0000 (22:28 +0200)]
staging: rtl8188eu: cleanup long line in rtw_hal_xmit()
Cleanup a line over 80 characters in rtw_hal_xmit() by using
if(x) instead of if(x == true). Also clears a missing spaces
around '|' checkpatch issue.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Sat, 27 Oct 2018 20:28:49 +0000 (22:28 +0200)]
staging: rtl8188eu: change return type of rtw_hal_xmit()
The function rtw_hal_xmit() returns true or false.
Change the return type from s32 to bool.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Sat, 27 Oct 2018 20:28:48 +0000 (22:28 +0200)]
staging: rtl8188eu: change return type of rtl8188eu_xmitframe_complete()
The function rtl8188eu_xmitframe_complete() returns true or false.
Change the return type from s32 to bool.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Sat, 27 Oct 2018 20:28:47 +0000 (22:28 +0200)]
staging: rtl8188eu: change type of a struct field
The field enable of struct recv_reorder_ctrl is only used for boolean
values, so change the type from u8 to bool.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Sat, 27 Oct 2018 20:28:46 +0000 (22:28 +0200)]
staging: rtl8188eu: remove unnecessary ternary operator
The field accept_addba_req of struct mlme_ext_info has type bool.
Use the value of accept_addba_req directly instead of the ternary
operator in an asignment.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Sun, 21 Oct 2018 19:45:28 +0000 (21:45 +0200)]
staging: rtl8188eu: change type of is_cck_rate - style
The variable is_cck_rate is used for boolean values, so change the
type from u8 to bool. The initializations to zero and use of ternary
operator in the assignments are unnecessary, remove them as well.
Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Sun, 21 Oct 2018 19:45:27 +0000 (21:45 +0200)]
staging: rtl8188eu: rename variable isCCKrate - style
Rename the variable isCCKrate to avoid CamelCase.
isCCKrate -> is_cck_rate
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Sun, 21 Oct 2018 19:45:26 +0000 (21:45 +0200)]
staging: rtl8188eu: rename variable Max_spatial_stream - style
Rename the variable Max_spatial_stream to avoid CamelCase.
Max_spatial_stream -> max_spatial_stream
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Sun, 21 Oct 2018 19:45:25 +0000 (21:45 +0200)]
staging: rtl8188eu: simplify odm_evm_db_to_percentage()
Use clamp() to simplify code in odm_evm_db_to_percentage().
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nicolas Saenz Julienne [Wed, 17 Oct 2018 19:01:56 +0000 (21:01 +0200)]
staging: bcm2835-audio: update TODO
The following tasks were completed or not the right solution:
1/2- Not the proper solution, we should register a platform device in
vchiq the same way it's done with bcm2835-camera as commented here:
https://lkml.org/lkml/2018/10/16/1131
2/3- Fixed by Takashi Iwai here: https://lkml.org/lkml/2018/9/4/587
Also, adds a new task as per mailing list conversation.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nicolas Saenz Julienne [Wed, 17 Oct 2018 19:01:55 +0000 (21:01 +0200)]
staging: bcm2835-audio: rename platform_driver structure
It was called bcm2835_alsa0_driver, that "0" didn't mean much.
Suggested-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nicolas Saenz Julienne [Wed, 17 Oct 2018 19:01:54 +0000 (21:01 +0200)]
staging: bcm2835-audio: more generic probe function name
There will only be one probe function, there is no use for appendig
"_dt" the end of the name.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nicolas Saenz Julienne [Wed, 17 Oct 2018 19:01:53 +0000 (21:01 +0200)]
staging: bcm2835-audio: use anonymous union in struct vc_audio_msg
In this case explicitly naming the union doesn't help overall code
comprehension and clutters it.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nicolas Saenz Julienne [Wed, 17 Oct 2018 19:01:52 +0000 (21:01 +0200)]
staging: bcm2835-audio: reorder variable declarations & remove trivial comments
When it comes to declaring variables it's preferred, when possible, to
use an inverted tree organization scheme.
Also, removes some comments that were useless.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nicolas Saenz Julienne [Wed, 17 Oct 2018 19:01:51 +0000 (21:01 +0200)]
staging: bcm2835-audio: don't initialize memory twice
The memory is being allocated with devres_alloc(), wich ultimately uses
__GFP_ZERO to call kmalloc. We don't need to zero the memory area again
in bcm2835-audio.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nicolas Saenz Julienne [Wed, 17 Oct 2018 19:01:50 +0000 (21:01 +0200)]
staging: bcm2835-audio: unify FOURCC command definitions
The device communicates with the audio core using FOURCC codes. The
driver was generating them using different macros/expressions. We now
use the same macro to create them and centralize all the definitions.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cristian Sicilia [Fri, 19 Oct 2018 18:29:33 +0000 (20:29 +0200)]
staging: rtlwifi: Modified the line ending with a parenthesis
This patch fixes two line ending with parenthesis, which did
not conform to the linux kernel coding style.
Signed-off-by: Cristian Sicilia <sicilia.cristian@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rohit Sarkar [Tue, 6 Nov 2018 18:23:00 +0000 (23:53 +0530)]
staging: wlan-ng: Fix a typo.
"Exiting" instead of "Exitting"
Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Laís Pessine do Carmo [Wed, 7 Nov 2018 00:28:04 +0000 (22:28 -0200)]
staging: sm750fb: Add spaces around '+'
Add spaces around '+' to correct the following checkpath.pl warnings:
WARNING: line over 80 characters
+ write_dpPort(accel, *(unsigned int *)(pSrcbuf + (j * 4)));
WARNING: line over 80 characters
+ memcpy(ajRemain, pSrcbuf+ul4BytesPerScan, ulBytesRemain);
Signed-off-by: Laís Pessine do Carmo <laispc19@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Wed, 7 Nov 2018 10:39:32 +0000 (10:39 +0000)]
staging: rtl8192u: rename struct name _rt_firmare_seg_container
Rename struct _rt_firmare_seg_container to _fw_seg_container to match
the typedef name of this structure. Also removes the spelling mistake
of 'firmare'.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Tue, 30 Oct 2018 11:09:59 +0000 (11:09 +0000)]
staging: speakup: clean up few indentation issues
Trivial fix to clean up indentation issues across the driver
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Tue, 30 Oct 2018 11:17:20 +0000 (11:17 +0000)]
staging: xgifb: clean an indentation issue
Trivial fix to clean up an indentation issue
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Robert Eshleman [Sun, 28 Oct 2018 03:47:00 +0000 (20:47 -0700)]
staging: rtl8712: fix CamelCase in fw_priv struct
Rename fields in fw_priv struct from CamelCase to snake_case.
Reported by checkpatch.
Signed-off-by: Robert Eshleman <bobbyeshleman@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Mon, 15 Oct 2018 22:34:33 +0000 (23:34 +0100)]
drivers: staging: rtl*: fix spelling mistake "Orginial" -> "Original"
Trivial fix to common spelling mistakes in some rtl* drivers
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jeeeun Evans [Thu, 18 Oct 2018 11:41:01 +0000 (12:41 +0100)]
staging: ks7010: remove unnecessary blank line
Cleanup extra line found by checkpatch.pl
Signed-off-by: Jeeeun Evans <jeeeunevans@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nícolas F. R. A. Prado [Wed, 7 Nov 2018 00:42:42 +0000 (22:42 -0200)]
staging: mt7621-mmc: Add blank line after declaration
Correct the following warning from checkpatch.pl:
WARNING: Missing a blank line after declarations
+ struct msdc_host *host = mmc_priv(mmc);
+ msdc_pm(state, (void *)host);
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@protonmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rohit Sarkar [Wed, 7 Nov 2018 09:43:14 +0000 (15:13 +0530)]
staging: goldfish: Add SPDX license identifier.
Fix checkpatch warning by adding the SPDX license identifier.
Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hans de Goede [Thu, 18 Oct 2018 15:03:33 +0000 (17:03 +0200)]
staging: vboxvideo: Stop disabling/enabling accel support on master set / drop
Userspace mode-setting (and thus also VESA) is not supported together with
modesetting. KMS userspace apps not properly marking the framebuffer as
dirty are also not supported.
So stop trying to accommodate this and simply enable accel
once at driver init.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hans de Goede [Thu, 18 Oct 2018 15:03:32 +0000 (17:03 +0200)]
staging: vboxvideo: Change licence headers over to SPDX
All the files contain a MIT license header, replace this with:
SPDX-License-Identifier: MIT
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hans de Goede [Thu, 18 Oct 2018 15:03:31 +0000 (17:03 +0200)]
staging: vboxvideo: Cleanup the comments
Some comments where still using docbook style comments, move these
either over to kerneldoc, or just make them regular comments.
Also remove a bunch of obsolete comments.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hans de Goede [Thu, 18 Oct 2018 15:03:30 +0000 (17:03 +0200)]
staging: vboxvideo: Drop duplicate vbox_err.h file
Switch to the more complete vbox_err.h file from include/linux which got
added with the merging of the vboxguest driver.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hans de Goede [Thu, 18 Oct 2018 15:03:29 +0000 (17:03 +0200)]
staging: vboxvideo: Keep old mode when disable crtc
On DPMS off we get a call to vbx_crtc_atomic_disable, followed by
a call to vbox_primary_atomic_update, at which point crtc_state->enable
is 0 and crtc_state->mode has been zero-ed. On a 0 width/height
vbox_do_modeset() falls back to 640x480, so this causes the guest Window
(its "monitor") to resize to 640x480 (and become black).
This commit makes us not look at crtc_state->mode when crtc_state->enable
is not set, so that we keep the old mode and just make the window go black.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hans de Goede [Thu, 18 Oct 2018 15:03:28 +0000 (17:03 +0200)]
staging: vboxvideo: Stop accessing crtc_state->active
Atomic modesetting drivers should never check crtc_state->active directly,
instead check crtc_state->enable.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioannis Valasakis [Tue, 6 Nov 2018 12:40:58 +0000 (12:40 +0000)]
staging: davinci: add SPDX License Identifier
Add missing SPDX License Identifier to the source and header files.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioannis Valasakis [Tue, 6 Nov 2018 12:40:49 +0000 (12:40 +0000)]
staging: davinci: remove FSF mail address from copyright
Remove the mail address from the copyright notice as it may change in
the future. Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioannis Valasakis [Tue, 6 Nov 2018 12:45:42 +0000 (12:45 +0000)]
staging: tegravde: replace bit assignment with macro
Replace the bit assignment with the preferred BIT macro. Reported by
checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioannis Valasakis [Tue, 6 Nov 2018 02:29:10 +0000 (02:29 +0000)]
staging: speakup: move arguments to adhere to 80 chars
Move the arguments of spk_serial_synth_immediate and the
spk_ttyio_synth_immediate to adhere to 80 chars limit coding standards.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioannis Valasakis [Tue, 6 Nov 2018 02:20:56 +0000 (02:20 +0000)]
staging: speakup: move arguments to reduce 80 chars limit
Move the arguments one line below to remove the warning of the 80 chars
limit. Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioannis Valasakis [Tue, 6 Nov 2018 02:20:49 +0000 (02:20 +0000)]
staging: speakup: add spaces around minus
Add spaces around minus operator. Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioannis Valasakis [Tue, 6 Nov 2018 01:25:18 +0000 (01:25 +0000)]
staging: bcm2048: add SPDX License Identifier
Add missing SPDX License Identifier. Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhagyashri P. Dighole [Mon, 5 Nov 2018 19:49:05 +0000 (19:49 +0000)]
staging: erofs: Modify conditional checks
Fix coding style alignment issues detected by checkpatch.pl
Use ! for NULL test rather than explicitly comparing to NULL.
Signed-off-by: Bhagyashri P. Dighole <digholebhagyashri@gmail.com>
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhagyashri P. Dighole [Mon, 5 Nov 2018 19:48:38 +0000 (19:48 +0000)]
staging: erofs: Modify coding style alignments
Fix coding style alignment issues detected by checkpatch.pl
Matched alignments with parenthesis.
Signed-off-by: Bhagyashri P. Dighole <digholebhagyashri@gmail.com>
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rasmus Villemoes [Wed, 24 Oct 2018 10:48:20 +0000 (11:48 +0100)]
staging: greybus: loopback.c: remove unused lists
gb_loopback_device::list_op_async is never used except for the
LIST_INIT. The ::list field appears to have a few more uses, but on
closer inspection the linked list of struct gb_loopbacks that it heads
is never used for anything, so there's no reason to maintain it, much
less to keep it sorted.
Reviewed-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gao Xiang [Sat, 3 Nov 2018 09:23:56 +0000 (17:23 +0800)]
staging: erofs: remove the redundant d_rehash() for the root dentry
There is actually no need at all to d_rehash() for the root dentry
as Al pointed out, fix it.
Reported-by: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Sat, 27 Oct 2018 14:27:19 +0000 (15:27 +0100)]
staging: rtl8723bs: fix typo in function name rtw_sctx_chk_waring_status
Trivial fix to typo in function name, rename it to
rtw_sctx_chk_warning_status.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Sat, 27 Oct 2018 14:26:18 +0000 (15:26 +0100)]
staging: rtl8188eu: fix typo in function name rtw_sctx_chk_waring_status
Trivial fix to typo in function name, rename it to
rtw_sctx_chk_warning_status.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Wang [Tue, 16 Oct 2018 12:37:11 +0000 (20:37 +0800)]
Staging: comedi: dt9812: fixed a typo in comment.
Fixed a typo in comment.
Signed-off-by: Marco Wang <m.aesophor@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Thu, 1 Nov 2018 16:45:26 +0000 (16:45 +0000)]
staging: wilc1000: remove coreconfigurator.h file
Remove the coreconfigurator header file, as its source file is deleted
after code refactor. Moved the required structure and prototypes to
hostinterface header.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Thu, 1 Nov 2018 16:45:23 +0000 (16:45 +0000)]
staging: wilc1000: remove coreconfigurator.c file
After use of framework API's most of the redundant functions are removed
in coreconfigurator.c file. Now moved left over function to
host_interface file and deleted the coreconfigurator.c file.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Thu, 1 Nov 2018 16:45:20 +0000 (16:45 +0000)]
staging: wilc1000: remove unnecessary MAX_STRING_LEN macro
Cleanup patch to remove the use of unnecessary 'MAX_STRING_LEN' macro.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Thu, 1 Nov 2018 16:45:17 +0000 (16:45 +0000)]
staging: wilc1000: refactor wilc_parse_assoc_resp_info()
Refactor wilc_parse_assoc_resp_info() function by removing the use of
get_asoc_status() API. For parsing assoc response use the struct and
avoided the use of offset macros to extract the ies information.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Thu, 1 Nov 2018 16:45:14 +0000 (16:45 +0000)]
staging: wilc1000: avoid line over 80 chars in wilc_parse_network_info()
Use shorter name for 'network_info' variable to avoid line over 80 chars
issue.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Thu, 1 Nov 2018 16:45:11 +0000 (16:45 +0000)]
staging: wilc1000: refactor get_bssid() function
Refactor get_bssid() by making use of 'ieee80211_mgmt' struct. Instead
of passing the memory offset now using structure element to fetch the
bssid information.
Returning the pointer to bssid from get_bssid() instead of filing the
input argument.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Thu, 1 Nov 2018 16:45:08 +0000 (16:45 +0000)]
staging: wilc1000: remove unused code in coreconfigurator
After refactoring of wilc_parse_network_info(), some of the functions and
macro are not required, so removed the unused code.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Thu, 1 Nov 2018 16:45:05 +0000 (16:45 +0000)]
staging: wilc1000: refactor wilc_parse_network_info() using kernel framework api's
Refactor wilc_parse_network_info() by making use of cfg80211.h provided
API.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioannis Valasakis [Thu, 1 Nov 2018 14:41:54 +0000 (14:41 +0000)]
staging: octeon: Fix style issues
Fix mismatch parentheses and style issues.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michelle Darcy [Thu, 1 Nov 2018 19:19:23 +0000 (12:19 -0700)]
staging: davinci_vpfe: Align brackets to open parentheses
Fixes checkpatch.pl CHECK: Alignment should match open parenthesis
Signed-off-by: Michelle Darcy <mdarcy137@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shayenne da Luz Moura [Wed, 31 Oct 2018 15:03:26 +0000 (12:03 -0300)]
staging: vboxvideo: Remove unnecessary parentheses
Remove unneeded parentheses around the arguments of ||. This reduces
clutter and code behave in the same way.
Change suggested by checkpatch.pl.
vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
crtc->x'
Signed-off-by: Shayenne da Luz Moura <shayenneluzmoura@gmail.com>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>