OSDN Git Service
TreeHugger Robot [Thu, 11 Apr 2019 01:48:30 +0000 (01:48 +0000)]
Merge "Update OWNERS for nfc folder." into qt-dev
Cn Chen [Thu, 11 Apr 2019 01:32:43 +0000 (01:32 +0000)]
Merge "Enable/disable fingerprint for SUW suggestion activity" into qt-dev
TreeHugger Robot [Thu, 11 Apr 2019 00:41:33 +0000 (00:41 +0000)]
Merge "Set IA background not transparent" into qt-dev
TreeHugger Robot [Thu, 11 Apr 2019 00:02:41 +0000 (00:02 +0000)]
Merge "Fixed display name not saved after carrier changed" into qt-dev
Raff Tsai [Wed, 10 Apr 2019 23:42:48 +0000 (23:42 +0000)]
Merge "Remove old format contextual card log" into qt-dev
Salvador Martinez [Wed, 10 Apr 2019 22:46:10 +0000 (22:46 +0000)]
Merge "Update BS warning to follow through on action" into qt-dev
Raj Mojumder [Wed, 10 Apr 2019 21:59:24 +0000 (14:59 -0700)]
Update OWNERS for nfc folder.
BUG:
65294119
Test: gerrit upload
Change-Id: I71e6e39c61862529198378228d793d3a6ba14139
Signed-off-by: Raj Mojumder <rmojumder@google.com>
Exempt-From-Owner-Approval: Invalid owners.
TreeHugger Robot [Wed, 10 Apr 2019 22:22:25 +0000 (22:22 +0000)]
Merge "Changes for renamed API" into qt-dev
Sean Stout [Wed, 10 Apr 2019 22:02:41 +0000 (22:02 +0000)]
Merge "Add android.settings.VIEW_ADVANCED_POWER_USAGE_DETAIL" into qt-dev
Mill Chen [Wed, 10 Apr 2019 00:28:46 +0000 (17:28 -0700)]
Set IA background not transparent
The static IA is overlapping the Wi-Fi slice when expanding Wi-Fi slice.
This is caused by that Wi-Fi slice is expanding quickly and static IA
is moving down slowly. We set the background of IA not to transparent
and make IA not overlap slice cards.
Fixes:
129491990
Test: visual
Change-Id: Ib28a18df0016c8fb58bd400085cb658f3bd9d3e6
TreeHugger Robot [Wed, 10 Apr 2019 20:57:23 +0000 (20:57 +0000)]
Merge "Rename resource variable names: homepage_* -> contextual_*" into qt-dev
TreeHugger Robot [Wed, 10 Apr 2019 20:46:22 +0000 (20:46 +0000)]
Merge "Creates user_switcher_enabled setting to match setting" into qt-dev
TreeHugger Robot [Wed, 10 Apr 2019 20:36:22 +0000 (20:36 +0000)]
Merge "Allow user without a password to clear credentials" into qt-dev
TreeHugger Robot [Wed, 10 Apr 2019 20:01:32 +0000 (20:01 +0000)]
Merge "Go to the correct subscription in WifiCallingSettings" into qt-dev
Julia Reynolds [Wed, 10 Apr 2019 16:44:10 +0000 (12:44 -0400)]
Changes for renamed API
Test: atest
Bug:
130224929
Change-Id: Ia5003a31153da74347a3251a71dfcd423e65a462
Julia Reynolds [Wed, 10 Apr 2019 19:46:58 +0000 (19:46 +0000)]
Merge "Use correct key value" into qt-dev
TreeHugger Robot [Wed, 10 Apr 2019 19:44:42 +0000 (19:44 +0000)]
Merge "Fix up Network and Internet Slice" into qt-dev
Fan Zhang [Wed, 10 Apr 2019 19:29:58 +0000 (19:29 +0000)]
Merge "Gracefully handle the case where private volume may be unmountable" into qt-dev
Fan Zhang [Wed, 10 Apr 2019 19:25:10 +0000 (12:25 -0700)]
Rename resource variable names: homepage_* -> contextual_*
Fixes:
130250419
Test: rebuild
Change-Id: I497f2d8e48fb6b5cd54b40e5f5b0691de0e19b1c
Fabian Kozynski [Wed, 10 Apr 2019 19:22:20 +0000 (15:22 -0400)]
Creates user_switcher_enabled setting to match setting
When the user enters UserSettings, the switch displays the setting as
on, but the setting is not created until the user modifies this for the
first time. This change makes sure that the setting is created when the
user enters UserSettings for the first time.
Fixes:
130270878
Test: manual, switch to second user and observe switcher icons.
Change-Id: I30bc5025c178da3668a76c828c34545c1d98b085
TreeHugger Robot [Wed, 10 Apr 2019 18:25:45 +0000 (18:25 +0000)]
Merge "Batch rename: homepage_* to contextual_* or condtion_*" into qt-dev
Julia Reynolds [Wed, 10 Apr 2019 17:49:03 +0000 (13:49 -0400)]
Use correct key value
Test: manual with pre O and O+ apps
Fixes:
130179408
Change-Id: I6a3f815dc441f99509eb334f028f42948e8f9c9e
TreeHugger Robot [Wed, 10 Apr 2019 17:18:03 +0000 (17:18 +0000)]
Merge "Correct SecureNfc behavior in setting page" into qt-dev
Shibin George [Tue, 9 Apr 2019 11:16:20 +0000 (16:46 +0530)]
Gracefully handle the case where private volume may be unmountable
If sdcard was removed while format(as phone storage) was
under progress, blkid can fail to identify the UUID of the
private volume. The PrivateStorageInfo.getTotalSize() API
assumes UUID to be always valid which could simply be not the case.
Avoid calling getTotalSize() on private volume when its state
is unmountable.
Bug:
130203877
Test: 1) Insert sdcard as "portable" storage.
2) Format it as "phone" storage.
3) Remove the sdcard while format is in progress.
4) Insert sdcard again -> blkid may fail to id the sdcard.
In such case, the fsUuid of the private-volume will be reported as "".
5) Open "Storage Settings". Settings app crashes:
FATAL EXCEPTION: main
Process: com.android.settings, PID: 3700
...
Caused by: java.lang.IllegalArgumentException: Invalid UUID string:
at java.util.UUID.fromString(UUID.java:194)
at android.os.storage.StorageManager.convert(StorageManager.java:2139)
at android.app.usage.StorageStatsManager.getTotalBytes(StorageStatsManager.java:121)
at com.android.settingslib.deviceinfo.PrivateStorageInfo.getTotalSize(PrivateStorageInfo.java:64)
However, with this CL, "Storage Settings" can be opened
and the private volume's state is correctly reflected as "Corrupted".
User can choose to format the volume again.
Copyright (c) 2019 Qualcomm Innovation Center, Inc. All Rights Reserved.
Change-Id: I764603b5806f43f0c6d398f9d6803646774cd912
Lei Yu [Wed, 10 Apr 2019 16:56:28 +0000 (16:56 +0000)]
Merge "Override height of SliceView in Settings" into qt-dev
Pavel Grafov [Wed, 10 Apr 2019 15:12:55 +0000 (16:12 +0100)]
Allow user without a password to clear credentials
Currently the code assumes that the user always has a pin or
password or pattern. If there's no password confirmKeyGuard() will
return false, so the acttivity will finish without doing anything.
With this change if there's no PIN/password/pattern, the credential
clearing task will be launched straightaway as the user presses "OK"
the confirmation prompt.
Bug:
127697771
Test: manual
Change-Id: Iac4af0abfc7430ed197e04f833bf203c3f66f52e
Andrew Sapperstein [Wed, 10 Apr 2019 16:49:49 +0000 (16:49 +0000)]
Merge "Updates to data usage prefs" into qt-dev
Jonathan Koo [Wed, 10 Apr 2019 16:46:16 +0000 (16:46 +0000)]
Merge "Address UI change request for injected services" into qt-dev
TreeHugger Robot [Wed, 10 Apr 2019 16:42:03 +0000 (16:42 +0000)]
Merge "Settings: fix the NullPointerException when initiating media player" into qt-dev
TreeHugger Robot [Wed, 10 Apr 2019 15:31:35 +0000 (15:31 +0000)]
Merge "Fix visibility of settings on channel page" into qt-dev
TreeHugger Robot [Wed, 10 Apr 2019 15:18:08 +0000 (15:18 +0000)]
Merge "Should go to wifi page from wifi panel "See more"" into qt-dev
Jack Yu [Wed, 10 Apr 2019 05:25:00 +0000 (22:25 -0700)]
Fixed display name not saved after carrier changed
The caller needs to specify the name changing source, otherwise
telephony resets it to default after SIM swapped.
Bug:
130237749
Test: Manual
Change-Id: Iaa46db7bf22a35cb583faae069c9f2519ba4f94f
Pasty Chang [Wed, 10 Apr 2019 14:23:00 +0000 (14:23 +0000)]
Merge "Enable heavy theme for setupwizard pages" into qt-dev
Julia Reynolds [Wed, 10 Apr 2019 13:57:02 +0000 (09:57 -0400)]
Fix visibility of settings on channel page
Properly hide fields if the parent app or group
is blocked. This is needed because apps can link
directly to this screen.
Test: atest
Fixes:
130184191
Change-Id: I8c39410574940615fbb607a201e20e480ec02d87
Raff Tsai [Wed, 10 Apr 2019 10:28:29 +0000 (18:28 +0800)]
Settings: fix the NullPointerException when initiating media player
If the input media resource is invalid, MediaPlayer create calling may
fail and returns null, so trigger one NullPointerException.
Add the null pointer judegement when calling seekto and so on.
Test: manual
Fixes:
130032215
Change-Id: I38cb08584aa4e4c2ce4dc58a5a095960c7bd1948
Signed-off-by: Hoff Cheng <hoffc@qti.qualcomm.com>
Kevin Chyn [Wed, 10 Apr 2019 08:34:34 +0000 (08:34 +0000)]
Merge "ConfirmDeviceCredential should respond to cancel when launched through BP" into qt-dev
Raff Tsai [Wed, 10 Apr 2019 07:16:17 +0000 (15:16 +0800)]
Remove old format contextual card log
These logs are replaced by SettingsIntelligenceLogWriter
Test: rebuild
Fixes:
124701288
Change-Id: Id93143a1f291878b7c212c35ed8683ca38d5fe17
lindatseng [Wed, 10 Apr 2019 01:07:46 +0000 (18:07 -0700)]
Should go to wifi page from wifi panel "See more"
Redirect to wifi intent instead of network & internet page
when user clicks on See more button on wifi only panel.
Test: Manual
Fixes:
130245318
Change-Id: Ic1ddb5d91cbcabfbe8ee57a5d7ec0994204f9386
Lifu Tang [Fri, 5 Apr 2019 20:47:21 +0000 (13:47 -0700)]
Address UI change request for injected services
- Remove icons from injected items
- Create a separate section for work profile
Bug:
129948280
Test: build, flash, and test manually
Change-Id: Ia64af349c8dd1575d629debd574cdb3ae6eb650d
cnchen [Fri, 22 Mar 2019 11:48:04 +0000 (19:48 +0800)]
Enable/disable fingerprint for SUW suggestion activity
Bug:
115251237
Test: atest RunSettingsRoboTests, manually test enable/disable situations
Change-Id: Ia53d2723fca5d7e3093e79037cb9053d11e4babc
Clown SHEN [Wed, 10 Apr 2019 02:48:20 +0000 (02:48 +0000)]
Merge "Add icon for sign in" into qt-dev
Antony Sargent [Tue, 9 Apr 2019 23:52:22 +0000 (16:52 -0700)]
Updates to data usage prefs
-Remove 'Data Usage' pref from Network & internet homepage
-Add 'Data warning & limit' to mobile network details page
Fixes:
127535879
Fixes:
130241963
Test: robotests
Change-Id: I28b3de34dcf11140762b4e3ee5b465f842ac48d4
Fan Zhang [Tue, 9 Apr 2019 23:33:58 +0000 (16:33 -0700)]
Batch rename: homepage_* to contextual_* or condtion_*
Contextual cards are not bound to homepage. Remove prefix homepage from
layout and theme names.
Next step: update names for some resource values (dimen/color etc)
Bug:
130250419
Test: rebuild
Change-Id: I5e901268462aaa37e00493080ae09af001784823
Fan Zhang [Tue, 9 Apr 2019 23:39:46 +0000 (23:39 +0000)]
Merge "Record all contextual card log to MetricsFeatureProvider" into qt-dev
Antony Sargent [Tue, 9 Apr 2019 22:32:39 +0000 (15:32 -0700)]
Go to the correct subscription in WifiCallingSettings
For subscriptions that support wifi calling, we have a preference on the
mobile network details page which leads to a Wifi Calling page. That
page already supports the concept of multiple subscriptions with a
header strip containing a tab for each subscription that supports wifi
calling. However, we were not necessarily selecting the *correct* tab
when going to this page. So you might be viewing the mobile network
details for subscription B and click on "Wifi Calling", only to land on
the page with the tab for subscription A selected.
This CL fixes the problem by adding an extra with the current
subscription id to the Preference's intent in
WifiCallingPreferenceController, and then reads that extra in
WifiCallingSettings and uses it to select the appropriate tab.
Fixes:
117135894
Test: make RunSettingsRoboTests
Change-Id: I3aec30072712247d14fe0fb6b61207535f9e981c
TreeHugger Robot [Tue, 9 Apr 2019 22:48:04 +0000 (22:48 +0000)]
Merge "Show Styles & Wallpaper in Settings" into qt-dev
Matthew Fritze [Tue, 9 Apr 2019 22:05:11 +0000 (15:05 -0700)]
Fix up Network and Internet Slice
- Fix pref key for Airplane mode
- Return null when no mobile data is available
Test: robotests
Fixes:
130244854
Change-Id: I88806cb9215af159114ac150c20cdb8fb413befe
TreeHugger Robot [Tue, 9 Apr 2019 22:02:30 +0000 (22:02 +0000)]
Merge "Treat mode_default as denied for install_unknown_apps" into qt-dev
TreeHugger Robot [Tue, 9 Apr 2019 21:19:24 +0000 (21:19 +0000)]
Merge "Do not retrive app detail if the fragment is exiting." into qt-dev
TreeHugger Robot [Tue, 9 Apr 2019 20:45:10 +0000 (20:45 +0000)]
Merge "Use helper method for determining whether eSIM is supported" into qt-dev
Sean Stout [Fri, 5 Apr 2019 19:34:44 +0000 (12:34 -0700)]
Add android.settings.VIEW_ADVANCED_POWER_USAGE_DETAIL
This intent action opens the advanced power usage details screen for
a provided application.
Test: adb shell am start -a \
"android.settings.VIEW_ADVANCED_POWER_USAGE_DETAIL" -d \
"package:com.google.android.deskclock" --ez \
"request_ignore_background_restriction" 1
Bug:
129901520
Test: None
Bug:
129901520
Change-Id: Ib19228111c71ef1cfb5888f859a7efcf92a01754
Lei Yu [Tue, 9 Apr 2019 20:26:25 +0000 (13:26 -0700)]
Override height of SliceView in Settings
Fixes:
129012281
Test: Manual
Change-Id: I99ad80ea03a52f4a9edc0a7532ad4a0f2d33779e
Lei Yu [Tue, 9 Apr 2019 20:23:48 +0000 (20:23 +0000)]
Merge "Move bitmap recycle to onDestroy()" into qt-dev
TreeHugger Robot [Tue, 9 Apr 2019 20:18:03 +0000 (20:18 +0000)]
Merge "Treat mcx apn type as not wild-cardable." into qt-dev
Raff Tsai [Fri, 29 Mar 2019 09:17:08 +0000 (17:17 +0800)]
Record all contextual card log to MetricsFeatureProvider
Use ContextualCardLogUtils to serialize contextual card event to
string, and records the string using regular MetricFeatureProvider
logging APIs.
Bug:
124701288
Test: Robolectric, integrating test with SettingsIntelligence
Change-Id: Ie139b4f4b8a2b0f0dcc4bb8df9bdec8f5fd824a6
Salvador Martinez [Fri, 5 Apr 2019 20:07:23 +0000 (13:07 -0700)]
Update BS warning to follow through on action
The BS warning only had support for following through when a user
wanted to toggle battery saver. This also makes it so that if
the warning is shown for routines it will finish whatever action
it interrupted once confirmed.
Test: robotests pass, manual verification
Bug:
129696128
Change-Id: I2c34ed678b19d95f3c7d1094ab8f79cc0c23252e
Antony Sargent [Tue, 9 Apr 2019 16:49:57 +0000 (09:49 -0700)]
Use helper method for determining whether eSIM is supported
It turns out to be more complicated than I had thought to determine if a
device should be considered to support eSIM. But the good news is that
we already had a helper method for this - this CL switches to using it
in some code for DSDS UI.
Fixes:
129061243
Test: make RunSettingsRoboTests
Change-Id: I41e500eb70b6c6b725c0ddf09fe1ca1a69df4563
TreeHugger Robot [Tue, 9 Apr 2019 18:01:30 +0000 (18:01 +0000)]
Merge "Use active instead of available subscriptions in 2 places" into qt-dev
Amin Shaikh [Mon, 8 Apr 2019 19:39:07 +0000 (15:39 -0400)]
Show Styles & Wallpaper in Settings
Show "Styles & Wallpaper" in Settings based on whether the ThemePicker
component is availalable. Also update dashboard summary for display.
Bug:
129874298
Test: m RunSettingsRoboTests
Change-Id: Id7e0bb9cbc689bb9e637919a10a7d1006397afab
TreeHugger Robot [Tue, 9 Apr 2019 17:11:40 +0000 (17:11 +0000)]
Merge "Remove viewFlipper used in contextual card dismissal." into qt-dev
TreeHugger Robot [Tue, 9 Apr 2019 17:11:11 +0000 (17:11 +0000)]
Merge "Inflate dismissal background instead of drawing while swiping" into qt-dev
TreeHugger Robot [Tue, 9 Apr 2019 17:00:13 +0000 (17:00 +0000)]
Merge "Only enable feedback dialog in debuggable build." into qt-dev
Linda Tseng [Tue, 9 Apr 2019 16:57:26 +0000 (16:57 +0000)]
Merge "Fix panel slices title not updated when locale changed" into qt-dev
Pasty Chang [Tue, 9 Apr 2019 11:37:45 +0000 (11:37 +0000)]
Enable heavy theme for setupwizard pages
Stencil heavy theme is ready. Enable by setting the attribute to true.
light & heavy theme screenshot: https://screenshot.googleplex.com/15SXBK66NZX
Bug:
130208067
Test: atest
Change-Id: Ic3843b5f6724ed2f4fcdadf1ad634d918596c2ae
Jack Yu [Tue, 9 Apr 2019 10:40:21 +0000 (18:40 +0800)]
Correct SecureNfc behavior in setting page
1. String under SecureNfc should update immediately when NFC toggle
2. SecureNfc state should remain the same after NFC toggle
Bug:
129037278
Test: Toggle NFC/SecureNfc option and check behavior
Change-Id: I9cbac4951f0c70accd92c43fc62658cb5dbb5c9b
Julia Reynolds [Tue, 9 Apr 2019 12:56:40 +0000 (12:56 +0000)]
Merge "Move NAS selection to 'special app access'" into qt-dev
Pasty Chang [Tue, 9 Apr 2019 11:53:00 +0000 (11:53 +0000)]
Merge "Add strings used for setupwizard lockscreen skip dialog" into qt-dev
Yi-Ling Chuang [Mon, 1 Apr 2019 14:53:10 +0000 (22:53 +0800)]
Remove viewFlipper used in contextual card dismissal.
- Use view's visibility to control which view we should show.
- Slice view can be built with normal height after removing viewFlipper.
Bug:
129438972
Bug:
128689305
Test: robotests
Change-Id: If7e9bd30d5cb5bcd3b9ff9f09cc2eae36543b9e9
Yi-Ling Chuang [Fri, 29 Mar 2019 14:44:27 +0000 (22:44 +0800)]
Inflate dismissal background instead of drawing while swiping
- Only swipe the foreground out to have the background revealed.
- Inflate dismissal_swipe_background.xml while swiping.
- Fix the fly-in transition.
- Fix the overlapping problem.
Bug:
129742618
Test: robotests
Change-Id: I5311e50332d0ea0437d1693d075d5c3a2176a443
Yi-Ling Chuang [Tue, 9 Apr 2019 09:23:06 +0000 (17:23 +0800)]
Only enable feedback dialog in debuggable build.
Bug:
129881534
Test: robotests
Change-Id: I0dbd8c06f650cc7b3c32697f0c3af055912fab59
TreeHugger Robot [Tue, 9 Apr 2019 08:30:33 +0000 (08:30 +0000)]
Merge "Should not decode Wi-Fi QR code after onPause" into qt-dev
clownshen [Tue, 9 Apr 2019 06:22:13 +0000 (14:22 +0800)]
Add icon for sign in
Bug:
130188624
Test: manual test
Test: make RunSettingsRoboTests -j32 ROBOTEST_FILTER=com.android.settings.wifi.details.WifiDetailPreferenceControllerTest
Change-Id: I58a6c411a31e5cb0fe05eba486ba38774c078070
Clown SHEN [Tue, 9 Apr 2019 06:45:49 +0000 (06:45 +0000)]
Merge "Redraw WiFi detail page's header icon" into qt-dev
lindatseng [Mon, 8 Apr 2019 22:11:58 +0000 (15:11 -0700)]
Fix panel slices title not updated when locale changed
When calling getSliceData from SliceDataConverter, we were returning
the old version of List<SliceData> if there's one already existed.
So when the Locale get changed and we are re-indexing data, we
are still inserting the old List<SliceData> in database. We should
reconstruct the List of SliceData instead of reusing the old
version here, since we only call SliceDataConverter#getSliceData
when we need to reindex.
Test: Manual verification
Fixes:
126732022
Change-Id: I42a3cf93dc313efefe50a34faabac9e1d616ef6c
TreeHugger Robot [Tue, 9 Apr 2019 05:33:21 +0000 (05:33 +0000)]
Merge changes from topic "role-replace" into qt-dev
* changes:
Remove old default apps code and use roles instead.
Move default payment app to special app access.
Arc Wang [Mon, 8 Apr 2019 11:22:44 +0000 (19:22 +0800)]
Should not decode Wi-Fi QR code after onPause
Bug:
130141694
Test: manual
atest WifiDppQrCodeScannerFragmentTest
Change-Id: I412fb7c06220c23bddc7b3c448fcc72a00bdecc3
Hai Zhang [Sat, 6 Apr 2019 07:45:42 +0000 (15:45 +0800)]
Remove old default apps code and use roles instead.
Default apps are moved into PermissionController.
Bug:
124452117
Bug:
124457823
Test: presubmit & manual
Change-Id: I5f68e5b77cd6163d093590185314270706d75391
Hai Zhang [Sat, 6 Apr 2019 08:21:32 +0000 (16:21 +0800)]
Move default payment app to special app access.
Bug:
124452117
Bug:
124522992
Test: build
Change-Id: I58e7127920d939dc3635bcc2e608cee6baa21998
TreeHugger Robot [Tue, 9 Apr 2019 05:24:21 +0000 (05:24 +0000)]
Merge "Add null check in UserPreference" into qt-dev
TreeHugger Robot [Tue, 9 Apr 2019 04:18:09 +0000 (04:18 +0000)]
Merge "Supports to share Wi-Fi networks of WPA3 security SAE & OWE via QR code generator" into qt-dev
Arc Wang [Wed, 3 Apr 2019 10:45:22 +0000 (18:45 +0800)]
Supports to share Wi-Fi networks of WPA3 security SAE & OWE via QR code generator
When scanned a no password ZXing QR code, add both open network &
enhanced open network to configured Wi-Fi network list because this kind
of QR code may refer to a open network or an enhanced open network.
Bug:
124131581
Test: manual
Change-Id: Id9f85ef8dcdf72347be8106938437aecd0eed9f5
clownshen [Tue, 2 Apr 2019 11:28:56 +0000 (19:28 +0800)]
Redraw WiFi detail page's header icon
Tint 87% dark in day mode and 100% white for night mode
Bug:
129413562
Test: make RunSettingsRoboTests -j32 ROBOTEST_FILTER=com.android.settings.wifi.details.WifiDetailPreferenceControllerTest
Test: manual test
Change-Id: Ia31231ca7871ac4efcea5e1232690ff4374df5b3
(cherry picked from commit
86f65ef488a5648399c1eb29d8e631c952d5dbf1)
pastychang [Tue, 2 Apr 2019 11:03:16 +0000 (19:03 +0800)]
Add strings used for setupwizard lockscreen skip dialog
Test: atest
Bug:
124028212
Change-Id: I9f65022f6bbc70606a40b5b20e9484731376d203
Arc Wang [Tue, 9 Apr 2019 01:39:35 +0000 (01:39 +0000)]
Merge "Remove the PreferenceGroup without title in WifiNetworkDetailsFragment" into qt-dev
Cn Chen [Tue, 9 Apr 2019 01:27:01 +0000 (01:27 +0000)]
Merge "Fix fingerprint screens from "Anything else" screen not applying Stencil theme" into qt-dev
TreeHugger Robot [Mon, 8 Apr 2019 23:37:53 +0000 (23:37 +0000)]
Merge "Import translations. DO NOT MERGE" into qt-dev
Lei Yu [Mon, 8 Apr 2019 23:16:20 +0000 (16:16 -0700)]
Move bitmap recycle to onDestroy()
If we recycle it in OnStop() and this page isn't destoried,
it will crash when we revisit it.
Fixes:
130185099
Test: RunSettingsRoboTests
Change-Id: I4d3c1c12debcccb1ee7d676a1c5accece0b42e09
Antony Sargent [Mon, 8 Apr 2019 20:42:14 +0000 (13:42 -0700)]
Use active instead of available subscriptions in 2 places
In a couple of places we were showing DSDS UI using the list of
*available* subscriptions instead of the list of *active* ones. This
difference is relevant for instance if you have multiple eSIM profiles -
in typical hardware only one of those can be active at one time. This CL
fixes that problem in two places:
1) The header at the top of the Network & internet page
2) The ListPreference's on the mobile network detail page for selecting
the default subscription for Calls / SMS.
Fixes:
129673046
Test: make RunSettingsRoboTests
Change-Id: I891c856bdd4516286fcee1067684d9161ceaca80
Suprabh Shukla [Mon, 8 Apr 2019 22:23:01 +0000 (15:23 -0700)]
Treat mode_default as denied for install_unknown_apps
Test: atest SettingsRoboTests
Bug:
123700348
Change-Id: Ieeb6456854cc3d0faa0e9c407accd94f56a25813
Xiangyu/Malcolm Chen [Mon, 8 Apr 2019 21:38:25 +0000 (21:38 +0000)]
Merge "Revert switchBar if enable / disable subscription fails." into qt-dev
Lei Yu [Mon, 8 Apr 2019 21:28:09 +0000 (21:28 +0000)]
Merge "Settings: [BT] Wrong Pairing Popup is shown on new pairing request." into qt-dev
Amit Mahajan [Mon, 8 Apr 2019 21:22:40 +0000 (14:22 -0700)]
Treat mcx apn type as not wild-cardable.
Test: manual
Bug:
130167974
Change-Id: Ic3e643646491e5a187505fd54ca767ad91e285f5
Bill Yi [Mon, 8 Apr 2019 20:57:43 +0000 (13:57 -0700)]
Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Bug:
64712476
Change-Id: If0ee949c0948860c8a6834fc3b63fa0d9175cfb0
Fan Zhang [Mon, 8 Apr 2019 19:29:27 +0000 (12:29 -0700)]
Do not retrive app detail if the fragment is exiting.
The exit flag can be set by a variety of things, such as when package is
removed, or package is invalid (hidden mainline module). Loading such
packages changes the internal state of ApplicationsState class (an app
singleton), which leads to inconsistencies later.
Fixes:
130166465
Test: robotest
Change-Id: Ib09240cb694fa16692914a7aa9ce354869615c2d
Fan Zhang [Mon, 8 Apr 2019 20:55:58 +0000 (13:55 -0700)]
Add null check in UserPreference
The comparator can get null objects according to bug report.
Fixes:
130144755
Test: manual
Change-Id: Ic8a332d390f411d2eb69c944fb7fd166d9961535
TreeHugger Robot [Mon, 8 Apr 2019 20:00:29 +0000 (20:00 +0000)]
Merge "Delete carrier entry from mobile network details page." into qt-dev
Julia Reynolds [Mon, 8 Apr 2019 19:46:57 +0000 (15:46 -0400)]
Move NAS selection to 'special app access'
Test: manual
Fixes:
130169253
Change-Id: I0e69b11c557bc153cee0073bb2e982e3ee36e721
Malcolm Chen [Fri, 5 Apr 2019 05:24:25 +0000 (22:24 -0700)]
Revert switchBar if enable / disable subscription fails.
Bug:
123321718
Test: build manual test
Change-Id: Ia7e8c762d91f81b67e0d0b11d36dfa78ec1e2d18
Sumit Deshmukh [Thu, 28 Mar 2019 09:01:45 +0000 (14:31 +0530)]
Settings: [BT] Wrong Pairing Popup is shown on new pairing request.
Usecase:
1. Start advertising from DUT (using BLE Smartertooth app).
2. Scan and connect from central device.
3. Now initiate bond from central and accept pairing request.
(Consent Pairing Dialog will be shown on DUT)
4. Notification will be received for PASSKEY CONFIRMATION Dialog.
Do not open notification and let it timeout.
5. Repeat steps 2 and 3. At step 3, Passkey Confirmation pairing
dialog is show instead of Consent pairing dialog.
Issue:
Wrong Pairing Popup is shown. Passkey Confirmation pairing
dialog is show instead of Consent pairing dialog.
Reproducible Rate: 100%
Root Cause:
PendingIntent created for showing pairing notification are getting
reused as only FLAG_ONE_SHOT is used. This flag is not updating new
extra's in the pending intent.
Fix:
Use flag FLAG_UPDATE_CURRENT in pending Intent.
Test: Tested above mentioned testcase and pairing scenarios.
Fix:
129479787
Bug:
129456113
Change-Id: I46813f355cd796cee1b472774b494c8580b39784
TreeHugger Robot [Mon, 8 Apr 2019 18:15:57 +0000 (18:15 +0000)]
Merge "Fix 'Advanced' collapse point on Network & internet page" into qt-dev