OSDN Git Service
Bruce Momjian [Tue, 19 Mar 2002 12:59:08 +0000 (12:59 +0000)]
Just adds a regressions test suite for the ALTER TABLE/ADD PRIMARY KEY
feature.
I'll do ALTER TABLE / DROP CONSTRAINT next...
Christopher Kings-Lynne
Bruce Momjian [Tue, 19 Mar 2002 12:56:38 +0000 (12:56 +0000)]
Add missing trailing semicolons to ecpg rules.
Neil Conway
Bruce Momjian [Tue, 19 Mar 2002 12:52:22 +0000 (12:52 +0000)]
Fix DOMAIN breakage.
Bruce Momjian [Tue, 19 Mar 2002 03:05:38 +0000 (03:05 +0000)]
Add
> * -Add domain capability [domain] (Rod Taylor)
Bruce Momjian [Tue, 19 Mar 2002 03:01:01 +0000 (03:01 +0000)]
psql \? cleanups by Ian Barwick
Bruce Momjian [Tue, 19 Mar 2002 02:58:20 +0000 (02:58 +0000)]
The attached patch cleans up the implementation of the TRUNCATE command;
in the current code, the authentication logic (check user, check the
relation we're operating on, etc) is done in tcop/utility.c, whereas the
actual TRUNCATE command in done in TruncateRelation() in
commands/createinh.c (which is really just a wrapper over
heap_truncate() in catalog/heap.c). This patch moves the authentication
logic into TruncateRelation(), as well as making some minor code
cleanups.
Neil Conway
Bruce Momjian [Tue, 19 Mar 2002 02:57:15 +0000 (02:57 +0000)]
Fix for trigger handling:
* We should not even consider checking the row if it is no longer
* valid since it was either deleted (doesn't matter) or updated
* (in which case it'll be checked with its final values).
Stephan Szabo
Bruce Momjian [Tue, 19 Mar 2002 02:48:45 +0000 (02:48 +0000)]
>Added ServerEncoding
> Korean (JOHAB), Thai (WIN874),
> Vietnamese (TCVN), Arabic (WIN1256)
>
>Added ClientEncoding
> Simplified Chinese (GBK), Korean (UHC)
>
>Add PsqlODBC and document ...etc patch.
"JDBC patch" is delivered, too. :-)
Eiji Tokuya
Bruce Momjian [Tue, 19 Mar 2002 02:47:57 +0000 (02:47 +0000)]
> I am backing out this patch. Please resubmit with this corrected. Thanks.
>
> I am running Python 1.5.
Therein lies the problem... :)
Since it appears you have the requirement of supporting old python
versions, attached is just the pgdb.py part of the patch (with a fix for
DateTime handling). It has the same functionality but certainly won't be
quite as fast. Given the absence of _PyString_Join in python1.5, it's a
pain to get the C variants working for all versions. The pgdb.py patch
does leaves the hooks in, should someone wish to do the optimization at a
later point.
Elliot Lee
Bruce Momjian [Tue, 19 Mar 2002 02:32:21 +0000 (02:32 +0000)]
Add psql \dD listing of domains, from Jonathan Eisler.
Bruce Momjian [Tue, 19 Mar 2002 02:18:25 +0000 (02:18 +0000)]
Add DOMAIN support. Includes manual pages and regression tests, from
Rod Taylor.
Dave Cramer [Tue, 19 Mar 2002 01:32:48 +0000 (01:32 +0000)]
applied patch from Liam Stewart
If one is trying to compile a JDBC 1 driver and junit.jar is in the
CLASSPATH, then the build fails as ant tries to build the JDBC 2 test
classes. This patch fixes this problem by excluding the jdbc 2 files
unless the jdk1.2+ property is set.
Bruce Momjian [Tue, 19 Mar 2002 01:14:41 +0000 (01:14 +0000)]
Comment patch:
This one better describes the problem.
heap.c needs to be updated to include 'Hard coded badness' for that
table.
--
Rod Taylor
Bruce Momjian [Tue, 19 Mar 2002 00:12:09 +0000 (00:12 +0000)]
Improve wording of bug fix:
Ensure that sequence counters do not go backwards after a crash
Bruce Momjian [Mon, 18 Mar 2002 23:03:13 +0000 (23:03 +0000)]
Update for 7.2.1.
Bruce Momjian [Mon, 18 Mar 2002 19:35:10 +0000 (19:35 +0000)]
Update FAQ.
Dave Cramer [Mon, 18 Mar 2002 04:16:33 +0000 (04:16 +0000)]
Fixes bug where query hangs if there is an error in the query, went back to
code before QueryExecutor class was created and copied behaviour
Tom Lane [Sun, 17 Mar 2002 19:59:57 +0000 (19:59 +0000)]
Improve documentation about array I/O representation.
Tom Lane [Sat, 16 Mar 2002 22:47:13 +0000 (22:47 +0000)]
Try to make array_in's behavior a tad less bizarre. Leading whitespace
before a data item is now always skipped, rather than only sometimes.
Backslashes not within double-quoted text are treated reasonably, as
are multiple sequences of quoted text in a single data item. But it
still seems rather prone to misbehavior if the input is not completely
syntactically correct --- in particular, garbage following a right brace
will be ignored.
Dave Cramer [Sat, 16 Mar 2002 02:15:23 +0000 (02:15 +0000)]
fixed QueryExecuter to deal with multiple errors
previously it was throwing a SQLException as soon as the error message was
received from the backend. This did not allow the protocol to finish properly
now, simply collects error messages from the backend until the query is done
and throws exception at the end
Also added setLogLevel to Driver.java, and made the log levels public
Bruce Momjian [Fri, 15 Mar 2002 21:46:59 +0000 (21:46 +0000)]
Manually clean up indenting of ecpg lex/yacc files, OK'ed by Michael
Meskes. These files are not touched by pgindent so this has to be
manually done.
Tom Lane [Fri, 15 Mar 2002 19:20:36 +0000 (19:20 +0000)]
Repair two problems with WAL logging of sequence nextvalI() ops, as
per recent pghackers discussion: force a new WAL record at first nextval
after a checkpoint, and ensure that xlog is flushed to disk if a nextval
record is the only thing emitted by a transaction.
Bruce Momjian [Fri, 15 Mar 2002 16:16:31 +0000 (16:16 +0000)]
Back out EXCEPT/DIFFERENCE patch. Seems I forgot the details of this.
Bruce Momjian [Fri, 15 Mar 2002 15:55:58 +0000 (15:55 +0000)]
Fix for docs from Patrick Welche:
! DIFFERENCE (− or ∖): builds the set difference of
two tables. Let <classname>R</classname> and
<classname>S</classname>
again be two tables with the same
arity. <classname>R</classname> - <classname>S</classname>
--- 488,494 ----
<listitem>
<para>
! EXCEPT (− or ∖): builds the set difference of
Dave Cramer [Fri, 15 Mar 2002 04:11:49 +0000 (04:11 +0000)]
patch from Alexey Slynko
This patch solve problems with arrays in latest development JDBC driver
Bruce Momjian [Thu, 14 Mar 2002 22:44:50 +0000 (22:44 +0000)]
The attached patch changes ALTER TABLE OWNER to also change the
ownership of any toast tables that belong to the table that is being
operated upon (as suggested by Tom Lane).
Neil Conway
Hiroshi Inoue [Thu, 14 Mar 2002 05:42:04 +0000 (05:42 +0000)]
1) Internal improvements to handle updatable cursors(1st cut).
2) Fix a bug in SQLColAttribute().
Peter Eisentraut [Wed, 13 Mar 2002 00:05:06 +0000 (00:05 +0000)]
Move
src/GNUmakefile.in to src/Makefile
and
src/backend/port/Makefile.in to src/backend/port/Makefile
All configure substitutions are now done in Makefile.global.
Bruce Momjian [Tue, 12 Mar 2002 21:44:18 +0000 (21:44 +0000)]
Change "head -1" to "sort q" as suggested for POSIX compatibility.
Tom Lane [Tue, 12 Mar 2002 00:52:10 +0000 (00:52 +0000)]
Restructure representation of join alias variables. An explicit JOIN
now has an RTE of its own, and references to its outputs now are Vars
referencing the JOIN RTE, rather than CASE-expressions. This allows
reverse-listing in ruleutils.c to use the correct alias easily, rather
than painfully reverse-engineering the alias namespace as it used to do.
Also, nested FULL JOINs work correctly, because the result of the inner
joins are simple Vars that the planner can cope with. This fixes a bug
reported a couple times now, notably by Tatsuo on 18-Nov-01. The alias
Vars are expanded into COALESCE expressions where needed at the very end
of planning, rather than during parsing.
Also, beginnings of support for showing plan qualifier expressions in
EXPLAIN. There are probably still cases that need work.
initdb forced due to change of stored-rule representation.
Bruce Momjian [Mon, 11 Mar 2002 18:26:20 +0000 (18:26 +0000)]
More pgsql \? cleanup for Peter E.
Bruce Momjian [Mon, 11 Mar 2002 18:22:03 +0000 (18:22 +0000)]
Correct optional args in psql \? as pointed out by Ian Barwick.
Bruce Momjian [Mon, 11 Mar 2002 16:54:27 +0000 (16:54 +0000)]
Pleas apply it for 7.2.1 and current CVS.
Patch fixes using lc.lang instead of lc.lc_ctype.
Teodor Sigaev
Bruce Momjian [Mon, 11 Mar 2002 16:41:44 +0000 (16:41 +0000)]
Mention time() and interval() are also changed in 7.2.
Bruce Momjian [Mon, 11 Mar 2002 15:08:18 +0000 (15:08 +0000)]
Inlined a patch to add the libpq setNoticeProcessor capability to
libpq++.
Ofir Reichenberg
Michael Meskes [Mon, 11 Mar 2002 12:56:02 +0000 (12:56 +0000)]
Changed the version numbers, but did not commit the Makefiles.
Hiroshi Inoue [Mon, 11 Mar 2002 10:25:57 +0000 (10:25 +0000)]
Bug fixes for the 2002-03-08 change.
1) Put back the error message for SQLError().
2) Change Disallow premature to handle the SELECTed
result.
3) Put back the behavior of AUTUCOMMIT mode change.
4) Fix SQLColumns for ODBC3.0.
5) Improve the handling of variable bookmark in ODBC3.0.
6) Enable Recognize Unique Index Button.
Peter Eisentraut [Mon, 11 Mar 2002 05:03:52 +0000 (05:03 +0000)]
Fix markup
Peter Eisentraut [Mon, 11 Mar 2002 05:02:04 +0000 (05:02 +0000)]
Uppercase class selectors, to work with browsers that follow the standards.
Bruce Momjian [Mon, 11 Mar 2002 04:39:14 +0000 (04:39 +0000)]
Back out this for Peter:
> This simple patch fixes broken Makefile, broken ApplySnapshot and
> makes all utilities honour --verbose command line option.
>
> --
> Yours, Alexey V. Borzov, Webmaster of RDW.ru
>
Michael Meskes [Sun, 10 Mar 2002 12:09:54 +0000 (12:09 +0000)]
Fixed two bugs in define command in pgc.l
Bruce Momjian [Sun, 10 Mar 2002 06:12:23 +0000 (06:12 +0000)]
Update and remove items:
< * Remove brackets as multi-statement rule grouping, must use parens (Bruce)
> * -Remove brackets as multi-statement rule grouping, must use parens (Bruce)
458d457
< * Remove USING clause from pg_get_indexdef() if index is btree (Bruce)
Bruce Momjian [Sun, 10 Mar 2002 06:02:24 +0000 (06:02 +0000)]
Add DEFAULT_INDEX_TYPE == "btree", for clarity.
Bruce Momjian [Sun, 10 Mar 2002 06:00:15 +0000 (06:00 +0000)]
Disable brackets in multi-statement rules, as discussed.
Thomas G. Lockhart [Sat, 9 Mar 2002 17:37:16 +0000 (17:37 +0000)]
Guard against NULL strings in SET key=val constructs.
Problem noted by Fernando Nasser.
Dave Cramer [Sat, 9 Mar 2002 17:36:14 +0000 (17:36 +0000)]
Added a check for not calling next() before getting objects from the result set,
moved the check for columnIndex into same call
check at the top of all getXXX
added appropriate error
Tom Lane [Sat, 9 Mar 2002 17:35:37 +0000 (17:35 +0000)]
Code review for improved-hashing patch. Fix some portability issues
(char != unsigned char, Datum != uint32); make use of new hash code in
dynahash hash tables and hash joins.
Dave Cramer [Sat, 9 Mar 2002 17:08:39 +0000 (17:08 +0000)]
Here is a small patch that cleans up some error reporting in the JDBC driver. PSQLExceptions are thrown instead of SQLExceptions and if a warning is received while waiting for the backend secret key, that warning is chained to the new Connection object instead of generating an exception. A couple new error messages have been added.
Bruce Momjian [Sat, 9 Mar 2002 05:11:38 +0000 (05:11 +0000)]
Wording improvements to runtime.sgml. Add mention in postgresql.conf
file that SIGHUP or "pg_ctl reload" are required for changes to take
affect on a running server.
Bruce Momjian [Fri, 8 Mar 2002 20:36:58 +0000 (20:36 +0000)]
Improve wording of pg_hba.conf file.
Hiroshi Inoue [Fri, 8 Mar 2002 09:50:39 +0000 (09:50 +0000)]
Remove compile errors.
Hiroshi Inoue [Fri, 8 Mar 2002 08:52:55 +0000 (08:52 +0000)]
1) Implement SQLParamOptions().
2) Handle Multiple results and implement SQLMoreResult().
3) Improve multibyte handling thanks to Eiji Tokuya.
4) Add new options.
LF <-> CR/LF converion.
TRUE is -1 (for VB).
5) Introduce unicode(UCS-2) support.
6) Reduce the length of connection strings.
7) Improve SQLError, SQLGetDiagRec(ODBC 3.0).
8) Implement SQLTablePrivileges().
9) Miscellaneous changes for ODBC 3.0 support.
Tom Lane [Fri, 8 Mar 2002 07:12:11 +0000 (07:12 +0000)]
analyze.o need not depend on parser.h.
Tom Lane [Fri, 8 Mar 2002 06:55:08 +0000 (06:55 +0000)]
Remove unnecessary inclusion.
Tom Lane [Fri, 8 Mar 2002 04:37:18 +0000 (04:37 +0000)]
Fix copying/equality-check bugs in GrantStmt and ConstraintsSetStmt,
per reports from Fernando Nasser. Also, rearrange order of declarations
in parsenodes.h as suggested by Fernando.
Bruce Momjian [Fri, 8 Mar 2002 04:34:37 +0000 (04:34 +0000)]
Remove async TODO.detail file.
Bruce Momjian [Fri, 8 Mar 2002 04:33:53 +0000 (04:33 +0000)]
Update TODO items that are completed.
Bruce Momjian [Fri, 8 Mar 2002 04:29:01 +0000 (04:29 +0000)]
TODO item done:
* Change FIXED_CHAR_SEL to 0.20 from 0.04 to give better selectivity (Bruce)
Bruce Momjian [Fri, 8 Mar 2002 04:03:32 +0000 (04:03 +0000)]
Mark as done:
> * -Change DEBUG startup tag to LOG (Bruce)
Bruce Momjian [Fri, 8 Mar 2002 01:31:19 +0000 (01:31 +0000)]
Add
> * Prevent aggregates from being used in rule WHERE clauses
Tom Lane [Fri, 8 Mar 2002 00:42:09 +0000 (00:42 +0000)]
Add missing colon to getopt() arg.
Bruce Momjian [Thu, 7 Mar 2002 20:48:41 +0000 (20:48 +0000)]
Add FULL in VACUUM psql completion.
Bruce Momjian [Thu, 7 Mar 2002 20:18:15 +0000 (20:18 +0000)]
Adjust elog() tags so source and regression tests match.
Bruce Momjian [Thu, 7 Mar 2002 17:54:42 +0000 (17:54 +0000)]
Back out psql domain improvements until domain is applied.
Bruce Momjian [Thu, 7 Mar 2002 16:35:41 +0000 (16:35 +0000)]
Back out domain patch until it works properly.
Bruce Momjian [Thu, 7 Mar 2002 04:45:53 +0000 (04:45 +0000)]
Also an small change to the tab-complete feature of psql which allows to
use tables and views interchangeably.
Manuel Sugawara
Bruce Momjian [Wed, 6 Mar 2002 21:49:52 +0000 (21:49 +0000)]
Fix syntax error introduced by patch.
Bruce Momjian [Wed, 6 Mar 2002 20:49:46 +0000 (20:49 +0000)]
I've attached a patch which implements Bob Jenkin's hash function for
PostgreSQL. This hash function replaces the one used by hash indexes and
the catalog cache. Hash joins use a different, relatively poor-quality
hash function, but I'll fix that later.
As suggested by Tom Lane, this patch also changes the size of the fixed
hash table used by the catalog cache to be a power-of-2 (instead of a
prime: I chose 256 instead of 257). This allows the catcache to lookup
hash buckets using a simple bitmask. This should improve the performance
of the catalog cache slightly, since the previous method (modulo a
prime) was slow.
In my tests, this improves the performance of hash indexes by between 4%
and 8%; the performance when using btree indexes or seqscans is
basically unchanged.
Neil Conway <neilconway@rogers.com>
Bruce Momjian [Wed, 6 Mar 2002 20:48:42 +0000 (20:48 +0000)]
Enable ALTER TABLE ADD PRIMARY KEY for pg_dump, for performance reasons
so index is not on table during COPY.
> > AFAICT, the patch I posted to -patches a little while to enable the
> > usage of ALTER TABLE ADD PRIMARY KEY by pg_dump hasn't been applied, nor
> > is it in the unapplied patches list. I was under the impression that
> > this was in the queue for application -- did it just get lost?
Neil Conway <neilconway@rogers.com>
Bruce Momjian [Wed, 6 Mar 2002 20:42:38 +0000 (20:42 +0000)]
alter table doc cleanups.
Neil Conway
Bruce Momjian [Wed, 6 Mar 2002 20:41:36 +0000 (20:41 +0000)]
This simple patch fixes broken Makefile, broken ApplySnapshot and
makes all utilities honour --verbose command line option.
--
Yours, Alexey V. Borzov, Webmaster of RDW.ru
Bruce Momjian [Wed, 6 Mar 2002 20:39:45 +0000 (20:39 +0000)]
Here is a diff of changes to the psql source code implementing a simple
'list domains' command '\dD'. This is the interface component of
rbt@zort.ca's domain backend modifications.
Jonathan Eisler
Bruce Momjian [Wed, 6 Mar 2002 20:35:02 +0000 (20:35 +0000)]
Ok. Updated patch attached.
- domain.patch -> source patch against pgsql in cvs
- drop_domain.sgml and create_domain.sgml -> New doc/src/sgml/ref docs
- dominfo.txt -> basic domain related queries I used for testing
[ ADDED TO /doc]
Enables domains of array elements -> CREATE DOMAIN dom int4[3][2];
Uses a typbasetype column to describe the origin of the domain.
Copies data to attnotnull rather than processing in execMain().
Some documentation differences from earlier.
If this is approved, I'll start working on pg_dump, and a \dD <domain>
option in psql, and regression tests. I don't really feel like doing
those until the system table structure settles for pg_type.
CHECKS when added, will also be copied to to the table attributes. FK
Constraints (if I ever figure out how) will be done similarly. Both
will lbe handled by MergeDomainAttributes() which is called shortly
before MergeAttributes().
Rod Taylor
Bruce Momjian [Wed, 6 Mar 2002 19:58:26 +0000 (19:58 +0000)]
Modify ALTER TABLE OWNER to change index ownership; code cleanup.
Neil Conway
Bruce Momjian [Wed, 6 Mar 2002 19:05:58 +0000 (19:05 +0000)]
Update docs for new stored procedure error levels.
Bruce Momjian [Wed, 6 Mar 2002 18:50:33 +0000 (18:50 +0000)]
Add new elog() levels to stored procedure languages. plperl DEBUG hack
still needed because only removed in 7.4.
Bruce Momjian [Wed, 6 Mar 2002 14:40:05 +0000 (14:40 +0000)]
Add libpgeasy example file.
Michael Meskes [Wed, 6 Mar 2002 10:10:52 +0000 (10:10 +0000)]
Synced parser with backend.
Bruce Momjian [Wed, 6 Mar 2002 06:48:05 +0000 (06:48 +0000)]
Update reference pages for new INFO, NOTICE, WARNING elog() levels.
Bruce Momjian [Wed, 6 Mar 2002 06:44:33 +0000 (06:44 +0000)]
Update docs for new INFO, NOTICE, WARNING elog() levels.
Bruce Momjian [Wed, 6 Mar 2002 06:23:20 +0000 (06:23 +0000)]
Improve elog descriptions.
Bruce Momjian [Wed, 6 Mar 2002 06:12:59 +0000 (06:12 +0000)]
Add missing Unicode multibyte files.
Bruce Momjian [Wed, 6 Mar 2002 06:10:59 +0000 (06:10 +0000)]
Change made to elog:
o Change all current CVS messages of NOTICE to WARNING. We were going
to do this just before 7.3 beta but it has to be done now, as you will
see below.
o Change current INFO messages that should be controlled by
client_min_messages to NOTICE.
o Force remaining INFO messages, like from EXPLAIN, VACUUM VERBOSE, etc.
to always go to the client.
o Remove INFO from the client_min_messages options and add NOTICE.
Seems we do need three non-ERROR elog levels to handle the various
behaviors we need for these messages.
Regression passed.
Bruce Momjian [Wed, 6 Mar 2002 03:37:16 +0000 (03:37 +0000)]
Add name:
> * Improve concurrency of hash indexes (Neil Conway)
Dave Cramer [Wed, 6 Mar 2002 03:07:45 +0000 (03:07 +0000)]
changed Cancel to cancel
Dave Cramer [Tue, 5 Mar 2002 20:11:57 +0000 (20:11 +0000)]
backed out changes for cancel, no need to look for two 'Z' responses
Dave Cramer [Tue, 5 Mar 2002 18:02:44 +0000 (18:02 +0000)]
Patch by Nicolas Verger to correctly propogate SQLWarning to the Statement and ResultSet
Dave Cramer [Tue, 5 Mar 2002 18:01:27 +0000 (18:01 +0000)]
fixed cancel query bug introduced by patch
Bruce Momjian [Tue, 5 Mar 2002 17:55:45 +0000 (17:55 +0000)]
Autoconf for jdbc debug changes.
Bruce Momjian [Tue, 5 Mar 2002 17:55:23 +0000 (17:55 +0000)]
At this moment, --enable-debug adds debugging information to most of the
parts o f postgresql. The jdbc drivers are never compiled with debugging
support. This p atch make sure that debugging information is added to
the jdbc jar when the --en able-debug is added. This was usefull for me
for debugging some java jdbc poolin g objects but this might perhaps be
usefull for other people too?
Dries Verachtert
Bruce Momjian [Tue, 5 Mar 2002 07:57:45 +0000 (07:57 +0000)]
Prevent failed passwords from being echoed to server logs, for security.
Bruce Momjian [Tue, 5 Mar 2002 06:52:05 +0000 (06:52 +0000)]
Prevent failed passwords from being echoed to server logs, for security.
Bruce Momjian [Tue, 5 Mar 2002 06:28:26 +0000 (06:28 +0000)]
Update FAQ.
Bruce Momjian [Tue, 5 Mar 2002 06:20:51 +0000 (06:20 +0000)]
This version has been synchonized with English version at Mar 03.
With best wishes,Victor Vislobokov
Perm, Russia
Bruce Momjian [Tue, 5 Mar 2002 06:14:45 +0000 (06:14 +0000)]
This trivial patch fixes a typo and improves the phrasing of a sentence
in the docs.
Neil Conway
Bruce Momjian [Tue, 5 Mar 2002 06:13:19 +0000 (06:13 +0000)]
Adds \du documentation line for \? in psqls help.c
Thought I saw a patch earlier converting docs to use []s, so this uses
them.
Rod Taylor
Bruce Momjian [Tue, 5 Mar 2002 06:10:28 +0000 (06:10 +0000)]
Please, apply attached patch for contrib/tsearch to 7.2.1 and current
CVS. It fix english stemmer's problem with ending words like
'technology'.
We have found one more bug in english stemmer. The bug is with
'irregular' english words like 'skies' -> 'sky'. Please, apply attached
cumulative patch to 7.2.1 and current CVS instead previous one.
Thank to Thomas T. Thai <tom@minnesota.com> for hard testing. This kind
of bug has significance only for dump/reload database and viewing, but
searching/indexing works right.
Teodor Sigaev
Bruce Momjian [Tue, 5 Mar 2002 06:07:27 +0000 (06:07 +0000)]
Back out old version and update with newer patch of:
Fix for non-blocking connections in libpq
Bernhard Herzog
Bruce Momjian [Tue, 5 Mar 2002 05:54:07 +0000 (05:54 +0000)]
Currently, contrib/oid2name doesn't bother to free() the memory that it
malloc()'s. This isn't too serious (because oid2name is a short-lived
utility, so the memory will soon be returned to the OS on process
termination), but I still think it's poor style.
This patch changes oid2name so that it allocates memory on the stack
where possible and free()s the remaining heap-allocated memory. The
patch also fixes a typo a comment and adds 'const' qualifiers to a few
'char *' function parameters.
Neil Conway
Bruce Momjian [Tue, 5 Mar 2002 05:52:50 +0000 (05:52 +0000)]
> Tatsuo Ishii wrote:
> > > > It was made to cope with encoding such as an Asian bloc in 7.2Beta2.
> > > >
> > > > Added ServerEncoding
> > > > Korean (JOHAB), Thai (WIN874),
> > > > Vietnamese (TCVN), Arabic (WIN1256)
> > > >
> > > > Added ClientEncoding
> > > > Simplified Chinese (GBK), Korean (UHC)
> > > >
> > > >
> > > >
> http://www.sankyo-unyu.co.jp/Pool/postgresql-7.2b2.newencoding.diff.tar.gz
> > > > (608K)
> > >
> > > Looks good. I need some people to review this for me.
> >
> > For me they look good too. The only missing part is a
> > documentation. I will ask him to write it up. If he couldn't, I will
> > do it for him.
> > > The diff is 3mb
> > > but appears to address only additions to multibyte. I have attached a
> > > list of files it modifies. Also, look at the sizes of the mb/
> > > directory. It is getting large:
> > >
> > > 4 ./CVS
> > > 6 ./Unicode/CVS
> > > 3433 ./Unicode
> > > 6197 .
> >
> > Yes. We definitely need the on-the-fly encoding addition capability:
> > i.e. CREATE CHRACTER SET in the future...
> > --
> > Tatsuo Ishii
> >
> >
Address chainge.
http://www.sankyo-unyu.co.jp/Pool/postgresql-7.2.newencoding.diff.gz
Add PsqlODBC and document ...etc patch.
Eiji Tokuya