OSDN Git Service

kde/Katie.git
4 years agomake stat() error checks consisten in QFileSystemEngine::createDirectory(), QFileSyst...
Ivailo Monev [Sun, 29 Dec 2019 06:04:16 +0000 (06:04 +0000)]
make stat() error checks consisten in QFileSystemEngine::createDirectory(), QFileSystemEngine::removeDirectory() and QFileSystemEngine::copyFile()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove redundant condition in QFileSystemEngine::fillMetaData()
Ivailo Monev [Sun, 29 Dec 2019 05:44:52 +0000 (05:44 +0000)]
remove redundant condition in QFileSystemEngine::fillMetaData()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agouse QLocalServer in QtNetworkSettings::supportsIPv6()
Ivailo Monev [Sun, 29 Dec 2019 04:21:20 +0000 (04:21 +0000)]
use QLocalServer in QtNetworkSettings::supportsIPv6()

QLocalServer can poke the address regardless if it is protected as it does
not bind to the address

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agofix Travis build
Ivailo Monev [Sun, 29 Dec 2019 03:33:37 +0000 (03:33 +0000)]
fix Travis build

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agodo not include aliases in all codec names
Ivailo Monev [Sun, 29 Dec 2019 03:29:11 +0000 (03:29 +0000)]
do not include aliases in all codec names

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoavoid deep copy of strings in QIcuCodec::aliases() and QIcuCodec::allCodecs()
Ivailo Monev [Sun, 29 Dec 2019 02:59:03 +0000 (02:59 +0000)]
avoid deep copy of strings in QIcuCodec::aliases() and QIcuCodec::allCodecs()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agono need to install newer libzstd version in Travis anymore
Ivailo Monev [Sat, 28 Dec 2019 23:57:14 +0000 (23:57 +0000)]
no need to install newer libzstd version in Travis anymore

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoset Travis dist to bionic
Ivailo Monev [Sat, 28 Dec 2019 23:41:32 +0000 (23:41 +0000)]
set Travis dist to bionic

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agocorrect some comments in top-level CMake file [ci skip]
Ivailo Monev [Sat, 28 Dec 2019 23:23:06 +0000 (23:23 +0000)]
correct some comments in top-level CMake file [ci skip]

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agorely on the fact that default QTime constructor is for null-time in QTime::fromString()
Ivailo Monev [Sat, 28 Dec 2019 23:14:34 +0000 (23:14 +0000)]
rely on the fact that default QTime constructor is for null-time in QTime::fromString()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoreplace QT_TYPENAME with Q_TYPENAME and remove it
Ivailo Monev [Sat, 28 Dec 2019 23:07:22 +0000 (23:07 +0000)]
replace QT_TYPENAME with Q_TYPENAME and remove it

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agouse single variable assignment in QUuid::fromRfc4122()
Ivailo Monev [Sat, 28 Dec 2019 22:59:04 +0000 (22:59 +0000)]
use single variable assignment in QUuid::fromRfc4122()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove redundant default case in QParallelAnimationGroupPrivate::applyGroupState()
Ivailo Monev [Sat, 28 Dec 2019 22:37:51 +0000 (22:37 +0000)]
remove redundant default case in QParallelAnimationGroupPrivate::applyGroupState()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove default QParallelAnimationGroup::event() reimplementation
Ivailo Monev [Sat, 28 Dec 2019 22:35:59 +0000 (22:35 +0000)]
remove default QParallelAnimationGroup::event() reimplementation

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove default QPauseAnimation::event() reimplementation
Ivailo Monev [Sat, 28 Dec 2019 22:34:45 +0000 (22:34 +0000)]
remove default QPauseAnimation::event() reimplementation

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove default QSequentialAnimationGroup::event() reimplementation
Ivailo Monev [Sat, 28 Dec 2019 22:25:32 +0000 (22:25 +0000)]
remove default QSequentialAnimationGroup::event() reimplementation

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove redundant reinterpret_cast<> in QIcuCodec::convertFromUnicode()
Ivailo Monev [Sat, 28 Dec 2019 22:17:43 +0000 (22:17 +0000)]
remove redundant reinterpret_cast<> in QIcuCodec::convertFromUnicode()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agodeal with QVarLengthArray TODO
Ivailo Monev [Sat, 28 Dec 2019 22:06:28 +0000 (22:06 +0000)]
deal with QVarLengthArray TODO

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agomove qstringmatcher header inclusion from qstringlist header to source file
Ivailo Monev [Sat, 28 Dec 2019 20:57:00 +0000 (20:57 +0000)]
move qstringmatcher header inclusion from qstringlist header to source file

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove redundant uint() construct in QDate::setYMD()
Ivailo Monev [Sat, 28 Dec 2019 19:24:35 +0000 (19:24 +0000)]
remove redundant uint() construct in QDate::setYMD()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoreturn object rather than reference from QFileInfoPrivate::getFileTime()
Ivailo Monev [Sat, 28 Dec 2019 19:23:39 +0000 (19:23 +0000)]
return object rather than reference from QFileInfoPrivate::getFileTime()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agocorrect QFileInfoPrivate::getCachedFlag() return value
Ivailo Monev [Sat, 28 Dec 2019 18:28:45 +0000 (18:28 +0000)]
correct QFileInfoPrivate::getCachedFlag() return value

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agooptimize QSize::scale()
Ivailo Monev [Sat, 28 Dec 2019 18:10:05 +0000 (18:10 +0000)]
optimize QSize::scale()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove bogus compile-time error in qrect header
Ivailo Monev [Sat, 28 Dec 2019 17:55:54 +0000 (17:55 +0000)]
remove bogus compile-time error in qrect header

there is no topLeft() function that I am aware of

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agouse uninitialized buffer instead of resizing one in QByteDataBuffer::read()
Ivailo Monev [Sat, 28 Dec 2019 17:39:30 +0000 (17:39 +0000)]
use uninitialized buffer instead of resizing one in QByteDataBuffer::read()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agobuild against internal copies of libpng and sqlite if not found
Ivailo Monev [Sat, 28 Dec 2019 16:29:17 +0000 (16:29 +0000)]
build against internal copies of libpng and sqlite if not found

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agomark getSettingsPath() function as static
Ivailo Monev [Sat, 28 Dec 2019 04:19:47 +0000 (04:19 +0000)]
mark getSettingsPath() function as static

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agomark default case in QCryptographicHash::hash() as unreachable
Ivailo Monev [Sat, 28 Dec 2019 03:31:19 +0000 (03:31 +0000)]
mark default case in QCryptographicHash::hash() as unreachable

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agofix build-time check in qt_safe_accept() and introduce NetBSD support
Ivailo Monev [Sat, 28 Dec 2019 02:51:36 +0000 (02:51 +0000)]
fix build-time check in qt_safe_accept() and introduce NetBSD support

upstream commit:
https://github.com/qt/qtbase/commit/b3b2f502e9b499814a1e3b21e1b572e3ff1ba37b

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove redundant QT_SOCKOPTLEN_T definition
Ivailo Monev [Sat, 28 Dec 2019 02:29:48 +0000 (02:29 +0000)]
remove redundant QT_SOCKOPTLEN_T definition

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoavoid struct mirroring by including qobject_p header in qsignaldumper source file
Ivailo Monev [Sat, 28 Dec 2019 02:22:52 +0000 (02:22 +0000)]
avoid struct mirroring by including qobject_p header in qsignaldumper source file

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoreplace C-style casts with static_cast where applicable
Ivailo Monev [Sat, 28 Dec 2019 01:47:40 +0000 (01:47 +0000)]
replace C-style casts with static_cast where applicable

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoplug QDateTime memory leaks
Ivailo Monev [Sat, 28 Dec 2019 01:23:58 +0000 (01:23 +0000)]
plug QDateTime memory leaks

caused by shadowing member

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agodo not reallocate shared empty/null QByteArray data
Ivailo Monev [Sat, 28 Dec 2019 01:04:10 +0000 (01:04 +0000)]
do not reallocate shared empty/null QByteArray data

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoQSharedData ref member does not have to be mutable
Ivailo Monev [Sat, 28 Dec 2019 01:01:03 +0000 (01:01 +0000)]
QSharedData ref member does not have to be mutable

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agodo not free the shared empty and shared null QByteArray data
Ivailo Monev [Sat, 28 Dec 2019 00:23:29 +0000 (00:23 +0000)]
do not free the shared empty and shared null QByteArray data

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove redundant QT_NO_EXCEPTIONS definition from minsize.sh script [ci skip]
Ivailo Monev [Sat, 28 Dec 2019 00:12:02 +0000 (00:12 +0000)]
remove redundant QT_NO_EXCEPTIONS definition from minsize.sh script [ci skip]

exceptions are automatically disabled via Q_COMPILER_EXCEPTIONS

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agocompiler warning fixes
Ivailo Monev [Sat, 28 Dec 2019 00:04:51 +0000 (00:04 +0000)]
compiler warning fixes

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoQFont::exactMatch() should return false for aliases
Ivailo Monev [Fri, 27 Dec 2019 15:45:03 +0000 (15:45 +0000)]
QFont::exactMatch() should return false for aliases

upstream commit:
https://github.com/qt/qtbase/commit/78eeb6b066113c678fe15531ca10e70964f6b9a4

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agouse public QByteArray constructor in QByteArray::trimmed()
Ivailo Monev [Fri, 27 Dec 2019 15:11:44 +0000 (15:11 +0000)]
use public QByteArray constructor in QByteArray::trimmed()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agouse public QString constructors in QString::simplified() and QString::trimmed()
Ivailo Monev [Fri, 27 Dec 2019 15:11:11 +0000 (15:11 +0000)]
use public QString constructors in QString::simplified() and QString::trimmed()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoQDirIterator destructor does not have to be virtual
Ivailo Monev [Fri, 27 Dec 2019 15:09:50 +0000 (15:09 +0000)]
QDirIterator destructor does not have to be virtual

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoavoid temporary in QDirIteratorPrivate::pushDirectory()
Ivailo Monev [Fri, 27 Dec 2019 15:07:56 +0000 (15:07 +0000)]
avoid temporary in QDirIteratorPrivate::pushDirectory()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoavoid temporary in QUrl streaming operator
Ivailo Monev [Fri, 27 Dec 2019 14:58:54 +0000 (14:58 +0000)]
avoid temporary in QUrl streaming operator

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoreplace QListIterator<> with foreach() where applicable
Ivailo Monev [Fri, 27 Dec 2019 13:30:08 +0000 (13:30 +0000)]
replace QListIterator<> with foreach() where applicable

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoRevert "get rid of QByteArray::shared_empty and QString::shared_empty"
Ivailo Monev [Fri, 27 Dec 2019 12:29:42 +0000 (12:29 +0000)]
Revert "get rid of QByteArray::shared_empty and QString::shared_empty"

This reverts commit 259252b337b15cebdc556e597a30c5a8fb0ac1ef.

4 years agoavoid temporary in QCalendarDateValidator::currentText() const
Ivailo Monev [Fri, 27 Dec 2019 12:10:39 +0000 (12:10 +0000)]
avoid temporary in QCalendarDateValidator::currentText() const

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agomake TextWriter::hasOverlap() const and avoid temporary in it
Ivailo Monev [Fri, 27 Dec 2019 12:10:11 +0000 (12:10 +0000)]
make TextWriter::hasOverlap() const and avoid temporary in it

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove redundant uint() constructs in QString::at() and QString::operator[]
Ivailo Monev [Fri, 27 Dec 2019 11:36:07 +0000 (11:36 +0000)]
remove redundant uint() constructs in QString::at() and QString::operator[]

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoget rid of QByteArray::shared_empty and QString::shared_empty
Ivailo Monev [Fri, 27 Dec 2019 10:49:10 +0000 (10:49 +0000)]
get rid of QByteArray::shared_empty and QString::shared_empty

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoinline qstrnlen() function to strnlen()
Ivailo Monev [Fri, 27 Dec 2019 10:27:13 +0000 (10:27 +0000)]
inline qstrnlen() function to strnlen()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove bogus compile-time error
Ivailo Monev [Fri, 27 Dec 2019 10:14:50 +0000 (10:14 +0000)]
remove bogus compile-time error

the signature for truncate() from unistd header takes two arguments,
QByteArray::truncate() takes only one

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoprotect QIcuCodec::allCodecs() and QIcuCodec::allMibs() cache with mutex
Ivailo Monev [Fri, 27 Dec 2019 09:03:17 +0000 (09:03 +0000)]
protect QIcuCodec::allCodecs() and QIcuCodec::allMibs() cache with mutex

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoRevert "install newer libpng version in Travis"
Ivailo Monev [Fri, 27 Dec 2019 07:45:29 +0000 (07:45 +0000)]
Revert "install newer libpng version in Travis"

This reverts commit a6e204f4d8e209285256f252081b09e159aafc74.

4 years agoinstall newer libpng version in Travis
Ivailo Monev [Fri, 27 Dec 2019 06:58:24 +0000 (06:58 +0000)]
install newer libpng version in Travis

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agorequire LibTIFF v3.6.0 atleast
Ivailo Monev [Fri, 27 Dec 2019 06:19:55 +0000 (06:19 +0000)]
require LibTIFF v3.6.0 atleast

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoreplace convert_rgb888_to_rgb32_C() function pointer with actual function call
Ivailo Monev [Fri, 27 Dec 2019 05:56:12 +0000 (05:56 +0000)]
replace convert_rgb888_to_rgb32_C() function pointer with actual function call

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agorequire libpng v1.5.4 atleast
Ivailo Monev [Fri, 27 Dec 2019 05:37:54 +0000 (05:37 +0000)]
require libpng v1.5.4 atleast

there is no tarball for stable v1.5.3 in the archive at:
https://ftp-osl.osuosl.org/pub/libpng/src/archive/xz/libpng15/

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agocorrect ZLIB package version requirement note
Ivailo Monev [Fri, 27 Dec 2019 05:36:24 +0000 (05:36 +0000)]
correct ZLIB package version requirement note

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agowarn on negative data size from qCompress() function
Ivailo Monev [Fri, 27 Dec 2019 05:24:04 +0000 (05:24 +0000)]
warn on negative data size from qCompress() function

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoavoid buffer resizing in qCompress() function
Ivailo Monev [Fri, 27 Dec 2019 05:14:00 +0000 (05:14 +0000)]
avoid buffer resizing in qCompress() function

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agosimplify qUncompress() function
Ivailo Monev [Fri, 27 Dec 2019 03:27:27 +0000 (03:27 +0000)]
simplify qUncompress() function

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoinline qstrcmp() function overloads
Ivailo Monev [Fri, 27 Dec 2019 02:03:43 +0000 (02:03 +0000)]
inline qstrcmp() function overloads

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoindent and use signle variable assignment in QByteArray::toBase64()
Ivailo Monev [Fri, 27 Dec 2019 01:21:57 +0000 (01:21 +0000)]
indent and use signle variable assignment in QByteArray::toBase64()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoreplace tabs with spaces in QByteArray::fromBase64()
Ivailo Monev [Fri, 27 Dec 2019 01:19:21 +0000 (01:19 +0000)]
replace tabs with spaces in QByteArray::fromBase64()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove redundant header inclusions from qfont_x11 source file
Ivailo Monev [Thu, 26 Dec 2019 21:19:42 +0000 (21:19 +0000)]
remove redundant header inclusions from qfont_x11 source file

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove redundant QFONTLOADER_DEBUG and QFONTLOADER_DEBUG_VERBOSE definitions
Ivailo Monev [Thu, 26 Dec 2019 21:19:24 +0000 (21:19 +0000)]
remove redundant QFONTLOADER_DEBUG and QFONTLOADER_DEBUG_VERBOSE definitions

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agooptimize QFont::lastResortFont()
Ivailo Monev [Thu, 26 Dec 2019 21:19:00 +0000 (21:19 +0000)]
optimize QFont::lastResortFont()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove redundant qt_defaultDpiX(), qt_defaultDpiY() and qt_defaultDpi() functions
Ivailo Monev [Thu, 26 Dec 2019 19:58:18 +0000 (19:58 +0000)]
remove redundant qt_defaultDpiX(), qt_defaultDpiY() and qt_defaultDpi() functions

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove non-existing classes forward declarations from qx11info_x11 header
Ivailo Monev [Thu, 26 Dec 2019 19:46:43 +0000 (19:46 +0000)]
remove non-existing classes forward declarations from qx11info_x11 header

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agooptimize and make font tables lookups consistent
Ivailo Monev [Thu, 26 Dec 2019 18:58:00 +0000 (18:58 +0000)]
optimize and make font tables lookups consistent

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove redundant Q_UNUSED() macro calls in bestFoundry() function
Ivailo Monev [Thu, 26 Dec 2019 18:21:07 +0000 (18:21 +0000)]
remove redundant Q_UNUSED() macro calls in bestFoundry() function

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agocheck if path is writable as fallback in QSettings::isWritable()
Ivailo Monev [Wed, 25 Dec 2019 22:26:14 +0000 (22:26 +0000)]
check if path is writable as fallback in QSettings::isWritable()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoconvert strings to ASCII instead of Latin1 in QSettingsPrivate::variantToString()
Ivailo Monev [Wed, 25 Dec 2019 21:52:02 +0000 (21:52 +0000)]
convert strings to ASCII instead of Latin1 in QSettingsPrivate::variantToString()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoreplace break with return in QSettingsPrivate::variantToString()
Ivailo Monev [Wed, 25 Dec 2019 21:51:08 +0000 (21:51 +0000)]
replace break with return in QSettingsPrivate::variantToString()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoconvert strings from/to ASCII instead of Latin1 in QSettingsPrivate::variantToString()
Ivailo Monev [Wed, 25 Dec 2019 21:50:08 +0000 (21:50 +0000)]
convert strings from/to ASCII instead of Latin1 in QSettingsPrivate::variantToString()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoupdate QSettings documentation [ci skip]
Ivailo Monev [Wed, 25 Dec 2019 21:23:17 +0000 (21:23 +0000)]
update QSettings documentation [ci skip]

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove redundant QT_RCC and QT_UIC definitions
Ivailo Monev [Wed, 25 Dec 2019 18:43:41 +0000 (18:43 +0000)]
remove redundant QT_RCC and QT_UIC definitions

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove uic3 leftovers
Ivailo Monev [Wed, 25 Dec 2019 18:39:35 +0000 (18:39 +0000)]
remove uic3 leftovers

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agomake all custom CMake modules print library in status message
Ivailo Monev [Wed, 25 Dec 2019 18:29:33 +0000 (18:29 +0000)]
make all custom CMake modules print library in status message

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoupdate README [ci skip]
Ivailo Monev [Wed, 25 Dec 2019 17:57:59 +0000 (17:57 +0000)]
update README [ci skip]

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoavoid temporary in QVariant::canConvert() and int() constructs
Ivailo Monev [Wed, 25 Dec 2019 17:31:07 +0000 (17:31 +0000)]
avoid temporary in QVariant::canConvert() and int() constructs

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoset Architectures to those which Debian provides binary packages for in Debian contro...
Ivailo Monev [Wed, 25 Dec 2019 17:23:32 +0000 (17:23 +0000)]
set Architectures to those which Debian provides binary packages for in Debian control file [ci skip]

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agolink tst_script to script component
Ivailo Monev [Wed, 25 Dec 2019 08:48:14 +0000 (08:48 +0000)]
link tst_script to script component

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agolink performance_server to core component
Ivailo Monev [Wed, 25 Dec 2019 07:16:51 +0000 (07:16 +0000)]
link performance_server to core component

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove redundant Q_UNUSED() macro call in QDBusConnectionPrivate::serviceOwnerChanged...
Ivailo Monev [Wed, 25 Dec 2019 07:15:01 +0000 (07:15 +0000)]
remove redundant Q_UNUSED() macro call in QDBusConnectionPrivate::serviceOwnerChangedNoLock()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agolink QDBusType test to D-Bus libraries
Ivailo Monev [Wed, 25 Dec 2019 06:35:36 +0000 (06:35 +0000)]
link QDBusType test to D-Bus libraries

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agouse foreach() for iteration in ~QFactoryLoaderPrivate(), QFactoryLoader::updateDir...
Ivailo Monev [Wed, 25 Dec 2019 05:55:31 +0000 (05:55 +0000)]
use foreach() for iteration in ~QFactoryLoaderPrivate(), QFactoryLoader::updateDir() and QFactoryLoader::update()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agomove variable closer to the scope it is used in in QFactoryLoader::updateDir()
Ivailo Monev [Wed, 25 Dec 2019 05:54:04 +0000 (05:54 +0000)]
move variable closer to the scope it is used in in QFactoryLoader::updateDir()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoupdate QSettings documentation [ci skip]
Ivailo Monev [Wed, 25 Dec 2019 05:08:38 +0000 (05:08 +0000)]
update QSettings documentation [ci skip]

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoremove redundant QProcEnvKey
Ivailo Monev [Wed, 25 Dec 2019 04:17:48 +0000 (04:17 +0000)]
remove redundant QProcEnvKey

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agodrop redundant QSettings UNIX file locking
Ivailo Monev [Wed, 25 Dec 2019 03:36:14 +0000 (03:36 +0000)]
drop redundant QSettings UNIX file locking

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agoavoid temporaries in QString::isRightToLeft()
Ivailo Monev [Tue, 24 Dec 2019 23:17:51 +0000 (23:17 +0000)]
avoid temporaries in QString::isRightToLeft()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agosetup include directories before including sub-directory CMake files
Ivailo Monev [Tue, 24 Dec 2019 22:23:55 +0000 (22:23 +0000)]
setup include directories before including sub-directory CMake files

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agocorrect and verify codepoint conversion in tst_QChar::normalization_data()
Ivailo Monev [Tue, 24 Dec 2019 22:23:15 +0000 (22:23 +0000)]
correct and verify codepoint conversion in tst_QChar::normalization_data()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agomark overflow cases in QByteArray integer conversion methods unlikely
Ivailo Monev [Tue, 24 Dec 2019 22:22:28 +0000 (22:22 +0000)]
mark overflow cases in QByteArray integer conversion methods unlikely

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agocheck if string is normalized before normalizing it from QString::normalized()
Ivailo Monev [Tue, 24 Dec 2019 21:29:36 +0000 (21:29 +0000)]
check if string is normalized before normalizing it from QString::normalized()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agosimplify the QSettings write check
Ivailo Monev [Tue, 24 Dec 2019 19:19:32 +0000 (19:19 +0000)]
simplify the QSettings write check

the previous implementation was supposed to be write-optimized, for cases
when QSettings::setValue() followed by QSettings::sync() is called often.
it turns out that optimizing for reading from the settings without changing
the object is more beneficial as that is often the case.

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agooptimize key/value and section/key splitting in ini_settings_read() function
Ivailo Monev [Tue, 24 Dec 2019 18:18:09 +0000 (18:18 +0000)]
optimize key/value and section/key splitting in ini_settings_read() function

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
4 years agolock QSettingsPrivate object that work with the same file only from QSettingsPrivate...
Ivailo Monev [Tue, 24 Dec 2019 09:35:43 +0000 (09:35 +0000)]
lock QSettingsPrivate object that work with the same file only from QSettingsPrivate::write()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>