OSDN Git Service
Heikki Linnakangas [Wed, 13 Apr 2011 08:43:22 +0000 (11:43 +0300)]
On IA64 architecture, we check the depth of the register stack in addition
to the regular stack. The code to do that is platform and compiler specific,
add support for the HP-UX native compiler.
Tom Lane [Wed, 13 Apr 2011 06:56:33 +0000 (02:56 -0400)]
Add some useful cross-references to the CREATE EXTENSION reference page.
Per a suggestion from Josh Kupershmidt, though I modified his patch
quite a lot.
Tom Lane [Tue, 12 Apr 2011 23:19:24 +0000 (19:19 -0400)]
Pass collations to functions in FunctionCallInfoData, not FmgrInfo.
Since collation is effectively an argument, not a property of the function,
FmgrInfo is really the wrong place for it; and this becomes critical in
cases where a cached FmgrInfo is used for varying purposes that might need
different collation settings. Fix by passing it in FunctionCallInfoData
instead. In particular this allows a clean fix for bug #5970 (record_cmp
not working). This requires touching a bit more code than the original
method, but nobody ever thought that collations would not be an invasive
patch...
Tom Lane [Tue, 12 Apr 2011 06:05:24 +0000 (02:05 -0400)]
Suppress compiler warnings about "value computed is not used".
The recent patch to remove gcc 4.6 warnings created some new ones, at
least on my rather old gcc version. Try to make everybody happy by
casting to "void" when we just want to discard the result.
Tom Lane [Tue, 12 Apr 2011 05:59:34 +0000 (01:59 -0400)]
Be more wary of missing statistics in eqjoinsel_semi().
In particular, if we don't have real ndistinct estimates for both sides,
fall back to assuming that half of the left-hand rows have join partners.
This is what was done in 8.2 and 8.3 (cf nulltestsel() in those versions).
It's pretty stupid but it won't lead us to think that an antijoin produces
no rows out, as seen in recent example from Uwe Schroeder.
Tom Lane [Tue, 12 Apr 2011 01:32:53 +0000 (21:32 -0400)]
Fix RI_Initial_Check to use a COLLATE clause when needed in its query.
If the referencing and referenced columns have different collations,
the parser will be unable to resolve which collation to use unless it's
helped out in this way. The effects are sometimes masked, if we end up
using a non-collation-sensitive plan; but if we do use a mergejoin
we'll see a failure, as recently noted by Robert Haas.
The SQL spec states that the referenced column's collation should be used
to resolve RI checks, so that's what we do. Note however that we currently
don't append a COLLATE clause when writing a query that examines only the
referencing column. If we ever support collations that have varying
notions of equality, that will have to be changed. For the moment, though,
it's preferable to leave it off so that we can use a normal index on the
referencing column.
Peter Eisentraut [Mon, 11 Apr 2011 19:28:45 +0000 (22:28 +0300)]
Clean up most -Wunused-but-set-variable warnings from gcc 4.6
This warning is new in gcc 4.6 and part of -Wall. This patch cleans
up most of the noise, but there are some still warnings that are
trickier to remove.
Tom Lane [Mon, 11 Apr 2011 16:28:28 +0000 (12:28 -0400)]
Teach pattern_fixed_prefix() about collations.
This is necessary, not optional, now that ILIKE and regexes are collation
aware --- else we might derive a wrong comparison constant for index
optimized pattern matches.
Heikki Linnakangas [Mon, 11 Apr 2011 10:46:37 +0000 (13:46 +0300)]
TransferPredicateLocksToNewTarget should initialize a new lock
entry's commitSeqNo to that of the old one being transferred, or take
the minimum commitSeqNo if it is merging two lock entries.
Also, CreatePredicateLock should initialize commitSeqNo for to
InvalidSerCommitSeqNo instead of to 0. (I don't think using 0 would
actually affect anything, but we should be consistent.)
I also added a couple of assertions I used to track this down: a
lock's commitSeqNo should never be zero, and it should be
InvalidSerCommitSeqNo if and only if the lock is not held by
OldCommittedSxact.
Dan Ports, to fix leak of predicate locks reported by YAMAMOTO Takashi.
Heikki Linnakangas [Mon, 11 Apr 2011 10:43:31 +0000 (13:43 +0300)]
Fix the size of predicate lock manager's shared memory hash tables at creation.
This way they don't compete with the regular lock manager for the slack shared
memory, making the behavior more predictable.
Tom Lane [Sun, 10 Apr 2011 23:37:24 +0000 (19:37 -0400)]
Add some more mapping macros for Microsoft wide-character API.
Per buildfarm.
Tom Lane [Sun, 10 Apr 2011 22:44:07 +0000 (18:44 -0400)]
Insert dummy "break"s to silence compiler complaints.
Apparently some compilers dislike a case label with nothing after it.
Per buildfarm.
Andrew Dunstan [Sun, 10 Apr 2011 22:26:53 +0000 (18:26 -0400)]
Remove CRLF line endings in new cube results file.
Tom Lane [Sun, 10 Apr 2011 22:02:17 +0000 (18:02 -0400)]
Teach regular expression operators to honor collations.
This involves getting the character classification and case-folding
functions in the regex library to use the collations infrastructure.
Most of this work had been done already in connection with the upper/lower
and LIKE logic, so it was a simple matter of transposition.
While at it, split out these functions into a separate source file
regc_pg_locale.c, so that they can be correctly labeled with the Postgres
project's license rather than the Scriptics license. These functions are
100% Postgres-written code whereas what remains in regc_locale.c is still
mostly not ours, so lumping them both under the same copyright notice was
getting more and more misleading.
Andrew Dunstan [Sun, 10 Apr 2011 20:57:42 +0000 (16:57 -0400)]
Adjust regression tests on cube and ECPG for MinGW 64 bit compiler.
Backport to 9.0, we're not supporting this compiler on earlier releases.
Andrew Dunstan [Sun, 10 Apr 2011 18:51:26 +0000 (14:51 -0400)]
Don't make "replication" magical as a user name, only as a database name, in pg_hba.conf.
Per gripe from Josh Berkus.
Bruce Momjian [Sun, 10 Apr 2011 15:42:00 +0000 (11:42 -0400)]
pgindent run before PG 9.1 beta 1.
Tom Lane [Tue, 29 Mar 2011 21:54:27 +0000 (17:54 -0400)]
Clean up overly complex code for issuing some related error messages.
The original version was unreadable, and not mechanically checkable
either.
Peter Eisentraut [Sat, 9 Apr 2011 21:14:20 +0000 (00:14 +0300)]
Add collation support on Windows (MSVC build)
There is not yet support in initdb to populate the pg_collation
catalog, but if that is done manually, the rest should work.
Tom Lane [Sat, 9 Apr 2011 21:12:39 +0000 (17:12 -0400)]
Fix ILIKE to honor collation when working in single-byte encodings.
The original collation patch only fixed the multi-byte code path.
This change also ensures that ILIKE's idea of the case-folding rules
is exactly the same as str_tolower's.
Tom Lane [Sat, 9 Apr 2011 20:24:36 +0000 (16:24 -0400)]
Remove collate.linux.utf8.sql's assumptions about ".utf8" in locale names.
Tweak the test so that it does not depend on the platform using ".utf8" as
the extension signifying that a locale uses UTF8 encoding. For the most
part this just requires using the abbreviated collation names "en_US" etc,
though I had to work a bit harder on the collation creation tests.
This opens the door to using the test on platforms that spell locales
differently, for example ".utf-8" or ".UTF-8". Also, the test is now
somewhat useful with server encodings other than UTF8; though depending on
which encoding is selected, different subsets of it will fail for lack of
character set support.
Tom Lane [Sat, 9 Apr 2011 18:40:09 +0000 (14:40 -0400)]
Adjust collation determination rules as per discussion.
Remove crude hack that tried to propagate collation through a
function-returning-record, ie, from the function's arguments to individual
fields selected from its result record. That is just plain inconsistent,
because the function result is composite and cannot have a collation;
and there's no hope of making this kind of action-at-a-distance work
consistently. Adjust regression test cases that expected this to happen.
Meanwhile, the behavior of casting to a domain with a declared collation
stays the same as it was, since that seemed to be the consensus.
Tom Lane [Sat, 9 Apr 2011 18:08:41 +0000 (14:08 -0400)]
Don't show unusable collations in psql's \dO command.
"Unusable" collations are those not matching the current database's
encoding. The former behavior inconsistently showed such collations
some of the time, depending on the details of the pattern argument.
Andrew Dunstan [Sat, 9 Apr 2011 03:11:37 +0000 (23:11 -0400)]
Latest consolidated typedef list from buildfarm.
Tom Lane [Fri, 8 Apr 2011 23:19:17 +0000 (19:19 -0400)]
Clean up minor collation issues in indxpath.c.
Get rid of bogus collation test in match_special_index_operator (even for
ILIKE, the pattern match operator's collation doesn't matter here, and even
if it did the test was testing the wrong thing).
Fix broken looping logic in expand_indexqual_rowcompare.
Add collation check in match_clause_to_ordering_op.
Make naming and argument ordering more consistent; improve comments.
Tom Lane [Fri, 8 Apr 2011 21:39:59 +0000 (17:39 -0400)]
Fix make_greater_string to not have an undocumented collation assumption.
The previous coding worked only if ltproc->fn_collation was always either
DEFAULT_COLLATION_OID or a C-compatible locale. While that's true at the
moment, it wasn't documented (and in fact wasn't true when this code was
committed...). But it only takes a couple more lines to make its internal
caching behavior locale-aware, so let's do that.
Robert Haas [Fri, 8 Apr 2011 20:51:45 +0000 (16:51 -0400)]
Truncate the predicate lock SLRU to empty, instead of almost empty.
Otherwise, the SLRU machinery can get confused and think that the SLRU
has wrapped around. Along the way, regardless of whether we're
truncating all of the SLRU or just some of it, flush pages after
truncating, rather than before.
Kevin Grittner
Tom Lane [Fri, 8 Apr 2011 20:48:25 +0000 (16:48 -0400)]
Tweak collation setup for GIN index comparison functions.
Honor index column's collation spec if there is one, don't go to the
expense of calling get_typcollation when we can reasonably assume that
all GIN storage types will use default collation, and be sure to set
a collation for the comparePartialFn too.
Tom Lane [Fri, 8 Apr 2011 20:11:04 +0000 (16:11 -0400)]
Avoid an unnecessary syscache lookup in parse_coerce.c.
All the other fields of the constant are being extracted from the syscache
entry we already have, so handle collation similarly. (There don't seem
to be any other uses for the new function at the moment.)
Robert Haas [Fri, 8 Apr 2011 19:52:49 +0000 (15:52 -0400)]
Make psql use pg_table_size instead of pg_relation_size on 9.0+ servers.
Per discussion, pg_table_size() is a more helpful number than
pg_relation_size().
Bernd Helmle, reviewed by Susanne Ebrecht and me.
Robert Haas [Fri, 8 Apr 2011 19:44:50 +0000 (15:44 -0400)]
Fix bug in propagating ALTER TABLE actions to typed tables.
We need to propagate such actions to all typed table children of a
given type, not just the first one.
Noah Misch
Tom Lane [Fri, 8 Apr 2011 19:38:57 +0000 (15:38 -0400)]
Modify initdb to complain only when no usable system locales are found.
Per discussion, the original behavior seems too noisy. But if things
are so broken that none of the locales reported by "locale -a" are usable,
that's probably worth warning about.
Robert Haas [Fri, 8 Apr 2011 19:29:02 +0000 (15:29 -0400)]
Partially roll back overenthusiastic SSI optimization.
When a regular lock is held, SSI can use that in lieu of a predicate lock
to detect rw conflicts; but if the regular lock is being taken by a
subtransaction, we can't assume that it'll commit, so releasing the
parent transaction's lock in that case is a no-no.
Kevin Grittner
Bruce Momjian [Fri, 8 Apr 2011 15:46:34 +0000 (11:46 -0400)]
Have pg_upgrade properly preserve relfrozenxid in toast tables.
This fixes a pg_upgrade bug that could lead to query errors when clog
files are improperly removed.
Tom Lane [Fri, 8 Apr 2011 15:36:05 +0000 (11:36 -0400)]
Avoid extra whitespace in the arguments of <indexterm>.
As noted by Thom Brown, this confuses the DocBook index processor; it
fails to merge entries that differ only in whitespace, and sorts them
unexpectedly as well. Seems like a toolchain bug, but I'm not going to
hold my breath waiting for a fix.
Note: easiest way to find these is to look for double spaces in HTML.index.
Tom Lane [Fri, 8 Apr 2011 14:54:03 +0000 (10:54 -0400)]
Add an example of WITH (UPDATE RETURNING) INSERT to the INSERT ref page.
Per a discussion with Gavin Flower. This barely scratches the surface
of potential WITH (something RETURNING) use cases, of course, but it's
one of the simplest compelling examples I can think of.
Robert Haas [Fri, 8 Apr 2011 04:30:54 +0000 (00:30 -0400)]
Fix some sloppiness in new PL/python get_source_line() function.
Jan Urbański
Andrew Dunstan [Fri, 8 Apr 2011 02:17:06 +0000 (22:17 -0400)]
Avoid use of mixed slash style paths in arguments to xcopy in MSVC builds.
Some versions of xcopy, notably on Windows 7 don't like it. Backpatch
to 8.3, where we first used xcopy.
Robert Haas [Thu, 7 Apr 2011 20:43:39 +0000 (16:43 -0400)]
Tweaks for SSI out-of-shared memory behavior.
If we call hash_search() with HASH_ENTER, it will bail out rather than
return NULL, so it's redundant to check for NULL again in the caller.
Thus, in cases where we believe it's impossible for the hash table to run
out of slots anyway, we can simplify the code slightly.
On the flip side, in cases where it's theoretically possible to run out of
space, we don't want to rely on dynahash.c to throw an error; instead,
we pass HASH_ENTER_NULL and throw the error ourselves if a NULL comes
back, so that we can provide a more descriptive error message.
Kevin Grittner
Tom Lane [Thu, 7 Apr 2011 19:14:39 +0000 (15:14 -0400)]
Modernize dlopen interface code for FreeBSD and OpenBSD.
Remove the hard-wired assumption that __mips__ (and only __mips__) lacks
dlopen in FreeBSD and OpenBSD. This assumption is outdated at least for
OpenBSD, as per report from an anonymous 9.1 tester. We can perfectly well
use HAVE_DLOPEN instead to decide which code to use.
Some other cosmetic adjustments to make freebsd.c, netbsd.c, and openbsd.c
exactly alike.
Peter Eisentraut [Thu, 7 Apr 2011 16:22:34 +0000 (19:22 +0300)]
Allow pg_upgrade with PGCLIENTENCODING set
This used to work, but since PGCLIENTENCODING is now a connection
option variable, pg_upgrade would prevent it.
Tom Lane [Thu, 7 Apr 2011 15:40:23 +0000 (11:40 -0400)]
Fix SortTocFromFile() to cope with lines that are too long for its buffer.
The original coding supposed that a dump TOC file could never contain lines
longer than 1K. The folly of that was exposed by a recent report from
Per-Olov Esgard. We only really need to see the first dozen or two bytes
of each line, since we're just trying to read off the numeric ID at the
start of the line; so there's no need for a particularly huge buffer.
What there is a need for is logic to not process continuation bufferloads.
Back-patch to all supported branches, since it's always been like this.
Bruce Momjian [Thu, 7 Apr 2011 13:57:09 +0000 (09:57 -0400)]
Preserve pg_largeobject_metadata.relfrozenxid in pg_upgrade.
This is needed only in 9.1 because only 9.0 had this and no one is
upgrading from a 9.0 beta to 9.0 anymore. We basically don't backpatch
9.0 beta fixes at this point.
Bruce Momjian [Thu, 7 Apr 2011 10:22:40 +0000 (06:22 -0400)]
Simplify structure of query used to gather database object information
in pg_upgrade.
Tom Lane [Thu, 7 Apr 2011 06:34:57 +0000 (02:34 -0400)]
Fix collations when we call transformWhereClause from outside the parser.
Previous patches took care of assorted places that call transformExpr from
outside the main parser, but I overlooked the fact that some places use
transformWhereClause as a shortcut for transformExpr + coerce_to_boolean.
In particular this broke collation-sensitive index WHERE clauses, as per
report from Thom Brown. Trigger WHEN and rule WHERE clauses too.
I'm not forcing initdb for this fix, but any affected indexes, triggers,
or rules will need to be dropped and recreated.
Tom Lane [Thu, 7 Apr 2011 04:11:01 +0000 (00:11 -0400)]
Revise the API for GUC variable assign hooks.
The previous functions of assign hooks are now split between check hooks
and assign hooks, where the former can fail but the latter shouldn't.
Aside from being conceptually clearer, this approach exposes the
"canonicalized" form of the variable value to guc.c without having to do
an actual assignment. And that lets us fix the problem recently noted by
Bernd Helmle that the auto-tune patch for wal_buffers resulted in bogus
log messages about "parameter "wal_buffers" cannot be changed without
restarting the server". There may be some speed advantage too, because
this design lets hook functions avoid re-parsing variable values when
restoring a previous state after a rollback (they can store a pre-parsed
representation of the value instead). This patch also resolves a
longstanding annoyance about custom error messages from variable assign
hooks: they should modify, not appear separately from, guc.c's own message
about "invalid parameter value".
Peter Eisentraut [Wed, 6 Apr 2011 20:19:00 +0000 (23:19 +0300)]
Update regression test files for PL/Python traceback patch
Peter Eisentraut [Wed, 6 Apr 2011 20:00:44 +0000 (23:00 +0300)]
Replace the confusing exit_nicely() by an atexit/on_exit hook
Peter Eisentraut [Wed, 6 Apr 2011 19:36:06 +0000 (22:36 +0300)]
Add traceback information to PL/Python errors
This mimics the traceback information the Python interpreter prints
with exceptions.
Jan Urbański
Peter Eisentraut [Tue, 5 Apr 2011 21:16:13 +0000 (00:16 +0300)]
Update key words table for 9.1
Robert Haas [Tue, 5 Apr 2011 19:16:59 +0000 (15:16 -0400)]
Repair some flakiness in CheckTargetForConflictsIn.
When we release and reacquire SerializableXactHashLock, we must recheck
whether an R/W conflict still needs to be flagged, because it could have
changed under us in the meantime. And when we release the partition
lock, we must re-walk the list of predicate locks from the beginning,
because our pointer could get invalidated under us.
Bug report #5952 by Yamamoto Takashi. Patch by Kevin Grittner.
Alvaro Herrera [Tue, 5 Apr 2011 18:06:06 +0000 (15:06 -0300)]
Change "Id" to "id" in some SGML tags
Gabriele Bartolini
Robert Haas [Tue, 5 Apr 2011 16:40:17 +0000 (12:40 -0400)]
Typo fixes.
Erik Rijkers
Robert Haas [Tue, 5 Apr 2011 13:35:43 +0000 (09:35 -0400)]
Add casts from int4 and int8 to numeric.
Joey Adams, per gripe from Ramanujam. Review by myself and Tom Lane.
Simon Riggs [Mon, 4 Apr 2011 22:23:13 +0000 (23:23 +0100)]
Avoid assuming there will be only 3 states for synchronous_commit.
Also avoid hardcoding the current default state by giving it the name
"on" and replace with a meaningful name that reflects its behaviour.
Coding only, no change in behaviour.
Simon Riggs [Mon, 4 Apr 2011 21:38:43 +0000 (22:38 +0100)]
Centralise release note items related to recovery and replication
Simon Riggs [Mon, 4 Apr 2011 21:36:09 +0000 (22:36 +0100)]
Update comments and credit doc proofreaders
Alvaro Herrera [Mon, 4 Apr 2011 20:42:42 +0000 (16:42 -0400)]
Update MSVC toolchain to match SGML entity uppercasing
Per Robert Haas
Robert Haas [Mon, 4 Apr 2011 20:13:01 +0000 (16:13 -0400)]
Merge synchronous_replication setting into synchronous_commit.
This means one less thing to configure when setting up synchronous
replication, and also avoids some ambiguity around what the behavior
should be when the settings of these variables conflict.
Fujii Masao, with additional hacking by me.
Alvaro Herrera [Mon, 4 Apr 2011 20:07:53 +0000 (16:07 -0400)]
Uppercase <!ENTITY> and <!DOCTYPE> tags in SGML source
This improves compatibility with external toolchains, such as those used
by some documentation translation tools.
Gabriele Bartolini
Robert Haas [Mon, 4 Apr 2011 17:25:42 +0000 (13:25 -0400)]
Add missing check on invocation of trusted procedures.
KaiGai Kohei
Robert Haas [Mon, 4 Apr 2011 17:20:18 +0000 (13:20 -0400)]
Include pid in pg_lock_status() results even for SIREAD locks.
Dan Ports
Alvaro Herrera [Mon, 4 Apr 2011 16:03:41 +0000 (12:03 -0400)]
Duplicate expansion of "direction" from FETCH's synopsis into MOVE
Robert Haas [Mon, 4 Apr 2011 01:52:47 +0000 (21:52 -0400)]
Rearrange "add column" logic to merge columns at exec time.
The previous coding set attinhcount too high in some cases, resulting in
an undumpable, undroppable column. Per bug #5856, reported by Naoya
Anzai. See also commit
31b6fc06d83c6de3644c8f2921eb7de0eb92fac3, which
fixes a similar bug in ALTER TABLE .. ADD CONSTRAINT.
Patch by Noah Misch.
Robert Haas [Sun, 3 Apr 2011 23:56:22 +0000 (19:56 -0400)]
Improve documentation on the range of the numeric data type.
Gianni Ciolli, reviewed by Noah Misch
Robert Haas [Sun, 3 Apr 2011 23:49:05 +0000 (19:49 -0400)]
Remove mention of using "man" from the tutorial.
This isn't applicable on Windows, and the internal link to the
psql documentation should be more than sufficient.
Susanne Ebrecht
Robert Haas [Sun, 3 Apr 2011 23:42:00 +0000 (19:42 -0400)]
Avoid possible hang during smart shutdown.
If a smart shutdown occurs just as a child is starting up, and the
child subsequently becomes a walsender, there is a race condition:
the postmaster might count the exstant backends, determine that there
is one normal backend, and wait for it to die off. Had the walsender
transition already occurred before the postmaster counted, it would
have proceeded with the shutdown.
To fix this, have each child that transforms into a walsender kick
the postmaster just after doing so, so that the state machine is
certain to advance.
Fujii Masao
Tom Lane [Sat, 2 Apr 2011 22:05:42 +0000 (18:05 -0400)]
Fix typo in PQconnectStartParams().
This would lead to leaking the PGconn structure after an error detected by
conninfo_array_parse(), as well as failing to return a useful error message
in such cases. Backpatch to 9.0 where the error was introduced.
Joseph Adams
Heikki Linnakangas [Sat, 2 Apr 2011 14:06:43 +0000 (17:06 +0300)]
Escape greater than and less than characters in docs.
Susanne Ebrecht and me
Magnus Hagander [Fri, 1 Apr 2011 17:58:36 +0000 (19:58 +0200)]
Avoid palloc before CurrentMemoryContext is set up on win32
Instead, write the unconverted output - it will be in the wrong
encoding, but at least we don't crash.
Rushabh Lathia
Robert Haas [Fri, 1 Apr 2011 17:15:49 +0000 (13:15 -0400)]
Tab completion for COMMENT ON FOREIGN DATA WRAPPER / SERVER.
Robert Haas [Fri, 1 Apr 2011 15:40:37 +0000 (11:40 -0400)]
pg_dump support for comments on FOREIGN DATA WRAPPER and SERVER objects.
Shigeru Hanada, with some corrections.
Robert Haas [Fri, 1 Apr 2011 15:28:28 +0000 (11:28 -0400)]
Support comments on FOREIGN DATA WRAPPER and SERVER objects.
This mostly involves making it work with the objectaddress.c framework,
which does most of the heavy lifting. In that vein, change
GetForeignDataWrapperOidByName to get_foreign_data_wrapper_oid and
GetForeignServerOidByName to get_foreign_server_oid, to match the
pattern we use for other object types.
Robert Haas and Shigeru Hanada
Robert Haas [Fri, 1 Apr 2011 14:35:52 +0000 (10:35 -0400)]
Fix compiler warning.
Heikki Linnakangas [Fri, 1 Apr 2011 11:41:39 +0000 (14:41 +0300)]
Fix two missing spaces in error messages.
Josh Kupershmidt
Heikki Linnakangas [Thu, 31 Mar 2011 15:43:23 +0000 (18:43 +0300)]
Fix a tiny race condition in predicate locking. Need to hold the lock while
examining the head of predicate locks list. Also, fix the comment of
RemoveTargetIfNoLongerUsed, it was neglected when we changed the way update
chains are handled.
Kevin Grittner
Heikki Linnakangas [Thu, 31 Mar 2011 10:37:01 +0000 (13:37 +0300)]
Increase SHMEM_INDEX_SIZE from 32 to 64. We're currently at 40 entries in
ShmemIndex, so 64 leaves some headroom.
Kevin Grittner
Heikki Linnakangas [Thu, 31 Mar 2011 09:37:11 +0000 (12:37 +0300)]
Don't leak the temporary PLyProcedure struct we create for inline plpython
blocks.
Investigation by Jan Urbański, though I didn't use his patch.
Heikki Linnakangas [Thu, 31 Mar 2011 07:19:29 +0000 (10:19 +0300)]
Reword the phrase on zero replication_timeout in the docs.
Heikki Linnakangas [Thu, 31 Mar 2011 07:09:49 +0000 (10:09 +0300)]
Improve error message when WAL ends before reaching end of online backup.
Bruce Momjian [Wed, 30 Mar 2011 21:45:54 +0000 (17:45 -0400)]
Mention pg_upgrade sets autovacuum_freeze_max_age to maximum.
Bruce Momjian [Wed, 30 Mar 2011 21:36:24 +0000 (17:36 -0400)]
Expand comment on how pg_upgrade is turning off autovacuum.
Andrew Dunstan [Wed, 30 Mar 2011 20:43:31 +0000 (16:43 -0400)]
Attempt to unbreak windows builds broken by commit
754baa2.
Heikki Linnakangas [Wed, 30 Mar 2011 07:36:58 +0000 (10:36 +0300)]
Check that we've reached end-of-backup also when we're not performing
archive recovery.
It's possible to restore an online backup without recovery.conf, by simply
copying all the necessary WAL files to pg_xlog. "pg_basebackup -x" does that
too. That's the use case where this cross-check is useful.
Backpatch to 9.0. We used to do this in earlier versins, but in 9.0 the code
was inadvertently changed so that the check is only performed after archive
recovery.
Fujii Masao.
Heikki Linnakangas [Wed, 30 Mar 2011 07:10:32 +0000 (10:10 +0300)]
Automatically terminate replication connections that are idle for more
than replication_timeout (a new GUC) milliseconds. The TCP timeout is often
too long, you want the master to notice a dead connection much sooner.
People complained about that in 9.0 too, but with synchronous replication
it's even more important to notice dead connections promptly.
Fujii Masao and Heikki Linnakangas
Heikki Linnakangas [Wed, 30 Mar 2011 05:54:28 +0000 (08:54 +0300)]
Adjust error message, now that we expect other message types than connection
close at this point. Fix PQsetnonblocking() comment.
Fujii Masao
Peter Eisentraut [Tue, 29 Mar 2011 20:23:50 +0000 (23:23 +0300)]
Update SQL features list
Feature F692 "Extended collation support" is now also supported. This
refers to allowing the COLLATE clause anywhere in a column or domain
definition instead of just directly after the type.
Also correct the name of the feature in accordance with the latest SQL
standard.
Bruce Momjian [Tue, 29 Mar 2011 15:11:12 +0000 (11:11 -0400)]
In pg_upgrade, add C comment about how autovacuum is disabled.
Peter Eisentraut [Mon, 28 Mar 2011 19:53:55 +0000 (22:53 +0300)]
Add maintainer-check target
This can do various source code checks that are not appropriate for
either the build or the regression tests. Currently: duplicate_oids,
SGML syntax and tabs check, NLS syntax check.
Peter Eisentraut [Mon, 28 Mar 2011 19:52:23 +0000 (22:52 +0300)]
Make duplicate_oids return nonzero exit status if duplicates were found
Automatic detection of errors is easier that way.
Tom Lane [Mon, 28 Mar 2011 19:44:54 +0000 (15:44 -0400)]
Prevent a rowtype from being included in itself.
Eventually we might be able to allow that, but it's not clear how many
places need to be fixed to prevent infinite recursion when there's a direct
or indirect inclusion of a rowtype in itself. One such place is
CheckAttributeType(), which will recurse to stack overflow in cases such as
those exhibited in bug #5950 from Alex Perepelica. If we were sure it was
the only such place, we could easily modify the code added by this patch to
stop the recursion without a complaint ... but it probably isn't the only
such place. Hence, throw error until such time as someone is excited
enough about this type of usage to put work into making it safe.
Back-patch as far as 8.3. 8.2 doesn't have the recursive call in
CheckAttributeType in the first place, so I see no need to add code there
in the absence of clear evidence of a problem elsewhere.
Bruce Momjian [Mon, 28 Mar 2011 18:50:08 +0000 (14:50 -0400)]
Add 9.1 release note link for synchronous replication.
We already had links to the GUC variables that control it.
Robert Haas [Mon, 28 Mar 2011 13:42:09 +0000 (09:42 -0400)]
Mark up release notes using <link>.
Unlike <xref>, this actually works.
Alvaro Herrera [Sat, 26 Mar 2011 03:09:17 +0000 (00:09 -0300)]
Add missing #include
Tom Lane [Mon, 28 Mar 2011 13:34:56 +0000 (09:34 -0400)]
Get rid of links that don't work when building HISTORY.
Robert Haas [Mon, 28 Mar 2011 01:35:15 +0000 (21:35 -0400)]
Typo fix in SSI docs.
Kevin Grittner
Robert Haas [Mon, 28 Mar 2011 01:28:15 +0000 (21:28 -0400)]
Correct "characters" to "bytes" in createdb docs.
Susanne Ebrecht
Greg Stark [Sun, 27 Mar 2011 20:31:41 +0000 (21:31 +0100)]
fix up a couple non-prototypes of the form foo() to be foo(void) -- found using -Wstrict-prototypes
Tom Lane [Sun, 27 Mar 2011 17:29:52 +0000 (13:29 -0400)]
Fix check_exclusion_constraint() to insert correct collations in ScanKeys.
Tom Lane [Sun, 27 Mar 2011 16:51:04 +0000 (12:51 -0400)]
Fix plpgsql to release SPI plans when a function or DO block is freed.
This fixes the gripe I made a few months ago about DO blocks getting
slower with repeated use. At least, it fixes it for the case where
the DO block isn't aborted by an error. We could try running
plpgsql_free_function_memory() even during error exit, but that seems
a bit scary since it makes a lot of presumptions about the data
structures being in good shape. It's probably reasonable to assume
that repeated failures of DO blocks isn't a performance-critical case.