OSDN Git Service

android-x86/hardware-interfaces.git
7 years agoMerge "graphics: set maxThreads to 4 for the composer" into oc-dev
Chia-I Wu [Fri, 12 May 2017 19:59:18 +0000 (19:59 +0000)]
Merge "graphics: set maxThreads to 4 for the composer" into oc-dev
am: 15e33c6d17

Change-Id: I4e5c759f467d6085e9dc1d57ca65db0273343eef

7 years agoMerge "graphics: set maxThreads to 4 for the composer" into oc-dev
Chia-I Wu [Fri, 12 May 2017 19:50:55 +0000 (19:50 +0000)]
Merge "graphics: set maxThreads to 4 for the composer" into oc-dev

7 years agoMerge "Bluetooth: Add a second thread for the scheduler" am: 2709c56ad5 am: 31f6040908
Myles Watson [Fri, 12 May 2017 18:15:30 +0000 (18:15 +0000)]
Merge "Bluetooth: Add a second thread for the scheduler" am: 2709c56ad5 am: 31f6040908
am: f56e2909f9

Change-Id: Icd6191fb8f079126c1a4991683d9ee6b1015f18c

7 years agoMerge "Bluetooth: Add a second thread for the scheduler" am: 2709c56ad5
Myles Watson [Fri, 12 May 2017 18:10:27 +0000 (18:10 +0000)]
Merge "Bluetooth: Add a second thread for the scheduler" am: 2709c56ad5
am: 31f6040908

Change-Id: I4fb1e8f7a8d011b4c1cb59245dce5c9d20a05b2d

7 years agoMerge "Bluetooth: Add a second thread for the scheduler"
Myles Watson [Fri, 12 May 2017 18:08:28 +0000 (18:08 +0000)]
Merge "Bluetooth: Add a second thread for the scheduler"
am: 2709c56ad5

Change-Id: I0375940ba054d6b12d00957e96e0de860625c273

7 years agoMerge "Bluetooth: Add a second thread for the scheduler"
Treehugger Robot [Fri, 12 May 2017 18:03:54 +0000 (18:03 +0000)]
Merge "Bluetooth: Add a second thread for the scheduler"

7 years agoBluetooth: Add a second thread for the scheduler
Myles Watson [Fri, 12 May 2017 18:01:57 +0000 (18:01 +0000)]
Bluetooth: Add a second thread for the scheduler
am: 33f36706d0

Change-Id: I4730416f799b0947690d4a4544be41bfed191afb

7 years agographics: set maxThreads to 4 for the composer
Chia-I Wu [Thu, 11 May 2017 22:20:10 +0000 (15:20 -0700)]
graphics: set maxThreads to 4 for the composer

There are implmentations that can dead lock when calling certain
functions in certain states.  It works fine before HIDL because
SurfaceFlinger calls those functions in another thread.  We allow
for 4 hwbinder threads in this commit to simulate how SurfaceFlinger
calls hwcomposer.

Bug: 38183197
Test: camera, videos, multi windows, screencap, screenrecord
Change-Id: Ie05b2ca349b8c1ed9a3ac962981434f2efee92d9

7 years agoMerge changes from topic 'audio-primary-hal-vts-fix' into oc-dev
Kevin Rocard [Fri, 12 May 2017 06:57:47 +0000 (06:57 +0000)]
Merge changes from topic 'audio-primary-hal-vts-fix' into oc-dev
am: 257c2f1a43

Change-Id: Ic8850d915b5672e7529f99e7d57845b2de44857a

7 years agoconfigstore: include types.h instead of ISurfaceFlingerConfigs.h am: 92c77bd6e7 am...
Jaesoo Lee [Fri, 12 May 2017 05:16:36 +0000 (05:16 +0000)]
configstore: include types.h instead of ISurfaceFlingerConfigs.h am: 92c77bd6e7 am: 4b1848247f
am: d21a105380

Change-Id: I1a674bd0827b0dccdb01fded168cf3122de81afa

7 years agoconfigstore: include types.h instead of ISurfaceFlingerConfigs.h am: 92c77bd6e7
Jaesoo Lee [Fri, 12 May 2017 05:12:35 +0000 (05:12 +0000)]
configstore: include types.h instead of ISurfaceFlingerConfigs.h am: 92c77bd6e7
am: 4b1848247f

Change-Id: I7563d66174d3fd5c6c7a35389bb5d5ed78c7ac3c

7 years agoconfigstore: include types.h instead of ISurfaceFlingerConfigs.h
Jaesoo Lee [Fri, 12 May 2017 05:10:34 +0000 (05:10 +0000)]
configstore: include types.h instead of ISurfaceFlingerConfigs.h
am: 92c77bd6e7

Change-Id: I2782872f927b8fa9a0cc1da877d0f1cac3680150

7 years agoBluetooth: Add a second thread for the scheduler
Myles Watson [Thu, 11 May 2017 23:39:59 +0000 (16:39 -0700)]
Bluetooth: Add a second thread for the scheduler

Test: service call bluetooth_manager 6 # (Stop Bluetooth)
      /data/nativetest64/VtsHalBluetoothV1_0TargetTest/\
          VtsHalBluetoothV1_0TargetTest
Bug: 3817826534461621
Change-Id: Ia8f6683ca47c9deac43d1047846caee5688f1eca
(cherry picked from commit 74c601361c5f2d68561b545b7b7a52a3916ba8e9)

7 years agoBluetooth: Add a second thread for the scheduler
Myles Watson [Thu, 11 May 2017 23:39:59 +0000 (16:39 -0700)]
Bluetooth: Add a second thread for the scheduler

Test: service call bluetooth_manager 6 # (Stop Bluetooth)
      /data/nativetest64/VtsHalBluetoothV1_0TargetTest/\
          VtsHalBluetoothV1_0TargetTest
Bug: 3817826534461621
Change-Id: Ia8f6683ca47c9deac43d1047846caee5688f1eca

7 years agoMerge changes from topic 'audio-primary-hal-vts-fix' into oc-dev
Kevin Rocard [Thu, 11 May 2017 22:34:39 +0000 (22:34 +0000)]
Merge changes from topic 'audio-primary-hal-vts-fix' into oc-dev

* changes:
  Audio HAL: A volume/gain outside of [0,1] is an error
  Audio HAL VTS: Log test unexpected behaviour
  Audio HAL VTS: Improve ASSERT of Result and Return
  Audio HAL VTS: stopped stream state getters may return INVALID_STATE
  Audio HAL VTS: setGain allow -0.0
  Audio HAL VTS: Some methods are optional
  Audio HAL VTS: GetPresentationPosition may return 0 on stop stream
  Audio HAL VTS: getDevice() == NONE => not supported
  Audio HAL VTS: Getter test assert logic was incorrect
  Audio HAL VTS: debugDump can only test for crash
  Audio HAL VTS: Sanitize prepareFor{Writing,Reading} input size
  Audio HAL VTS: refactor prepareFor{Reading,Writing}
  Audio HAL VTS: Sanitize setMode input
  Audio HAL VTS: Allow OK when setting a non existing parameter
  Audio HAL VTS: differentiate getParam success/failure/not_implemented
  Audio HAL VTS: Fix style on modified files

7 years agoMerge changes from topic 'fix-hidl-generate' into oc-dev
Steven Moreland [Thu, 11 May 2017 00:55:46 +0000 (00:55 +0000)]
Merge changes from topic 'fix-hidl-generate' into oc-dev
am: 4be51a8512  -s ours

Change-Id: I91054a4a0ffcf6ff117bd4b6c3dcc3a94e7231c2

7 years agoUpdate makefiles for c++-sources and c++-headers.
Steven Moreland [Thu, 11 May 2017 00:49:04 +0000 (00:49 +0000)]
Update makefiles for c++-sources and c++-headers.
am: 8716f3063e  -s ours

Change-Id: If3655769859781369e8cb8456f133e0c35636254

7 years agoUpdate makefiles for c++-sources and c++-headers. (2/2)
Steven Moreland [Thu, 11 May 2017 00:48:55 +0000 (00:48 +0000)]
Update makefiles for c++-sources and c++-headers. (2/2)
am: bc71124120

Change-Id: Icf36068a4d863a8520854c7a83e51f960c188e12

7 years agoMerge "Start processes that need real-time with CAP_SYS_NICE." into oc-dev
Martijn Coenen [Thu, 11 May 2017 00:47:30 +0000 (00:47 +0000)]
Merge "Start processes that need real-time with CAP_SYS_NICE." into oc-dev
am: 6c062f77c1

Change-Id: I921160390dc9f90e7872729194ed1d1240ce68b7

7 years agoconfigstore: include types.h instead of ISurfaceFlingerConfigs.h
Jaesoo Lee [Tue, 2 May 2017 06:15:14 +0000 (15:15 +0900)]
configstore: include types.h instead of ISurfaceFlingerConfigs.h

Utils.h does not need to include ISurfaceFlingerConfigs.h.

Bug: 37727469
Test: successfully built sailfish-userdebug
Change-Id: I6650020bfc3b265d871ca3244b8900c336f98419

7 years agoActually fix build breakage with cleanspec. am: 319b8292be am: b16a4d26d3
Steven Moreland [Wed, 10 May 2017 22:51:15 +0000 (22:51 +0000)]
Actually fix build breakage with cleanspec. am: 319b8292be am: b16a4d26d3
am: 6ad2f6c984

Change-Id: I09a208dcd24cf17d3171ed5d4f64282a2642dd56

7 years agoActually fix build breakage with cleanspec. am: 319b8292be
Steven Moreland [Wed, 10 May 2017 22:48:44 +0000 (22:48 +0000)]
Actually fix build breakage with cleanspec. am: 319b8292be
am: b16a4d26d3

Change-Id: I235f68723215a806317828b65d9b8905598b10eb

7 years agoActually fix build breakage with cleanspec.
Steven Moreland [Wed, 10 May 2017 22:47:14 +0000 (22:47 +0000)]
Actually fix build breakage with cleanspec.
am: 319b8292be

Change-Id: Ic9dcbf28c238b30eba296fedcdef08af049aef31

7 years agoActually fix build breakage with cleanspec.
Steven Moreland [Wed, 10 May 2017 22:32:32 +0000 (15:32 -0700)]
Actually fix build breakage with cleanspec.

OUT_DIR instead of OUT

Test: manual
Change-Id: I2e48c6f2f39ff2318517ff55cbfa6ca912c05021

7 years agoAdd CleanSpec to hardware/interfaces. am: e468cf8004 am: 7780055fd1
Steven Moreland [Wed, 10 May 2017 21:03:08 +0000 (21:03 +0000)]
Add CleanSpec to hardware/interfaces. am: e468cf8004 am: 7780055fd1
am: aae66d171a

Change-Id: Id1a1c32443e342915dd40147560bb1987d782f9d

7 years agoAdd CleanSpec to hardware/interfaces. am: e468cf8004
Steven Moreland [Wed, 10 May 2017 20:58:37 +0000 (20:58 +0000)]
Add CleanSpec to hardware/interfaces. am: e468cf8004
am: 7780055fd1

Change-Id: I5d5f2618fc6d18034439d3cb1c31290d825f1c2e

7 years agoAdd CleanSpec to hardware/interfaces.
Steven Moreland [Wed, 10 May 2017 20:55:36 +0000 (20:55 +0000)]
Add CleanSpec to hardware/interfaces.
am: e468cf8004

Change-Id: If1978c73a668dacaf8f3b2842a704c5b28d5135e

7 years agoAdd CleanSpec to hardware/interfaces.
Steven Moreland [Wed, 10 May 2017 20:37:21 +0000 (13:37 -0700)]
Add CleanSpec to hardware/interfaces.

Fixes build breakage from interface changing after -Lc++-sources
and -Lc++-headers was added to hidl-gen.

Test: wip
Change-Id: I9ee0a0e7b72f8f2a3253d205943a696c07129a64

7 years agoMerge changes from topic 'fix-hidl-generate' into oc-dev
Steven Moreland [Wed, 10 May 2017 20:02:38 +0000 (20:02 +0000)]
Merge changes from topic 'fix-hidl-generate' into oc-dev

* changes:
  Update makefiles for c++-sources and c++-headers.
  Update makefiles for c++-sources and c++-headers. (2/2)

7 years agoMerge "Start processes that need real-time with CAP_SYS_NICE." into oc-dev
Martijn Coenen [Wed, 10 May 2017 17:55:46 +0000 (17:55 +0000)]
Merge "Start processes that need real-time with CAP_SYS_NICE." into oc-dev

7 years agoUpdate makefiles for c++-sources and c++-headers.
Steven Moreland [Tue, 9 May 2017 21:34:19 +0000 (14:34 -0700)]
Update makefiles for c++-sources and c++-headers.

Test: pass
Bug: 38174080
Merged-In: I683455736eed35e6ced24e2763c2bdb5fb6c9601
Change-Id: I683455736eed35e6ced24e2763c2bdb5fb6c9601

7 years agoUpdate makefiles for c++-sources and c++-headers. (2/2)
Steven Moreland [Wed, 10 May 2017 02:51:19 +0000 (19:51 -0700)]
Update makefiles for c++-sources and c++-headers. (2/2)

Test: pass
Bug: 38174080
Change-Id: Icad451f9f9ad5f46412356a4171a8a1222f8e545

7 years agoUpdate makefiles for c++-sources and c++-headers. am: cb360c60d8 am: 4bd4e7fb3b
Steven Moreland [Wed, 10 May 2017 02:58:00 +0000 (02:58 +0000)]
Update makefiles for c++-sources and c++-headers. am: cb360c60d8 am: 4bd4e7fb3b
am: 127b116fe5

Change-Id: I3a2aa76acef0f0d1455bfad775e87e8089d357e8

7 years agoUpdate makefiles for c++-sources and c++-headers. am: cb360c60d8
Steven Moreland [Wed, 10 May 2017 02:52:52 +0000 (02:52 +0000)]
Update makefiles for c++-sources and c++-headers. am: cb360c60d8
am: 4bd4e7fb3b

Change-Id: Ief274574dda12a38f62f49953a88f612d5b3586c

7 years agoUpdate makefiles for c++-sources and c++-headers.
Steven Moreland [Wed, 10 May 2017 02:47:25 +0000 (02:47 +0000)]
Update makefiles for c++-sources and c++-headers.
am: cb360c60d8

Change-Id: If0f0c69fa29a8c1cbd0d5b4e53e386ef8b68757e

7 years agoMerge "Bugfix: Add HIDL_FETCH_IScheduleTest declaration" into oc-dev
PO HUNG CHEN [Wed, 10 May 2017 02:42:02 +0000 (02:42 +0000)]
Merge "Bugfix: Add HIDL_FETCH_IScheduleTest declaration" into oc-dev
am: c365952316

Change-Id: If6399162d868c7498ca6e4a5d9453b4425ab77cc

7 years agoMerge "Update IRadioResponse.hal documentation to fix failing VTS" into oc-dev
Sanket Padawe [Wed, 10 May 2017 02:41:46 +0000 (02:41 +0000)]
Merge "Update IRadioResponse.hal documentation to fix failing VTS" into oc-dev
am: 41ea816c9d

Change-Id: I3f9efd6422652efc967a9c8a5bda284f87a4a458

7 years agoMerge "Bugfix: Add HIDL_FETCH_IScheduleTest declaration" into oc-dev
PO HUNG CHEN [Wed, 10 May 2017 02:28:10 +0000 (02:28 +0000)]
Merge "Bugfix: Add HIDL_FETCH_IScheduleTest declaration" into oc-dev

7 years agoMerge "Update IRadioResponse.hal documentation to fix failing VTS" into oc-dev
Sanket Padawe [Wed, 10 May 2017 02:27:04 +0000 (02:27 +0000)]
Merge "Update IRadioResponse.hal documentation to fix failing VTS" into oc-dev

7 years agoUpdate IRadioResponse.hal documentation to fix failing VTS
Naina Nalluri [Fri, 5 May 2017 18:00:05 +0000 (11:00 -0700)]
Update IRadioResponse.hal documentation to fix failing VTS

update IRadioResponse.hal documentation with
nas/data error codes

Bug: 35671595
Test: Only doc update.
Change-Id: I5a106e05b487f7deecb208af6465e5ea5238b26e

7 years agoUpdate makefiles for c++-sources and c++-headers.
Steven Moreland [Tue, 9 May 2017 21:34:19 +0000 (14:34 -0700)]
Update makefiles for c++-sources and c++-headers.

Test: pass
Bug: 38174080
Change-Id: I683455736eed35e6ced24e2763c2bdb5fb6c9601

7 years agoCamera: Remove TODOs in interfaces
Eino-Ville Talvala [Tue, 9 May 2017 21:32:28 +0000 (21:32 +0000)]
Camera: Remove TODOs in interfaces
am: 71619beef7

Change-Id: I43e85210ab1972f8245376831f578816be4dea78

7 years agoMerge "Camera: Clean up TODOs that aren't going to be addressed." into oc-dev
Eino-Ville Talvala [Tue, 9 May 2017 21:32:10 +0000 (21:32 +0000)]
Merge "Camera: Clean up TODOs that aren't going to be addressed." into oc-dev
am: 0b3d86e05a

Change-Id: Ic0ca4e1eff6716466ef86bc6a660bc371da875d6

7 years agoMerge "Add DOOR_LOCK to default config." into oc-dev
Ram Periathiruvadi [Tue, 9 May 2017 21:31:44 +0000 (21:31 +0000)]
Merge "Add DOOR_LOCK to default config." into oc-dev
am: c63bdfbd74

Change-Id: I2386d09d237957da9f7ea146412b5a36cbf208a6

7 years agoCamera: Remove TODOs in interfaces
Eino-Ville Talvala [Tue, 9 May 2017 18:13:20 +0000 (11:13 -0700)]
Camera: Remove TODOs in interfaces

These are tracked elsewhere and won't be addresed for the initial
interface versions.

Update current.txt hashes; comment-only update

Test: Compiles
Bug: 34108979
Bug: 33269977
Bug: 33262893
Change-Id: I0c0521cf69649d871f64a67773ce822db2487044

7 years agoMerge "Camera: Clean up TODOs that aren't going to be addressed." into oc-dev
TreeHugger Robot [Tue, 9 May 2017 17:30:35 +0000 (17:30 +0000)]
Merge "Camera: Clean up TODOs that aren't going to be addressed." into oc-dev

7 years agoMerge "Add DOOR_LOCK to default config." into oc-dev
TreeHugger Robot [Tue, 9 May 2017 17:21:13 +0000 (17:21 +0000)]
Merge "Add DOOR_LOCK to default config." into oc-dev

7 years agoStart processes that need real-time with CAP_SYS_NICE.
Martijn Coenen [Tue, 9 May 2017 16:57:00 +0000 (09:57 -0700)]
Start processes that need real-time with CAP_SYS_NICE.

Bug: 37293077
Test: verified CAP_SYS_NICE granted in /proc/pid/status
Change-Id: If404450cbeb077d331b231bda1af2d6eae774b75

7 years agoAudio HAL: A volume/gain outside of [0,1] is an error
Kevin Rocard [Tue, 9 May 2017 00:08:11 +0000 (17:08 -0700)]
Audio HAL: A volume/gain outside of [0,1] is an error

Hals are supposed to received normalized volumes, between 0 and 1.
Previously volumes outside [0,1] were clamp to this range.
This clamping has the capability to hide bugs thus return an error if
such volume is received.

Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug: 36311550
Change-Id: Ia4880bdff6111cbcdae6a4ebee921eddae141ee4
Signed-off-by: Kevin Rocard <krocard@google.com>
7 years agoCamera: Clean up TODOs that aren't going to be addressed.
Eino-Ville Talvala [Mon, 8 May 2017 22:29:28 +0000 (15:29 -0700)]
Camera: Clean up TODOs that aren't going to be addressed.

These TODOs aren't in scope for the wrapper libraries.

Leave the few TODOs that have bugs tracking them, and the ones that
are from autogenerated metadata.

Test: Builds
Bug: 34108979
Change-Id: Ib28467a4fbcfaab4a0809334bc62eabb9290797a

7 years agoMerge "Revert "Set omx and configstore as optional."" into oc-dev
Yifan Hong [Mon, 8 May 2017 22:12:06 +0000 (22:12 +0000)]
Merge "Revert "Set omx and configstore as optional."" into oc-dev
am: b8e84d240f

Change-Id: Iaf5f7aacacd2eb72b1ba98e19f5fe7589580bdbd

7 years agoAudio HAL VTS: Log test unexpected behaviour
Kevin Rocard [Mon, 8 May 2017 18:53:07 +0000 (11:53 -0700)]
Audio HAL VTS: Log test unexpected behaviour

Some test output infos that are useful to understand how they run.
Unfortunately the xml report does not seem to be saved by VTS tradefed.
Thus output them in logcat.

Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug: 36311550
Change-Id: I9a2cc10160c3b1c8f81db0464efbc6b26600cadc
Signed-off-by: Kevin Rocard <krocard@google.com>
7 years agoAudio HAL VTS: Improve ASSERT of Result and Return
Kevin Rocard [Wed, 3 May 2017 02:21:58 +0000 (19:21 -0700)]
Audio HAL VTS: Improve ASSERT of Result and Return

Previously tests on Result and Return were using ASSERT_NO_FATAL_FAILURE
and helper methods.
This leaded to complex error messages were the error did not pointed to
the helper methods instead of the ASSERT_RESULT call.
Additionally SCOPE_TRACE messages are repeated
for each ASSERT_NO_FATAL_FAILURE level.

Use ::testing::AssertionResult to improve drastically the error messages.

Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug: 36311550
Change-Id: If705502546606d678df3f1966b0cd9f3ef8c2529
Signed-off-by: Kevin Rocard <krocard@google.com>
7 years agoAudio HAL VTS: stopped stream state getters may return INVALID_STATE
Kevin Rocard [Wed, 3 May 2017 17:57:06 +0000 (10:57 -0700)]
Audio HAL VTS: stopped stream state getters may return INVALID_STATE

A never started stream should have its render position and next write
timestamp at 0 or indicate that the state is invalid.

Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug: 36311550
Change-Id: I62e16066bb22101ee8f75154fc6c85a66be2f402
Signed-off-by: Kevin Rocard <krocard@google.com>
7 years agoAudio HAL VTS: setGain allow -0.0
Kevin Rocard [Wed, 3 May 2017 18:19:25 +0000 (11:19 -0700)]
Audio HAL VTS: setGain allow -0.0

Previously -0.0 was consider an invalid value as not in the range [0,1].
But it is quite difficult in C++ to differentiate -0.0 and 0.0 as -0.0 == 0.0
and such difference has no impact in practice.

Thus leave the implementation support or not -0.0.

Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug: 36311550
Change-Id: Ia0ebcb325f77adcf8471620f418da1cbe8995e36
Signed-off-by: Kevin Rocard <krocard@google.com>
7 years agoAudio HAL VTS: Some methods are optional
Kevin Rocard [Wed, 3 May 2017 18:16:05 +0000 (11:16 -0700)]
Audio HAL VTS: Some methods are optional

Although the method documentation does not say it,
some HIDL interface methods are optional.

Update the tests to allow NOT_SUPPORTED to be returned.

Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug: 36311550
Change-Id: If31acc2dbdb6d1d563910e85c99401c48f4f3f86
Signed-off-by: Kevin Rocard <krocard@google.com>
7 years agoAudio HAL VTS: GetPresentationPosition may return 0 on stop stream
Kevin Rocard [Wed, 3 May 2017 17:52:43 +0000 (10:52 -0700)]
Audio HAL VTS: GetPresentationPosition may return 0 on stop stream

GetPresentationPosition returns the last time a sample was written to
the hardware.
Calling it on a stop stream should return 0 sample written, but the
timestamps of that measure is of little importance.
Thus allow this timestamp to be 0 indicating that the measure was never
actually made.

Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug: 36311550
Change-Id: I3c33b60f98e8cbea269a7739cc1889af932dcff5
Signed-off-by: Kevin Rocard <krocard@google.com>
7 years agoAudio HAL VTS: getDevice() == NONE => not supported
Kevin Rocard [Wed, 3 May 2017 02:34:29 +0000 (19:34 -0700)]
Audio HAL VTS: getDevice() == NONE => not supported

getDevice does not return a Result, thus it can not return NOT_SUPPORTED.
Consider NONE as not supported.

Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug: 36311550
Change-Id: I3b6f7a1fbc1d1535faf549f5b031461cb39d1722
Signed-off-by: Kevin Rocard <krocard@google.com>
7 years agoAudio HAL VTS: Getter test assert logic was incorrect
Kevin Rocard [Wed, 3 May 2017 01:58:58 +0000 (18:58 -0700)]
Audio HAL VTS: Getter test assert logic was incorrect

Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug: 36311550
Change-Id: Iaf2d71829a15b12dcf56e825773c8a697896a264
Signed-off-by: Kevin Rocard <krocard@google.com>
7 years agoAudio HAL VTS: debugDump can only test for crash
Kevin Rocard [Wed, 3 May 2017 01:41:46 +0000 (18:41 -0700)]
Audio HAL VTS: debugDump can only test for crash

DebugDump does not return an error code, thus the implementation can not
return not implemented.

As a result, the test can not expect any output from the function.
Only test that the call does not crash and add a log if the function is
probably not implemented in the test.

Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug: 36311550
Change-Id: I2c18958bceb1eb638491f9afce9d8e8025ccd3ec
Signed-off-by: Kevin Rocard <krocard@google.com>
7 years agoAudio HAL VTS: Sanitize prepareFor{Writing,Reading} input size
Kevin Rocard [Wed, 3 May 2017 01:34:59 +0000 (18:34 -0700)]
Audio HAL VTS: Sanitize prepareFor{Writing,Reading} input size

Return an error if framesCount or frameSize are null to avoid a division
by zero when calculating the buffer size.

The message queues are allocated with a buffer size but if two big they will
assert not return an error.
Thus take some margin on the buffer size check.

Note that both function should be refactored as 99% identical.

Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug: 36311550
Change-Id: I0576e9016ef2e567c8d4e171c6237883d9865db9
Signed-off-by: Kevin Rocard <krocard@google.com>
7 years agoAudio HAL VTS: refactor prepareFor{Reading,Writing}
Kevin Rocard [Wed, 3 May 2017 01:31:24 +0000 (18:31 -0700)]
Audio HAL VTS: refactor prepareFor{Reading,Writing}

Those functions had lots of copy paste on errors and
the following patch will even add more error detections.
Refactor the hidl_cb call to avoid all duplication.
Note that both function should be refactored as 99% identical.

Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug: 36311550
Change-Id: I40d6926b4f9f5e3aba51e878f55fb013f4ca09c1
Signed-off-by: Kevin Rocard <krocard@google.com>
7 years agoAudio HAL VTS: Sanitize setMode input
Kevin Rocard [Wed, 3 May 2017 01:16:00 +0000 (18:16 -0700)]
Audio HAL VTS: Sanitize setMode input

Some values of AudioMode are exposed although implementation detail.
Make sure the client can not use them.

Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug: 36311550
Change-Id: If513c2a06efa8a92459f0af80c63232fc63302b0
Signed-off-by: Kevin Rocard <krocard@google.com>
7 years agoAudio HAL VTS: Allow OK when setting a non existing parameter
Kevin Rocard [Wed, 3 May 2017 17:43:21 +0000 (10:43 -0700)]
Audio HAL VTS: Allow OK when setting a non existing parameter

setHwAvSync and setParameters were implemented in the pre-hidl interface
as set_parameters.
Unfortunately set_parameters did not return an error if a key was not
implemented.

As most HIDL implementation will be a wrapper around the pre-hidl
interface, allow those functions to return OK on not implemented key.

Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug: 36311550
Change-Id: Icfcaa02b7d63e03375fddc90dc5a803754c1874f
Signed-off-by: Kevin Rocard <krocard@google.com>
7 years agoMerge "Revert "Set omx and configstore as optional."" into oc-dev
Yifan Hong [Mon, 8 May 2017 21:10:56 +0000 (21:10 +0000)]
Merge "Revert "Set omx and configstore as optional."" into oc-dev

7 years agoAudio HAL VTS: differentiate getParam success/failure/not_implemented
Kevin Rocard [Wed, 3 May 2017 00:38:34 +0000 (17:38 -0700)]
Audio HAL VTS: differentiate getParam success/failure/not_implemented

When sending parameters to the HAL (and some getters are implemented
with getParameters), the client expect a status consistent
with the other HIDL methods. Ie: not implemented or success and failure.

Unfortunately, the legacy get_parameter interface, which currently most
Audio HIDL implementation are a wrapper around, do not return such error
code.

Get parameters return a list of key values.
 - If a requested key does not return a key value pair, consider it not
   implemented
 - If a requested key returns a key not followed by a correct value,
   consider it a failure
 - otherwise it is a success

Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug: 36311550
Change-Id: Id6711e9c1974fe5a336b6de83a9b6d14f74437c9
Signed-off-by: Kevin Rocard <krocard@google.com>
7 years agoAudio HAL VTS: Fix style on modified files
Kevin Rocard [Fri, 5 May 2017 21:02:55 +0000 (14:02 -0700)]
Audio HAL VTS: Fix style on modified files

In order to avoid style inconsistency as well as non functional
modification in following patches,
fix the style of all files modified for the fix of the VTS tests.

Patch generated with:
$ clang-format -i --style file -- <file list>

Bug: 36311550
Test: compile
Change-Id: I53dbcdabf959a6100e34a2ee4d0f951d525049cb

7 years agoAdd DOOR_LOCK to default config.
Ram Periathiruvadi [Thu, 4 May 2017 18:06:17 +0000 (11:06 -0700)]
Add DOOR_LOCK to default config.

One of the triggers for Bluetooth Auto connect is a door unlock signal.
Adding it to the list of default supported properties.

Bug: b/37674555
Test: Auto connect triggers on adb shell dumpsys activity service
com.android.car inject-event zoned-boolean 0x16200b02 1 false

Change-Id: Icfed9ea57239cd2397f3e71dcfaccd767a2e9739
(cherry picked from commit e17a009d5de6601e0482cc5495aef16c562c6e30)

7 years agoMerge "Add GENERIC_FAILURE error checks for some Radio BTSAP Apis which are failing...
Shuo Qian [Mon, 8 May 2017 17:52:46 +0000 (17:52 +0000)]
Merge "Add GENERIC_FAILURE error checks for some Radio BTSAP Apis which are failing" into oc-dev
am: 79c636a4ff

Change-Id: I81fc971a9a36550c254999222bdc669dd234b558

7 years agoMerge "Add GENERIC_FAILURE error checks for some Radio BTSAP Apis which are failing...
Shuo Qian [Mon, 8 May 2017 17:49:17 +0000 (17:49 +0000)]
Merge "Add GENERIC_FAILURE error checks for some Radio BTSAP Apis which are failing" into oc-dev

7 years agoRemove unused lambda captures am: 5ca756ea1f am: 68f6e99613
Yi Kong [Mon, 8 May 2017 17:24:21 +0000 (17:24 +0000)]
Remove unused lambda captures am: 5ca756ea1f am: 68f6e99613
am: dcf35ca86e

Change-Id: I025a2f240cb6f4278bece0f1b3c91dbfcdffa0fc

7 years agoRemove unused lambda captures am: 5ca756ea1f
Yi Kong [Mon, 8 May 2017 17:21:17 +0000 (17:21 +0000)]
Remove unused lambda captures am: 5ca756ea1f
am: 68f6e99613

Change-Id: I4646c377fec898d104f13e260eb039b42f8cc31d

7 years agoRemove unused lambda captures
Yi Kong [Mon, 8 May 2017 17:17:45 +0000 (17:17 +0000)]
Remove unused lambda captures
am: 5ca756ea1f

Change-Id: Ia11bcc3b1f05b4582fa85856d1cdf94c41c23fdc

7 years agoBugfix: Add HIDL_FETCH_IScheduleTest declaration
Howard Chen [Mon, 8 May 2017 06:04:05 +0000 (14:04 +0800)]
Bugfix: Add HIDL_FETCH_IScheduleTest declaration

Fix the bug that makes the registerAsServer fails.
sp<IScheduleTest> server =
IScheduleTest::getService(serviceName, true);
status_t status = server->registerAsService(serviceName);

Bug:38099333
Test: oc-dev on pixel sailfish with a vts test case
  "libhwbinder_latency -i 1"
Change-Id: I892835a25ef7df56a6424da41c0fc477b3a532d8

7 years agoRevert "Set omx and configstore as optional."
Yifan Hong [Thu, 4 May 2017 22:33:12 +0000 (22:33 +0000)]
Revert "Set omx and configstore as optional."

Test: boots
Test: Youtube video works

Bug: 35356977
Fixes: 38001671

This reverts commit 49a6654ccf5675470b5f638a918a963cc446ee36.

Change-Id: I7b04aa62e248c7fae0307229d07ffa174109ff05

7 years agoAdd GENERIC_FAILURE error checks for some Radio BTSAP Apis which are
sqian [Fri, 5 May 2017 19:51:56 +0000 (12:51 -0700)]
Add GENERIC_FAILURE error checks for some Radio BTSAP Apis which are
failing

Test: Vts
Bug: 35671595
Change-Id: Ie2ca86437283ce2f8e4b5cad21454a8d201e53ad

7 years agoMerge "VTS: Fix IRadio.setAllowedCarriers and IRadio.nvResetConfig" into oc-dev
Jayachandran Chinnakkannu [Fri, 5 May 2017 22:29:14 +0000 (22:29 +0000)]
Merge "VTS: Fix IRadio.setAllowedCarriers and IRadio.nvResetConfig" into oc-dev
am: eca8d114bf

Change-Id: I33e926f4ecd0314b4554ca9d90104f8afda773eb

7 years agoMerge "VTS: Fix IRadio.setAllowedCarriers and IRadio.nvResetConfig" into oc-dev
Jayachandran Chinnakkannu [Fri, 5 May 2017 22:22:33 +0000 (22:22 +0000)]
Merge "VTS: Fix IRadio.setAllowedCarriers and IRadio.nvResetConfig" into oc-dev

7 years agoRemove unused lambda captures
Yi Kong [Fri, 5 May 2017 20:35:50 +0000 (13:35 -0700)]
Remove unused lambda captures

Test: build
Bug: 37752547
Change-Id: I339baf849c7aef97dd319377026564dedd0cc568

7 years agoRenamed enums in IGnssNavigationMessageCallback.hal from GNSS prefix to GPS prefix...
Yu Liu [Fri, 5 May 2017 20:22:03 +0000 (20:22 +0000)]
Renamed enums in IGnssNavigationMessageCallback.hal from GNSS prefix to GPS prefix; also made some comment fixes in IGnssMeasurementCallback.hal
am: 216b87090d

Change-Id: I4ac5a047e375280b51dc37498650017f44327689

7 years agoRenamed enums in IGnssNavigationMessageCallback.hal from GNSS prefix to
Yu Liu [Tue, 2 May 2017 18:33:20 +0000 (11:33 -0700)]
Renamed enums in IGnssNavigationMessageCallback.hal from GNSS prefix to
GPS prefix; also made some comment fixes in IGnssMeasurementCallback.hal

BUG: 37946308
Test: Existing tests still pass.

Change-Id: Ia29c3f3943f0373e18634ddeede2ff5eb8998050

7 years agoMerge "Expect SUCCESS for tdls vts tests" into oc-dev
Ningyuan Wang [Fri, 5 May 2017 17:43:42 +0000 (17:43 +0000)]
Merge "Expect SUCCESS for tdls vts tests" into oc-dev
am: 525e0ecb1a

Change-Id: Icdc6c2349baea024f5944d1ba04a914a6871dd7a

7 years agoMerge "Add missing application ID tag to AES/HMAC attestation calls" into oc-dev
Shawn Willden [Fri, 5 May 2017 17:43:22 +0000 (17:43 +0000)]
Merge "Add missing application ID tag to AES/HMAC attestation calls" into oc-dev
am: 585acc6778

Change-Id: I613bc59b8eeeed229131fcff32835e91d26adda6

7 years agoMerge "Expect SUCCESS for tdls vts tests" into oc-dev
Ningyuan Wang [Fri, 5 May 2017 17:34:36 +0000 (17:34 +0000)]
Merge "Expect SUCCESS for tdls vts tests" into oc-dev

7 years agoMerge "Add missing application ID tag to AES/HMAC attestation calls" into oc-dev
TreeHugger Robot [Fri, 5 May 2017 17:29:21 +0000 (17:29 +0000)]
Merge "Add missing application ID tag to AES/HMAC attestation calls" into oc-dev

7 years agoMerge "audiohal: Add diagnostics to investigate HAL call crashes" into oc-dev
Mikhail Naganov [Fri, 5 May 2017 00:08:46 +0000 (00:08 +0000)]
Merge "audiohal: Add diagnostics to investigate HAL call crashes" into oc-dev
am: 65f7dbc9a9

Change-Id: I1f0d90fa7705d2716dbd3358418706ccae8dccb9

7 years agoMerge "audiohal: Add diagnostics to investigate HAL call crashes" into oc-dev
TreeHugger Robot [Fri, 5 May 2017 00:02:39 +0000 (00:02 +0000)]
Merge "audiohal: Add diagnostics to investigate HAL call crashes" into oc-dev

7 years agoVTS: Fix IRadio.setAllowedCarriers and IRadio.nvResetConfig
Jayachandran C [Wed, 3 May 2017 07:42:51 +0000 (00:42 -0700)]
VTS: Fix IRadio.setAllowedCarriers and IRadio.nvResetConfig

1) IRadio.setAllowedCarriers
Fix IRadio.setAllowedCarriers to pass no restrictions.
Passing restrictions will block all other SIM cards until
a new IRadio.setAllowedCarriers with no restriction is
invoked. Even factory reset will not recover.

2) IRadio.nvResetConfig
IRadio.nvResetConfig with ResetNvType RELOAD causes radio restart.
All subsuquent scripts fail with cause RADIO_NOT_AVAILABLE.
Fix to use ResetNvType ERASE which does not restart the radio.

Test: VTS
Bug: 37946160

Change-Id: Ib671758414cc97e1a596358306f89eed13918c48

7 years agoMerge "Set omx and configstore as optional." into oc-dev
Yifan Hong [Thu, 4 May 2017 21:59:38 +0000 (21:59 +0000)]
Merge "Set omx and configstore as optional." into oc-dev
am: 17a0193835

Change-Id: I3115a2c2b21f740d991f8740dfb0414c48d075e8

7 years agoMerge "Set omx and configstore as optional." into oc-dev
Yifan Hong [Thu, 4 May 2017 21:53:14 +0000 (21:53 +0000)]
Merge "Set omx and configstore as optional." into oc-dev

7 years agoSet omx and configstore as optional.
Yifan Hong [Thu, 4 May 2017 21:30:59 +0000 (14:30 -0700)]
Set omx and configstore as optional.

To fix the build for new devices.

Bug: 36097717
Bug: 35356977

Test: on master, m system_compatibility_matrix.xml -j

Change-Id: Ie7a3da46930b3627f4eb6b77c3ba8e50fa2b21ed

7 years agoaudiohal: Add diagnostics to investigate HAL call crashes
Mikhail Naganov [Wed, 3 May 2017 19:08:22 +0000 (12:08 -0700)]
audiohal: Add diagnostics to investigate HAL call crashes

This is intended to clarify whether surprising zeroing out of HAL
control structures happens to a particular HAL module, or to any
HAL module at random.

Unfortunately, the crash itself can't be prevented as
audioflinger can't work around a HAL outage, and needs to be
restarted anyway.

Bug: 36225019
Test: verified that the logged string contains the information
Change-Id: I5843d89b4e5385b4ce269f72b5891ccb646daeba

7 years agoMerge "audiohal: Fix incorrect parameter handling in IDevicesFactory::openDevice...
Mikhail Naganov [Thu, 4 May 2017 21:34:06 +0000 (21:34 +0000)]
Merge "audiohal: Fix incorrect parameter handling in IDevicesFactory::openDevice" into oc-dev
am: f66f505bc6

Change-Id: Ie6a32e496f723413421bef285a4370ddef7214bc

7 years agoMerge "audiohal: Fix incorrect parameter handling in IDevicesFactory::openDevice...
TreeHugger Robot [Thu, 4 May 2017 21:26:25 +0000 (21:26 +0000)]
Merge "audiohal: Fix incorrect parameter handling in IDevicesFactory::openDevice" into oc-dev

7 years agoadd more hals to framework compatibility matrix
Yifan Hong [Thu, 4 May 2017 19:19:31 +0000 (19:19 +0000)]
add more hals to framework compatibility matrix
am: c6cba90b96

Change-Id: I6fc92d1938bb1394bf88d50ba1777256fde86f7c

7 years agoaudiohal: Fix incorrect parameter handling in IDevicesFactory::openDevice
Mikhail Naganov [Mon, 24 Apr 2017 16:29:22 +0000 (09:29 -0700)]
audiohal: Fix incorrect parameter handling in IDevicesFactory::openDevice

Check for possibly invalid values of IDevicesFactory::Device enum.

Bug: 37592306
Change-Id: I4a2300d3be9ab38e6c51ba8a3b5bbbb606a11c2b
Test: VTS
(cherry picked from commit 8c16d85122472ef01a9e023c9568968faac1aff8)

7 years agoadd more hals to framework compatibility matrix
Yifan Hong [Wed, 3 May 2017 19:13:48 +0000 (12:13 -0700)]
add more hals to framework compatibility matrix

Bug: 37321309

Test: marlin builds (PRODUCT_FULL_TREBLE=true)
Test: bullhead builds (PRODUCT_FULL_TREBLE=false)

Change-Id: Ib92183a0749d972d9e89f38e158d32080c8023c6

7 years agoMerge "Remove redundant dependencies." am: 8b4c1e4589 am: a2b80cf2ca
Steven Moreland [Wed, 3 May 2017 22:25:43 +0000 (22:25 +0000)]
Merge "Remove redundant dependencies." am: 8b4c1e4589 am: a2b80cf2ca
am: 32ed1e2578  -s ours

Change-Id: I36f61b9a0103b75aa168e0fa0564bc103ef5de58

7 years agoMerge "Remove redundant dependencies." am: 8b4c1e4589
Steven Moreland [Wed, 3 May 2017 22:23:13 +0000 (22:23 +0000)]
Merge "Remove redundant dependencies." am: 8b4c1e4589
am: a2b80cf2ca

Change-Id: I69b5f0365e0fe3fe4472f86b90457d57b817c584

7 years agoMerge "Remove redundant dependencies."
Steven Moreland [Wed, 3 May 2017 22:20:12 +0000 (22:20 +0000)]
Merge "Remove redundant dependencies."
am: 8b4c1e4589

Change-Id: Ia79f726d5b0230836c1e5fdcf2043ab6c3ba7c18