OSDN Git Service
David Majnemer [Mon, 6 Jan 2014 07:39:46 +0000 (07:39 +0000)]
MC: Fatally error if subtraction operand is bad
Instead of crashing, raise an error when a subtraction expression
involves an undefined symbol.
This fixes PR18375.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198590
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 6 Jan 2014 06:57:27 +0000 (06:57 +0000)]
The rest of r198588. Remove SegOvrBits from X86 TSFlags since they weren't being used.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198589
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 6 Jan 2014 06:51:58 +0000 (06:51 +0000)]
Remove SegOvrBits from X86 TSFlags since they weren't being used.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198588
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 6 Jan 2014 06:09:03 +0000 (06:09 +0000)]
Remove argument to fix build bot failure.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198587
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 6 Jan 2014 06:02:58 +0000 (06:02 +0000)]
Add OpSize16 bit, for instructions which need 0x66 prefix in 16-bit mode
The 0x66 prefix toggles between 16-bit and 32-bit addressing mode.
So in 32-bit mode it is used to switch to 16-bit addressing mode for the
following instruction, while in 16-bit mode it's the other way round — it's
used to switch to 32-bit mode instead.
Thus, emit the 0x66 prefix byte for OpSize only in 32-bit (and 64-bit) mode,
and introduce a new OpSize16 bit which is used in 16-bit mode instead.
This is just the basic infrastructure for that change; a subsequent patch
will add the new OpSize16 bit to the 32-bit instructions that need it.
Patch from David Woodhouse.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198586
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Mon, 6 Jan 2014 06:00:00 +0000 (06:00 +0000)]
Remove unnecessary #includes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198585
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Mon, 6 Jan 2014 04:55:54 +0000 (04:55 +0000)]
[x86] Add basic support for .code16
This is not really expected to work right yet. Mostly because we will
still emit the OpSize (0x66) prefix in all the wrong places, along with
a number of other corner cases. Those will all be fixed in the subsequent
commits.
Patch from David Woodhouse.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198584
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Mon, 6 Jan 2014 04:14:03 +0000 (04:14 +0000)]
Support: add reference for ARM EHABI
Add a reference to the ARM EHABI Specification as a follow up to SVN r198576
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198583
91177308-0d34-0410-b5e6-
96231b3b80d8
Kevin Qin [Mon, 6 Jan 2014 02:26:10 +0000 (02:26 +0000)]
[AArch64 NEON] Fix invalid constant used in vselect condition.
There is a wrong assumption that the vector element type and the
type of each ConstantSDNode in the build_vector were the same.
However, when promoting the integer operand of a legally typed
build_vector, the operand type and the vector element type do not
need to be the same
(See method 'DAGTypeLegalizer::PromoteIntOp_BUILD_VECTOR' in
LegalizeIntegerTypes.cpp).
in AArch64 backend, the following dag sequence:
C0: i1 = Constant<0>
C1: i1 = Constant<-1>
V: v8i1 = BUILD_VECTOR C1, C1, C0, C0, C0, C0, C0, C0
is type-legalized into:
NewC0: i32 = Constant<0>
NewC1: i32 = Constant<1>
V: v8i8 = BUILD_VECTOR NewC1, NewC1, NewC0, NewC0, NewC0, NewC0, NewC0, NewC0
Forcing a getZeroExtend to VTBits to ensure that the new constant
is correctly.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198582
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Mon, 6 Jan 2014 01:22:54 +0000 (01:22 +0000)]
[Sparc] Add ELF Object Writer for Sparc.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198580
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Mon, 6 Jan 2014 00:43:20 +0000 (00:43 +0000)]
Refactor function that checks that __builtin_returnaddress's argument is constant.
This moves the check up into the parent class so that all targets can use it
without having to copy (and keep in sync) the same error message.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198579
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Mon, 6 Jan 2014 00:43:09 +0000 (00:43 +0000)]
Remove a failing test to get the buildbots back to green.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198578
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Mon, 6 Jan 2014 00:43:04 +0000 (00:43 +0000)]
Try to fix s390x build bot.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198577
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Mon, 6 Jan 2014 00:15:00 +0000 (00:15 +0000)]
ARM: move ARMUnwindOp.h into Support
Move the ARM EHABI unwind opcode definitions from the ARM MCTargetDesc into LLVM
Support. This enables sharing of the definitions across the ARM target code as
well as llvm-readobj. This will allow implementation of the unwind decoding in
llvm-readobj.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198576
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sun, 5 Jan 2014 20:26:05 +0000 (20:26 +0000)]
SPARC: Make helper function static.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198567
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 5 Jan 2014 19:40:56 +0000 (19:40 +0000)]
Fix ModR/M byte output for 16-bit addressing modes (PR18220)
Add some tests to validate correct register selection, including a fix
to an existing test which was requiring the *wrong* output.
Patch from David Woodhouse.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198566
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sun, 5 Jan 2014 19:25:57 +0000 (19:25 +0000)]
ELF relocation types for sparc.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198565
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 5 Jan 2014 19:25:13 +0000 (19:25 +0000)]
Remove opcode from MOV32r0 that I accidentally left when I converted it to Pseudo. Remove FIXME as well.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198564
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Sun, 5 Jan 2014 16:36:37 +0000 (16:36 +0000)]
ARM: style changes to LDRD, STRD definition
Fix indentation, name registers similar to ARM ARM.
No functionality change!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198563
91177308-0d34-0410-b5e6-
96231b3b80d8
Elena Demikhovsky [Sun, 5 Jan 2014 14:21:07 +0000 (14:21 +0000)]
AVX-512: changed property name from "neverHasSideEffects=1" to "hasSideEffects=0", added this property to VMOVSS/VMOVSD;
Optimized a truncate pattern.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198562
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Atanasyan [Sun, 5 Jan 2014 13:40:27 +0000 (13:40 +0000)]
[Mips] Add support for DT_MIPS_RLD_MAP and DT_MIPS_PLTGOT dynamic
section tags to the llvm-readobj.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198561
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Atanasyan [Sun, 5 Jan 2014 13:40:17 +0000 (13:40 +0000)]
[Mips] Rename the test case input file. No functional changes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198560
91177308-0d34-0410-b5e6-
96231b3b80d8
Elena Demikhovsky [Sun, 5 Jan 2014 10:46:09 +0000 (10:46 +0000)]
AVX-512: Added more intrinsics for convert and min/max.
Removed vzeroupper from AVX-512 mode - our optimization gude does not recommend to insert vzeroupper at all.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198557
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sun, 5 Jan 2014 10:38:52 +0000 (10:38 +0000)]
[PM] Add a definition for the static PassID in the CallGraphAnalysis.
Missed this when adding the skeleton analysis. Caught by a build break
in the next patch I'm working on when trying to use the analysis.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198556
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sun, 5 Jan 2014 09:14:53 +0000 (09:14 +0000)]
Add in a unittest for the one-use pattern matcher.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198552
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 5 Jan 2014 07:16:04 +0000 (07:16 +0000)]
Add the other form of movq xmm,xmm for the disassembler.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198551
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 5 Jan 2014 06:55:48 +0000 (06:55 +0000)]
Use patterns to remove some duplicate instructions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198550
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 5 Jan 2014 05:46:38 +0000 (05:46 +0000)]
Fix encoding for PUSH64i16. Add In64BitMode Predicate. Remove disassembler hack.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198547
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 5 Jan 2014 05:10:07 +0000 (05:10 +0000)]
Remove no longer needed x86 disassembler hack.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198546
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 5 Jan 2014 04:55:55 +0000 (04:55 +0000)]
Mark x86 _alt instructions as AsmParserOnly so they will be omitted from disassembler without string matches.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198545
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 5 Jan 2014 04:32:42 +0000 (04:32 +0000)]
Use new ForceDisassemble flag on the 2-byte forms of INC/DEC for 32-bit mode and remove disassmbler table emitter hack.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198544
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 5 Jan 2014 04:17:28 +0000 (04:17 +0000)]
Add a new x86 specific instruction flag to force some isCodeGenOnly instructions to go through to the disassembler tables without resorting to string matches. Apply flag to all _REV instructions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198543
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sun, 5 Jan 2014 03:28:29 +0000 (03:28 +0000)]
Add support to the pattern match library for matching NSW and NUW
instructions. I needed this for a quick experiment I was making, and
while I've no idea if that will ever get committed, I didn't want to
throw away the pattern match code and for anyone else to have to write
it again. I've added unittests to make sure this works correctly.
In fun news, this also uncovered the IRBuilder bug. Doh!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198541
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sun, 5 Jan 2014 03:22:33 +0000 (03:22 +0000)]
Fix a bug in IRBuilder that's been there for who knows how long. It
failed to correctly propagate the NUW and NSW flags to the constant
folder for two instructions. I've added a unittest to cover flag
propagation for the rest of the instructions and constant expressions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198538
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Sun, 5 Jan 2014 03:10:56 +0000 (03:10 +0000)]
Attempt to fix buildbots by XFAILing some architectures.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198537
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sun, 5 Jan 2014 03:07:04 +0000 (03:07 +0000)]
Add lit.local.cfg for MC/Sparc
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198536
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sun, 5 Jan 2014 02:23:11 +0000 (02:23 +0000)]
Use a shorter name for the IRBuilder member. This will help the tests
I'm adding next be a lot more readable.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198534
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sun, 5 Jan 2014 02:13:48 +0000 (02:13 +0000)]
[Sparc] Add initial implementation of MC Code emitter for sparc.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198533
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Sun, 5 Jan 2014 02:07:20 +0000 (02:07 +0000)]
Simplify the PatternMatch unittest by giving it a module, function, and
basic block to hold instructions, and managing all of their lifetimes in
a fixture. This makes it easy to sink the expectations into the test
cases themselves which also makes things a bit more explicit and clearer
IMO.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198532
91177308-0d34-0410-b5e6-
96231b3b80d8
Bill Wendling [Sun, 5 Jan 2014 01:47:20 +0000 (01:47 +0000)]
Emit an error message if the value passed to __builtin_returnaddress isn't a constant
__builtin_returnaddress requires that the value passed into is be a constant.
However, at -O0 even a constant expression may not be converted to a constant.
Emit an error message intead of crashing.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198531
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 5 Jan 2014 01:35:51 +0000 (01:35 +0000)]
Mark the 64-bit x86 push/pop instructions as In64BitMode. Mark the corresponding 32-bit versions with the same encodings Not64BitMode. Remove hack from tablegen disassembler table emitter. Fix bad test.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198530
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sun, 5 Jan 2014 01:34:12 +0000 (01:34 +0000)]
Don't use PrintFatalError(which calls exit) for 'Primary decode conflict'. Just skip emitting the table. This way the main function will delete the output file instead of it remaining empty and confusing dependency checks if build is invoked a second time.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198529
91177308-0d34-0410-b5e6-
96231b3b80d8
Nico Weber [Sun, 5 Jan 2014 00:37:45 +0000 (00:37 +0000)]
Add a FIXME.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198528
91177308-0d34-0410-b5e6-
96231b3b80d8
Alp Toker [Sat, 4 Jan 2014 22:47:48 +0000 (22:47 +0000)]
Add missed cleanup from r198456
All other uses of this macro in LLVM/clang have been moved to the function
definition so follow suite (and the usage advice) here too for consistency.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198516
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sat, 4 Jan 2014 22:29:41 +0000 (22:29 +0000)]
Tag x86 move to/from debug/control registers with Not64BitMode/In64BitMode. Remove disassembler hack.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198515
91177308-0d34-0410-b5e6-
96231b3b80d8
Alp Toker [Sat, 4 Jan 2014 17:00:45 +0000 (17:00 +0000)]
Revert "Fix PR18361: Invalidate LoopDispositions after LoopSimplify hoists things."
This commit was the source of crasher PR18384:
While deleting: label %for.cond127
An asserting value handle still pointed to this value!
UNREACHABLE executed at llvm/lib/IR/Value.cpp:671!
Reverting to get the builders green, feel free to re-land after fixing up.
(Renato has a handy isolated repro if you need it.)
This reverts commit r198478.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198503
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 4 Jan 2014 11:30:13 +0000 (11:30 +0000)]
[Sparc] Add the initial implementation of an asm parser for sparc/sparcv9.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198484
91177308-0d34-0410-b5e6-
96231b3b80d8
Venkatraman Govindaraju [Sat, 4 Jan 2014 07:17:21 +0000 (07:17 +0000)]
[SparcV9]: Implement RETURNADDR and FRAMEADDR lowering in SPARC64.
Fixes PR18356.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198480
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Sat, 4 Jan 2014 05:52:49 +0000 (05:52 +0000)]
Fix PR18361: Invalidate LoopDispositions after LoopSimplify hoists things.
getSCEV for an ashr instruction creates an intermediate zext
expression when it truncates its operand.
The operand is initially inside the loop, so the narrow zext
expression has a non-loop-invariant loop disposition.
LoopSimplify then runs on an outer loop, hoists the ashr operand, and
properly invalidate the SCEVs that are mapped to value.
The SCEV expression for the ashr is now an AddRec with the hoisted
value as the now loop-invariant start value.
The LoopDisposition of this wide value was properly invalidated during
LoopSimplify.
However, if we later get the ashr SCEV again, we again try to create
the intermediate zext expression. We get the same SCEV that we did
earlier, and it is still cached because it was never mapped to a
Value. When we try to create a new AddRec we abort because we're using
the old non-loop-invariant LoopDisposition.
I don't have a solution for this other than to clear LoopDisposition
when LoopSimplify hoists things.
I think the long-term strategy should be to perform LoopSimplify on
all loops before computing SCEV and before running any loop opts on
individual loops. It's possible we may want to rerun LoopSimplify on
individual loops, but it should rarely do anything, so rarely require
invalidating SCEV.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198478
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Sat, 4 Jan 2014 05:52:45 +0000 (05:52 +0000)]
whitespace
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198477
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Sat, 4 Jan 2014 05:09:27 +0000 (05:09 +0000)]
Remove JMP64pcrel32 (jmpq ). There are no tests for it. I'm pretty sure it won't be emitted correctly since it was set to NoImm. And I can't prove that gas accepts 'jmpq' with an immediate either. Remove the special case for it from the disassembler table generator.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198475
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Fri, 3 Jan 2014 23:51:09 +0000 (23:51 +0000)]
Fix MSVC warning about missing return in DataLayout
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198465
91177308-0d34-0410-b5e6-
96231b3b80d8
Nico Weber [Fri, 3 Jan 2014 22:53:37 +0000 (22:53 +0000)]
Add a LLVM_DUMP_METHOD macro.
The motivation is to mark dump methods as used in debug builds so that they can
be called from lldb, but to not do so in release builds so that they can be
dead-stripped.
There's lots of potential follow-up work suggested in the thread
"Should dump methods be LLVM_ATTRIBUTE_USED only in debug builds?" on cfe-dev,
but everyone seems to agreen on this subset.
Macro name chosen by fair coin toss.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198456
91177308-0d34-0410-b5e6-
96231b3b80d8
Jack Carter [Fri, 3 Jan 2014 22:18:43 +0000 (22:18 +0000)]
[Mips]Work around MIPS linker issues exposed by commit r198087 until bug 18360 is resolved
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198451
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Fri, 3 Jan 2014 21:49:09 +0000 (21:49 +0000)]
FileCheck: Print a nice error message for missing closing ']' in regex vars.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198449
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Fri, 3 Jan 2014 19:56:20 +0000 (19:56 +0000)]
Revert "For disassembly when adding a symbolic operand that is a C++ symbol name, also put the human readable name in a comment."
This reverts commit r198441.
This change doesn't build on Windows, and doesn't do the right thing on
Linux and other platforms that don't use a _Z prefix instead of __Z for
C++ names.
It also had no tests, so it wasn't clear how to fix it forward.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198445
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Fri, 3 Jan 2014 19:42:04 +0000 (19:42 +0000)]
Fix typo.
Thanks to Owen Anderson for noticing it.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198443
91177308-0d34-0410-b5e6-
96231b3b80d8
Kevin Enderby [Fri, 3 Jan 2014 19:33:09 +0000 (19:33 +0000)]
For disassembly when adding a symbolic operand that is a C++
symbol name, also put the human readable name in a comment.
Also fix a bug in LLVMDisasmInstruction() that was not flushing
the raw_svector_ostream for the disassembled instruction string
before copying it to the output buffer that was causing truncation
of the output.
rdar://
10173828
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198441
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Fri, 3 Jan 2014 19:21:54 +0000 (19:21 +0000)]
Make the llvm mangler depend only on DataLayout.
Before this patch any program that wanted to know the final symbol name of a
GlobalValue had to link with Target.
This patch implements a compromise solution where the mangler uses DataLayout.
This way, any tool that already links with Target (llc, clang) gets the exact
behavior as before and new IR files can be mangled without linking with Target.
With this patch the mangler is constructed with just a DataLayout and DataLayout
is extended to include the information the Mangler needs.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198438
91177308-0d34-0410-b5e6-
96231b3b80d8
Ana Pazos [Fri, 3 Jan 2014 19:20:31 +0000 (19:20 +0000)]
[AArch64][NEON] Added SXTL and SXTL2 instruction aliases
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198437
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 3 Jan 2014 18:59:42 +0000 (18:59 +0000)]
Revert "Revert "Debug Info: Type Units: Simplify type hashing using IR-provided unique names.""
This reverts commit r198398, thus reapplying r198397.
I had accidentally introduced an endianness issue when applying the hash
to the type unit. Using support::ulittle64_t in the reinterpret_cast in
addDwarfTypeUnitType fixes this issue.
Original commit message:
Debug Info: Type Units: Simplify type hashing using IR-provided unique
names.
What's good for LTO metadata size problems ought to be good for non-LTO
debug info size too, so let's rely on the same uniqueness in both cases.
If it's insufficient for non-LTO for whatever reason (since we now won't
be uniquing CU-local types or any C types - but these are likely to not
be the most significant contributors to type bloat) we should consider a
frontend solution that'll help both LTO and non-LTO alike, rather than
using DWARF-level DIE-hashing that only helps non-LTO debug info size.
It's also much simpler this way and benefits C++ even more since we can
deduplicate lexically separate definitions of the same C++ type since
they have the same mangled name.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198436
91177308-0d34-0410-b5e6-
96231b3b80d8
David Peixotto [Fri, 3 Jan 2014 17:20:01 +0000 (17:20 +0000)]
Fix loop rerolling pass failure with non-consant loop lower bound
The loop rerolling pass was failing with an assertion failure from a
failed cast on loops like this:
void foo(int *A, int *B, int m, int n) {
for (int i = m; i < n; i+=4) {
A[i+0] = B[i+0] * 4;
A[i+1] = B[i+1] * 4;
A[i+2] = B[i+2] * 4;
A[i+3] = B[i+3] * 4;
}
}
The code was casting the SCEV-expanded code for the new
induction variable to a phi-node. When the loop had a non-constant
lower bound, the SCEV expander would end the code expansion with an
add insted of a phi node and the cast would fail.
It looks like the cast to a phi node was only needed to get the
induction variable value coming from the backedge to compute the end
of loop condition. This patch changes the loop reroller to compare
the induction variable to the number of times the backedge is taken
instead of the iteration count of the loop. In other words, we stop
the loop when the current value of the induction variable ==
IterationCount-1. Previously, the comparison was comparing the
induction variable value from the next iteration == IterationCount.
This problem only seems to occur on 32-bit targets. For some reason,
the loop is not rerolled on 64-bit targets.
PR18290
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198425
91177308-0d34-0410-b5e6-
96231b3b80d8
Alp Toker [Fri, 3 Jan 2014 07:58:20 +0000 (07:58 +0000)]
MSVC 2010 build fix
Back out the part of r198399 that enabled LLVM_FINAL/LLVM_OVERRIDE on VS 2010.
DwarfUnit.h legitimately uses them on destructors which unfortunately triggers
Compiler Error C3665 (override specifier not allowed on a destructor/finalizer)
prior to MSVC 2012:
virtual ~DwarfCompileUnit() LLVM_OVERRIDE;
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198401
91177308-0d34-0410-b5e6-
96231b3b80d8
Arnold Schwaighofer [Fri, 3 Jan 2014 05:47:03 +0000 (05:47 +0000)]
BasicAA: Use reachabilty instead of dominance for checking value equality in phi
cycles
This allows the value equality check to work even if we don't have a dominator
tree. Also add some more comments.
I was worried about compile time impacts and did not implement reachability but
used the dominance check in the initial patch. The trade-off was that the
dominator tree was required.
The llvm utility function isPotentiallyReachable cuts off the recursive search
after 32 visits. Testing did not show any compile time regressions showing my
worries unjustfied.
No compile time or performance regressions at O3 -flto -mavx on test-suite +
externals.
Addresses review comments from r198290.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198400
91177308-0d34-0410-b5e6-
96231b3b80d8
Alp Toker [Fri, 3 Jan 2014 05:00:46 +0000 (05:00 +0000)]
Enable LLVM_FINAL, LLVM_OVERRIDE and LLVM_HAS_VARIADIC_TEMPLATES with more gcc and MSVC versions
The 'sealed' definition of LLVM_FINAL can be dropped once VS 2010 is
decommissioned.
Some of this is speculative so will keep an eye on the waterfall -- ping me if
you see failures.
Incremental work towards C++11 migration.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198399
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 3 Jan 2014 04:49:04 +0000 (04:49 +0000)]
Revert "Debug Info: Type Units: Simplify type hashing using IR-provided unique names."
Reverting due to bot failure I won't have time to investigate until
tomorrow.
This reverts commit r198397.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198398
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 3 Jan 2014 04:20:26 +0000 (04:20 +0000)]
Debug Info: Type Units: Simplify type hashing using IR-provided unique names.
What's good for LTO metadata size problems ought to be good for non-LTO
debug info size too, so let's rely on the same uniqueness in both cases.
If it's insufficient for non-LTO for whatever reason (since we now won't
be uniquing CU-local types or any C types - but these are likely to not
be the most significant contributors to type bloat) we should consider a
frontend solution that'll help both LTO and non-LTO alike, rather than
using DWARF-level DIE-hashing that only helps non-LTO debug info size.
It's also much simpler this way and benefits C++ even more since we can
deduplicate lexically separate definitions of the same C++ type since
they have the same mangled name.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198397
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Fri, 3 Jan 2014 02:17:35 +0000 (02:17 +0000)]
80-column.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198394
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Fri, 3 Jan 2014 02:16:44 +0000 (02:16 +0000)]
Remove TextSectionSym as it is unused.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198393
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 3 Jan 2014 01:30:05 +0000 (01:30 +0000)]
Revert "Reverting r193835 due to weirdness with Go..."
The cgo problem was that it wants dwarf2 which doesn't support direct
constant encoding of the location. So let's add support for dwarf2
encoding (using a location expression) of data member locations.
This reverts commit r198385.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198389
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 3 Jan 2014 00:48:38 +0000 (00:48 +0000)]
Reverting r193835 due to weirdness with Go...
Apologies for the noise - we're seeing some Go failures with cgo
interacting with Clang's debug info due to this change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198385
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 3 Jan 2014 00:00:41 +0000 (00:00 +0000)]
Fix break introduced in r198377 due to using a local type as a template parameter.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198379
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Thu, 2 Jan 2014 23:57:28 +0000 (23:57 +0000)]
Test coverage for non-default-constructible elements in a StringMap
This functionality was enabled by r198374. Here's a test to ensure it
works and we don't regress it.
Based on a patch by Maciej Piechotka.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198377
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Thu, 2 Jan 2014 23:28:39 +0000 (23:28 +0000)]
Remove StringMapEntryInitializer support.
It was never specialized so let's just remove that unused
configurability and always do the default.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198374
91177308-0d34-0410-b5e6-
96231b3b80d8
Quentin Colombet [Thu, 2 Jan 2014 22:47:22 +0000 (22:47 +0000)]
[RegAlloc] Make tryInstructionSplit less aggressive.
The greedy register allocator tries to split a live-range around each
instruction where it is used or defined to relax the constraints on the entire
live-range (this is a last chance split before falling back to spill).
The goal is to have a big live-range that is unconstrained (i.e., that can use
the largest legal register class) and several small local live-range that carry
the constraints implied by each instruction.
E.g.,
Let csti be the constraints on operation i.
V1=
op1 V1(cst1)
op2 V1(cst2)
V1 live-range is constrained on the intersection of cst1 and cst2.
tryInstructionSplit relaxes those constraints by aggressively splitting each
def/use point:
V1=
V2 = V1
V3 = V2
op1 V3(cst1)
V4 = V2
op2 V4(cst2)
Because of how the coalescer infrastructure works, each new variable (V3, V4)
that is alive at the same time as V1 (or its copy, here V2) interfere with V1.
Thus, we end up with an uncoalescable copy for each split point.
To make tryInstructionSplit less aggressive, we check if the split point
actually relaxes the constraints on the whole live-range. If it does not, we do
not insert it.
Indeed, it will not help the global allocation problem:
- V1 will have the same constraints.
- V1 will have the same interference + possibly the newly added split variable
VS.
- VS will produce an uncoalesceable copy if alive at the same time as V1.
<rdar://problem/
15570057>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198369
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Thu, 2 Jan 2014 22:09:39 +0000 (22:09 +0000)]
[PPC] Fix comment to match function name
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198362
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Thu, 2 Jan 2014 22:04:47 +0000 (22:04 +0000)]
Remove comments on CU skeleton construction, they're probably
obvious.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198361
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Thu, 2 Jan 2014 21:38:26 +0000 (21:38 +0000)]
[PPC] Fix the scheduling of CR logicals on the P7
CR logicals (crand, crxor, etc.) on the P7 need to be in the first slot of each
dispatch group. The old itinerary entry was just wrong (but has not mattered
because we don't generate these instructions).
This will matter when, in an upcoming commit, we start generating these
instructions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198359
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Thu, 2 Jan 2014 21:38:18 +0000 (21:38 +0000)]
Elaborate on comment for skeleton CU construction.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198358
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Thu, 2 Jan 2014 21:38:13 +0000 (21:38 +0000)]
Revert seemingly unnecessary section sym for the data section.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198357
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Thu, 2 Jan 2014 21:26:59 +0000 (21:26 +0000)]
[PPC] Use the correct immediate operands on 64-bit instructions
Several of the 64-bit fixed-point instructions with immediate operands were
using the 32-bit (i32) operand nodes instead of the corresponding 64-bit (i64)
operand definitions (u16imm instead of u16imm64, for example).
This error has had no effect so far, but would have caused type-checking
violations with an upcoming change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198356
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Thu, 2 Jan 2014 21:13:43 +0000 (21:13 +0000)]
Disable compare sinking in CodeGenPrepare when multiple condition registers are available
As noted in the comment above CodeGenPrepare::OptimizeInst, which aggressively
sinks compares to reduce pressure on the condition register(s), for targets
such as PowerPC with multiple condition registers, this may not be the right
thing to do. This adds an HasMultipleConditionRegisters boolean to TLI, and
CodeGenPrepare::OptimizeInst is skipped when HasMultipleConditionRegisters is
true.
This functionality will be used by the PowerPC backend in an upcoming commit.
Especially when the PowerPC backend starts tracking individual condition
register bits as separate allocatable entities (which will happen in this
upcoming commit), this sinking from CodeGenPrepare::OptimizeInst is
significantly suboptimial.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198354
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Thu, 2 Jan 2014 21:12:11 +0000 (21:12 +0000)]
indvars: cleanup the IV visitor. It does more than gather sext/zext info.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198353
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Thu, 2 Jan 2014 21:09:05 +0000 (21:09 +0000)]
Fix all the verifier tests I added for address spaces.
I originally had these using opt -verify, and I never removed the
-verify when converting them to use llvm-as instead, so these were
failing because of using the -verify argument which llvm-as doesn't have
instead of what it's actually supposed to be testing.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198352
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Thu, 2 Jan 2014 21:03:28 +0000 (21:03 +0000)]
Fix up a couple of review comments:
Use an if statement instead of a pair of ternary operators checking
the same condition.
Use a cheap method call rather than returning the local symbol.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198351
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Thu, 2 Jan 2014 21:03:22 +0000 (21:03 +0000)]
Simplify conditional.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198350
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Thu, 2 Jan 2014 20:55:01 +0000 (20:55 +0000)]
Allow addrspacecast in global aliases
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198349
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Thu, 2 Jan 2014 20:47:09 +0000 (20:47 +0000)]
[TableGen] Correctly generate implicit anonymous prototype defs in multiclasses
Even within a multiclass, we had been generating concrete implicit anonymous
defs when parsing values (generally in value lists). This behavior was
incorrect, and led to errors when multiclass parameters were used in the
parameter list of the implicit anonymous def.
If we had some multiclass:
multiclass mc<string n> {
... : SomeClass<SomeOtherClass<n> >
The capture of the multiclass parameter 'n' would not work correctly, and
depending on how the implicit SomeOtherClass was used, either TableGen would
ignore something it shouldn't, or would crash.
To fix this problem, when inside a multiclass, we generate prototype anonymous
defs for implicit anonymous defs (just as we do for explicit anonymous defs).
Within the multiclass, the current record prototype is populated with a node
that is essentially: !cast<SomeOtherClass>(!strconcat(NAME, anon_value_name)).
This is then resolved to the correct concrete anonymous def, in the usual way,
when NAME is resolved during multiclass instantiation.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198348
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Thu, 2 Jan 2014 20:47:05 +0000 (20:47 +0000)]
[TableGen] Handle ValueType in CodeGenDAGPatterns GetNumNodeResults
A ValueType in a pattern dag is a type cast, and GetNumNodeResults should
handle it (the type cast has only one result).
This comes up, for example, during the type checking of pattern fragments, for
example, AArch64's Neon_combine_2d fragment is:
dag Operands = (ops node:$Rm, node:$Rn);
dag Fragment = (v2f64 (concat_vectors (v1f64 node:$Rm), (v1f64 node:$Rn)));
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198347
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Thu, 2 Jan 2014 20:01:43 +0000 (20:01 +0000)]
Delete unread globals through addrspacecast
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198346
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Thu, 2 Jan 2014 19:53:49 +0000 (19:53 +0000)]
Fix addrspacecast with metadata globals
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198345
91177308-0d34-0410-b5e6-
96231b3b80d8
Jordan Rose [Thu, 2 Jan 2014 19:47:45 +0000 (19:47 +0000)]
[CMake] Add missing set_output_directory after Takumi's change in r198205.
Plugins need to go in build/Debug/lib as well (rather than build/lib/Debug).
Also, fix the SHLIBDIR path for Xcode, which by default includes Xcode build
settings rather than a simple %(build_mode)s parameter.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198344
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Thu, 2 Jan 2014 19:38:41 +0000 (19:38 +0000)]
Remove redundant fold call introduced in r195944. Thanks very much to Juergen
for pointing this out.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198341
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Thu, 2 Jan 2014 19:35:33 +0000 (19:35 +0000)]
[TableGen] Use the same anonymous name as the prefix on all multiclass defs
TableGen had been generating a different name for an anonymous multiclass's
NAME for every def in the multiclass. This had an unfortunate side effect: it
was impossible to reference one def within the multiclass from another (in the
parameter list, for example). By making sure we only generate an anonymous name
once per multiclass (which, as it turns out, requires only changing the name
parameter to reference type), we can now concatenate NAME within the multiclass
with a def name in order to generate a reference to that def.
This does not matter so much, in and of itself, but is necessary for a
follow-up commit that will fix variable capturing in implicit anonymous
multiclass defs (and that is important).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198340
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Thu, 2 Jan 2014 19:29:38 +0000 (19:29 +0000)]
indvars: insert truncate at loop boundary to avoid redundant IVs.
When widening an IV to remove s/zext, we generally try to eliminate
the original narrow IV. However, LCSSA phi nodes outside the loop were
still using the original IV. Clean this up more aggressively to avoid
redundancy in generated code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198338
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Thu, 2 Jan 2014 19:12:10 +0000 (19:12 +0000)]
Mark REX64_PREFIX as In64BitMode, remove hack from X86RecognizableInstr.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198336
91177308-0d34-0410-b5e6-
96231b3b80d8
Douglas Gregor [Thu, 2 Jan 2014 19:07:19 +0000 (19:07 +0000)]
CMake separate projects: use correct name for LIBRARY_OUTPUT_DIRECTORY_${suffix}.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198335
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Thu, 2 Jan 2014 19:04:59 +0000 (19:04 +0000)]
Make llvm::Regex non-copyable but movable.
Based on a patch by Maciej Piechotka.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198334
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Thu, 2 Jan 2014 18:48:24 +0000 (18:48 +0000)]
Revert "Debug info: Add enumerators to the __apple_names accelerator table."
This reverts r197927 until the discussion on llvm-commits comes to a
conclusion.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198333
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Thu, 2 Jan 2014 18:44:21 +0000 (18:44 +0000)]
Remove unused HasFROperands field from disassembler.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198332
91177308-0d34-0410-b5e6-
96231b3b80d8