OSDN Git Service

android-x86/system-bt.git
3 years agoReplace BT_HDR => BT_HDR_RIGID
Chris Manton [Sat, 6 Mar 2021 23:35:36 +0000 (15:35 -0800)]
Replace BT_HDR => BT_HDR_RIGID

Toward structurally sound code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: Ib6569c0c19c7f1e6f4b9e9c1abc27e30d1e33fbf

3 years agoRemove unused flags
Zach Johnson [Fri, 21 Aug 2020 17:43:01 +0000 (10:43 -0700)]
Remove unused flags

nobody needs this

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I1dc37a831f0faf92990ec5e83c2759dedce2551b

3 years agoshim: Const-ify helper translations
Chris Manton [Sun, 18 Apr 2021 06:23:04 +0000 (23:23 -0700)]
shim: Const-ify helper translations

Bug: 163134718
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I7e95481a762fce8afd3111c497784dc97d4eae13

3 years agolegacy: Remove unused var stack/hid/hidh_conn
Chris Manton [Sat, 17 Apr 2021 18:02:35 +0000 (11:02 -0700)]
legacy: Remove unused var stack/hid/hidh_conn

Toward meaningful code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I8837a66dcba4ab160fc152319b9eb71f27a61045

3 years agolegacy: Use stack/hid/hid_conn::tHID_CONN_STATE
Chris Manton [Sat, 17 Apr 2021 17:35:31 +0000 (10:35 -0700)]
legacy: Use stack/hid/hid_conn::tHID_CONN_STATE

Toward readable code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I8984eb536a7241758e5276bd26aaab4bd02b97ac

3 years agolegacy: Add stack/hid/hid_conn::hid_conn_state_text
Chris Manton [Sat, 17 Apr 2021 17:33:23 +0000 (10:33 -0700)]
legacy: Add stack/hid/hid_conn::hid_conn_state_text

Toward loggable code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I95495eb823cd4b01df96b48773ede6818d52b301

3 years agolegacy: Enum-ify stack/hid/hid_conn::tHID_CONN_STATE
Chris Manton [Sat, 17 Apr 2021 17:27:21 +0000 (10:27 -0700)]
legacy: Enum-ify stack/hid/hid_conn::tHID_CONN_STATE

Toward readable code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I2869eb18c858b724a34d234ea67c0246d494d5f7

3 years agoRemove useless typedefs
Chris Manton [Tue, 16 Mar 2021 00:14:29 +0000 (17:14 -0700)]
Remove useless typedefs

Toward meaningful code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I5d96ba04a4dea271488fc59b53558c775a315452

3 years agoRe-log btm_sec_connected
Chris Manton [Fri, 12 Mar 2021 01:27:24 +0000 (17:27 -0800)]
Re-log btm_sec_connected

Toward loggable code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: If38627c7034b88ddbd7306d9e9d0dc8c07f9ba9e

3 years agoRemove #def BTA_HH_DEBUG
Chris Manton [Tue, 16 Mar 2021 01:32:58 +0000 (18:32 -0700)]
Remove #def BTA_HH_DEBUG

Toward loggable code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: I3daf1d4bb8e7ec37828f6eb589b878215f769635

3 years agoRe-log acl_send_data_packet_br_edr
Chris Manton [Fri, 12 Mar 2021 01:27:38 +0000 (17:27 -0800)]
Re-log acl_send_data_packet_br_edr

Toward loggable code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: I0310f9e143fa1b1bec60efb113025000112d6fe6

3 years agoPoint BtmStatus to tBTM_STATUS
Chris Manton [Mon, 1 Mar 2021 18:33:43 +0000 (10:33 -0800)]
Point BtmStatus to tBTM_STATUS

Towards converging code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: Id2c30a0deb41bb6cd1dd55099c17924e80e88335

3 years agoAdd stack/include/btm_status helpers
Chris Manton [Mon, 1 Mar 2021 18:32:04 +0000 (10:32 -0800)]
Add stack/include/btm_status helpers

Toward reliable code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: If8a990740ea4446df2c9293d6f9342dc0e316f39

3 years agoMerge changes Iac5bc982,I90c66a3b,I4ed5973b,I5173b895,I28420a70, ...
Treehugger Robot [Tue, 20 Apr 2021 02:34:17 +0000 (02:34 +0000)]
Merge changes Iac5bc982,I90c66a3b,I4ed5973b,I5173b895,I28420a70, ...

* changes:
  legacy: Move BTM_SEC_ #defs to compilation unit
  legacy: Re-log stack/smp/smp_utils::smp_proc_pairing_cmpl
  legacy: Re-log stack/smp/smp_utils::smp_send_cmd
  legacy: Add stack/include/smp_api_types::smp_opcode_text
  legacy: Use proper types tSDP_STATUS
  shim: Add default for HCI_STATUS helper
  Use proper types tSDP_STATUS

3 years agolegacy: Move BTM_SEC_ #defs to compilation unit
Chris Manton [Fri, 16 Apr 2021 17:50:29 +0000 (10:50 -0700)]
legacy: Move BTM_SEC_ #defs to compilation unit

Toward modularized code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: Iac5bc9821127bc95d71384eb2a02555540ddb0dc

3 years agolegacy: Re-log stack/smp/smp_utils::smp_proc_pairing_cmpl
Chris Manton [Fri, 16 Apr 2021 17:13:33 +0000 (10:13 -0700)]
legacy: Re-log stack/smp/smp_utils::smp_proc_pairing_cmpl

Toward loggable code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I90c66a3b676d3ee4c694e0cb9751d1dbc53c34b3

3 years agolegacy: Re-log stack/smp/smp_utils::smp_send_cmd
Chris Manton [Fri, 16 Apr 2021 16:55:51 +0000 (09:55 -0700)]
legacy: Re-log stack/smp/smp_utils::smp_send_cmd

Toward loggable code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I4ed5973b81ad0691e7f85cca732650d0d5c2f225

3 years agolegacy: Add stack/include/smp_api_types::smp_opcode_text
Chris Manton [Fri, 16 Apr 2021 16:52:19 +0000 (09:52 -0700)]
legacy: Add stack/include/smp_api_types::smp_opcode_text

Toward loggable code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I5173b895f0dba0637a5985dbae6e94038fe65ff9

3 years agolegacy: Use proper types tSDP_STATUS
Chris Manton [Mon, 19 Apr 2021 02:32:53 +0000 (19:32 -0700)]
legacy: Use proper types tSDP_STATUS

Bug: 163134718
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I28420a70fca3eacdaf3a0e19ab2360324d26c317

3 years agoshim: Add default for HCI_STATUS helper
Chris Manton [Sun, 18 Apr 2021 16:34:58 +0000 (09:34 -0700)]
shim: Add default for HCI_STATUS helper

Bug: 185730737
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I1681f65cfb3aa3cdfe38a1de987bf0aaf62d6c99

3 years agoUse proper types tSDP_STATUS
Chris Manton [Tue, 16 Mar 2021 00:14:10 +0000 (17:14 -0700)]
Use proper types tSDP_STATUS

Toward readable code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: Ie8f28b14b00e791110ffc5367a81ca8bf4a1060d

3 years agoMerge "HCI: Warn on unhandled events"
Treehugger Robot [Mon, 19 Apr 2021 21:44:01 +0000 (21:44 +0000)]
Merge "HCI: Warn on unhandled events"

3 years agoshim: Wrap TRY_POSTING_ON_MAIN conditional
Chris Manton [Mon, 19 Apr 2021 00:41:52 +0000 (17:41 -0700)]
shim: Wrap TRY_POSTING_ON_MAIN conditional

Bug: 185633860
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I34afd1b42744f1357f4a5ea6624e343bd7f59ad1

3 years agoHCI: Warn on unhandled events
Myles Watson [Mon, 19 Apr 2021 19:09:05 +0000 (12:09 -0700)]
HCI: Warn on unhandled events

Bug: 185731391
Test: cert/run
Tag: #gd-refactor
Change-Id: I0d63c4c85ab49a0bee857d384dd5b0d27a8fe8fd

3 years agoMerge "Fix valid check for btm_process_remote_ext_features"
Jack He [Mon, 19 Apr 2021 18:42:57 +0000 (18:42 +0000)]
Merge "Fix valid check for btm_process_remote_ext_features"

3 years agoMerge "gd hci: Correct max_page_number for read remote feature complete"
Jack He [Mon, 19 Apr 2021 18:42:48 +0000 (18:42 +0000)]
Merge "gd hci: Correct max_page_number for read remote feature complete"

3 years agoFix valid check for btm_process_remote_ext_features
Chienyuan [Mon, 19 Apr 2021 10:10:53 +0000 (18:10 +0800)]
Fix valid check for btm_process_remote_ext_features

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: I690fb002de43c0998ad9003ca41ace4f3e8ea719

3 years agogd hci: Correct max_page_number for read remote feature complete
Chienyuan [Mon, 19 Apr 2021 08:38:38 +0000 (16:38 +0800)]
gd hci: Correct max_page_number for read remote feature complete

Tag: #gd-refactor
Bug: 183688717
Test: gd/cert/run
Change-Id: I2386fb48d06f164fb3660bbb04603713ec4a742e

3 years agoGD Storage: Call SaveDelayed on the right thread
Jack He [Sat, 17 Apr 2021 08:37:25 +0000 (01:37 -0700)]
GD Storage: Call SaveDelayed on the right thread

* To resolve a dedlock between StorageModule and ConfigCache

Fixes: 178976563
Bug: 178976563
Test: atest bluetooth_test_gd
Tag: #gd-refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I13a51931111eb3c0e1c999cd4b7f4fc30d9e1f13

3 years agoMerge changes Ic583e487,Ic589759c,Ibe9720b5,I3fc83d6d,I3cccdf77, ...
Chris Manton [Fri, 16 Apr 2021 21:21:11 +0000 (21:21 +0000)]
Merge changes Ic583e487,Ic589759c,Ibe9720b5,I3fc83d6d,I3cccdf77, ...

* changes:
  shim: Move disconnect classic/le into thread safe space
  shim: Add acl tests
  shim: Replace mock do_in_main_thread with a fake
  shim: Move dumpsys map off heap into static allocation
  shim: Clean up mock entry and add common header inclusion
  gd: Make address protected to set it for tests
  Untangle HCI_STATUS/BTM_STATUS bta/dm/bta_dm_act
  Enum-ify tSMP_STATUS

3 years agoshim: Move disconnect classic/le into thread safe space
Chris Manton [Thu, 15 Apr 2021 02:03:09 +0000 (19:03 -0700)]
shim: Move disconnect classic/le into thread safe space

Bug: 184604254
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: Ic583e4878a2d7428f3007303f9f030e9a78bd32f

3 years agoshim: Add acl tests
Chris Manton [Thu, 15 Apr 2021 02:06:04 +0000 (19:06 -0700)]
shim: Add acl tests

Bug: 184604254
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: Ic589759cec3190e99f0a1659985740f415569ab2

3 years agoshim: Replace mock do_in_main_thread with a fake
Chris Manton [Thu, 15 Apr 2021 20:54:20 +0000 (13:54 -0700)]
shim: Replace mock do_in_main_thread with a fake

Bug: 184604254
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: Ibe9720b5934806bca2d62055fc50dc20ecac927d

3 years agoshim: Move dumpsys map off heap into static allocation
Chris Manton [Thu, 15 Apr 2021 02:45:36 +0000 (19:45 -0700)]
shim: Move dumpsys map off heap into static allocation

Bug: 184604254
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I3fc83d6d0a3ef68c0fd5ed5d17249abd7d09f833

3 years agoshim: Clean up mock entry and add common header inclusion
Chris Manton [Wed, 14 Apr 2021 22:01:23 +0000 (15:01 -0700)]
shim: Clean up mock entry and add common header inclusion

Bug: 182544206
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I3cccdf773638134affefd1a7c143e4862c53f9e3

3 years agogd: Make address protected to set it for tests
Chris Manton [Thu, 15 Apr 2021 23:54:22 +0000 (16:54 -0700)]
gd: Make address protected to set it for tests

Bug: 184604254
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I36b30d48a453bbd27c804d319971061059c9a3cf

3 years agoUntangle HCI_STATUS/BTM_STATUS bta/dm/bta_dm_act
Chris Manton [Mon, 1 Mar 2021 18:33:19 +0000 (10:33 -0800)]
Untangle HCI_STATUS/BTM_STATUS bta/dm/bta_dm_act

Toward readable code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: Ib02cba5dd1a47085bb7842236a66e9c71384eada

3 years agoEnum-ify tSMP_STATUS
Chris Manton [Tue, 2 Mar 2021 17:59:07 +0000 (09:59 -0800)]
Enum-ify tSMP_STATUS

Toward readable code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: I613ee010fef7211edb51592efcc385f3999a7ba4

3 years agoBluetoothMetrics: Log classic pairing metrics from gd
Chen Chen [Mon, 12 Apr 2021 20:20:36 +0000 (13:20 -0700)]
BluetoothMetrics: Log classic pairing metrics from gd

Test: gd/cert/run
Manual test: build and run Bluetooth (connection, pairing, music and phone call)
Bug: 181819141
Tag: #gd-refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: Ie2bb98151c9d22cee2374c46422809e45e07b3b0

3 years agoGd Metrics: Use le_meta_event_view before move
Chen Chen [Thu, 15 Apr 2021 17:20:08 +0000 (10:20 -0700)]
Gd Metrics: Use le_meta_event_view before move

Test: gd/cert/run
Bug: 181819141
Tag: #stability
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines
Change-Id: I77d482dea2f77c8aa7c41b0e33bd398a9eb21adf

3 years agoMerge "Reference the chipset capability in LE_Set_Data_Length"
Treehugger Robot [Thu, 15 Apr 2021 07:29:34 +0000 (07:29 +0000)]
Merge "Reference the chipset capability in LE_Set_Data_Length"

3 years agoMerge "audio: Initial implementation for bluetooth hw driver input"
Jakub Pawlowski [Thu, 15 Apr 2021 06:19:08 +0000 (06:19 +0000)]
Merge "audio: Initial implementation for bluetooth hw driver input"

3 years agoMerge "gd Scanning: Unregister event when stop"
Treehugger Robot [Thu, 15 Apr 2021 06:13:04 +0000 (06:13 +0000)]
Merge "gd Scanning: Unregister event when stop"

3 years agogd Scanning: Unregister event when stop
Chienyuan [Tue, 13 Apr 2021 09:36:55 +0000 (17:36 +0800)]
gd Scanning: Unregister event when stop

Tag: #gd-refactor
Bug: 184002509
Test: gd/cert/run
Change-Id: I8346ccafdcb867ae8695de2b3ed087f5fadbeab4

3 years agoGD metrics: remove reference before move
Chen Chen [Thu, 15 Apr 2021 01:19:24 +0000 (18:19 -0700)]
GD metrics: remove reference before move

Test: gd/cert/run
Bug: 181819141
Tag: #stability
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: Iebe25a935aac2e1936734f775f617496ef920fd1

3 years agoMerge "GD metrics: Logging link layer events from GD"
Chen Chen [Wed, 14 Apr 2021 22:40:48 +0000 (22:40 +0000)]
Merge "GD metrics: Logging link layer events from GD"

3 years agogd: Enforce modules to present a unique name
Chris Manton [Tue, 13 Apr 2021 23:49:18 +0000 (16:49 -0700)]
gd: Enforce modules to present a unique name

A rogue module should be identified if it hangs

Bug: 184608842
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I0514ff36c7b1654e8de30a262b9a3a05a305a537

3 years agoheadless: Add docs and more information
Chris Manton [Tue, 13 Apr 2021 23:49:51 +0000 (16:49 -0700)]
headless: Add docs and more information

Bug: 147316415
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I44c8a3a38914581a335446f975c9626a9587e73f

3 years agoheadless: Add initial/final sentinal log markers
Chris Manton [Tue, 13 Apr 2021 21:17:14 +0000 (14:17 -0700)]
headless: Add initial/final sentinal log markers

Bug: 147316415
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: Ic965827c03487d9d7984382178411e520c5a5057

3 years agoExplict default init types module_t
Chris Manton [Sat, 10 Apr 2021 17:48:17 +0000 (10:48 -0700)]
Explict default init types module_t

Toward initialized code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: I343a777b57138017f825823d260a3c956f2aead0

3 years agoEnum-ify tSMP_EVT
Chris Manton [Tue, 2 Mar 2021 20:32:59 +0000 (12:32 -0800)]
Enum-ify tSMP_EVT

Toward readable code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: I12e2d8d7d1f8ddb05a6b9b673c74013fda5a0d22

3 years agoEnum-ify tBTA_STATUS
Chris Manton [Wed, 3 Mar 2021 01:02:17 +0000 (17:02 -0800)]
Enum-ify tBTA_STATUS

Toward readable code

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: Id79e619d24484ace55409e32f99368d5d9bce06e

3 years agotesting: Use proper types
Chris Manton [Wed, 14 Apr 2021 03:16:41 +0000 (20:16 -0700)]
testing: Use proper types

Bug: 163134718
Test: gd/cert/run
Tag: #refactor
Change-Id: I959e0522ca0e7394e7d1287859694d83d9e50e83

3 years agoReference the chipset capability in LE_Set_Data_Length
Ugo Yu [Wed, 14 Apr 2021 09:52:33 +0000 (17:52 +0800)]
Reference the chipset capability in LE_Set_Data_Length

The parameters in LE_Set_Data_Length was hard-coded to the maximum
value, which could break some low-end Bluetooth chips.

Tag: #feature
Bug: 178526513
Test: bluetooth_test_gd --gtest_filter="*controller*"
Change-Id: I5299beff2ab0faff12482c038137878d9ced0a7d

3 years agoMerge RQ2A.210405.006 to aosp-master - DO NOT MERGE
Bill Yi [Wed, 14 Apr 2021 02:29:21 +0000 (19:29 -0700)]
Merge RQ2A.210405.006 to aosp-master - DO NOT MERGE

Merged-In: Ia5ca732e8464d02a3c5a7b1b75f4c6afbe441fb1
Merged-In: I4021d889879a11a7ad2a59a1b63c4371970cc823
Change-Id: I2db132a530a87a3664f7ea24c0fc5d4ac0a85822

3 years agoGD metrics: Logging link layer events from GD
Chen Chen [Wed, 31 Mar 2021 18:58:15 +0000 (11:58 -0700)]
GD metrics: Logging link layer events from GD

Events include:
* LinkLayerConnection,
* ReadRssi,
* ReadFailedContactCounter,
* ReadTxPower,
* RemoteVersionInfo,
* HciTimeout
Also move the gd metrics logging from common to os

Test: gd/cert/run
Manual test: build and run Bluetooth (connection, pairing, music and phone
call)
Bug: 181819141
Tag: #gd-refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: Id84651a4cc0343ed0438083290b3aaab1ead6535

3 years agoMerge "RFCOMM: Handle configuration for pending connection"
Jack He [Tue, 13 Apr 2021 23:58:05 +0000 (23:58 +0000)]
Merge "RFCOMM: Handle configuration for pending connection"

3 years agoaudio: Initial implementation for bluetooth hw driver input
Grzegorz Kołodziejczyk [Thu, 1 Apr 2021 15:21:17 +0000 (15:21 +0000)]
audio: Initial implementation for bluetooth hw driver input

Patch adds initial implementation for input driver of bluetooth hw.

Tag: #feature
Test: open input stream e.g. Le Audio Decoded session
Sponsor: jpawlowski@
Bug: 150670922
Change-Id: I6702f962a26c93a4f53cfc223185b5a61112d330

3 years agoMerge "OOB: Implement generateLocalOobData API"
Treehugger Robot [Tue, 13 Apr 2021 15:28:25 +0000 (15:28 +0000)]
Merge "OOB: Implement generateLocalOobData API"

3 years agoMerge "Add time unit to AVDTP delay reporting value displayed for debugging."
Johanna Ye [Tue, 13 Apr 2021 14:56:11 +0000 (14:56 +0000)]
Merge "Add time unit to AVDTP delay reporting value displayed for debugging."

3 years agoMerge "Add logging message to indicate collision with previous pending connection...
Johanna Ye [Tue, 13 Apr 2021 13:23:14 +0000 (13:23 +0000)]
Merge "Add logging message to indicate collision with previous pending connection from the same remote device."

3 years agoAdd time unit to AVDTP delay reporting value displayed for debugging.
Johanna Ye [Mon, 12 Apr 2021 11:34:18 +0000 (13:34 +0200)]
Add time unit to AVDTP delay reporting value displayed for debugging.

Tag: #refactor
Test: ADT3 with Pixel Buds
Bug: 182167357
Change-Id: Ie2527cc4c2e9cb871d15eb26417ae4814953de84

3 years agoRFCOMM: Handle configuration for pending connection
Chienyuan [Wed, 7 Apr 2021 13:34:55 +0000 (21:34 +0800)]
RFCOMM: Handle configuration for pending connection

Tag: #refactor
Bug: 183672787
Test: manual
Change-Id: I9a41c953dc87f9c804ea6624f60516d5e640904a

3 years agoMerge "SCO: change D1 max latency to 0xFFFF"
Josh Wu [Tue, 13 Apr 2021 03:00:24 +0000 (03:00 +0000)]
Merge "SCO: change D1 max latency to 0xFFFF"

3 years agoMerge "Initial btif/test/btif_stack_test"
Treehugger Robot [Mon, 12 Apr 2021 19:20:44 +0000 (19:20 +0000)]
Merge "Initial btif/test/btif_stack_test"

3 years agoAdd logging message to indicate collision with previous pending connection from the...
Johanna Ye [Tue, 23 Mar 2021 16:04:43 +0000 (17:04 +0100)]
Add logging message to indicate collision with previous pending connection from the same remote device.

Currently, When there's already a pending connecting procedure going on in the native layer (even if it were the same remote device), the native layer returns BT_STATUS_BUSY which is then interpreted by the JNI layer as a failure to connect, resulting in a disconnection request.

This adds logging message when this happens, until there's a clear
indication to prioritize a complete fix.

Tag: #stability
Bug: 174127136
Test: manual through repeated connections in ADT3 OOBE
Change-Id: Ifc84e883f8ae248ecfa99556465c22b32ce82f79

3 years agoSCO: change D1 max latency to 0xFFFF
Josh Wu [Mon, 12 Apr 2021 09:43:35 +0000 (17:43 +0800)]
SCO: change D1 max latency to 0xFFFF

Although classic SCO cannot retransmit, the max latency should be
0xFFFF(Don't care) instead of 0(reserved, not 0ms).

Tag: #compatibility
Bug: 185093884
Test: atest BluetoothInstrumentationTests
Change-Id: Ia287c32e771eff1e5550fbb2098d70c520689250

3 years agoRemove not Hwbinder thread stopwatch caller
weichinweng [Mon, 12 Apr 2021 08:16:58 +0000 (16:16 +0800)]
Remove not Hwbinder thread stopwatch caller

Bug: 185083209
Test: atest BluetoothInstrumentationTests
Tag: #stability
Change-Id: I14aa41d741c30a9470929a19b633d0d936adcf04

3 years agoInitial btif/test/btif_stack_test
Chris Manton [Thu, 8 Apr 2021 00:37:08 +0000 (17:37 -0700)]
Initial btif/test/btif_stack_test

Bug: 182544206
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines
No-Typo-Check: Legacy code mocks

Change-Id: I5cf4b24651b436a96bfbba43ad33db28707352e3

3 years agovc: Initial field in constructor
Greg Kaiser [Fri, 9 Apr 2021 14:10:44 +0000 (07:10 -0700)]
vc: Initial field in constructor

The 'flags' field was our only field not initialized in our
constructor.  To assure consistent behavior, we initialize it
here.

Test: TreeHugger
Change-Id: I92c94eb5a995b5980d635f2c6d1cb12bf28ef4ca

3 years agobtm_iso: Allow to start ISO by many clients
Łukasz Rymanowski [Mon, 4 Jan 2021 14:45:50 +0000 (14:45 +0000)]
btm_iso: Allow to start ISO by many clients

It turns out we might need btm_iso to be stated from more than one place
e.g. broadcast and unicast scenario.

Therefore, allow for that.

Bug: 150670922
Tag: #feature
Test: atest --host net_test_btm_iso
Sponsor: jpawlowski@

Change-Id: I8111a55707a00b5622a260f938e0da08fc37ae65

3 years agoMerge "HCI: Accept erroneous ConnectionComplete"
Treehugger Robot [Fri, 9 Apr 2021 08:59:21 +0000 (08:59 +0000)]
Merge "HCI: Accept erroneous ConnectionComplete"

3 years agoaudio: Introduce LE Audio support for client interface and HAL
Grzegorz Kołodziejczyk [Fri, 26 Feb 2021 21:38:37 +0000 (21:38 +0000)]
audio: Introduce LE Audio support for client interface and HAL

Patch introduces support for client interface and HAL.

Tag: #feature
Test: atest bluetooth-test-audio-hal-interface
Sponsor: jpawlowski@
Bug: 150670922
Change-Id: Idddddc403aacc671d8010f8c6004038ffe53da8f

3 years agoRe-log btif/src/stack_manager
Chris Manton [Thu, 8 Apr 2021 23:17:27 +0000 (16:17 -0700)]
Re-log btif/src/stack_manager

Bug: 163134718
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I3403836b9e358ecd2967de25a72cba421641e24b

3 years agoAdd layer of indirection to set hal_callbacks
Chris Manton [Thu, 8 Apr 2021 23:16:53 +0000 (16:16 -0700)]
Add layer of indirection to set hal_callbacks

Used for test injection

Bug: 163134718
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I1cfd4103bfe6b20aabff2885e5ace106e11b04e8

3 years agoCononicalize include pathnames
Chris Manton [Thu, 8 Apr 2021 00:37:18 +0000 (17:37 -0700)]
Cononicalize include pathnames

Bug: 163134718
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I5a8f78346ae26fd4cdccc5730160cb76b3a01a9e

3 years agoRemove execute bits btif/::
Chris Manton [Wed, 7 Apr 2021 20:01:27 +0000 (13:01 -0700)]
Remove execute bits btif/::

Bug: 163134718
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I35654b3c03d365900c06e12a09934a27739b75b9

3 years agoPrint stopwatch log when the bluetooth HAL died.
weichinweng [Thu, 8 Apr 2021 09:48:39 +0000 (17:48 +0800)]
Print stopwatch log when the bluetooth HAL died.

Bug: 175754404
Test: atest BluetoothInstrumentationTests
Tag: #stability
Change-Id: I775066475cc3b14de3b613b8a3b60c34214c3703

3 years agoMerge "Update to use CXX 1.0"
Matthew Maurer [Thu, 8 Apr 2021 19:59:20 +0000 (19:59 +0000)]
Merge "Update to use CXX 1.0"

3 years agoMerge "Add a hint for cert tests"
Treehugger Robot [Thu, 8 Apr 2021 18:28:09 +0000 (18:28 +0000)]
Merge "Add a hint for cert tests"

3 years agoMerge changes I3ccf85d5,I731adcff,I6f5f9cec,I9f773287,Iabf796dc, ...
Treehugger Robot [Thu, 8 Apr 2021 18:27:11 +0000 (18:27 +0000)]
Merge changes I3ccf85d5,I731adcff,I6f5f9cec,I9f773287,Iabf796dc, ...

* changes:
  Update gitignore for Cargo.lock and tags
  Use local rules for flex/bison
  Specify bt_shim_ffi dependency to bluetoothtbd
  Fix rust build in build.py
  Avoid const value_type of vector
  Guard printing PKG_CONFIG_PATH in build.py
  Add missing #include <string.h> for memcpy
  Fix packetgen outputs

3 years agoHCI: Accept erroneous ConnectionComplete
Myles Watson [Wed, 7 Apr 2021 17:04:11 +0000 (10:04 -0700)]
HCI: Accept erroneous ConnectionComplete

Some controllers send ConnectionComplete with status code
Unknown Connection when cancelling a RemoteNameRequest.

Fixes: 184239841
Tag: #gd-refactor
Test: cert/run
Change-Id: Ibcaf68a13e18a629ab16be3bb4bfe9c1ff208095

3 years agoMerge "gd hci: Check credit before sending next fragment"
Jack He [Thu, 8 Apr 2021 17:29:14 +0000 (17:29 +0000)]
Merge "gd hci: Check credit before sending next fragment"

3 years agogd hci: Check credit before sending next fragment
Chienyuan [Thu, 8 Apr 2021 07:37:19 +0000 (15:37 +0800)]
gd hci: Check credit before sending next fragment

Tag: #gd-refactor
Bug: 180870443
Test: gd/cert/run
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines
Change-Id: Ifd2af34886a0cf40d5ca3f4fdd4869089276d919

3 years agoAdd a hint for cert tests
Myles Watson [Thu, 8 Apr 2021 00:44:36 +0000 (17:44 -0700)]
Add a hint for cert tests

Bug: 184786243
Test: cert/run
Tag: #gd-refactor
Change-Id: Ie81ce626c23016dd66c8418aeff44687d50111d5

3 years agoUpdate to use CXX 1.0
Matthew Maurer [Thu, 8 Apr 2021 08:08:26 +0000 (01:08 -0700)]
Update to use CXX 1.0

Test: m
Bug: 184799689
Tag: #refactor
Change-Id: I93c7c2e8f754501771fe13c9f30408940dfe66a6

3 years agoAdd StopWatch for Hwbinder callback function
weichinweng [Wed, 3 Mar 2021 02:19:19 +0000 (10:19 +0800)]
Add StopWatch for Hwbinder callback function

Add stopWatch feature to monitor HCI callbacks and audio client
callbacks.

Bug: 175754854
Test: atest BluetoothInstrumentationTests
Tag: #stability
Change-Id: I87b9aac85166f345629ea110653cc873ca24c079

3 years agoUpdate owners
Hansong Zhang [Wed, 7 Apr 2021 23:29:11 +0000 (16:29 -0700)]
Update owners

Test: N/A
Change-Id: Ia98b958ea7a97b7aa5a47ce3b118148adcaa5d08

3 years agoOOB: Implement generateLocalOobData API
Martin Brabham [Wed, 31 Mar 2021 16:41:34 +0000 (09:41 -0700)]
OOB: Implement generateLocalOobData API

Ignore-AOSP-First: Conflict with internal
Bug: 178007935
Tag: #feature
Test: manual
Change-Id: I149907ef7ee3b6f9600ac57950afbc9616381dc0
Merged-In: I149907ef7ee3b6f9600ac57950afbc9616381dc0

3 years agoMerge "SCO: Use const reference instead of const value"
Treehugger Robot [Wed, 7 Apr 2021 17:28:48 +0000 (17:28 +0000)]
Merge "SCO: Use const reference instead of const value"

3 years agoAdd Volume Control Profile API
Łukasz Rymanowski [Fri, 29 Jan 2021 08:56:03 +0000 (08:56 +0000)]
Add Volume Control Profile API

Bug: 150670922
Test: compilation
Tag: #feature
Sponsor: jpawlowski@
Change-Id: I4a12847f9be7cb77d9094fd5a1a8f9c68053ad21

3 years agoSCO: Use const reference instead of const value
Jack He [Wed, 7 Apr 2021 06:02:32 +0000 (23:02 -0700)]
SCO: Use const reference instead of const value

Bug: 183476377
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I538c46eeb9cf40400f4f4ec424c4da6ae804213c

3 years ago vc: Implement Volume Control Profile
Łukasz Rymanowski [Fri, 29 Jan 2021 09:05:10 +0000 (09:05 +0000)]
 vc: Implement Volume Control Profile

 This implements basic version of VCP which allows to control Volume
 Control Service on ther remote side.

 This profile for expose only connect/disconnect/set volume

 Bug: 150670922
 Tag: #feature
 Test: atest --host bluetooth_test_vc
 Sponsor: jpawlowski@

Change-Id: Ie68c333ffece3958d68580fbfd3a86aec1186711

3 years agolegacy: Plumb gd sco conn req to legacy stack
Chris Manton [Wed, 7 Apr 2021 01:12:21 +0000 (18:12 -0700)]
legacy: Plumb gd sco conn req to legacy stack

Bug: 183476377
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I79fcfcf8dde071aff0a07f5440cfdca6e0e8134e

3 years agoConst-ify btm_sco_conn_req::DEV_CLASS
Chris Manton [Wed, 7 Apr 2021 05:42:02 +0000 (22:42 -0700)]
Const-ify btm_sco_conn_req::DEV_CLASS

Bug: 183476377
Test: gd/cert/run
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: Iec78ab6a7b46837f9ab512d57b320b565d78f7cd

3 years agoMerge "RFCOMM: Handle failed connection request"
Treehugger Robot [Wed, 7 Apr 2021 06:06:49 +0000 (06:06 +0000)]
Merge "RFCOMM: Handle failed connection request"

3 years agoUpdate gitignore for Cargo.lock and tags
Abhishek Pandit-Subedi [Mon, 15 Mar 2021 20:52:05 +0000 (13:52 -0700)]
Update gitignore for Cargo.lock and tags

Bug: 176847216
Tag: #floss
Test: atest --host bluetooth_test_gd

Change-Id: I3ccf85d54493630257957a1c5182e54470bcb16f

3 years agoUse local rules for flex/bison
Abhishek Pandit-Subedi [Mon, 15 Mar 2021 20:44:51 +0000 (13:44 -0700)]
Use local rules for flex/bison

Use local flex and bison rules for the packet parser instead of
depending on the rules in common-mk. Right now, the packet parser is
using a re-entrant parser which can't be used with C++ codegen for flex.
Common-mk maintainers would like the flex code to use C++ codegen since
it is compiling the file as C++.

Bug: 176847216
Tag: #floss
Test: atest --host bluetooth_test_gd
Change-Id: I731adcff7c966543300d2cdf1f87ef2a69b8a211

3 years agoSpecify bt_shim_ffi dependency to bluetoothtbd
Sonny Sasaka [Sat, 27 Mar 2021 05:17:53 +0000 (22:17 -0700)]
Specify bt_shim_ffi dependency to bluetoothtbd

Specifying lib bt_shim_ffi explicitly before ssl so that ssl references
can be linked from bt_shim_ffi.

Bug: 176846220
Tag: #floss
Test: atest --host bluetooth_test_gd
Change-Id: I6f5f9cec960157559a57fe6721cd21ea0647c312

3 years agoFix rust build in build.py
Sonny Sasaka [Thu, 25 Mar 2021 14:10:47 +0000 (07:10 -0700)]
Fix rust build in build.py

This copies the rust build result to the gn output directory to be
accessible when linking from C++. Also adds an option to use crates.io
for rust crates.

Bug: 176846220
Tag: #floss
Test: atest --host bluetooth_test_gd
Change-Id: I9f7732878a2aced6f80f363c25aff3243d34f0d5