OSDN Git Service
Ivailo Monev [Sat, 28 Dec 2019 22:25:32 +0000 (22:25 +0000)]
remove default QSequentialAnimationGroup::event() reimplementation
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 22:17:43 +0000 (22:17 +0000)]
remove redundant reinterpret_cast<> in QIcuCodec::convertFromUnicode()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 22:06:28 +0000 (22:06 +0000)]
deal with QVarLengthArray TODO
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 20:57:00 +0000 (20:57 +0000)]
move qstringmatcher header inclusion from qstringlist header to source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 19:24:35 +0000 (19:24 +0000)]
remove redundant uint() construct in QDate::setYMD()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 19:23:39 +0000 (19:23 +0000)]
return object rather than reference from QFileInfoPrivate::getFileTime()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 18:28:45 +0000 (18:28 +0000)]
correct QFileInfoPrivate::getCachedFlag() return value
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 18:10:05 +0000 (18:10 +0000)]
optimize QSize::scale()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 17:55:54 +0000 (17:55 +0000)]
remove bogus compile-time error in qrect header
there is no topLeft() function that I am aware of
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 17:39:30 +0000 (17:39 +0000)]
use uninitialized buffer instead of resizing one in QByteDataBuffer::read()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 16:29:17 +0000 (16:29 +0000)]
build against internal copies of libpng and sqlite if not found
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 04:19:47 +0000 (04:19 +0000)]
mark getSettingsPath() function as static
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 03:31:19 +0000 (03:31 +0000)]
mark default case in QCryptographicHash::hash() as unreachable
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 02:51:36 +0000 (02:51 +0000)]
fix build-time check in qt_safe_accept() and introduce NetBSD support
upstream commit:
https://github.com/qt/qtbase/commit/
b3b2f502e9b499814a1e3b21e1b572e3ff1ba37b
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 02:29:48 +0000 (02:29 +0000)]
remove redundant QT_SOCKOPTLEN_T definition
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 02:22:52 +0000 (02:22 +0000)]
avoid struct mirroring by including qobject_p header in qsignaldumper source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 01:47:40 +0000 (01:47 +0000)]
replace C-style casts with static_cast where applicable
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 01:23:58 +0000 (01:23 +0000)]
plug QDateTime memory leaks
caused by shadowing member
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 01:04:10 +0000 (01:04 +0000)]
do not reallocate shared empty/null QByteArray data
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 01:01:03 +0000 (01:01 +0000)]
QSharedData ref member does not have to be mutable
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 00:23:29 +0000 (00:23 +0000)]
do not free the shared empty and shared null QByteArray data
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 00:12:02 +0000 (00:12 +0000)]
remove redundant QT_NO_EXCEPTIONS definition from minsize.sh script [ci skip]
exceptions are automatically disabled via Q_COMPILER_EXCEPTIONS
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 28 Dec 2019 00:04:51 +0000 (00:04 +0000)]
compiler warning fixes
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 15:45:03 +0000 (15:45 +0000)]
QFont::exactMatch() should return false for aliases
upstream commit:
https://github.com/qt/qtbase/commit/
78eeb6b066113c678fe15531ca10e70964f6b9a4
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 15:11:44 +0000 (15:11 +0000)]
use public QByteArray constructor in QByteArray::trimmed()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 15:11:11 +0000 (15:11 +0000)]
use public QString constructors in QString::simplified() and QString::trimmed()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 15:09:50 +0000 (15:09 +0000)]
QDirIterator destructor does not have to be virtual
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 15:07:56 +0000 (15:07 +0000)]
avoid temporary in QDirIteratorPrivate::pushDirectory()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 14:58:54 +0000 (14:58 +0000)]
avoid temporary in QUrl streaming operator
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 13:30:08 +0000 (13:30 +0000)]
replace QListIterator<> with foreach() where applicable
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 12:29:42 +0000 (12:29 +0000)]
Revert "get rid of QByteArray::shared_empty and QString::shared_empty"
This reverts commit
259252b337b15cebdc556e597a30c5a8fb0ac1ef.
Ivailo Monev [Fri, 27 Dec 2019 12:10:39 +0000 (12:10 +0000)]
avoid temporary in QCalendarDateValidator::currentText() const
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 12:10:11 +0000 (12:10 +0000)]
make TextWriter::hasOverlap() const and avoid temporary in it
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 11:36:07 +0000 (11:36 +0000)]
remove redundant uint() constructs in QString::at() and QString::operator[]
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 10:49:10 +0000 (10:49 +0000)]
get rid of QByteArray::shared_empty and QString::shared_empty
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 10:27:13 +0000 (10:27 +0000)]
inline qstrnlen() function to strnlen()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 10:14:50 +0000 (10:14 +0000)]
remove bogus compile-time error
the signature for truncate() from unistd header takes two arguments,
QByteArray::truncate() takes only one
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 09:03:17 +0000 (09:03 +0000)]
protect QIcuCodec::allCodecs() and QIcuCodec::allMibs() cache with mutex
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 07:45:29 +0000 (07:45 +0000)]
Revert "install newer libpng version in Travis"
This reverts commit
a6e204f4d8e209285256f252081b09e159aafc74.
Ivailo Monev [Fri, 27 Dec 2019 06:58:24 +0000 (06:58 +0000)]
install newer libpng version in Travis
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 06:19:55 +0000 (06:19 +0000)]
require LibTIFF v3.6.0 atleast
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 05:56:12 +0000 (05:56 +0000)]
replace convert_rgb888_to_rgb32_C() function pointer with actual function call
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 05:37:54 +0000 (05:37 +0000)]
require libpng v1.5.4 atleast
there is no tarball for stable v1.5.3 in the archive at:
https://ftp-osl.osuosl.org/pub/libpng/src/archive/xz/libpng15/
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 05:36:24 +0000 (05:36 +0000)]
correct ZLIB package version requirement note
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 05:24:04 +0000 (05:24 +0000)]
warn on negative data size from qCompress() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 05:14:00 +0000 (05:14 +0000)]
avoid buffer resizing in qCompress() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 03:27:27 +0000 (03:27 +0000)]
simplify qUncompress() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 02:03:43 +0000 (02:03 +0000)]
inline qstrcmp() function overloads
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 01:21:57 +0000 (01:21 +0000)]
indent and use signle variable assignment in QByteArray::toBase64()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 27 Dec 2019 01:19:21 +0000 (01:19 +0000)]
replace tabs with spaces in QByteArray::fromBase64()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Thu, 26 Dec 2019 21:19:42 +0000 (21:19 +0000)]
remove redundant header inclusions from qfont_x11 source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Thu, 26 Dec 2019 21:19:24 +0000 (21:19 +0000)]
remove redundant QFONTLOADER_DEBUG and QFONTLOADER_DEBUG_VERBOSE definitions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Thu, 26 Dec 2019 21:19:00 +0000 (21:19 +0000)]
optimize QFont::lastResortFont()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Thu, 26 Dec 2019 19:58:18 +0000 (19:58 +0000)]
remove redundant qt_defaultDpiX(), qt_defaultDpiY() and qt_defaultDpi() functions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Thu, 26 Dec 2019 19:46:43 +0000 (19:46 +0000)]
remove non-existing classes forward declarations from qx11info_x11 header
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Thu, 26 Dec 2019 18:58:00 +0000 (18:58 +0000)]
optimize and make font tables lookups consistent
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Thu, 26 Dec 2019 18:21:07 +0000 (18:21 +0000)]
remove redundant Q_UNUSED() macro calls in bestFoundry() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 22:26:14 +0000 (22:26 +0000)]
check if path is writable as fallback in QSettings::isWritable()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 21:52:02 +0000 (21:52 +0000)]
convert strings to ASCII instead of Latin1 in QSettingsPrivate::variantToString()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 21:51:08 +0000 (21:51 +0000)]
replace break with return in QSettingsPrivate::variantToString()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 21:50:08 +0000 (21:50 +0000)]
convert strings from/to ASCII instead of Latin1 in QSettingsPrivate::variantToString()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 21:23:17 +0000 (21:23 +0000)]
update QSettings documentation [ci skip]
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 18:43:41 +0000 (18:43 +0000)]
remove redundant QT_RCC and QT_UIC definitions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 18:39:35 +0000 (18:39 +0000)]
remove uic3 leftovers
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 18:29:33 +0000 (18:29 +0000)]
make all custom CMake modules print library in status message
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 17:57:59 +0000 (17:57 +0000)]
update README [ci skip]
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 17:31:07 +0000 (17:31 +0000)]
avoid temporary in QVariant::canConvert() and int() constructs
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 17:23:32 +0000 (17:23 +0000)]
set Architectures to those which Debian provides binary packages for in Debian control file [ci skip]
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 08:48:14 +0000 (08:48 +0000)]
link tst_script to script component
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 07:16:51 +0000 (07:16 +0000)]
link performance_server to core component
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 07:15:01 +0000 (07:15 +0000)]
remove redundant Q_UNUSED() macro call in QDBusConnectionPrivate::serviceOwnerChangedNoLock()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 06:35:36 +0000 (06:35 +0000)]
link QDBusType test to D-Bus libraries
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 05:55:31 +0000 (05:55 +0000)]
use foreach() for iteration in ~QFactoryLoaderPrivate(), QFactoryLoader::updateDir() and QFactoryLoader::update()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 05:54:04 +0000 (05:54 +0000)]
move variable closer to the scope it is used in in QFactoryLoader::updateDir()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 05:08:38 +0000 (05:08 +0000)]
update QSettings documentation [ci skip]
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 04:17:48 +0000 (04:17 +0000)]
remove redundant QProcEnvKey
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 25 Dec 2019 03:36:14 +0000 (03:36 +0000)]
drop redundant QSettings UNIX file locking
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 23:17:51 +0000 (23:17 +0000)]
avoid temporaries in QString::isRightToLeft()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 22:23:55 +0000 (22:23 +0000)]
setup include directories before including sub-directory CMake files
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 22:23:15 +0000 (22:23 +0000)]
correct and verify codepoint conversion in tst_QChar::normalization_data()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 22:22:28 +0000 (22:22 +0000)]
mark overflow cases in QByteArray integer conversion methods unlikely
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 21:29:36 +0000 (21:29 +0000)]
check if string is normalized before normalizing it from QString::normalized()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 19:19:32 +0000 (19:19 +0000)]
simplify the QSettings write check
the previous implementation was supposed to be write-optimized, for cases
when QSettings::setValue() followed by QSettings::sync() is called often.
it turns out that optimizing for reading from the settings without changing
the object is more beneficial as that is often the case.
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 18:18:09 +0000 (18:18 +0000)]
optimize key/value and section/key splitting in ini_settings_read() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 09:35:43 +0000 (09:35 +0000)]
lock QSettingsPrivate object that work with the same file only from QSettingsPrivate::write()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 08:54:24 +0000 (08:54 +0000)]
link QCssParser test to xml component
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 08:49:13 +0000 (08:49 +0000)]
link QThread test to system thread library
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 08:43:58 +0000 (08:43 +0000)]
make use of QThread::yieldCurrentThread() in sql component threading test
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 08:37:34 +0000 (08:37 +0000)]
link svg component to zlib libraries explicitly
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 08:37:20 +0000 (08:37 +0000)]
link network component to OpenSSL libraries explicitly
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 08:31:03 +0000 (08:31 +0000)]
set extra link libraries as private where applicable
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 07:29:08 +0000 (07:29 +0000)]
use consistent name for locker in QSettingsPrivate::write()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 07:28:40 +0000 (07:28 +0000)]
do not include Shell profile and linker config in Debian package
Shell profile file breaks cross-compilation because it exports
PKG_CONFIG_PATH
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 05:53:06 +0000 (05:53 +0000)]
take prefix into account and use HEX string in QSharedMemoryPrivate::makePlatformSafeKey()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 05:14:42 +0000 (05:14 +0000)]
remove redundant QT_NO_QOBJECT definition checks from qsettings_p header
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 05:13:55 +0000 (05:13 +0000)]
fix synchronization of QSettings between multiple processes
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 24 Dec 2019 02:29:16 +0000 (02:29 +0000)]
replace QMetaType with QVariant enums where applicable in QVariant test
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 23 Dec 2019 21:05:10 +0000 (21:05 +0000)]
rework QSettings, use JSON as native format for it
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 23 Dec 2019 21:03:59 +0000 (21:03 +0000)]
adjust expected QVariant test data
it is possible to convert negative strings to integers now
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 23 Dec 2019 03:23:45 +0000 (03:23 +0000)]
quote varibles that may contain whitespace in KatieMacros and KatieBuildMacros CMake files
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>