OSDN Git Service
Peter Eisentraut [Mon, 6 Jul 2009 17:01:42 +0000 (17:01 +0000)]
Show definition of index columns in \d on index
This adds a column called "Definition" to the output of psql \d on an
index, which shows the full expression behind the index column. For indexes
on plain columns, this is redundant, but for expression indexes, this
reveals the real expression.
Author: Khee Chin <kheechin@gmail.com>
Tom Lane [Mon, 6 Jul 2009 02:58:40 +0000 (02:58 +0000)]
Per SQL spec (in particular, the grammar in SQL:2008 7.13) we should allow
parentheses around the <query expression body> that follows a WITH clause, eg
with cte(foo) as ( values(0) ) ((select foo from cte));
This seems to be just an oversight/thinko in gram.y. Noted while
experimenting with bug #4902.
Tom Lane [Mon, 6 Jul 2009 02:16:03 +0000 (02:16 +0000)]
Fix handling of changed-Param signaling for CteScan plan nodes. We were using
the "cteParam" as a proxy for the possibility that the underlying CTE plan
depends on outer-level variables or Params, but that doesn't work very well
because it sometimes causes calling subqueries to be treated as SubPlans when
they could be InitPlans. This is inefficient and also causes the outright
failure exhibited in bug #4902. Instead, leave the cteParam out of it and
copy the underlying CTE plan's extParams directly. Per bug #4902 from
Marko Tiikkaja.
Peter Eisentraut [Fri, 3 Jul 2009 19:14:25 +0000 (19:14 +0000)]
Add log_line_prefix placeholder %e to contain the current SQL state
Author: Guillaume Smet <guillaume.smet@gmail.com>
Peter Eisentraut [Fri, 3 Jul 2009 18:56:50 +0000 (18:56 +0000)]
Have \d show child tables that inherit from the specified parent
As per discussion, \d shows only the number of child tables, because that
could be hundreds, when used for partitioning. \d+ shows the actual list.
Author: Damien Clochard <damien@dalibo.info>
Tom Lane [Thu, 2 Jul 2009 21:34:32 +0000 (21:34 +0000)]
Fix up pg_dump's --binary-upgrade option so that it behaves properly with
inherited columns and check constraints. Per my recent trouble report.
Peter Eisentraut [Thu, 2 Jul 2009 18:55:40 +0000 (18:55 +0000)]
Upgrade to Autoconf 2.63
This upgrades the configure infrastructure to the latest Autoconf version.
Some notable news are:
- The workaround for the broken fseeko() test is gone.
- Checking for unknown options is now provided by Autoconf itself.
- Fixes for Mac OS X
Peter Eisentraut [Thu, 2 Jul 2009 07:03:18 +0000 (07:03 +0000)]
Regression test for XML mapping functionality
I wrote this one while chasing down some bugs in the closing days of 8.4. It
could be useful in the long run. This area of the code had no test coverage
at all before.
Tom Lane [Wed, 1 Jul 2009 23:57:33 +0000 (23:57 +0000)]
Remove useless References column for pg_listener catalog description. Per Shigehiro Honda.
Tom Lane [Wed, 1 Jul 2009 23:15:55 +0000 (23:15 +0000)]
Stamp HEAD as 8.5devel.
Tom Lane [Tue, 30 Jun 2009 17:38:50 +0000 (17:38 +0000)]
Add missed src/include/foreign subdirectory to the set installed into
INSTALLDIR/include/server/. Itagaki Takahiro
Tom Lane [Sat, 27 Jun 2009 21:06:46 +0000 (21:06 +0000)]
Revert addition of "o" to tar options. This was intended to fix bug #4883,
but the cure appears to be worse than the disease. It turns out that GNU
tar versions 1.14.x misinterpret -o as --same-owner, not --no-same-owner,
leading to exactly the wrong behavior for both root and nonroot users.
While that bug has been fixed for nearly five years, these tar versions
are still found in the wild, notably in OS X 10.4. Given that #4883 was
the first complaint we'd heard, it's definitely not worth fixing at the
risk of breaking things for other users. Perhaps revisit at a later date
when we're not up against a release deadline.
Marc G. Fournier [Sat, 27 Jun 2009 00:14:47 +0000 (00:14 +0000)]
Bundle v8.4.0
Tom Lane [Fri, 26 Jun 2009 22:23:17 +0000 (22:23 +0000)]
Update release notes in final preparation for 8.4.0.
Tom Lane [Fri, 26 Jun 2009 22:08:17 +0000 (22:08 +0000)]
Add a note about SystemTap vs DTrace spelling of probe names.
Tom Lane [Fri, 26 Jun 2009 22:06:11 +0000 (22:06 +0000)]
Marginal improvement of description of recovery_end_command.
Tom Lane [Fri, 26 Jun 2009 20:29:04 +0000 (20:29 +0000)]
Cleanup and code review for the patch that made bgwriter active during
archive recovery. Invent a separate state variable and inquiry function
for XLogInsertAllowed() to clarify some tests and make the management of
writing the end-of-recovery checkpoint less klugy. Fix several places
that were incorrectly testing InRecovery when they should be looking at
RecoveryInProgress or XLogInsertAllowed (because they will now be executed
in the bgwriter not startup process). Clarify handling of bad LSNs passed
to XLogFlush during recovery. Use a spinlock for setting/testing
SharedRecoveryInProgress. Improve quite a lot of comments.
Heikki and Tom
Peter Eisentraut [Fri, 26 Jun 2009 19:33:52 +0000 (19:33 +0000)]
Translation updates for 8.4 release.
File that are translated less than 80% have been removed, as per new
translation team policy.
Peter Eisentraut [Fri, 26 Jun 2009 06:40:57 +0000 (06:40 +0000)]
Extract tarballs with "o" option (tar xof), to behave reasonably when run
as root, as would usually be the case during make install.
per bug #4883
Peter Eisentraut [Fri, 26 Jun 2009 06:37:14 +0000 (06:37 +0000)]
Use $(TAR) instead of tar in makefiles.
Tom Lane [Thu, 25 Jun 2009 23:07:15 +0000 (23:07 +0000)]
Add __attribute__((format_arg(1))) to the declaration of err_gettext(),
to restore gcc's ability to crosscheck format arguments within elog.c.
Noted in a test compilation with -Wformat-nonliteral enabled.
Heikki Linnakangas [Thu, 25 Jun 2009 21:36:00 +0000 (21:36 +0000)]
Fix some serious bugs in archive recovery, now that bgwriter is active
during it:
When bgwriter is active, the startup process can't perform mdsync() correctly
because it won't see the fsync requests accumulated in bgwriter's private
pendingOpsTable. Therefore make bgwriter responsible for the end-of-recovery
checkpoint as well, when it's active.
When bgwriter is active (= archive recovery), the startup process must not
accumulate fsync requests to its own pendingOpsTable, since bgwriter won't
see them there when it performs restartpoints. Make startup process drop its
pendingOpsTable when bgwriter is launched to avoid that.
Update minimum recovery point one last time when leaving archive recovery.
It won't be updated by the end-of-recovery checkpoint because XLogFlush()
sees us as out of recovery already.
This fixes bug #4879 reported by Fujii Masao.
Peter Eisentraut [Thu, 25 Jun 2009 21:15:38 +0000 (21:15 +0000)]
Man pages back to lowercase names, with additional fixup to make the .so
links work.
Tom Lane [Thu, 25 Jun 2009 19:33:25 +0000 (19:33 +0000)]
Make prior patch pgindent-safe.
Heikki Linnakangas [Thu, 25 Jun 2009 19:05:52 +0000 (19:05 +0000)]
The code to unlink dropped relations in FinishPreparedTransaction() was
acting like runs inside WAL recovery, but it doesn't. I must've copy-pasted
this from a redo-function in the relation forks patch. Noticed by Tom Lane
while he was looking through callers of smgrdounlink().
Heikki Linnakangas [Thu, 25 Jun 2009 12:03:11 +0000 (12:03 +0000)]
Disable pg_standby -l option because the backend doesn't expect the recovered
file to be a symlink. We tried to fix this issue with an earlier server-side
patch, but it didn't fix the whole issue.
The same bug is present in older releases as well, but the 8.4 train is
about to leave the station, and I'm not sure if have consensus on whether
we can remove the -l option in back-branches or do we need to attempt a
server-side fix to make symlinking safe.
Patch by Simon Riggs, per discussion on bug identified by Fujii Masao.
Magnus Hagander [Thu, 25 Jun 2009 11:30:08 +0000 (11:30 +0000)]
Disallow empty passwords in LDAP authentication, the same way
we already do it for PAM.
Peter Eisentraut [Wed, 24 Jun 2009 15:16:22 +0000 (15:16 +0000)]
Correct grammar in picksplit debug messages
Magnus Hagander [Wed, 24 Jun 2009 13:46:32 +0000 (13:46 +0000)]
Fix incorrect LDAP example, noted by Tom.
Magnus Hagander [Wed, 24 Jun 2009 13:39:42 +0000 (13:39 +0000)]
parse_ident_usermap() shuold use ereport(LOG) and not ERROR, and put the
return value in the *error_p variable.
Noted by Tom.
Tom Lane [Tue, 23 Jun 2009 20:33:25 +0000 (20:33 +0000)]
Provide a link to the UPDATE reference page in the 'Updating Data'
section of the docs. Per suggestion from Brad Bowman.
Magnus Hagander [Tue, 23 Jun 2009 18:13:23 +0000 (18:13 +0000)]
Properly initialize SSL engines when used from libpq. This is required for
most external engines.
Per report and initial code from Lars Kanis
Tom Lane [Tue, 23 Jun 2009 16:25:02 +0000 (16:25 +0000)]
Fix an ancient error in dist_ps (distance from point to line segment), which
a number of other geometric operators also depend on. It miscalculated the
slope of the perpendicular to the given line segment anytime that slope was
other than 0, infinite, or +/-1. In some cases the error would be masked
because the true closest point on the line segment was one of its endpoints
rather than the intersection point, but in other cases it could give an
arbitrarily bad answer. Per bug #4872 from Nick Roosevelt.
Bug goes clear back to Berkeley days, so patch all supported branches.
Make a couple of cosmetic adjustments while at it.
Tom Lane [Tue, 23 Jun 2009 03:46:00 +0000 (03:46 +0000)]
Fix the makefiles to fail cleanly if Perl is needed but not present. This
used to work as intended, but got broken some time ago (a quoted empty string
is not an empty string), and got broken some more by the changes to generate
ecpg's preproc.y automatically. Given all the unprotected uses of $(PERL)
elsewhere, it seems best to make use of the $(missing) script rather than
trying to ensure each such use is protected individually. Also fix various
bits of documentation that omitted to mention Perl as a requirement for
building from a CVS pull. Per a complaint from Robert Haas.
Marc G. Fournier [Mon, 22 Jun 2009 23:15:02 +0000 (23:15 +0000)]
bundle RC2
Tom Lane [Mon, 22 Jun 2009 20:04:28 +0000 (20:04 +0000)]
For bulk write operations (eg COPY IN), use a ring buffer of 16MB instead
of the 256KB limit originally enforced by a patch committed 2008-11-06.
Per recent test results, the smaller size resulted in an undesirable decrease
in bulk data loading speed, due to COPY processing frequently getting blocked
for WAL flushing. This area might need more tweaking later, but this setting
seems to be good enough for 8.4.
Tom Lane [Mon, 22 Jun 2009 17:54:30 +0000 (17:54 +0000)]
Make to_timestamp and friends skip leading spaces before an integer field,
even when not in FM mode. This improves compatibility with Oracle and with
our pre-8.4 behavior, as per bug #4862.
Brendan Jurd
Add a couple of regression test cases for this. In passing, get rid of the
labeling of the individual test cases; doesn't seem to be good for anything
except causing extra work when inserting a test...
Tom Lane
Peter Eisentraut [Mon, 22 Jun 2009 07:12:50 +0000 (07:12 +0000)]
Add more explicit note that the parameters of MOVE are identical to FETCH.
per David Wheeler
Tom Lane [Mon, 22 Jun 2009 04:37:18 +0000 (04:37 +0000)]
Revert dubious message wording change.
Peter Eisentraut [Sun, 21 Jun 2009 20:15:32 +0000 (20:15 +0000)]
Message fixes
Tom Lane [Sat, 20 Jun 2009 18:45:28 +0000 (18:45 +0000)]
Fix things so that array_agg_finalfn does not modify or free its input
ArrayBuildState, per trouble report from Merlin Moncure. By adopting
this fix, we are essentially deciding that aggregate final-functions
should not modify their inputs ever. Adjust documentation and comments
to match that conclusion.
Peter Eisentraut [Fri, 19 Jun 2009 19:15:13 +0000 (19:15 +0000)]
Extend man page installation hackery so that the man page section is also
fixed up in the .so links.
Peter Eisentraut [Fri, 19 Jun 2009 19:14:25 +0000 (19:14 +0000)]
Don't convert the man page names to lower case, so that the .so links work.
This is pretty much a workaround for incomplete tools, but having the man
page names in upper case looks more natural anyway.
Peter Eisentraut [Fri, 19 Jun 2009 15:28:25 +0000 (15:28 +0000)]
Add manvolnum, so that man pages are generated.
Peter Eisentraut [Thu, 18 Jun 2009 15:10:35 +0000 (15:10 +0000)]
Don't attempt to "rm" directories on uninstall.
Peter Eisentraut [Thu, 18 Jun 2009 14:42:08 +0000 (14:42 +0000)]
Recursive Joins -> Recursive Queries
per Erik Rijkers
Peter Eisentraut [Thu, 18 Jun 2009 14:34:36 +0000 (14:34 +0000)]
Add some more documentation and cross-links on using dblink with SQL/MED.
Peter Eisentraut [Thu, 18 Jun 2009 10:22:09 +0000 (10:22 +0000)]
Refine the use of terminology around bound and unbound cursors and cursor
variables. Remove the confusing term "reference cursor".
Heikki Linnakangas [Thu, 18 Jun 2009 10:08:08 +0000 (10:08 +0000)]
Fix a few errors in comments. Patch by Fujii Masao, plus the one in
visibilitymap.c by me.
Tom Lane [Thu, 18 Jun 2009 01:27:02 +0000 (01:27 +0000)]
Fix the just-reported problem that you can't specify all four trigger event
types in CREATE TRIGGER. While at it, clean up the amazingly tedious and
inextensible way that the trigger event type list was handled. Per report
from Greg Sabino Mullane.
Tom Lane [Wed, 17 Jun 2009 21:58:49 +0000 (21:58 +0000)]
Proofreading for Bruce's recent round of documentation proofreading.
Most of those changes were good, but some not so good ...
Tom Lane [Wed, 17 Jun 2009 16:05:34 +0000 (16:05 +0000)]
ExecAgg() failed to finish running out set-returning functions in the last
aggregated tuple of a run. Per report from Laurenz Albe. This is a new
bug in 8.4, but only because prior versions rejected SRFs in an Agg plan
node altogether.
Peter Eisentraut [Wed, 17 Jun 2009 13:59:28 +0000 (13:59 +0000)]
Add another link of a GUC variable to where it is explained.
Peter Eisentraut [Wed, 17 Jun 2009 13:46:12 +0000 (13:46 +0000)]
Fix typo in error message: tgargv -> tg_argv
Tom Lane [Sun, 14 Jun 2009 00:00:24 +0000 (00:00 +0000)]
Change test tables in copy2 regression test to be temporary tables.
This prevents autovacuum from reclaiming free space in them and causing
the test's output row order to change, which is causing intermittent
bogus failure reports in the buildfarm.
Backpatch to 8.3. The issue exists further back, but since autovacuum was
not on by default before 8.3, it's not a problem for buildfarm testing.
Tom Lane [Sat, 13 Jun 2009 15:42:09 +0000 (15:42 +0000)]
Fix get_sort_group_operators() so that it doesn't think arrays can be grouped
via hashing. Eventually we ought to make that possible, but it won't happen
for 8.4. Per yesterday's report from Robert Haas.
Peter Eisentraut [Sat, 13 Jun 2009 13:43:34 +0000 (13:43 +0000)]
Tweak the display of incoming foreign-key constraints in \d, per discussion
on hackers. Also, take that string out of the translation roster, since
it's now entirely pseudo-SQL.
Tom Lane [Fri, 12 Jun 2009 19:48:53 +0000 (19:48 +0000)]
Improve documentation about GiST opclass support functions.
Dimitri Fontaine
Tom Lane [Fri, 12 Jun 2009 16:17:29 +0000 (16:17 +0000)]
Fix several places where a function was declared static and then defined
without static. Per testing with a compiler that complains about this.
Tom Lane [Fri, 12 Jun 2009 15:53:32 +0000 (15:53 +0000)]
Add info about minimum recommended AIX fix levels, per Laurenz Albe.
Marc G. Fournier [Fri, 12 Jun 2009 05:19:22 +0000 (05:19 +0000)]
time to tag rc1 ...
Bruce Momjian [Fri, 12 Jun 2009 03:09:07 +0000 (03:09 +0000)]
Tighten typedef check for Linux.
Bruce Momjian [Fri, 12 Jun 2009 03:04:48 +0000 (03:04 +0000)]
Mention BSD/OS find_typedef behavior.
Bruce Momjian [Thu, 11 Jun 2009 22:21:44 +0000 (22:21 +0000)]
Document struct/union problem with pgindent.
Tom Lane [Thu, 11 Jun 2009 21:44:26 +0000 (21:44 +0000)]
Update release notes to today.
Tom Lane [Thu, 11 Jun 2009 20:46:11 +0000 (20:46 +0000)]
Revisit AlterTableCreateToastTable's API once again, hoping to make it what
pg_migrator actually needs and not just a partial solution. We have to be
able to specify the OID that the new toast table should be created with.
Tom Lane [Thu, 11 Jun 2009 19:00:15 +0000 (19:00 +0000)]
Remove our inadequate kluge that tried to get AIX's various broken versions
of getaddrinfo() to work. Instead, recommend updating the OS to get a working
version of getaddrinfo. Per recent discussions.
Tom Lane [Thu, 11 Jun 2009 18:30:03 +0000 (18:30 +0000)]
Mark contrib's GiST and GIN opclass support functions as STRICT, for safety.
(Note: GiST penalty functions could possibly be non-strict, but none are at
present.)
Tom Lane [Thu, 11 Jun 2009 17:45:38 +0000 (17:45 +0000)]
Update time zone data files to tzdata release 2009i: DST law changes in
Bangladesh, Egypt, Jordan, Pakistan.
Tom Lane [Thu, 11 Jun 2009 17:25:39 +0000 (17:25 +0000)]
Fix things so that you can still do "select foo()" where foo is a SQL
function returning setof record. This used to work, more or less
accidentally, but I had broken it while extending the code to allow
materialize-mode functions to be called in select lists. Add a regression
test case so it doesn't get broken again. Per gripe from Greg Davidson.
Tom Lane [Thu, 11 Jun 2009 16:14:18 +0000 (16:14 +0000)]
Somebody seems to have thought they could get away without checking for
rsinfo->expectedDesc == NULL in deflist_to_tuplestore(), but that doesn't
look very safe to me. Noted in passing while studying problem report
from Greg Davidson.
Bruce Momjian [Thu, 11 Jun 2009 14:49:15 +0000 (14:49 +0000)]
8.4 pgindent run, with new combined Linux/FreeBSD/MinGW typedef list
provided by Andrew.
Bruce Momjian [Thu, 11 Jun 2009 03:14:08 +0000 (03:14 +0000)]
Add FreeBSD support for find_typedef, per request from Andrew.
Peter Eisentraut [Wed, 10 Jun 2009 23:42:44 +0000 (23:42 +0000)]
Translation updates
Peter Eisentraut [Wed, 10 Jun 2009 23:11:52 +0000 (23:11 +0000)]
Arrange that the string "syntax error" generated by bison is translated.
Tom Lane [Wed, 10 Jun 2009 23:03:32 +0000 (23:03 +0000)]
Fix ill-advised whitespace prettification, per buildfarm.
Peter Eisentraut [Wed, 10 Jun 2009 22:34:11 +0000 (22:34 +0000)]
Clarify to the translator that plpgsql_yyerror() deals with the translation
of "syntax error", not the literal string.
This same change was made in the backend a while ago; but it applies to
plpgsql as well.
Tom Lane [Wed, 10 Jun 2009 22:12:28 +0000 (22:12 +0000)]
Properly mark pg_freespace() function as strict. Also update
uninstall script to match reality.
Peter Eisentraut [Wed, 10 Jun 2009 21:51:56 +0000 (21:51 +0000)]
Clarify error message
Tom Lane [Wed, 10 Jun 2009 21:24:11 +0000 (21:24 +0000)]
Support Kerberos on platforms where libcom_err depends on OpenSSL, as
reportedly is true on OpenBSD. Also support OpenBSD's spelling of
-Wl,--as-needed. Per Simon Bertrang.
Tom Lane [Wed, 10 Jun 2009 20:25:41 +0000 (20:25 +0000)]
Add warning that xpath() doesn't work with non-UTF8 data.
Peter Eisentraut [Wed, 10 Jun 2009 20:02:15 +0000 (20:02 +0000)]
Improve capitalization and punctuation in recently added GiST message.
Tom Lane [Wed, 10 Jun 2009 19:21:37 +0000 (19:21 +0000)]
Add a warning about possible strange behavior of volatile functions
in cursors. This has always been the case, but given the lack of user
complaints about it, I'm not going to bother back-patching this.
Tom Lane [Wed, 10 Jun 2009 18:54:16 +0000 (18:54 +0000)]
Keep rs_startblock the same during heap_rescan, so that a rescan of a SeqScan
node starts from the same place as the first scan did. This avoids surprising
behavior of scrollable and WITH HOLD cursors, as seen in Mark Kirkwood's bug
report of yesterday.
It's not entirely clear whether a rescan should be forced to drop out of the
syncscan mode, but for the moment I left the code behaving the same on that
point. Any change there would only be a performance and not a correctness
issue, anyway.
Back-patch to 8.3, since the unstable behavior was created by the syncscan
patch.
Tom Lane [Wed, 10 Jun 2009 16:31:32 +0000 (16:31 +0000)]
Fix cash_in() to behave properly in locales where frac_digits is zero,
eg Japan. Report and fix by Itagaki Takahiro. Also fix CASHDEBUG printout
format for branches with 64-bit money type, and some minor comment cleanup.
Back-patch to 7.4, because it's broken all the way back.
Bruce Momjian [Wed, 10 Jun 2009 15:13:45 +0000 (15:13 +0000)]
Fix Linux typedef code.
Peter Eisentraut [Wed, 10 Jun 2009 07:03:34 +0000 (07:03 +0000)]
Correct/improve the datetime_precision field in the information schema.
In particular, always show 0 for the date type instead of null, and show
6 (the default) for time, timestamp, and interval without a declared
precision. This is now in fuller conformance with the SQL standard.
Also clarify the documentation about this.
discovered and analyzed by Konstantin Izmailov and Tom Lane
Tom Lane [Wed, 10 Jun 2009 05:05:03 +0000 (05:05 +0000)]
Make handling of INTERVAL DAY TO MINUTE and INTERVAL DAY TO SECOND input
more consistent with other cases, by having an unlabeled integer field
be treated as a number of minutes or seconds respectively. These cases
are outside the spec (which insists on full "dd hh:mm" or "dd hh:mm:ss"
input respectively), so it's not much help to us in deciding what to do.
But with this change, it's uniformly the case that an unlabeled integer
will be considered as being a number of the interval's rightmost field.
The change also takes us back to the 8.3 behavior of throwing error
for certain ambiguous inputs such as INTERVAL '1 2' DAY TO MINUTE.
Per recent discussion.
Tom Lane [Wed, 10 Jun 2009 03:44:35 +0000 (03:44 +0000)]
Ensure xmlFree(NULL) is a no-op instead of a core dump. Per report from
Sergey Burladyan, there are at least some dank corners of libxml2 that
assume this behavior, even though their published documentation suggests
they shouldn't.
This is only really a live problem in 8.3, but the code is still there
for possible debugging use in HEAD, so patch both branches.
Bruce Momjian [Wed, 10 Jun 2009 03:38:32 +0000 (03:38 +0000)]
Fix BSD find_typedef logic.
Bruce Momjian [Wed, 10 Jun 2009 01:51:44 +0000 (01:51 +0000)]
Update pgindent instructions.
Bruce Momjian [Wed, 10 Jun 2009 01:47:59 +0000 (01:47 +0000)]
Document new location for typedef list.
Peter Eisentraut [Tue, 9 Jun 2009 22:00:57 +0000 (22:00 +0000)]
Fix xmlattribute escaping XML special characters twice (bug #4822).
Author: Itagaki Takahiro <itagaki.takahiro@oss.ntt.co.jp>
Tom Lane [Tue, 9 Jun 2009 19:51:00 +0000 (19:51 +0000)]
Mark internal_in as not strict, so that the construct "null::internal"
will throw an error, rather than possibly allowing someone to synthesize
a manual call to an internal-accepting function. As of CVS HEAD and existing
releases, all such functions are either STRICT or careful about null inputs,
so there is no current security issue here. But it seems like a good idea
to lock this down to protect against future mistakes.
In passing, similarly lock down trigger_in, language_handler_in, opaque_in,
and shell_in. These are not believed to present any security risk, but
there's still no good reason to allow nulls of these types to be created.
I left the polymorphic pseudotypes (anyelement etc) alone, since a null
of one of those types doesn't seem to be a problem --- the worst you can
say about it is that it doesn't have an underlying non-polymorphic type.
If we were to make this change during normal development, we'd just
automatically bump catversion for a pg_proc.h change. But since this doesn't
create a compatibility risk and isn't believed to be fixing a live bug, it
seems better not to force a catversion bump in late beta.
Alvaro Herrera [Tue, 9 Jun 2009 19:36:28 +0000 (19:36 +0000)]
Fix typo, per Tom
Tom Lane [Tue, 9 Jun 2009 18:15:04 +0000 (18:15 +0000)]
Switch order of tests to avoid possible Assert failure for
"array_agg_finalfn(null)". We should modify pg_proc entries to prevent this
query from being accepted, but let's just make the function itself secure too.
Per my note of today.
Tom Lane [Tue, 9 Jun 2009 17:41:02 +0000 (17:41 +0000)]
Restore dblink_current_query() to being a C-language function, so as to not
create an ABI break between 8.3 and 8.4. It is still just a wrapper around
the built-in current_query() function, but at a different implementation
level. Per my proposal.
Note: this change doesn't break 8.4beta installations, since their
SQL-language definition of the function still works fine.
Alvaro Herrera [Tue, 9 Jun 2009 16:41:02 +0000 (16:41 +0000)]
Dynamically set a lower bound on autovacuum nap time so that we don't rebuild
the database list too often.
Per bug report from Łukasz Jagiełło and ensuing discussion on
pgsql-performance.
Joe Conway [Tue, 9 Jun 2009 16:35:36 +0000 (16:35 +0000)]
Default client encoding to server encoding for dblink connections. Addresses
issue raised by Ruzsinszky Attila and confirmed by others.
----------------------------------------------------------------------
Tom Lane [Tue, 9 Jun 2009 14:36:06 +0000 (14:36 +0000)]
Fix failure to double-quote function argument names when needed, in
pg_get_function_arguments() and related functions. Per report from
Andreas Nolte.