OSDN Git Service
Deborah Brouwer [Wed, 31 Mar 2021 22:42:30 +0000 (15:42 -0700)]
staging: rtl8723bs: core: add * to block comments
Add * at the beginning of each line in block comments to conform to the
Linux kernel coding style. Issue detected using checkpatch.
Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com>
Link: https://lore.kernel.org/r/bd143fff718849274b065a1c71f1aa7f6fc6f40f.1617229359.git.deborahbrouwer3563@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Deborah Brouwer [Wed, 31 Mar 2021 22:42:29 +0000 (15:42 -0700)]
staging: rtl8723bs: core: add comma within a comment
Add a comma to separate repeated words in a comment. The comma preserves
the meaning of the comment while also stopping the checkpatch warning:
WARNING: Possible repeated word: 'very'.
Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com>
Link: https://lore.kernel.org/r/2944d1a0e8769edb489bb336423625a61d314d05.1617229359.git.deborahbrouwer3563@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Martin Kaiser [Mon, 29 Mar 2021 09:32:15 +0000 (11:32 +0200)]
staging: rtl8188eu: (trivial) remove a duplicate debug print
Keep the one that shows the wakeup capability.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20210329093215.16186-1-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Martin Kaiser [Sun, 28 Mar 2021 17:54:46 +0000 (19:54 +0200)]
staging: rtl8188eu: remove unused function parameter
rtw_usb_if1_init does not use its struct usb_device_id parameter.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20210328175446.28063-1-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Yang Yingliang [Thu, 1 Apr 2021 10:36:45 +0000 (18:36 +0800)]
staging: greybus: camera: Switch to memdup_user_nul()
Use memdup_user_nul() helper instead of open-coding to
simplify the code.
Reported-by: Hulk Robot <hulkci@huawei.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20210401103645.1558813-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Beatriz Martins de Carvalho [Thu, 1 Apr 2021 09:07:54 +0000 (10:07 +0100)]
staging: greybus: arche-platform: Ending line with argument
Remove checkpatch check "CHECK: Lines should not end with a '('"
with argument present in next line.
Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>
Link: https://lore.kernel.org/r/20210401090754.116522-1-martinsdecarvalhobeatriz@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:19 +0000 (15:24 +0100)]
staging: rtl8723bs: remove unused macros in include/drv_types.c
remove declarations of unused macros
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/b405202e5bace2098dd7c787297f700cc1c030e0.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:18 +0000 (15:24 +0100)]
staging: rtl8723bs: include macro in a do - while loop in core/rtw_security.c
fix the following checkpatch warning:
ERROR: Macros with multiple statements should be enclosed
in a do - while loop
2014: FILE: drivers/staging/rtl8723bs/core/rtw_security.c:2014:
+#define ROUND(i, d, s) \
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/0f176b08b7a49d6649ff9d5468bd912e58c1db06.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:17 +0000 (15:24 +0100)]
staging: rtl8723bs: remove unused fields in struct security_priv
remove unused fields in struct security_priv
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/b7ff4cda1cd4cd4e73120f8526ff53a745bcffa8.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:16 +0000 (15:24 +0100)]
staging: rtl8723bs: remove macros updating unused fields in struct security_priv
remove macros updating statistic fields in struct security_priv
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/00c13a16f0034884a916855a7b7d782d6d05d4c1.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:15 +0000 (15:24 +0100)]
staging: rtl8723bs: put parentheses on macros with complex values in include/wifi.h
fix the following checkpatch warnings:
ERROR: Macros with complex values should be enclosed in parentheses
114: FILE: drivers/staging/rtl8723bs/include/wifi.h:114:
+#define SetToDs(pbuf) \
--
ERROR: Macros with complex values should be enclosed in parentheses
122: FILE: drivers/staging/rtl8723bs/include/wifi.h:122:
+#define SetFrDs(pbuf) \
--
ERROR: Macros with complex values should be enclosed in parentheses
132: FILE: drivers/staging/rtl8723bs/include/wifi.h:132:
+#define SetMFrag(pbuf) \
--
ERROR: Macros with complex values should be enclosed in parentheses
137: FILE: drivers/staging/rtl8723bs/include/wifi.h:137:
+#define ClearMFrag(pbuf) \
--
ERROR: Macros with complex values should be enclosed in parentheses
145: FILE: drivers/staging/rtl8723bs/include/wifi.h:145:
+#define ClearRetry(pbuf) \
--
ERROR: Macros with complex values should be enclosed in parentheses
148: FILE: drivers/staging/rtl8723bs/include/wifi.h:148:
+#define SetPwrMgt(pbuf) \
--
ERROR: Macros with complex values should be enclosed in parentheses
153: FILE: drivers/staging/rtl8723bs/include/wifi.h:153:
+#define ClearPwrMgt(pbuf) \
--
ERROR: Macros with complex values should be enclosed in parentheses
156: FILE: drivers/staging/rtl8723bs/include/wifi.h:156:
+#define SetMData(pbuf) \
--
ERROR: Macros with complex values should be enclosed in parentheses
161: FILE: drivers/staging/rtl8723bs/include/wifi.h:161:
+#define ClearMData(pbuf) \
--
ERROR: Macros with complex values should be enclosed in parentheses
164: FILE: drivers/staging/rtl8723bs/include/wifi.h:164:
+#define SetPrivacy(pbuf) \
--
ERROR: Macros with complex values should be enclosed in parentheses
220: FILE: drivers/staging/rtl8723bs/include/wifi.h:220:
+#define SetDuration(pbuf, dur) \
--
ERROR: Macros with complex values should be enclosed in parentheses
224: FILE: drivers/staging/rtl8723bs/include/wifi.h:224:
+#define SetPriority(pbuf, tid) \
--
ERROR: Macros with complex values should be enclosed in parentheses
229: FILE: drivers/staging/rtl8723bs/include/wifi.h:229:
+#define SetEOSP(pbuf, eosp) \
--
ERROR: Macros with complex values should be enclosed in parentheses
232: FILE: drivers/staging/rtl8723bs/include/wifi.h:232:
+#define SetAckpolicy(pbuf, ack) \
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/99d3e605501c1792035e7403d6da86243e6b48cb.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:14 +0000 (15:24 +0100)]
staging: rtl8723bs: remove unused macros in include/wifi.h
remove declarations of unused macros in include/wifi.h
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/1192085c7e891f801751f3adb7884083a2999483.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:13 +0000 (15:24 +0100)]
staging: rtl8723bs: add spaces around operator in include/rtw_pwrctrl.h
fix post-commit hook checkpatch warning:
add a space around that '*'
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/d0695bf94766ee68aba70daaa1cdefff64c38b62.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:12 +0000 (15:24 +0100)]
staging: rtl8723bs: put parentheses on macros with complex values in include/rtw_pwrctrl.h
fix the following checkpatch warnings:
ERROR: Macros with complex values should be enclosed in parentheses
92: FILE: drivers/staging/rtl8723bs/include/rtw_pwrctrl.h:92:
+#define LPS_DELAY_TIME 1*HZ /* 1 sec */
--
ERROR: Macros with complex values should be enclosed in parentheses
244: FILE: drivers/staging/rtl8723bs/include/rtw_pwrctrl.h:244:
+#define rtw_ips_mode_req(pwrctl, ips_mode) \
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/b3b7cf5ae7b0c1c07a629b618fd86a7b89331b33.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:11 +0000 (15:24 +0100)]
staging: rtl8723bs: remove commented code line in os_dep/ioctl_linux.c
remove commented code line using obsolete definitions
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/ed9cab77a9a7dc1bcae4b6a42e16108e7833ac4b.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:10 +0000 (15:24 +0100)]
staging: rtl8723bs: remove unused field in rereg_nd_name_data struct
remove unused field old_ips_mode in struct rereg_nd_name_data
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/e47b4092f12c4930b7185ecdd59b1d0611dd09e7.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:09 +0000 (15:24 +0100)]
staging: rtl8723bs: remove unused macro in include/rtw_pwrctrl.h
remove unused macro reading field ips_mode_req of struct
pwrctrl_priv
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/39805614be82f1fd90ee460ffedb8a7beb99dce9.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:07 +0000 (15:24 +0100)]
staging: rtl8723bs: remove unused macros in include/hal_phy.h
remove declarations of unused macros in include/hal_phy.h
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/a001f2b2b8fb0ffa73ffe2e79f45a4a8e92cdf2a.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:06 +0000 (15:24 +0100)]
staging: rtl8723bs: add spaces around operators in include/hal_data.h
add spaces around operators in a macro
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/4186cc811caa92fe0625d06b3803e73f424059a6.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:05 +0000 (15:24 +0100)]
staging: rtl8723bs: put parentheses on macros with complex values in include/hal_data.h
fix the following checkpatch warning:
ERROR: Macros with complex values should be enclosed in parentheses
49: FILE: drivers/staging/rtl8723bs/include/hal_data.h:49:
+#define CHANNEL_MAX_NUMBER
14+24+21 /* 14 is the max channel number */
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/22c4bc695d3600fcaec18949c7521fa38aa4f4a0.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:04 +0000 (15:24 +0100)]
staging: rtl8723bs: remove unused macros in include/hal_data.h
remove declarations of unused macros in include/hal_data.h
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/5ad16f41ae356e09156a0f3018eef9cffd3c59a7.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:03 +0000 (15:24 +0100)]
staging: rtl8723bs: remove unused macros in include/hal_com_reg.h
remove declarations of unused macros in include/hal_com_reg.h
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/4a5f1016f46ded3fe9b96a85aff3a5a320e29ab9.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:02 +0000 (15:24 +0100)]
staging: rtl8723bs: added spaces around operators in a macro in include/hal_com.h
added spaces around operators in macro expression
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/20e455aef3b24a46dafe32a8bb46804f284e3c1e.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:01 +0000 (15:24 +0100)]
staging: rtl8723bs: put parentheses on macro with complex values in include/hal_com.h
fix the following checkpatch warning:
ERROR: Macros with complex values should be enclosed in parentheses
187: FILE: drivers/staging/rtl8723bs/include/hal_com.h:187:
+#define PageNum_128(_Len)
(u32)(((_Len)>>7) + ((_Len)&0x7F ? 1:0))
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/3d187b860c3a104b00e97543390b2bbe3f2caa24.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Sat, 27 Mar 2021 14:24:00 +0000 (15:24 +0100)]
staging: rtl8723bs: remove unused macros in include/hal_com.h
remove declarations of unused macros in include/hal_com.h
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/3914fc4c7182988c92b794357c7a3e4ef3b484d6.1616854134.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Fri, 26 Mar 2021 17:41:45 +0000 (18:41 +0100)]
Staging: rtl8723bs: remove useless macros
Remove two 'no-op' macros, as well as two related unreferenced macros,
in the staging/rtl8723bs driver.
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210326174145.19427-2-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Fri, 26 Mar 2021 17:41:44 +0000 (18:41 +0100)]
Staging: rtl8723bs: remove obsolete comments
Remove some orphan comments in the staging/rtl8723bs driver
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210326174145.19427-1-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Fri, 26 Mar 2021 18:06:32 +0000 (19:06 +0100)]
staging: rtl8723bs: fix broken indentation
fix indentation broken by patch removing conditional
code blocks checked by unused
CONFIG_INTERRUPT_BASED_TXBCN family defines
Fixes:
65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*)
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/20210326180632.1859-1-fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Edmundo Carmona Antoranz [Sat, 27 Mar 2021 00:17:33 +0000 (18:17 -0600)]
staging: rtl8723bs: hal: remove unused variable in HalBtc8723b1Ant.c
Variable btRssiState in halbtc8723b1ant_ActionWifiConnectedBtAclBusy()
is set but never read. Removing it.
Removing this warning:
drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c:2093:5: warning: variable ‘btRssiState’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Link: https://lore.kernel.org/r/20210327001736.180881-3-eantoranz@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Edmundo Carmona Antoranz [Sat, 27 Mar 2021 00:17:34 +0000 (18:17 -0600)]
staging: rtl8723bs: sdio_ops: removing unused variable
Inside sd_int_dpc(), variable report is set but it's never read.
Getting rid of it.
Removing this warning:
drivers/staging/rtl8723bs/hal/sdio_ops.c:946:30: warning: variable ‘report’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Link: https://lore.kernel.org/r/20210327001736.180881-4-eantoranz@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Julian Braha [Fri, 26 Mar 2021 05:45:33 +0000 (01:45 -0400)]
drivers: staging: netlogic: fix unmet dependency for PHYLIB
When NETLOGIC_XLR_NET is enabled, and NETDEVICES is
disabled, Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for PHYLIB
Depends on [n]: NETDEVICES [=n]
Selected by [y]:
- NETLOGIC_XLR_NET [=y] && STAGING [=y] && CPU_XLR [=y]
This is because NETLOGIC_XLR_NET selects PHYLIB
without selecting or depending on NETDEVICES,
despite PHYLIB depending on NETDEVICES.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
Link: https://lore.kernel.org/r/20210326054533.48751-1-julianbraha@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Wed, 24 Mar 2021 15:50:36 +0000 (16:50 +0100)]
staging: rtl8723bs: remove assignment in condition in os_dep/ioctl_linux.c
fix the following checkpatch warning:
ERROR: do not use assignment in if condition
2607: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2607:
+ if (0 != (ret = rtw_change_ifname(padapter, new_ifname)))
--
ERROR: do not use assignment in if condition
4239: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:4239:
+ if (!(ext = vmalloc(len)))
--
ERROR: do not use assignment in if condition
4253: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:4253:
+ if (!(ext_dbg = vmalloc(len))) {
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/98b58790ae7c791d091b301bccf67a70c41ec599.1616600897.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Wed, 24 Mar 2021 15:50:35 +0000 (16:50 +0100)]
staging: rtl8723bs: remove assignment in condition in os_dep/ioctl_cfg80211.c
fix the following checkpatch warning:
ERROR: do not use assignment in if condition
1440: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:1440:
+ if ((wps_ie = rtw_get_wps_ie(buf, len, NULL, &wps_ielen)))
--
ERROR: do not use assignment in if condition
2465: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2465:
+ if ((pmgntframe = alloc_mgtxmitframe(pxmitpriv)) == NULL)
--
ERROR: do not use assignment in if condition
2937: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2937:
+ if ((pmgntframe = alloc_mgtxmitframe(pxmitpriv)) == NULL) {
--
ERROR: do not use assignment in if condition
3335: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:3335:
+ if (!(ndev = wdev_to_ndev(wdev)))
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/cc687c2ff614da3e110addd1c5cd610e3356cbd7.1616600897.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Aiuto [Wed, 24 Mar 2021 15:50:34 +0000 (16:50 +0100)]
staging: rtl8723bs: remove assignment in condition in core/rtw_ieee80211.c
fix the following checkpatch warning:
ERROR: do not use assignment in if condition
1118: FILE: drivers/staging/rtl8723bs/core/rtw_ieee80211.c:1118:
+ if ((addr = of_get_property(np, "local-mac-address", &len)) &&
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/8e784a7e1407924724c97398af8e5aeb23460612.1616600897.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:56 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in HalBtc8723b2Ant.h
Remove the following unnecessary enum names in
hal/HalBtc8723b2Ant.h:
enum bt_info_src_8723b_2ant
enum bt_8723b_2ant_bt_status
enum bt_8723b_2ant_coex_algo
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-34-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:55 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in odm.h
Remove the following unnecessary enum names or definitions in
hal/odm.h:
enum ODM_Ability_E [definition]
enum odm_ability_e [name]
enum odm_interface_e [name]
enum odm_ic_type_e [name]
enum odm_cut_version_e [name]
enum odm_fab_e [name]
enum odm_rf_path_e [definition]
enum odm_rf_type_e [name]
enum odm_mac_phy_mode_e [definition]
enum odm_bt_coexist_e [definition]
enum odm_operation_mode_e [definition]
enum odm_wireless_mode_e [name]
enum odm_band_type_e [name]
enum odm_sec_chnl_offset_e [definition]
enum odm_security_e [definition]
enum odm_bw_e [name]
enum odm_board_type_e [definition]
enum ODM_Package_TYPE_E [definition]
enum odm_cca_path_e [definition]
enum fat_state_e [definition]
enum ant_div_type_e [name]
enum rt_status [definition]
enum dm_1r_cca_e [name]
enum dm_rf_e [name]
enum dm_swas_e [definition]
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-33-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:54 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in HalPhyRf.h
Remove the following unnecessary enum definition in
hal/HalPhyRf.h:
enum spur_cal_method
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-32-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:53 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in odm_DIG.h
Remove the following unnecessary enum definitions in
hal/odm_DIG.h:
enum dm_dig_op_e
enum ODM_Pause_CCKPD_TYPE
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-31-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:52 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in odm_types.h
Remove the following unnecessary enum definition in
hal/odm_types.h:
enum rt_spinlock_type
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-30-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:51 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in HalBtc8723b1Ant.h
Remove the following unnecessary enum names in
hal/HalBtc8723b1Ant.h:
enum bt_info_src_8723b_1ant
enum bt_8723b_1ant_bt_status
enum bt_8723b_1ant_wifi_status
enum bt_8723b_1ant_coex_algo
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-29-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:50 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in HalBtcOutSrc.h
Remove the following unnecessary enum names or definitions in
hal/HalBtcOutSrc.h:
enum btc_powersave_type [name]
enum btc_bt_reg_type [name]
enum btc_chip_type [name]
enum btc_msg_type [name]
enum btc_dbg_opcode [definition]
enum btc_rssi_state [name]
enum btc_wifi_role [definition]
enum btc_wifi_bw_mode [name]
enum btc_wifi_traffic_dir [name]
enum btc_wifi_pnp [name]
enum bt_wifi_coex_state [definition]
enum btc_get_type [name]
enum btc_set_type [name]
enum btc_dbg_disp_type [name]
enum btc_notify_type_ips [name]
enum btc_notify_type_lps [name]
enum btc_notify_type_scan [name]
enum btc_notify_type_associate [name]
enum btc_notify_type_media_status [name]
enum btc_notify_type_special_packet [name]
enum btc_notify_type_stack_operation [definition]
enum btc_antenna_pos [name]
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-28-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:49 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in odm_interface.h
Remove the following unnecessary enum definition in
hal/odm_interface.h:
enum odm_h2c_cmd
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-27-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:48 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in rtw_efuse.h
Remove the following unnecessary enum name in
include/rtw_efuse.h:
enum _efuse_def_type
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-26-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:47 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in ieee80211.h
Remove the following unnecessary enum names or definitions in
include/ieee80211.h:
enum rateid_idx [name]
enum ratr_table_mode [definition]
enum eap_type [definition]
enum mgn_rate [name]
enum ieee80211_state [definition]
enum rtw_ieee80211_category [name]
enum _public_action [name]
enum rtw_ieee80211_back_parties [definition]
enum rtw_ieee80211_vht_actioncode [definition]
enum secondary_ch_offset [definition]
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-25-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:46 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in hal_com_phycfg.h
Remove the following unnecessary enum names in
include/hal_com_phycfg.h:
enum rf_tx_num
enum _regulation_txpwr_lmt
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-24-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:45 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in HalPwrSeqCmd.h
Remove the following unnecessary enum name in
include/HalPwrSeqCmd.h:
enum pwrseq_cmd_delay_unit
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-23-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:44 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in rtw_rf.h
Remove the following unnecessary enum names or definitions in
include/rtw_rf.h:
enum capability [name]
enum _reg_preamble_mode [name]
enum _rtl8712_rf_mimo_config_ [definition]
enum rf90_radio_path [definition]
enum vht_data_sc [name]
enum protection_mode [definition]
enum rt_rf_type_definition [name]
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-22-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:43 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in rtw_xmit.h
Remove the following unnecessary enum definition in
include/rtw_xmit.h:
enum txdesc_sc
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-21-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:42 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in rtw_mlme_ext.h
Remove the following unnecessary enum names or definitions in
include/rtw_mlme_ext.h:
enum rt_channel_domain [name]
enum rt_channel_domain_2g [name]
enum rt_channel_domain_5g [name]
enum Associated_AP [definition]
enum ht_iot_peer_e [name]
enum scan_state [name]
enum rtw_c2h_event [name]
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-20-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:41 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in hal_phy.h
Remove the following unnecessary enum names or definitions in
include/hal_phy.h:
enum rf_type [name]
enum antenna_path [definition]
enum rf_content [definition]
enum BaseBand_Config_Type [definition]
enum hw_block [definition]
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-19-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:40 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in rtl8723b_hal.h
Remove the following unnecessary enum names in
include/rtl8723b_hal.h:
enum c2h_evt
enum package_type_e
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-18-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:39 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in wifi.h
Remove the following unnecessary enum names or definitions in
include/wifi.h:
enum wifi_frame_type [name]
enum wifi_frame_subtype [name]
enum wifi_reg_domain [definition]
enum p2p_proto_wk_id [definition]
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-17-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:38 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in rtw_wifi_regd.h
Remove the following unnecessary enum definition in
include/rtw_wifi_regd.h:
enum country_code_type_t
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-16-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:37 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in hal_com_h2c.h
Remove the following unnecessary enum definition in
include/hal_com_h2c.h:
enum h2c_cmd
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-15-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:36 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in rtl8723b_cmd.h
Remove the following unnecessary enum name in
include/rtl8723b_cmd.h:
enum h2c_cmd_8723B
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-14-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:35 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in rtw_pwrctrl.h
Remove the following unnecessary enum names in
include/rtw_pwrctrl.h:
enum Power_Mgnt
enum _PS_BBRegBackup_
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-13-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:34 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in hal_intf.h
Remove the following unnecessary enum names or definitions in
include/hal_intf.h:
enum rtl871x_hci_type [name]
enum hw_variables [name]
enum rt_eeprom_type [definition]
enum wowlan_subcode [definition]
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-12-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:33 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in osdep_service.h
Remove the following unnecessary enum definitions in
include/osdep_service.h:
enum mstat_f
enum mstat_status
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-11-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:32 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in rtw_mp.h
Remove the following unnecessary enum definitions in
include/rtw_mp.h:
enum mp_mode
enum mpt_rate_index
enum power_mode
enum ofdm_tx_mode
enum encry_ctrl_state
enum mpt_txpwr_def
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-10-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:31 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in wlan_bssdef.h
Remove the following unnecessary enum names or definitions in
include/wlan_bssdef.h:
enum ndis_802_11_wep_status [name]
enum ndis_802_11_reload_defaults [definition]
enum vrtl_carrier_sense [name]
enum vcs_type [name]
enum uapsd_max_sp [name]
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-9-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:30 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in rtw_ht.h
Remove the following unnecessary enum names in
include/rtw_ht.h:
enum aggre_size_e
enum rt_ht_inf0_capbility
enum rt_ht_inf1_capbility
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-8-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:29 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in drv_types.h
Remove the following unnecessary enum names or definitions in
include/drv_types.h:
enum _nic_version [definition]
enum _iface_type [name]
enum adapter_type [definition]
enum driver_state [name]
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-7-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:28 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in rtw_recv.h
Remove the following unnecessary enum name in
include/rtw_recv.h:
enum rx_packet_type
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-6-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:27 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in hal_com.h
Remove the following unnecessary enum definition in
include/hal_com.h:
enum firmware_source
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-5-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:26 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in rtw_eeprom.h
Remove the following unnecessary enum name
include/rtw_eeprom.h:
enum rt_customer_id
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-4-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:25 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in rtw_cmd.h
Remove the following unnecessary enum names in
include/rtw_cmd.h:
enum rtw_drvextra_cmd_id
enum lps_ctrl_type
enum rfintfs
enum rtw_h2c_cmd
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-3-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marco Cesati [Wed, 24 Mar 2021 12:44:24 +0000 (13:44 +0100)]
Staging: rtl8723bs: remove named enums in rtw_mlme.h
Remove the following unnecessary enum names or definitions in
include/rtw_mlme.h:
enum dot11AuthAlgrthmNum [name]
enum _band [name]
enum DriverInterface [definition]
enum scan_result_type [definition]
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-2-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bruno Raoult [Fri, 26 Mar 2021 09:48:35 +0000 (10:48 +0100)]
r8192U_wx.c: style: avoid multiple blank lines
fix checkpatch.pl check:
CHECK: Please don't use multiple blank lines
in drivers/staging/rtl8192u/r8192U_wx.c
Signed-off-by: Bruno Raoult <braoult@gmail.com>
Link: https://lore.kernel.org/r/2c1f2c668d299ce1895ce97dc7fb9a67d3723e63.1616748922.git.braoult@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bruno Raoult [Fri, 26 Mar 2021 09:48:34 +0000 (10:48 +0100)]
r8192U_wx.c: style: Unnecessary parentheses
fix checkpatch.pl check:
CHECK: Unnecessary parentheses around expr
in drivers/staging/rtl8192u/r8192U_wx.c
Signed-off-by: Bruno Raoult <braoult@gmail.com>
Link: https://lore.kernel.org/r/f42993e183e1127dcc9fce3f0ed42dd6d795c647.1616748922.git.braoult@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bruno Raoult [Fri, 26 Mar 2021 09:48:33 +0000 (10:48 +0100)]
r8192U_wx.c: style: braces all arms of statement
fix checkpatch.pl check:
CHECK: braces {} should be used on all arms of this statement
in drivers/staging/rtl8192u/r8192U_wx.c
Signed-off-by: Bruno Raoult <braoult@gmail.com>
Link: https://lore.kernel.org/r/adbbb5243dca7998a31a786eef277bd85068c63a.1616748922.git.braoult@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bruno Raoult [Fri, 26 Mar 2021 09:48:32 +0000 (10:48 +0100)]
r8192U_wx.c: style: spaces preferred around operators
fix checkpatch.pl check:
CHECK: spaces required around that <op>
in drivers/staging/rtl8192u/r8192U_wx.c
Signed-off-by: Bruno Raoult <braoult@gmail.com>
Link: https://lore.kernel.org/r/e7298c14538ad7a58720585d019a70f637e0cdb1.1616748922.git.braoult@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bruno Raoult [Fri, 26 Mar 2021 09:48:31 +0000 (10:48 +0100)]
r8192U_wx.c: style: alignment with open parenthesis
fix checkpatch.pl check:
CHECK: Alignment should match open parenthesis
in drivers/staging/rtl8192u/r8192U_wx.c
Signed-off-by: Bruno Raoult <braoult@gmail.com>
Link: https://lore.kernel.org/r/34f4134241f49d1694cbfb9c2185e3ef54284680.1616748922.git.braoult@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Swen Kalski [Thu, 25 Mar 2021 13:35:20 +0000 (14:35 +0100)]
Staging: comedi: remove unnecessary else statement
Removal of an unnecessary else in statging/comedi/comedi_buf.c
Add an early Return and removed the unleashed the else condition
for better readability int staging/comedi drivers.
Signed-off-by: Swen Kalski <kalski.swen@gmail.com>
Link: https://lore.kernel.org/r/20210325133520.GA594125@m17r3en
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wan Jiabing [Thu, 25 Mar 2021 08:00:46 +0000 (16:00 +0800)]
drivers: staging: rtl8712: _adapter is declared twice
struct _adapter has been declared at 23rd line.
Remove the duplicate.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Link: https://lore.kernel.org/r/20210325080050.861273-1-wanjiabing@vivo.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Wed, 24 Mar 2021 15:21:35 +0000 (15:21 +0000)]
staging: rtl8188eu: Fix null pointer dereference on free_netdev call
An unregister_netdev call checks if pnetdev is null, hence a later
call to free_netdev can potentially be passing a null pointer, causing
a null pointer dereference. Avoid this by adding a null pointer check
on pnetdev before calling free_netdev.
Fixes:
1665c8fdffbb ("staging: rtl8188eu: use netdev routines for private data")
Reviewed-by: Martin Kaiser <martin@kaiser.cx>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210324152135.254152-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Coiby Xu [Wed, 24 Mar 2021 01:00:01 +0000 (09:00 +0800)]
staging: qlge: deal with the case that devlink_health_reporter_create fails
devlink_health_reporter_create may fail. In that case, do the cleanup
work.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Coiby Xu <coxu@redhat.com>
Link: https://lore.kernel.org/r/20210324010002.109846-1-coxu@redhat.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Fri, 26 Mar 2021 11:09:47 +0000 (12:09 +0100)]
Merge tag 'iio-for-5.13a' of https://git./linux/kernel/git/jic23/iio into staging-next
Jonathan writes:
1st set of IIO/counter device support, features and cleanup in the 5.13 cycle
Big set in here from Alexandru Ardelean enabling multiple buffer support.
This includes providing a new directory per buffer that combines
what was previously in buffer/ and scan_elements/. Old interfaces still
in place for compatiblity.
Note immuatable branch for scmi patches to allow for some significant
rework going on in that subsystem. Merge required updating to reflect
some changes in IIO.
Late rebase to fix some wrong fixes tags due to some earlier rebases
made necessary by messing up the immutable branch.
IIO New Device Support
* adi,ad5686
- Add info to support AD5673R and AD5677R
* bosch,bmi088
- New driver supporting this accelerometer + gyroscope
* cros_ec_mkbp
- New driver for this proximity sensor that exposes a 'front'
sensor. Very simple switch like device, but driver allows it
to share interface with more sophisticated proximity sensors.
* iio_scmi
- New driver to support ARM SCMI protocol to expose underlying
accelerometers and gyroscopes via this firmware interface.
* st,st_magn
- Add ID for IISMDC magnetometer.
* ti,ads131e0
- New driver supporting ads131e04, ads131e06 and ads131e08 24 bit ADCs
Counter New Device Support
* IRQ or GPIO based counter
- New driver for a conceptually simple counter that uses interrupts
to perform the count.
Features
* core
- Dual buffer supprt including:
Various helpers to centralize handling of bufferer related elements.
Document existing and new IOCTLs
Register the IIO chrdev only if it can actually be used for anything.
Rework attribute group creation in the core (lots of patches)
Merge buffer/ and scan_elements/ entries into one list + maintain
backwards compatible set.
Introduce the internal logic and IOCTL to allow multiple buffers
+ access to an anon FD per buffer to actually read from it.
Tidy up tools/iio/iio_generic_buffer and switch to new interfaces.
Update ABI docs.
A few follow up fixes, unsuprising as this was a huge bit of rework.
- Move common case setting of trig->parent to the core.
- Provide an iio_read_channel_processed_scale() to avoid loss of
precision from iio_read_channel_processed() then applying integer
scale. Use it in ntc_thermistor driver in hwmon.
- Allow drivers to specify labels from elsewhere than DT. Use it for
bmc150 and kxcjk-1013 labels related to position on 2 in one tablets.
- Document label usage for proximity and accelerometer sensors.
- Some local variable renames for consistency
tools
- Add -a parameter to iio_event_monitor to allow autoenabling of events.
* acpi_als
- Add trigger support for devices that don't support notification method.
* adi,ad7124
- Allow more than 8 channels. This is a complex little device, but is
capable of supporting up to 16 channels if the share certain
configuration settings.
* hrtimer-trigger
- Support sampling frequency below 1Hz.
* mediatek,mt8195-auxadc
- Add compatible to binding docs (always also includes mt8173)
* st,stm32-adc
- Enable timetamps when not using DMA.
* vishay,vcnl3020
- Sampling frequency control.
Cleanup and minor fixes:
* treewide
- Use some getter and setter functions instead of opencoding.
- Set of fixes for pointless casts in various drivers.
- Avoid wrong kernel-doc marking on comment blocks.
- Fix various other minor kernel-doc issues shown by W=1
* core
- Use a signed temporary for IIO_VAL_FRACTIONAL_LOG2 to avoid odd casts.
- Fix IIO_VAL_FRACTIONAL_LOG2 for values between -1.0 and 0.0
- Add unit tests for iio_format_value()
* docs
- Fix formatting/typos in iio_configfs.rst and buffers.rst
- Add documentation of index in buffers.rst
- Fix scan element description
- Avoid some issues with HTML generation from ABI docs by moving
duplicated defintions to more generic files.
- Drop reference to long dead mailing list.
* 104-quad
- Remove left over deprecated IIO counter ABI.
* adi,adi-axi-adc
- Fix wrong bit of docs.
* adi,ad5791
- Typos
* adi,ad9834
- Switch to device managed functions in probe.
* adi,adis*
- Add and use helpers for locking to reduced duplication.
* adi,adis16480
- Fix calculation of sampling frequency when using pulse per second input.
* adi,adis16475
- Calculate the IMU scaled internal sampling rate and runtime depending
on sysfs based configuration rather than getting from DT. Drop now
unnecessary property from DT bindings doc.
* cros_ec
- Fix result of a series of recent changes that means extended buffer
attributes turn up in the wrong place. Too complex to revert the
various patches unfortunately so this is a bit messy.
* fsl,mma3452
- Indentation cleanup.
* hid-sensors
- Size of storage needs to increase for some parts when using quaternions.
- Move the get sensistivity attribute to hid-sensors-common to reduce
duplication. Enable it for more device types.
- Correctly handle relative sensitivity if reported that way including
documenting the new ABI.
* maxim,max517
- Use device managed functions in probe.
* mediatek,mt6360-adc
- Use asm/unaligned.h instead of directly including
unaligned/be_byteshift.h
* novuton,npcm-adc
- Local lock instead of missusing mlock.
* semtech,sx9500
- Typos
* st,sensor
- typo fix
* st,spear-adc
- Local lock instead of missusing mlock.
* st,stm32-adc
- Long standing HAS_IOMEM dependency fix.
* st,stm32-counter
- Remove left over deprecated IIO counter ABI.
* ti,palmas-adc
- Local lock instead of missusing mlock.
* ti,tmp007
- Switch to device managed functions in probe.
Other
* MAINTAINERS
- Move Peter Meerwald-Stadler to Credits at his request
* tag 'iio-for-5.13a' of https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio: (119 commits)
iio: acpi_als: Add trigger support
iio: acpi_als: Add local variable dev in probe
iio: acpi_als: Add timestamp channel
iio: adc: ad7292: Modify the bool initialization assignment
iio: cros: unify hw fifo attributes without API changes
iio: kfifo: add devm_iio_triggered_buffer_setup_ext variant
iio: event_monitor: Enable events before monitoring
dt-bindings: iio: adc: Add compatible for Mediatek MT8195
iio:magnetometer: Add Support for ST IIS2MDC
dt-bindings: iio: st,st-sensors add IIS2MDC.
staging: iio: ad9832: kernel-doc fixes
iio:dac:max517.c: Use devm_iio_device_register()
iio:cros_ec_sensors: Fix a wrong function name in kernel doc.
iio: buffer: kfifo_buf: kernel-doc, typo in function name.
iio: accel: sca3000: kernel-doc fixes. Missing - and wrong function names.
iio: adc: adi-axi-adc: Drop false marking for kernel-doc
iio: adc: cpcap-adc: kernel-doc fix - that should be _ in structure name
iio: dac: ad5504: fix wrong part number in kernel-doc structure name.
iio: dac: ad5770r: kernel-doc fix case of letter R wrong in structure name
iio: adc: ti-adc084s021: kernel-doc fixes, missing function names
...
Jonathan Cameron [Fri, 26 Mar 2021 10:03:41 +0000 (10:03 +0000)]
Merge remote-tracking branch 'local/ib-iio-scmi-5.12-rc2-take3' into togreg
Updated to use devm_iio_kfifo_buffer_setup() in place of now
removed devm_iio_kfifo_allocate()
Take3 branch because first 2 versions including wrong version of
patch.
Gwendal Grignou [Wed, 17 Mar 2021 07:40:12 +0000 (00:40 -0700)]
iio: acpi_als: Add trigger support
As some firmware does not notify on illuminance changes, add a
trigger to be able to query light via software (sysfs-trigger or
hrtrigger).
Add a hardware trigger set as the default trigger to maintain backward
compatibility.
Check iio_info reports the sensor as buffer capable:
iio:device0: acpi-als (buffer capable)
To test, check we can get data on demand on an Intel based chromebook:
IIO_DEV="iio:device0"
echo 1 > iio_sysfs_trigger/add_trigger
cat trigger2/name > ${IIO_DEV}/trigger/current_trigger
for i in ${IIO_DEV}/scan_elements/*_en ${IIO_DEV}/buffer/enable ; do
echo 1 > $i
done
od -x /dev/${IIO_DEV} &
echo 1 > trigger2/trigger_now
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20210317074012.2336454-4-gwendal@chromium.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Gwendal Grignou [Wed, 17 Mar 2021 07:40:11 +0000 (00:40 -0700)]
iio: acpi_als: Add local variable dev in probe
Use dev = &device->dev in probe routine for clarity.
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20210317074012.2336454-3-gwendal@chromium.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Gwendal Grignou [Wed, 17 Mar 2021 07:40:10 +0000 (00:40 -0700)]
iio: acpi_als: Add timestamp channel
Add timestamp channel in list of channel, to allow retrieving timestamps
when events are produced.
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20210317074012.2336454-2-gwendal@chromium.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Guoqing Chi [Fri, 19 Mar 2021 06:27:06 +0000 (14:27 +0800)]
iio: adc: ad7292: Modify the bool initialization assignment
A bool initializer is best assigned to false rather than 0.
Signed-off-by: Guoqing Chi <chiguoqing@yulong.com>
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Link: https://lore.kernel.org/r/20210319062706.5135-1-chi962464zy@163.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Gwendal Grignou [Thu, 18 Mar 2021 18:48:57 +0000 (11:48 -0700)]
iio: cros: unify hw fifo attributes without API changes
Commit
2e2366c2d141 ("iio: cros_ec: unify hw fifo attributes into the core file")
should be reverted as it set buffer extended attributes at
the wrong place. However, to revert it will requires to revert more
commits:
commit
165aea80e2e2 ("iio: cros_ec: use devm_iio_triggered_buffer_setup_ext()")
commit
21232b4456ba ("iio: buffer: remove iio_buffer_set_attrs() helper")).
and we would still have conflict with more recent development.
commit
ee708e6baacd ("iio: buffer: introduce support for attaching more IIO buffers")
Instead, this commit reverts the first 2 commits without re-adding
iio_buffer_set_attrs() and set the buffer extended attributes at the
right place:
1. Instead of adding has_fw_fifo, deduct it from the configuration:
- EC must support FIFO (EC_FEATURE_MOTION_SENSE_FIFO) set.
- sensors send data a regular interval (accelerometer, gyro,
magnetomer, barometer, light sensor).
- "Legacy accelerometer" is only present on EC without FIFO, so we don't
need to set buffer attributes.
2. devm_iio_triggered_buffer_setup_ext() does not need to be called when
EC does not support FIFO, as there is no FIFO to manage.
3. Use devm_iio_triggered_buffer_setup_ext() when EC has a FIFO to
specify the buffer extended attributes.
Fixes:
2e2366c2d141 ("iio: cros_ec: unify hw fifo attributes into the core file")
Fixes:
165aea80e2e2 ("iio: cros_ec: use devm_iio_triggered_buffer_setup_ext()")
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20210318184857.2679181-1-gwendal@chromium.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Alexandru Ardelean [Thu, 11 Mar 2021 09:10:42 +0000 (11:10 +0200)]
iio: kfifo: add devm_iio_triggered_buffer_setup_ext variant
This is similar to the {devm_}iio_triggered_buffer_setup_ext variants added
via commit
5164c7889857 ("iio: triggered-buffer: add
{devm_}iio_triggered_buffer_setup_ext variants").
These can be used to pass extra buffer attributes to the buffer object.
This is a bit of temporary mechanism (hopefully) so that drivers that want
to allocate a kfifo buffer with extra buffer attributes, don't need to
include 'buffer_impl.h' directly. This can also become an API function (in
it's own right, unfortunately), but it may be a little less bad vs drivers
having to include 'buffer_impl.h'.
So, far the drivers that want to pass buffer attributes, all have to do
with some HW FIFO attributes, so there may be a chance of unifying them
into IIO core somehow (as some standard API). But, until that happens, we
just need to let them register their HW FIFO attributes directly (without
having to let them include 'buffer_impl.h' directly).
Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
Link: https://lore.kernel.org/r/20210311091042.22417-1-aardelean@deviqon.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Linus Walleij [Fri, 19 Mar 2021 13:53:01 +0000 (14:53 +0100)]
iio: event_monitor: Enable events before monitoring
After some painful sessions with a driver that register an
enable/disable sysfs knob (gp2ap002) and manually going
in and enabling the event before monitoring it:
cd /sys/bus/iio/devices/iio\:device2/events
# ls
in_proximity_thresh_either_en
# echo 1 > in_proximity_thresh_either_en
I realized that it's better if the iio_event_monitor is
smart enough to enable all events by itself and disable them
after use, if passed the -a flag familiar from the
iio_generic_buffer tool.
Auto-enabling events depend on the hardware being able
to handle all events at the same time which isn't
necessarily the case, so a command line option is required
for this.
Cc: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20210319135301.542911-1-linus.walleij@linaro.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Seiya Wang [Fri, 19 Mar 2021 02:34:24 +0000 (10:34 +0800)]
dt-bindings: iio: adc: Add compatible for Mediatek MT8195
This commit adds dt-binding documentation of auxadc for Mediatek MT8195 SoC
Platform.
Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
Link: https://lore.kernel.org/r/20210319023427.16711-7-seiya.wang@mediatek.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
LI Qingwu [Wed, 17 Mar 2021 06:39:02 +0000 (06:39 +0000)]
iio:magnetometer: Add Support for ST IIS2MDC
Add support for ST magnetometer IIS2MDC,
an I2C/SPI interface 3-axis magnetometer.
The patch was tested on the instrument with IIS2MDC via I2C interface.
Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
Link: https://lore.kernel.org/r/20210317063902.19300-3-Qing-wu.Li@leica-geosystems.com.cn
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
LI Qingwu [Wed, 17 Mar 2021 06:39:01 +0000 (06:39 +0000)]
dt-bindings: iio: st,st-sensors add IIS2MDC.
Add support for ST magnetometer IIS2MDC,
an I2C/SPI interface 3-axis magnetometer sensor.
The patch was tested on the instrument with IIS2MDC via I2C interface.
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
Link: https://lore.kernel.org/r/20210317063902.19300-2-Qing-wu.Li@leica-geosystems.com.cn
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Mugilraj Dhavachelvan [Mon, 15 Mar 2021 13:37:11 +0000 (19:07 +0530)]
staging: iio: ad9832: kernel-doc fixes
Fixes a W=1 warning.
-Added ``:`` to lock parameter in 'ad9832_state' description.
-It's a reference comment so removed /**
Signed-off-by: Mugilraj Dhavachelvan <dmugil2000@gmail.com>
Link: https://lore.kernel.org/r/20210315133711.26860-1-dmugil2000@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Mugilraj Dhavachelvan [Sun, 14 Mar 2021 17:57:09 +0000 (23:27 +0530)]
iio:dac:max517.c: Use devm_iio_device_register()
Use devm_iio_device_register() to avoid remove function and
drop explicit call to iio_device_unregister().
Signed-off-by: Mugilraj Dhavachelvan <dmugil2000@gmail.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20210314175709.34301-1-dmugil2000@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Jonathan Cameron [Sat, 13 Mar 2021 14:53:41 +0000 (14:53 +0000)]
iio:cros_ec_sensors: Fix a wrong function name in kernel doc.
cros_ec_sensors_read_data_unsafe() had wrong function name in kernel-doc
This shows up with W=1 builds.
No fixes tag because I don't want to waste time on this being
backported.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Guenter Roeck <groeck@chromium.org>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Gwendal Grignou <gwendal@chromium.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Link: https://lore.kernel.org/r/20210313145341.116088-1-jic23@kernel.org
Jonathan Cameron [Sun, 14 Mar 2021 16:46:55 +0000 (16:46 +0000)]
iio: buffer: kfifo_buf: kernel-doc, typo in function name.
Should have been _kfifo_ and was _fifo_
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20210314164655.408461-9-jic23@kernel.org
Jonathan Cameron [Sun, 14 Mar 2021 16:46:54 +0000 (16:46 +0000)]
iio: accel: sca3000: kernel-doc fixes. Missing - and wrong function names.
All extremely obvious so nothing to add to patch title.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20210314164655.408461-8-jic23@kernel.org
Jonathan Cameron [Sun, 14 Mar 2021 16:46:53 +0000 (16:46 +0000)]
iio: adc: adi-axi-adc: Drop false marking for kernel-doc
This comment block isn't in kernel-doc format so drop the /** marking.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20210314164655.408461-7-jic23@kernel.org
Jonathan Cameron [Sun, 14 Mar 2021 16:46:52 +0000 (16:46 +0000)]
iio: adc: cpcap-adc: kernel-doc fix - that should be _ in structure name
Fixes a W=1 warning.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Tony Lindgren <tony@atomide.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20210314164655.408461-6-jic23@kernel.org
Jonathan Cameron [Sun, 14 Mar 2021 16:46:51 +0000 (16:46 +0000)]
iio: dac: ad5504: fix wrong part number in kernel-doc structure name.
Probably a bit of cut and paste where someone forgot to change the
part number.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20210314164655.408461-5-jic23@kernel.org
Jonathan Cameron [Sun, 14 Mar 2021 16:46:50 +0000 (16:46 +0000)]
iio: dac: ad5770r: kernel-doc fix case of letter R wrong in structure name
Nothing useful to add beyond this causing a warning with W=1
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Link: https://lore.kernel.org/r/20210314164655.408461-4-jic23@kernel.org
Jonathan Cameron [Sun, 14 Mar 2021 16:46:49 +0000 (16:46 +0000)]
iio: adc: ti-adc084s021: kernel-doc fixes, missing function names
The documentation in this driver was nearly kernel-doc and was marked
as such. Unfortunately the format was wrong and function names were
missing. This patch puts them in with minor edits to keep the resulting
line short.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: Gwendal Grignou <gwendal@chromium.org>
Cc: Mårten Lindahl <martenli@axis.com>
Link: https://lore.kernel.org/r/20210314164655.408461-3-jic23@kernel.org
Jonathan Cameron [Sun, 14 Mar 2021 16:46:48 +0000 (16:46 +0000)]
iio: pressure: zpa2326: kernel-doc fixes
Two comment blocks had wrong naming for function/structures that they
referred to. Results in warnings when doing a W=1 build.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20210314164655.408461-2-jic23@kernel.org
Oleksij Rempel [Mon, 1 Mar 2021 08:04:01 +0000 (09:04 +0100)]
counter: add IRQ or GPIO based counter
Add simple IRQ or GPIO base counter. This device is used to measure
rotation speed of some agricultural devices, so no high frequency on the
counter pin is expected.
The maximal measurement frequency depends on the CPU and system load. On
the idle iMX6S I was able to measure up to 20kHz without count drops.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Reviewed-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Link: https://lore.kernel.org/r/20210301080401.22190-3-o.rempel@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>