OSDN Git Service

android-x86/bionic.git
9 years agoam 4f11c59b: Merge "Add ndk_missing_symbols.py."
Dan Albert [Thu, 22 Jan 2015 01:31:42 +0000 (01:31 +0000)]
am 4f11c59b: Merge "Add ndk_missing_symbols.py."

* commit '4f11c59b3f3acffe6c8e359296a9e38c4b7edfb6':
  Add ndk_missing_symbols.py.

9 years agoMerge "Add ndk_missing_symbols.py."
Dan Albert [Thu, 22 Jan 2015 01:25:56 +0000 (01:25 +0000)]
Merge "Add ndk_missing_symbols.py."

9 years agoAdd ndk_missing_symbols.py.
Dan Albert [Thu, 22 Jan 2015 00:42:02 +0000 (16:42 -0800)]
Add ndk_missing_symbols.py.

ndk_missing_symbols.py pulls libc.so and libm.so off a running device
or emulator and shows the list of symbols that are in the current
bionic that aren't available on the target.

Change-Id: Ia92c315a6a0ce2e5c33db0b62c8fab41c08a4c31

9 years agoam 2a8c929a: Merge "Implement __fsetlocking."
Elliott Hughes [Wed, 21 Jan 2015 22:58:17 +0000 (22:58 +0000)]
am 2a8c929a: Merge "Implement __fsetlocking."

* commit '2a8c929aaf8d34d2b6e89ed9c8b6da163316143e':
  Implement __fsetlocking.

9 years agoam 8476b8ed: Merge "Contact proper debuggerd when crashing."
Christopher Ferris [Wed, 21 Jan 2015 22:58:11 +0000 (22:58 +0000)]
am 8476b8ed: Merge "Contact proper debuggerd when crashing."

* commit '8476b8ed9e290d79cd00e7801c505268f0e8ec15':
  Contact proper debuggerd when crashing.

9 years agoam fbc70d38: Merge "Report 404 errors from Gerrit and continue."
Dan Albert [Wed, 21 Jan 2015 22:58:07 +0000 (22:58 +0000)]
am fbc70d38: Merge "Report 404 errors from Gerrit and continue."

* commit 'fbc70d3899a58e6aff7d3e94803fcdc80629de5a':
  Report 404 errors from Gerrit and continue.

9 years agoMerge "Implement __fsetlocking."
Elliott Hughes [Wed, 21 Jan 2015 19:42:40 +0000 (19:42 +0000)]
Merge "Implement __fsetlocking."

9 years agoMerge "Contact proper debuggerd when crashing."
Christopher Ferris [Wed, 21 Jan 2015 18:39:59 +0000 (18:39 +0000)]
Merge "Contact proper debuggerd when crashing."

9 years agoImplement __fsetlocking.
Elliott Hughes [Wed, 21 Jan 2015 02:09:05 +0000 (18:09 -0800)]
Implement __fsetlocking.

The old __isthreaded hack was never very useful on Android because all user
code runs in a VM where there are lots of threads running. But __fsetlocking
lets a caller say "I'll worry about the locking for this FILE*", which is
useful for the normal case where you don't share a FILE* between threads
so you don't need any locking.

Bug: 17154740
Bug: 18593728
Change-Id: I2a8dddc29d3edff39a3d7d793387f2253608a68d

9 years agoMerge "Report 404 errors from Gerrit and continue."
Dan Albert [Wed, 21 Jan 2015 18:25:39 +0000 (18:25 +0000)]
Merge "Report 404 errors from Gerrit and continue."

9 years agoReport 404 errors from Gerrit and continue.
Dan Albert [Wed, 21 Jan 2015 17:56:28 +0000 (09:56 -0800)]
Report 404 errors from Gerrit and continue.

Currently, we get a 404 from Gerrit in the event that two projects
have the same Change-Id. We should be able to handle this and actually
cherry-pick each change so we can check multi-project changes, but for
now just skip these changes.

Change-Id: I7bc63208998d58beec83b71b302450d9be3ea026

9 years agoam f3743584: Merge "Fix signed/unsigned comparison that was upsetting clang."
Elliott Hughes [Wed, 21 Jan 2015 02:11:35 +0000 (02:11 +0000)]
am f3743584: Merge "Fix signed/unsigned comparison that was upsetting clang."

* commit 'f374358414812d3e5a45ba75a2b1926693924420':
  Fix signed/unsigned comparison that was upsetting clang.

9 years agoam a779719d: Merge "Add TEMP_FAILURE_RETRY to stdio\'s low-level read/write functions."
Elliott Hughes [Wed, 21 Jan 2015 02:11:34 +0000 (02:11 +0000)]
am a779719d: Merge "Add TEMP_FAILURE_RETRY to stdio\'s low-level read/write functions."

* commit 'a779719d628de5e504dac08d334bc576f3b7fb0a':
  Add TEMP_FAILURE_RETRY to stdio's low-level read/write functions.

9 years agoam 927d8be7: Merge "Fix build error when XLOG is enabled"
Elliott Hughes [Wed, 21 Jan 2015 02:11:33 +0000 (02:11 +0000)]
am 927d8be7: Merge "Fix build error when XLOG is enabled"

* commit '927d8be76d956fcda630e1088e9b89eb31be5146':
  Fix build error when XLOG is enabled

9 years agoam c053a428: Merge "Optimized fread."
Elliott Hughes [Wed, 21 Jan 2015 02:11:32 +0000 (02:11 +0000)]
am c053a428: Merge "Optimized fread."

* commit 'c053a42831165044cca0bb9eb220b8f5d27fdd18':
  Optimized fread.

9 years agoContact proper debuggerd when crashing.
Christopher Ferris [Mon, 19 Jan 2015 19:16:52 +0000 (11:16 -0800)]
Contact proper debuggerd when crashing.

Make the request structure match the new structure found in debuggerd
code.

On 64 bit systems, make sure that the 32 bit compiled linker is contacted.

Bug: https://code.google.com/p/android/issues/detail?id=97024
Change-Id: I675b8ff222fcf836b05de4e9b5976ff91ca929bf

9 years agoMerge "Fix signed/unsigned comparison that was upsetting clang."
Elliott Hughes [Wed, 21 Jan 2015 00:57:06 +0000 (00:57 +0000)]
Merge "Fix signed/unsigned comparison that was upsetting clang."

9 years agoFix signed/unsigned comparison that was upsetting clang.
Elliott Hughes [Wed, 21 Jan 2015 00:52:04 +0000 (16:52 -0800)]
Fix signed/unsigned comparison that was upsetting clang.

bionic/libc/stdio/fread.c:86:27: error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned int') [-Werror,-Wsign-compare]

Change-Id: Ia7e1e053e0cb13113e8f2eede820be013acbab82

9 years agoMerge "Add TEMP_FAILURE_RETRY to stdio's low-level read/write functions."
Elliott Hughes [Wed, 21 Jan 2015 00:50:01 +0000 (00:50 +0000)]
Merge "Add TEMP_FAILURE_RETRY to stdio's low-level read/write functions."

9 years agoAdd TEMP_FAILURE_RETRY to stdio's low-level read/write functions.
Elliott Hughes [Wed, 21 Jan 2015 00:18:32 +0000 (16:18 -0800)]
Add TEMP_FAILURE_RETRY to stdio's low-level read/write functions.

This is correctness rather than performance, but found while investigating
performance.

Bug: 18593728
Change-Id: Idbdfed89d1931fcfae65db29d662108d4bbd9b65

9 years agoMerge "Fix build error when XLOG is enabled"
Elliott Hughes [Wed, 21 Jan 2015 00:13:27 +0000 (00:13 +0000)]
Merge "Fix build error when XLOG is enabled"

9 years agoFix build error when XLOG is enabled
Patrick Tjin [Wed, 21 Jan 2015 00:02:04 +0000 (16:02 -0800)]
Fix build error when XLOG is enabled

(cherrypick of 79a49c9857f3949fc13373eeb179f27b6ecdca81.)

Change-Id: I7bb44fd1fe3ef2ddfc115247f328eccfceeb5352
Signed-off-by: Patrick Tjin <pattjin@google.com>
9 years agoMerge "Optimized fread."
Elliott Hughes [Wed, 21 Jan 2015 00:11:30 +0000 (00:11 +0000)]
Merge "Optimized fread."

9 years agoOptimized fread.
Elliott Hughes [Tue, 20 Jan 2015 19:23:50 +0000 (11:23 -0800)]
Optimized fread.

This makes us competitive with glibc for fully-buffered and unbuffered reads,
except in single-threaded situations where glibc avoids locking, but since
we're never really single-threaded anyway, that isn't a priority.

Bug: 18593728
Change-Id: Ib776bfba422ccf46209581fc0dc54f3567645b8f

9 years agoam d3d75c02: Merge "Remove testcase time printing in bionic-unit-tests."
Yabin Cui [Tue, 20 Jan 2015 23:43:15 +0000 (23:43 +0000)]
am d3d75c02: Merge "Remove testcase time printing in bionic-unit-tests."

* commit 'd3d75c029a9b768989d5370000788dca4032b97a':
  Remove testcase time printing in bionic-unit-tests.

9 years agoMerge "Remove testcase time printing in bionic-unit-tests."
Yabin Cui [Tue, 20 Jan 2015 23:38:34 +0000 (23:38 +0000)]
Merge "Remove testcase time printing in bionic-unit-tests."

9 years agoam 1c01c9f7: Merge "Add target libbionic_gtest_main for cts test."
Yabin Cui [Tue, 20 Jan 2015 22:51:49 +0000 (22:51 +0000)]
am 1c01c9f7: Merge "Add target libbionic_gtest_main for cts test."

* commit '1c01c9f752c07d758349356c18563261b8216da9':
  Add target libbionic_gtest_main for cts test.

9 years agoRemove testcase time printing in bionic-unit-tests.
Yabin Cui [Tue, 20 Jan 2015 22:46:03 +0000 (14:46 -0800)]
Remove testcase time printing in bionic-unit-tests.

Bug: 19075565
Change-Id: Icccb60657a2985e96abb1703673f0ebe2199586a

9 years agoMerge "Add target libbionic_gtest_main for cts test."
Yabin Cui [Tue, 20 Jan 2015 22:44:01 +0000 (22:44 +0000)]
Merge "Add target libbionic_gtest_main for cts test."

9 years agoAdd target libbionic_gtest_main for cts test.
Yabin Cui [Tue, 20 Jan 2015 20:02:21 +0000 (12:02 -0800)]
Add target libbionic_gtest_main for cts test.

Bug: 17589740
Change-Id: I37f2d3fe72870b9dc867407fa1619c9a6fcd5cbb

9 years agoam 1d7b3f3c: Merge "Improve <stdio_ext.h> testing."
Elliott Hughes [Tue, 20 Jan 2015 18:27:47 +0000 (18:27 +0000)]
am 1d7b3f3c: Merge "Improve <stdio_ext.h> testing."

* commit '1d7b3f3ccc4f2883cbc0fe677dff888c56c18996':
  Improve <stdio_ext.h> testing.

9 years agoMerge "Improve <stdio_ext.h> testing."
Elliott Hughes [Tue, 20 Jan 2015 18:07:36 +0000 (18:07 +0000)]
Merge "Improve <stdio_ext.h> testing."

9 years agoam 3bbf4639: Merge "Add a benchmark for using stdio to read a file in /proc."
Elliott Hughes [Sat, 17 Jan 2015 01:42:16 +0000 (01:42 +0000)]
am 3bbf4639: Merge "Add a benchmark for using stdio to read a file in /proc."

* commit '3bbf4639080bc2f42435b4a7fd400c44aab7fd70':
  Add a benchmark for using stdio to read a file in /proc.

9 years agoMerge "Add a benchmark for using stdio to read a file in /proc."
Elliott Hughes [Sat, 17 Jan 2015 01:24:43 +0000 (01:24 +0000)]
Merge "Add a benchmark for using stdio to read a file in /proc."

9 years agoAdd a benchmark for using stdio to read a file in /proc.
Elliott Hughes [Sat, 17 Jan 2015 01:08:31 +0000 (17:08 -0800)]
Add a benchmark for using stdio to read a file in /proc.

Change-Id: I12517aae19e36b7c022a11e8807aece61bb0cb9c

9 years agoImprove <stdio_ext.h> testing.
Elliott Hughes [Sat, 17 Jan 2015 00:40:55 +0000 (16:40 -0800)]
Improve <stdio_ext.h> testing.

I almost fixed a non-bug. Add a test to prevent me from doing that.

Change-Id: I4a1dc13e603a7a377bdaee2e78132015087f7107

9 years agoam 481cf21e: Merge "Use SI prefixes throughout the benchmark output."
Elliott Hughes [Sat, 17 Jan 2015 00:27:58 +0000 (00:27 +0000)]
am 481cf21e: Merge "Use SI prefixes throughout the benchmark output."

* commit '481cf21e08a6cbbc686487744f1cb07b6d3f400e':
  Use SI prefixes throughout the benchmark output.

9 years agoMerge "Use SI prefixes throughout the benchmark output."
Elliott Hughes [Sat, 17 Jan 2015 00:23:34 +0000 (00:23 +0000)]
Merge "Use SI prefixes throughout the benchmark output."

9 years agoam cfe7e75f: Merge "Make sys_resource test more robust."
Yabin Cui [Fri, 16 Jan 2015 21:57:33 +0000 (21:57 +0000)]
am cfe7e75f: Merge "Make sys_resource test more robust."

* commit 'cfe7e75fc13afb987d86aaaee305040f3369f797':
  Make sys_resource test more robust.

9 years agoMerge "Make sys_resource test more robust."
Yabin Cui [Fri, 16 Jan 2015 21:52:11 +0000 (21:52 +0000)]
Merge "Make sys_resource test more robust."

9 years agoMake sys_resource test more robust.
Yabin Cui [Mon, 5 Jan 2015 19:06:30 +0000 (11:06 -0800)]
Make sys_resource test more robust.

"ulimit -c xxx" command may run before bionic-unit-tests.
Make sure sys_resource test fails gently in that case.

Change-Id: Ic3b5ed8b20acba56df8c5ef082c88e5050e761aa

9 years agoUse SI prefixes throughout the benchmark output.
Elliott Hughes [Fri, 16 Jan 2015 21:11:25 +0000 (13:11 -0800)]
Use SI prefixes throughout the benchmark output.

Also switch throughput to GiB/s. I did play with using the new code,
but having consistent units for all results seemed easier to use
anyway (and doesn't require extra code).

Change-Id: I466fd573373bd05619e6f6e6d3dedd7dae0d9362

9 years agoam ffad8df6: Merge "Use a vector of benchmarks and new for loop syntax."
Elliott Hughes [Fri, 16 Jan 2015 03:27:04 +0000 (03:27 +0000)]
am ffad8df6: Merge "Use a vector of benchmarks and new for loop syntax."

* commit 'ffad8df672363bad43528898cc47aa2ed3d08c66':
  Use a vector of benchmarks and new for loop syntax.

9 years agoMerge "Use a vector of benchmarks and new for loop syntax."
Elliott Hughes [Fri, 16 Jan 2015 03:22:40 +0000 (03:22 +0000)]
Merge "Use a vector of benchmarks and new for loop syntax."

9 years agoUse a vector of benchmarks and new for loop syntax.
Elliott Hughes [Fri, 16 Jan 2015 01:10:42 +0000 (17:10 -0800)]
Use a vector of benchmarks and new for loop syntax.

Change-Id: Ib1f1250e7786770083ed6a478677a893b2075a93

9 years agoam 594db0f1: Merge "bionic benchmarks: limit benchmark run time to 1s real time"
Elliott Hughes [Fri, 16 Jan 2015 00:48:36 +0000 (00:48 +0000)]
am 594db0f1: Merge "bionic benchmarks: limit benchmark run time to 1s real time"

* commit '594db0f1b235306d2687395564745888348df808':
  bionic benchmarks: limit benchmark run time to 1s real time

9 years agoMerge "bionic benchmarks: limit benchmark run time to 1s real time"
Elliott Hughes [Fri, 16 Jan 2015 00:44:16 +0000 (00:44 +0000)]
Merge "bionic benchmarks: limit benchmark run time to 1s real time"

9 years agoam 3159972a: Merge "bionic benchmarks: export benchmark library"
Elliott Hughes [Fri, 16 Jan 2015 00:42:43 +0000 (00:42 +0000)]
am 3159972a: Merge "bionic benchmarks: export benchmark library"

* commit '3159972a80234f7a8e3903cefaeb7719a50f6279':
  bionic benchmarks: export benchmark library

9 years agobionic benchmarks: limit benchmark run time to 1s real time
Colin Cross [Thu, 28 Nov 2013 01:37:54 +0000 (17:37 -0800)]
bionic benchmarks: limit benchmark run time to 1s real time

The benchmark run loop tries to run until 1s of time has been
accumulated between StartBenchmarkTiming() and StopBenchmarkTiming().
If a majority of the time is spent stopped this can lead to
benchmarks running for very long periods of time.  This can easily
happen when benchmarking something that requires initialization or
cleanup on each iteration.

Modify the loop to run for 1s of real time instead of 1s of
benchmark time.  For existing benchmarks this shouldn't make much
of a difference.

Change-Id: Iaba8a13b4dfc4a5e2cd9992041c9173ea556f9cc

9 years agoMerge "bionic benchmarks: export benchmark library"
Elliott Hughes [Fri, 16 Jan 2015 00:36:19 +0000 (00:36 +0000)]
Merge "bionic benchmarks: export benchmark library"

9 years agobionic benchmarks: export benchmark library
Colin Cross [Fri, 15 Nov 2013 22:34:22 +0000 (14:34 -0800)]
bionic benchmarks: export benchmark library

Export libbenchmark for external projects to write benchmarks against.

Change-Id: I3b04a56a62ce517afc0d5e06dc8d28879ada3d30

9 years agoam 6fac2f68: Merge "Fix possible leak in pthread_detach."
Yabin Cui [Thu, 15 Jan 2015 19:43:52 +0000 (19:43 +0000)]
am 6fac2f68: Merge "Fix possible leak in pthread_detach."

* commit '6fac2f680f829570122276dc6876f02350a652b1':
  Fix possible leak in pthread_detach.

9 years agoMerge "Fix possible leak in pthread_detach."
Yabin Cui [Thu, 15 Jan 2015 19:35:38 +0000 (19:35 +0000)]
Merge "Fix possible leak in pthread_detach."

9 years agoam deab11ac: Merge "Make bionic-unit-tests default run isolate mode."
Yabin Cui [Thu, 15 Jan 2015 19:10:33 +0000 (19:10 +0000)]
am deab11ac: Merge "Make bionic-unit-tests default run isolate mode."

* commit 'deab11acd7000573ad9c034e5bf9475aadbc5cbe':
  Make bionic-unit-tests default run isolate mode.

9 years agoFix possible leak in pthread_detach.
Yabin Cui [Thu, 18 Dec 2014 22:22:09 +0000 (14:22 -0800)]
Fix possible leak in pthread_detach.

If pthread_detach() is called while the thread is in pthread_exit(),
it takes the risk that no one can free the pthread_internal_t.
So I add PTHREAD_ATTR_FLAG_ZOMBIE to detect this, maybe very rare, but
both glibc and netbsd libpthread have similar function.

Change-Id: Iaa15f651903b8ca07aaa7bd4de46ff14a2f93835

9 years agoMerge "Make bionic-unit-tests default run isolate mode."
Yabin Cui [Thu, 15 Jan 2015 18:10:30 +0000 (18:10 +0000)]
Merge "Make bionic-unit-tests default run isolate mode."

9 years agoam fcc6fd35: Merge "Refactoring: move mips reloc to separate method"
Dmitriy Ivanov [Thu, 15 Jan 2015 18:01:49 +0000 (18:01 +0000)]
am fcc6fd35: Merge "Refactoring: move mips reloc to separate method"

* commit 'fcc6fd35dfa88e659aa1769d1a1351ad74278763':
  Refactoring: move mips reloc to separate method

9 years agoMerge "Refactoring: move mips reloc to separate method"
Dmitriy Ivanov [Thu, 15 Jan 2015 17:56:36 +0000 (17:56 +0000)]
Merge "Refactoring: move mips reloc to separate method"

9 years agoRefactoring: move mips reloc to separate method
Dmitriy Ivanov [Wed, 14 Jan 2015 19:36:38 +0000 (11:36 -0800)]
Refactoring: move mips reloc to separate method

Change-Id: I712614853e3f0e515f5c2bdd8f0aaa5feeae8e55

9 years agoam ffa2c9ed: Merge "Refactoring: unify relocate function"
Dmitriy Ivanov [Wed, 14 Jan 2015 18:19:37 +0000 (18:19 +0000)]
am ffa2c9ed: Merge "Refactoring: unify relocate function"

* commit 'ffa2c9edb5b1cf295bceffc7876a68747b6fa259':
  Refactoring: unify relocate function

9 years agoMerge "Refactoring: unify relocate function"
Dmitriy Ivanov [Wed, 14 Jan 2015 18:14:30 +0000 (18:14 +0000)]
Merge "Refactoring: unify relocate function"

9 years agoam 2b15f54a: Merge "bionic: libc: Added path to root ramdisk build properties file."
Andres Morales [Wed, 14 Jan 2015 15:59:03 +0000 (15:59 +0000)]
am 2b15f54a: Merge "bionic: libc: Added path to root ramdisk build properties file."

* commit '2b15f54a489d84d9a273025b615cdb63f63d5fc9':
  bionic: libc: Added path to root ramdisk build properties file.

9 years agoMerge "bionic: libc: Added path to root ramdisk build properties file."
Andres Morales [Wed, 14 Jan 2015 15:54:03 +0000 (15:54 +0000)]
Merge "bionic: libc: Added path to root ramdisk build properties file."

9 years agoam 85747809: Merge "Test that ip6-localhost exists in etc/hosts."
Yabin Cui [Wed, 14 Jan 2015 12:00:21 +0000 (12:00 +0000)]
am 85747809: Merge "Test that ip6-localhost exists in etc/hosts."

* commit '85747809b05a5e3b48bd4da9a7ea98d0adf8f919':
  Test that ip6-localhost exists in etc/hosts.

9 years agoam a23569c9: Merge "Refactoring: use generic reloc constants"
Dmitriy Ivanov [Wed, 14 Jan 2015 12:00:19 +0000 (12:00 +0000)]
am a23569c9: Merge "Refactoring: use generic reloc constants"

* commit 'a23569c9485d50e9184dcc7d97640140015b3f3d':
  Refactoring: use generic reloc constants

9 years agoam d986f2e4: Merge "Sync with upstream OpenBSD stdio."
Elliott Hughes [Wed, 14 Jan 2015 12:00:18 +0000 (12:00 +0000)]
am d986f2e4: Merge "Sync with upstream OpenBSD stdio."

* commit 'd986f2e4642a0571754cb1349101acf8ac10b484':
  Sync with upstream OpenBSD stdio.

9 years agoRefactoring: unify relocate function
Dmitriy Ivanov [Tue, 13 Jan 2015 20:12:38 +0000 (12:12 -0800)]
Refactoring: unify relocate function

  Use one relocate for all platforms.

Change-Id: I43e75162c5b29105e651defc11a511e168368736

9 years agobionic: libc: Added path to root ramdisk build properties file.
Andres Morales [Wed, 14 Jan 2015 02:00:56 +0000 (18:00 -0800)]
bionic: libc: Added path to root ramdisk build properties file.

Change-Id: Id850e4e5ef4e91cea7ad53f6858886daf660eeec

9 years agoMerge "Test that ip6-localhost exists in etc/hosts."
Yabin Cui [Wed, 14 Jan 2015 01:50:20 +0000 (01:50 +0000)]
Merge "Test that ip6-localhost exists in etc/hosts."

9 years agoMerge "Refactoring: use generic reloc constants"
Dmitriy Ivanov [Wed, 14 Jan 2015 01:34:30 +0000 (01:34 +0000)]
Merge "Refactoring: use generic reloc constants"

9 years agoTest that ip6-localhost exists in etc/hosts.
Yabin Cui [Tue, 13 Jan 2015 22:35:15 +0000 (14:35 -0800)]
Test that ip6-localhost exists in etc/hosts.

Addition change: make netdb_test pass on host.

Bug: 18791191
Change-Id: I7a9e29aa559ff6557288b47323d8a436379201a2

9 years agoMerge "Sync with upstream OpenBSD stdio."
Elliott Hughes [Wed, 14 Jan 2015 01:27:37 +0000 (01:27 +0000)]
Merge "Sync with upstream OpenBSD stdio."

9 years agoSync with upstream OpenBSD stdio.
Elliott Hughes [Wed, 14 Jan 2015 01:19:21 +0000 (17:19 -0800)]
Sync with upstream OpenBSD stdio.

Mainly to get the __atexit_register_cleanup removals we suggested.

Change-Id: I58d40b8c5b8401bfb6bfffe8f3430ac0718af917

9 years agoRefactoring: use generic reloc constants
Dmitriy Ivanov [Tue, 13 Jan 2015 20:17:31 +0000 (12:17 -0800)]
Refactoring: use generic reloc constants

Change-Id: I94dd6256b1b4509b6ea696a3aff17a3991529468

9 years agoam b13f5f50: Merge "Revert "Refactoring: use generic reloc constants""
Dimitry Ivanov [Tue, 13 Jan 2015 23:20:28 +0000 (23:20 +0000)]
am b13f5f50: Merge "Revert "Refactoring: use generic reloc constants""

* commit 'b13f5f5029d5fab190a4480ea3caa623328c5415':
  Revert "Refactoring: use generic reloc constants"

9 years agoam 684a861b: Merge "Refactoring: use generic reloc constants"
Dmitriy Ivanov [Tue, 13 Jan 2015 23:20:27 +0000 (23:20 +0000)]
am 684a861b: Merge "Refactoring: use generic reloc constants"

* commit '684a861bab72b8ec27b41f221982d434b40dcbfe':
  Refactoring: use generic reloc constants

9 years agoMerge "Revert "Refactoring: use generic reloc constants""
Dimitry Ivanov [Tue, 13 Jan 2015 22:32:48 +0000 (22:32 +0000)]
Merge "Revert "Refactoring: use generic reloc constants""

9 years agoRevert "Refactoring: use generic reloc constants"
Dimitry Ivanov [Tue, 13 Jan 2015 22:31:54 +0000 (22:31 +0000)]
Revert "Refactoring: use generic reloc constants"

This reverts commit 265a60a0d285a733d9d98f53672bce668803b434.

Change-Id: I6d46db0ac03cda44ed1e20f6084a552e0089eb14

9 years agoMerge "Refactoring: use generic reloc constants"
Dmitriy Ivanov [Tue, 13 Jan 2015 22:21:04 +0000 (22:21 +0000)]
Merge "Refactoring: use generic reloc constants"

9 years agoRefactoring: use generic reloc constants
Dmitriy Ivanov [Tue, 13 Jan 2015 20:17:31 +0000 (12:17 -0800)]
Refactoring: use generic reloc constants

Change-Id: I67918a1a926164a38a5a47f2264390632eb42905

9 years agoam 5a388898: Merge "Check the committer rather than the Gerrit owner."
Dan Albert [Tue, 13 Jan 2015 01:05:43 +0000 (01:05 +0000)]
am 5a388898: Merge "Check the committer rather than the Gerrit owner."

* commit '5a388898cfa9befb7626dfcd9940713ce942cadd':
  Check the committer rather than the Gerrit owner.

9 years agoMerge "Check the committer rather than the Gerrit owner."
Dan Albert [Tue, 13 Jan 2015 00:58:30 +0000 (00:58 +0000)]
Merge "Check the committer rather than the Gerrit owner."

9 years agoCheck the committer rather than the Gerrit owner.
Dan Albert [Tue, 13 Jan 2015 00:23:53 +0000 (16:23 -0800)]
Check the committer rather than the Gerrit owner.

Guarding based on the Gerrit owner can be circumvented by an arbitrary
user uploading a different patch with a Change-Id that is non-unique,
with the other copy being owned by a Googler.

Change-Id: I5414b679e361d4c38d70bf9c4516c122f668fc49

9 years agoam 8d50e16a: Merge "Guard against @google.com.example.com."
Dan Albert [Mon, 12 Jan 2015 21:52:52 +0000 (21:52 +0000)]
am 8d50e16a: Merge "Guard against @google.com.example.com."

* commit '8d50e16aa96291612c95f89b49ecfacf556241a6':
  Guard against @google.com.example.com.

9 years agoMerge "Guard against @google.com.example.com."
Dan Albert [Mon, 12 Jan 2015 21:49:05 +0000 (21:49 +0000)]
Merge "Guard against @google.com.example.com."

9 years agoGuard against @google.com.example.com.
Dan Albert [Mon, 12 Jan 2015 20:25:31 +0000 (12:25 -0800)]
Guard against @google.com.example.com.

Begin adding some unit tests. Testing the Jenkins interface will
probably be difficult, but testing that we can properly handle
messages from Gerrit is easy enough.

Change-Id: Id7e8e175e0f064fd10715febe40040a65564c701

9 years agoam 780ea474: Merge "Oops. Fix dict key."
Dan Albert [Mon, 12 Jan 2015 20:04:11 +0000 (20:04 +0000)]
am 780ea474: Merge "Oops. Fix dict key."

* commit '780ea47482854e1b58931bea928bf93bcaf6e3aa':
  Oops. Fix dict key.

9 years agoMerge "Oops. Fix dict key."
Dan Albert [Mon, 12 Jan 2015 19:59:28 +0000 (19:59 +0000)]
Merge "Oops. Fix dict key."

9 years agoOops. Fix dict key.
Dan Albert [Mon, 12 Jan 2015 19:56:41 +0000 (11:56 -0800)]
Oops. Fix dict key.

Change-Id: Ia8295417d4097f38eef633089cb4539b849f3c74

9 years agoam 0d0188b0: Merge "Only build changes that come from @google.com."
Dan Albert [Mon, 12 Jan 2015 19:55:19 +0000 (19:55 +0000)]
am 0d0188b0: Merge "Only build changes that come from @google.com."

* commit '0d0188b0c7e017e431c83b2f7e4956137430b6d9':
  Only build changes that come from @google.com.

9 years agoMerge "Only build changes that come from @google.com."
Dan Albert [Mon, 12 Jan 2015 19:51:39 +0000 (19:51 +0000)]
Merge "Only build changes that come from @google.com."

9 years agoOnly build changes that come from @google.com.
Dan Albert [Sat, 10 Jan 2015 18:38:53 +0000 (10:38 -0800)]
Only build changes that come from @google.com.

Googlers should be able to tell the buildbot to launch builds for an
external contributor's change, but Gerrit is determined to make this
hard for us. The email sent by Gerrit for comments doesn't actually
contain the email address of the commenter in any clear way, only the
name. It does however contain a list of `Gerrit-Reviewer: Name
<email>` entries that could be used for this though.

Change-Id: Iee61f06dcd8f0024f16b535ea9a34765bf01b2e7

9 years agoam d7f935a0: Merge "Make indentation match the style guide."
Dan Albert [Sat, 10 Jan 2015 06:49:29 +0000 (06:49 +0000)]
am d7f935a0: Merge "Make indentation match the style guide."

* commit 'd7f935a05b25d003a721565ba64a015b3a341fbe':
  Make indentation match the style guide.

9 years agoMerge "Make indentation match the style guide."
Dan Albert [Sat, 10 Jan 2015 06:45:20 +0000 (06:45 +0000)]
Merge "Make indentation match the style guide."

9 years agoam c80eb091: Merge "Clean up paths.h."
Yabin Cui [Sat, 10 Jan 2015 05:24:53 +0000 (05:24 +0000)]
am c80eb091: Merge "Clean up paths.h."

* commit 'c80eb091a4c090d1162959e08921f8989b3dc355':
  Clean up paths.h.

9 years agoMerge "Clean up paths.h."
Yabin Cui [Sat, 10 Jan 2015 05:17:29 +0000 (05:17 +0000)]
Merge "Clean up paths.h."

9 years agoClean up paths.h.
Yabin Cui [Thu, 8 Jan 2015 04:36:20 +0000 (20:36 -0800)]
Clean up paths.h.

Bug: 18905946
Change-Id: I02cd1ddd5c0b0af165685413bc1fb12ca6bf5f33

9 years agoMake indentation match the style guide.
Dan Albert [Sat, 10 Jan 2015 01:22:00 +0000 (17:22 -0800)]
Make indentation match the style guide.

Apparently Google abandoned the 2 space indent for Python long ago.
Helps to actually read the style guide before trying to adhere to it.

Change-Id: I4feb019f0916f9d8e4f78c0dbeafbe45d8a46bfd

9 years agoam 7e3766a8: Merge "Use relative imports."
Dan Albert [Sat, 10 Jan 2015 01:02:45 +0000 (01:02 +0000)]
am 7e3766a8: Merge "Use relative imports."

* commit '7e3766a8fcc534d92a6f7416fcbbdc092756e415':
  Use relative imports.

9 years agoMerge "Use relative imports."
Dan Albert [Sat, 10 Jan 2015 00:58:12 +0000 (00:58 +0000)]
Merge "Use relative imports."