QEasingCurve::valueForProgress() optimization

doing qreal (either float or double) math on demand is much more optimal,
also reducing the switches to one is a bonus

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QEasingCurve::InCurve, QEasingCurve::OutCurve, QEasingCurve::SineCurve and QEasingCurve::CosineCurve are deffinetly not internal

used by plasma system-monitor applet for example

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QEasingCurve documentation review

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

call FatalSignalHandler constructor

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QOpacityEffect review

by starting the elapsed timer just before the fade timer the opacity
transition will be smoother at the start of the effect

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

explicitly convert the elapsed time to double

QElapsedTimer::elapsed() returns qint64 btw

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

do not send move and resize events to the widget from qFadeEffect()

the position and size of the widget matter not to the effect

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

drop effects other than fade

QComboBox animation was essentially non-operational (see
5b5fbca2ed070acc4ed37fe20fc1d16532469aef), UI_AnimateToolBox was just
reserved and unused . there is fade effect for QMenu and QToolTip so
the relevant effect is there

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QOpacityEffect optimization

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

set the global static variables before deleting the effect instances in qScrollEffect() and qFadeEffect()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

snapshot the widget as QImage from QRollEffect

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove declaration of now non-existing QRollEffect::run() method

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

actually animate QComboBox

for some reason the code for it was Q_WS_WIN && !QT_NO_EFFECTS guarded and
I purged Q_WS_WIN code programatically

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

merge QRollEffect::run() into QRollEffect constructor

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

cancel the opacity/fade effect when the widget is destroyed

widgets are supposed to call qFadeEffect(0) to cancel the effect but just
in case

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

fade effect class rewrite to not use QWidget and event filter

since the effect sets a X11 window property the only thing it has to care
about is if the widget pointer is valid and the elapsed time. moving,
resizing the widget, etc. do not matter

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused graphics effects feature

doubles as performance optimzation

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

trc man page correction

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

apply style from settings only if it is not empty and the style override is empty from QApplicationPrivate::x11_apply_settings()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QApplication::setStyle() documentation update

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

optimize QAlphaWidget (fade effect) further by using window opacity

relies solely on the compositor for it and assumes window opacity is not
set by the user, Katana has animation override
(_KDE_NET_WM_SKIP_CLOSE_ANIMATION X11 atom) and the Katie fade effect
should probably have such (or just check if the opacity value is not 1.0
before running the effect) because effects may overlap with window manager
/compositor effects resulting in all sort of bad things

for that reason I am considering dropping the effects that alter the way
windows/widgets show, hide, are moved, etc. altogether and leaving that
to the window manager/compositor. effects such as colorization of pixmap
and grayscaling (used in QIcon) however are unlikely to be removed

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

optimize QAlphaWidget by avoiding QImage to QPixmap conversion

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

use icons from the system in scripttools component

less static data in the library and better looks - can't go wrong with that

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused scripttools component images

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused qicon header inclusion in qscriptbreakpointsmodel source file

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

correct indendation in QKeyMapper::translateKeyEvent()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

fix ODR-violation in md5c and sha2 source files

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove qbitmap source file from the unity exclude list

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

simplify QKeyMapper::clearMappings() and do not use the cached locale codec

since it is known what locale the X11 input method uses it is redundant to
verify that via XLocaleOfIM() (unless X11 fails to detect what locale is
set for some strange reason).

also not using the cached codec returned by QTextCodec::codecForLocale()
because the locale may change at any time (either environment variable
change or just plain setlocale() call as was done by KCatalog as gettext
workaround) and QKeyMapper has to reflect such changes

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QFontDatabase optimizations

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

do not set the internal QApplicationPrivate::styleOverride from QApplicationPrivate::x11_apply_settings()

the style name is either from the settings or the platform plugin, not from
-style argument

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

show preview even of the desktop style

the desktop style is now determined by QT_PLATFORM_PLUGIN and
DESKTOP_SESSION environment variables with fallback to cleanlooks style so
even if it is the fallback style there is something to show but if it is
not the fallback the user will be able to preview the style chosen by
QGuiPlatformPlugin

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

lock QSettings files via flock()

now QSettings will behave much like opening a file via open() and the like,
see the QFile hijack test case

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

add QSidebar test

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

effectively revert c3c697ea5b4e141f08c4607955f085c49667b806

it being static means its destruction will be delayed until exit and it
holds shared data references the meta types of which may be unregistered by
the time it is destroyed

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

use patternForFont() in getFcPattern() and rename getFcPattern()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

fix regression since 81cc2609442d5ee1e445040d9863e2538904a7f7

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

build fix for the case when QT_NO_TEMPORARYFILE is defined

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QT_NO_WIZARD config option is no longer broken

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

adjust expected result in QFontDatabase test case

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

query all fonts to get the styles for font family from QFontDatabase::styles()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

check if qt_x11Data pointer is valid before using its members from QFontDatabase

qt_x11Data pointer is valid only if QApplication instance is created, fixes
possible crashes

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove now unused QFontFamily struct

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

compiler warning fix

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

plug QFontDatabase memory leak

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

compiler warning fix

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QFontDatabase review

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

query fontconfig directly from QFontDatabase

since fontconfig has its own cache mainting internal QFontDatabase cache
is kinda redundant, have to leak check still but font tests pass

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

inline qt_pixelSize() function

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

scale the fontconfig weight value to QFont::Weight in QFontDatabase

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove compat QFontDatabase methods

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

de-duplicate QFontDatabase code

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

add case-sensitivity test for QFontDatabase

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

de-duplicate QFontDatabase code

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

const-ify QFontDatabase::styleString() methods

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

test case for converting QFont from and to QString

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

add config file for testing X 16 bit depth support

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

update comment in QVariant test data

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

zero-copy QX11Data::copyXImageToQImage() for some cases

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QX11Data::copyXImageToQImage() optimization

the cake is a lie - even tho XGetPixel() and XPutPixel() take ulong as
pixel value it has to converted manually to value appropriate for the
XImage depth

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

Merge branch 'master' of https://scm.osdn.net/gitroot/kde/Katie

special-case QImage::Format_RGB16 with different bytes per line

for some reason on Debian XImage with depth equal to 16 can have different
bytes per line (off by 2 bits), on Arch it was not a thing when I tested
it so it could be a bug in X

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove QTextDecoder and QTextEncoder leftovers

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

convert the SVG image to QImage::Format_ARGB32_Premultiplied only if it is not in format with alpha channel

since it is painting of image (not painting to image) the performance
impact of it not being QImage::Format_ARGB32_Premultiplied is neglectable

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

drop noop SVG quality implementation

altought it would be pretty easy to implement it seems to be in somewhat
unsupported state anyway, for reference:
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/shape-rendering
https://developer.mozilla.org/en-US/docs/Web/CSS/image-rendering

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove redundant QCompleter::event() reimplementation

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused QPdf::generateLinearGradientShader() method

USE_NATIVE_GRADIENTS is never defined

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused QFontSubset::toTruetype() method

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

correct logic in isStyleMatch() function

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

load the application font as last resort instead of adding it to each patterns

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove now bogus QFont test

italic/oblique are handled as enum (QFont::Style) and hint for fontconfig
what kind of slant to match (if style name is not specified that is) which
means exact style match or nothing. trying to substitute, mix and match
such style names in QFontDatabase was bad idea to begin with (not my idea)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

do not add the last resort font to the pattern when loading font

the default QApplication font is the last resort font

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

minor QFont documentation review

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

do not add fonts with empty style to the database

Source Code Variable font has such entries for example

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

query and set font pixel size from QFontDatabase

note that font pixel size is DPI-scaled, it being -1 means scale it to the
DPI of the paint device for example and Katie supports only scalable fonts
for a reason

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

preperations to drop QFontInfo

since I do not care about qt compat only normal and regular style
names are matched as equal, for now

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

resolve family aliases from QFontDatabase methods

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

fix font style matching in QFontDatabase::font() and test case it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

set the pitch of the font from QFontDatabase::font()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

export qt_getClipRects() only for the QRegion test

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

move qt_getClipRects() function to qregion source file, where it belongs

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

lock before accessing the custom meta types global static in QMetaType::type()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

Revert "always allocate QGlyphLayout data on the heap"

will have to wait until the QTextEngine redo

This reverts commit 4a5239046adeb78397c868074fe48d595fcb8fa4.

always allocate QGlyphLayout data on the heap

much easier to calculate the glyph array data size and also no
possibility for stack corruption

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

add thread-safety test for QFontDatabase

it basically tests fontconfig thread-safety but QFontDatabase is documented
as thread-safe (as it should be) so why not add test case for it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QFontDatabase test review

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

do not assume FcObjectSetCreate(), FcPatternCreate() and FcFontList() return non-null pointers in QFontDatabase constructor

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

replace hardcoded QFont::Unstretched value with the enum

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

assume the codec MIB is in the table in QTextCodec::mibEnum() and add test for it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused headers inclusions in qfont source file

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

use the QPixmap::scaled() method in QMoviePrivate::next()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

use QVector for the QMetaMethod list in qInvokeTestMethods() function

operator new may throw if the method count is zero, a test case should have
atleast one method tho

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

move QTextConverter::ConversionFlag documentation bellow QTextConverter documentation

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

move constructor and destructor to the top in qfontdatabase source file

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

read PNG rows directly into QImage allocated memory

KAT format is still faster, benchmark result:
********* Start testing of tst_QImageReader *********
Config: Using QTest library 4.12.0, Katie 4.12.0
PASS  : tst_QImageReader::initTestCase()
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.kat":
     449,473.586 CPU ticks per iteration (total: 224,736,793, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.kat":
     12,192,500.92 CPU ticks per iteration (total: 6,096,250,460, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.kat":
     4,553,239.292 CPU ticks per iteration (total: 2,276,619,646, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.png":
     1,847,145.64 CPU ticks per iteration (total: 923,572,823, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.png":
     19,422,744.28 CPU ticks per iteration (total: 9,711,372,141, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.png":
     12,389,194.51 CPU ticks per iteration (total: 6,194,597,257, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.ppm":
     653,286.280 CPU ticks per iteration (total: 326,643,140, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.ppm":
     2,728,198.060 CPU ticks per iteration (total: 1,364,099,030, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.ppm":
     2,455,954.036 CPU ticks per iteration (total: 1,227,977,018, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.svg":
     10,524,974.96 CPU ticks per iteration (total: 5,262,487,482, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.xpm":
     8,238,501.942 CPU ticks per iteration (total: 4,119,250,971, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.xpm":
     74,886,112.602 CPU ticks per iteration (total: 37,443,056,301, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.xpm":
     63,337,570.664 CPU ticks per iteration (total: 31,668,785,332, iterations: 500)
PASS  : tst_QImageReader::readImage()
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.kat":
     1,950,330.16 CPU ticks per iteration (total: 975,165,082, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.kat":
     13,089,959.61 CPU ticks per iteration (total: 6,544,979,808, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.kat":
     5,447,284.922 CPU ticks per iteration (total: 2,723,642,461, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.png":
     3,342,337.962 CPU ticks per iteration (total: 1,671,168,981, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.png":
     20,326,863.998 CPU ticks per iteration (total: 10,163,431,999, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.png":
     13,279,201.09 CPU ticks per iteration (total: 6,639,600,546, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.ppm":
     1,498,119.28 CPU ticks per iteration (total: 749,059,644, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.ppm":
     3,641,910.638 CPU ticks per iteration (total: 1,820,955,319, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.ppm":
     3,370,265.894 CPU ticks per iteration (total: 1,685,132,947, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.svg":
     9,147,455.174 CPU ticks per iteration (total: 4,573,727,587, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.xpm":
     9,729,368.638 CPU ticks per iteration (total: 4,864,684,319, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.xpm":
     75,966,954.086 CPU ticks per iteration (total: 37,983,477,043, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.xpm":
     64,719,740.840 CPU ticks per iteration (total: 32,359,870,420, iterations: 500)
PASS  : tst_QImageReader::setScaledSize()
PASS  : tst_QImageReader::cleanupTestCase()
Totals: 4 passed, 0 failed, 0 skipped
********* Finished testing of tst_QImageReader *********

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

cache system fonts on per QFontDatabase object basis

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

drop support for registering custom QVariantAnimation interpolators

even the declarative component inherit and use internal animation classes
methods for interpolation, if anything there should be more interpolators
(e.g. for QVariant::LongLong and QVariant::ULongLong)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

qconfig header update

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused QErrorMessage class

Katana uses KMessageBox or system notifcations for such things

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

do not store the hinting flags in QFontEngineFT

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>